[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26430|0                           |1
        is obsolete|                            |

--- Comment #19 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 26499
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26499&action=edit
[SIGNED OFF] Bug 11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- removed GetItemsLocationInfo()
- added sort_by input param to GetItemsInfo()
- VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call
  with GetItemsInfo() call, passing order_by "cn_sort"

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

Revised Test Plan
-----------------
NOTE: The ()'s are for my note taking and related to the "blocks"
      in the diff. Don't worry if they don't make sense.
1) perldoc C4::Items (Items2)
2) perldoc C4::XSLT (XSLT1)
3) Log into staff client (Item1)
4) Change OPACXSLTDetailsDisplay and
          OPACXSLTResultsDisplay
    'OPAC' system preferences to 'default'.
5) Change the 'hidelostitems' to "Don't Show".
6) Clear XSLTResultsDisplay and
         XSLTDetailsDisplay
    'Staff client' system preferences.
7) Search catalog for a biblio.
   Preferrably with - one lost,
    one hidden (via OpacHiddenItems system preference),
    one checked out (Search6,8,9,10,11)
8) Click biblio title in results. (Item3,4B,5 ; catalogue/detail 1)
9) Change XSLTResultsDisplay and
          XSLTDetailsDisplay
    'Staff client' system preferences to 'default'.
10) Search catalog for a biblio (Search12; XSLT2,3,4,5)
11) Click biblio title in results.
12) Home -> Lists
13) Add a '+ New list'
14) Add a barcode for the biblio used in step 7
     to the list (Items 4A ; Search 13,14B)
15) Search catalog for the same biblio in OPAC. (Items 7)
16) Click biblio title in results (opac-detail 1)
17) Click 'browse shelf' link in one of the items
18) Click the 'Lists' button in the search bar area and select
     a list (14A).
19) Run the QA test tool
20) Play with the visibility of items (hidelostitems, OpacHiddenItems)

The display should stay the same before and after patch. The
speed should increase though.

The revised test plan should trigger every code block and
every case in an if/else condition.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.