[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 24 16:14:26 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #29 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #28)

> >    FAIL	  valid
> > 		Useless use of private variable in void context 

IMO

   126: my %row = %{ $order, $line };

was actually a little better ;), being equivalent of:

   my %row = %$line;

and it tested just fine in that form ("Useles use: " warning aside). Looks like
merging %$line with %order is 100% redundant (%$line is allways the superset of
%$order).

> >     152 supplierid       => $details->{'supplierid'},
> Fixed.

Not fully yet - vendor link still doesn't work; there is no 'supplierid' key in
$details->{}, we have 'booksellerid' instead.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list