[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 26589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26589&action=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

This patch makes CanBookBeReserved and CanItemBeReserved to return a
another variable, a hashref that describes why it cannot be reserved.
It changes all calls to these functions and removes code in Perl scripts
that is not needed anymore.

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
----------
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.