[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

--- Comment #82 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #70)
> (In reply to M. Tompsett from comment #69)
> > > 7) It would be great to pass a hashref to get_opac_news
> > 
> > I don't see the number of parameters on get_opac_news growing past 3. Once
> > you hit that fourth parameter, that seems like the point in time to consider
> > making the parameter a hashref.
> 
> In my opinion, the trigger is when we have a call with undef:
> +    my ( $opac_news_count, $opac_news ) = &get_opac_news( undef, $lang,
> $branchcode );
> 
> It is not blocker for my QA point of view. Maybe for the RM point of view.

Perhaps the problem isn't undef, but rather it probably should be 0, even
though it isn't used.

-- 
You are receiving this mail because:
You are watching all bug changes.