[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 26 18:21:17 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26597|0                           |1
        is obsolete|                            |

--- Comment #90 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 26608
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26608&action=edit
[NEEDS SIGN OFF] Bug 7567 - Too many parameters and tiny bugs

Changed the add and update functions to use a hash reference
for the parameter, so that adding or subtracting parameters
should be easier. Added some POD for the add_opac_news and
upd_opac_news functions, so that developers would know how to
call it.

The hashref changes resulted in being able to return 0 for
failure and 1 for success. This meant adding a couple tests
to the test file.

And while testing, there was some sort of logic problem with
the matter of '' being all, but selecting all only showed
things set for all, and excluded particular languages, or other
interfaces.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list