[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
A few additional thoughts...

1)
A follow-up should probably be added for a few other OPAC scripts like
opac-basket.pl, opac-sendbasket.pl, opac-sendshelf.pl, etc., since these will
all show the unfiltered MARC record.


2)
It would be nice to see a future version of this that filters for both the OPAC
and the staff client. 

Passing a "context" in and checking the 'hidden' values against a hashref of
hashrefs might be a quick way of doing that:

my $display = {
            opac => {
                0 => 1,
                -1 => 1,
                -2 => 1,
                -3 => 1,
                -4 => 1,
                -5 => 1,
                -6 => 1,
                -7 => 1, 
            },
            intranet => {
                -6 => 1,
                -5 => 1,
                -1 => 1,
                0 => 1,
                1 => 1,
                4 => 1,
                6 => 1,
                7 => 1,  
            },
        };

3) I've added a few notes in Splinter Review for ways I think that the filter
sub could be improved. Since this has already passed QA, I'll just leave them
as notes.

If it's too late to make changes, I'll probably send a patch with some of them
after it's pushed in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.