[Koha-bugs] [Bug 9016] Multi transport types for notices

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 27 15:06:54 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

--- Comment #107 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Follow-up QA Comment:
Good/promising feature. Looks good, but with some comments:

1) This patch series provides some groundwork for subsequent changes in
follow-up reports.
This means that not everything this patch seems to offer now, is actually used.
For instance, you can edit sms notices now or click phone in overdue rules, but
this will not produce any results.
Given that I am told that these changes are still coming in the follow-up
reports, this should just be considered as temporary confusion.
I note however that marking these options as not-in-use-yet (somehow..) and
releasing them further on in the process would have had my (personal)
preference. 

2) At the last transport_type of tools/letter.pl a counter is displayed like:
Message body: 11/160.
It was not evident at the start for me that it meant 11 chars from max 160.
No blocker, but could be improved later?

3) When adding a new notice the first time, I was forced to add subject and
contents for each transport type (Which I did not really like).
BUT then I tried to reproduce this once again, and I couldn't. (Caching
problem?)
So no blocker.
But I discovered one small thing: If I enter code and name on the top, and do
not fill anything further. The program seems to accept that and save, but
actually it just ignores what I typed. Maybe we should catch that situation. No
blocker btw.
And another more annoying one (maybe more theoretical indeed): Fill in code,
name and the SECOND mtt. Now it will save one letter (including the name). But
it will not pickup the name again when editing this notice. (One of the last
patches dealt with something similar.) 

4) In this report overdue notices are still handled by transport type email
only.
The commit message in one of the patches suggests otherwise.
As I understand, the next patch series (10832) takes care of it.

5) On Overdue rules, I can enter a delay value and select a notice without
selecting a transport type. The action is saved, but reads to me that Koha will
not do anything with it. Should we warn the user here? 
No blocker for now. But could be improved.

6) From a commit message: "if you insert a new line in your
message_transport_types table, the overdues configuration table did not
displayed an header."
How would you add such a type? Just via sql? I understood that the interface
will not offer such a functionality.
I think that it is great that the interface immediately shows me overdue rules
and notices for the new type. But on the other hand, we could discuss how
sensible it really is to do so. No blocker, but an interesting discussion :)

7) Just noting that tools/overduerules.pl contains sql code and you also add
some. (Admin scripts are marked as an exception...)

Changed tests pass. No complaints from qa tools.
I am inclined to pass QA, but do you have a quick fix for some of the stuff
under point 3?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list