From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:28:33 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #12 from Katrin Fischer --- Created attachment 27822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27822&action=edit [SIGNED OFF] Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. Signed-off-by: Katrin Fischer Tested with rental lines created before and after applying the patch. After applying the patch it's better, but old lines will still look ok. There is still a double up on the title on the 'pay' tab, as we get the title from the itemnumber and also display the description. I think getting all the information from the itemnumber for display would be a bit nicer in the future. Butthis is an improvement. Passes tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:28:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:28:36 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #13 from Katrin Fischer --- Created attachment 27823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27823&action=edit [SIGNED OFF] Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:28:39 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #14 from Katrin Fischer --- Created attachment 27824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27824&action=edit Bug 11573: Follow-up: Include changes in OPAC templates Patch adds changes from earlier patches to OPAC prog and bootstrap templates. Patch radds a description for FU - Accrued fine. Removes a stray space before the comma, using some TT magic. To test: - Test like the other patch, display in OPAC prog, OPAC bootstrap, Staff Pay fines tab and Staff Accounts tab should be the same. - No ' , ' should be seen. - FU fines should now display a description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:36:27 +0000 Subject: [Koha-bugs] [Bug 12166] New: Improve display of Reserve charges in patron account Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Bug ID: 12166 Summary: Improve display of Reserve charges in patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Right now, a reserve charge will display in OPAC and staff like this: Res, Reserve Charge - Administrative sanctions in the European Union / Res is the accounttype, which should be resolved into a description - Hold fee. Reserve Charge should no longer be saved to the database, description should only have the title. Ideally, existing Reserve charge entries should be cleaned up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:37:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:37:01 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12166 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:37:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:37:01 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11573 Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 22:49:35 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #15 from Katrin Fischer --- Wajasu, I am not sure about your patch, as there are some problems with, would you mind going step by step? We could also check then that the other codes are still in use and have test plans for each. I haven't moved your patch to another bug yet, but happy to do so if you want me to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 01:23:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 23:23:49 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- Why should a reserve charge not be saved to the database? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 01:28:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 23:28:44 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 --- Comment #2 from Liz Rea --- Never mind, you mean the text, not the charge itself. As you were. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 02:06:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 00:06:37 +0000 Subject: [Koha-bugs] [Bug 12167] New: datetime type casting issue regarding bug 7567 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 Bug ID: 12167 Summary: datetime type casting issue regarding bug 7567 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org I just upgraded the mysql server on our live and test systems running Ubuntu, and bug 7567 stopped displaying news in the staff client. I was able to track it down to a type casting issue. A patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 02:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 00:07:02 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7567 Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 02:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 00:07:02 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 04:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 02:17:22 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #9 from Nicholas van Oudtshoorn --- Ping on this. Anybody interested in signing this one off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:17:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:17:08 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #1 from M. Tompsett --- Created attachment 27825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27825&action=edit Bug 12167 - Correct faulty test logic GetNewsToDisplay returns a reference to an array of hashes. Of course the hash >= 2. This patch properly checks the scalar size of the array. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t -- should "work" 2) apply the patch 3) prove -v t/db_dependent/NewsChannels.t -- should "fail" This is in preparation for the next patch. NOTE: I believe this may only work under Ubuntu 12.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:17:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:17:13 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #2 from M. Tompsett --- Created attachment 27826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27826&action=edit Bug 12167 - Patch disappearing news problem This doesn't duplicate on Debian, but it does under Ubuntu. TEST PLAN --------- 1) Update your git master to current. 2) Log into your staff client. 3) The news may have disappeared. -- Make sure to have news entered. The problem portion is the timestamp and date+1 logic don't seem to function properly. 4) Apply the first patch. 5) prove -v t/db_dependent/NewsChannels.t -- It should "fail". 6) Apply the second patch. 7) The news should reappear. -- There is no apparent change under Debian. 8) prove -v t/db_dependent/NewsChannels.t -- It should now "work". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:29:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:29:07 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:34:22 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- (In reply to M. Tompsett from comment #10) > I'm curious about the time queued date vs. now(). What if there is a cross > midnight situation? Can such a situation happen? I figure if some branches > are 12 timezones away from other branchs, it may. The timezone that matters is the timezone the database server is in, that is the one doing the NOW() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:39:08 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22762|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 27827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27827&action=edit Bug 11209: Don't sent the same message for the same user the same day For PREDUE messages, one message is sent to the message_queue table for each items in advanced. So the patron will receive the same message. The sms part for DUE and PREDUE should not contain dynamic parts, only a standard message. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:39:22 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:39:26 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23255|0 |1 is obsolete| | --- Comment #14 from Chris Cormack --- Created attachment 27828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27828&action=edit Bug 11209: Check if a notice has been already sent today The previous patch checks if a notice has already been sent when the current notices has been sent in queue. Which is wrong! We have to check if a similar notice has been sent today. This patch has been created after an observation on a production server: If a user place on holds several items, he will receive 1 SMS per hold. Here we only want 1 SMS for all holds. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 03:39:31 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #32 from David Cook --- (In reply to Jesse Weaver from comment #30) > (In reply to Jesse Weaver from comment #29) > > Created attachment 27761 [details] [review] [review] > > Bug 11559 - QA followup: Change path to humanmsg, fix XSLT error > > ... The commit message for this is a bit of an overstatement, this does not > in fact fix the bug David reported. Which browser did you notice this bug > on, though, David? The only places I can see where it should occur are IE < > 9. I noticed in Chrome on Windows. I'll have to take another look sometime to see how I go now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 08:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 06:20:58 +0000 Subject: [Koha-bugs] [Bug 12012] Updating Zebra config files for debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9612 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 08:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 06:20:58 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12012 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 08:50:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 06:50:37 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 --- Comment #33 from M. de Rooy --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:04:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:04:34 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from M. de Rooy --- QA Comment: You add a routine GetReserve to C4/Reserves.pm This is used only in C4/ILSDI/Services.pm. The returned hashref is used to check for the existence of the reserves record and to verify the borrowernumber. It seems that you could use GetReserveInfo to do exactly the same job. This would prevent changing the Reserves module, the need of a unit test, etc. So less maintenance. The only very small overhead is the join of a few tables there; imo not too high. Could you please adjust/simplify? Thanks. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:07:46 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #15 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:20:35 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #263 from Jonathan Druart --- Created attachment 27829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27829&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:20:41 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #264 from Jonathan Druart --- Created attachment 27830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27830&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:20:47 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #265 from Jonathan Druart --- Created attachment 27831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27831&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:20:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #266 from Jonathan Druart --- Created attachment 27832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27832&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:20:57 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #267 from Jonathan Druart --- Created attachment 27833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27833&action=edit Bug 7180: The default quantity is 1 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #268 from Jonathan Druart --- Created attachment 27834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27834&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:09 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #269 from Jonathan Druart --- Created attachment 27835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27835&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:16 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #270 from Jonathan Druart --- Created attachment 27836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27836&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:21 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #271 from Jonathan Druart --- Created attachment 27837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27837&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:26 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #272 from Jonathan Druart --- Created attachment 27838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27838&action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:33 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #273 from Jonathan Druart --- Created attachment 27839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27839&action=edit Bug 7180 - QA Followup - Correct minor language issues Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:38 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #274 from Jonathan Druart --- Created attachment 27840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27840&action=edit Bug 7180: Restore the "Add order" link Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:43 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #275 from Jonathan Druart --- Created attachment 27841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27841&action=edit Bug 7180: Remove useless rrp variable Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:48 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #276 from Jonathan Druart --- Created attachment 27842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27842&action=edit Bug 7180: FIX: discount was divided by 100 twice. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:21:56 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #277 from Jonathan Druart --- Created attachment 27843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27843&action=edit Bug 7180: fetch_sort_dropbox.pl is not in use anymore Test plan: git grep fetch_sort_dropbox should return no result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:22:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #278 from Jonathan Druart --- Created attachment 27844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27844&action=edit Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:22:11 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #279 from Jonathan Druart --- Created attachment 27845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27845&action=edit Bug 7180: QA followup 3 1/ showmarc.pl takes the importid for staged files. 2/ small note to indicate that the vendor's discount will be used if no discount is filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:22:18 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #280 from Jonathan Druart --- Created attachment 27846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27846&action=edit Bug 7180: Reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:22:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #281 from Jonathan Druart --- Created attachment 27847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27847&action=edit Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:23:05 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #282 from Jonathan Druart --- Last patches fix conflicts with bug 12089 and bug 12138. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:24:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:24:06 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27561|0 |1 is obsolete| | Attachment #27562|0 |1 is obsolete| | Attachment #27563|0 |1 is obsolete| | Attachment #27564|0 |1 is obsolete| | Attachment #27565|0 |1 is obsolete| | Attachment #27566|0 |1 is obsolete| | Attachment #27567|0 |1 is obsolete| | Attachment #27568|0 |1 is obsolete| | Attachment #27569|0 |1 is obsolete| | Attachment #27570|0 |1 is obsolete| | Attachment #27571|0 |1 is obsolete| | Attachment #27572|0 |1 is obsolete| | Attachment #27573|0 |1 is obsolete| | Attachment #27574|0 |1 is obsolete| | Attachment #27575|0 |1 is obsolete| | Attachment #27576|0 |1 is obsolete| | Attachment #27577|0 |1 is obsolete| | Attachment #27578|0 |1 is obsolete| | Attachment #27846|0 |1 is obsolete| | Attachment #27847|0 |1 is obsolete| | --- Comment #283 from Jonathan Druart --- Created attachment 27848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27848&action=edit Bug 7180: Reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:38:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:38:18 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #16 from M. de Rooy --- Just an observation (no big deal): If I have enabled email and sms for a patron, but I have no email address and the SMS driver should fail, I have two messages in the queue that fall back to PREDUE print. In this case you will have print duplicates. (Two runs now create four PREDUE prints.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:45:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:45:28 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #17 from M. de Rooy --- Similarly, if I clear the SMS number, sms messages will be sent to the queue each time in status pending. They will fail only if process cronjob has been run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 07:49:58 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #18 from Katrin Fischer --- It sounds to me like it would make sense not to try and create the message if the sms number is not sent or make sure to only have one printed mail for a fallback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:02:07 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27829|0 |1 is obsolete| | Attachment #27830|0 |1 is obsolete| | Attachment #27831|0 |1 is obsolete| | Attachment #27832|0 |1 is obsolete| | Attachment #27833|0 |1 is obsolete| | Attachment #27834|0 |1 is obsolete| | Attachment #27835|0 |1 is obsolete| | Attachment #27836|0 |1 is obsolete| | Attachment #27837|0 |1 is obsolete| | Attachment #27838|0 |1 is obsolete| | Attachment #27839|0 |1 is obsolete| | Attachment #27840|0 |1 is obsolete| | Attachment #27841|0 |1 is obsolete| | Attachment #27842|0 |1 is obsolete| | Attachment #27843|0 |1 is obsolete| | Attachment #27844|0 |1 is obsolete| | Attachment #27845|0 |1 is obsolete| | Attachment #27848|0 |1 is obsolete| | --- Comment #284 from Jonathan Druart --- Created attachment 27849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27849&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:02:16 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #285 from Jonathan Druart --- Created attachment 27850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27850&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:02:25 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #286 from Jonathan Druart --- Created attachment 27851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27851&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:02:58 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #287 from Jonathan Druart --- Created attachment 27852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27852&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:03:09 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #288 from Jonathan Druart --- Created attachment 27853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27853&action=edit Bug 7180: The default quantity is 1 Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:03:29 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #289 from Jonathan Druart --- Created attachment 27854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27854&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:03:32 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #19 from M. de Rooy --- I have some doubts on this patch: It could block lots of sms messages. You write: The sms part for DUE and PREDUE should not contain dynamic parts, only a standard message. But how do you prevent that (maybe apart from truncating the message to 160 chars)? If a message for a hold or a due does not contain a reference to the title, is it still useful for a patron at all? I could imagine that you send one message for dues at cronjob time, but what about Hold filled? Wouldn't that be a candidate for sending more messages if applicable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:03:39 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #290 from Jonathan Druart --- Created attachment 27855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27855&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:03:56 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #291 from Jonathan Druart --- Created attachment 27856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27856&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:04:07 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #292 from Jonathan Druart --- Created attachment 27857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27857&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:04:16 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #293 from Jonathan Druart --- Created attachment 27858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27858&action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:04:35 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #294 from Jonathan Druart --- Created attachment 27859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27859&action=edit Bug 7180 - QA Followup - Correct minor language issues Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:04:48 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #295 from Jonathan Druart --- Created attachment 27860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27860&action=edit Bug 7180: Restore the "Add order" link Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:05:05 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #296 from Jonathan Druart --- Created attachment 27861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27861&action=edit Bug 7180: Remove useless rrp variable Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:05:17 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #297 from Jonathan Druart --- Created attachment 27862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27862&action=edit Bug 7180: FIX: discount was divided by 100 twice. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:05:25 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #298 from Jonathan Druart --- Created attachment 27863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27863&action=edit Bug 7180: fetch_sort_dropbox.pl is not in use anymore Test plan: git grep fetch_sort_dropbox should return no result. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:05:42 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #299 from Jonathan Druart --- Created attachment 27864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27864&action=edit Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:05:58 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #300 from Jonathan Druart --- Created attachment 27865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27865&action=edit Bug 7180: QA followup 3 1/ showmarc.pl takes the importid for staged files. 2/ small note to indicate that the vendor's discount will be used if no discount is filled. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:06:25 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #301 from Jonathan Druart --- Created attachment 27866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27866&action=edit Bug 7180: Reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. Signed-off-by: Katrin Fischer Testing notes are on the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:07:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:07:42 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #302 from Jonathan Druart --- I reuploaded patches from my local branch, so without the Katrin's SO. Last patch set contains the SO! Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:25:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 08:25:42 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #20 from Jonathan Druart --- (In reply to M. de Rooy from comment #16) > If I have enabled email and sms for a patron, but I have no email address > and the SMS driver should fail, I have two messages in the queue that fall > back to PREDUE print. In this case you will have print duplicates. (Two runs > now create four PREDUE prints.) This has already been raised by Olli, he opened a report, bug 11561. (In reply to M. de Rooy from comment #17) > Similarly, if I clear the SMS number, sms messages will be sent to the queue > each time in status pending. They will fail only if process cronjob has been > run. Yes, a test could be added somewhere. But it should not append (yes you can via the UI, but it is a configuration issue). (In reply to M. de Rooy from comment #19) > I have some doubts on this patch: > It could block lots of sms messages. You write: The sms part for DUE and > PREDUE should not contain dynamic parts, only a > standard message. But how do you prevent that (maybe apart from truncating > the message to 160 chars)? > If a message for a hold or a due does not contain a reference to the title, > is it still useful for a patron at all? I could imagine that you send one > message for dues at cronjob time, but what about Hold filled? Wouldn't that > be a candidate for sending more messages if applicable? Maybe could I add a condition in the sql query like " AND content = $message->{content}". Like that, if the template contains dynamic parts, that won't match. What do you think about that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:07:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:07:38 +0000 Subject: [Koha-bugs] [Bug 12168] New: Spent and ordered budget values are wrong if deep > 2 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Bug ID: 12168 Summary: Spent and ordered budget values are wrong if deep > 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org A really weird (and old) code process the calculation for the spent and ordered sublevel funds. It only takes into account the direct children. So if you have: fund1 (spent=100) parent of fund11 (spent=10) parent of fund111 (spent=1), you get: fund | base-level | total spent fund1 | 100 | 110 fund11 ?| 10 | 11 fund111 | 1 | 1 which is wrong, it should be fund | base-level | total spent fund1 | 100 | 111 fund11 | 10 | 11 fund111 | 1 | 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:08:11 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:08:40 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12164 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:08:40 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:08:48 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on|12168 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:08:48 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12164 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:09:08 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12164 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:09:08 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:30:57 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:31:00 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 --- Comment #1 from Jonathan Druart --- Created attachment 27867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27867&action=edit Bug 12168: Spent and ordered budget values are wrong if deep > 2 A really weird (and old) code process the calculation for the spent and ordered sublevel funds. It only takes into account the direct children. So if you have: fund1 (spent=100) parent of fund11 (spent=10) parent of fund111 (spent=1), you get: fund | base-level | total spent fund1 | 100 | 110 fund11 | 10 | 11 fund111 | 1 | 1 which is wrong, it should be fund | base-level | total spent fund1 | 100 | 111 fund11 | 10 | 11 fund111 | 1 | 1 Test plan: - Create 1 budget and 3 funds with the same structure as above. - Create some orders and receive them (not all). - Go on the fund list view and verify the values are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:31:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 12:31:06 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 --- Comment #2 from Jonathan Druart --- Created attachment 27868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27868&action=edit Bug 12168: Add unit tests for GetBudgetHierarchySpent GetBudgetHierarchyOrdered Test plan: prove t/db_dependent/Budgets.t Note: This addition may sound overkill but I found this bug developping bug 12164 and I will reuse all of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:13:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:13:48 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25573|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 27869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27869&action=edit [SIGNED-OFF] Bug 11826: Add XSLT handler object to Koha namespace In achieving the goals of umbrella report 6536 (Z3950 improvements), this report adds a XSLT handler object to the Koha namespace. A follow-up adds unit tests for this module. This patch does not yet incorporate the new object into Z3950 search. So it does not change any behavior and is therefore harder to test. Test plan: Run the unit tests of the follow-up patch on report 11826. Signed-off-by: Marcel de Rooy I tested the new module in two additional ways: [1] Made a simple script (four lines as below) that ran a larger xml file with 1500 records through a test XSLT file modifying the title. my $eng= Koha::XSLT_Handler->new; open my $fh1, '<', '_example_file'; my @xml= <$fh1>; print $eng->transform( join('', @xml), '_example_xsl_file'); [2] Incorporated the object into my local changes of Breeding.pm (based on older work, not ready for submittal now). Ran transformation on Z3950 search results. Worked well :) Signed-off-by: Bernardo Gonzalez Kriegel Test runs Ok. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:13:56 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25574|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 27870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27870&action=edit [SIGNED-OFF] Bug 11826: Add unit tests for Koha::XSLT_Handler Test plan: Verify if XSLT_Handler.t passes. You could also sabotage the test by removing one of the test xsl files. Or you could 'repair' the bad xsl file (test02). Remove the second line redefining the xsl variable. In all those cases the unit test should fail now.. Discard your changes :) Signed-off-by: Bernardo Gonzalez Kriegel Test pass. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:14:05 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27229|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 27871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27871&action=edit [SIGNED-OFF] Bug 11826: Using the XSLT handler in C4/XSLT module Incorporate the new object into C4/XSLT module. The handler object needed one adjustment to allow for passing URLs. Removed the GetURI function; it is no longer needed. Added some documentation lines. Moved a file-level lexical upwards in the code for visibility. Removed some tabs (on two lines). Note: The handler could perhaps be moved up to the Context module, or be saved in a global ('our') variable. But I would rather not do that now, making testing not too complex at this moment. Test plan: Enable XSLT preferences for opac and intranet. Check result and detail pages. Check individual list display (virtual shelves). Force an XSLT error by editing one of your xsl files. Check the corresponding display. Put an URL in one the XSLT prefs (could just be to your own server). Check the display. Signed-off-by: Marcel de Rooy Running XSLTParse4Display in a loop showed no significant performance change. One pass cost me around 0.012 sec (except for the first pass). Signed-off-by: Bernardo Gonzalez Kriegel Results, detail, url and list view Ok No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:14:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:14:13 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27230|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 27872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27872&action=edit [SIGNED-OFF] Bug 11826: Use xslt handler object in showmarc, Record.pm Modifies showmarc and opac-showmarc to use new xslt handler. Removes cardview.pl as obsolete script. Modifies C4/Record.pm and a typo in the test Record.t. Test plan: [1] catalogue/showmarc: Go to Cataloging. Search. Click Card. [2] opac-showmarc: Go to opac detail, MARC view. Open URL for plain view in new tab. Change URL: Change viewas=html to viewas=card [3] Verify that there are no references in the codebase to cardview.pl [4] C4/Record.pm: Run the Record.t test in db_dependent. This test uses marc2modsxml, triggering the change. Additional: export to MODS from opac-detail. Signed-off-by: Bernardo Gonzalez Kriegel Views Ok. Test pass. No more cardview. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:14:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:14:35 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:31:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:31:25 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from M. de Rooy --- I'm seeing this code in the Itiva cronjob: my $letter = C4::Letters::GetPreparedLetter( module => $module, letter_code => $code, tables => { borrowers => $issues->{'borrowernumber'}, biblio => $issues->{'biblionumber'}, biblioitems => $issues->{'biblionumber'}, message_transport_type => 'phone', }, message_transport_type => 'phone', ); The duplicated mtt seems odd to me. Is that correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:39:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:39:29 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #10 from Jonathan Druart --- (In reply to M. de Rooy from comment #9) > The duplicated mtt seems odd to me. Is that correct? No, it seems that the one introduced by bug 10845 is wrong. I will provide follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:42:03 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #11 from M. de Rooy --- Please add the bug number too in the print message of updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:43:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:43:20 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #12 from Jonathan Druart --- Created attachment 27873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27873&action=edit Bug 11867: FIX message_transport_type parameter for Itiva cronjob The message_transport_type param should passed to GetPreparedLetter, not part of the "tables" parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:43:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:43:59 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #33 from Jonathan Druart --- Created attachment 27874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27874&action=edit Bug 10845: FIX message_transport_type parameter for Itiva cronjob The message_transport_type param should passed to GetPreparedLetter, not part of the "tables" parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:44:32 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #34 from Jonathan Druart --- Last patch fixes a problem raised by Marcel in bug 11867 comment 9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:46:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:46:18 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27820|0 |1 is obsolete| | Attachment #27873|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 27875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27875&action=edit Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:46:51 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #14 from Jonathan Druart --- Patch rebased on top of bug 9016 and bug 10845. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:49:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:49:33 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27875|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 27876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27876&action=edit Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 13:50:06 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #16 from Jonathan Druart --- Last patch adds the bug number in the updatedb entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:12:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:12:09 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27868|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 27877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27877&action=edit Bug 12168: Add unit tests for GetBudgetHierarchySpent GetBudgetHierarchyOrdered Test plan: prove t/db_dependent/Budgets.t Note: This addition may sound overkill but I found this bug developping bug 12164 and I will reuse all of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:16:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:16:09 +0000 Subject: [Koha-bugs] [Bug 12169] New: Improve reliability of sip_shutdown script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Bug ID: 12169 Summary: Improve reliability of sip_shutdown script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com the sip_shutdown script rightly announces the brittleness of it approach to identifying the process to kill. A more reliable method is available by getting the server to use the standard approach of writing a pidfile which is part of Net::Server's functionality. Change script to use this and alter config scripts accordingly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:33:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:33:47 +0000 Subject: [Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 27878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27878&action=edit Proposed patch Adds options to sample config and simplifies sample shutdown script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:40:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:40:03 +0000 Subject: [Koha-bugs] [Bug 12170] New: log serial alert emails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12170 Bug ID: 12170 Summary: log serial alert emails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Would be great if the logs of messages included the emails sent to people who subscribed to a serial. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:47:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:47:22 +0000 Subject: [Koha-bugs] [Bug 12171] New: Make Quick Spine Label Creator Quicker Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12171 Bug ID: 12171 Summary: Make Quick Spine Label Creator Quicker Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org We would like to see this process have options for streamlining. Would like to see options for printing as soon as the barcode is scanned. No button clicking. Just scan, and then after printing, it clears the text box and is ready for the next barcode. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:48:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:48:18 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtompset at hotmail.com |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 14:48:55 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 17:07:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 15:07:36 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #2 from Marc V?ron --- Created attachment 27879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27879&action=edit [Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 17:08:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 15:08:11 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27821|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 17:08:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 15:08:21 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:18:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27585|0 |1 is obsolete| | --- Comment #131 from Bernardo Gonzalez Kriegel --- Created attachment 27880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27880&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel My comments on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:18:30 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27586|0 |1 is obsolete| | --- Comment #132 from Bernardo Gonzalez Kriegel --- Created attachment 27881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27881&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:18:42 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27587|0 |1 is obsolete| | --- Comment #133 from Bernardo Gonzalez Kriegel --- Created attachment 27882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27882&action=edit Bug 11944: Encoding UTF8 in C4::Templates Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:18:52 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27588|0 |1 is obsolete| | --- Comment #134 from Bernardo Gonzalez Kriegel --- Created attachment 27883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27883&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:19:02 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27589|0 |1 is obsolete| | --- Comment #135 from Bernardo Gonzalez Kriegel --- Created attachment 27884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27884&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:24:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:24:39 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #136 from Bernardo Gonzalez Kriegel --- I'm in the process of sign, but have problems to upload some patches with git-bz. I'm out for a moment, will finish soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:35:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27590|0 |1 is obsolete| | --- Comment #137 from Bernardo Gonzalez Kriegel --- Created attachment 27885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27885&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with XXX and search "XXX" Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel XXX = removed char, because of git-bz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:35:31 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27591|0 |1 is obsolete| | --- Comment #138 from Bernardo Gonzalez Kriegel --- Created attachment 27886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27886&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:35:43 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27592|0 |1 is obsolete| | --- Comment #139 from Bernardo Gonzalez Kriegel --- Created attachment 27887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27887&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:35:54 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27593|0 |1 is obsolete| | --- Comment #140 from Bernardo Gonzalez Kriegel --- Created attachment 27888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27888&action=edit Bug 11944: TT Plugins should not encode strings Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:36:06 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27594|0 |1 is obsolete| | --- Comment #141 from Bernardo Gonzalez Kriegel --- Created attachment 27889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27889&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:36:19 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27595|0 |1 is obsolete| | --- Comment #142 from Bernardo Gonzalez Kriegel --- Created attachment 27890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27890&action=edit Bug 11944: FIX Error on editing an authority Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:36:30 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27596|0 |1 is obsolete| | --- Comment #143 from Bernardo Gonzalez Kriegel --- Created attachment 27891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27891&action=edit Bug 11944: Fix encoding issue on searching The search patch should fix non-latin character searches. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:36:41 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27597|0 |1 is obsolete| | --- Comment #144 from Bernardo Gonzalez Kriegel --- Created attachment 27892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27892&action=edit Bug 11944: Facets and resort This patch should fix facets and resort encoding issues. Note: This patch will certainly break the search history Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:43:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:43:33 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27598|0 |1 is obsolete| | --- Comment #145 from Bernardo Gonzalez Kriegel --- Created attachment 27893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27893&action=edit Bug 11944: Authentication The password should be encoded before hashing. Test plan: - Before applying the patch, create a user with a password "XXXX" - apply patches - try to log in - change the password - log out - try to log in Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel replaced string with XXXX, sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:43:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:43:45 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27599|0 |1 is obsolete| | --- Comment #146 from Bernardo Gonzalez Kriegel --- Created attachment 27894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27894&action=edit Bug 11944: Fix fund names encoding on the parcel page On the parcel page, the subtotal values are stored in an hashref. The key was the fund name. The fund name being encoded in utf8, the hashref was broken. This patch replaces this logic creating a key based on an integer. The budget name is now stored in a new "budget_name" key. Note: It also fixes a small ergonomic issue (a td was missing in the tfoot). Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:44:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:44:01 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27600|0 |1 is obsolete| | --- Comment #147 from Bernardo Gonzalez Kriegel --- Created attachment 27895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27895&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:44:16 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27601|0 |1 is obsolete| | --- Comment #148 from Bernardo Gonzalez Kriegel --- Created attachment 27896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27896&action=edit Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:44:35 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27602|0 |1 is obsolete| | --- Comment #149 from Bernardo Gonzalez Kriegel --- Created attachment 27897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27897&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:49:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:49:36 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27603|0 |1 is obsolete| | --- Comment #150 from Bernardo Gonzalez Kriegel --- Created attachment 27898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27898&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see [ Trimmed text, look original patch :( ] Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Comments: No koha-qa erros, save for a FAIL on first patch for enabling utf8, and third to last patch, because it take ages and not finish :) But there are simple changes, I think there must no be a problem As with many enconding problems, some I can not reproduce, but some yes, and that are fixed For example: 1) password (no problem before or after) 2) fund (no problem before or after) 3) frecuency (no problem before or after) 4) Numbering pattern (no problem before or after) 5) List (shelfs), content, mail (bad before, fixed) 6) Cart content, mail (bad before, fixed) 7) didyoumean (no problems before or after) Works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 16:50:34 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #151 from Bernardo Gonzalez Kriegel --- Sorry, I need to rewrite some text on commit messages. But is finished -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 19:15:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 17:15:08 +0000 Subject: [Koha-bugs] [Bug 12172] New: Remote XSLT style sheets fail to fetch under https under recent LWP::Simple Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12172 Bug ID: 12172 Summary: Remote XSLT style sheets fail to fetch under https under recent LWP::Simple Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Recent versions of LWP::Simple enable 'verify_hostname' by default. This breaks https get requests in a nasty way such that any page relying upon the stylesheet results in a nasty perl error. We should be using LWP::UserAgent and setting this ignorance explicitly, or even better, setting a 'Certificate Authority' path to enable proper hostname verification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 19:15:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 17:15:28 +0000 Subject: [Koha-bugs] [Bug 12172] Remote XSLT style sheets fail to fetch under https under recent LWP::Simple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12172 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 19:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 17:36:55 +0000 Subject: [Koha-bugs] [Bug 12172] Remote XSLT style sheets fail to fetch under https under recent LWP::Simple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12172 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 19:36:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 17:36:57 +0000 Subject: [Koha-bugs] [Bug 12172] Remote XSLT style sheets fail to fetch under https under recent LWP::Simple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12172 --- Comment #1 from Martin Renvoize --- Created attachment 27899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27899&action=edit Bug 12172: Use LWP::UserAgent for remote XSLT fetch This patch re-enables proper handling of https hosted remote xslt style sheets with recent releases of LWP (libwww-perl-5.837 and prior do not need this patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 19:39:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 17:39:27 +0000 Subject: [Koha-bugs] [Bug 12172] Remote XSLT style sheets fail to fetch under https under recent LWP::Simple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12172 --- Comment #2 from Martin Renvoize --- Initial patch cleans up code a little, and swaps from LWP::Simple to LWP::UserAgent to allow for explicit declaration of ssl options. It then disables verify_hostname to do the 'get'. I could not, in my testing come up with a reasonable solution to set CA Certificate path to use with the module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 19:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 17:56:51 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #17 from M. de Rooy --- The sql construct name=(SELECT name FROM ( SELECT name FROM letter WHERE code= ... LIMIT 1) AS t) does probably not win beauty prices :) You could try something with joining letter in the update statement. But on the other hand why would you? You do not need to change the name for the Phone notices. That name should be fine. Note that the SELECT .. LIMIT 1 will not always provide the best choice; you are not even sure which one he picks. Is it an idea to remove name from the UPDATE? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 21:21:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 19:21:27 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- (In reply to paxed from comment #2) > Created attachment 27793 [details] [review] > Fix bug introduced in bug 12138, javascript formatting > > Definitely my fault. Signed off that patch. But forgot to change status :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 21:50:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 19:50:12 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27757|0 |1 is obsolete| | --- Comment #33 from Jesse Weaver --- Created attachment 27900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27900&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib (Rebased to remove lightbox and hotkeys.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 21:58:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 19:58:54 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27758|0 |1 is obsolete| | --- Comment #34 from Jesse Weaver --- Created attachment 27901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27901&action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader (That last comment actually applies to this commit, which no longer includes the lightbox and hotkeys libraries. The previous commit no longer makes changes to use XSLT.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 21:59:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 19:59:47 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27759|0 |1 is obsolete| | Attachment #27760|0 |1 is obsolete| | Attachment #27761|0 |1 is obsolete| | --- Comment #35 from Jesse Weaver --- Created attachment 27902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27902&action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste (Now includes XML fixed-field widgets, fix for humanmsg and removes dead XSLT code.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 1 22:16:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 20:16:33 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #36 from Jesse Weaver --- (In reply to Galen Charlton from comment #31) > I've marked this as a candidate for 3.16.0. > > One question: given the integration problems around pazpar2, is it possible > to spit off the pazpar2 metasearch functionality, leaving the core of the > editor as something that might make it in as an experimental feature for > 3.16.0? I have a patch ready that does exactly this ready and sitting in a branch. Wasn't quite sure where to put it, but I can rebase and post it if we end up needing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 01:19:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 23:19:36 +0000 Subject: [Koha-bugs] [Bug 12150] Use more placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- Is ready to be signed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 01:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 23:32:19 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeparator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26941|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 27903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27903&action=edit [SIGNED-OFF] Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 01:32:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 23:32:27 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeparator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26942|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 27904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27904&action=edit [SIGNED-OFF] Bug 10330 - Follow up - missed case of authoritysep $ git grep authoritysep This showed: 1) the updatedatabase.pl script, as expected, 2) lots of po files, 3) a test file that was missed. TEST PLAN --------- 1) prove -v t/db_dependent/Search.t 2) Run koha QA test tools Signed-off-by: Bernardo Gonzalez Kriegel Work (both patches). Test pass. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 01:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 May 2014 23:32:45 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeparator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 02:06:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 00:06:59 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Currently generated barcodes are images produced using GD::Barcode. It's not possible to set font size for numbers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:29:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:29:43 +0000 Subject: [Koha-bugs] [Bug 12173] New: Improving Plack support on the staff client OMNIBUS Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Bug ID: 12173 Summary: Improving Plack support on the staff client OMNIBUS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: robin at catalyst.net.nz Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org This bug will be an umbrella for all bugs related to improving Plack support on the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:01 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:01 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:16 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12023 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:16 +0000 Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:31 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:31 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12041 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:44 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:44 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9967 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:57 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:30:57 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:31:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:31:11 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:31:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:31:11 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8970 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:31:32 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:31:32 +0000 Subject: [Koha-bugs] [Bug 9048] Quote editor does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Blocks| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:03 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:05 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #1 from Jonathan Druart --- Created attachment 27905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27905&action=edit Bug 12164: Move the budget period clone logic into C4::Budgets Note the typo InsertInTable "aqcudgets", note sure about the existing behavior before this patch! This patch adds a link "Duplicate" in the action list for budget periods (budgets). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:08 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #2 from Jonathan Druart --- Created attachment 27906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27906&action=edit Bug 12164: On cloning budget period, mark original budget as inactive This patch adds a checkbox "mark original budget as inactive" (budget period). If it is checked, the original budget will be marked as inactive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:11 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #3 from Jonathan Druart --- Created attachment 27907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27907&action=edit Bug 12164: On cloning budget periods, add a "reset all funds" option This patch adds a checkbox "reset all funds" (budgets). If it is checked, the new created budgets (funds) will be reset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:16 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #4 from Jonathan Druart --- Created attachment 27908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27908&action=edit Bug 12164: Close a budget period (budget) This is the main patch. On closing a budget period, all unreceived orders are moved from the old/previous fiscal year into the new fiscal year. You can rollover funds unused in the previous fiscal year to the new fiscal year. This patch set is based on bug 12168 (bugfix) and can be tested on top of bug 11578 (easier to see the fund structure). The patch set is cut in 6 main patches: - Move the budget period clone logic into C4::Budgets The code is moved from the pl to Budgets.pm and unit tests are provided. The original code should certainly be buggy since a typo existed. - On cloning budget period, mark original budget as inactive Cloning a budget period is already possible in Koha, this patch adds a checkbox to mark as inactive the original budget. That avoids to edit the budget and click the "inactive" checkbox. Both do the same action. - On cloning budget periods, add a "reset all funds" option Same as before, a new checkbox is added on cloning a budget period. If you check it, all fund amounts will be set to 0. Otherwise, no change compared to the existing behavior. - Close a budget period (budget) The goal of this patch set is to move unreceived orders from a budget to another. This patch adds a C4::Budgets::MoveOrders routine which does this job. This action is only possible if the fund structure is the same for both budgets, the budget_code field should be the same. - On closing budget period, move unspent amount Unspent amount will be move from the previous budget structure to the new one. - Add UI report This patch only adds a report when closing a budget is done. Test plan: Wording: below, budget is a "budget period" and fund is a "budget". Prerequisite: Having 1 active budget with some funds (with different levels and different amounts). Order and receive some orders (not all). 1/ Go on the budgets administration page (admin/aqbudgetperiods.pl) and duplicate the structure of this budget ("Duplicate" link in the "Actions" column). 2/ Enter start and end date for this budget and mark the original budget as inactive. 3/ Note that a new budget is created, with the same fund structures (and same value) and that the old one is marked as inactive (see admin/aqbudgets.pl page with patches from bug 11578). 4/ Try to close the new budget: it is not possible, there is no unreceived orders for this budget. 5/ You can close the inactive budget ("Close" link in the "Actions" column). 6/ Verify the number of "Unreceived orders" is correct and select the new budget in the budget list. Click on the "Move remaining unspent funds" if you want to move unspent amounts. 7/ A report view is displayed and show you the ordernumber which have been impacted (grouped by fund). 8/ Try different configuration, depending on the selected checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:19 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #5 from Jonathan Druart --- Created attachment 27909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27909&action=edit Bug 12164: On closing budget period, move unspent amount On closing a budget (budget period), the user will be presented with an option to move remaining unspent funds from the previous budget to the newly created one - adding to the amounts already entered in those funds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:47:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:47:24 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #6 from Jonathan Druart --- Created attachment 27910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27910&action=edit Bug 12164: Add UI report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 10:54:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 08:54:22 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #7 from Jonathan Druart --- Created attachment 27911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27911&action=edit script for testing this feature To test this feature, you can use this patch to create and delete a fund structure and orders (received and unreceived). The structure will be: budget_1 (1 pending, 0 ordered) > budget_11 (3 pending, 4 ordered) >> budget_111 (2 pending, 1 ordered) > budget_12 (4 pending, 3 ordered) budget_2 (1 pending, 0 ordered) > budget_21 (0 pending, 0 ordered) 1 order is 2 items (cost: 10 each). Create the data: perl bug_12164.pl create Delete the data: perl bug_12164.pl delete Note: The delete action does *not* remove created items. Important note: Backup your database before using this script! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 11:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 09:09:55 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #8 from Jonathan Druart --- Note: To complete this feature, a CSV export should be available on the report view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 11:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 09:22:58 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 11:42:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 09:42:00 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 11:51:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 09:51:23 +0000 Subject: [Koha-bugs] [Bug 12174] New: Zotero connection with Koha: problem with UTF-8 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Bug ID: 12174 Summary: Zotero connection with Koha: problem with UTF-8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org If i donwload Koha records with Zotero from server with Koha 3.12/3.14, I have problems with UTF-8. I don't had this problem with an old 3.2 in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 11:51:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 09:51:57 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 11:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 09:52:33 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 12:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 10:11:00 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 --- Comment #1 from Zeno Tajoli --- I find the problem. It is a mix of apache / new Zotero working. 1)The bug is not present in installation that use Ngix instead of apache. 2)Zotero doesn't use only COinS from Koha but if use also the record export (../cgi-bin/koha/opac-export.pl) 3)The cgi opac-export.pl it is ok to write a file on this but not if you try to use it like a stream in Zotero. Try: curl -i 'http://pust.urbe.it/cgi-bin/koha/opac-export.pl?format=utf8&op=export&bib=71000&save=Go' The result: HTTP/1.1 200 OK Date: Fri, 02 May 2014 09:41:22 GMT Server: Apache/2.2.22 (Debian) Content-Disposition: attachment; filename="bib-71000.utf8" Transfer-Encoding: chunked Content-Type: application/octet-stream; charset=ISO-8859-1 01403nam a2200265 i 4500001000600000003000900006005001700015 [the iso2709 output] 4)The header "charset=ISO-8859-1" is the default on Apache (Ngix doesn't inser anything instead). 5)Zotero read the header and it thinks that the stream in iso2709 format is written with ISO-8859-1 charset. So the fix is to be esplict on charset when we print the result. From 94: print $query->header( 95: -type => 'application/octet-stream', 96: -attachment=>"bib-$biblionumber.$format"); To 94: print $query->header( 95: -type => 'application/octet-stream', 96: -charset=>'utf-8', 97: -attachment=>"bib-$biblionumber.$format"); I will write and send the patch soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 12:45:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 10:45:34 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #73 from Jonathan Druart --- I never used the label creator tools, but it does not seem to work for me (tested with my UNIMARC DB and with my MARC21 using the "Arabic records" in attachment). I got badly encoded characters for barcodes 50 and 51 (see attachment). Moreover, I don't really understand why the usefulness of the font list in the koha-conf file. The font list already exist in a pl, why not just put the directory path (/usr/share/fonts/truetype/ttf-dejavu)? If a font is added in the koha-conf, it won't be added to the list in the Koha interface, which is quite odd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 13:18:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 11:18:30 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #45 from Jonathan Druart --- 2 questions: 1/ Shouldn't we use this pref wherever OPACBaseURL is used? 2/ Shouldn't we put a warning in the updatedb entry? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 13:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 11:19:10 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #74 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #73) > I never used the label creator tools, but it does not seem to work for me > (tested with my UNIMARC DB and with my MARC21 using the "Arabic records" in > attachment). > > I got badly encoded characters for barcodes 50 and 51 (see attachment). I seem to be missing the attachment. Please give more description of your test procedure as well. > > Moreover, I don't really understand why the usefulness of the font list in > the koha-conf file. The font list already exist in a pl, why not just put > the directory path (/usr/share/fonts/truetype/ttf-dejavu)? If a font is > added in the koha-conf, it won't be added to the list in the Koha interface, > which is quite odd. We only support the hardcoded fonts ATM. It would be good to fix the problem of hard coding but in another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 13:46:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 11:46:25 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #46 from Katrin Fischer --- I think the problem mostly is where we try to build the URL in staff, because there you can't get the information if the OPAC is run as https. There are other options used for links in the OPAC. Maybe this could be a first step? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 14:17:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 12:17:33 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #75 from Jonathan Druart --- (In reply to Chris Nighswonger from comment #74) > I seem to be missing the attachment. Please give more description of your > test procedure as well. Yep, sorry, it's coming. I imported the record, go on "Currently Available Layouts", edit the first layout, type:"Barcode/biblio". Manage batches > new batch > add items barcode 50, 51 > Export batch > Export > Download as pdf. And I got it, see attachment (I won't forget this time!). (I updated the koha-conf.xml, of course). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 14:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 12:18:07 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #76 from Jonathan Druart --- Created attachment 27917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27917&action=edit pdf broken with barcode 50&51 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 15:42:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 13:42:47 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #78 from Jonathan Druart --- I am on it but I did not manage to retrieve record from z3950.bnf.fr, I got the following error in the koha log file: Pazpar2 init failed: No Host option provided However, in opac/svc/pazpar2_init, $target_url == "z3950.bnf.fr:2211/TOUT". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 15:49:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 13:49:01 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #79 from Jonathan Druart --- (In reply to Jonathan Druart from comment #78) > I am on it but I did not manage to retrieve record from z3950.bnf.fr, I got > the following error in the koha log file: > Pazpar2 init failed: No Host option provided > > However, in opac/svc/pazpar2_init, $target_url == "z3950.bnf.fr:2211/TOUT". I got the same for z3950.biblibre.com:9999/biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 15:52:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 13:52:32 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #80 from Jonathan Druart --- And same for lx2.loc.gov:210/LCDB It's my first try with pazpar2, it seems to be a fail... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 15:59:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 13:59:58 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #81 from Katrin Fischer --- Hm, I haven't run into that problem - we'll probably need to wait for Jesse :( Do MARC21 targets work for you? I tested with 3 active targets: LOC, SWB and BNF. The other thing that might be missing is something in the setup of PazPar2 - did you see my notes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:01:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:01:11 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #82 from Katrin Fischer --- Do you see an error when running the pazpar2 server? #start pazpar2 server $ pazpar2 -f /home/katrin/koha-dev/etc/pazpar2/pazpar2.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:05:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:05:07 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #77 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #76) > Created attachment 27917 [details] > pdf broken with barcode 50&51 With the attached records you will need to use the following fields: 245a, author, itemtype, itemcallnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:07:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:07:26 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #78 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #76) > Created attachment 27917 [details] > pdf broken with barcode 50&51 Also check to be sure your ttf config tags fall inside of the tags in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:11:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:11:23 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #83 from Jonathan Druart --- So, QA comment just looking at the code: 1/ use Modern::Perl in the opac/svc file 2/ warning "my" variable $response masks earlier declaration in same scope at /home/koha/src/opac/svc/pazpar2_init line 80 3/ Why do you create a new table and don't use the entries in z3950servers (with a new column)? 4/ Some error raised by qa tools: FAIL koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt FAIL forbidden patterns forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 276) And some otheres. You should move new js files in koha-tmpl/intranet-tmpl/lib (see bug 12119, bug 12116, etc.) 5/ For your next patch, please split it in several small ones. It is very hard to read a 249.78 KB patch :) 6/ Unit tests are missing for GetExternalSearchTargets 7/ param debug => 1 is useless in get_template_and_user calls 8/ SQL queries in .pl files should be avoided 9/ I didn't understand the new css rules for .highlight 10/ + should be checked="checked" 11/ Please squash changes in opac.css (you completely rewrite the file in the first patch). And now I understand the size of the patch :) 12/ New js lib should be added to the about page, licenses tab. I don't change the status because I didn't test, but it seems to fail QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:13:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:13:04 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #84 from Jonathan Druart --- (In reply to Katrin Fischer from comment #81) > Do MARC21 targets work for you? I tested with 3 active targets: LOC, SWB and > BNF. The other thing that might be missing is something in the setup of > PazPar2 - did you see my notes? Yes, very useful! (In reply to Katrin Fischer from comment #82) > Do you see an error when running the pazpar2 server? > #start pazpar2 server > $ pazpar2 -f /home/katrin/koha-dev/etc/pazpar2/pazpar2.xml No, nothing here (some warnings), only the startup: 16:12:01-02/05 pazpar2 [warn] Wrapper element deprecated 16:12:01-02/05 pazpar2 [log] Use .. only 16:12:01-02/05 pazpar2 [warn] Wrapper element deprecated 16:12:01-02/05 pazpar2 [log] Use .. only 16:12:01-02/05 pazpar2 [warn] Wrapper element deprecated 16:12:01-02/05 pazpar2 [log] Use .. only 16:12:01-02/05 pazpar2 [log] Pazpar2 start 1.6.41 18f2ca94b3cfb8f77ab8444b5afa1479abd00308 16:12:01-02/05 pazpar2 [log] HTTP listener @:11002 And nothing after. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:15:24 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #79 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #75) > (In reply to Chris Nighswonger from comment #74) > > I seem to be missing the attachment. Please give more description of your > > test procedure as well. > > Yep, sorry, it's coming. > I imported the record, go on "Currently Available Layouts", edit the first > layout, type:"Barcode/biblio". > Manage batches > new batch > add items barcode 50, 51 > Export batch > > Export > Download as pdf. > And I got it, see attachment (I won't forget this time!). > (I updated the koha-conf.xml, of course). Seems that you are using Times-Roman in Layout, please confirm. If that is the case, what you view is the expected result, because there are no glyphs for that chars in DejaVuSerif. Using Helvetica will give you something better, mapping HO to DejaVuSans better, and with Bug 12063 correct display (See new attached image) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:16:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:16:10 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #80 from Bernardo Gonzalez Kriegel --- Created attachment 27918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27918&action=edit Display variations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:17:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:17:45 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #81 from Bernardo Gonzalez Kriegel --- (In reply to Bernardo Gonzalez Kriegel from comment #79) > something better, mapping HO to DejaVuSans better, and with Bug 12063 Sorry, Bug 12068 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:18:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:18:08 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #82 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #79) > Seems that you are using Times-Roman in Layout, please confirm. haaa! Ok thanks. I used Times-Roman. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:19:10 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:24:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:24:45 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #85 from Katrin Fischer --- I can't check with my installation at home now, to check if the warnings show up for me as well :( I remmber seeing those and I think we fixed it, but not entirely sure. Guess we will need Jesse now - I am going to fail it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:40:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:40:14 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #83 from Jonathan Druart --- hum, weird, I got ERROR in koha-conf.xml -- missing /path/to/font.ttf at /home/koha/src/C4/Creators/PDF.pm line 123ERROR in koha-conf.xml -- missing /path/to/font.ttf at /home/koha/src/C4/Creators/PDF.pm line 123 when I select "Helvetica-Bold-Oblique". The value is correct in DB: font: HBO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:48:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:48:18 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #84 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #83) > hum, weird, I got > ERROR in koha-conf.xml -- missing /path/to/font.ttf > at /home/koha/src/C4/Creators/PDF.pm line 123ERROR in koha-conf.xml -- > missing /path/to/font.ttf at > /home/koha/src/C4/Creators/PDF.pm line 123 > > when I select "Helvetica-Bold-Oblique". > The value is correct in DB: > font: HBO Problem is that current code appends an 'O' to selected font for title C4/Labels/Label.pm:400: ($field->{'code'} eq 'title') ? (($font =~ /T/) ? ($font = 'TI') : ($font = ($font . 'O'))) : ($font = $font); If you select HBO as main font, then it would search for HBOO for title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:53:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:53:32 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #47 from M. Tompsett --- This is a first step. We fix one place, and if this is deemed sufficient, we go on to the rest. Ideally, this could be integrated into a function that will get used everywhere. Yes, it would be a good idea to put a warning: "If you use HTTPS for your OPAC, then please set OpacProtocol to 'use' in the OPAC system preferences' Policy section." However, I don't have time to add that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 16:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 14:56:49 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #21 from Jonathan Druart --- Created attachment 27919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27919&action=edit Bug 11209: A message is duplicate if its content has been already sent If the template contains dynamic parts, the message won't be considerated as duplicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 17:00:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 15:00:04 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #58 from Koha Team AMU --- I just test this part of the patch. 1/ delete_all-items : ok 2/ New test with these permissions: - edit catalogue: edit_catalogue Edit catalogue edit_items Editer les exemplaires fast_cataloging Fast cataloging edit_items_restricted Limit item modification to barcode, status and note - tools : items_batchmod Perform batch modification of items items_limited_batchmod resctricted : limit item modification to item status - sysprefs : SubfieldsToAllowForRestrictedEdition : 995$f 995$o 995$u SubfieldsToAllowForRestrictedBatchmod : 995 $o test's result : - ok : the modification of items is retricted to the subfilds definied in these 2 sysprefs. - ok : The modification of all subfields of an item of a fast cataloging is ok. The framework fast cataloging is not concerned by SubfieldsToAllowForRestrictedEdition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 17:08:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 15:08:12 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #18 from Jonathan Druart --- Created attachment 27920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27920&action=edit Bug 11867: Change the sql query in order to win beauty prices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 17:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 15:08:59 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #19 from Jonathan Druart --- (In reply to M. de Rooy from comment #17) > The sql construct > name=(SELECT name FROM ( SELECT name FROM letter WHERE code= ... LIMIT 1) > AS t) > does probably not win beauty prices :) Erk > Is it an idea to remove name from the UPDATE? The name should be the same for all letters with the same code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 18:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 16:44:22 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 18:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 16:44:32 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 18:46:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 16:46:08 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 20:37:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 18:37:15 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 20:37:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 18:37:34 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 20:37:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 18:37:36 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 --- Comment #1 from Owen Leonard --- Created attachment 27921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27921&action=edit Bug 12106 - Capitalization: Patron Attributes on tools/patron import There are three instances of incorrectly-capitalized "Patron Attributes" on the patron import page. This patch corrects them. To test, view the patron import page (Tools -> Import patrons). Confirm that instances of the phrase "patron attributes" in the bottom-most fieldset are correctly capitalized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 20:54:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 18:54:01 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 21:08:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 19:08:41 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #3 from Galen Charlton --- (In reply to Olli-Antti Kivilahti from comment #2) > Apparently not everyone uses print notifications. Maybe a syspref should be > added to control the behaviour? Indeed, there should be a setting to control whether libraries want to default to printed hold notices. Folks can feel free to open a new bug report if they want to, but I'll be pushing this patch to master along with the rest of MTT because it restores previous behavior in this respect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 21:08:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 19:08:46 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 21:25:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 19:25:22 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Galen Charlton --- I will also be including this in part of the overall MTT push to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:19:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:19:48 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #151 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:20:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:20:17 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:20:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:20:30 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #35 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:20:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:20:50 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Olli! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:21:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:21:07 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #28 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:21:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:21:19 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:21:37 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 2 23:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 21:22:00 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 00:05:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 22:05:27 +0000 Subject: [Koha-bugs] [Bug 11638] Untranslatable "Tag editor" in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 27922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27922&action=edit Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 00:08:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 22:08:26 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Component|I18N/L10N |Templates Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Summary|Untranslatable "Tag editor" |Remove HTML from |in addbiblio.pl |addbiblio.pl --- Comment #3 from Bernardo Gonzalez Kriegel --- Changed Bug description and component -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 00:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 22:56:38 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 01:05:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 23:05:51 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #21 from Galen Charlton --- Comment on attachment 27466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27466 [PASSED QA] Bug 8769 - Allow SIP2 return backdating Review of attachment 27466: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8769&attachment=27466) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1780,4 @@ > } > > # case of a return of document (deal with issues and holdingbranch) > + my $today = dt_from_string( $return_date, 'iso' ); This makes me nervous. Besides the comments that Colin made about this change in bug 10694, a variable named $today that doesn't necessarily contain today's date is ... confusing. Also, it is not clear to be why this would be part of the SIP2 change. Can you explain the purpose of this line? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 01:27:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 May 2014 23:27:37 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Galen Charlton --- Pushed to master. Thanks, Olli and Fridolin! In retrospect, the OPAC's version of results browsing that doesn't depend on cookies or retaining state seems preferable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 11:27:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 09:27:29 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 --- Comment #2 from Zeno Tajoli --- Created attachment 27923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27923&action=edit file opac-export.pl is patched This patch solves the bug for UTF-8 output. MARC-8 works only if you save it as a file. In fact the standard Internet stack (browser, web server, etc.) doesn't know anything about MARC-8 or it's ISO base (ISO 2022). To test the bug: -- without the patch use Zotero on a recent Koha install with Apache. You can use PTFS sandboxes. You can't use Biblibre sandboxes, they use Ngix. -- Test a record with special chars. -- Install the patch -- Catch (using Zotero) the same record. -- Test all directly download from Opac. -- To check MARC-8, use a tool that support it. For example MarcEdit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 11:28:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 09:28:06 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 11:57:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 09:57:47 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27923|0 |1 is obsolete| | --- Comment #3 from Zeno Tajoli --- Created attachment 27924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27924&action=edit file opac-export.pl is patched -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 11:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 09:58:31 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 --- Comment #4 from Zeno Tajoli --- Created attachment 27925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27925&action=edit a follow-up to fix a missing print -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 11:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 09:59:56 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 --- Comment #5 from Zeno Tajoli --- To test the bug: -- without the patch use Zotero on a recent Koha install with Apache. You can use PTFS sandboxes. You can't use Biblibre sandboxes, they use Ngix. -- Test a record with special chars. -- Install the patch -- Catch (using Zotero) the same record. -- Test all directly download from Opac. -- To check MARC-8, use a tool that support it. For example MarcEdit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 19:22:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 17:22:47 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 --- Comment #2 from Marc V?ron --- Created attachment 27926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27926&action=edit [Signed-off] Bug 12106 - Capitalization: Patron Attributes on tools/patron import There are three instances of incorrectly-capitalized "Patron Attributes" on the patron import page. This patch corrects them. To test, view the patron import page (Tools -> Import patrons). Confirm that instances of the phrase "patron attributes" in the bottom-most fieldset are correctly capitalized. Followed test plan, works Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 19:23:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 17:23:12 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 19:23:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 17:23:22 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 20:35:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 18:35:34 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #45 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 20:35:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 18:35:58 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 3 23:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 21:59:31 +0000 Subject: [Koha-bugs] [Bug 12176] New: Remove HTML from additem.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bug ID: 12176 Summary: Remove HTML from additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There is HTML code on additem.pl In particular an untranslatable "Tag Editor" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 00:04:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 22:04:34 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 27927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27927&action=edit Bug 12176 - Remove HTML from additem.pl This patch removes HTML code from additem.pl To test: 1. Chech no regressions on Add/Edit/Save items 2. Update translation files for a language, check new string "Tag editor" on staff PO file 3. Check it pass xt/tt_valid.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 00:05:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 22:05:53 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 00:25:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 22:25:16 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27922|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 27928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27928&action=edit Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 00:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 22:29:06 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #5 from Bernardo Gonzalez Kriegel --- *** Bug 682 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 00:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 22:29:06 +0000 Subject: [Koha-bugs] [Bug 682] Move HTML out of addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=682 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED CC| |bgkriegel at gmail.com Resolution|WONTFIX |DUPLICATE --- Comment #1 from Bernardo Gonzalez Kriegel --- *** This bug has been marked as a duplicate of bug 11638 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 00:32:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 May 2014 22:32:02 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #1) > I find these instances of the phrase "tag editor" in .pl and .pm files: > > Line 238 of cataloguing\additem.pl > Line 255 of cataloguing\additem.pl This two in Bug 12176 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 04:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 02:06:43 +0000 Subject: [Koha-bugs] [Bug 12177] New: Remove HTML from authorities.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12177 Bug ID: 12177 Summary: Remove HTML from authorities.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There is HTML code on authorities.pl In particular untranslatable "Tag Editor" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 04:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 02:09:39 +0000 Subject: [Koha-bugs] [Bug 12177] Remove HTML from authorities.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12177 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 27929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27929&action=edit Bug 12177 - Remove HTML from authorities.pl This patch removes HTML code from authorities.pl To test: 1. Check no regressions on authority editor, new/edit/save 2. Check new line on translation files, update a language, look for 'Tag editor' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 04:10:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 02:10:08 +0000 Subject: [Koha-bugs] [Bug 12177] Remove HTML from authorities.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12177 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 04:11:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 02:11:05 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #7 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #1) > I find these instances of the phrase "tag editor" in .pl and .pm files: > > Line 220 of authorities\authorities.pl > Line 252 of authorities\authorities.pl This two in Bug 12177 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 12:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 10:02:36 +0000 Subject: [Koha-bugs] [Bug 12178] New: Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Bug ID: 12178 Summary: Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When using the CSV export option for late serial issues, the claim date is set, but the claimed status for the issue isn't. The issue remains as late. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 12:06:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 10:06:44 +0000 Subject: [Koha-bugs] [Bug 12179] New: Serial claims: No alert when vendor has no email address Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12179 Bug ID: 12179 Summary: Serial claims: No alert when vendor has no email address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When claiming late serial issues, there will be no alert on sending the email when there is no email address in the vendor's record. The claimed status and claim date will be set, but no email has been sent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 19:18:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 17:18:11 +0000 Subject: [Koha-bugs] [Bug 12180] New: Remove HTML from batchMod.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12180 Bug ID: 12180 Summary: Remove HTML from batchMod.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There is HTML code on batchMod.pl In particular an untranslatable "Tag Editor" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 19:28:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 17:28:07 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 --- Comment #6 from Benjamin Rokseth --- Agreed to the neccessity of unit tests in this setting. I can add one when available. The reason for this patch is addressing the gap between SIP2 circulation and internal circulation in Koha. The itemnumber is an internal DB id for the item it is not accessible anywhere and not suitable for item lookup. Barcode is an actual ID for an item. To explain, we have the following case: All circulation is handled by RFID and SIP2 transactions by an external RFIDhub (code will be added in Bug 11858 when tested enough). To minimize Koha code replication/rework we inject by javascript the needed functionality (checkin/checkout/RFID tag write). All transactions then pass the RFIDhub and communication with browser goes via websockets. As SIP transactions only deals with barcodes as IDs and we need to generate receipts I thought it best to use TransferSlip, better than duplicating the existing templates in Koha. As GetItem was already used it was easier to add barcode as parameter. An alternative would be to expand the svc or ILS-DI api to allow item lookup. Sorry for the long explanation, but probably someone else has some ideas to better solutions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 19:28:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 17:28:21 +0000 Subject: [Koha-bugs] [Bug 12180] Remove HTML from batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12180 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 27930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27930&action=edit Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 19:29:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 17:29:15 +0000 Subject: [Koha-bugs] [Bug 12180] Remove HTML from batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12180 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 19:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 17:33:50 +0000 Subject: [Koha-bugs] [Bug 12180] Remove HTML from batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12180 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27930|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 27931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27931&action=edit Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor' Fixed capitalizacion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 19:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 17:34:08 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #8 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #1) > I find these instances of the phrase "tag editor" in .pl and .pm files: > > Line 404 of tools\batchMod.pl > Line 418 of tools\batchMod.pl This two in Bug 12180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 20:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 18:49:09 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #30 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 21:15:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 19:15:31 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 21:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 19:30:10 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #45 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 22:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 20:40:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27520|1 |0 is obsolete| | --- Comment #303 from Galen Charlton --- Comment on attachment 27520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27520 Bug 7180: Reset statistic values on reloading the page This patch somehow got dropped during the QA process. It's needed for 10875 to apply successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 23:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 21:58:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #304 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 4 23:58:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 21:58:27 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #22 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 00:14:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 22:14:18 +0000 Subject: [Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #8 from Galen Charlton --- I happened to fix this bug already via one of my follow-ups for bug 7180. Sorry for forgetting about this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 00:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 22:24:51 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #77 from Galen Charlton --- Pushed to master, along with a follow-up implementing my suggestion to not make the ISO code required and to fall back to the currency code/name if the ISO code is not present. Thanks, Olivier! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 00:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 22:38:00 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #20 from Galen Charlton --- (In reply to Kyle M Hall from comment #5) > I think giving patrons the freedom to type in anything will make it more > complicated and confusing for some patrons. We could just add a new > authorised value category instead. I think that's a much better approach than maintaining a dependency on item types, AdvancedSearchTypes, and introducing a limited-purpose system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:17:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:17:45 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #67 from Galen Charlton --- Pushed latest round to master. Thanks, Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:17:56 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:28 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27665|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:30 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27666|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:32 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27667|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:34 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27668|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:36 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27669|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:39 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27670|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:18:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:18:41 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27671|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 01:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 May 2014 23:26:11 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:31:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:31:56 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #21 from Galen Charlton --- Created attachment 27932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27932&action=edit Bug 9468: [COUNTER-PATCH] make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:32:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:32:01 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #22 from Galen Charlton --- Created attachment 27933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27933&action=edit Bug 9468: [COUNTER-PATCH] define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:32:05 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #23 from Galen Charlton --- Created attachment 27934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27934&action=edit Bug 9468: [COUNTER-PATCH] use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:32:09 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #24 from Galen Charlton --- Created attachment 27935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27935&action=edit Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:32:32 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Galen Charlton --- I have attached a series of counter-patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:41:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:41:59 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Galen Charlton --- Pushed to master. Thanks, Olivier! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 02:45:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 00:45:56 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 03:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 01:00:22 +0000 Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for customization routine and verbose printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #20 from Galen Charlton --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 03:31:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 01:31:50 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #27 from Galen Charlton --- Pushed to master, along with a follow-up to apply the change to the Bootstrap theme and another follow-up to prevent a change in behavior for MARC21 authorities. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 04:24:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 02:24:33 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #130 from Galen Charlton --- Pushed to master. Thanks, Chris, Kyle, Fridolin, Katrin, and Jonathan! Note that I have elected to have the feature be OFF by default for upgrades. It will be on by default for new installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 04:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 02:26:23 +0000 Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 04:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 02:59:30 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #60 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 04:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 02:59:50 +0000 Subject: [Koha-bugs] [Bug 10677] C4::Search::GetSearchHistory is broken and unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10677 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Galen Charlton --- I confirm that the routine was removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 05:05:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 03:05:25 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Joel Coehoorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcoehoorn at york.edu --- Comment #30 from Joel Coehoorn --- This bug is affecting us now, as well. Reading through the issue and the comments, I noticed two things: 1. It's now been more than six months since it was re-filed with the Library::CallNumber::LC project, with no new activity, and nearly six months since the project had any activity at all. It seems unlikely to be fixed any time soon. 2. RESOLVED WONTFIX seems like the wrong status for this bug. While WONTFIX isn't far off from the perspective of the koha team, pairing that with RESOLVED gives the impression that there's nothing wrong. I can tell you: something is *very* wrong here, and the issue is far from resolved. Perhaps BLOCKED is a better option, though I understand if the koha team only wants to use that status when they can point to a specific other bug that is the cause of the block. But something with the state of this needs to change. Anything that starts with RESOLVED tends to make devs think everything is okay. Much better to have a state that shows this is still broken in koha. That will help generate pressure to fix the upstream perl module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 05:12:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 03:12:22 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 05:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 03:23:55 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 05:30:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 03:30:53 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #31 from Chris Cormack --- (In reply to Joel Coehoorn from comment #30) > This bug is affecting us now, as well. > > Reading through the issue and the comments, I noticed two things: > > 1. It's now been more than six months since it was re-filed with the > Library::CallNumber::LC project, with no new activity, and nearly six months > since the project had any activity at all. It seems unlikely to be fixed any > time soon. > > 2. RESOLVED WONTFIX seems like the wrong status for this bug. While WONTFIX > isn't far off from the perspective of the koha team, pairing that with > RESOLVED gives the impression that there's nothing wrong. I can tell you: > something is *very* wrong here, and the issue is far from resolved. Perhaps > BLOCKED is a better option, though I understand if the koha team only wants > to use that status when they can point to a specific other bug that is the > cause of the block. But something with the state of this needs to change. > Anything that starts with RESOLVED tends to make devs think everything is > okay. Much better to have a state that shows this is still broken in koha. > That will help generate pressure to fix the upstream perl module. I think you are putting way too much value on the status of it and how/what developers decide to spend their free time on. Unless someone is willing to fund a fix for this, it won't get fixed, no matter what the status is. When it's our free time, you are competing against spending time with our families, reading a book, etc. The status being blocked will not make it any more likely that someone will decide to work on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 05:32:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 03:32:42 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #22 from Galen Charlton --- Pushed to master. Thanks, Liz and Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 05:40:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 03:40:41 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Nu?o! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:04:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:04:12 +0000 Subject: [Koha-bugs] [Bug 12181] Koha installation problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12181 Simanta Shantikari changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Version|unspecified |3.14 Hardware|All |PC Component|Koha |bugs.koha-community.org Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha OS|All |Linux -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:09:46 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #40 from Galen Charlton --- Pushed to master. Thanks, Owen and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:15:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:15:14 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #23 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:20:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:20:26 +0000 Subject: [Koha-bugs] [Bug 12182] New: Koha installation problem in Ubuntu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12182 Bug ID: 12182 Summary: Koha installation problem in Ubuntu Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: simanta.s at libsys.co.in QA Contact: testopia at bugs.koha-community.org When try to install Koha-3.14 I am facing following error. Make test fail. t/Patroncards_Patroncard.t .......... ok t/Patroncards_Profile.t ............. ok t/Patroncards_Template.t ............ ok t/Print.t ........................... ok t/QueryParser.t ..................... 1/? # Failed test 'super simple keyword query' # at t/QueryParser.t line 22. # got: '@attr 1=4 @attr 4=6 "smith"' # expected: '@or @or @attr 1=1016 @attr 4=6 "smith" @attr 9=20 @attr 2=102 @attr 4=6 "smith" @attr 9=34 @attr 2=102 @attr 4=6 "smith"' # Failed test 'keyword search sorted by acqdate descending' # at t/QueryParser.t line 33. # got: '@or @attr 7=1 @attr 1=32 0 @attr 1=1003 @attr 4=6 "smith"' # expected: '@or @attr 1=32 @attr 7=1 0 @attr 1=1003 @attr 4=6 "smith"' # Looks like you failed 2 tests of 28. t/QueryParser.t ..................... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/28 subtests t/RecordProcessor.t ................. ok t/Review.t .......................... ok t/Ris.t ............................. ok t/RotatingCollections.t ............. given is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 133. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 134. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 139. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 144. t/RotatingCollections.t ............. ok t/Scheduler.t ....................... ok t/Scrubber.t ........................ 1/19 # Note: scrubber test output will have whitespace collapsed for readability # done. t/Scrubber.t ........................ ok t/Search_PazPar2.t .................. 1/8 400 URL must be absolute at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search/PazPar2.pm line 68. 400 URL must be absolute at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search/PazPar2.pm line 84. 400 URL must be absolute at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search/PazPar2.pm line 99. 400 URL must be absolute at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search/PazPar2.pm line 121. 400 URL must be absolute at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search/PazPar2.pm line 142. 400 URL must be absolute at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search/PazPar2.pm line 159. t/Search_PazPar2.t .................. ok t/SimpleMARC.t ...................... 1/37 when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/SimpleMARC.pm line 93. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/SimpleMARC.pm line 96. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/SimpleMARC.pm line 99. t/SimpleMARC.t ...................... ok t/SIP_Sip.t ......................... 1/8 verify_cksum: no sum detected at /home/libsys/Downloads/koha-3.14.06/t/../C4/SIP/Sip/Checksum.pm line 24. t/SIP_Sip.t ......................... ok t/SMS.t ............................. ok t/SocialData.t ...................... given is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 133. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 134. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 139. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 144. t/SocialData.t ...................... ok t/Stats.t ........................... ok t/SuggestionEngine.t ................ ok t/SuggestionEngine_AuthorityFile.t .. 1/? given is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 133. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 134. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 139. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 144. Smartmatch is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/Search.pm line 534. Useless use of '\'; doesn't escape metacharacter '(' at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/C4/AuthoritiesMarc.pm line 848. t/SuggestionEngine_AuthorityFile.t .. ok t/Templates.t ....................... ok t/TmplToken.t ....................... ok t/VirtualShelves_Merge.t ............ ok t/XSLT.t ............................ given is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 133. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 134. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 139. when is experimental at /home/libsys/Downloads/koha-3.14.06/blib/PERL_MODULE_DIR/Koha/DateUtils.pm line 144. t/XSLT.t ............................ ok Test Summary Report ------------------- t/QueryParser.t (Wstat: 512 Tests: 28 Failed: 2) Failed tests: 6, 17 Non-zero exit status: 2 Files=97, Tests=18030, 121 wallclock secs ( 2.59 usr 0.30 sys + 34.88 cusr 4.86 csys = 42.63 CPU) Result: FAIL Failed 1/97 test programs. 2/18030 subtests failed. make: *** [test_dynamic] Error 255 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:55:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:55:46 +0000 Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |11848 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:55:48 +0000 Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668 --- Comment #2 from Galen Charlton --- Created attachment 27936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27936&action=edit Bug 11668: make hardcoded strings in reports/borrowers_stats.pl translatable To test: [1] Generate the PO files for the language of your choice. [2] Supply translations for the "Total" and "TOTAL" strings in the $LANG-messages.op file. [3] Install the translation. [4] Change the staff interface to the chosen language. [5] Run the borrowers statistics report and export the results to CSV. [5] Verfiy that the strings "Total" and "TOTAL" are replaced with the translation made in step 2. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:55:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:55:46 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11668 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:56:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:56:03 +0000 Subject: [Koha-bugs] [Bug 12183] New: Ability to search child record in parent record (Analytical record) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 Bug ID: 12183 Summary: Ability to search child record in parent record (Analytical record) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Ability to search child record in parent record (Analytical record) by 773 tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:56:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:56:24 +0000 Subject: [Koha-bugs] [Bug 12183] Ability to search child record in parent record (Analytical record) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:56:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:56:32 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #60 from Galen Charlton --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:56:56 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #16 from Galen Charlton --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 06:57:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 04:57:59 +0000 Subject: [Koha-bugs] [Bug 12183] Ability to search child record in parent record (Analytical record) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Could this be a duplicate to bug 11175? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:04:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:04:24 +0000 Subject: [Koha-bugs] [Bug 12183] Ability to search child record in parent record (Analytical record) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 --- Comment #2 from Amit --- Hi Kartin, This feature help to search child record in parent record. For example: XXX is a title and contain 20 child records or more. So we want to search only child records within XXX title (Nested search) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:07:09 +0000 Subject: [Koha-bugs] [Bug 12183] Ability to search child record in parent record (Analytical record) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 --- Comment #3 from Katrin Fischer --- I think what Olli was trying to do is showing the childs in the parent directly. Could you add a bit more information about your feature to this bug? We have some sort of linking currently for serials and sets, will this cover monographs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:07:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:07:40 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:08:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:08:30 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:09:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:09:19 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #86 from David Cook --- Very tangential comment from me... It would be interesting in the long-term to see this feature integrate with an interlibrary loan feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:12:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:12:46 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:14:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:14:44 +0000 Subject: [Koha-bugs] [Bug 12183] Ability to search child record in parent record (Analytical record) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 --- Comment #4 from Amit --- Hi Kartin, Suppose you have a book which have several articles published and catalog in Koha by host entry 773 tag then we will able to search child record within the parent record. First search host record under (773 tag) host record you can search multiple child records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:18:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:18:19 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:20:58 +0000 Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Matthias! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:27:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:27:23 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 07:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 05:27:38 +0000 Subject: [Koha-bugs] [Bug 12183] Ability to search child record in parent record (Analytical record) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12183 --- Comment #5 from Katrin Fischer --- I think we might be misunderstanding each other :) I just wanted to prevent doubled up work, as I thought Olli's patch had a similar goal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 08:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 06:04:40 +0000 Subject: [Koha-bugs] [Bug 12150] Use more placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from paxed --- (In reply to Bernardo Gonzalez Kriegel from comment #1) > Is ready to be signed? Yes, sorry, forgot to change the status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 08:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 06:19:55 +0000 Subject: [Koha-bugs] [Bug 12184] New: Typo "retricted" in returns.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12184 Bug ID: 12184 Summary: Typo "retricted" in returns.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org Should be "restricted", of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:01:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:01:36 +0000 Subject: [Koha-bugs] [Bug 12182] Koha installation problem in Ubuntu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12182 --- Comment #1 from Simanta Shantikari --- When I execute this comman folling are showings #./koha_perl_deps.pl -m [Mon May 5 12:39:14 2014] koha_perl_deps.pl: defined(@array) is deprecated at /usr/share/perl5/PDF/Reuse.pm line 993, line 751. [Mon May 5 12:39:14 2014] koha_perl_deps.pl: (Maybe you should just omit the defined()?) [Mon May 5 12:39:14 2014] koha_perl_deps.pl: defined(@array) is deprecated at /usr/share/perl5/PDF/Reuse.pm line 993, line 751. [Mon May 5 12:39:14 2014] koha_perl_deps.pl: (Maybe you should just omit the defined()?) Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- Readonly::XS 0 * 1.02 No -------------------------------------------------------------------------------------------- Total modules reported: 1 * Module is missing or requires an upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:04:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:04:15 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27827|0 |1 is obsolete| | Attachment #27828|0 |1 is obsolete| | Attachment #27919|0 |1 is obsolete| | --- Comment #22 from M. de Rooy --- Created attachment 27937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27937&action=edit Bug 11209: Don't sent the same message for the same user the same day For PREDUE messages, one message is sent to the message_queue table for each items in advanced. So the patron will receive the same message. The sms part for DUE and PREDUE should not contain dynamic parts, only a standard message. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:04:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:04:50 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #23 from M. de Rooy --- Created attachment 27938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27938&action=edit Bug 11209: Check if a notice has been already sent today The previous patch checks if a notice has already been sent when the current notices has been sent in queue. Which is wrong! We have to check if a similar notice has been sent today. This patch has been created after an observation on a production server: If a user place on holds several items, he will receive 1 SMS per hold. Here we only want 1 SMS for all holds. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:04:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:04:54 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #24 from M. de Rooy --- Created attachment 27939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27939&action=edit Bug 11209: A message is duplicate if its content has been already sent If the template contains dynamic parts, the message won't be considerated as duplicated. Signed-off-by: Marcel de Rooy Duplicate messages will be queued, but when sending the queued messages duplicates are found and are marked as failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:05:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:05:58 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:06:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:06:14 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:41:11 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25910|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 27940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27940&action=edit Bug 11904: New module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:41:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:41:21 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25911|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 27941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27941&action=edit Bug 11904: Unit tests for Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:41:32 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25912|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 27942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27942&action=edit Bug 11904: Example usage of new module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:42:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:42:32 +0000 Subject: [Koha-bugs] [Bug 12185] New: Remove extra "f" from parcel.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Bug ID: 12185 Summary: Remove extra "f" from parcel.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org Pasi Kallinen spotted this rather obvious typo in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt: [% IF ( loop_order.order_internalnote ) %] f

Internal note: [% loop_order.order_internalnote|html %] [Change internal note]

[% ELSE %] The "f" before the " References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 --- Comment #1 from Magnus Enger --- Created attachment 27943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27943&action=edit Bug 12185 - Remove extra "f" from parcel.tt There is a typoed "f" outside of the HTML on line 279 of koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt This patch removes that extra "f". To test: It should be sufficient to look at line 279 before and after the patch has been applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:46:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:46:29 +0000 Subject: [Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 10:46:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 08:46:50 +0000 Subject: [Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 12:02:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 10:02:38 +0000 Subject: [Koha-bugs] [Bug 12186] New: Duplicate TT code for account payments Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 Bug ID: 12186 Summary: Duplicate TT code for account payments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org [% SWITCH line.accounttype %] [% CASE 'Pay' %]Payment,thanks [% CASE 'Pay00' %]Payment,thanks (cash via SIP2) .... This SWITCH statement is duplicated in three different files: intranet-tmpl/prog/en/modules/members/pay.tt intranet-tmpl/prog/en/modules/members/boraccount.tt opac-tmpl/prog/en/modules/opac-account.tt It should be folded into a single macro or block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 12:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 10:44:22 +0000 Subject: [Koha-bugs] [Bug 12187] New: Duplicate TT code for serial statuses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Bug ID: 12187 Summary: Duplicate TT code for serial statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org [% IF ( latestserial.status1 ) %]Expected[% END %] [% IF ( latestserial.status2 ) %]Arrived[% END %] [% IF ( latestserial.status3 ) %]Late[% END %] ... These statements are repeated multiple times, in the following files: intranet-tmpl/prog/en/modules/catalogue/detail.tt intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt intranet-tmpl/prog/en/modules/serials/claims.tt intranet-tmpl/prog/en/modules/serials/serials-recieve.tt intranet-tmpl/prog/en/modules/serials/serials-collection.tt intranet-tmpl/prog/en/modules/serials/serials-edit.tt intranet-tmpl/prog/en/modules/serials/subscription-detail.tt opac-tmpl/prog/en/modules/opac-full-serial-issues.tt opac-tmpl/prog/en/modules/opac-detail.tt To prevent things from getting out of sync, they should be folded into a single TT block or macro. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 13:30:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 11:30:40 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #20 from Kyle M Hall --- Pushed to 3.8.x! Will be in v3.08.24 Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 13:42:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 11:42:27 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #22 from Kyle M Hall --- Created attachment 27944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27944&action=edit Bug 8769 - (QA Followup) Rename $today to $return_date_dt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 13:45:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 11:45:44 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27944|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 27945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27945&action=edit Bug 8769 - (QA Followup) Rename $today to $return_date_dt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 13:55:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 11:55:21 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27945|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 27946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27946&action=edit Bug 8769 - (QA Followup) Undo change to value of $today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 13:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 11:58:20 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #25 from Kyle M Hall --- (In reply to Galen Charlton from comment #21) > Comment on attachment 27466 [details] [review] > [PASSED QA] Bug 8769 - Allow SIP2 return backdating > > Review of attachment 27466 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +1780,4 @@ > > } > > > > # case of a return of document (deal with issues and holdingbranch) > > + my $today = dt_from_string( $return_date, 'iso' ); > > This makes me nervous. Besides the comments that Colin made about this > change in bug 10694, a variable named $today that doesn't necessarily > contain today's date is ... confusing. Also, it is not clear to be why this > would be part of the SIP2 change. > > Can you explain the purpose of this line? After some examination, I have concluded that this change serves no useful purpose and only causes code obfuscation. I have attached a followup to revert that line of code. I believe the change is vestigial from a time before this feature was dependent on bug 10694. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 14:11:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 12:11:27 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27771|0 |1 is obsolete| | --- Comment #35 from Julian Maurice --- Created attachment 27947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27947&action=edit Bug 8868: ILS-DI: CancelHold needs to take a reserve_id CancelHold takes two parameters: patron_id and item_id. If item_id is considered as an itemnumber, holds on title can't be canceled. If item_id is considered as a biblionumber, all holds on this biblionumber (for a borrower) will be canceled. So CancelHold have to consider item_id as a reserve_id. - Added subroutine C4::Reserves::GetReserve - C4::ILSDI::Services::GetRecords now returns the reserve_id - Fix the text in the ilsdi.pl?service=Describe&verb=CancelHold page - Unit tests for CancelReserved and GetReserve - Do not delete row in reserves table if insert in old_reserves fails Signed-off-by: Leila and Sonia Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 14:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 12:23:10 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #36 from Julian Maurice --- GetReserve is already in master (added by bug 9394) This patch was creating another GetReserve subroutine. I only removed the GetReserve added by this patch (but still continue to use GetReserve in C4::ILSDI::Services) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 15:38:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 13:38:03 +0000 Subject: [Koha-bugs] [Bug 7088] cannot renew items on hold even with override In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 16:17:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 14:17:39 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 16:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 14:53:24 +0000 Subject: [Koha-bugs] [Bug 12188] New: fines duplicated after changing dateformat Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188 Bug ID: 12188 Summary: fines duplicated after changing dateformat Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 27948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27948&action=edit fines duplicated hi, I changed sys pref dateformat to put dd/mm/aaaa and after cron of overdues, fines were duplicated (see attachment). I think a bug is on date on description of charges or on cron? Someone noticed it? Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 16:53:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 14:53:43 +0000 Subject: [Koha-bugs] [Bug 12188] fines duplicated after changing dateformat In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 17:01:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 15:01:55 +0000 Subject: [Koha-bugs] [Bug 12186] Duplicate TT code for account payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- And there should probably be a space between "Payment" and "thanks"? Payment, thanks not Payment,thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 17:06:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 15:06:59 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #26 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 17:17:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 15:17:51 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 17:29:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 15:29:15 +0000 Subject: [Koha-bugs] [Bug 8813] issue slip lists items as overdue that are not overdue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8813 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Severity|enhancement |normal --- Comment #1 from Christopher Brannon --- I would love to see this issue corrected. We reported this almost two years ago. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 17:51:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 15:51:37 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 17:52:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 15:52:44 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 18:01:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 16:01:25 +0000 Subject: [Koha-bugs] [Bug 12186] Duplicate TT code for account payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- There are also bugs 12165 for adding the code to bootstrap and bug 12166. There are still some things that need to be added to the account descriptions before they will cover all cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 18:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 16:08:04 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #19 from Galen Charlton --- Pushed to master. Thanks, Tom?s. However, I am not pushing the follow-up: I've never heard of any other package that prompts you for a sudo password just by hitting the tab key. It's one thing to do 'sudo foo', then get prompted for a password -- that's what you expect. But not for hitting the tab key. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 18:21:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 16:21:30 +0000 Subject: [Koha-bugs] [Bug 5770] email librarian when purchase suggestion made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 18:23:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 16:23:14 +0000 Subject: [Koha-bugs] [Bug 12189] New: Untranslatable page title in print slip template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12189 Bug ID: 12189 Summary: Untranslatable page title in print slip template Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr printslip.pl includes this line: title => "Print Receipt for $borrowernumber", ...meaning the page title is untranslatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 18:49:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 16:49:14 +0000 Subject: [Koha-bugs] [Bug 12189] Untranslatable page title in print slip template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12189 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 19:18:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 17:18:29 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton --- Pushed to master, along with a regression test. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 19:51:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 17:51:38 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 20:00:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 18:00:23 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 20:21:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 18:21:24 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate --- Comment #14 from Galen Charlton --- Note that this is a candidate for 3.16 RC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 5 21:33:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 May 2014 19:33:42 +0000 Subject: [Koha-bugs] [Bug 12147] Column width for action links on invoices too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #3 from Owen Leonard --- Created attachment 27949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27949&action=edit Bug 12147 [Alternate] Column width for action links on invoices too small This alternative patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed and an improperly closed