From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:28:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:28:33 +0000
Subject: [Koha-bugs] [Bug 11573] change description of charges in account
fines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573
--- Comment #12 from Katrin Fischer ---
Created attachment 27822
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27822&action=edit
[SIGNED OFF] Bug 11573 - Make fine display more consistent for rentals
To test:
1. Set up an item type with a rental charge
2. issue an item from that item type
3. Check fines - the rental charge does not show the title of the issued item
4. Renew that item, the renewal charge does show the title of the issued item
5. Apply the patch
6. Repeat steps 1-4, both should show the title of the issued item in the
description.
This change is proposed in order to get rid of some double ups in the title on
the boraccount template.
Signed-off-by: Katrin Fischer
Tested with rental lines created before and after applying the patch.
After applying the patch it's better, but old lines will still look ok.
There is still a double up on the title on the 'pay' tab, as we get the
title from the itemnumber and also display the description. I think
getting all the information from the itemnumber for display would be
a bit nicer in the future. Butthis is an improvement.
Passes tests and QA script.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:28:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:28:36 +0000
Subject: [Koha-bugs] [Bug 11573] change description of charges in account
fines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573
--- Comment #13 from Katrin Fischer ---
Created attachment 27823
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27823&action=edit
[SIGNED OFF] Bug 11573 - removing title double ups on boraccount.tt
To test:
1. Create a bunch of fines (or view your existing fines data) - it should have
lost entries, rentals, rental renewals, and regular fines and fine updates.
2. View the fines tab for your borrower with fines
3. without the patch, it will look like the submitted screenshot
4. with the patch, there will be few, if any, doubleups of title
This patch may be incomplete - there may be cases that still need work. I'm
happy to do followups.
Rental fees and rental renewals will not look wholly consistent without the
other attached patch, but this one does not require it.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:28:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:28:39 +0000
Subject: [Koha-bugs] [Bug 11573] change description of charges in account
fines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573
--- Comment #14 from Katrin Fischer ---
Created attachment 27824
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27824&action=edit
Bug 11573: Follow-up: Include changes in OPAC templates
Patch adds changes from earlier patches to OPAC prog and
bootstrap templates.
Patch radds a description for FU - Accrued fine.
Removes a stray space before the comma, using some TT magic.
To test:
- Test like the other patch, display in OPAC prog, OPAC bootstrap,
Staff Pay fines tab and Staff Accounts tab should be the same.
- No ' , ' should be seen.
- FU fines should now display a description.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:36:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:36:27 +0000
Subject: [Koha-bugs] [Bug 12166] New: Improve display of Reserve charges in
patron account
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166
Bug ID: 12166
Summary: Improve display of Reserve charges in patron account
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Right now, a reserve charge will display in OPAC and staff like this:
Res, Reserve Charge - Administrative sanctions in the European Union /
Res is the accounttype, which should be resolved into a description - Hold fee.
Reserve Charge should no longer be saved to the database, description should
only have the title.
Ideally, existing Reserve charge entries should be cleaned up.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:37:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:37:01 +0000
Subject: [Koha-bugs] [Bug 11573] change description of charges in account
fines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12166
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:37:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:37:01 +0000
Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in
patron account
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |11573
Severity|enhancement |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 00:49:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 22:49:35 +0000
Subject: [Koha-bugs] [Bug 11573] change description of charges in account
fines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573
--- Comment #15 from Katrin Fischer ---
Wajasu, I am not sure about your patch, as there are some problems with, would
you mind going step by step? We could also check then that the other codes are
still in use and have test plans for each. I haven't moved your patch to
another bug yet, but happy to do so if you want me to.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 01:23:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 23:23:49 +0000
Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in
patron account
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liz at catalyst.net.nz
--- Comment #1 from Liz Rea ---
Why should a reserve charge not be saved to the database?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 01:28:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Apr 2014 23:28:44 +0000
Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in
patron account
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166
--- Comment #2 from Liz Rea ---
Never mind, you mean the text, not the charge itself. As you were.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 02:06:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 00:06:37 +0000
Subject: [Koha-bugs] [Bug 12167] New: datetime type casting issue regarding
bug 7567
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167
Bug ID: 12167
Summary: datetime type casting issue regarding bug 7567
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: gmcharlt at gmail.com
Reporter: mtompset at hotmail.com
QA Contact: testopia at bugs.koha-community.org
I just upgraded the mysql server on our live and test systems running Ubuntu,
and bug 7567 stopped displaying news in the staff client. I was able to track
it down to a type casting issue. A patch follows.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 02:07:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 00:07:02 +0000
Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug
7567
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |7567
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 02:07:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 00:07:02 +0000
Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12167
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 04:17:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 02:17:22 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
--- Comment #9 from Nicholas van Oudtshoorn ---
Ping on this. Anybody interested in signing this one off?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:17:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:17:08 +0000
Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug
7567
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167
--- Comment #1 from M. Tompsett ---
Created attachment 27825
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27825&action=edit
Bug 12167 - Correct faulty test logic
GetNewsToDisplay returns a reference to an array of hashes.
Of course the hash >= 2.
This patch properly checks the scalar size of the array.
TEST PLAN
---------
1) prove -v t/db_dependent/NewsChannels.t
-- should "work"
2) apply the patch
3) prove -v t/db_dependent/NewsChannels.t
-- should "fail"
This is in preparation for the next patch.
NOTE: I believe this may only work under Ubuntu 12.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:17:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:17:13 +0000
Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug
7567
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167
--- Comment #2 from M. Tompsett ---
Created attachment 27826
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27826&action=edit
Bug 12167 - Patch disappearing news problem
This doesn't duplicate on Debian, but it does under Ubuntu.
TEST PLAN
---------
1) Update your git master to current.
2) Log into your staff client.
3) The news may have disappeared.
-- Make sure to have news entered.
The problem portion is the timestamp and date+1 logic
don't seem to function properly.
4) Apply the first patch.
5) prove -v t/db_dependent/NewsChannels.t
-- It should "fail".
6) Apply the second patch.
7) The news should reappear.
-- There is no apparent change under Debian.
8) prove -v t/db_dependent/NewsChannels.t
-- It should now "work".
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:29:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:29:07 +0000
Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug
7567
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:34:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:34:22 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #12 from Chris Cormack ---
(In reply to M. Tompsett from comment #10)
> I'm curious about the time queued date vs. now(). What if there is a cross
> midnight situation? Can such a situation happen? I figure if some branches
> are 12 timezones away from other branchs, it may.
The timezone that matters is the timezone the database server is in, that is
the one doing the NOW()
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:39:08 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22762|0 |1
is obsolete| |
--- Comment #13 from Chris Cormack ---
Created attachment 27827
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27827&action=edit
Bug 11209: Don't sent the same message for the same user the same day
For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.
The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:39:22 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:39:26 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23255|0 |1
is obsolete| |
--- Comment #14 from Chris Cormack ---
Created attachment 27828
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27828&action=edit
Bug 11209: Check if a notice has been already sent today
The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.
This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 05:39:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 03:39:31 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559
--- Comment #32 from David Cook ---
(In reply to Jesse Weaver from comment #30)
> (In reply to Jesse Weaver from comment #29)
> > Created attachment 27761 [details] [review] [review]
> > Bug 11559 - QA followup: Change path to humanmsg, fix XSLT error
>
> ... The commit message for this is a bit of an overstatement, this does not
> in fact fix the bug David reported. Which browser did you notice this bug
> on, though, David? The only places I can see where it should occur are IE <
> 9.
I noticed in Chrome on Windows. I'll have to take another look sometime to see
how I go now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 08:20:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 06:20:58 +0000
Subject: [Koha-bugs] [Bug 12012] Updating Zebra config files for debian
packages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|9612 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 08:20:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 06:20:58 +0000
Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing
is enabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|12012 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 08:50:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 06:50:37 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868
--- Comment #33 from M. de Rooy ---
QA: Looking at this one now..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:04:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:04:34 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #34 from M. de Rooy ---
QA Comment:
You add a routine GetReserve to C4/Reserves.pm
This is used only in C4/ILSDI/Services.pm. The returned hashref is used to
check for the existence of the reserves record and to verify the
borrowernumber.
It seems that you could use GetReserveInfo to do exactly the same job. This
would prevent changing the Reserves module, the need of a unit test, etc. So
less maintenance. The only very small overhead is the join of a few tables
there; imo not too high.
Could you please adjust/simplify? Thanks.
Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:07:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:07:46 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--- Comment #15 from M. de Rooy ---
QA: Looking at this one now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:20:35 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #263 from Jonathan Druart ---
Created attachment 27829
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27829&action=edit
Bug 7180: Order from staged file improvements
This patch adds:
- 1 syspref MarcFieldsToOrder
- 1 ajax script acqui/ajax-getauthvaluedropbox.pl
- 1 routine C4::Budgets::GetBudgetByCode
Before this patch you were not able to order 1 or all the records from
your staged file. You were allowed to specify some information ("Import All"
and "Accounting details" areas) for the order.
With this patch, the previous behaviours still exist.
But now you can *select* which records you want to ordered.
For these ones you can specify independently informations (Quantity,
price, budget, sort1 and sort2).
The cherry on the cake is that you can pre-fill these information with
values
Test plan:
1. Fill the new syspref MarcFieldsToOrder with something like:
==BEGIN==
price: 947$c
quantity: 969$h
budget_code: 922$a
rrp: 010$d
discount: 969$d
sort1: 923$a
sort2: 924$a
==END==
The empty line at the end is mandatory!
The budget (corresponding to your budget_code) can be filled with
authorized value categories (statistic 1 and 2).
The sort1 and sort2 values can be filled with the an authorized value
(of the category previously selected)
2. Choose randomly one or more biblio(s) and fill fields with what is relevant.
3. Export the biblio and import it (with the "Stage MARC records for
import" tool).
4. Go on a basket and add an order from a staged file. Select your
staged file.
5. Well. Now you can see your biblio (or biblios if your had exported
more than one). For each one, informations should be pre-filled with the
biblio values. The budget should be selected on the budget corresponding
to the budget_code (in the field 922$a) and the "planning values" too
(with fields 923$a and 924$a).
You can modify these values (or not) and choose a default value for
budget and planning values (in the "Accounting details" area).
6. Save and check the prices values. Modify the order and check that
budget and sort* are good
Prices are calculated following some parameters:
if there is no price => listprice = 0
else =>
- the gstrate value for your order is the gstrate value of the bookseller
- discount = if filled : the discount value / 100
else: the discount value of the bookseller
- if the bookseller includes tax( List item price includes tax: Yes )
if a discount exists:
ecost = price
rrp = ecost / ( 1 - discount )
else: # a discount does not exist
ecost = price * ( 1 - discount )
rrp = price
else # the bookseller does not include tax
if a discount exists:
ecost = price / ( 1 + gstrate )
rrp = ecost / ( 1 - discount )
else: # a discount does not exist
rrp = price / ( 1 + gstrate )
ecost = rrp * ( 1 - discount )
- in all cases:
listprice = rrp / currency rate
unitprice = ecost
total = ecost * quantity
7. Retry with different parameters
8. Check the 'Import all' action still works
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:20:41 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #264 from Jonathan Druart ---
Created attachment 27830
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27830&action=edit
Bug 7180: FIX getAuthValueDropbox should display the selected value
If the no AV match the name/category or if no category is defined, the
input field should contain the value.
Signed-off-by: Pierre Angot
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:20:47 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #265 from Jonathan Druart ---
Created attachment 27831
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27831&action=edit
Bug 7180: Add UT for C4::Budgets::GetBudgetByCode
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:20:52 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #266 from Jonathan Druart ---
Created attachment 27832
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27832&action=edit
Bug 7180: QA followup
Ergonomic improvements:
- Remove the green color the selected record.
- Use fieldset.rows (and legend).
- Use the required css class for quantity inputs.
- Replace "budget" with "fund".
- fix the "undefined" string
- Add a "show MARC" link
- replace "no_match" with a text.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:20:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:20:57 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #267 from Jonathan Druart ---
Created attachment 27833
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27833&action=edit
Bug 7180: The default quantity is 1
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:03 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #268 from Jonathan Druart ---
Created attachment 27834
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27834&action=edit
Bug 7180: Follow-up fixing minor issues
- Fixed some labels from Budget to Fund
- Added the system preference to sysprefs.sql
- Fixed some untranslatable Javascript strings
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:09 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #269 from Jonathan Druart ---
Created attachment 27835
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27835&action=edit
Bug 7180: Change syspref description
- the blank line is now useless
- add an example for the syspref value
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:16 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #270 from Jonathan Druart ---
Created attachment 27836
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27836&action=edit
Bug 7180: Adapt neworderempty code (js function moved).
The js function fetchSortDropbox has been deleted in previous patch.
The new function is getAuthValueDropbox.
Test plan:
- link some av to some funds
- open an existing order and verify value are correctly filled in the
sort1 and sort2 values
- create a new order and verify behavior is the same as before
Note: This patch generates 2 ajax queries (max) if the budget is linked
to 2 av categories for sort1 and sort2. This could be improved using a
template plugin for values display on load.
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:21 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #271 from Jonathan Druart ---
Created attachment 27837
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27837&action=edit
Bug 7180: FIX License version
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:26 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #272 from Jonathan Druart ---
Created attachment 27838
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27838&action=edit
Bug 7180: QA followup
- fix unit tests (use a transaction).
- add 3 tabs on the page in order to be more understandable.
- fix a warn in logs
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:33 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #273 from Jonathan Druart ---
Created attachment 27839
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27839&action=edit
Bug 7180 - QA Followup - Correct minor language issues
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:38 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #274 from Jonathan Druart ---
Created attachment 27840
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27840&action=edit
Bug 7180: Restore the "Add order" link
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:43 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #275 from Jonathan Druart ---
Created attachment 27841
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27841&action=edit
Bug 7180: Remove useless rrp variable
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:48 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #276 from Jonathan Druart ---
Created attachment 27842
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27842&action=edit
Bug 7180: FIX: discount was divided by 100 twice.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:21:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:21:56 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #277 from Jonathan Druart ---
Created attachment 27843
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27843&action=edit
Bug 7180: fetch_sort_dropbox.pl is not in use anymore
Test plan:
git grep fetch_sort_dropbox
should return no result.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:22:03 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #278 from Jonathan Druart ---
Created attachment 27844
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27844&action=edit
Bug 7180: QA followup 2
This patch takes into account all QA failures raised in comment 207.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:22:11 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #279 from Jonathan Druart ---
Created attachment 27845
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27845&action=edit
Bug 7180: QA followup 3
1/ showmarc.pl takes the importid for staged files.
2/ small note to indicate that the vendor's discount will be used if no
discount is filled.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:22:18 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #280 from Jonathan Druart ---
Created attachment 27846
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27846&action=edit
Bug 7180: Reset statistic values on reloading the page
On the "Default accounting details", if a dropdown list was created for
a statistic value, on reloading the page it still exist. It should not
given the fund value is reset.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:22:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:22:23 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #281 from Jonathan Druart ---
Created attachment 27847
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27847&action=edit
Bug 10875: Add order from a staged file should not display inactive funds
When adding an order from a staged file, a link "show all funds" is now
added on the top of the page.
All inactive funds are hidden by default.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:23:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:23:05 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Passed QA
--- Comment #282 from Jonathan Druart ---
Last patches fix conflicts with bug 12089 and bug 12138.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:24:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:24:06 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27561|0 |1
is obsolete| |
Attachment #27562|0 |1
is obsolete| |
Attachment #27563|0 |1
is obsolete| |
Attachment #27564|0 |1
is obsolete| |
Attachment #27565|0 |1
is obsolete| |
Attachment #27566|0 |1
is obsolete| |
Attachment #27567|0 |1
is obsolete| |
Attachment #27568|0 |1
is obsolete| |
Attachment #27569|0 |1
is obsolete| |
Attachment #27570|0 |1
is obsolete| |
Attachment #27571|0 |1
is obsolete| |
Attachment #27572|0 |1
is obsolete| |
Attachment #27573|0 |1
is obsolete| |
Attachment #27574|0 |1
is obsolete| |
Attachment #27575|0 |1
is obsolete| |
Attachment #27576|0 |1
is obsolete| |
Attachment #27577|0 |1
is obsolete| |
Attachment #27578|0 |1
is obsolete| |
Attachment #27846|0 |1
is obsolete| |
Attachment #27847|0 |1
is obsolete| |
--- Comment #283 from Jonathan Druart ---
Created attachment 27848
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27848&action=edit
Bug 7180: Reset statistic values on reloading the page
On the "Default accounting details", if a dropdown list was created for
a statistic value, on reloading the page it still exist. It should not
given the fund value is reset.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:38:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:38:18 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #16 from M. de Rooy ---
Just an observation (no big deal):
If I have enabled email and sms for a patron, but I have no email address and
the SMS driver should fail, I have two messages in the queue that fall back to
PREDUE print. In this case you will have print duplicates. (Two runs now create
four PREDUE prints.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:45:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:45:28 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #17 from M. de Rooy ---
Similarly, if I clear the SMS number, sms messages will be sent to the queue
each time in status pending. They will fail only if process cronjob has been
run.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 09:49:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 07:49:58 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #18 from Katrin Fischer ---
It sounds to me like it would make sense not to try and create the message if
the sms number is not sent or make sure to only have one printed mail for a
fallback.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:02:07 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27829|0 |1
is obsolete| |
Attachment #27830|0 |1
is obsolete| |
Attachment #27831|0 |1
is obsolete| |
Attachment #27832|0 |1
is obsolete| |
Attachment #27833|0 |1
is obsolete| |
Attachment #27834|0 |1
is obsolete| |
Attachment #27835|0 |1
is obsolete| |
Attachment #27836|0 |1
is obsolete| |
Attachment #27837|0 |1
is obsolete| |
Attachment #27838|0 |1
is obsolete| |
Attachment #27839|0 |1
is obsolete| |
Attachment #27840|0 |1
is obsolete| |
Attachment #27841|0 |1
is obsolete| |
Attachment #27842|0 |1
is obsolete| |
Attachment #27843|0 |1
is obsolete| |
Attachment #27844|0 |1
is obsolete| |
Attachment #27845|0 |1
is obsolete| |
Attachment #27848|0 |1
is obsolete| |
--- Comment #284 from Jonathan Druart ---
Created attachment 27849
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27849&action=edit
Bug 7180: Order from staged file improvements
This patch adds:
- 1 syspref MarcFieldsToOrder
- 1 ajax script acqui/ajax-getauthvaluedropbox.pl
- 1 routine C4::Budgets::GetBudgetByCode
Before this patch you were not able to order 1 or all the records from
your staged file. You were allowed to specify some information ("Import All"
and "Accounting details" areas) for the order.
With this patch, the previous behaviours still exist.
But now you can *select* which records you want to ordered.
For these ones you can specify independently informations (Quantity,
price, budget, sort1 and sort2).
The cherry on the cake is that you can pre-fill these information with
values
Test plan:
1. Fill the new syspref MarcFieldsToOrder with something like:
==BEGIN==
price: 947$c
quantity: 969$h
budget_code: 922$a
rrp: 010$d
discount: 969$d
sort1: 923$a
sort2: 924$a
==END==
The empty line at the end is mandatory!
The budget (corresponding to your budget_code) can be filled with
authorized value categories (statistic 1 and 2).
The sort1 and sort2 values can be filled with the an authorized value
(of the category previously selected)
2. Choose randomly one or more biblio(s) and fill fields with what is relevant.
3. Export the biblio and import it (with the "Stage MARC records for
import" tool).
4. Go on a basket and add an order from a staged file. Select your
staged file.
5. Well. Now you can see your biblio (or biblios if your had exported
more than one). For each one, informations should be pre-filled with the
biblio values. The budget should be selected on the budget corresponding
to the budget_code (in the field 922$a) and the "planning values" too
(with fields 923$a and 924$a).
You can modify these values (or not) and choose a default value for
budget and planning values (in the "Accounting details" area).
6. Save and check the prices values. Modify the order and check that
budget and sort* are good
Prices are calculated following some parameters:
if there is no price => listprice = 0
else =>
- the gstrate value for your order is the gstrate value of the bookseller
- discount = if filled : the discount value / 100
else: the discount value of the bookseller
- if the bookseller includes tax( List item price includes tax: Yes )
if a discount exists:
ecost = price
rrp = ecost / ( 1 - discount )
else: # a discount does not exist
ecost = price * ( 1 - discount )
rrp = price
else # the bookseller does not include tax
if a discount exists:
ecost = price / ( 1 + gstrate )
rrp = ecost / ( 1 - discount )
else: # a discount does not exist
rrp = price / ( 1 + gstrate )
ecost = rrp * ( 1 - discount )
- in all cases:
listprice = rrp / currency rate
unitprice = ecost
total = ecost * quantity
7. Retry with different parameters
8. Check the 'Import all' action still works
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:02:16 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #285 from Jonathan Druart ---
Created attachment 27850
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27850&action=edit
Bug 7180: FIX getAuthValueDropbox should display the selected value
If the no AV match the name/category or if no category is defined, the
input field should contain the value.
Signed-off-by: Pierre Angot
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:02:25 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #286 from Jonathan Druart ---
Created attachment 27851
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27851&action=edit
Bug 7180: Add UT for C4::Budgets::GetBudgetByCode
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:02:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:02:58 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #287 from Jonathan Druart ---
Created attachment 27852
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27852&action=edit
Bug 7180: QA followup
Ergonomic improvements:
- Remove the green color the selected record.
- Use fieldset.rows (and legend).
- Use the required css class for quantity inputs.
- Replace "budget" with "fund".
- fix the "undefined" string
- Add a "show MARC" link
- replace "no_match" with a text.
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:03:09 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #288 from Jonathan Druart ---
Created attachment 27853
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27853&action=edit
Bug 7180: The default quantity is 1
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:03:29 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #289 from Jonathan Druart ---
Created attachment 27854
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27854&action=edit
Bug 7180: Follow-up fixing minor issues
- Fixed some labels from Budget to Fund
- Added the system preference to sysprefs.sql
- Fixed some untranslatable Javascript strings
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:03:32 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #19 from M. de Rooy ---
I have some doubts on this patch:
It could block lots of sms messages. You write: The sms part for DUE and PREDUE
should not contain dynamic parts, only a
standard message. But how do you prevent that (maybe apart from truncating the
message to 160 chars)?
If a message for a hold or a due does not contain a reference to the title, is
it still useful for a patron at all? I could imagine that you send one message
for dues at cronjob time, but what about Hold filled? Wouldn't that be a
candidate for sending more messages if applicable?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:03:39 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #290 from Jonathan Druart ---
Created attachment 27855
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27855&action=edit
Bug 7180: Change syspref description
- the blank line is now useless
- add an example for the syspref value
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:03:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:03:56 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #291 from Jonathan Druart ---
Created attachment 27856
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27856&action=edit
Bug 7180: Adapt neworderempty code (js function moved).
The js function fetchSortDropbox has been deleted in previous patch.
The new function is getAuthValueDropbox.
Test plan:
- link some av to some funds
- open an existing order and verify value are correctly filled in the
sort1 and sort2 values
- create a new order and verify behavior is the same as before
Note: This patch generates 2 ajax queries (max) if the budget is linked
to 2 av categories for sort1 and sort2. This could be improved using a
template plugin for values display on load.
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:04:07 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #292 from Jonathan Druart ---
Created attachment 27857
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27857&action=edit
Bug 7180: FIX License version
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:04:16 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #293 from Jonathan Druart ---
Created attachment 27858
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27858&action=edit
Bug 7180: QA followup
- fix unit tests (use a transaction).
- add 3 tabs on the page in order to be more understandable.
- fix a warn in logs
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:04:35 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #294 from Jonathan Druart ---
Created attachment 27859
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27859&action=edit
Bug 7180 - QA Followup - Correct minor language issues
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:04:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:04:48 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #295 from Jonathan Druart ---
Created attachment 27860
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27860&action=edit
Bug 7180: Restore the "Add order" link
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:05:05 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #296 from Jonathan Druart ---
Created attachment 27861
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27861&action=edit
Bug 7180: Remove useless rrp variable
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:05:17 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #297 from Jonathan Druart ---
Created attachment 27862
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27862&action=edit
Bug 7180: FIX: discount was divided by 100 twice.
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:05:25 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #298 from Jonathan Druart ---
Created attachment 27863
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27863&action=edit
Bug 7180: fetch_sort_dropbox.pl is not in use anymore
Test plan:
git grep fetch_sort_dropbox
should return no result.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:05:42 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #299 from Jonathan Druart ---
Created attachment 27864
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27864&action=edit
Bug 7180: QA followup 2
This patch takes into account all QA failures raised in comment 207.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:05:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:05:58 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #300 from Jonathan Druart ---
Created attachment 27865
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27865&action=edit
Bug 7180: QA followup 3
1/ showmarc.pl takes the importid for staged files.
2/ small note to indicate that the vendor's discount will be used if no
discount is filled.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:06:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:06:25 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #301 from Jonathan Druart ---
Created attachment 27866
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27866&action=edit
Bug 7180: Reset statistic values on reloading the page
On the "Default accounting details", if a dropdown list was created for
a statistic value, on reloading the page it still exist. It should not
given the fund value is reset.
Signed-off-by: Katrin Fischer
Testing notes are on the bug report.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:07:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:07:42 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180
--- Comment #302 from Jonathan Druart ---
I reuploaded patches from my local branch, so without the Katrin's SO.
Last patch set contains the SO!
Sorry for the confusion.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 10:25:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 08:25:42 +0000
Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are
sent for a patron
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209
--- Comment #20 from Jonathan Druart ---
(In reply to M. de Rooy from comment #16)
> If I have enabled email and sms for a patron, but I have no email address
> and the SMS driver should fail, I have two messages in the queue that fall
> back to PREDUE print. In this case you will have print duplicates. (Two runs
> now create four PREDUE prints.)
This has already been raised by Olli, he opened a report, bug 11561.
(In reply to M. de Rooy from comment #17)
> Similarly, if I clear the SMS number, sms messages will be sent to the queue
> each time in status pending. They will fail only if process cronjob has been
> run.
Yes, a test could be added somewhere. But it should not append (yes you can via
the UI, but it is a configuration issue).
(In reply to M. de Rooy from comment #19)
> I have some doubts on this patch:
> It could block lots of sms messages. You write: The sms part for DUE and
> PREDUE should not contain dynamic parts, only a
> standard message. But how do you prevent that (maybe apart from truncating
> the message to 160 chars)?
> If a message for a hold or a due does not contain a reference to the title,
> is it still useful for a patron at all? I could imagine that you send one
> message for dues at cronjob time, but what about Hold filled? Wouldn't that
> be a candidate for sending more messages if applicable?
Maybe could I add a condition in the sql query like " AND content =
$message->{content}".
Like that, if the template contains dynamic parts, that won't match.
What do you think about that?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:07:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:07:38 +0000
Subject: [Koha-bugs] [Bug 12168] New: Spent and ordered budget values are
wrong if deep > 2
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Bug ID: 12168
Summary: Spent and ordered budget values are wrong if deep > 2
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart at biblibre.com
QA Contact: testopia at bugs.koha-community.org
A really weird (and old) code process the calculation for the spent and ordered
sublevel funds.
It only takes into account the direct children.
So if you have:
fund1 (spent=100) parent of fund11 (spent=10) parent of fund111 (spent=1), you
get:
fund | base-level | total spent
fund1 | 100 | 110
fund11 ?| 10 | 11
fund111 | 1 | 1
which is wrong, it should be
fund | base-level | total spent
fund1 | 100 | 111
fund11 | 10 | 11
fund111 | 1 | 1
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:08:11 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
|ity.org |m
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:08:40 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12164
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:08:40 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12168
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:08:48 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Depends on|12168 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:08:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:08:48 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|12164 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:09:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:09:08 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12164
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:09:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:09:08 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12168
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:30:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:30:57 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:31:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:31:00 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
--- Comment #1 from Jonathan Druart ---
Created attachment 27867
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27867&action=edit
Bug 12168: Spent and ordered budget values are wrong if deep > 2
A really weird (and old) code process the calculation for the spent and
ordered sublevel funds.
It only takes into account the direct children.
So if you have:
fund1 (spent=100) parent of fund11 (spent=10) parent of fund111 (spent=1), you
get:
fund | base-level | total spent
fund1 | 100 | 110
fund11 | 10 | 11
fund111 | 1 | 1
which is wrong, it should be
fund | base-level | total spent
fund1 | 100 | 111
fund11 | 10 | 11
fund111 | 1 | 1
Test plan:
- Create 1 budget and 3 funds with the same structure as above.
- Create some orders and receive them (not all).
- Go on the fund list view and verify the values are correct.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 14:31:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 12:31:06 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
--- Comment #2 from Jonathan Druart ---
Created attachment 27868
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27868&action=edit
Bug 12168: Add unit tests for GetBudgetHierarchySpent GetBudgetHierarchyOrdered
Test plan:
prove t/db_dependent/Budgets.t
Note: This addition may sound overkill but I found this bug developping
bug 12164 and I will reuse all of that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:13:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:13:48 +0000
Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25573|0 |1
is obsolete| |
--- Comment #8 from Bernardo Gonzalez Kriegel ---
Created attachment 27869
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27869&action=edit
[SIGNED-OFF] Bug 11826: Add XSLT handler object to Koha namespace
In achieving the goals of umbrella report 6536 (Z3950 improvements), this
report adds a XSLT handler object to the Koha namespace.
A follow-up adds unit tests for this module.
This patch does not yet incorporate the new object into Z3950 search. So
it does not change any behavior and is therefore harder to test.
Test plan:
Run the unit tests of the follow-up patch on report 11826.
Signed-off-by: Marcel de Rooy
I tested the new module in two additional ways:
[1] Made a simple script (four lines as below) that ran a larger xml file
with 1500 records through a test XSLT file modifying the title.
my $eng= Koha::XSLT_Handler->new;
open my $fh1, '<', '_example_file';
my @xml= <$fh1>;
print $eng->transform( join('', @xml), '_example_xsl_file');
[2] Incorporated the object into my local changes of Breeding.pm (based on
older work, not ready for submittal now).
Ran transformation on Z3950 search results. Worked well :)
Signed-off-by: Bernardo Gonzalez Kriegel
Test runs Ok. No koha-qa errors.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:13:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:13:56 +0000
Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25574|0 |1
is obsolete| |
--- Comment #9 from Bernardo Gonzalez Kriegel ---
Created attachment 27870
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27870&action=edit
[SIGNED-OFF] Bug 11826: Add unit tests for Koha::XSLT_Handler
Test plan:
Verify if XSLT_Handler.t passes.
You could also sabotage the test by removing one of the test xsl files.
Or you could 'repair' the bad xsl file (test02). Remove the second line
redefining the xsl variable.
In all those cases the unit test should fail now.. Discard your changes :)
Signed-off-by: Bernardo Gonzalez Kriegel
Test pass. No koha-qa errors.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:14:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:14:05 +0000
Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27229|0 |1
is obsolete| |
--- Comment #10 from Bernardo Gonzalez Kriegel ---
Created attachment 27871
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27871&action=edit
[SIGNED-OFF] Bug 11826: Using the XSLT handler in C4/XSLT module
Incorporate the new object into C4/XSLT module.
The handler object needed one adjustment to allow for passing URLs.
Removed the GetURI function; it is no longer needed.
Added some documentation lines.
Moved a file-level lexical upwards in the code for visibility.
Removed some tabs (on two lines).
Note: The handler could perhaps be moved up to the Context module, or be saved
in a global ('our') variable. But I would rather not do that now, making
testing not too complex at this moment.
Test plan:
Enable XSLT preferences for opac and intranet.
Check result and detail pages.
Check individual list display (virtual shelves).
Force an XSLT error by editing one of your xsl files. Check the
corresponding display.
Put an URL in one the XSLT prefs (could just be to your own server).
Check the display.
Signed-off-by: Marcel de Rooy
Running XSLTParse4Display in a loop showed no significant performance change.
One pass cost me around 0.012 sec (except for the first pass).
Signed-off-by: Bernardo Gonzalez Kriegel
Results, detail, url and list view Ok
No koha-qa errors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:14:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:14:13 +0000
Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27230|0 |1
is obsolete| |
--- Comment #11 from Bernardo Gonzalez Kriegel ---
Created attachment 27872
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27872&action=edit
[SIGNED-OFF] Bug 11826: Use xslt handler object in showmarc, Record.pm
Modifies showmarc and opac-showmarc to use new xslt handler.
Removes cardview.pl as obsolete script.
Modifies C4/Record.pm and a typo in the test Record.t.
Test plan:
[1] catalogue/showmarc: Go to Cataloging. Search. Click Card.
[2] opac-showmarc: Go to opac detail, MARC view.
Open URL for plain view in new tab.
Change URL: Change viewas=html to viewas=card
[3] Verify that there are no references in the codebase to cardview.pl
[4] C4/Record.pm: Run the Record.t test in db_dependent.
This test uses marc2modsxml, triggering the change.
Additional: export to MODS from opac-detail.
Signed-off-by: Bernardo Gonzalez Kriegel
Views Ok. Test pass. No more cardview. No koha-qa errors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:14:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:14:35 +0000
Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:31:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:31:25 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #9 from M. de Rooy ---
I'm seeing this code in the Itiva cronjob:
my $letter = C4::Letters::GetPreparedLetter(
module => $module,
letter_code => $code,
tables => {
borrowers => $issues->{'borrowernumber'},
biblio => $issues->{'biblionumber'},
biblioitems => $issues->{'biblionumber'},
message_transport_type => 'phone',
},
message_transport_type => 'phone',
);
The duplicated mtt seems odd to me. Is that correct?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:39:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:39:29 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
--- Comment #10 from Jonathan Druart ---
(In reply to M. de Rooy from comment #9)
> The duplicated mtt seems odd to me. Is that correct?
No, it seems that the one introduced by bug 10845 is wrong. I will provide
follow-ups.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:42:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:42:03 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
--- Comment #11 from M. de Rooy ---
Please add the bug number too in the print message of updatedatabase
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:43:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:43:20 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
--- Comment #12 from Jonathan Druart ---
Created attachment 27873
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27873&action=edit
Bug 11867: FIX message_transport_type parameter for Itiva cronjob
The message_transport_type param should passed to GetPreparedLetter, not
part of the "tables" parameter.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:43:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:43:59 +0000
Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845
--- Comment #33 from Jonathan Druart ---
Created attachment 27874
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27874&action=edit
Bug 10845: FIX message_transport_type parameter for Itiva cronjob
The message_transport_type param should passed to GetPreparedLetter, not
part of the "tables" parameter.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:44:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:44:32 +0000
Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845
--- Comment #34 from Jonathan Druart ---
Last patch fixes a problem raised by Marcel in bug 11867 comment 9.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:46:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:46:18 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27820|0 |1
is obsolete| |
Attachment #27873|0 |1
is obsolete| |
--- Comment #13 from Jonathan Druart ---
Created attachment 27875
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27875&action=edit
Bug 11867: MTT: Manage *_PHONE notices
The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should
be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE).
Test plan:
1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices
2/ Execute the update DB entry
3/ Verify the 3 notices have been merged into "phone" template of the
HOLD, PREDUE and OVERDUE notices
4/ Verify there is no regression in the Talking Tech feature (how?)
Signed-off-by: Bernardo Gonzalez Kriegel
No koha-qa errors
Verified that notices are merged
TalkingTech_itiva_outbound.pl runs without problem... but can't produce
any output, may be not correctly configured (my setup), no warnings
nor log messages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:46:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:46:51 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
--- Comment #14 from Jonathan Druart ---
Patch rebased on top of bug 9016 and bug 10845.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:49:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:49:33 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27875|0 |1
is obsolete| |
--- Comment #15 from Jonathan Druart ---
Created attachment 27876
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27876&action=edit
Bug 11867: MTT: Manage *_PHONE notices
The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should
be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE).
Test plan:
1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices
2/ Execute the update DB entry
3/ Verify the 3 notices have been merged into "phone" template of the
HOLD, PREDUE and OVERDUE notices
4/ Verify there is no regression in the Talking Tech feature (how?)
Signed-off-by: Bernardo Gonzalez Kriegel
No koha-qa errors
Verified that notices are merged
TalkingTech_itiva_outbound.pl runs without problem... but can't produce
any output, may be not correctly configured (my setup), no warnings
nor log messages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 15:50:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 13:50:06 +0000
Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE
notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867
--- Comment #16 from Jonathan Druart ---
Last patch adds the bug number in the updatedb entry.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:12:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:12:09 +0000
Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong
if deep > 2
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27868|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 27877
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27877&action=edit
Bug 12168: Add unit tests for GetBudgetHierarchySpent GetBudgetHierarchyOrdered
Test plan:
prove t/db_dependent/Budgets.t
Note: This addition may sound overkill but I found this bug developping
bug 12164 and I will reuse all of that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:16:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:16:09 +0000
Subject: [Koha-bugs] [Bug 12169] New: Improve reliability of sip_shutdown
script
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169
Bug ID: 12169
Summary: Improve reliability of sip_shutdown script
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: colin.campbell at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
the sip_shutdown script rightly announces the brittleness of it approach to
identifying the process to kill.
A more reliable method is available by getting the server to use the standard
approach of writing a pidfile which is part of Net::Server's functionality.
Change script to use this and alter config scripts accordingly
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:33:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:33:47 +0000
Subject: [Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169
Colin Campbell changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
|ity.org |com
--- Comment #1 from Colin Campbell ---
Created attachment 27878
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27878&action=edit
Proposed patch
Adds options to sample config and simplifies sample shutdown script
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:40:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:40:03 +0000
Subject: [Koha-bugs] [Bug 12170] New: log serial alert emails
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12170
Bug ID: 12170
Summary: log serial alert emails
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
Would be great if the logs of messages included the emails sent to people who
subscribed to a serial.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:47:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:47:22 +0000
Subject: [Koha-bugs] [Bug 12171] New: Make Quick Spine Label Creator Quicker
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12171
Bug ID: 12171
Summary: Make Quick Spine Label Creator Quicker
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: gmcharlt at gmail.com
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
We would like to see this process have options for streamlining. Would like to
see options for printing as soon as the barcode is scanned. No button
clicking. Just scan, and then after printing, it clears the text box and is
ready for the next barcode.
Christopher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:48:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:48:18 +0000
Subject: [Koha-bugs] [Bug 459] No uninstall script
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|mtompset at hotmail.com |gmcharlt at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 16:48:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 14:48:55 +0000
Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug
7567
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |mtompset at hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 17:07:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 15:07:36 +0000
Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to
Bootstrap OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165
--- Comment #2 from Marc V?ron ---
Created attachment 27879
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27879&action=edit
[Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap
Opac theme
1) Create an account with lots of different charges, fines, fees, etc.
2) Look at the accouts tab in the prog OPAC theme
3) Compare the page to bootstrap theme
4) Verify display is now the same
In my tests I found some things that could still be improved,
but for the goal is to make all OPAC themes behave the same.
Tested by changing accounttype in table accountlines to all possible values
like Pay, Pay00, Pay01 etc.
Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for
Pay00
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 17:08:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 15:08:11 +0000
Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to
Bootstrap OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27821|0 |1
is obsolete| |
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 17:08:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 15:08:21 +0000
Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to
Bootstrap OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:18:20 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27585|0 |1
is obsolete| |
--- Comment #131 from Bernardo Gonzalez Kriegel ---
Created attachment 27880
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27880&action=edit
Bug 11944: Remove all utf8 filter from templates
This patch
- removes all html_entity usages in tt file which hide utf8 bugs
- removes all encode utf8 in tt plugins because we should get correctly
marked data from DBIC and other sources directly (cf plugin EncodeUTF8
used in renew.tt)
- adds some cleanup in C4::Templates::output: we now use perl utf8 file
handler output so we don't need to decode tt variables manually.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
My comments on last patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:18:30 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27586|0 |1
is obsolete| |
--- Comment #132 from Bernardo Gonzalez Kriegel ---
Created attachment 27881
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27881&action=edit
Bug 11944: replace use of utf8 with Encode
See the wiki page for the explanation.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:18:42 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27587|0 |1
is obsolete| |
--- Comment #133 from Bernardo Gonzalez Kriegel ---
Created attachment 27882
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27882&action=edit
Bug 11944: Encoding UTF8 in C4::Templates
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:18:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:18:52 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27588|0 |1
is obsolete| |
--- Comment #134 from Bernardo Gonzalez Kriegel ---
Created attachment 27883
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27883&action=edit
Bug 11944: Set ImplicitUnicode for YAML
Before this patch, string for yaml files used in preferences.pl were
broken.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:19:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:19:02 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27589|0 |1
is obsolete| |
--- Comment #135 from Bernardo Gonzalez Kriegel ---
Created attachment 27884
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27884&action=edit
Bug 11944: Library name variable should be decoded
Test on preferences.pl and on some others pages when mysql is used to
store session.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:24:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:24:39 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bgkriegel at gmail.com
--- Comment #136 from Bernardo Gonzalez Kriegel ---
I'm in the process of sign, but have problems to upload some patches with
git-bz.
I'm out for a moment, will finish soon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:35:20 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27590|0 |1
is obsolete| |
--- Comment #137 from Bernardo Gonzalez Kriegel ---
Created attachment 27885
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27885&action=edit
Bug 11944: replace uri_escape with uri_escape_utf8 everywhere
To reproduce, edit, index notice with XXX and search "XXX"
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
XXX = removed char, because of git-bz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:35:31 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27591|0 |1
is obsolete| |
--- Comment #138 from Bernardo Gonzalez Kriegel ---
Created attachment 27886
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27886&action=edit
Bug 11944: Never use decode/encode in TT Plugins
The EncodeUTF8 TT plugin is useless, we should NEVER use encode in
templates.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:35:43 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27592|0 |1
is obsolete| |
--- Comment #139 from Bernardo Gonzalez Kriegel ---
Created attachment 27887
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27887&action=edit
Bug 11944: Remove obsolete encoding routines
We don't need to decode manually which provide nice performance boost.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:35:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:35:54 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27593|0 |1
is obsolete| |
--- Comment #140 from Bernardo Gonzalez Kriegel ---
Created attachment 27888
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27888&action=edit
Bug 11944: TT Plugins should not encode strings
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:36:06 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27594|0 |1
is obsolete| |
--- Comment #141 from Bernardo Gonzalez Kriegel ---
Created attachment 27889
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27889&action=edit
Bug 11944: Some refresh don't indicate the charset to use
This patch replaces occurrences of META HTTP-EQUIV=Refresh with a
redirection.
Note:
The list of modified files has been got with the following grep:
git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator |
grep -v \.js
Test plan:
1) admin/auth_tag_structure.pl
- Go on an authority MARC framework for an authority type
(admin/auth_tag_structure.pl?authtypecode=CO for instance)
- Click on the "Add a new tag" button
- Fill fields
- Save
- You should be redirected on the auth_tag_structure.pl page
- Try to modify an existing tag
- The redirection should be done
2) admin/auth_subfields_structure.pl
- From the previous page, click on a "subfields" link
- Edit/Add a new subfields
- Save
- You should be redirected to the subfield list
- Delete a subfield
- You should be redirected to the subfield list
3) admin/authorised_values.pl
- Add/Edit an authorised value
- Save
- You should be redirected to the authorised value list (with the
right category selected)
4) admin/categorie.pl
- Add/Edit a patron category
- Save
- You should be redirected to the category list
- Delete a patron category
- You should be redirected to the category list
5) admin/koha2marclinks.pl
- Go on the Koha to MARC mapping configuration page
- Edit a field
- Map a field and click on "OK"
- You should be redirected to the list
6) admin/marc_subfields_structure.pl
- Go on the MARC frameworks page
- Click on "MARC structure" for one on the list
- Click on "Subfields" for one on the list
- Add/Edit a subfield
- Save
- You should be redirected to the subfield list
7) admin/systempreferences.pl
- Go on the system preferences admin page
- Click on the "Local use" tab
- Add/Edit a pref
- Save
- You shold be redirected to the Local use preference list
8) serials/subscription-detail.pl
- Go on a subscription detail page
- Delete the subscription (using Edit > Delete subscription)
- You should be redirected on the serials home page
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:36:19 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27595|0 |1
is obsolete| |
--- Comment #142 from Bernardo Gonzalez Kriegel ---
Created attachment 27890
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27890&action=edit
Bug 11944: FIX Error on editing an authority
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:36:30 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27596|0 |1
is obsolete| |
--- Comment #143 from Bernardo Gonzalez Kriegel ---
Created attachment 27891
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27891&action=edit
Bug 11944: Fix encoding issue on searching
The search patch should fix non-latin character searches.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:36:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:36:41 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27597|0 |1
is obsolete| |
--- Comment #144 from Bernardo Gonzalez Kriegel ---
Created attachment 27892
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27892&action=edit
Bug 11944: Facets and resort
This patch should fix facets and resort encoding issues.
Note: This patch will certainly break the search history
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:43:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:43:33 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27598|0 |1
is obsolete| |
--- Comment #145 from Bernardo Gonzalez Kriegel ---
Created attachment 27893
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27893&action=edit
Bug 11944: Authentication
The password should be encoded before hashing.
Test plan:
- Before applying the patch, create a user with a password "XXXX"
- apply patches
- try to log in
- change the password
- log out
- try to log in
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
replaced string with XXXX, sorry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:43:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:43:45 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27599|0 |1
is obsolete| |
--- Comment #146 from Bernardo Gonzalez Kriegel ---
Created attachment 27894
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27894&action=edit
Bug 11944: Fix fund names encoding on the parcel page
On the parcel page, the subtotal values are stored in an hashref. The
key was the fund name. The fund name being encoded in utf8, the hashref
was broken.
This patch replaces this logic creating a key based on an integer.
The budget name is now stored in a new "budget_name" key.
Note: It also fixes a small ergonomic issue (a td was missing in the
tfoot).
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:44:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:44:01 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27600|0 |1
is obsolete| |
--- Comment #147 from Bernardo Gonzalez Kriegel ---
Created attachment 27895
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27895&action=edit
Bug 11944: Fix encoding issue on adding a subscription
If frequencies or numbering patterns contain non-latin characters, so
output was broken.
To reproduce:
- Create a frequency and a numbering pattern with non-latin characters
- Add a new subscription using these values
- The screen should not contain bad encoded characters.
Signed-off-by: Paola Rossi
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 1 18:44:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 May 2014 16:44:16 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27601|0 |1
is obsolete| |
--- Comment #148 from Bernardo Gonzalez Kriegel ---
Created attachment 27896
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27896&action=edit
Bug 11944: use CGI( -utf8 ) everywhere
Signed-off-by: Paola Rossi