[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

--- Comment #21 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 27466
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27466
[PASSED QA] Bug 8769 - Allow SIP2 return backdating

Review of attachment 27466:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8769&attachment=27466)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +1780,4 @@
>      }
>  
>      # case of a return of document (deal with issues and holdingbranch)
> +    my $today = dt_from_string( $return_date, 'iso' );

This makes me nervous.  Besides the comments that Colin made about this change
in bug 10694, a variable named $today that doesn't necessarily contain today's
date is ... confusing.  Also, it is not clear to be why this would be part of
the SIP2 change.

Can you explain the purpose of this line?

-- 
You are receiving this mail because:
You are watching all bug changes.