[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Galen Charlton from comment #21)
> Comment on attachment 27466 [details] [review]
> [PASSED QA] Bug 8769 - Allow SIP2 return backdating
> 
> Review of attachment 27466 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Circulation.pm
> @@ +1780,4 @@
> >      }
> >  
> >      # case of a return of document (deal with issues and holdingbranch)
> > +    my $today = dt_from_string( $return_date, 'iso' );
> 
> This makes me nervous.  Besides the comments that Colin made about this
> change in bug 10694, a variable named $today that doesn't necessarily
> contain today's date is ... confusing.  Also, it is not clear to be why this
> would be part of the SIP2 change.
> 
> Can you explain the purpose of this line?

After some examination, I have concluded that this change serves no useful
purpose and only causes code obfuscation. I have attached a followup to revert
that line of code. I believe the change is vestigial from a time before this
feature was dependent on bug 10694.

-- 
You are receiving this mail because:
You are watching all bug changes.