[Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 25888
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25888
Bug 11733: gist can be multi-valued

Review of attachment 25888:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11733&attachment=25888)
-----------------------------------------------------------------

::: acqui/basketgroup.pl
@@ +82,5 @@
> +            unless ( defined $gst ) {
> +                ($gst) = split /\|/, C4::Context->preference("gist");
> +            }
> +            $gst //= 0;
> +            $total = $total * ( $gst / 100 + 1 );

I think there is another bug lurking here.  The 'gist' contains a list of
decimal values, so dividing the default one by 100 leads to the wrong result if
the default tax rate isn't 0.

-- 
You are receiving this mail because:
You are watching all bug changes.