[Koha-bugs] [Bug 11672] Untranslatable report areas in step 1 of Guided Reports

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to paxed from comment #3)
> (In reply to Owen Leonard from comment #2)
> > This looks good to me as far as functionality goes, but Koha's templates use
> > the American "Catalog" instead of "Catalogue."
> > 
> 
> C4/Reports/Guided.pm, where those values came from:
>     [CAT  => "Catalogue"],

Yes of course it's logical to have used that spelling since you were
referencing the text in the script. However you will find that in the default
en templates the standard spelling is "Catalog."

> > [% BLOCK translate_report_areas %]
> > [%  SWITCH area %]
> > [%   CASE 'CIRC' %]Circulation
> > [%   CASE 'CAT'  %]Catalogue
> > [%   CASE 'PAT'  %]Patrons
> > [%   CASE 'ACQ'  %]Acquisition
> > [%   CASE 'ACC'  %]Accounts
> > [%  END %]
> > [% END %]
>
> Define standard indentation. I see no mention of indentation for the
> templates in the coding guidelines.

Again, sometimes the standard is simply, "what you see consistently in other
templates." Indentation isn't always consistent, but generally speaking I would
consider standard indentation to be:

[% BLOCK translate_report_areas %]
    [% SWITCH area %]
        [% CASE 'CIRC' %]Circulation
        [% CASE 'CAT' %]Catalogue
        [% CASE 'PAT' %]Patrons
        [% CASE 'ACQ' %]Acquisition
        [% CASE 'ACC' %]Accounts
    [% END %]
[% END %]

I think this kind of indentation helps others more easily understand the
logical structure of the template tags. It also works better with a text
editor's indentation tools.

That's just my opinion of course and a discussion on the developer's list could
help sort it out.

-- 
You are receiving this mail because:
You are watching all bug changes.