[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 7 16:37:38 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #10)
> Patch doesn't apply.

It is only a unit file which was already deleted.

> Of more note, the change to C4::Search::History::add seems unrelated and
> dangerous, as no current callers of C4::Search::History:add seem to be
> passing a time parameter.

I don't understand why it is dangerous. Actually the search_history.time field
has a default value in DB. I need to pass some hardcoded time (further back in
time) for unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list