[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #57 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #56)
> Maybe we could take a step by step approach here? 
> 
> Currently we are sending out incomplete emails and making the way we create
> the links consistent, will take a lot more work.
> 
> We have code in Auth.pm that produces working links for the opac cart email,
> but doesn't use OpacBaseUrl. And the links in the opac list emails are
> broken.
> 
> The first patch was just trying to copy the logic from the cart email for
> the opac list email, so both would create the links the same way using the
> same lines of code. Maybe this could be still be a valid first step?

I would not mind passing QA on the first patch, overriding opacbaseurl with the
stuff from Auth.pm as a temporary measure. (Maybe adding a comment somewhere?)
But the lines in Auth.pm:
            OPACBaseURL               => ($in->{'query'}->https() ? "https://"
: "http://") . $ENV{'SERVER_NAME'} .
                   ($ENV{'SERVER_PORT'} eq ($in->{'query'}->https() ? "443" :
"80") ? '' : ":$ENV{'SERVER_PORT'}"),

should actually be adjusted when resolving the various OpacBaseURL bugs. Note
that there was an issue too with the https function and Plack..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.