[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #61 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. de Rooy from comment #57)
> But the lines in Auth.pm:
>             OPACBaseURL               => ($in->{'query'}->https() ?
> "https://" : "http://") . $ENV{'SERVER_NAME'} .
>                    ($ENV{'SERVER_PORT'} eq ($in->{'query'}->https() ? "443"
> : "80") ? '' : ":$ENV{'SERVER_PORT'}"),
> 
> should actually be adjusted when resolving the various OpacBaseURL bugs.
> Note that there was an issue too with the https function and Plack..

One could run their staff and OPAC clients on different ports. I'm not saying
every combination is sane, but every combination is not accounted for with that
code. This code does not account for the sane combination of https (staff) and
http (OPAC), nor the strange combination of http (staff) and https (OPAC).

The best way, without the OpacProtocol system preference, is a full-out across
the board fix the hard coded 'http' 'https' messes, and require the protocol in
OPACBaseURL.

The problem with this solution is that it is much larger to implement, because
if you put http(s) into your OPACBaseURL, you'll get http://http(s):// in
locations you haven't fixed yet.

If Katrin can fix all the OPACBaseURLs, that would be great. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.