[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

--- Comment #183 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #182)
> (In reply to Jonathan Druart from comment #181)
> I need some expert too: what is the best way to handle the
> uri_escape/unescape and the uri, url, html TT filters?
> There are a lot of all of that in include files, results.tt, search.pl and
> Seach.pm...

Looking at unescape:

uri_escape_utf8 encodes data before escaping, so expects perl internal format
(what you should normally have..)
uri_escape and uri_unescape operate on byte level; so you should normally
expect to decode their output in your program.
Also note that CGI normally handles escaping/unescaping for params. So it seems
that some unescaping in catalogue/search.pl and opac-search.pl is useless.

The unescape in members/paycollect.pl is not decoded. Could be a problem.
In cataloguing/additem a cookie is unescaped and thawed. Should be checked.

This one is confusing (opac-search):
my @query_inputs = _input_cgi_parse($query_cgi);
$template->param ( QUERY_INPUTS => \@query_inputs );
$query_cgi comes from buildQuery and contains uri_escape_utf8ed string (so:
encoded data)
_input_cgi_parse runs a part through uri_unescape, so still encoded.
we pass it to the template in encoded form: Does it get mixed up with decoded
data here?

C4/Search/History:
decode_json( uri_unescape( $session->param('search_history') ) )
$session is a CGI Session object: How does it handle utf8?
uri_unescape operates on byte level
decode_json expects an encoded string
Should be checked. Not sure if the output is encoded or decoded in perl.

-- 
You are receiving this mail because:
You are watching all bug changes.