[Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon May 12 17:11:53 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 27992
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27992
Bug 7981 - Transfer message when returning doesn't properly respect
HomeOrHoldingBranchReturn syspref
Review of attachment 27992:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7981&attachment=27992)
-----------------------------------------------------------------
And some trailing spaces
FAIL t/db_dependent/Circulation_Branch.t
OK pod
FAIL forbidden patterns
forbidden pattern: trailing space char (line 319)
forbidden pattern: trailing space char (line 311)
forbidden pattern: trailing space char (line 323)
forbidden pattern: trailing space char (line 327)
forbidden pattern: trailing space char (line 315)
Marked as Failed QA.
::: C4/Circulation.pm
@@ +1976,3 @@
> $messages->{'WasTransfered'} = 1;
> } else {
> + $messages->{'NeedsTransfer'} = $returnbranch;
Why don't you keep needstransfer = 1 ?
You don't use this value later.
::: circ/returns.pl
@@ +272,5 @@
> title => $biblio->{'title'},
> homebranch => $biblio->{'homebranch'},
> + homebranchname => GetBranchName( $biblio->{'homebranch'} ),
> + returnbranch => $returnbranch,
> + returnbranchname => GetBranchName( $returnbranch ),
Please use the Branches TT plugin to get a branch name from its code.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list