[Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 28202
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28202
Allow hiding branches from the OPAC search pulldowns

Review of attachment 28202:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12242&attachment=28202)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +417,5 @@
> +                    \@include_branches;
> +                } else {
> +                    $tmpbranches;
> +                }
> +            },

Inline functions like this are difficult to maintain. They are also difficult
to write tests for.

If you modify C4 or Koha libraries, you need to write a test. This is only
possible if you write this as a function.

I'm assuming GetBranchesLoop is in C4/Branches, and I think this function would
better fit there.

This also seems like a convoluted way of doing it, but I could be wrong.

::: installer/data/mysql/sysprefs.sql
@@ +235,4 @@
>  ('OPACFRBRizeEditions','0','','If ON, the OPAC will query one or more ISBN web services for associated ISBNs and display an Editions tab on the details pages','YesNo'),
>  ('opacheader','','70|10','Add HTML to be included as a custom header in the OPAC','Textarea'),
>  ('OpacHiddenItems','','','This syspref allows to define custom rules for hiding specific items at opac. See docs/opac/OpacHiddenItems.txt for more informations.','Textarea'),
> +('OpacHideBranches','',NULL,'Hide these branches from OPAC search branches pull-down. (Use short branch names, separated by pipe-characters.)','Free'),

I'm not sure a system preference is the best way to do it, because you also
have search groups which could show up in the drop downs.

Perhaps modifications to the library and group entry screens?

-- 
You are receiving this mail because:
You are watching all bug changes.