[Koha-bugs] [Bug 12279] Diacritics in system preference editor broken

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12279

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28377|0                           |1
        is obsolete|                            |

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 28378
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28378&action=edit
[SIGNED-OFF] Bug 12279: Diacritics in system preference editor broken

This patch changes how .pref files are read. Instead of going through
all our global ultra-tweaked template object, we only use gettemplate
to build the correct file name (path included) and load it using the
(at functional) YAML::Syck::LoadFile method.

Pros: Doesn't break anything for YAML::Syck pre-1.27 (the ones shipped with
      Ubuntu 14.04)
Cons: something is wrong with C4::Templates encoding/decoding, or at least
      our default setup using C4::Templates->new doesn't work properly for
      all file types.

To test:
- On clean master, install a translation like:
  cd misc/translator ; perl translate install fr-FR
- Go to sysprefs, opac
=> FAIL: descriptions are encoding-broken
- Apply the patch, reload
=> SUCCESS: Everything shows ok

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Works ok, no errors
Test:
1) with YAML::Syck 1.19, no problems before, translated preferences
encode diacritics, ej. '\xC3\xA8' for grave accented e
Page shows correctly
2) with YAML:Syck 1.27, translated preferences have unencoded diacritics,
without patch display is broken, with patch it shows correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.