[Koha-bugs] [Bug 11292] barcode scanner clicking 'save'

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off
                 CC|                            |gmcharlt at gmail.com

--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to M. de Rooy from comment #11)
> (In reply to Jonathan Druart from comment #10)
> > Shouldn't we add the noEnterSubmit class to the elements?

Or to the form itself. That would be a more minimal fix, and more consistent.

> This can be pushed in its current state.
> Note that it is referring to cataloging.js instead of staff-global.js where
> a keypress is active on class noEnterSubmit.

Marcel, have you tested /all/ of the interfaces that this patch touches?  By
changing cataloging.js and matching on .input_marceditor, a bunch of forms are
affected, not just the main cataloging editor:

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt (and here
accepting this patch means that there would be /two/ handlers trying to prevent
form submission via the enter key)
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt

Now, that isn't necessarily a problem -- as arguably none of these forms should
be submittable using the enter key, but this patch is an example of one where
the test plan does not account for all of the side effects.

> I agree that another report could bring these two closer (achieving more
> consistency..)

Why wait?  Why not insist on consistency now as opposed to adding
inconsistency?

This doesn't necessarily /require/ a counter-patch now, but I am setting back
to 'signed off' pending confirmation that all of the forms that this patch
affects have been tested, particularly the item editor.

-- 
You are receiving this mail because:
You are watching all bug changes.