From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:29:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:29:21 +0000 Subject: [Koha-bugs] [Bug 12730] Pre-due Notices not being sent. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:29:09 +0000 Subject: [Koha-bugs] [Bug 12730] Pre-due Notices not being sent. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Jesse, is this still a problem? I haven't seen similar in our 3.16 installations, but we are not using phone notifications. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:30:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:30:18 +0000 Subject: [Koha-bugs] [Bug 13048] Serial Error when NULL date encountered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|blocker |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:32:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:32:49 +0000 Subject: [Koha-bugs] [Bug 12774] Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I suspect this could be a duplicate of bug 12730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:36:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:36:00 +0000 Subject: [Koha-bugs] [Bug 10870] can't create a profile for patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- I tested on current master and creating patron card creator profiles works ok for me. Closing this as it does not seem to be reproducable and 3.10 is no longer maintained. Please open a new bug if problem reappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:39:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:39:39 +0000 Subject: [Koha-bugs] [Bug 9491] can't see all funds from basket with 'show all' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9491 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- 3.8 is no longer maintained and I believe this has been fixed since this was reported. There are also more patches waiting in PQA, that will change that page quite a bit. Please file a new bug if the problem shows up again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 07:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 06:57:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #156 from Katrin Fischer --- ... and still working on it right now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 09:49:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 08:49:13 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #157 from Katrin Fischer --- Hi Kyle, I tried to test this last minute, but I found a blocker: Changing the allowance from the 'personal details' page is not being saved. I tried using the update button and also make a full change request, nothing worked. Firefox shows a network error: NetworkError: 404 Not Found - http://localhost/cgi-bin/koha/svc/patron/show_checkouts_to_relatives If Javscript is needed to make this work, please also consider a non-Javascript fallback. The stars * mark questions or problems, questions are questions :) 1)* Code review - OK passes QA script and tests - OK ModPrivacy is removed, no other references found * Note: There is some use of the TT plugin $EncodeUTF8, which might be obsoleted if the UTF-8 patches get pushes. 2)* Database structure - OK Patch adds an issue_id PK column to issues/old_issues * Problem (normal): I think old_issues PK should not be AUTO_INCREMENT (see old_reserves) - OK Patch adds privacy_guarantor_checkouts to borrowers/deletedborrowers * Problem (trivial): Please add 'AFTER privacy' to updatedatabase to ensure the correct sequence for new and updated installations - OK 2 new system preferences are added: - AllowPatronToSetCheckoutsVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - OK updatedatabase works - OK changes with kohastructure are consistent 3) Testing the new issue_id - OK Numbering after update appears ok: old_issues: 1-23 issues: 24-26 - OK New Check-outs get the next higher number. - OK Check-ins are correctly moved to old_issues. 4) Testing changes on borrower record (staff) - OK Deleted patron is moved to deletedborrowers. - OK Editing patrons. - OK Adding patrons. 5) Testing 'Show checkouts to guarantor' (staff) * Details: The information now always shows on the patron record, if yes or no independent from the system preference settings independent from the patron being guarantor/guarantee Question: Can we think of a better way here? Maybe only show the information when (either pref is ON and the patron is a guarantee) OR (setting is set to yes)? Really not sure what is best here, sounds too complicated. * Edit form: Settings shows next to privacy Question: Maybe it would make sense to group it with the guarantor information? * Terminology: The setting is "...to guarantor" but the tab is labelled "Relative's checkouts" Question: Should we make them match? 6)* Testing options and visibility in OPAC * AllowPatronToSetCheckoutsVisibilityForGuarantor is ON OpacPrivacy is OFF Problem (blocker) changes to the display made from the personal details tab won't save. - OpacPrivacy is ON OK Setting can be changed. - AllowPatronToSetCheckoutsVisibilityForGuarantor is ON OK Setting is not displayed. Found preexisting BUGS! * Problem (also in master): Author's don't display correctly on the relative's checkouts issues list in staff: Vogelfang und Vogelberingung / by _AUTHOR_ Bub, Hans * Problem (also in master) Table layout on the 'details' tab in staff is broken. Notes: - Should we not generally display information about an existing guarantor in the patron's details in OPAC? - If both settings are OFF the user has no information in the OPAC, but we still show it on staff - not sure how to make this better. It feels a bit like this is not 'round' yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 09:59:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 08:59:34 +0000 Subject: [Koha-bugs] [Bug 13169] C4::Templates::themelanguage fails if the DB is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 09:59:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 08:59:37 +0000 Subject: [Koha-bugs] [Bug 13169] C4::Templates::themelanguage fails if the DB is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33115|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 33116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33116&action=edit [PASSED QA] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated With the aim to remove hardcoded themes the C4::Templates::themelanguage got dependent on the DB being populated. This patch reintroduced the hardcoded defaults as a last resort. To test: - Do a fresh install, clean your browser's cache, empty DB - Open the staff interface => FAIL: A "Software error" screen shows "Template process failed: file error..." - Apply the patch - Reload => SUCCESS: The webinstaller prompts for login correctly. - Sign off :-D Regards Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 10:06:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 09:06:03 +0000 Subject: [Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33089|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 33117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33117&action=edit [SIGNED OFF] Bug 10582: Koha OPAC URL shows Perl error message before web installer was run This patch makes opac/maintenance.pl run smoothly when the DB hasn't been populated yet. It does so, by using C4::Templates::gettemplate instead of C4::Auth::get_user_and_template as the maintenance page doesn't need authentication checks at all, it should happen *before* any attempt to check credentials. To test: - Backup and DROP your database - Point your browser to the OPAC page => FAIL: An error is shown: "Cant's use an undefined value as an ARRAY..." - Apply the patch - Relad the page => SUCCESS: The maintenance page correctly shows. We should now check the rest of the script's behaviour remains untouched: - Reload your backed up DB - Change your DB version number by hand to one version lower, like in: > UPDATE systempreferences SET value="3.1700042" WHERE variable LIKE '%version%'; - Go to the OPAC => SUCCESS: Maintenance page shows as expected - Recover the right version number, like in: > UPDATE systempreferences SET value="3.1700043" WHERE variable LIKE '%version%'; - Set OpacMaintenance to Show on the staff client - Reload the OPAC => SUCCESS: Maintenance page shows as expected - Set OpacMaintenance to 'Don't show' on the staff client - Reload the OPAC => SUCCESS: Normal OPAC shows - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer Works as described, fixes long existing bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 10:06:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 09:06:00 +0000 Subject: [Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 10:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 09:09:51 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 10:11:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 09:11:15 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #26 from Katrin Fischer --- Hi Marcel, can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 12:15:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 11:15:46 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 12:15:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 11:15:49 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32558|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 33118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33118&action=edit Bug 13119 - Use XSLT to display tagged titles in the OPAC This patch updates the display of a logged-in user's tagged titles to use the same XSLT stylesheet used by search results and Lists. This would make for a more consistent display of information. Unrelated change: Corrected "My tags" header to read "Your tags," consistent with sidebar navigation. To test you should have multiple titles in your catalog which you have tagged in the OPAC. - Set the OPACXSLTResultsDisplay system preference to 'default' - Log in to the OPAC and view the "your tags" page. - Confirm that title information is displayed correctly. Compare to search results. - Empty the OPACXSLTResultsDisplay system preference and reload the "your tags" page. The display should revert to the old view, showing title, subtitle (if any) and author (if any). - Set the OPACXSLTResultsDisplay to a custom path pointing to a custom XSL file and confirm that the list of your tagged titles changes accordingly. Note: A follow-up will add "action" links ("place hold," "add to cart," etc) consistent with other pages. Signed-off-by: Frederic Demians Works as described. opac-tag.pl page displays tagged titles the same way as result & list pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 12:46:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 11:46:03 +0000 Subject: [Koha-bugs] [Bug 12842] Add classification to MARC21 XSLT detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12842 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 12:46:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 11:46:05 +0000 Subject: [Koha-bugs] [Bug 12842] Add classification to MARC21 XSLT detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12842 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31249|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 33119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33119&action=edit Bug 12842: Add DDC classification numbers to MARC21 XSLT detail page Patch will add DDC classifications, divided with | below the subjects in the OPAC and staff detail pages. To test: - catalogue a record with one or mulitple 082$a subfields - verify the classifications are displayed in OPAC and staff detail page - Add following CSS to OpacUserCSS or IntranetUserCSS: .results_summary.ddc { display:none; } - Verify the DDC classifications are now no longer displayed Signed-off-by: Frederic Demians Test plan ok. Repetions of $a subfield are separated by a space, which seems correct. I'm not sure whether other subfield than $a should be displayed on intranet. Whatever, this could be added later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 14:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 13:47:23 +0000 Subject: [Koha-bugs] [Bug 13169] C4::Templates::themelanguage fails if the DB is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. /me feels relieved :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 14:47:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 13:47:44 +0000 Subject: [Koha-bugs] [Bug 13011] Parsing a date on sending a letter generates a warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 16:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 15:34:14 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 16:34:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 15:34:17 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28243|0 |1 is obsolete| | --- Comment #17 from Fr?d?ric Demians --- Created attachment 33120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33120&action=edit Bug 12252 - OAI-PMH result includes item data GetRecord for OAI-PMH was pulling the MARCXML directly from the database. Now it uses GetMarcBiblio and includes the item data with it, making it more generally useful. Test plan: * Run an OAI-PMH query, for example: http://koha/cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:52&metadataPrefix=marcxml to fetch biblionumber 52 * Note that it doesn't include the 952 data * Apply the patch * Do the same thing, but this time see that the 952 data is at the bottom of the MARCXML. Note: * This patch also includes a small tidy-up in C4::Biblios to group things semantically a bit better, so I don't spend ages looking for a function that was staring me in the face all along again. Signed-off-by: David Cook Works as described. Simple yet useful patch. Signed-off-by: Jonathan Druart Signed-off-by: Frederic Demians 952/995 item fields are back in response to GetRecord OAI verb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 16:35:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 15:35:55 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28345|0 |1 is obsolete| | --- Comment #18 from Fr?d?ric Demians --- Created attachment 33121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33121&action=edit Bug 12252 - OAI-PMH items respect OpacHiddenItems This allows the OAI-PMH service to not provide item information when there is a rule that would supress it in OpacHiddenItems. Test plan: * Find an OAI-PMH URL that shows you some items. * Add an entry to OpacHiddenItems that would block that. * Check that it's blocked. Signed-off-by: Frederic Demians Tested, playing with OpacHiddenItems. GetRecord OAI verb returns a record complying with OpacHiddenItems rules, for example without items from a specific library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 16:36:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 15:36:38 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29160|0 |1 is obsolete| | --- Comment #19 from Fr?d?ric Demians --- Created attachment 33122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33122&action=edit Bug 12252 - include item data in OAI-PMH ListRecords result Same in spirit to the other patch, this also includes the item detail in ListRecords. Test plan: * Fetch a URL like: http://koha/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml * Verify that there are 952 entries in the returned records where appropriate. Signed-off-by: Frederic Demians ListRecords OAI verb returns a list of records including items in 952/995 which are not hidden based on OpacHiddenItems syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 16:54:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 15:54:01 +0000 Subject: [Koha-bugs] [Bug 12236] Collapse unused message transport types in notice editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- It may already have changed in HEAD, and it doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 16:59:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 15:59:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- There is a conflict on circ/circulation.tt. Could you fix it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 19:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 18:25:04 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 19:25:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 18:25:07 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31677|0 |1 is obsolete| | --- Comment #18 from Fr?d?ric Demians --- Created attachment 33123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33123&action=edit Bug 12357 [1] - Add ability to export arbitrary fields for RIS format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the LC and multiple NT fields Signed-off-by: Frederic Demians Tested with unimarc db. Populating RisExportAdditionalFields, RIS exported records can contain new RIS specific fields populated by field/subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 19:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 18:25:20 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31678|0 |1 is obsolete| | --- Comment #19 from Fr?d?ric Demians --- Created attachment 33124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33124&action=edit Bug 12357 [2] - Add ability to use record level itemtype for RIS export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference RisUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as RIS 6) View the record, note the TY field is your record's itemtype code Signed-off-by: Frederic Demians I confirm that with this patch TY RIS field can contain biblioitems.itemtype field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 19:26:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 18:26:49 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31679|0 |1 is obsolete| | --- Comment #20 from Fr?d?ric Demians --- Created attachment 33125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33125&action=edit Bug 12357 [3]- Add ability to export arbitrary fields for BibTex format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref BibtexExportAdditionalFields: lccn: 010$a notes: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select BIBTEX 6) Inspect the downloaded file, note the lccn and multiple note fields Signed-off-by: Frederic Demians Similar to RIS patch [1]. Functionnal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 1 19:26:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Nov 2014 18:26:59 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31680|0 |1 is obsolete| | --- Comment #21 from Fr?d?ric Demians --- Created attachment 33126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33126&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code Signed-off-by: Frederic Demians Similar to RIS [2] patch. Functionnal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 02:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 01:40:55 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Kurdish language |Update descriptions for | |languages, scripts and | |regions --- Comment #4 from Bernardo Gonzalez Kriegel --- Changing description to reflect broader scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 02:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 01:43:05 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28217|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 33127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33127&action=edit Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 03:24:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 02:24:44 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9056 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 03:24:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 02:24:44 +0000 Subject: [Koha-bugs] [Bug 9056] Add more translations to table language_descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12250 --- Comment #10 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #8) > We still need a follow up for this adding the languages to the other > translations. On current master there is only one file for this. I completed all languages/scripts/regions on Bug 12250, but can add patches for 3.16/14/12 if needed. Not sure about the status of this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 03:25:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 02:25:25 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 08:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 07:50:32 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 08:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 07:50:34 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #1 from Fr?d?ric Demians --- Created attachment 33128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33128&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 08:51:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 07:51:28 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Assignee|tomascohen at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:22:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:22:22 +0000 Subject: [Koha-bugs] [Bug 9056] Add more translations to table language_descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Katrin Fischer --- I think we can close it :) If someone wants a complete file for the earlier versions, we can then deal with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:29:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:29:27 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation and add field for giving a reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Factorize code for order |Factorize code for order |cancellation |cancellation and add field | |for giving a reason -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:35:46 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #35 from Katrin Fischer --- *** Bug 12050 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:35:46 +0000 Subject: [Koha-bugs] [Bug 12050] batch bib deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12050 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12403 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:37:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:37:57 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #305 from Katrin Fischer --- *** Bug 9597 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:37:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:37:57 +0000 Subject: [Koha-bugs] [Bug 9597] grab order info from the 970 when ordering from staged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- MarcFieldsToOrder from bug 7180 should help with that :) *** This bug has been marked as a duplicate of bug 7180 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:43:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:43:55 +0000 Subject: [Koha-bugs] [Bug 5613] search by 'on order' in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|search by 'on order' |search by 'on order' in | |OPAC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:46:04 +0000 Subject: [Koha-bugs] [Bug 4110] Improve consistency and reliability of the interfaces to Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I wonder if this bug is too broad and we should aim to have a few 'small step' bug reports instead. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:48:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:48:40 +0000 Subject: [Koha-bugs] [Bug 6532] way to move items to another record in batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6532 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|way to move items in |way to move items to |batches |another record in batches -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:49:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:49:38 +0000 Subject: [Koha-bugs] [Bug 6511] Server-side paging of SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Is this resolved by using datatables and processing server side, like we do for the patrons now? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:55:03 +0000 Subject: [Koha-bugs] [Bug 5575] 3.4 BibLibre circ & members omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5575 Bug 5575 depends on bug 5730, which changed state. Bug 5730 Summary: Patron search, start_with search now searches within a string, not just the start http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5730 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:55:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:55:02 +0000 Subject: [Koha-bugs] [Bug 5730] Patron search, start_with search now searches within a string, not just the start In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- "Begins with" patron search now works correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:55:03 +0000 Subject: [Koha-bugs] [Bug 6253] Unified Patron Search subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6253 Bug 6253 depends on bug 5730, which changed state. Bug 5730 Summary: Patron search, start_with search now searches within a string, not just the start http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5730 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:56:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:56:48 +0000 Subject: [Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences per library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Easier to customize OPACs |Be able to configure HTML |for Multi-Library set ups |Opac preferences per | |library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 09:59:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 08:59:48 +0000 Subject: [Koha-bugs] [Bug 4272] Replace text links by using icons (edit, delete, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Links versus icons |Replace text links by using |suggestion |icons (edit, delete, ...) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:01:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:01:17 +0000 Subject: [Koha-bugs] [Bug 1922] Table of Contents Tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- 505 now appears formatted, see 12464 for a screenshot. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:03:22 +0000 Subject: [Koha-bugs] [Bug 6659] show opacnav on the log in page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid, but maybe by intention? For libraries not allowing OPAC searches until after you have logged in, this might be the desired behaviour. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:04:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:04:18 +0000 Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences for OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:08:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:08:03 +0000 Subject: [Koha-bugs] [Bug 6036] Mobile interface for Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:08:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:08:57 +0000 Subject: [Koha-bugs] [Bug 7142] non public note on item edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7142 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Nicole, do you mean the items tab view of the item? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:16:26 +0000 Subject: [Koha-bugs] [Bug 6068] New feature: capability to blanking subfields in BatchMod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6068 Bug 6068 depends on bug 6688, which changed state. Bug 6688 Summary: capability to blanking subfields in BatchMod = disable form http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6688 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:16:26 +0000 Subject: [Koha-bugs] [Bug 6688] capability to blanking subfields in BatchMod = disable form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- If you check the checkbox to empty a field in item batch mod, the input field is locked. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:17:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:17:26 +0000 Subject: [Koha-bugs] [Bug 8245] in acqui-home.pl with hierarchic bugdets the calculation of a sum spent in sub-budget is not in the budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8245 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I believe this is fixed with the recent patches to the acquisition module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:19:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:19:17 +0000 Subject: [Koha-bugs] [Bug 8060] Wrong length for category_code in borrower_attribute_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- borrower_attribute_types.category_code is varchar(10) now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:22:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:22:29 +0000 Subject: [Koha-bugs] [Bug 3194] Hide records in the OPAC if all items are lost and "hidelostitems" is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I suggest using opachiddenitems here, as this would hide the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:23:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:23:59 +0000 Subject: [Koha-bugs] [Bug 8528] Move C4::Calendar to Koha::Closure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m, | |jweaver at bywatersolutions.co | |m, katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure, but can this and the linked bug reports be closed with the newer work on hourly loans/calendar? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:25:14 +0000 Subject: [Koha-bugs] [Bug 8460] Improve error messages in OPAC with more information to be sent to the administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Improve Error Handling |Improve error messages in | |OPAC with more information | |to be sent to the | |administrator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:25:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:25:39 +0000 Subject: [Koha-bugs] [Bug 8387] Hide labels when no links exist under them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Tools |Templates Version|3.6 |master Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:26:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:26:46 +0000 Subject: [Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|allow attributes to be made |Allow patron attributes to |repeatable |be made repeatable after | |initial creation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:28:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:28:19 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Circulation |OPAC Version|3.8 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |minor --- Comment #1 from Katrin Fischer --- Not sure if catalogue here refers to the OPAC or staff client, assuming it's OPAC, then it's true. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:33:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:33:52 +0000 Subject: [Koha-bugs] [Bug 6418] Make it possible to use custom XSLT (display 590a...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6418 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Summary|display 590a |Make it possible to use | |custom XSLT (display | |590a...) --- Comment #4 from Katrin Fischer --- I think the answer here is currently to use a custom XSLT stylesheet and a wiki page with hints exists. I think improving the workflow of the custom XSLT could be a separate bug report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:34:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:34:56 +0000 Subject: [Koha-bugs] [Bug 8855] Link from receipt to invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|get from receipt to invoice |Link from receipt to | |invoice --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:35:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:35:53 +0000 Subject: [Koha-bugs] [Bug 8734] Acquisitions- Quantity for ordering from suggestion unable to modify In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:36:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:36:43 +0000 Subject: [Koha-bugs] [Bug 8722] C4::Circulation needs unit test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |LATER --- Comment #1 from Katrin Fischer --- While this would be great, I think the bug report is a bit too general to get tackled :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:38:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:38:35 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 5359, which changed state. Bug 5359 Summary: Parcel receive improvement http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5359 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:38:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:38:35 +0000 Subject: [Koha-bugs] [Bug 5359] Parcel receive improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #5 from Katrin Fischer --- As noone seems to be able to remember what this was about, I am going to be mean and close it invalid. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:40:52 +0000 Subject: [Koha-bugs] [Bug 6425] Advanced search: begins with and contains searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|begins with and contains |Advanced search: begins |searches |with and contains searches -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:42:03 +0000 Subject: [Koha-bugs] [Bug 5408] Refactor C4::Circulation::GetIssuingRule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #6 from Katrin Fischer --- WONTFIXING this approach as Koha has changed quite a bit since 2010... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:46:38 +0000 Subject: [Koha-bugs] [Bug 9026] Reject/approve a tag *one time* / (batch) edit tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9026 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|tagging improvements |Reject/approve a tag *one | |time* / (batch) edit tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:50:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:50:22 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen at washk12.org --- Comment #32 from Katrin Fischer --- *** Bug 9171 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:50:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:50:22 +0000 Subject: [Koha-bugs] [Bug 9171] Vendor sent us a file with holdings in 952 which has repeated subfields and no home or holding branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- I think bug 10877 goes in the same direction as this. *** This bug has been marked as a duplicate of bug 10877 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 10:53:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 09:53:36 +0000 Subject: [Koha-bugs] [Bug 9175] Shelving location search returns no results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master --- Comment #1 from Katrin Fischer --- This is still valid. The shelving location search in advanced staff search will only work correctly if searching with the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:00:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:00:17 +0000 Subject: [Koha-bugs] [Bug 9664] additional fees tracking in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, does the shipping cost help with that or do we need a more specific feature? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:12:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:12:38 +0000 Subject: [Koha-bugs] [Bug 5614] patron prefs not in categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:14:21 +0000 Subject: [Koha-bugs] [Bug 9746] Perl module libdbd-sqlite2|3-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 4269 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:14:21 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.a at aandc.org --- Comment #1 from Katrin Fischer --- *** Bug 9746 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:15:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:15:11 +0000 Subject: [Koha-bugs] [Bug 4964] design of news in opac could be better In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4964 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Is this still an issue in the new bootstrap theme? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:16:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:16:05 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master Summary|Randomly generated |Set minPasswordLength to a |suggested passwords are too |higher value by default |weak | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:16:52 +0000 Subject: [Koha-bugs] [Bug 6197] Capitalized or lowercased Turkish characters are not searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- Seems to be a configuration issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:17:47 +0000 Subject: [Koha-bugs] [Bug 10035] move or copy hard due date to be by patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|move or copy hard due date |move or copy hard due date |to defaults section |to be by patron category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:18:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:18:13 +0000 Subject: [Koha-bugs] [Bug 4031] Expand EnableOpacSearchHistory options for controlling search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4031 --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:19:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:19:06 +0000 Subject: [Koha-bugs] [Bug 4457] Create order from last order details in serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve serials |Create order from last |acquisitions link |order details in serials -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:21:36 +0000 Subject: [Koha-bugs] [Bug 5385] Correct POD errors as highlighted by podchecker In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- I don't get any results with Andrew's comment on current master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:23:10 +0000 Subject: [Koha-bugs] [Bug 5686] Add tamil to languages list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Summary|search in tamil |Add tamil to languages list -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:24:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:24:18 +0000 Subject: [Koha-bugs] [Bug 5934] Manipulate titles in Borrower Preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5934 --- Comment #1 from Katrin Fischer --- Can someone add some more detail to this? The title and the description doesn't seem to match. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:27:18 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #2 from Katrin Fischer --- Still true, would be an easy one :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:28:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:28:11 +0000 Subject: [Koha-bugs] [Bug 9855] Add OpenGraph (Facebook preview) tags to pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:29:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:29:28 +0000 Subject: [Koha-bugs] [Bug 6262] overdues warning label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6262 --- Comment #3 from Katrin Fischer --- I agree that this doesn't look good, but can't tell if a warning should still be given for large library systems. Maybe a big library can tell if it's a problem? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:30:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:30:19 +0000 Subject: [Koha-bugs] [Bug 9485] Short cut to create new authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- There is a link to create a new authority in the authority linker plugin now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:36:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:36:06 +0000 Subject: [Koha-bugs] [Bug 10239] add dates to course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:36:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:36:20 +0000 Subject: [Koha-bugs] [Bug 10239] Add start end end dates to course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add dates to course |Add start end end dates to |reserves |course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:38:44 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPACAllowUserToChooseBranch |New |and hold rules |OPACAllowUserToChooseBranch | |setting for only showing | |libraries allowing holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:39:28 +0000 Subject: [Koha-bugs] [Bug 10306] acquisitions shows publisher from 260 only (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|acquisitions shows |acquisitions shows |publisher from 260 only |publisher from 260 only | |(RDA) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:40:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:40:32 +0000 Subject: [Koha-bugs] [Bug 7884] Ergonomics & usability omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- All linked bugs have been closed, closing the omnibus as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:41:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:41:35 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m, katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:46:04 +0000 Subject: [Koha-bugs] [Bug 7832] Server Z39.50 for Unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I believe this was a configuration issue, as we know that Z39.50-download for UNIMARC libraries works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:46:14 +0000 Subject: [Koha-bugs] [Bug 7832] Server Z39.50 for Unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:51:14 +0000 Subject: [Koha-bugs] [Bug 7655] Runtime parameters: Allow for an "optional" field tag, versus the need for % In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Allow for an "optional" |Runtime parameters: Allow |field tag, versus the need |for an "optional" field |for % |tag, versus the need for % -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:51:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:51:21 +0000 Subject: [Koha-bugs] [Bug 7655] Runtime parameters: Allow for an "optional" field tag, versus the need for % In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:52:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:52:27 +0000 Subject: [Koha-bugs] [Bug 10353] "Fines in days" (aka suspensions) should be first-class citizen in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Has this been improved with the borrower_debarments table? It's possible now to add a text and we have different types of restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:53:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:53:47 +0000 Subject: [Koha-bugs] [Bug 6173] Cronjob to send account expiry notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Marking this duplicate of bug 6810 as this has been worked on more recently. *** This bug has been marked as a duplicate of bug 6810 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:53:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:53:47 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale at anantcorp.com --- Comment #29 from Katrin Fischer --- *** Bug 6173 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:54:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:54:48 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:55:34 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #3 from Katrin Fischer --- Still an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:56:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:56:08 +0000 Subject: [Koha-bugs] [Bug 10394] The ability to unreceipt an order line as well as an invoice. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10394 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- It is possible in current versions to undo a receive and delete an then empty invoice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 11:58:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 10:58:16 +0000 Subject: [Koha-bugs] [Bug 10369] Added Sort1 in circulation page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- This was reported 2013 but doesn't have enough information to see what the intention was. Closing for now, please reopen if I was too fast. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:01:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:01:28 +0000 Subject: [Koha-bugs] [Bug 10375] add a tool to Koha, to check for zebra problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Mason, are you still working on this or can this be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:02:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:02:40 +0000 Subject: [Koha-bugs] [Bug 9157] inventory tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- So I think maybe what's needed would be: - an option to not automatically check items in - an option to set the inventory/last seen date manually ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:04:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:04:22 +0000 Subject: [Koha-bugs] [Bug 10364] add a way to partially receive an order without creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10364 --- Comment #2 from Katrin Fischer --- The display of orders that have been partially received has been improved a lot as it now shows the dependent parent order in a lot of places. I still think without totally changing our database structure it won't be possible to really achieve this. The different order lines can have different prices, be received in different years etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:09:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:09:19 +0000 Subject: [Koha-bugs] [Bug 13186] New: Deleting record results in perl error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13186 Bug ID: 13186 Summary: Deleting record results in perl error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When deleting a record from the staff interface a perl error is shown: - do a search - go to a detail page - use edit > delete record Can't call method "title" on an undefined value at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 826. URL is: http://localhost:8080/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&biblionumber=19 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:09:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:09:34 +0000 Subject: [Koha-bugs] [Bug 5428] Back to results after deleting a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:10:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:10:57 +0000 Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto email address for some notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 --- Comment #2 from Katrin Fischer --- Not quite what was intended here, but the reply-to is now configurable by branch at least - small steps :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:11:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:11:36 +0000 Subject: [Koha-bugs] [Bug 10596] make expiration date an option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:11:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:11:48 +0000 Subject: [Koha-bugs] [Bug 10596] Patrons: Make expiration date an option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|make expiration date an |Patrons: Make expiration |option |date an option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:12:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:12:27 +0000 Subject: [Koha-bugs] [Bug 10620] Z39.50 page should highlight required fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This is fixed in current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:14:54 +0000 Subject: [Koha-bugs] [Bug 12778] Item lost status should show in list of checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 10623 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:14:54 +0000 Subject: [Koha-bugs] [Bug 10623] item lost says 'checked out' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10623 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12778 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:19:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:19:14 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add RDA support to Koha |Omnibus: add RDA support to | |Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 10306] acquisitions shows publisher from 260 only (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11701, 11066, 10726, 12726, | |12725, 12724, 10306 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 12725] Show RDA tag 264 on Intranet Results and Detail XSLT view (MARC21) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 12726] Show RDA tag 264 on OPAC Results XSLT view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:20:55 +0000 Subject: [Koha-bugs] [Bug 12724] Show RDA tag 264 on OPAC Detail XSLT view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:23:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:23:13 +0000 Subject: [Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 6873 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:23:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:23:13 +0000 Subject: [Koha-bugs] [Bug 6873] Incremental fine system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10874 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:24:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:24:47 +0000 Subject: [Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Maybe take a look at the staticfine.pl script in current Koha - it might be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:24:53 +0000 Subject: [Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:26:04 +0000 Subject: [Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:26:04 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:26:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:26:30 +0000 Subject: [Koha-bugs] [Bug 10696] Shelf browser in mobile theme. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- The CCSR theme has since been removed, marking this invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:29:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:29:37 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Not sure which this is a duplicate of... but now that we removed the prog OPAC template, this will need some work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:29:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:29:44 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:30:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:30:52 +0000 Subject: [Koha-bugs] [Bug 9716] opaclayoutstylesheet and opaccolorstylesheet must be filled in for CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #4 from Katrin Fischer --- The CCSR OPAC theme has since been removed. As this bug has last been updated in 2013. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:32:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:32:36 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #11 from Katrin Fischer --- The OPACMobileUserCSS has been removed with the prog/CCSR OPAC theme removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:34:39 +0000 Subject: [Koha-bugs] [Bug 6382] Automatic Status Changing on Check In In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- Bug 11629 should be helpful here :) *** This bug has been marked as a duplicate of bug 11629 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:34:39 +0000 Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #34 from Katrin Fischer --- *** Bug 6382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:35:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:35:45 +0000 Subject: [Koha-bugs] [Bug 5686] Add tamil to languages list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5686 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Bernardo Gonzalez Kriegel --- Tamil is one of the languages added on Bug 12250 *** This bug has been marked as a duplicate of bug 12250 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:35:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:35:45 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |novamcccharles at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- *** Bug 5686 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:36:53 +0000 Subject: [Koha-bugs] [Bug 10805] Notice- Item check out /check in notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- I think this has been a configuration problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:37:26 +0000 Subject: [Koha-bugs] [Bug 3591] "Family administrator" account for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:40:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:40:47 +0000 Subject: [Koha-bugs] [Bug 11374] Need provision to give batch name in Tools > Label creator > Manage batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 5169 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:40:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:40:47 +0000 Subject: [Koha-bugs] [Bug 5169] name/rename label batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 11374 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:44:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:44:07 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn at pennmanor.net --- Comment #1 from Katrin Fischer --- *** Bug 8042 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:44:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:44:07 +0000 Subject: [Koha-bugs] [Bug 8042] Batch numbers aren't committed as used until an item is added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- I believe this is the same problem as bug 12911 - marking them duplicate so discussion can continue on one report. *** This bug has been marked as a duplicate of bug 12911 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:46:42 +0000 Subject: [Koha-bugs] [Bug 10203] print labels based on range of barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 7468 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:46:42 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 10203 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:50:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:50:28 +0000 Subject: [Koha-bugs] [Bug 5765] patron messaging form template tests for SMS inconsistently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #5 from Katrin Fischer --- Bug report is pretty old and we have done quite some work on this since. Closing WORKSFORME. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 12:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 11:52:48 +0000 Subject: [Koha-bugs] [Bug 12925] Problem encoding characters in link "Back to results" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de Component|OPAC |System Administration Version|3.16 |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org --- Comment #3 from Katrin Fischer --- The problem with searching for ?, ?, ?, ?, ? remains for the system preference editor, which is separate from the catalog search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 13:32:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 12:32:00 +0000 Subject: [Koha-bugs] [Bug 5575] 3.4 BibLibre circ & members omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5575 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 13:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 12:42:12 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #2 from Tom?s Cohen Arazi --- Frederic, I'm on the phone right now, so cannot test. But could you make the patch use C4::Templates::themelanguage instead so we use the fallback logic from only one place? It does exactly what you want. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 14:22:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 13:22:46 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 --- Comment #53 from mathieu saby --- Search.t is not failing anymore with my new patches ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 14:29:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 13:29:43 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #3 from Fr?d?ric Demians --- (In reply to Tom?s Cohen Arazi from comment #2) > Frederic, I'm on the phone right now, so cannot test. But could you make the > patch use C4::Templates::themelanguage instead so we use the fallback logic > from only one place? It does exactly what you want. Thanks! Yes, of course. Thanks for pointing to the right direction! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 14:56:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 13:56:27 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33128|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 33129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33129&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Note: Implemented with C4::XSLT::_get_best_default_xslt_filename() to keep code orthogonal. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:06:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:06:51 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 --- Comment #12 from M. Tompsett --- Given that prog is still in 3.14 and 3.16 (which are not obsolete yet), and that 3.18 has not yet been released, I do not see why this couldn't be left open for back-porting. I'm not sure RESOLVED INVALID is an appropriate state, Katrin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:08:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:08:41 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #13 from Katrin Fischer --- This patch hasn't seen any attention since April and was in discussion, if my attempt to close this brings it back to life this is fine with me :) - if you want to provide patches for the older versions that's of course possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:25:29 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Summary|Stage MARC for Import hangs |Stage MARC for Import hangs | |for biblio containing | |invalid ISBN-13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:34:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:34:36 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:34:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:34:38 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #1 from Fr?d?ric Demians --- Created attachment 33130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33130&action=edit Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for import' hangs. If I use the same UNIMARC record and change 979 to 978 in the ISBN, 'Stage MARC for import' works perfectly. The patch deals with the fact that converting an ISBN-13 to ISBN-10 with Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978. TEST PLAN: (1) Download, and decompress the ZIP file attached to BZ. (2) On a UNIMARC Koha instance, go in Tools > Stage MARC for import. (3) Choose the MARC file containing the record with an ISBN begining with 979. Click on Upload file, then Stage to import. (4) The Job progress bar stay at 0%. (5) Apply the patch. Repeat steps 2-3. The upload works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:34:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:34:53 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:36:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:36:25 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #2 from Fr?d?ric Demians --- (In reply to Tiburce Euphrasie from comment #0) > I think I've also detected a small problem in Open a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:37:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:37:09 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Version|3.10 |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:38:41 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.16 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:43:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:43:24 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16087|0 |1 is obsolete| | Attachment #27297|0 |1 is obsolete| | Attachment #27298|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 33131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33131&action=edit Bug 9551 - OPACMobileUserCSS being overriden by OPACUserCSS Test Plan: 1) Set a rule in OpacUserCSS that should be overidden by a rule set in OPACMobileUserCSS 2) Load OPAC, check for OpacUserCSS taking precedence 3) Apply patch 4) Reload OPAC, check for OPACMobileUserCSS taking precedence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:43:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:43:30 +0000 Subject: [Koha-bugs] [Bug 13158] Software error: Can't call method "as_string" on an undefined value at /usr/share/koha/lib/C4/Koha.pm line 1608. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13158 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |frederic at tamil.fr Resolution|--- |DUPLICATE --- Comment #2 from Fr?d?ric Demians --- It happens in search result containing records with invalid ISBN-13, ie ISBN-13 not beginning with 978. *** This bug has been marked as a duplicate of bug 13167 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:43:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:43:30 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ncubec at solusi.ac.zw --- Comment #3 from Fr?d?ric Demians --- *** Bug 13158 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:55:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:55:18 +0000 Subject: [Koha-bugs] [Bug 13157] improving facet definitions for unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #1 from Fr?d?ric Demians --- Created attachment 33132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33132&action=edit Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 17:55:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 16:55:58 +0000 Subject: [Koha-bugs] [Bug 13157] improving facet definitions for unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 18:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 17:23:11 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from M. Tompsett --- This should apply cleanly to 3.16.x. However, I'm not certain how the ordering of the mobile before or after makes any difference, because when I use: .silly { color:#FF0000; } and .silly { color:#00FF00; } in the two system preferences, I always seem to get non-mobile version when hunting for .silly in firebug. Can anyone confirm this is working or not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 18:44:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 17:44:31 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/suggestion/su | |ggestion.pl CC| |frederic at tamil.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 18:47:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 17:47:01 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 18:47:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 17:47:03 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 --- Comment #1 from Fr?d?ric Demians --- Created attachment 33133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33133&action=edit Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 18:47:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 17:47:38 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 20:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 19:10:52 +0000 Subject: [Koha-bugs] [Bug 13157] improving facet definitions for unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #2 from mathieu saby --- Hello A change is also needed in biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xml Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 20:16:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 19:16:14 +0000 Subject: [Koha-bugs] [Bug 10364] add a way to partially receive an order without creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10364 --- Comment #3 from mathieu saby --- Hello If the issue is still there, maybe it is possible to fix it only at display level , for the printing of basketgroups for example? As Koha knows that order B was creaated by a partial receipt of order A, it is possible - I think - to display only one line for A and B. Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 20:30:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 19:30:07 +0000 Subject: [Koha-bugs] [Bug 10364] add a way to partially receive an order without creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10364 --- Comment #4 from Katrin Fischer --- Trying to see how it could work: Why would you want to reprint a basket group if it's already partially received? And should the received items be marked/printed? Could it be, that the price or another detail for the received one is different to the still ordered one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 20:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 19:57:33 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 Peter Kelly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |peterAtKohaBugzilla at pck.co. | |nz --- Comment #3 from Peter Kelly --- Created attachment 33134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33134&action=edit Patch to increase password length -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 20:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 19:58:35 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 --- Comment #4 from Peter Kelly --- To be honest, I haven't tested this patch. But it is so simple, "what could possibly go wrong". I don't have time to test it right now so am uploading it but leaving the status unchanged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 21:07:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 20:07:06 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/elasticsearch_browser This has the browser (subject browse etc) code on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 21:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 20:29:52 +0000 Subject: [Koha-bugs] [Bug 13157] improving facet definitions for unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33132|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 33135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33135&action=edit Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 2 23:21:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Nov 2014 22:21:02 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 --- Comment #5 from Peter Kelly --- Sorry, I should have said - the patch increases the default length to 12. The default length was discussed in bug 9885. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 04:45:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 03:45:32 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:02:53 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31128|0 |1 is obsolete| | Attachment #31129|0 |1 is obsolete| | --- Comment #12 from Robin Sheat --- Created attachment 33136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33136&action=edit Bug 12478 - add some base objects that the ES code will depend on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:05:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:05:45 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33136|0 |1 is obsolete| | --- Comment #13 from Robin Sheat --- Created attachment 33137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33137&action=edit Bug 12478 - add some base objects that the ES code will depend on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:05:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:05:50 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #14 from Robin Sheat --- Created attachment 33138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33138&action=edit Bug 12478 - pile of elasticsearch code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:05:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:05:54 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #15 from Robin Sheat --- Created attachment 33139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33139&action=edit Bug 12478 - set up database tables for elasticsearch This sets up the database changes needed to run ES. This isn't intended to be ready for upstreaming, just to make testing easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:05:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:05:59 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #16 from Robin Sheat --- Created attachment 33140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33140&action=edit Bug 12478 - authorities can now be stored in ES (Not fetched yet though.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:06:04 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #17 from Robin Sheat --- Created attachment 33141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33141&action=edit Bug 12478 - add test cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 05:12:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 04:12:51 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #18 from Robin Sheat --- I've added a dump of the current state of patches. It's in the process of being split up and having unit tests written, in particular of the underlying modules, i.e. the things that will be needed but aren't central to ES itself. The last functional change was the ability for authorities to be indexed too. Currently, they can't be searched, but they are there. The next functional change (clearly) is to make them be searchable. I'm expecting that 90% of this will leverage the existing query builder type stuff. I'm hoping that someone can have a go setting this up on their own installation and trying it out, to see if there are any particular points that need explained. dcook, I'll be seeing you at the conference tomorrow, I suggest you have a laptop with a VM ready to go on it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 08:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 07:15:42 +0000 Subject: [Koha-bugs] [Bug 13187] New: Access keys should be localizable/translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13187 Bug ID: 13187 Summary: Access keys should be localizable/translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr For example: cancelorder.tt: cancelorder.tt: After translating the buttons, the access keys do not reflect the button texts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 09:45:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 08:45:00 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au --- Comment #89 from Bob Birchall --- What's the status of this? Is it still being pursued? I guess its going to miss 3.18? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 10:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 09:51:55 +0000 Subject: [Koha-bugs] [Bug 12886] shelfbrowser script should write headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 10:51:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 09:51:57 +0000 Subject: [Koha-bugs] [Bug 12886] shelfbrowser script should write headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32351|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 33142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33142&action=edit Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header=
I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 10:52:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 09:52:46 +0000 Subject: [Koha-bugs] [Bug 12886] shelfbrowser script should write headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > I am not sure why this happens, but with the patch applied for every time I > use the 'arrow' picture, a 1 appears in the bottom left corner. > This doesn't happen without the patch applied. Silly error, print should have been removed, done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 11:36:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 10:36:39 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12803 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 11:36:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 10:36:39 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12450 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 12:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 11:04:45 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Do we need a new patch here? It looks like this is the last missing piece to > get rid of SQLHelper. see comment 9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 12:05:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 11:05:28 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 12:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 11:11:00 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #27 from M. de Rooy --- (In reply to Katrin Fischer from comment #26) > Hi Marcel, can you explain? Installing Text::Bidi gives headaches: 0) I installed a fribidi with yum already (not on debian!) 1) After last error, installed ExtUtils::PkgConfig 2) Package fribidi was not found in the pkg-config search path. Made a fribidi.pc file 3) After several warnings and editing several lines in this fribidi.pc, I came one step further: 'YAML' not installed, will not store persistent state. 4) After installing YAML, got this fatal error: fribidi.h: No such file or directory. The installed fribidi appears to be a problem. So I am still stuck with this. Since I am not using this feature at all, I would not like to waste much more time on it.. Not sure if other people on other distros will have similar problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 12:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 11:14:27 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #28 from Katrin Fischer --- Hi Marcel, hope I didn't miss it, but which distro are you using? I think all I did was something like 'sudo apt-get install libtext-bidi-perl' - as it seemed to be ok on Ubuntu and Debian, I didn't see a problem here when we discussed the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 13:17:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 12:17:13 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #29 from Katrin Fischer --- (12:15:07) marcelr: cait: fedora -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 13:33:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 12:33:49 +0000 Subject: [Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > Moving this out of the queue for now - all other patches are blocked or > passed QA. There is no patch on this one. It's a document to review, see description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 13:35:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 12:35:33 +0000 Subject: [Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #21 from Katrin Fischer --- I know - I just moved it when I had qa'd everything I could. We don't really have a good status for documentation :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 13:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 12:46:51 +0000 Subject: [Koha-bugs] [Bug 13157] improving facet definitions for unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:23:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:23:01 +0000 Subject: [Koha-bugs] [Bug 13157] Fix holdingbranch facet for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|improving facet definitions |Fix holdingbranch facet for |for unimarc |UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:31:18 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30828|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 33143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33143&action=edit Bug 1861 - Unique patrons logins not (totally) enforced The Koha 3.0 patron admin page will prevent you from creating a user who has an identical OPAC login as someone else (though I would change the error message from "Login/password already exists." to "Login already exists.", since it's not the password that's the problem). However, there's nothing enforced in the MySQL database to prevent patrons from being imported or manually inserted with duplicate logins. Would it be better to change the MySQL spec from this: KEY `userid` (`userid`) to this: UNIQUE KEY `userid` (`userid`) Test plan: 1) Enter mysql console 2) Attempt to create two borrowers with identical user id's 3) Note you are able to do so 4) Delete these bororwers 5) Apply this patch 6) Run updatedatabase.pl 7) Repeat step 2 8) Note you are now unable to do so Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors Signed-off-by: Katrin Fischer Leaves deletedborrowers as it is, deleting patrons still works ok. Works according to test plan. Database update will only be successful, when no duplicate entries exist in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:31:16 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:31:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:31:26 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #10 from Kyle M Hall --- Created attachment 33144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33144&action=edit Bug 1861 [QA Followup] - Fix Check_Userid and unit tests Check_Userid assumes that a borrowernumber will always be passed in and thus fails to to return 0 for an already used userid when creating a new patron. Unit tests must now also me modified to no longer assume it is possible to create multiple patrons with the same userid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:42:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:42:44 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #25 from Martin Renvoize --- QA Comment: Should these db action in Context.pm use the dbic variation now days? Other than that, the code looks good to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:51:09 +0000 Subject: [Koha-bugs] [Bug 11948] last name browse on patron card creator searching anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED --- Comment #2 from Kyle M Hall --- I believe this behavior has now been fixed in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 14:55:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 13:55:14 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #26 from Martin Renvoize --- QA Comment: I also get qa script failure. FAIL C4/Context.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:04:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:04:12 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #27 from Martin Renvoize --- I also get all Bernardo's failures too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:07:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:07:04 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:09:08 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Jonathan Druart --- (In reply to M. de Rooy from comment #28) > QA Comment: > This looks promising, but currently generates a problem: > stage-marc-import.pl: Can't call method "update" on an undefined value at > /usr/share/koha/testclone/Koha/SimpleMARC.pm line 214, chunk 1. > > Steps to reproduce: > Add/Update field 946 a with value "Hi 946". Could you please test this patch set with bug 11395 please? I got the same error without patches from bug 11395. I did not manage to maintain both bug reports bug free independently of each other. They should be tested, QAed and pushed together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:09:39 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32239|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart --- Created attachment 33145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33145&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:09:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:09:44 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32240|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart --- Created attachment 33146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33146&action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:09:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:09:48 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32241|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart --- Created attachment 33147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33147&action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:09:52 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32242|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart --- Created attachment 33148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33148&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:09:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:09:56 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32243|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart --- Created attachment 33149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33149&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:00 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32244|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart --- Created attachment 33150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33150&action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:07 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32245|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart --- Created attachment 33151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33151&action=edit Bug 11395: Fix field_numbers This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. The following line was completely stupid: if $from_field ne $to_subfield The field_number equals 1 if the user wants to update the first field and 0 for all fields. The field_numbers (note the s) variable contains the field numbers to update. This array is filled if a condition exists (field exists or field equals). Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:12 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32246|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart --- Created attachment 33152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33152&action=edit Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:16 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32247|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 33153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33153&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:21 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32248|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 33154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33154&action=edit Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:25 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32249|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart --- Created attachment 33155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33155&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:10:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:10:59 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #72 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:13:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:13:32 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #30 from M. de Rooy --- (In reply to Jonathan Druart from comment #29) > (In reply to M. de Rooy from comment #28) > > QA Comment: > > This looks promising, but currently generates a problem: > > stage-marc-import.pl: Can't call method "update" on an undefined value at > > /usr/share/koha/testclone/Koha/SimpleMARC.pm line 214, chunk 1. > > > > Steps to reproduce: > > Add/Update field 946 a with value "Hi 946". > > Could you please test this patch set with bug 11395 please? > I got the same error without patches from bug 11395. > I did not manage to maintain both bug reports bug free independently of each > other. > > They should be tested, QAed and pushed together. If so, please merge them. A squash of patches that edit the same lines multiple items would be helpful too. I appreciate that you did a lot of work here. But QAing these sets takes time too. Just setting the status back to Signed off is not my solution.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:15:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:15:08 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #10 from simith.doliveira at inlibro.com --- Created attachment 33156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33156&action=edit Add a new button to the checkout confirmation dialog when checking out a reserved item Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:15:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:15:38 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29697|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 33157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33157&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:16:28 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:17:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:17:24 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Jonathan Druart --- It applied correctly here but with some "Auto-merging". Could you retry with this new patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:29:31 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #8 from M. de Rooy --- Created attachment 33158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33158&action=edit Bug 13096: Template changes for memberentry in staff. If AutoEmailOpacUser is enabled, Koha will send an email with account details to the patron at creation time. This report makes it possible to also send this mail when updating patron details, perhaps finishing the registration process at a later stage. This patch makes the needed template changes. It adds a checkbox when a patron is modified (not created/duplicated). It adds javascript to check this checkbox on a username or password change. The staff user can uncheck it again if needed. Test plan: Disable AutoEmailOpacUser. Test adding, duplicating and modifying a patron. You should not see the checkbox. Enable AutoEmailOpacUser. Test adding or duplicating. You should not see the checkbox. Test modifying a patron. If you edit username or password, the checkbox should automatically be checked. You can uncheck it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:29:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:29:35 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #9 from M. de Rooy --- Created attachment 33159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33159&action=edit Bug 13096: Send account notice at patron modification time Instead of sending an account notice only at creation time, this patch makes it possible to generate the same notice when changing account details of the patron. In memberentry.pl, the code for selecting an email address and sending the alert is replaced by calling SendAutoEmail in Members.pm. An additional call is made for the op=save situation; if in that case param mailacctdetails is true (checkbox), a mail will be sent. Note that the script refers to op=duplicate several times. Inspecting the template shows that the duplicate operation also goes via op=insert however. If the password is '!' (disabled), the form now shows the password as blank. If no password is entered, AddMember will insert the ! again. This makes staff more aware of a missing password than showing *****. Test plan: [1] Disable AutoEmailOpacUser. Add, duplicate, modify patron. No mails? [2] Enable AutoEmailOpacUser. Add, duplicate patron. Check mail. [3] Modify patron. Check the email checkbox. Did you receive it? [4] Modify patron. Uncheck the email checkbox. No mail? [5] Create a new patron without userid and password. No mail. [6] Edit this patron: a userid has been generated, but the password should be blank. Enter a password. Check mail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:29:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:29:38 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #10 from M. de Rooy --- Created attachment 33160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33160&action=edit Bug 13096: Send account notice when user completes self-registration If you have enabled AutoEmailOPACUser, a notice is sent to a patron at creation time. This patch will make Koha send a notice when someone self-registers and submits or follows the verification link. The usercode and password are prefilled on the form, but many patrons will find it helpful to have them in a mail. Instead of creating a new pref for this specific case, I have chosen to extend pref AutoEmailOpacUser. These situations are very similar. The pref text is adjusted in a follow-up. Note: If the user does not enter an email address, he will not receive any notice. (No verification link either.) Test plan: [1] Enable the prefs AutoEmailOPACUser and PatronSelfRegistration. [2] Enable PatronSelfRegistrationVerifyByEmail. [3] Self-register an account. Verify the account with the link in the mail. Check that you receive another mail with account details now. [4] Disable PatronSelfRegistrationVerifyByEmail. [5] Self-register again. Check if you receive a mail when submitting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:29:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:29:41 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #11 from M. de Rooy --- Created attachment 33161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33161&action=edit Bug 13096: Send account notice when changing password with member-password Send an alert with account details if AutoEmailOpacUser is enabled and the checkbox was not unchecked. Added license statement and modern perl line to the code. Fixed some other minor issues too: When changing password, the ajax call used userid instead of borrowernumber. Current master does not allow you to change userid only. Test on newpassword in the template was dead. Removed dead destination parameter. Test plan: Disable AutoEmailOpacUser. Goto a patron. Click the Change Password button. No checkbox, no mail. Enable AutoEmailOpacUser. Click Change Password again. Do you receive a mail when saving? Uncheck the checkbox: no mail? Test changing the userid only. Test saving without any changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:29:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:29:45 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #12 from M. de Rooy --- Created attachment 33162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33162&action=edit Bug 13096: Adjusting description of pref AutoEmailOPACUser. Test plan: Check the pref rewording in Systempreferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:34:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:34:32 +0000 Subject: [Koha-bugs] [Bug 10353] "Fines in days" (aka suspensions) should be first-class citizen in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Tom?s Cohen Arazi --- Even when they weren't strictly related, it was fixed as part of bug 2720. So closing this one. Maybe future enhancements will be requested on new bug reports. *** This bug has been marked as a duplicate of bug 2720 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:34:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:34:32 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #52 from Tom?s Cohen Arazi --- *** Bug 10353 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:37:05 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #86 from Tom?s Cohen Arazi --- Created attachment 33163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33163&action=edit Bug 10860: Update DBIx Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:40:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:40:10 +0000 Subject: [Koha-bugs] [Bug 13179] Circulation page layout problem when OnSiteCheckoutsForce is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13179 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13184 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:40:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:40:10 +0000 Subject: [Koha-bugs] [Bug 13184] Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |13179 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:46:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:46:48 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31730|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 33164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33164&action=edit Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in it the code from GetBookSeller and GetBookSellerFromId. Test plan: 1/ Create a bookseller, modify it. 2/ Add contacts for this bookseller 3/ Create an order, receive it, transfer it 4/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:47:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:47:58 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #20 from Jonathan Druart --- (In reply to Paola Rossi from comment #18) There only was a small conflict on the number of unit tests. > Falling back to patching base and 3-way merge... > error: The following untracked working tree files would be overwritten by > merge: > Koha/Acquisition/Bookseller.pm > Please move or remove them before you can merge. > Aborting > Failed to merge in the changes. > Patch failed at 0001 Bug 12896: Move the bookseller-related code into > Koha::Acquisition::Bookseller You should remove the file and retry to apply this patch. Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:48:28 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) > Back to needs signoff. I meant to Signed off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:49:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:49:11 +0000 Subject: [Koha-bugs] [Bug 13188] New: Mandatory fields are wrong in patron personal details page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Bug ID: 13188 Summary: Mandatory fields are wrong in patron personal details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org For an registered patron, the page /cgi-bin/koha/opac-memberentry.pl displays his personal details and allow him to ask for a change. In this page mandatory fields are wrong. It uses PatronSelfRegistrationBorrowerMandatoryField instead of BorrowerMandatoryField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:50:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:50:28 +0000 Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:54:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:54:28 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #31 from Jonathan Druart --- (In reply to M. de Rooy from comment #30) > If so, please merge them. > A squash of patches that edit the same lines multiple items would be helpful > too. I would not prefer. One is a bugfix (this one), the other is a new feature (11395). I could try to find what fix the problem, but I don't have enough time to do it soon and I don't think it is worth a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 15:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 14:55:05 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #87 from Tom?s Cohen Arazi --- Created attachment 33165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33165&action=edit Bug 10860: (RM followup) checkout-related sysprefs belong to the checkouts section Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:03:57 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:04:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:04:00 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:04:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:04:05 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:04:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:04:08 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:04:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:04:11 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:20:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:20:41 +0000 Subject: [Koha-bugs] [Bug 13189] New: Patron card creator patron search browse by last name broken by extended attributes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Bug ID: 13189 Summary: Patron card creator patron search browse by last name broken by extended attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:20:52 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:20:55 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:30:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:30:08 +0000 Subject: [Koha-bugs] [Bug 13184] Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 16:31:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 15:31:23 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #88 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:26:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:26:28 +0000 Subject: [Koha-bugs] [Bug 13190] New: Export checkout list does not work anymore Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Bug ID: 13190 Summary: Export checkout list does not work anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 11703 breaks the export feature present on the checkout list. On circ/circulation.pl, the export column is there but not the export button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:26:39 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:26:39 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11703 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:26:45 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:30:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:30:13 +0000 Subject: [Koha-bugs] [Bug 13179] Circulation page layout problem when OnSiteCheckoutsForce is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13179 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:39:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:39:54 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #1 from Jonathan Druart --- Created attachment 33166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33166&action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:40:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:40:51 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #188 from Jonathan Druart --- This feature introduces a bug: it's not possible to export the checkout list. See bug 13190 for a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:45:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:45:26 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:51:55 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Jonathan Druart --- It does not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 17:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 16:52:04 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:06:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:06:52 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:17:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:17:12 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #3 from Jonathan Druart --- Created attachment 33167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33167&action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:17:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:17:26 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:17:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:17:50 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:17:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:17:50 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12404 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:19:10 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:19:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:19:12 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 --- Comment #2 from Owen Leonard --- Created attachment 33168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33168&action=edit Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:22:44 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33167|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 33169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33169&action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:27:45 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28767|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 33170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33170&action=edit Bug 12404: Add UT for marcrecord2csv Verify that these unit tests pass before any changes and after applying all patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:27:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:27:48 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28768|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 33171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33171&action=edit Bug 12404: Add new unit tests These unit tests reflect the changes done in next patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:27:51 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28769|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 33172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33172&action=edit Bug 12404: Allow TT tags for csv profiles This patch is the main patch. It contains the changes in C4::Record::marcrecord2csv. The goal of this development is to provide a better flexibility on creating a CSV profile. Currently it is not possible to: - Concatenate specific subfields into a csv column - Display a field/subfield using a condition - Extract a substring of a subfield value and a lot of other actions. This patch allows to write Template Toolkit code and to extract only data you want. See the help page for more information (in next patch). Test plan: Create some CSV profiles (MARC, not SQL) using some TT methods. Use the basket export and the export tool and verify the CSV file generated is what you expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:27:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:27:54 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28770|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 33173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33173&action=edit Bug 12404: tools/export.pl allows CSV export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:27:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:27:57 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28771|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 33174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33174&action=edit Bug 12404: Add some documentation in the help page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:28:53 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Jonathan Druart --- Bug 10703 introduces a big regression, see bug 13190. Has to be apply before this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:38:00 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #13 from M. de Rooy --- Will still make some small adjustments before setting to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 18:55:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 17:55:54 +0000 Subject: [Koha-bugs] [Bug 13191] New: Null borrowernumber in reserves table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13191 Bug ID: 13191 Summary: Null borrowernumber in reserves table Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Occasionally, we have reserves placed on our system without a linked borrowernumber. It displays as NULL in the reserves table of the database. I cannot recreate how this behavior is happening so far, except to say it appears to originate on the public side of the system. Some debugging code was added to C4::Reserves::AddReserve on our system, and the logs revealed it's a call to AddReserve where no borrowernumber is passed in -- on the OPAC side. Has anyone else seen this behavior? Know why it's happening? Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 19:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 18:02:16 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 19:10:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 18:10:55 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #55 from simith.doliveira at inlibro.com --- Created attachment 33175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33175&action=edit Bug 8753 - Add forgot password link to OPAC - Updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 19:13:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 18:13:23 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #56 from simith.doliveira at inlibro.com --- Created attachment 33176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33176&action=edit Bug 8753 - Add forgot password link to OPAC - DBIx Schema Added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 19:14:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 18:14:14 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 19:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 18:45:13 +0000 Subject: [Koha-bugs] [Bug 13192] New: Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192 Bug ID: 13192 Summary: Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: tiburce.euphrasie at aupaysdescrevettes.org QA Contact: testopia at bugs.koha-community.org Aloha, Fr?d?ric Demians suggests me to open a new bug report for this case (please read http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 for more information): ...I think I've also detected a small problem in cataloguing::value_builder::unimarc_field_010 : [...] Line 94 to 96 : if (length ($isbn) == 13){ $isbn = substr($isbn, 3, length($isbn)-3); } [...] Then, line 143 : $sth->execute($seg2, "978$seg2"); This "978" on line 143 is hard-coded and there's no relation with the original data inside $isbn (lost on line 95 via the substr function). I don't know if this is a real problem but it might be better to keep the original data than replacing it with "978". Thanks to Fr?d?ric Demians for resolving bug 13167. Aloha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:01:31 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31181|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 33177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33177&action=edit Bug 6681: introduce XSLT scripts to remove items and links This patch adds the following sample files: - Del952.xsl - Del995.xsl - Del9LinksExcept952.xsl - Del9LinksExcept995.xsl Thay can be used on the new SRU/Z39.50 XSLT processing feature. At the same time they can be used to solve this bug. To test: - Have an SRU/Z39.50 target configured - Have a search that returns at least a record with the following properties: * It contains $9 links * It contains items (952 or 995 fields in MARC21/NORMARC and UNIMARC respectively). MARC21/NORMARC test: - Do a Z39.50/SRU cataloguing search that retrieves the desired record - Verify it includes $9 and 952 field(s) by clicking on the MARC link - Edit your Z39.50 target and add Del952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view of the imported record doesn't contain the 952 field - Edit your Z39.50 target and add Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view contains the 952 field (including the $9 subfield), and all other $9 subfields have been removed - Edit your Z39.50 target and add Del952.xsl, Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field (both, comma separated) - Re-run the search => SUCCESS: the MARC view doesn't contain $9 subfields nor items. - Repeat for UNIMARC, replacing 952 for 995. - Sign off :-D Regards Tomas Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:02:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:02:11 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:24:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:24:25 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- If you do not have "Always show checkouts immediately" checked by default, the list of checkouts doesn't appear but the "export checkouts" form does. However, the "export checkouts" function doesn't work unless you have selected checkouts to export. I think the export form should be hidden by default along with the checkouts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:31:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:31:23 +0000 Subject: [Koha-bugs] [Bug 13193] New: Discussion: strategy for diagnosing memcache issues. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Bug ID: 13193 Summary: Discussion: strategy for diagnosing memcache issues. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In bug 13150, we came across the following error: Can't use string ("") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Biblio.pm line 1635. Ultimately, this was determined to be caused by a corrupted data structure caused by memcache. I would suggest creating an entry in a similar hash that contains a well known string that could be checked upon entering any page. If the memcached copy didn't match the well-known value, we would know that memcache is having problems, and throw a warning of some sort, advising that memcache should be re-started. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:31:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:31:58 +0000 Subject: [Koha-bugs] [Bug 13193] Discussion: strategy for diagnosing memcache issues. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:42:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:42:37 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #7 from Owen Leonard --- There a couple of things I would like to see added if possible: - Output of subtitles as defined in Keyword to MARC mapping - Overdue items highlighted in red as they are on the checkouts page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 20:45:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 19:45:34 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #4 from Tiburce Euphrasie --- (In reply to Fr?d?ric Demians from comment #2) > (In reply to Tiburce Euphrasie from comment #0) > > > I think I've also detected a small problem in > > Open a separate bug report. Aloha, Done. See bug 13192 : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192 Aloha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 21:19:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 20:19:37 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #5 from Tiburce Euphrasie --- (In reply to Fr?d?ric Demians from comment #1) > Created attachment 33130 [details] [review] > Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 > > If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for > import' hangs. If I use the same UNIMARC record and change 979 to 978 in the > ISBN, 'Stage MARC for import' works perfectly. > > The patch deals with the fact that converting an ISBN-13 to ISBN-10 with > Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978. Aloha Fr?d?ric Demians, Adding 'return unless $isbn;' on line 1683 in Koha.pm means that the sub NormalizeISBN will return nothing for the specific ISBN sample I've provided. This is not a proper way to fix this bug because that patch implies that all those '979.*' ISBN simply don't exist. Bu the way, the initial summary for this bug was "Stage MARC for Import hangs", a mistake was done when changing this summary to "Stage MARC for Import hangs for biblio containing invalid ISBN-13", so I'll change it to "Stage MARC for Import hangs for biblio containing valid 979* ISBN-13" after redacting this comment. This ISBN is valid : - there's a scan from the original book in the attachment file 32969 : http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32969 - There's some documentation available this kind of ISBN : http://www.afnil.org/ http://fr.wikipedia.org/wiki/International_Standard_Book_Number Aloha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 21:23:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 20:23:53 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Tiburce Euphrasie changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Stage MARC for Import hangs |Stage MARC for Import hangs |for biblio containing |for biblio containing valid |invalid ISBN-13 |979* ISBN-13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 21:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 20:27:12 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 21:37:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 20:37:29 +0000 Subject: [Koha-bugs] [Bug 13132] Confirm report delete? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #2 from Heather Braum --- Owen, We are on 3.16.4 (which I thought was the latest version of 3.16 when I reported this issue), and I am still not seeing a confirm delete message on Mac and PC versions of Firefox and Chrome... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 21:52:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 20:52:58 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:03:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:03:37 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #6 from Fr?d?ric Demians --- (In reply to Tiburce Euphrasie from comment #5) Aloha! > Aloha Fr?d?ric Demians, > Adding 'return unless $isbn;' on line 1683 in Koha.pm means that the sub > NormalizeISBN will return nothing for the specific ISBN sample I've provided. > > This is not a proper way to fix this bug because that patch implies that all > those '979.*' ISBN simply don't exist. Your assumption is not correct. The function can't transform your ISBN-13 into ISBN-10, because it begins with '979'. Rather than returning undef to say that the conversion is not possible, the function was failing badly, stopping completely the Perl process. That's what is corrected by the patch. Have you tried the patch? Does it solve the bug reported here? Can you import your record? Is your ISBN field preserved? For both records? The Koha internal function NormalizeISBN is called from other part of the Koha code base (see bug 13158). When the action requested to the function could not be completed, the function is supposed to return undef (nothing). That's exactly what'is done with the patch. The import process call NormalizeISBN function for whatever reason. I can't say why, indeed. And for doing nothing with the result, since ISBN field is not modified during import. But this is another story, and can't be fixed here. > Bu the way, the initial summary for this bug was "Stage MARC for Import > hangs", a mistake was done when changing this summary to "Stage MARC for > Import hangs for biblio containing invalid ISBN-13", so I'll change it to > "Stage MARC for Import hangs for biblio containing valid 979* ISBN-13" after > redacting this comment. You're correct. That's a valid ISBN-13 which can't be converted into ISBN-10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:06:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:06:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #57 from M. de Rooy --- Interesting! Just some thoughts: The SQL code in the opac-recovery script will not make it pass QA. Please move it to module level (in DBIx?). Can you unit test SendPasswordRecoveryEmail? I would not mind a mail with a library password; other info is more sensitive. If you can read/intercept the password from the mail, you can also read the unique userid for the reset password form. Same result: a hacked account. This approach is fine with me, feels more safe but is not per se safer imo. Thinking out loud: if you do not include sensitive keywords as "password" in your mail (so rename your script?), would that be little more safe? Would not attract attention? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:11:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:11:25 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #58 from Chris Cormack --- (In reply to M. de Rooy from comment #57) > Interesting! Just some thoughts: > The SQL code in the opac-recovery script will not make it pass QA. Please > move it to module level (in DBIx?). > Can you unit test SendPasswordRecoveryEmail? > > I would not mind a mail with a library password; other info is more > sensitive. If you can read/intercept the password from the mail, you can > also read the unique userid for the reset password form. Same result: a > hacked account. This approach is fine with me, feels more safe but is not > per se safer imo. I disagree, a token should be time based, and will require the person to set a password. This password only they will know. It's true that if someone intercepts the token and uses it to set your password for you, that is still a problem. However when you go to use the token and find out it has been used you will know this. If they intercept your password, they could use it for a bunch of time without you ever knowing. Sending passwords in the clear is a bad idea. Please do not do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:15:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:15:58 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #59 from Katrin Fischer --- I agree with Chris, I think. Also we have a similar approach for the patron verification - sending a link to a page where you learn about your password. It seems a good way to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:20:28 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #13 from Fr?d?ric Demians --- For me, there is a design error in you dev. You send to TT a representation of MARC record which is not correct. You loose the field order in the record, and subfields order inside each field. The fields object sent to TT is a hashref of arrayref of hashref of array. The valid representation is an arrayref (1 per tag) of arrayref (1 per subfield) of arrayref (1 per pair letter/value). So for example (bad example), if you have: 245 ## - TITLE STATEMENT a Title My first title b Remainder of title My remainder a Title My second title With your represenation, you can't know anymore that the second $a comes after $b. In MARC21, it's important since separators are in the subfield content itself. Your 245 field will be represented like that: 245 => { 'a' => [ 'My first title', 'My second title' ], 'b' => [ 'My remainder' ] } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:20:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:20:47 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #28 from Robin Sheat --- Is it really coming from Koha::Cache? I haven't had a chance to look yet, but I don't really understand those messages, and without understanding they'll be hard to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:21:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:21:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #60 from Eric B?gin --- The token sent to the user is valid only for 2 days or if the link is clicked. Most of the time, a use who requests a password will click the link in the following minutes (if not seconds). Of course, this doesn't prevent your email to be intercepted. As far as I know, this feature was implemented the way most of the ? Forgot your password ? ? links are implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:28:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:28:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #61 from Liz Rea --- Also, if you send the password in the clear, if it is intercepted once, and you are one of (more people than we'd like to admit) those people who uses the same password in multiple accounts, it's not only your library account that is now possibly hacked. We should not ever, ever, ever show a password in the clear. Ever. I am glad this works the way it does, it is the proper way. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:32:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:32:02 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #62 from Eric B?gin --- Juste wondering how this clear text password came in the discussion. That was never the case with this development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:34:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:34:58 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #63 from Liz Rea --- Comment 57, 2nd paragraph - when someone doing QA suggests mailing a cleartext password might be ok, it seems right to emphatically tell them "no, that's a bad idea." I for one appreciate the fact that it was never part of this dev, thanks for doing it properly. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:37:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:37:41 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #8 from Barton Chittenden --- (In reply to Fr?d?ric Demians from comment #7) > (In reply to Chris Cormack from comment #6) > > > 28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set > > to mm/dd/yyyy (american format) > > I already tested switching dateformat do dd/mm/yyyy. It doesn't help. Sorry. Fr?d?ric: did you test dd/mm/yyyy or mm/dd/yyyy? The latter is the one we're having trouble with. Your reply above suggests that you tested the former, but I can't tell if you mis-typed your answer or mis-tested. No big deal either way, I'm just looking for clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:39:06 +0000 Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure if it's wrong - it seems like it might be intended behaviour. The library staff might have a different set of fields to fill out then the patron. I am not sure, but i think it earlier versions we didn't check for mandatory fields at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:47:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:47:02 +0000 Subject: [Koha-bugs] [Bug 12886] shelfbrowser script should write headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:47:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:47:05 +0000 Subject: [Koha-bugs] [Bug 12886] shelfbrowser script should write headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33142|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 33178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33178&action=edit [PASSED QA] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header=
I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes tests and QA script, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 22:49:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 21:49:19 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Katrin Fischer --- Hm not sure what's wrong - I tried applying 11944 first, but got a couple of conficts. 7380 won't apply alone either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:08:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:08:25 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #5 from Chris Cormack --- Comment on attachment 33129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33129 Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details Review of attachment 33129: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13170&attachment=33129) ----------------------------------------------------------------- ::: opac/opac-showmarc.pl @@ +57,5 @@ > + C4::Context->config('opachtdocs'), > + C4::Context->preference('opacthemes'), > + C4::Languages::getlanguage($input), > + $view eq 'card' ? 'compact.xsl' : 'plainMARC.xsl' > + ); Why are we doing this? Instead of using C4::Template::themelanguage ? Now we still have different behaviour for xslt and for normal templates themelanguage will never fallback to prog for the opac. however _get_best_defautl_xslt_filename will. So if have a new theme chrisc theme. And I make all the stuff, but no new xslt file. It will now fall back to prog, instead of bootstrap. This is a problem as prog no longer exists in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:08:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:08:53 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:23:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:23:21 +0000 Subject: [Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.14 |master Severity|critical |normal --- Comment #2 from Katrin Fischer --- To test: - Create an authority for "Cement Concrete & Aggregates Australia" - Create a new bibliographic record, link to the authority - Click on the plugin again, the search string is not complete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:26:45 +0000 Subject: [Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #7 from Katrin Fischer --- We have an updated English UNIMARC framework now with 11453. I am not sure it makes sense to continue here - maybe we should file more specific bugs for further improvements/fixes? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:35:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:35:52 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- I feel like we made a mistake here. Now it's not possible to add notices that have a hardcoded notice code like 'HOLD' for multiple branches. Maybe I am wrong...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:37:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:37:21 +0000 Subject: [Koha-bugs] [Bug 12008] hold notice can be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Can't test this as it's currently not possible to add mulitple letters with the same code :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:39:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:39:41 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #6 from Fr?d?ric Demians --- (In reply to Chris Cormack from comment #5) > Why are we doing this? Instead of using C4::Template::themelanguage ? > > Now we still have different behaviour for xslt and for normal templates > > themelanguage will never fallback to prog for the opac. however > _get_best_defautl_xslt_filename will. > > So if have a new theme chrisc theme. And I make all the stuff, but no new > xslt file. It will now fall back to prog, instead of bootstrap. > > This is a problem as prog no longer exists in the OPAC. Ok. I see. I forgot to modify _get_best_default_xslt_filename to fall back to 'bootstrap' theme rather than 'prog' for OPAC interface. There is a difference between C4::Template::themelanguage & C4::XSLT::_get_best_default_xslt_filename. 'themelanguage' search tempalates in subdirectories of directory named 'modules'. '_get_best_default_xslt_filename' search XSL file in a subdirectory named 'xslt'. Would you suggest to factorize both functions in one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:40:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:40:10 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:43:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:43:57 +0000 Subject: [Koha-bugs] [Bug 7997] Can't create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can create a notice with |Can't create a notice with |the same code |the same code --- Comment #15 from Katrin Fischer --- Updating the bug description a bit: The problem now is that we DON'T allow for duplicate letter codes and a check has been added in the template (bug 11742). But I think we forgot about the existence of the hardcoded letter codes - some of those are: - ACCTDETAULS - HOLD - Slip templates... So... I think we need to find a way to allow duplicates? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:44:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:44:48 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #10 from Katrin Fischer --- Kyle, could you take another look at this? I think it's almost a blocker, as your items will not be reset to the correct state if the fields has been empty (which is kind of a data loss) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:46:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:46:32 +0000 Subject: [Koha-bugs] [Bug 9342] zebra UNIMARC dom indexing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Is DOM indexing for UNIMARC still not functional at all, as the title of this bug suggests or is there a more specific problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:47:43 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #11 from Katrin Fischer --- I think we can't leave that it is currently - we need local logins or we will break people's LDAP setups on update :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:49:58 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #7 from Chris Cormack --- (In reply to Fr?d?ric Demians from comment #6) > (In reply to Chris Cormack from comment #5) > > > Why are we doing this? Instead of using C4::Template::themelanguage ? > > > > Now we still have different behaviour for xslt and for normal templates > > > > themelanguage will never fallback to prog for the opac. however > > _get_best_defautl_xslt_filename will. > > > > So if have a new theme chrisc theme. And I make all the stuff, but no new > > xslt file. It will now fall back to prog, instead of bootstrap. > > > > This is a problem as prog no longer exists in the OPAC. > > Ok. I see. I forgot to modify _get_best_default_xslt_filename to fall back > to 'bootstrap' theme rather than 'prog' for OPAC interface. It should fall back to whateverr OPACFallback is set to. Currently thats bootstrap, but we dont want to be in this same position when we change default theme again sometime in the future of having hardcoded theme names. > > There is a difference between C4::Template::themelanguage & > C4::XSLT::_get_best_default_xslt_filename. 'themelanguage' search tempalates > in subdirectories of directory named 'modules'. > '_get_best_default_xslt_filename' search XSL file in a subdirectory named > 'xslt'. > > Would you suggest to factorize both functions in one? Something like that, a single place where we pick the theme and language seems to be a lot less error prone and easier to maintain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:53:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:53:05 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:53:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:53:08 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33129|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 33179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33179&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Note: Implemented with C4::XSLT::_get_best_default_xslt_filename() to keep code orthogonal. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:56:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:56:33 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #9 from Chris Cormack --- Comment on attachment 33179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33179 Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details Review of attachment 33179: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13170&attachment=33179) ----------------------------------------------------------------- ::: C4/XSLT.pm @@ +145,4 @@ > my @candidates = ( > "$htdocs/$theme/$lang/xslt/${base_xslfile}", # exact match > "$htdocs/$theme/en/xslt/${base_xslfile}", # if not, preferred theme in English > + "$htdocs/bootstrap/$lang/xslt/${base_xslfile}", # if not, 'bootstrap' theme in preferred language Hmm nope, still not the same behaviour in themelanguage we do my $fallback_syspref = ($interface eq 'intranet') ? 'template' : 'OPACFallback'; C4::Context->preference( $fallback_syspref ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 3 23:58:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 22:58:51 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #10 from Fr?d?ric Demians --- > It should fall back to whateverr OPACFallback is set to. Currently thats > bootstrap, but we dont want to be in this same position when we change > default theme again sometime in the future of having hardcoded theme names. Sorry. I wasn't even aware of this syspref. > Something like that, a single place where we pick the theme and language > seems to be a lot less error prone and easier to maintain. Will try. Thanks. > Hmm nope, still not the same behaviour > > in themelanguage we do > > my $fallback_syspref = ($interface eq 'intranet') ? 'template' : > 'OPACFallback'; > C4::Context->preference( $fallback_syspref ) I couldn't agree with you more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 00:09:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 23:09:20 +0000 Subject: [Koha-bugs] [Bug 12971] Printing member information lacks data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 00:29:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 23:29:41 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33179|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 33180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33180&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Note: Implemented with C4::XSLT::_get_best_default_xslt_filename() to keep code orthogonal. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 00:39:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Nov 2014 23:39:25 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #12 from Chris Cormack --- Excellent this looks good, Ill do a proper test tomorrow (i might edit the commit message to remove mention of the sub we aren't using now). But from a code review it looks good. Just to do some regression testing now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 01:14:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 00:14:03 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #64 from M. Tompsett --- (In reply to M. de Rooy from comment #57) > Interesting! Just some thoughts: > The SQL code in the opac-recovery script will not make it pass QA. Please > move it to module level (in DBIx?). > Can you unit test SendPasswordRecoveryEmail? Though, I would make sure this comment didn't get missed in the midst of everyone discussing password logic. M. de Rooy, are you talking about just the SELECT? What about the DELETE? Could you clarify which bits you mean by commenting on a splinter review? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 02:33:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 01:33:30 +0000 Subject: [Koha-bugs] [Bug 9175] Shelving location search returns no results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9175 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 06:46:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 05:46:06 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 06:46:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 05:46:10 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33180|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 33181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33181&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. Signed-off-by: Chris Note: This makes a small change to C4::Templates::themelanguage so that it works with .xsl files too (They live in the xslt dir) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 07:01:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 06:01:24 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #65 from Katrin Fischer --- We don't want any SQL code in the .pl files - so I'd say both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 07:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 06:48:49 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #7 from Katrin Fischer --- It would be great if someone could test this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 07:49:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 06:49:12 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #6 from Katrin Fischer --- It would be great if someone could test this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 07:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 06:50:32 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 07:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 06:50:34 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33181|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 33182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33182&action=edit [PASSED QA] Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. Signed-off-by: Chris Note: This makes a small change to C4::Templates::themelanguage so that it works with .xsl files too (They live in the xslt dir) Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 09:03:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 08:03:58 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #29 from Jonathan Druart --- (In reply to Robin Sheat from comment #28) > Is it really coming from Koha::Cache? I haven't had a chance to look yet, > but I don't really understand those messages, and without understanding > they'll be hard to fix. koha at koha-qa:~/src (BZ11998?)% perl -wc C4/Context.pm Subroutine handle_errors redefined at C4/Context.pm line 28. Constant subroutine C4::Context::CONFIG_FNAME redefined at /usr/share/perl/5.20/constant.pm line 156. Subroutine KOHAVERSION redefined at C4/Context.pm line 214. Subroutine final_linear_version redefined at C4/Context.pm line 234. Subroutine read_config_file redefined at C4/Context.pm line 263. Subroutine ismemcached redefined at C4/Context.pm line 279. Subroutine memcached redefined at C4/Context.pm line 290. Subroutine db_scheme2dbi redefined at C4/Context.pm line 309. Subroutine import redefined at C4/Context.pm line 314. Subroutine new redefined at C4/Context.pm line 353. Subroutine set_context redefined at C4/Context.pm line 429. Subroutine restore_context redefined at C4/Context.pm line 468. Subroutine _common_config redefined at C4/Context.pm line 499. Subroutine config redefined at C4/Context.pm line 512. Subroutine zebraconfig redefined at C4/Context.pm line 515. Subroutine ModZebrations redefined at C4/Context.pm line 518. Subroutine preference redefined at C4/Context.pm line 540. Subroutine boolean_preference redefined at C4/Context.pm line 567. Subroutine enable_syspref_cache redefined at C4/Context.pm line 583. Subroutine disable_syspref_cache redefined at C4/Context.pm line 597. Subroutine clear_syspref_cache redefined at C4/Context.pm line 613. Subroutine set_preference redefined at C4/Context.pm line 628. Subroutine delete_preference redefined at C4/Context.pm line 676. Subroutine AUTOLOAD redefined at C4/Context.pm line 703. Subroutine Zconn redefined at C4/Context.pm line 725. Subroutine _new_Zconn redefined at C4/Context.pm line 751. Subroutine _new_dbh redefined at C4/Context.pm line 813. Subroutine dbh redefined at C4/Context.pm line 878. Subroutine new_dbh redefined at C4/Context.pm line 912. Subroutine set_dbh redefined at C4/Context.pm line 937. Subroutine restore_dbh redefined at C4/Context.pm line 960. Subroutine queryparser redefined at C4/Context.pm line 984. Subroutine _new_queryparser redefined at C4/Context.pm line 1004. Subroutine marcfromkohafield redefined at C4/Context.pm line 1036. Subroutine _new_marcfromkohafield redefined at C4/Context.pm line 1052. Subroutine stopwords redefined at C4/Context.pm line 1077. Subroutine _new_stopwords redefined at C4/Context.pm line 1093. Subroutine userenv redefined at C4/Context.pm line 1117. Subroutine set_userenv redefined at C4/Context.pm line 1139. Subroutine set_shelves_userenv redefined at C4/Context.pm line 1161. Subroutine get_shelves_userenv redefined at C4/Context.pm line 1169. Subroutine _new_userenv redefined at C4/Context.pm line 1196. Subroutine _unset_userenv redefined at C4/Context.pm line 1213. Subroutine get_versions redefined at C4/Context.pm line 1230. Subroutine tz redefined at C4/Context.pm line 1256. Subroutine IsSuperLibrarian redefined at C4/Context.pm line 1271. Subroutine interface redefined at C4/Context.pm line 1295. Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.20/fields.pm line 135. Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.20/fields.pm line 135. Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.20/fields.pm line 135. C4/Context.pm syntax OK koha at koha-qa:~/src (BZ11998?)% perlcritic C4/Context.pm Variable declared in conditional statement at line 544, column 5. Declare variables outside of the condition. (Severity: 5) On master: koha at koha-qa:~/src (master??)% perl -wc C4/Context.pm C4/Context.pm syntax OK koha at koha-qa:~/src (master??)% perlcritic C4/Context.pm C4/Context.pm source OK The perlcritic error is easy to fix, I can provide a followup, but I don't understand the warnings neither. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 09:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 08:07:09 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #30 from Jonathan Druart --- Created attachment 33183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33183&action=edit Bug 11998: QA follow-up - fix the perlcritic error % perlcritic C4/Context.pm Variable declared in conditional statement at line 544, column 5. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 09:09:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 08:09:20 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Jonathan Druart --- You should use the branch ft/bug_11944, not the patches on the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 09:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 08:35:46 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #6 from Jonathan Druart --- Created attachment 33184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33184&action=edit Bug 13190: Refactor the checkouts table template code This code is duplicated and should be centralised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 09:37:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 08:37:41 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart --- (In reply to Owen Leonard from comment #5) > If you do not have "Always show checkouts immediately" checked by default, > the list of checkouts doesn't appear but the "export checkouts" form does. It worked on a view, not on the other. I copy the duplicated code into an include file in order to avoid this mistake later. > However, the "export checkouts" function doesn't work unless you have > selected checkouts to export. You would like to export all checkouts, that's it? This behavior is the same as before I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 09:54:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 08:54:39 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #14 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #13) > For me, there is a design error in you dev. You send to TT a representation > of > MARC record which is not correct. You loose the field order in the record, > and > subfields order inside each field. The fields object sent to TT is a hashref > of > arrayref of hashref of array. The valid representation is an arrayref (1 per > tag) of arrayref (1 per subfield) of arrayref (1 per pair letter/value). It's easier to manipulate hashref than arrayref in this case. If you want to access to the $b subfield, you don't need to process all subfields. Could you give me an where this structure would be a problem for a CSV export? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 10:23:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 09:23:34 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #8 from Jonathan Druart --- Created attachment 33185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33185&action=edit Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 10:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 09:25:18 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #9 from Jonathan Druart --- (In reply to Owen Leonard from comment #7) > - Output of subtitles as defined in Keyword to MARC mapping I don't want to add to much information on this table. But this could be done later if needed. > - Overdue items highlighted in red as they are on the checkouts page Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 10:43:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 09:43:01 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart --- (In reply to Paola Rossi from comment #11) > For 1) I pass the patches to "Failed QA" status. Paola, thanks for testing. What you described is the expected behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:04:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:04:27 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #15 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #14) > It's easier to manipulate hashref than arrayref in this case. If you want to > access to the $b subfield, you don't need to process all subfields. Could > you give me an where this structure would be a problem for a CSV export? I agree. I have seen TT syntax you can get: fields.245, fields.245.a. And then [% FOREACH %] on hashref keys... It's elegant, but it is also a trap. In MARC21, you can have this kind of title field: 245 14 $a The phonics basic skills workbook. $n Part 1, $p Reading readiness $h [videorecording] : $b preparing for kindergarten. which should be rendered: The phonics basic skills workbook. Part 1, Reading readiness [videorecording] : preparing for kindergarten. With your field representation, you loose the subfield order: a, n, p, h, and b. There is chance a TT construction will try to put $b just after $a, which is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:04:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:04:39 +0000 Subject: [Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12821 --- Comment #9 from Jonathan Druart --- Is this problem still exist on master? It seems that bug 11821 corrected it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:04:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:04:39 +0000 Subject: [Koha-bugs] [Bug 12821] Capitalization: about page fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11817 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:05:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:05:31 +0000 Subject: [Koha-bugs] [Bug 12378] addbiblio.pl error when deleting record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 11817 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:05:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:05:31 +0000 Subject: [Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at stas.org --- Comment #10 from Jonathan Druart --- *** Bug 12378 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:11:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:11:03 +0000 Subject: [Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:38:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:38:48 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:38:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:38:51 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30988|0 |1 is obsolete| | Attachment #30989|0 |1 is obsolete| | Attachment #30990|0 |1 is obsolete| | Attachment #30991|0 |1 is obsolete| | Attachment #31273|0 |1 is obsolete| | Attachment #31960|0 |1 is obsolete| | Attachment #31961|0 |1 is obsolete| | Attachment #32230|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 33186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33186&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:38:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:38:55 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #20 from Jonathan Druart --- Created attachment 33187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33187&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:38:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:38:58 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #21 from Jonathan Druart --- Created attachment 33188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33188&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:39:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:39:01 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #22 from Jonathan Druart --- Created attachment 33189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33189&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:39:05 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #23 from Jonathan Druart --- Created attachment 33190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33190&action=edit Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:39:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:39:08 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #24 from Jonathan Druart --- Created attachment 33191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33191&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:39:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:39:12 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #25 from Jonathan Druart --- Created attachment 33192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33192&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:39:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:39:15 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #26 from Jonathan Druart --- Created attachment 33193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33193&action=edit Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 11:40:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 10:40:03 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #27 from Jonathan Druart --- (In reply to Paola Rossi from comment #18) > # Looks like you failed 2 tests of 3. I don't get these failures, could you please retest with this new rebased patch set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 12:28:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 11:28:43 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 12:28:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 11:28:45 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 --- Comment #1 from Kyle M Hall --- Created attachment 33194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33194&action=edit Bug 13189 - Patron card creator patron search browse by last name broken by extended attributes The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! Test Plan: 1) Enable extended patron attributes 2) Add a new searchable patron attribute 3) Create a new patron with the last name "Ace" 4) Add the value "D" to the attribute for this patron 5) Browse to the patron card maker, start a new patron batch 6) Click "Add item(s)" to bring up the patron search 7) Click the letter "D" in the patron search box 8) Note that "Ace" shows in the results list 9) Apply this patch 10) Repeat step 7 11) Note that "Ace" no longer shows in the results list 12) Perform a regular search by putting the letter "D" in the "Name:" field, and hit the "Search" button 13) Note this time the results *do* have Ace in them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 12:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 11:29:03 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 12:44:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 11:44:11 +0000 Subject: [Koha-bugs] [Bug 13194] New: Tiny typo in POD for SetMessagingPreferencesFromDefaults Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Bug ID: 13194 Summary: Tiny typo in POD for SetMessagingPreferencesFromDefaults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org The POD for C4::Members::Messaging::SetMessagingPreferencesFromDefaults() has an example of usage: C4::Members::Messaging::SetMessagingPreferenceFromDefaults( { borrowernumber => $borrower->{'borrowernumber'} categorycode => 'CPL' } ); The name of the subroutine is mis-spelled as SetMessagingPreferenceFromDefaults when it should be SetMessagingPreference*s*FromDefaults. This has no practical consequences of course, but if you copy and paste the example into your code it can lead to some unnecessary head scratching. Trust me, I know... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 12:51:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 11:51:26 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |z.tajoli at cineca.it --- Comment #8 from Zeno Tajoli --- Hi all, in fact now the tag '' is not used by Koha. We need to delete it, but not with perl code. In my opinion the best option is to delete it in sql files (sample_notices.sql). So the patch do the work but not in the good place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 13:04:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 12:04:06 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #5 from Gaetan Boisson --- Bug found after more testing: The fields of the form in acquisitions will create values in the marc record. If we have default values for the same fields in the ACQ framework, we will systematically have two marc tags created in the record. It is not a huge problem since very few fields are created by the form in acquisitions but would be better handled this way: If the marc tag doesn't exist (ie wasn't created by the acquisitions form), create it with the subfield and its default values. If the marc tag already exist, but the subfield doesn't, add the subfield with its default value to the existing tag If both marc tag and subfield already exists, do nothing. Of course one could argue that for repeatable fields, one should be able to chose where to create the subfield. But i don't see an easy way to do this, and since so few fields are concerned, i think we'd better just be careful when using this feature not to overlap too much with fields handled by the form. Here's anexample (with french unimarc) of the current behaviour to make things clearer: The document type field in the form will create a value in 099$t (bibliographic level itemtype.) The ACQ framework is set to put a default value of 1 in 099$z. Then the resulting record will look like this: 099 ## - Informations locales z 1 099 ## - Informations locales t [docupment type] the field 099 being not repeatable, this is not valid, additionally, if one then manually edits the record, the two 099 show up in the interface, and if a default value is set for 099$t, the new record will look like this (two document types): 099 ## - Informations locales t [document type default value] z 1 099 ## - Informations locales t [docupment type] If the ACQ framework has a default value for a subfield that is created by the acquisitions form, the marc tag will also be duplicated. Like this: 099 ## - Informations locales z 1 (value coming from the ACQ framework) 099 ## - Informations locales t (value coming from the ACQ framework) 099 ## - Informations locales t (value entered in the acquisitions form) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 13:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 12:22:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #16 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #15) > With your field representation, you loose the subfield order: a, n, p, h, and > b. There is chance a TT construction will try to put $b just after $a, which > is > wrong. I am not sure to understand the problem. In our case (CSV), you will set something like: === Title=[% FOREACH field IN fields.245 %][% field.a.0 %] [% field.a.n %] [% field.a.p %] [% field.a.h %] [% field.a.b %][% END %] === Since it's not possible to display an entire field and you need to list the subfields you want to display, the order is not a problem. But maybe I am missing something. IMO this way allows us a very good flexibility (since we can use the TT methods) with a minimum of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 13:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 12:25:26 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #9 from Katrin Fischer --- Zeno, are you sure it's not used? I thought it might be used to have a multi-line order layout (similar to items) - but haven't had the time to check yet. Title Price Note... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 13:26:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 12:26:24 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #10 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #8) > Hi all, Hi Zeno, > in fact now the tag '' is not used by Koha. Why do you say that? It's still in used. > We need to delete it, but not with perl code. > In my opinion the best option is to delete it in sql files > (sample_notices.sql). We need it to know we have to loop on orders. > So the patch do the work but not in the good place. I didn't find a better place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 13:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 12:54:47 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #17 from Fr?d?ric Demians --- > I am not sure to understand the problem. > In our case (CSV), you will set something like: > === > Title=[% FOREACH field IN fields.245 %][% field.a.0 %] [% field.a.n %] [% > field.a.p %] [% field.a.h %] [% field.a.b %][% END %] > === > > Since it's not possible to display an entire field and you need to list the > subfields you want to display, the order is not a problem. Let suppose than another valid 245 field contains (from LoC MARC21 format): 245 00 $a Love from Joy : $b letters from a farmer?s wife. $n Part III, $p 1987-1995, At the bungalow. It must be displayed (and exported): Love from Joy : letters from a farmer?s wife. Part III, 1987-1995, At the bungalow. With you TT (minus typo): Love from Joy : Part III, 1987-1995, At the bungalow. letters from a farmer's wife. You can't have an unique TT for all 245 subfields combinations. > IMO this way allows us a very good flexibility (since we can use the TT > methods) with a minimum of code. It still possible. Fields order isn't that important, but sufields is. You could build an hashref of arrayref of arrayref. For a $record containing a MARC::Record (its a variation of your code): my $fields; for my $field ( $record->fields ) { my $fieldtag = $field->tag; my $values; if ( $field->is_control_field ) { $values = $field->data(); } else { $values->{indicator}{1} = $field->indicator(1); $values->{indicator}{2} = $field->indicator(2); for ( $field->subfields ) { my ($letter, $value) = @$_; push @{ $values->{subf} }, [ $letter => $value ]; } } # We force the key as an integer (trick for 00X and OXX fields) push @{ $fields->{fields}{0+$fieldtag} }, $values; } And then to display the first 245 field, all subfields in order: [% FOREACH s IN fields.245.first.subf %][% s.1 %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:09:46 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:09:49 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 --- Comment #1 from Magnus Enger --- Created attachment 33195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33195&action=edit Fix typo in SetMessagingPreferencesFromDefaults POD The example usage for C4::Members::Messaging::SetMessagingPreferencesFromDefaults calls the subroutine SetMessagingPreferenceFromDefaults, not SetMessagingPreferencesFromDefaults (missing the 's' at the end of 'Preferences'). To test: - Apply the patch - Check that the POD now refers to the actual name of the subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:21:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:21:28 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #18 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #17) > It still possible. Fields order isn't that important, but sufields is. You > could build an hashref of arrayref of arrayref. For a $record containing a > MARC::Record (its a variation of your code): I accept, of course, all kinds of followup to improve this enhancement :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:24:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:24:11 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 --- Comment #6 from Jonathan Druart --- Created attachment 33196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33196&action=edit Bug 12743: ACQ: default values for catalogue records At the moment, it is possible to create records in acquisitions, but the ACQ framework is only used for items created in this module. This patch allows to defined default values in the ACQ framework for records created on the acquisition module. Test plan: 1/ Make sure you have the ACQ framework created (otherwise create it from the default framework). 2/ Define a default value for a field (for instance 099$z=1). 3/ Go in the acquisition module and create a new order from a new record. 4/ Fill mandatory information and save. 5/ Go on the detail page of this record and verify the default value exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:24:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:24:56 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart --- (In reply to Gaetan Boisson from comment #5) > Bug found after more testing: The last patch should take into account all cases you listed. Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:38:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:38:06 +0000 Subject: [Koha-bugs] [Bug 13195] New: Regression: Circulation checkouts table no longer shows item type description Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13195 Bug ID: 13195 Summary: Regression: Circulation checkouts table no longer shows item type description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: kyle at bywatersolutions.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Another regression caused by Bug 11703: The list of checkouts on the circulation and patron detail page shows item type codes instead of the full description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:40:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:40:01 +0000 Subject: [Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Summary|Item lost status should |Regression: Item lost |show in list of checkouts |status doesn't show in list | |of checkouts Severity|enhancement |major --- Comment #2 from Owen Leonard --- This is a regression caused by Bug 11703 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:43:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:43:28 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 14:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 13:48:38 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #11 from Zeno Tajoli --- Dear Johnatyhan and Katrin, if you see here: http://manual.koha-community.org/3.16/en/noticesappendix.html#noticesfieldguide you can see that in Notices and slips only those 'special' tags are supported: <> or Those tags needs special routines in the code because the generic routine (C4:: Letters::GetPreparedLetter) works only with name of tables. And the name of table for order is 'aqorders', not 'orders'. As I know, '' and '' are only strings without meanning now in Koha. So the best option is to delete the tags in sample_notices.sql In comment 2 Paola Rossi found that ACQCLAIM and ACQCLAIM-ISSUE extrat all data that we need without '' and '', also for multiple situations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:03:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:03:07 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #19 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #18) > I accept, of course, all kinds of followup to improve this enhancement :) I don't say no :-) I've even tried. But I'me encountering now an issue with the mix in the code between previous syntax and TT syntax. I can't have a TT directive containing a = sign. For example: [% IF s.0 == 'b' %] [% SET letter = s.0 %] The = sign is used to split the CSV profile here: # Separating the marcfields from the user-supplied headers my @csv_structures; foreach (@marcfieldsarray) { my @result = split('=', $_); my $content = ( @result == 2 ) ? $result[1] : $result[0]; So it breaks valid TT code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:06:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:06:22 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:06:25 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31987|0 |1 is obsolete| | Attachment #31988|0 |1 is obsolete| | Attachment #31989|0 |1 is obsolete| | Attachment #32931|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 33197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33197&action=edit Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:06:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:06:30 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #13 from Jonathan Druart --- Created attachment 33198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33198&action=edit Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:06:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:06:35 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #14 from Jonathan Druart --- Created attachment 33199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33199&action=edit Bug 12944 [Patron lists follow-up] There is no way to search orders by creator This bug modifies not just the order search form but also the patron lists feature, making use of the new script for building a patron autocomplete form. However, the test plan does not specify that the patron lists form be tested as well, and it doesn't work. This patch corrects a minor flaw which broke the patron search autocomplete when adding patrons to a patron list. To test, create a new patron list if necessary. Click the "add patrons" button to add patrons to the list. In the patron search form type a partial patron name. You should get an autocomplete dropdown of existing patrons. Selecting one should work correctly. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:06:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:06:39 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #15 from Jonathan Druart --- Created attachment 33200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33200&action=edit Bug 12944: The autocomplete should only be applied for the form If it's the result view, the autocomplete should not be apply to the input element (it does not exist). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:08:18 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > I did an 'empty' search from the orders search tab at the top. Fixed! I also squashed the Kyle's patch (in order to avoid the creation and the deletion of a file in the git tree). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:09:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:09:40 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #17 from Jonathan Druart --- (In reply to Paola Rossi from comment #11) > NB. On patron list, there is a little redundancy in the removing patrons' > options. Yes I agree, but not introduced by this patch. You can open a new bug report if you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 15:45:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 14:45:23 +0000 Subject: [Koha-bugs] [Bug 13168] "Today's checkouts" sort improperly because issuedate lacks seconds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168 Helen Linda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helen.linda at goddard.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 16:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 15:22:05 +0000 Subject: [Koha-bugs] [Bug 13132] Report deletion confirmation doesn't always work with reports tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Version|3.16 |master Summary|Confirm report delete? |Report deletion | |confirmation doesn't always | |work with reports tabs Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 16:27:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 15:27:10 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #53 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 16:27:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 15:27:30 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 16:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 15:27:38 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #54 from sandboxes at biblibre.com --- Created attachment 33201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33201&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: coce.tamil.fr:8080 and this EAN (or ISBN): 3333297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 16:30:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 15:30:56 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #55 from M. Tompsett --- I use ol,gb,aws and even saw all three mixed in the results for "C FR". Still can't get it to work on my personal VMs, because the success event doesn't trigger. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 16:50:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 15:50:49 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:04:35 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com, | |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:05:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:05:02 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:13:12 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #1 from Amit --- Created attachment 33202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33202&action=edit Bug 13144 - Google transliteration does not work on bootstrap There was no id defined for that particular element to identify it. To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. Follow patch: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:13:29 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:17:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:17:36 +0000 Subject: [Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Report deletion |Report deletion |confirmation doesn't always |confirmation doesn't work |work with reports tabs |with DataTables pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:22:44 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #56 from Fr?d?ric Demians --- I'd like to thank you, Mark, for your tenacity. Your remarks, critics and guidance make a difference, and help a lot to get a polished result which comply with Koha standard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:29:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:29:08 +0000 Subject: [Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 --- Comment #3 from Owen Leonard --- Created attachment 33203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33203&action=edit Bug 13132 - Report deletion confirmation doesn't work with DataTables pagination This patch fixes a problem with save report deletion confirmation which appears when the user tries to delete a report found on a DataTables page > 1. This patch alters the trigger to accommodate links which are not initially shown. A small addition has been made to automatically close the menu when the delete link is clicked. To test you must have, at the very least, greater than 10 saved reports. - If necessary change the number of entries shown so that there is a "next" page of results. - Navigate to a subsequent page, click the "Action" menu, and choose "Delete" for one of your saved reports. - A confirmation message should appear. -- Clicking "OK" should complete the deletion. -- Clicking "Cancel" should cancel the deletion. - Confirm that deletion confirmations work from the first page and from other tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:29:06 +0000 Subject: [Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:54:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:54:24 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 --- Comment #1 from Fridolin SOMERS --- Created attachment 33204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33204&action=edit Bug 12838 - Deleting a borrower orphans that borrower's lists Currently if any borrower has a list, and that borrower is deleted, the list is effectively abandoned and unable to be deleted until that list has been associated with an existent user. This patch adds to a superlibrarian the ability to view/edit/delete/manage all lists. Test plan : - Log as not-superlibrarian user - Go to lists module => You can only edit/delete your lists - Log as superlibrarian user - Go to lists module => You can do any action on any list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:54:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:54:38 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 17:54:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 16:54:48 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:00:44 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:00:44 +0000 Subject: [Koha-bugs] [Bug 13196] New: "Always show checkouts immediately" cookie should persist across sessions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Bug ID: 13196 Summary: "Always show checkouts immediately" cookie should persist across sessions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 11703 To me an option which says "Always show checkouts immediately" should really mean "Always," not just "for this session, until I close my browser." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:07:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:07:17 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #8 from Kyle M Hall --- Created attachment 33205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33205&action=edit Bug 13190 [QA Followup] - Fix koha-qa.pl violations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:11:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:11:02 +0000 Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #2 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #1) > I am not sure if it's wrong - it seems like it might be intended behaviour. > The library staff might have a different set of fields to fill out then the > patron. > I am not sure, but i think it earlier versions we didn't check for mandatory > fields at all. Indeed, but in case the preference PatronSelfRegistration is off, one should not have to configure the preference PatronSelfRegistrationBorrowerMandatoryField. For me this preference only applies to the self-registration form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:17:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:17:06 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:17:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:17:08 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #1 from Owen Leonard --- Created attachment 33206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33206&action=edit Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions This patch modifies the way the checkouts script sets the "Always show checkouts" cookie so that it is set with an explicit expiration date (+365 days). This will allow the cookie to persist across browser sesssions. To test, apply the patch and clear your browser cookies to start with a clean slate. - Check out to a patron who has existing checkouts. Their checkouts should not load by default. - Check the "Always show checkouts immediately" checkbox. - Close your browser. - Reopen your browser and check out to that patron again. Checkouts should now be displayed by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:23:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:23:07 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 18:56:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 17:56:50 +0000 Subject: [Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Heather Braum --- This patch fixes a problem with save report deletion confirmation which appears when the user tries to delete a report found on a DataTables page > 1. This patch alters the trigger to accommodate links which are not initially shown. A small addition has been made to automatically close the menu when the delete link is clicked. Test Plan: To test you must have, at the very least, greater than 10 saved reports. - If necessary change the number of entries shown so that there is a "next" page of results. - Navigate to a subsequent page, click the "Action" menu, and choose "Delete" for one of your saved reports. - A confirmation message should appear. -- Clicking "OK" should complete the deletion. -- Clicking "Cancel" should cancel the deletion. - Confirm that deletion confirmations work from the first page and from other tabs. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:01:18 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #9 from Fr?d?ric Demians --- (In reply to Barton Chittenden from comment #8) > Fr?d?ric: did you test dd/mm/yyyy or mm/dd/yyyy? The latter is the one we're > having trouble with. Your reply above suggests that you tested the former, > but I can't tell if you mis-typed your answer or mis-tested. > > No big deal either way, I'm just looking for clarification. Sorry. I've tried all values for dateformat syspref, and it always works on master. I can't understand how it wouldn't work, indeed. You said: 'date_due' is formatted '09/04/2014 23:59' But this is not what I have. I have yyyy/mm/dd hh:mm, and so the code in master seems valid. There is a mystery... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:02:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:02:02 +0000 Subject: [Koha-bugs] [Bug 13168] "Today's checkouts" sort improperly because issuedate lacks seconds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168 Fred P changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fred.pierre at smfpl.org --- Comment #4 from Fred P --- I like it, but shouldn't the order be newest checkout to oldest? That way the circulation staff sees the most recent item at the top of the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:06:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:06:14 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:06:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:06:16 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33169|0 |1 is obsolete| | Attachment #33184|0 |1 is obsolete| | Attachment #33205|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 33207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33207&action=edit [PASSED QA] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:07:16 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33207|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:07:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:07:21 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33169|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:07:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:07:26 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33184|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:07:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:07:31 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33205|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:08:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:08:11 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33169|0 |1 is obsolete| | Attachment #33184|0 |1 is obsolete| | Attachment #33205|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 33208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33208&action=edit [SIGNED-OFF] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:08:18 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #11 from Kyle M Hall --- Created attachment 33209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33209&action=edit [SIGNED-OFF] Bug 13190: Refactor the checkouts table template code This code is duplicated and should be centralised. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:08:20 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #12 from Kyle M Hall --- Created attachment 33210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33210&action=edit [SIGNED-OFF] Bug 13190 [QA Followup] - Fix koha-qa.pl violations Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:09:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:09:53 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #13 from Kyle M Hall --- > > However, the "export checkouts" function doesn't work unless you have > > selected checkouts to export. > > You would like to export all checkouts, that's it? > This behavior is the same as before I think. I can confirm this is the original behavior ( as of 3.16.2 ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:17:19 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:31:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:31:28 +0000 Subject: [Koha-bugs] [Bug 13197] New: Export.pl errors out on command line if --id_list_file is not provided Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Bug ID: 13197 Summary: Export.pl errors out on command line if --id_list_file is not provided Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If one attempts to run export.pl from the command line without the --id_list_file switch, it errors out with the following message: cannot open 0: No such file or directory at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 209. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:31:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:31:42 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:31:45 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:33:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:33:13 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:33:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:33:15 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 --- Comment #1 from Kyle M Hall --- Created attachment 33211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33211&action=edit Bug 13197 - Export.pl errors out on command line if --id_list_file is not provided If one attempts to run export.pl from the command line without the --id_list_file switch, it errors out with the following message: cannot open 0: No such file or directory at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 209. Test Plan: 1) Run tools/export.pl from the command line without the --id_list_file option 2) Note the error 3) Apply this patch 4) Repeat step 1 5) Note the error does not occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:34:16 +0000 Subject: [Koha-bugs] [Bug 13195] Regression: Circulation checkouts table no longer shows item type description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:34:16 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13195 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:35:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:35:52 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33211|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 33212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33212&action=edit Bug 13197 - Export.pl errors out on command line if --id_list_file is not provided If one attempts to run export.pl from the command line without the --id_list_file switch, it errors out with the following message: cannot open 0: No such file or directory at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 209. Test Plan: 1) Run tools/export.pl from the command line without the --id_list_file option 2) Note the error 3) Apply this patch 4) Repeat step 1 5) Note the error does not occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:46:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:46:26 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13198 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:46:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:46:26 +0000 Subject: [Koha-bugs] [Bug 13198] New: Regression: In transit holds no longer show their transfer date in circulation holds list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13198 Bug ID: 13198 Summary: Regression: In transit holds no longer show their transfer date in circulation holds list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 11703 Another regression caused by Bug 11703: Previously when you looked at the list of a patrons holds from the checkouts or patron details page any hold which was in transit would show the date when it was transferred. The transfer date no longer appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:56:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:56:13 +0000 Subject: [Koha-bugs] [Bug 13198] Regression: In transit holds no longer show their transfer date in circulation holds list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13198 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |hbraum at nekls.org Resolution|--- |DUPLICATE --- Comment #1 from Heather Braum --- *** This bug has been marked as a duplicate of bug 13122 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 19:56:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 18:56:13 +0000 Subject: [Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from Heather Braum --- *** Bug 13198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:05:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:05:46 +0000 Subject: [Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:05:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:05:46 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13122 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:16:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:16:18 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:16:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:16:18 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |11703 --- Comment #20 from Katrin Fischer --- What is needed to get this moving again? Kyle, could you take a look at the last 2 comments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:44:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:44:27 +0000 Subject: [Koha-bugs] [Bug 13199] New: Incoherence between 'en' sample notices and translated notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bug ID: 13199 Summary: Incoherence between 'en' sample notices and translated notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: frederic at tamil.fr QA Contact: gmcharlt at gmail.com Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : /installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. For example, for French installation, those notices are missing: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:46:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:46:08 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:48:41 +0000 Subject: [Koha-bugs] [Bug 13168] "Today's checkouts" sort improperly because issuedate lacks seconds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168 --- Comment #5 from Fred P --- Excuse me, I see that is covered in bug #13020. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 20:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 19:57:37 +0000 Subject: [Koha-bugs] [Bug 4224] Holds queue report includes items already allocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4224 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- I can't reproduce this bug in master anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:00:22 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #41 from Katrin Fischer --- This feels like an evil bug stuck in a discussion about architecture - could we have a small and easy fix bringing the old functionality back and figure out the other stuff separately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:00:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:00:33 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:00:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:00:35 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29502|0 |1 is obsolete| | --- Comment #32 from Brendan Gallagher --- Created attachment 33213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33213&action=edit Bug 11413: Change the field number logic This patch series is a bugfix for the Marc modification templates tool. Bug description: If you want to do an action (delete/update/move/...) on a multivalued field and if a condition is defined on the same field, it is highly probable the resulted record will not be what you expect. For example: Deleting All (or the first) fields 650 if 245$a="Bad title" works with the current code. BUT if you want to delete All (or the first) fields 650 with a condition on 650$9=42, and if at least one field matches the condition : - if you have selected all, all fields 650 will be deleted, even the ones who do not match the condition. - if you have selected first, the first 650 field will be deleted, even if it does not match the condition. The expected behavior is to delete the fields matching the condition (and not all the 650 fields). What this patch does: This patch introduces 2 changes in the logic of Koha::SimpleMARC. The first change is a change of the prototypes for the 2 routines field_exists and field_equals. Now they return the "field number" of the matching fields. The second change is the type of the "n" parameter for all routines using it in Koha::SimpleMARC. Before this patch, the "n" parameter was a boolean in most cases. If 0, the action was done on all fields, if 1 on the first one only. Now it is possible to specify the "field numbers" (so the array of field numbers which is returned by field_exists or field_equals) for all routines which had the n parameter. Test plan for the patch series: Note: This test plan describes a specific example, feel free to create your own one. 0/ Define a marc modification template with the following action: Delete field 245 if 245$9 = 42 1/ choose and export a record with several 245 fields. For ex: 245 $a The art of computer programming $c Donald E. Knuth. $9 41 245 $a Bad title $c Bad author $9 42 2/ import it using the Stage MARC for import tool. 3/ verify the imported record does not contain any 245 field. 4/ apply all the patches from this bug report 5/ do again steps 2 and 3 6/ verify the imported record contains only one 245 field, the one with 245$9=41 7/ verify the unit tests passed: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:00:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:00:47 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29503|0 |1 is obsolete| | --- Comment #33 from Brendan Gallagher --- Created attachment 33214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33214&action=edit Bug 11413: UT to show up the issue These UT reflect this change: - deletion of the field 245 if 245$a='Bad title' - move of the 650 field to 651 if 650$9=499 Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:00:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:00:58 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29504|0 |1 is obsolete| | --- Comment #34 from Brendan Gallagher --- Created attachment 33215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33215&action=edit Bug 11413: Reflect the changes to the interface Test plan: - add/edit an action on the marc modification templates tools - choose an action and define a condition - define the source field as same as the condition field - verify the All/1st dropdown list is changed to Every/1st Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:21:37 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #1 from Fr?d?ric Demians --- Created attachment 33216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33216&action=edit Bug 13199 Add missing notices for fr-FR installation prove xt/sample_notices.sql identifies five missing notices for fr-FR. This patch add those missing notices: ISSUEQSLIP ISSUESLIP OPAC_REG_VERIFY RESERVESLIP TRANSFERSLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:21:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:21:35 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:22:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:22:12 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #2 from Fr?d?ric Demians --- Created attachment 33217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33217&action=edit Bug 13199 Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : /installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 4 21:25:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 20:25:01 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #3 from Fr?d?ric Demians --- The test identifies other missing notices: - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 00:51:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Nov 2014 23:51:30 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #19 from David Cook --- (In reply to Robin Sheat from comment #18) > I've added a dump of the current state of patches. It's in the process of > being split up and having unit tests written, in particular of the > underlying modules, i.e. the things that will be needed but aren't central > to ES itself. > > The last functional change was the ability for authorities to be indexed > too. Currently, they can't be searched, but they are there. The next > functional change (clearly) is to make them be searchable. I'm expecting > that 90% of this will leverage the existing query builder type stuff. > > I'm hoping that someone can have a go setting this up on their own > installation and trying it out, to see if there are any particular points > that need explained. > > dcook, I'll be seeing you at the conference tomorrow, I suggest you have a > laptop with a VM ready to go on it ;) Alas, I'll have to try it out another time. Working on some OAI stuff at the moment, but will have to look at this sometime soon! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 07:35:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 06:35:16 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 07:42:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 06:42:17 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 07:42:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 06:42:20 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33212|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 33218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33218&action=edit Bug 13197 - Export.pl errors out on command line if --id_list_file is not provided If one attempts to run export.pl from the command line without the --id_list_file switch, it errors out with the following message: cannot open 0: No such file or directory at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 209. Test Plan: 1) Run tools/export.pl from the command line without the --id_list_file option 2) Note the error 3) Apply this patch 4) Repeat step 1 5) Note the error does not occur Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:01:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:01:01 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33206|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 33219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33219&action=edit Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions This patch modifies the way the checkouts script sets the "Always show checkouts" cookie so that it is set with an explicit expiration date (+365 days). This will allow the cookie to persist across browser sesssions. To test, apply the patch and clear your browser cookies to start with a clean slate. - Check out to a patron who has existing checkouts. Their checkouts should not load by default. - Check the "Always show checkouts immediately" checkbox. - Close your browser. - Reopen your browser and check out to that patron again. Checkouts should now be displayed by default. Signed-off-by: Frederic Demians Works as described. I confirm that without this patch, the un-persistance of "show checkouts" choice is very perturbing for librarians coming from previous version of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:01:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:01:37 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:15:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:15:19 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:15:21 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #2 from Fr?d?ric Demians --- Created attachment 33220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33220&action=edit Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 Signed-off-by: Frederic Demians I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:17:19 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:19:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:19:36 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:19:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:19:38 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33195|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 33221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33221&action=edit [SIGNED OFF] Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD The example usage for C4::Members::Messaging::SetMessagingPreferencesFromDefaults calls the subroutine SetMessagingPreferenceFromDefaults, not SetMessagingPreferencesFromDefaults (missing the 's' at the end of 'Preferences'). To test: - Apply the patch - Check that the POD now refers to the actual name of the subroutine (perldoc C4::Members::Messaging) http://bugs.koha-community.org/show_bug.cgi?id=13194 Adding 's' is the correct doc change to make it match with the function definition. Comfirmable with less. perldoc C4::Members::Messaging proves the doc is still nice. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:22:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:22:15 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #42 from Chris Cormack --- Created attachment 33222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33222&action=edit Bug 12892 : Alternate fix to restore the deleted code This doesn't depend on anything other patch. 1. Create a reservation for a Borrower with pickup branch 2. Check-in the corresponding Item in the pickup branch and confirm the hold for the Borrower 3. Go to circ/circulation.pl for the Borrower and verify that the reservation is "Waiting for pickup" 4. In the Borrower -> Check Out -tab (circ/circulation.pl) on the right of the big "Checking out to borrowername" should be a notification about holds ready for pickup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:23:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:23:20 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff CC| |chris at bigballofwax.co.nz --- Comment #43 from Chris Cormack --- I have attached an alternate patch, which restores the code that was deleted when the ajax checkouts were added. This is not dependent on other patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:23:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:23:59 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Fr?d?ric Demians --- Katrin: I've added you to this patch CC! You're in best position to confirm this bug may be disturbing/blocking for non-English installations, since you're the only one to succeed having a de-DE on a par with 'en' sample notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:32:25 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- I can't apply your patches, and get this Git error: fatal: sha1 information is lacking or useless (acqui/add_user_search.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 08:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 07:34:27 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- I don't mind this patch myself. But sorry, you modify three functions: AddReserve, GetReserveFee, and _Findgroupreserve. There are only tests for AddReserve in our current test suite. You need to improve test coverage if you want your tweaks in GetReserveFee and _Findgroupreserve to pass QA properly, in my understanding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:01:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:01:07 +0000 Subject: [Koha-bugs] [Bug 13200] New: Followup of Bug 12246 - noisy C4/Auth.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Bug ID: 13200 Summary: Followup of Bug 12246 - noisy C4/Auth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com OpacMainUserBlockMobile is still pushed as a parameter in C4::Auth. This generates a noisy warning. This patch will remove the parameter in question. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:14:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:14:19 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 --- Comment #1 from M. Tompsett --- Created attachment 33223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33223&action=edit Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:15:09 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13200 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:15:09 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12246 Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:31:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:31:51 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 --- Comment #2 from Martin Renvoize --- Created attachment 33224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33224&action=edit [SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:32:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:32:38 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33223|0 |1 is obsolete| | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:32:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:32:56 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Super Simple Patch.. works as expected :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:38:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:38:03 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:38:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:38:06 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33222|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 33225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33225&action=edit [SIGNED OFF] Bug 12892 : Alternate fix to restore the deleted code This doesn't depend on anything other patch. 1. Create a reservation for a Borrower with pickup branch 2. Check-in the corresponding Item in the pickup branch and confirm the hold for the Borrower 3. Go to circ/circulation.pl for the Borrower and verify that the reservation is "Waiting for pickup" 4. In the Borrower -> Check Out -tab (circ/circulation.pl) on the right of the big "Checking out to borrowername" should be a notification about holds ready for pickup. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:43:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:43:22 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #45 from Martin Renvoize --- Thanks for stepping into the breach Chris... alternate patch works as expected for me.. signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:05 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29216|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart --- Created attachment 33226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33226&action=edit Bug 11023: Toggle "new" status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Toggle new status - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:09 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29217|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart --- Created attachment 33227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33227&action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:13 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29218|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart --- Created attachment 33228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33228&action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:17 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29219|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart --- Created attachment 33229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33229&action=edit Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:21 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29220|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart --- Created attachment 33230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33230&action=edit Bug 11023: Use DBIx-Class to retrieve column names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:24 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29221|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart --- Created attachment 33231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33231&action=edit Bug 11023: Don't use the biblioitems fields for the subtitution It's dangerous to allow a change on the biblioitems fields with this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:28 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29222|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart --- Created attachment 33232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33232&action=edit Bug 11023: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:32 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31820|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart --- Created attachment 33233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33233&action=edit Bug 11023: Rename the duration parameter with 'age' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:36 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31821|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart --- Created attachment 33234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33234&action=edit Bug 11023: The age parameter should be a number The template should check if the age parameter is correctly filled (should be a number). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:45:40 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31822|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart --- Created attachment 33235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33235&action=edit Bug 11023: Change the name of the feature Originaly this feature only permits to update the "new" field. Now all item fields can be updated. The name of the feature is now "Automatic item modifications by age". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:46:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:46:11 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:49:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:49:15 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 09:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 08:59:28 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33225|0 |1 is obsolete| | --- Comment #46 from Rafal Kopaczka --- Created attachment 33236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33236&action=edit Bug 12892 : Alternate fix to restore the deleted code This doesn't depend on anything other patch. 1. Create a reservation for a Borrower with pickup branch 2. Check-in the corresponding Item in the pickup branch and confirm the hold for the Borrower 3. Go to circ/circulation.pl for the Borrower and verify that the reservation is "Waiting for pickup" 4. In the Borrower -> Check Out -tab (circ/circulation.pl) on the right of the big "Checking out to borrowername" should be a notification about holds ready for pickup. Signed-off-by: Martin Renvoize Signed-off-by: Rafal Kopaczka -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:01:23 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkopaczka at afm.edu.pl --- Comment #47 from Rafal Kopaczka --- This patch also fix bug 12971, and maybe some other bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:02:53 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12971 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:02:53 +0000 Subject: [Koha-bugs] [Bug 12971] Printing member information lacks data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:09:22 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #48 from Rafal Kopaczka --- (In reply to Rafal Kopaczka from comment #47) > This patch also fix bug 12971, and maybe some other bugs. Nope, sorry this does not fix that issue. But, still this is good patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:10:31 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 --- Comment #8 from Gaetan Boisson --- Created attachment 33237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33237&action=edit [SIGNED-OFF] Bug 12743: ACQ: default values for catalogue records At the moment, it is possible to create records in acquisitions, but the ACQ framework is only used for items created in this module. This patch allows to defined default values in the ACQ framework for records created on the acquisition module. Test plan: 1/ Make sure you have the ACQ framework created (otherwise create it from the default framework). 2/ Define a default value for a field (for instance 099$z=1). 3/ Go in the acquisition module and create a new order from a new record. 4/ Fill mandatory information and save. 5/ Go on the detail page of this record and verify the default value exist. Signed-off-by: Gaetan Boisson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:14:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:14:18 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Gaetan Boisson --- Tested the three cases: - default value in a field/subfield that will not be created by the form in acquisitions (creation of a new field with the default value in the subfield) - default value in a subfield for a field that will be created by the form, but whose subfield won't (creation of the subfield with the default value in the already existing field) - default value in a subfield for which the form will create a value (nothing happens) >From what i understand, the from works depending on koha/marc mappings, so the title field for the form will create a value in whatever is mapped to biblio.title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:33:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:33:52 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #15 from Jonathan Druart --- Created attachment 33238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33238&action=edit Bug 12630 - Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! ------------------------- -- REPLICATE LIKE THIS -- ------------------------- 0. Enable AllowHoldDateInFuture-system preference! 1. Select a biblio with some holds. 2. Place a hold with the "Hold starts on date"-attribute set to future. 3. More the specific hold up on the priority queue. 4. Add another normal hold, observe how it is prioritized with the "Hold starts on date"-hold, leaving old holds to the prioritization queue tail. Unfair eh? Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:33:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:33:55 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31141|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 33239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33239&action=edit Bug 12630 [QA Followup] - Rename _ShiftPriorityByDateAndPriority to _ShiftPriority Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:33:58 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #17 from Jonathan Druart --- Created attachment 33240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33240&action=edit Bug 12630: Add regression tests Verify that the 2 tests failed before applying this patch and return green after. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:34:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:34:29 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart --- The patch look good, I added 2 regression tests. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:34:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:34:46 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:35:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:35:04 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:48:38 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #19 from Jonathan Druart --- Actually I am not sure, the POD says "This is most useful when the reservedate can be set by the user. It allows the new reserve to be placed before other reserves that have a later reservedate". So it is the expected behavior. We want to change it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 10:57:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 09:57:44 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #9 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #8) > I can't apply your patches, and get this Git error: > > fatal: sha1 information is lacking or useless (acqui/add_user_search.pl). This patch depends on bug 12648, try to apply it before this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 11:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 10:03:57 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #5 from Jonathan Druart --- I am not sure to understand what I could test here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 11:19:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 10:19:07 +0000 Subject: [Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31945|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 33241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33241&action=edit Bug 13007: Add a foreign key for suggestions.budgetid The DB field suggestions.budgetid should be linked to aqbudgets.budget_id. If the fund is removed, this column should be set to NULL. Test plan: 1/ Using your SQL CLI (or equivalent), create or update 1+ suggestions and set "0" in the budgetid field (or a nonexistent budget id). 2/ Execute the updatedabase script. 3/ Verify that your suggestion is unlinked to the nonexistent fund. 4/ Verify the constraint has correctly been added (show create table suggestions). 5/ Check that this change does not affect the behavior on adding a suggestion (linked to a fund or not). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 11:50:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 10:50:33 +0000 Subject: [Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33241|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 33242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33242&action=edit Bug 13007: Add a foreign key for suggestions.budgetid The DB field suggestions.budgetid should be linked to aqbudgets.budget_id. If the fund is removed, this column should be set to NULL. Test plan: 1/ Using your SQL CLI (or equivalent), create or update 1+ suggestions and set "0" in the budgetid field (or a nonexistent budget id). 2/ Execute the updatedabase script. 3/ Verify that your suggestion is unlinked to the nonexistent fund. 4/ Verify the constraint has correctly been added (show create table suggestions). 5/ Check that this change does not affect the behavior on adding a suggestion (linked to a fund or not). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 11:51:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 10:51:39 +0000 Subject: [Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Jonathan Druart --- (In reply to Paola Rossi from comment #4) > About the first step: > 0/ Verify it is not possible to create a suggestion not linked to a fund via > the Koha interface. > > in intranet, "any" is an option in the dropdown list on "Acquisition > information" for selecting a fund to link to the suggestion. So IMO it's > still easy to create suggestions not linked to a fund. > > So I pass the patch to "Failed QA" STATUS. I don't remember why I wrote that... If you don't choose a fund, the value in DB will be NULL. Which is acceptable and normal. I updated the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 11:51:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 10:51:53 +0000 Subject: [Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 11:53:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 10:53:49 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #91 from Paola Rossi --- [I beg you pardon for the length of this comment, my delay in answering and possible inaccuracies.] I've applied the patch against master 3.17.00.044 [HEAD 10860]. To test the patch IMHO on ADMIN it is better: - (as required by the test plan) kept the value of syspref "ReservesMaxPickupDelay" > 0 - set the syspref "EnhancedMessagingPreferences" to ON (default is OFF) To test the patch IMHO on ADMIN it could be better: - kept the default value "Don't allow" to the syspref "AllowOnShelfHolds" - set the "Charge" of the item-types to 0.00 (default 5.00) for all types - [remember to set the circulation rules] - set the syspref "KohaAdminEmailAddress" to a value not filtered by antispam's own emailing-system [to receive notices' email] - [remeber to refresh the cache [Ctrl r - Ctrl F5] after seeing master's behaviour]. At my tests, the RESERVESLIP and HOLD notices are allowed to be cloned to your specific library, but I saw that koha uses only the "ALL LIBRARIES" notices, and never the cloned ones. So I changed those 2 notices to test the 2 parts of the test plan about LETTER. To test the part of the test plan about the RESERVESLIP notice, i.e. see below: *** TEST: LETTER PLACEHOLDER ***, IMHO the functions to test are "Confirm"/"Print and confirm", on cheching in a record already on hold by another patron. To test the last part of the test plan about the HOLD notice, i.e. see below: *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION ****, if I'm not wrong : - set the notice's email [i.e. "Primary email"] of the test patron to your own email - if this patron had a found/status W hold, you'll receive a mail soon after: perl ./misc/cronjobs/advance_notices.pl -c perl ./misc/cronjobs/process_message_queue.pl IMHO it would be better explicitly adding a further last part to the test plan about the provided: t/db_dependent/Holds.t [perhaps other parts of the preamble could need a testing action too.] At my tests the upgrade of the DB is OK. The 4 *.tt are OK. NB1.: on ADMIN, in the "Circ and fines issuing rules", perhaps the new column "Holds wait for pickup (day)" could be better set at the right of "Holds allowed (count)", at the right of all the 4 columns about renewal, and not among these 4 ones. NB2.: on CIRC, on waitingreserves.pl (="Holds awaiting pickup"), on the "Holds over" tag, the present string: "Holds listed here have been awaiting pickup for more than days." could be modified. In master it was: "Holds listed here have been awaiting pickup for more than X days." where X was the value of the syspref "ReservesMaxPickUpDelay" which has been removed by this patch. NB3.: On opac-user.pl, for a logged in user with W holds, the W holds had not neigher the "Cancel" icon nor the "Suspend" icon. [I didn't check the master about this behaviour, sorry. If this patch had changed the behaviour, this regression would be on error, and this point will be added to the errors' list.] PROBLEMS: NB4.: [MASTER] at my tests the "W" found/status of a hold/reserve is set in only 1 case: it is set to a hold, that previously had been opened on a biblio record which was already checked out (found=NULL), and then checked in (found=W) without "Ignore" submit. [I'd like to have a feedback about it, please, because all my tests were about this assumption.] NB5.: [MASTER] So, at my tests, the waitingdate of a hold/reserve can be only the current date, i.e. the current day on which I check-in a biblio record. [I'd like to have a feedback about it, please, because all my tests were about this assumption.] 1) I saw no reserves.lastpickupdate nor the reserves.waitingdate on RESERVESLIP notice. But I think that this problem is out of this bug, because the master too behaves so. [On the contrary, on master (and after applying too) the reserves.reservesnotes is correctly shown by the notice.] 2) Whilst a check out lasts 1 more day for an intervening holiday, the hold's period doesn't: I'd like to have a feedback about this, please. If the W hold would last 1 more day, the patch would be in error. 3) On upgrading the DB, by syspref "ReservesMaxPickupDelay" > 0, all the holds for all the patrons' categories and item types would receive the same lasting period. Whilst the patch, once applied, could assign a different value to each of them. I think this remarkable to get coherent DB datas. 4) The found/status "W" meaning is about the lasting period available to the patron to pick up the document. But when a "Transfer" is needed from the check-out' library, to the hold's library, koha [master] doesn't set the found/status to "W", but to NULL/T: I think that this behaviour could be evaluated, that it can be a master's bug, and, if this is the case, that this patch could be tested after having resolved this bug on a DB with such cases. 5) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/46 # Failed test 'GetLastPickupDate(): Not using Calendar' # at t/db_dependent/Holds.t line 436. # got: '2014-11-10' # expected: '2014-11-05' # Failed test 'GetLastPickupDate(): Moving lastpickupdate over holidays, but not affected by them' # at t/db_dependent/Holds.t line 448. # got: '2014-11-10' # expected: '2014-11-05' # Failed test 'MoveWaitingdate(): Moving to past' # at t/db_dependent/Holds.t line 401. # got: '' # expected: '1' # Failed test 'Waiting reserve with lastpickupdate for 2014-11-04 totally canceled' # at t/db_dependent/Holds.t line 367. # got: '1' # expected: '0' # Looks like you failed 4 tests of 46. t/db_dependent/Holds.t .. Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/46 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 1024 Tests: 46 Failed: 4) Failed tests: 37, 39, 41, 44 Non-zero exit status: 4 Files=1, Tests=46, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.91 cusr 0.29 csys = 1.22 CPU) Result: FAIL For the 5-th problem I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:17:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:17:17 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:35:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:35:06 +0000 Subject: [Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:35:31 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #30 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:36:27 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #64 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:41:09 +0000 Subject: [Koha-bugs] [Bug 13201] New: GetSuggestion takes suggestionid Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Bug ID: 13201 Summary: GetSuggestion takes suggestionid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The pod and the variable names are wrong! This could be dangerous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:42:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:42:47 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 --- Comment #1 from Jonathan Druart --- Created attachment 33243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33243&action=edit Bug 13201: GetSuggestion takes suggestionid Test plan: Verify the tests for suggestions still passed and that the changes are consistent (just looking at the code). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 12:43:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 11:43:07 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:06:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:06:34 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31953|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 33244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33244&action=edit Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or 0000-00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:07:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:07:33 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Jonathan Druart --- (In reply to Katrin Fischer from comment #22) > Sadly, I found a bug: Fortunately, you found it! :) It should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:13:08 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #35 from M. de Rooy --- This passed qa now, but is there any evidence that the problem reported does not occur anymore with adding the patches of 11395 on top? What did you test, Brendan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:19:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:19:53 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #20 from Kyle M Hall --- khall: hmm, that's an interesting point Joubu. imo this is at best an undocumented feature ( not documented in the manual afaik ) at best, but I and I'm sure many would consider it a bug In actuality khall: If this patch doesn't get pushed, then we *must* at the very least syspref the behavior. Joubu: my feeling is that the date should be take into account, otherwise the further holds could be blocked by the one "in the future" khall: that is true. There was a bug where a patron could cheat his way to the front of the line by setting a starts on date way in the past, but I closed up that bug by disabling the calendar selector for past dates khall: however, one could still cheat the system if they know what they are doing khall: this bug closes that loophole permanently khall: I suppose we could also have the script round up any hold starts on date in the past to the current date as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:29:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:29:36 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #66 from M. de Rooy --- (In reply to Liz Rea from comment #63) > Comment 57, 2nd paragraph - when someone doing QA suggests mailing a > cleartext password might be ok, it seems right to emphatically tell them > "no, that's a bad idea." Please keep it in context. Hope I do not intercept any undertone about QA work here? For completeness: I completely agree that sending password by mail is theoretically very bad. However, we probably do not have a 100% safe solution for this. So therefore in a pragmatic view the sensitivity argument etc. And to add: As long as many OPACs are going over HTTP, we send the password clear text all over the place.. But again, also comment 57 This approach is fine with me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:29:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:29:33 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #21 from Kyle M Hall --- khall: as far as I can tell C4::Reserves::CheckReserves does *not* take the reservedate into account. I think with a followup that does, this patch would be acceptable. Do you agree? khall: That way one future hold doesn't hold back other reserves, and it still prevents cheating the system Joubu: sounds good khall: I'll file a new bug report and make it a blocker for this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:34:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:34:20 +0000 Subject: [Koha-bugs] [Bug 13102] Follow-up for 13096: Replace kohaadmin@yoursite.org with KohaAdminEmailAddress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13102 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:35:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:35:40 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:35:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:35:42 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:35:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:35:43 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:35:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:35:45 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:35:46 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:35:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:35:48 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:37:56 +0000 Subject: [Koha-bugs] [Bug 13096] Send account notice with login details in more situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #14 from M. de Rooy --- There will be not much support for extending the AutoEmailOpacUser functionality. See report 8753. I will not put more effort into this line of development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:37:56 +0000 Subject: [Koha-bugs] [Bug 13102] Follow-up for 13096: Replace kohaadmin@yoursite.org with KohaAdminEmailAddress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13102 Bug 13102 depends on bug 13096, which changed state. Bug 13096 Summary: Send account notice with login details in more situations http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:40:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:40:42 +0000 Subject: [Koha-bugs] [Bug 13202] New: Holds with a future date should be skipped over until that date is current Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13202 Bug ID: 13202 Summary: Holds with a future date should be skipped over until that date is current Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 12630 would remove the ability to insert a new hold into the middle of the holds list based on the future hold date. This is good, as the current behavior allows for "cheating" the holds system to get his or her hold pushed higher up the list of holds. A better solution would be for the holds system to skip over any holds where the hold date is in the future. With this behavior, bug 12630 could be pushed, but not allow one future hold in priority 1 to keep any holds after it from being filled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:40:55 +0000 Subject: [Koha-bugs] [Bug 13202] Holds with a future date should be skipped over until that date is current In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13202 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12630 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:40:55 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13202 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:42:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:42:02 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:43:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:43:21 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from M. de Rooy --- Fridolin: We had discussions about superlibrarians viewing all lists in the past; the outcome generally was: don't do it for reasons of privacy. Also note that in current master there should not be any orphaned lists anymore. Look at the code of VirtualShelves::DelBorrower. It is called when you delete a patron and it now deletes all lists of that patron. Bug 11889 was opened for a discussion about not deleting all lists. Liz: Could you confirm that this is no longer a problem in current master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 13:46:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 12:46:16 +0000 Subject: [Koha-bugs] [Bug 13202] Holds with a future date should be skipped over until that date is current In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13202 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:00:45 +0000 Subject: [Koha-bugs] [Bug 13203] New: Plugin housekeeping: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Bug ID: 13203 Summary: Plugin housekeeping: Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:00:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:00:55 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:13:34 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #5 from Kyle M Hall --- I think the biggest issue with this approach is it's tied to using Apache, right? This solution should work with apache, nginx, or whatever crazy way someone may have Koha up and running. Am I correct? (In reply to Martin Renvoize from comment #4) > I've been thinking about this problem for a few yers now.. though never > gotten around to doing much about it. > > I did at some point start using mod_pagespeed (by google) on a number of our > server, but this unfortunately led to other problems which I could not > narrow down to anything but this apache module. > > However, the real piece I wanted was this caching advantage enabled using > the following filter: > > https://developers.google.com/speed/pagespeed/module/filter-cache-extend > > I'm wondering if we could do somthing similar, either in the Apache config > itself, or in perl pre apache. > > My thought's were to append a version string within the templates (similar > to Kyle's approach but within the filename as opposed to a query string) and > then add some re-write rules in apache to remove the appended string again. > (I got stuck at the apache re-write rules level.. I've never been especially > good at them) I did wonder whether we should be appending a hash of the file > content as opposed to a versions for our version string.. to enable the > detection of customised changes, but this would obviously add to server load > too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:14:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:14:18 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:20:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:20:48 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:32:22 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Owen Leonard --- I set this bug to "In Discussion" when I submitted comment 3, so I would like to keep it "In Discussion" until that point is discussed. I think this is a worthwhile issue to pursue but I would like to hear more comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:35:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:35:29 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plugin housekeeping: |Plugin housekeeping: | |UNIMARC field 123i, 123j, | |210c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:36:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:36:52 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:36:55 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #1 from M. de Rooy --- Created attachment 33245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33245&action=edit Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 14:40:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 13:40:39 +0000 Subject: [Koha-bugs] [Bug 13204] New: Plugin housekeeping: continued Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Bug ID: 13204 Summary: Plugin housekeeping: continued Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:39:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:39:17 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: continued In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #1 from M. de Rooy --- Created attachment 33246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33246&action=edit Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin As it seems, this plugin has been created for UNIMARC field 328 (Dissertation note). It refers to authval category LABTHE. The plugin seems however not to be used: it contains several critical errors. I tried a quick fix but it was not good enough. Since the code can be recovered from git (if needed), a real fix can always follow this patch. What are some problems: [1] The path to the template is wrong. Should be cataloguing/value_builder [2] The plugin parameter $input is not used. A new CGI object is created. [3] Resolving errors 1 and 2 still results in premature end of script headers. [4] Not sure whether the plugin can effectively handle missing LABTHE values. Instead of keeping this in Koha, I opt for removing it for now. As additional argument I would mention that labs_theses does not have Focus or Blur actions, only the Click action that does not work. Test plan: Git grep on labs_theses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:40:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:40:04 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Summary|Plugin housekeeping: |Plugin housekeeping: Remove |continued |labs_theses.pl plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:41:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:41:02 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #2 from M. de Rooy --- Instead of a signoff, a counterpatch is welcome too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:44:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:44:02 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- (In reply to M. de Rooy from comment #1) > Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 > characters long and contain the same components as subfields $f and $g > except that character position 0 contains a plus sign (for the northern > celestial hemisphere) or a minus sign (for the southern celestial > hemisphere). I am not sure about that. >From http://multimedia.bnf.fr/unimarcb_trad/B123-6-2010.pdf, $ij are declinaison and $fg are coordinate. Moreover the default value should be '00' not '', isn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:50:20 +0000 Subject: [Koha-bugs] [Bug 13205] New: Last/First page options for result list paging Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Bug ID: 13205 Summary: Last/First page options for result list paging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if the page navigation for the OPAC and staff result lists allowed to jump to the last/first page of the results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:53:14 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31952|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 33247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33247&action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions > TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:54:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:54:14 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #6 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #4) > - A patch add a new TO_PROCESS notice to en/mandatory/sample_notices.sql. Why > no notice for other languages? "Others will be added when the patch will be signed off." I will do :) > - notice_unprocessed_suggestion.pl script has no execution permisions like > other scripts in misc/cronjobs Done. > - The script help should say that the script uses a notice named TO_PROCESS > Done. > - It would be a plus, if running the script without -c were sending the > result > to STDOUT. Done. > - Patron name & surname are in TO_PROCESS notice, but are not displayed. It > appears that, calling EnqueueLetter, your script doesn't provide borrowers > table info. You should have: > > tables => { > suggestions => $suggestion->{suggestionid}, > branches => $patron->{branchcode}, > borrowers => $patron->{borrowernumber}, > }, Done. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:56:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:56:41 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #3 from M. de Rooy --- (In reply to Jonathan Druart from comment #2) > (In reply to M. de Rooy from comment #1) > > Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 > > characters long and contain the same components as subfields $f and $g > > except that character position 0 contains a plus sign (for the northern > > celestial hemisphere) or a minus sign (for the southern celestial > > hemisphere). > > I am not sure about that. > From http://multimedia.bnf.fr/unimarcb_trad/B123-6-2010.pdf, $ij are > declinaison and $fg are coordinate. > Moreover the default value should be '00' not '', isn't it? My information came from ifla. You are correct that fg is coordinate and ij is declination. I do not understand the 00 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:57:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:57:52 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #4 from M. de Rooy --- http://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_123_update.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 15:59:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 14:59:07 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC: Display an |OPAC: Display an |acquisition details tab |acquisition details --- Comment #47 from Jonathan Druart --- (In reply to Nicole C. Engard from comment #46) > I am writing this up for the manual but can't seem to make it work. I have > the preference set to 'display' but on the titles that have items on order I > do no see the acquisitions tab. Will it only work for items ordered after > you turn the preference on? Does it depend on another preference? Hi Nicole, Sorry for the delay! Actually in the pushed version, there is no tab! You must have AcqCreateItem != "ordering" to see the information "X items are on order". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:10:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:10:32 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #34 from Jonathan Druart --- Created attachment 33248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33248&action=edit Bug 8218: qa followup This patch - rename _entity_clean as _clean_ampersand - rename the script to sanitize_records.pl - add a --fix-ampersand switch (the only one FOR NOW, enabled by default) so it is obvious what the script does. - make POD and usage reflect this changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:10:54 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #35 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #33) > I'm willing to push the feature, because I like it, and it doesn't break > people's funcionality, and hence marked as rel_3_18_candidate. This means > you are not catch by feature freeze. > > Can you please work a bit on the fact that the feature is about ampersands > only? > I propose > > - keeping the SanitizeRecord name general. > - renaming _entity_clean as _clean_ampersand > - renaming the script to sanitize_records.pl > - add a --fix-ampersand switch (the only one FOR NOW, enabled by default) so > it is obvious what the script does. > - make POD and usage reflect this changes. > > I mark it FAILED-QA until the authors answer this proposal. I agree, all done in the last patch, back to passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:13:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:13:41 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 --- Comment #9 from Jonathan Druart --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:15:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:15:44 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 --- Comment #2 from Jonathan Druart --- Comment on attachment 33078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33078 Bug 13180 - While acquiring from the new improved staged file, warning "Indicator in 952 is empty at /home/koha/kohaclone/C4/Biblio.pm" is flooding the bejesus out of my koha-error.log Review of attachment 33078: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13180&attachment=33078) ----------------------------------------------------------------- ::: acqui/addorderiso2709.pl @@ +272,2 @@ > my @ind_tag = $input->param('ind_tag'); > my @indicator = $input->param('indicator'); Hum? This line already exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:16:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:16:18 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- + my @indicator = $input->param('indicator'); #Passing the imaginary empty " " -indicators from the templates, to stop C4::Biblio::TransformHtmlToXml() to warn the bejesus out of my koha-error.log my @ind_tag = $input->param('ind_tag'); my @indicator = $input->param('indicator'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:16:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:16:56 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart --- Could you please update the patch with a decent commit message? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:20:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:20:46 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #5 from Jonathan Druart --- (In reply to M. de Rooy from comment #3) > I do not understand the 00 ? If I don't fill the inputs, the value should be 00, not an empty string. Otherwise the field could be filled with a string's length < 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:21:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:21:07 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 --- Comment #3 from Fridolin SOMERS --- (In reply to M. de Rooy from comment #2) > Fridolin: We had discussions about superlibrarians viewing all lists in the > past; the outcome generally was: don't do it for reasons of privacy. privacy for a superlibarian ? those users can see full patron details, circulation history, even change its password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:30:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:30:07 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:30:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:30:09 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33224|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 33249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33249&action=edit Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:31:39 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33221|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 33250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33250&action=edit Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD The example usage for C4::Members::Messaging::SetMessagingPreferencesFromDefaults calls the subroutine SetMessagingPreferenceFromDefaults, not SetMessagingPreferencesFromDefaults (missing the 's' at the end of 'Preferences'). To test: - Apply the patch - Check that the POD now refers to the actual name of the subroutine (perldoc C4::Members::Messaging) Adding 's' is the correct doc change to make it match with the function definition. Comfirmable with less. perldoc C4::Members::Messaging proves the doc is still nice. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:31:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:31:37 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 16:52:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 15:52:57 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 --- Comment #4 from M. de Rooy --- (In reply to Fridolin SOMERS from comment #3) > (In reply to M. de Rooy from comment #2) > > Fridolin: We had discussions about superlibrarians viewing all lists in the > > past; the outcome generally was: don't do it for reasons of privacy. > > privacy for a superlibarian ? > those users can see full patron details, circulation history, even change > its password. I will try to find it on Bugzilla.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:07:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:07:53 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32827|0 |1 is obsolete| | Attachment #32828|0 |1 is obsolete| | Attachment #32829|0 |1 is obsolete| | Attachment #32830|0 |1 is obsolete| | Attachment #32831|0 |1 is obsolete| | Attachment #32832|0 |1 is obsolete| | Attachment #32833|0 |1 is obsolete| | Attachment #32834|0 |1 is obsolete| | Attachment #32835|0 |1 is obsolete| | Attachment #32836|0 |1 is obsolete| | Attachment #32837|0 |1 is obsolete| | Attachment #32838|0 |1 is obsolete| | --- Comment #559 from Kyle M Hall --- Created attachment 33251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33251&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:08:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #560 from Kyle M Hall --- Created attachment 33252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33252&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:08:18 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #561 from Kyle M Hall --- Created attachment 33253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33253&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:08:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:08:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #562 from Kyle M Hall --- Created attachment 33254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33254&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:08:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #563 from Kyle M Hall --- Created attachment 33255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33255&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:08:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:08:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #564 from Kyle M Hall --- Created attachment 33256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33256&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:08:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:08:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #565 from Kyle M Hall --- Created attachment 33257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33257&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:09:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:09:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #566 from Kyle M Hall --- Created attachment 33258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33258&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:09:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #567 from Kyle M Hall --- Created attachment 33259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33259&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:09:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:09:16 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #568 from Kyle M Hall --- Created attachment 33260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33260&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:09:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #569 from Kyle M Hall --- Created attachment 33261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33261&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:09:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:09:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #570 from Kyle M Hall --- Created attachment 33262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33262&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:12:14 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #20 from Jonathan Druart --- Created attachment 33263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33263&action=edit Bug 12404: Allow equal sign '=' in the TT directive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:12:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:12:58 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #21 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #19) > (In reply to Jonathan Druart from comment #18) > > > I accept, of course, all kinds of followup to improve this enhancement :) > > I don't say no :-) I've even tried. > > But I'me encountering now an issue with the mix in the code between previous > syntax and TT syntax. I can't have a TT directive containing a = sign. The last patch should allow you to do what you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:34:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:34:50 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #12 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #11) > Dear Johnatyhan and Katrin, Simply Jonathan :) > In comment 2 Paola Rossi found that ACQCLAIM and ACQCLAIM-ISSUE extrat all > data that we need without '' and '', also for multiple > situations I am really not sure about that. How to know when the repeatable element is ended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:37:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:37:53 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:37:56 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31276|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 33264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33264&action=edit Bug 12851: order tags should be removed from the claiming letter If you use a claimissue notice to claim serials, the generated letter will be Title1, Author1 Title2, Author2 ... TitleN, AuthorN This patch geds rid of these tags. Test plan: 1/ Create a claimissue notice with something like: <> <> The following issues are in late: <>, <> (<>) 2/ Generated late serial issues. 3/ Send notifications to vendor. 4/ The order tags should not exist anymore in the sent email. You can see bug 5342 for a more detailled test plan. Note that the order tag is needed for repeatable elements describe on several lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:38:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:38:26 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #14 from Jonathan Druart --- Ok, this patch looks to be the way to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:57:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:57:59 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:58:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:58:01 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31950|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 33265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33265&action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as "can be treated" if its status is "ASKED". Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 17:59:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 16:59:46 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31951|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 33266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33266&action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion > TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 18:00:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 17:00:07 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33247|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 33267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33267&action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions > TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 18:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 17:51:11 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #6 from M. Tompsett --- (In reply to Jonathan Druart from comment #5) > I am not sure to understand what I could test here... Oops. Nevermind. Turns out the t/db_dependent/Reserves.t triggers them all. Sign off coming up. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 18:52:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 17:52:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #22 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #21) > The last patch should allow you to do what you want. It works if I have something like that (with an arrayref of subfields): Title=[% FOREACH s IN fields.200.first.subfields %][% IF s.0 == "a" %][% s.1 %][% END %][% END %] It doesn't work with: [% FOREACH s IN fields.200.first.subfields %][% IF s.0 == "a" %][% s.1 %][% END %][% END %] The editing workflow is really awkward. After saving a profile, you have to do several clicks, to return on edit the CSV profile. And worst, you haven't any feedback, syntax verification, or a visual feedback. You have to switch to Download cart to see the result. When there is no result, you can surmise you have done something wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 18:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 17:53:23 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 18:53:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 17:53:25 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31023|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 33268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33268&action=edit Bug 12792: C4::Reserves breaks my vim syntax color C4/Reserves.pm is unreadable with my vim configuration. It appears I am the only one having this problem. For an incomprehensible reason, a string constructs with qq/my string/; completely breaks the syntax color for all the rest of the file (~2300l). If I replace it with qq{my string}; all is fine! Test plan: launch git show HEAD and verify this patch won't break anything. Additionally, prove t/db_dependent/Reserve.t This will trigger the three functions that were modified. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 20:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 19:51:18 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 20:51:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 19:51:21 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33219|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 33269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33269&action=edit [PASSED QA] Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions This patch modifies the way the checkouts script sets the "Always show checkouts" cookie so that it is set with an explicit expiration date (+365 days). This will allow the cookie to persist across browser sesssions. To test, apply the patch and clear your browser cookies to start with a clean slate. - Check out to a patron who has existing checkouts. Their checkouts should not load by default. - Check the "Always show checkouts immediately" checkbox. - Close your browser. - Reopen your browser and check out to that patron again. Checkouts should now be displayed by default. Signed-off-by: Frederic Demians Works as described. I confirm that without this patch, the un-persistance of "show checkouts" choice is very perturbing for librarians coming from previous version of Koha. Signed-off-by: Katrin Fischer Passes tests and QA script, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:31:45 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:31:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:31:49 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33208|0 |1 is obsolete| | Attachment #33209|0 |1 is obsolete| | Attachment #33210|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 33270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33270&action=edit [PASSED QA] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:32:19 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #15 from Katrin Fischer --- Created attachment 33271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33271&action=edit [PASSED QA] Bug 13190: Refactor the checkouts table template code This code is duplicated and should be centralised. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:36:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:36:02 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Jonathan, is it possible that exporting today's check ins (using the entry in the toolbar) is also not working? I am not sure if I am missing configuraton. I returned some items and tried exporting, the file is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:46:14 +0000 Subject: [Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I am sorry, but I am not able to see the problem on current master. I tried with 11 reports, set the page to 10, went on the second page. Tried the menu and the checkbox + button below the table. I always got the confirmation dialog. I tried from the all tab and form the acqusitions tab. What is missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:47:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:47:15 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:52:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:52:44 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #3 from Katrin Fischer --- I think this should not stay an undocumented feature. At least the preference should not have to be manually added but be a part of the sys pref editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:54:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:54:31 +0000 Subject: [Koha-bugs] [Bug 13206] New: Add GoogleIndicTransliteration system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13206 Bug ID: 13206 Summary: Add GoogleIndicTransliteration system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com See bug 31144 and http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6. A system preference GoogleIndicTransliteration should be added to expose this feature and document it. Currently the feature will work if you add the pref locally and set it to 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:54:40 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:54:40 +0000 Subject: [Koha-bugs] [Bug 13206] Add GoogleIndicTransliteration system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13144 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:56:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:56:03 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:56:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:56:06 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33220|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 33272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33272&action=edit [PASSED QA] Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 Signed-off-by: Frederic Demians I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. Signed-off-by: Katrin Fischer Fixes a somewhat 'hidden' feature, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 21:56:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 20:56:29 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:03:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:03:36 +0000 Subject: [Koha-bugs] [Bug 12829] Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32936|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:15:05 +0000 Subject: [Koha-bugs] [Bug 12829] Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:15:09 +0000 Subject: [Koha-bugs] [Bug 12829] Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32938|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 33273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33273&action=edit [PASSED QA] Bug 12829: properly skip invalid ISBN when rendering for normal record display Currently, 020$z (and 010$z fr UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 020$z (or 010$z on UNIMARC) but no 020$a (no 010$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a $a, and $z are skipped. no matter how many ISBN fields you add. - Sign off :-D Regards To+ http://bugs.koha-community.org/show_bug.cgi?id=12901 Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:15:24 +0000 Subject: [Koha-bugs] [Bug 12829] Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 --- Comment #10 from Katrin Fischer --- Created attachment 33274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33274&action=edit Bug 12829: Follow-up - fix small display issue in UNIMARC UNIMARC XSLT uses
  • instead of . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:17:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:17:29 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:28:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:28:36 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:28:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:28:41 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33236|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer --- Created attachment 33275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33275&action=edit [PASSED QA] Bug 12892 : Alternate fix to restore the deleted code This doesn't depend on anything other patch. 1. Create a reservation for a Borrower with pickup branch 2. Check-in the corresponding Item in the pickup branch and confirm the hold for the Borrower 3. Go to circ/circulation.pl for the Borrower and verify that the reservation is "Waiting for pickup" 4. In the Borrower -> Check Out -tab (circ/circulation.pl) on the right of the big "Checking out to borrowername" should be a notification about holds ready for pickup. Signed-off-by: Martin Renvoize Signed-off-by: Rafal Kopaczka Signed-off-by: Katrin Fischer Passes all tests and QA script, restores the old code and behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:09 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:07 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:12 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31948|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:15 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:18 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:20 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:38:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:38:23 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33244|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:39:23 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #25 from Katrin Fischer --- Created attachment 33276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33276&action=edit [PASSED QA] Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion use DBIx::Class instead of C4::SQLHelper. Moreover, the tests and the .pl have been adapted. Test plan: 1) Apply the patch. 2) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 3) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS 4) Log in the intranet, create a suggestion and verify the created suggestion. 5) Edit a suggestion from the intranet and verify the suggestion is correctly modified. 6) Log in the OPAC and verify you can add a suggestion. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, suggestion created on staff and opac, suggestion edited without problems, no koha-qa errors. Signed-off-by: Katrin Fischer Passes tests and QA script: Also tested: - adding suggestion from staff and OPAC - edit suggestion from staff - deleting suggestion from OPAC - changing to a normal status (email got created) - changing to a custom status (SUGGEST_STATUS) - display of custom status in OPAC No problems found. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:39:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:39:29 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #26 from Katrin Fischer --- Created attachment 33277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33277&action=edit [PASSED QA] Bug 12627: DBIx::Class is case sensitive for column names STATUS should be "STATUS", not "status". Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:39:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:39:32 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #27 from Katrin Fischer --- Created attachment 33278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33278&action=edit [PASSED QA] Bug 12627: Remove warnings suggestion.pl: keys on reference is experimental Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:39:36 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #28 from Katrin Fischer --- Created attachment 33279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33279&action=edit [PASSED QA] Bug 12627: Fix date management C4::Dates->today returns a string formatted depending on the dateformat syspref. Before the original patch, SQLHelper managed both format (string formatted and DateTime. Now DBIX::Class only manages DateTime, so the call to NewSuggestion and ModSuggestion should pass a DateTime object Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:39:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:39:40 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #29 from Katrin Fischer --- Created attachment 33280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33280&action=edit [PASSED QA] Bug 12627: Bug 12627: Fix default values - TT changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:39:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:39:43 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #30 from Katrin Fischer --- Created attachment 33281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33281&action=edit [PASSED QA] Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or 0000-00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. Signed-off-by: Katrin Fischer No regressions found, adding and editing suggestions from OPAC and staff. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:48:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:48:20 +0000 Subject: [Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Is it possible that this is also fixed by bug 13053 (PQA)? I needed to apply 13053 because I had an error message about missing permissions that it fixed, but then I could run the script without the parameter and no errors were shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 22:58:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 21:58:36 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #22 from Katrin Fischer --- Applies cleanly on master now :) But will have to continue tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:21:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:21:41 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #17 from Liz Rea --- I tested the "export today's checkins" two ways: using the "check in" page - works as expected from a borrower who had returns that day using the tickboxes on the circulation screen and clicking "Return or renew items" (after clicking "show checkouts") - worked as expected for that borrower. I noted that borrowers that don't have any checkins today get an empty file, I assume that is how the feature is intended to work. Katrin - I hope this helps. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:23:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:23:49 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #67 from David Cook --- (In reply to M. de Rooy from comment #66) > (In reply to Liz Rea from comment #63) > > Comment 57, 2nd paragraph - when someone doing QA suggests mailing a > > cleartext password might be ok, it seems right to emphatically tell them > > "no, that's a bad idea." > > Please keep it in context. Hope I do not intercept any undertone about QA > work here? > > For completeness: I completely agree that sending password by mail is > theoretically very bad. However, we probably do not have a 100% safe > solution for this. So therefore in a pragmatic view the sensitivity argument > etc. > And to add: As long as many OPACs are going over HTTP, we send the password > clear text all over the place.. > > But again, also comment 57 This approach is fine with me! When it comes to security/safety, there is never a 100% guarantee. However, there are better and worse ways of doing things. It sounds like the approach used in these patches is a reasonable one. As Eric mentioned, it's the "standard" way of doing it. As for sending passwords in the clear when using HTTP, that's not an issue with Koha's code. That's an end-user configuration issue. If people are using HTTP instead of HTTPS, that's their responsibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:44:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:44:37 +0000 Subject: [Koha-bugs] [Bug 13207] New: "Branch:" on basket page should read "Library:" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Bug ID: 13207 Summary: "Branch:" on basket page should read "Library:" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The label "Branch:" on the basket summary page should be "Library: " instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:47:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:47:34 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:47:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:47:36 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33243|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 33282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33282&action=edit [SIGNED OFF] Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN ----------------- 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:52:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:52:06 +0000 Subject: [Koha-bugs] [Bug 13208] New: More complete breadcrumbs when cancelling an order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Bug ID: 13208 Summary: More complete breadcrumbs when cancelling an order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When cancelling an order, you now can give a reason. The breadcrumbs on that page don't have the bookseller or basket. They could be more complete. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 5 23:57:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 22:57:07 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Hi Jonathan, I tested all files included in the patch and they work fine... but: git grep GetBookSeller serials/claims.pl:use C4::Bookseller qw( GetBookSeller ); serials/claims.pl: @supplierinfo=GetBookSeller($supplierid); t/db_dependent/Bookseller.t:#Test GetBookSeller t/db_dependent/Bookseller.t: "Get Supplier1 (GetBookSellerFromId)" ); ... and serials claims actually explodes when you try to open it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:00:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:00:05 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #36 from Brendan Gallagher --- (In reply to M. de Rooy from comment #35) > This passed qa now, but is there any evidence that the problem reported does > not occur anymore with adding the patches of 11395 on top? > What did you test, Brendan? I did not see the problems Marcel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:04:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:04:41 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #37 from Brendan Gallagher --- (In reply to Brendan Gallagher from comment #36) > (In reply to M. de Rooy from comment #35) > > This passed qa now, but is there any evidence that the problem reported does > > not occur anymore with adding the patches of 11395 on top? > > What did you test, Brendan? > > I did not see the problems Marcel. Sorry more info - I was testing and QA-ing this in conjunction with Kyle while I was working on the coding for this one and Kyle was QA-ing/code 11395. For 11413 (I test both with this patch plus 11319 and then with 11395 on top) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:04:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:04:59 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #5 from Katrin Fischer --- Hi Frederic, hopefully those will be the last inconsistencies to be cleaned up. I'd like to have the test, but it will need to pass. - Could you also provide a patch for ru-RU and uk-UA? Copying the English samples is fine - still a good help to get people started making their own translated notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:12:54 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:13:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:13:07 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|Test Suite |Installation and upgrade | |(web-based installer) QA Contact|gmcharlt at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:14:45 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:20:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:20:53 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:21:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:21:47 +0000 Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification types are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 00:22:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Nov 2014 23:22:08 +0000 Subject: [Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 01:00:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 00:00:28 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- (In reply to Kyle M Hall from comment #5) > I think the biggest issue with this approach is it's tied to using Apache, > right? not quite... mod_pagespeed has modules for both apache and ngnix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 01:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 00:07:27 +0000 Subject: [Koha-bugs] [Bug 13209] New: show hold wait time estimate in opac Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13209 Bug ID: 13209 Summary: show hold wait time estimate in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be neat to show the patrons what the approximate wait time is for an item if they place it on hold today. It would take the due date + the number of days it can wait on the hold shelf + the number of days it can check out for x the number of people on hold queue and say when you could (in theory) expect it to arrive back in library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 01:08:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 00:08:03 +0000 Subject: [Koha-bugs] [Bug 13210] New: Text a call number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13210 Bug ID: 13210 Summary: Text a call number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Would be nice to have an option in the opac next to a call number to text it to someone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 02:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 01:44:16 +0000 Subject: [Koha-bugs] [Bug 10168] text myself a call number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10168 --- Comment #1 from Owen Leonard --- *** Bug 13210 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 02:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 01:44:16 +0000 Subject: [Koha-bugs] [Bug 13210] Text a call number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13210 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 10168 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:19:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:19:16 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33168|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 33283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33283&action=edit Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout Signed-off-by: Liz Rea Checked these 4 conditions, plus that if a specified due date was allowed, that it was enforced. I noted that the on-site checkouts seemed to take longer to process, but this probably isn't the place for that sort of complaint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:19:33 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:30:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:30:07 +0000 Subject: [Koha-bugs] [Bug 13211] New: Google Indic Transliteration as a System Preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Bug ID: 13211 Summary: Google Indic Transliteration as a System Preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Uudocumented feature Added: Google Indic Transliteration as a System Preference Follow bug: 13144 http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:30:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:30:20 +0000 Subject: [Koha-bugs] [Bug 13211] Google Indic Transliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:32:54 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #5 from Amit --- Hi Katrin, Thanks will create Google Transliteration as a system preference. Please see Bug: 13211 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:34:14 +0000 Subject: [Koha-bugs] [Bug 13211] Google Indic Transliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 04:35:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 03:35:14 +0000 Subject: [Koha-bugs] [Bug 13211] Google Indic Transliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 05:27:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 04:27:08 +0000 Subject: [Koha-bugs] [Bug 13211] Google Indic Transliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #1 from Amit --- Created attachment 33284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33284&action=edit Bug-13211: Added Google Indic Transliteration as a System Preference Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Follow bug: 13144 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 05:27:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 04:27:30 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Google Indic |Added: |Transliteration as a System |GoogleIndicTransliteration |Preference |as a System Preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 05:27:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 04:27:53 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 05:31:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 04:31:24 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #6 from Amit --- Hi Katrin, I have created the patch Bug: 13211. Please test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:04:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:04:28 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33283|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 33285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33285&action=edit [PASSED QA] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout Signed-off-by: Liz Rea Checked these 4 conditions, plus that if a specified due date was allowed, that it was enforced. I noted that the on-site checkouts seemed to take longer to process, but this probably isn't the place for that sort of complaint. Signed-off-by: Katrin Fischer Small visual improvment for a new feature. No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:04:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:04:24 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:04:31 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:06:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:06:20 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:06:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:06:20 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:06:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:06:52 +0000 Subject: [Koha-bugs] [Bug 13206] Add GoogleIndicTransliteration system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13211 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:06:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:06:52 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #2 from Katrin Fischer --- *** Bug 13206 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:08:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:08:32 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #10 from Katrin Fischer --- I am not sure why this is marked as a major bug - improving the display of the internal notes seems like an enhancement? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:09:39 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #3 from Katrin Fischer --- Thank you Amit, this looks good - just a tiny thing we need to fix for the tests - the sysprefs.sql is alphabetically sorted, with the idea that we have less conflicts there when newly added prefs are not right next to each other all the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:12:50 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #4 from Amit --- Hi Katrin, Thanks I will recreate patch suggested by you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:18:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:18:35 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33284|0 |1 is obsolete| | --- Comment #5 from Amit --- Created attachment 33286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33286&action=edit Bug-13211: Added Google Indic Transliteration as a System Preference Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:20:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:20:22 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #6 from Amit --- Hi Katrin, Added GoogleIndicTransliteration in syspref.sql alphabetically. Please test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:31:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:31:36 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #11 from Katrin Fischer --- Working on this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:41:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:41:34 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #12 from Katrin Fischer --- I think this patch does the right thing, but I am worried for the reason we do it - the possiblity that libraries HAVE duplicated ids in their databases. Is there something smart we could do to not just leave them with: [Thu Nov 6 07:36:04 2014] updatedatabase.pl: DBD::mysql::db do failed: Duplicate entry 'test' for key 'userid' at /home/katrin/kohaclone/installer/data/mysql/updatedatabase.pl line 9015. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:44:22 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |wizzyrea at gmail.com --- Comment #6 from Liz Rea --- Applying: Bug 12555: Add a FK on aqorders_items.itemnumber fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Sorry Jonathan :/ Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:44:35 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #6 from Fr?d?ric Demians --- > Could you also provide a patch > for ru-RU and uk-UA? Copying the English samples is fine - still a good help > to get people started making their own translated notices. Ok. Will do this evening. Do you have someone doing it-I & pl-PL? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:46:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:46:08 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #7 from Katrin Fischer --- Ah sorry, I missed those in the test output. If you could do them all that would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 07:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 06:48:50 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #8 from Martin Renvoize --- I wasn't actually suggesting the use of mod_pagespeed itself, but reimplementing one of its features as best we could. In effect kyles patch does indeed do this, only it utilises a query parameter as a posed to appending to the filename itslef; which as Owen quite rightly suggests could mean that our 'static' resources end up never being chached on ocassions which would adversely affect performance. Kyle, your right that my approach of using rewrite rules would be dependant upon some apache\nginx\whatever server specific rules being written. We are doing this already though for some other cases I think so I don't see that as such a binding reason not to implement it in this way. I'll see if I can find some time today to submit an alternative patch just to give people a clue of what I'm talking about. As for upgrade paths.. I have no idea how the packages handle Apache config updates at current... But I imagine the shared config in /etc/koha to be where such rules should exist and as such believe its perfectly possible to update them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:19:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:19:48 +0000 Subject: [Koha-bugs] [Bug 13048] Serial Error when NULL date encountered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13048 --- Comment #1 from Katrin Fischer --- Hi Joy, I haven't seen this happening and haven't managed to create a serial issue without planned date - do you have some more information on it? On which page does it happen? Is it migrated data or date added to Koha manually? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:25:00 +0000 Subject: [Koha-bugs] [Bug 7997] Can't create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #16 from Katrin Fischer --- I think this needs to be fixed prior to release - sorry for missing the problem in testing earlier :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:26:02 +0000 Subject: [Koha-bugs] [Bug 6981] barcode not incrementing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|critical |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:34:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:34:07 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #9 from Martin Renvoize --- Created attachment 33287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33287&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:34:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:34:50 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #10 from Martin Renvoize --- Alternative patch including Apache rewrite rules attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:38:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:38:12 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #11 from Martin Renvoize --- Hold off on testing.. my RewriteRule needs some more work ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:41:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:41:10 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #12 from Martin Renvoize --- Scratch that.. it was just my gitified setup confusing me ;).. Go forth and test ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:43:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:43:31 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #38 from M. de Rooy --- (In reply to Brendan Gallagher from comment #37) > (In reply to Brendan Gallagher from comment #36) > > (In reply to M. de Rooy from comment #35) > > > This passed qa now, but is there any evidence that the problem reported does > > > not occur anymore with adding the patches of 11395 on top? > > > What did you test, Brendan? > > > > I did not see the problems Marcel. > > Sorry more info - I was testing and QA-ing this in conjunction with Kyle > while I was working on the coding for this one and Kyle was QA-ing/code > 11395. For 11413 (I test both with this patch plus 11319 and then with > 11395 on top) Thanks. I verified now that the bug of comment28 is resolved by applying the patches of bug 11395 on top of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 08:59:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 07:59:35 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #13 from Martin Renvoize --- Of course.. we'll need a followup for other static files too (at least css). I'll get to work on that using my method.. and will include upping the cache time for .js and .css files as this patch basically means we're introducing a method for enforced replacement of caches when, and only when, we want them to get updated :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:08:08 +0000 Subject: [Koha-bugs] [Bug 13212] New: Use CSS3 ellipsis instead of FacetLabelTruncationLength Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212 Bug ID: 13212 Summary: Use CSS3 ellipsis instead of FacetLabelTruncationLength Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CSS3 has text-overflow: ellipsis - should use that instead of FacetLabelTruncationLength -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:35:31 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #14 from Martin Renvoize --- Created attachment 33288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33288&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:41:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:41:19 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33245|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 33289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33289&action=edit Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:42:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:42:09 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #7 from M. de Rooy --- (In reply to Jonathan Druart from comment #2) > Moreover the default value should be '00' not '', isn't it? Corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:49:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:49:27 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30613|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 33290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33290&action=edit Bug 12555: Call DelItem on cancelling a receipt On cancelling a receipt, the items should be deleted using the C4::Items::DelItem subroutine in order to update zebra and sent the items in the deleteditems table. The entries in aqorders_items will automatically deleted by the DBMS (on delete cascade). Test plan: 0/ Set the AcqCreateItem pref to "on receiving" 1/ Create an order with some items 2/ Receive the items 3/ Note the itemnumber in the items table 4/ Cancel the receipt 5/ Verify the itemnumbers are present in the deleteditems table and the items have been deleted. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:49:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:49:29 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31008|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 33291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33291&action=edit Bug 12555: Add a FK on aqorders_items.itemnumber The previous patch assumed that deleting an item will delete the entry in aqorders_items. But the FK did not exist. Looking at the code, we never join aqorders_items and deleteditems, so I think we can add this constraint. Before adding this constraint, we need to delete all entries in aqorders_items if the item has already been deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:49:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:49:48 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:56:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:56:41 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 --- Comment #5 from M. de Rooy --- (In reply to M. de Rooy from comment #4) > (In reply to Fridolin SOMERS from comment #3) > > (In reply to M. de Rooy from comment #2) > > > Fridolin: We had discussions about superlibrarians viewing all lists in the > > > past; the outcome generally was: don't do it for reasons of privacy. > > > > privacy for a superlibarian ? > > those users can see full patron details, circulation history, even change > > its password. > > I will try to find it on Bugzilla.. See bug 5763 (there may be more, perhaps linked with bug 7310) I personally think that we could perhaps resolve this by offering an optional third tab (or another form) in staff that allows the superlibrarian or perhaps users with a specific permission to search for lists of other users. This third tab or something like that could be switched off if the library sees it as a privacy issue. This would also prevent a mixup of all these lists for that particular staff user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 09:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 08:56:55 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #15 from Martin Renvoize --- Kyle, how did you choose which files to do this for.. it feels like there are instances of js files referred to which you've not accounted for? I discovered this whilst attempting to find all css files fro a similar treatment. I've used the following command to regex all css imports within file in the templates directory and note that many of my results also contained a JS import that hadn't had your treatment applied? grep -r -l " References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #8 from Jonathan Druart --- (In reply to M. de Rooy from comment #7) > (In reply to Jonathan Druart from comment #2) > > Moreover the default value should be '00' not '', isn't it? > > Corrected. 1 character is still missing. "A celestial chart with an angular scale, with declination -16? to -49?" is $i-0160000$j-0490000 With the patch, I get $i-016000$j-049000 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:00:12 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #16 from Martin Renvoize --- Admittedly.. my regex catches a few file we don't wish to update.. but I'm now going through the file manually to remove those.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:11:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:11:33 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33289|0 |1 is obsolete| | --- Comment #9 from M. de Rooy --- Created attachment 33292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33292&action=edit Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:12:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:12:13 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #10 from M. de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to M. de Rooy from comment #7) > > (In reply to Jonathan Druart from comment #2) > > > Moreover the default value should be '00' not '', isn't it? > > > > Corrected. > > 1 character is still missing. > > "A celestial chart with an angular scale, with declination -16? to -49?" > is $i-0160000$j-0490000 > > With the patch, I get $i-016000$j-049000 Thanks for testing. Fixed a dumb typo: f3 = f3.substring(f2.length-2); f2->f3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:23:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:23:47 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #10 from Jonathan Druart --- Created attachment 33293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33293&action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:23:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:23:51 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #11 from Jonathan Druart --- Created attachment 33294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33294&action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:24:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:24:48 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #12 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #8) > Followup expected :-) It would be nice also to have an updatabase.pl entry to > insert the new TO_PROCESS notification. Done, thanks Fr?d?ric for your tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:33:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:33:51 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #23 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #22) > (In reply to Jonathan Druart from comment #21) > > > The last patch should allow you to do what you want. > > It works if I have something like that (with an arrayref of subfields): > > Title=[% FOREACH s IN fields.200.first.subfields %][% IF s.0 == "a" %][% s.1 > %][% END %][% END %] > > It doesn't work with: > > [% FOREACH s IN fields.200.first.subfields %][% IF s.0 == "a" %][% s.1 %][% > END %][% END %] Hum, yes. I have no solution for this case. It's a limitation. > The editing workflow is really awkward. After saving a profile, you have to > do several clicks, to return on edit the CSV profile. And worst, you haven't > any feedback, syntax verification, or a visual feedback. You have to switch > to Download cart to see the result. When there is no result, you can surmise > you have done something wrong. Yes, I totally agree... But it is not in the scope of this enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:36:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:36:16 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #17 from Martin Renvoize --- Created attachment 33295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33295&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:38:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:38:19 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33295|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 33296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33296&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:39:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:39:55 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #19 from Martin Renvoize --- Created attachment 33297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33297&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:44:22 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Jonathan Druart --- (In reply to Katrin Fischer from comment #23) > Hi Jonathan, > > I tested all files included in the patch and they work fine... but: > > git grep GetBookSeller > serials/claims.pl:use C4::Bookseller qw( GetBookSeller ); > serials/claims.pl: @supplierinfo=GetBookSeller($supplierid); > t/db_dependent/Bookseller.t:#Test GetBookSeller > t/db_dependent/Bookseller.t: "Get Supplier1 (GetBookSellerFromId)" ); > > ... and serials claims actually explodes when you try to open it. git remote update git checkout -b bug_12896 origin/master git bz apply 12852 git bz apply 12896 git grep GetBookSeller misc/release_notes/release_notes_3_10_0.txt: 8223 minor Properly format SQL query in C4::Bookseller::GetBookSeller t/db_dependent/Bookseller.t:#Test GetBookSeller t/db_dependent/Bookseller.t: "Get Supplier1 (GetBookSellerFromId)" ); You certainly forgot to apply 12852 before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:46:41 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #25 from Jonathan Druart --- Created attachment 33298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33298&action=edit Bug 12896: Remove 2 occurrences in comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 10:52:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 09:52:23 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #20 from Martin Renvoize --- (In reply to Martin Renvoize from comment #15) > Kyle, how did you choose which files to do this for.. it feels like there > are instances of js files referred to which you've not accounted for? > > I discovered this whilst attempting to find all css files fro a similar > treatment. > > I've used the following command to regex all css imports within file in the > templates directory and note that many of my results also contained a JS > import that hadn't had your treatment applied? > > grep -r -l " sed -i 's/\.css"/_[% KOHA_VERSION %].css"/g' Regarding this comment.. I'm even more sure we've missed a few places for the JS's.. We'll definitely need to handle these before applying my follow-up patch that increases JS cache time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 11:20:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 10:20:16 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #26 from Katrin Fischer --- You are totally right... dependencies dependencies... will retest tonight. All other things I tested worked nicely, I am being carefully optimistic :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 11:33:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 10:33:53 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #11 from Jonathan Druart --- What means "Degree (complete with 0):"? Does it should be 000 for degree and 00 for the 2 others? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 11:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 10:46:04 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #12 from M. de Rooy --- (In reply to Jonathan Druart from comment #11) > What means "Degree (complete with 0):"? > Does it should be 000 for degree and 00 for the 2 others? I just copied this from the existing unimarc_field_123g template. It actually means left padding with zeroes. I agree that this text is confusing. According to the specs, it is plus or minus followed by 3-2-2 chars (total 8). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 11:52:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 10:52:32 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #8 from Zeno Tajoli --- For OPAC_REG_VERIFY, RENEWAL in it-IT/necessari/notices.sql the English strings are OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 11:55:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 10:55:38 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33292|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 33299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33299&action=edit Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 11:55:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 10:55:35 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 12:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 11:35:21 +0000 Subject: [Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33117|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 33300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33300&action=edit [PASSED QA] Bug 10582: Koha OPAC URL shows Perl error message before web installer was run This patch makes opac/maintenance.pl run smoothly when the DB hasn't been populated yet. It does so, by using C4::Templates::gettemplate instead of C4::Auth::get_user_and_template as the maintenance page doesn't need authentication checks at all, it should happen *before* any attempt to check credentials. To test: - Backup and DROP your database - Point your browser to the OPAC page => FAIL: An error is shown: "Cant's use an undefined value as an ARRAY..." - Apply the patch - Relad the page => SUCCESS: The maintenance page correctly shows. We should now check the rest of the script's behaviour remains untouched: - Reload your backed up DB - Change your DB version number by hand to one version lower, like in: > UPDATE systempreferences SET value="3.1700042" WHERE variable LIKE '%version%'; - Go to the OPAC => SUCCESS: Maintenance page shows as expected - Recover the right version number, like in: > UPDATE systempreferences SET value="3.1700043" WHERE variable LIKE '%version%'; - Set OpacMaintenance to Show on the staff client - Reload the OPAC => SUCCESS: Maintenance page shows as expected - Set OpacMaintenance to 'Don't show' on the staff client - Reload the OPAC => SUCCESS: Normal OPAC shows - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer Works as described, fixes long existing bug. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 12:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 11:48:50 +0000 Subject: [Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Nice, I've been meaning to fix that for a few years now ;) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 13:47:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 12:47:05 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com Severity|enhancement |trivial --- Comment #7 from Tom?s Cohen Arazi --- I'm marking this one as normal. It is really making a feature usable, the interested users already use it by having the syspref manually set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 13:52:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 12:52:51 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |13211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 13:52:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 12:52:51 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:14:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:14:39 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:14:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:14:41 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #7 from M. Tompsett --- Created attachment 33301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33301&action=edit Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:15:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:15:27 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33301|0 |1 is obsolete| | CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:16:28 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:16:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:16:30 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33286|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 33302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33302&action=edit Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:18:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:18:49 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from M. Tompsett --- (In reply to M. Tompsett from comment #7) > Created attachment 33301 [details] [review] > Bug-13211: Added Google Indic Transliteration as a System Preference Sorry for the blip. git bz thought it should attach here, because I applied 13144 in order to test 13211. I believe the status was passed QA before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:21:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:21:45 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #92 from Paola Rossi --- I beg your pardon for the following comment, further in addition to the 91-th comment. It's about the syspref "AllowOnShelfHolds". As the manual 3.16 says: "Asks: ___ hold requests to be placed on items that are not checked out." At my tests, the default value is "Don't allow" instead of the manual's default "Allow". The "Allow" status is the most interesting one, of course. [on MASTER] A) About a multi branch system, with "Transfer" from L1 to L2 ["if the library system is a multi branch system and patrons used the hold system to request items from other libraries"], the 3 status/found (of the just created hold, of the transferred hold by L1, and also after cancelling the Transfer by L2's receiving] are all NULL. IMHO the status/found of the hold could be "W" after cancelling. B) About reserving from home ["if the library wanted to allow users to place holds on items [NOT OUT!] from home"], IMHO the status/found of the hold could be "W", but at my tests it's NULL. If A) and B) be bugs, and fixed, all these new "W" cases of a hold should be tested in this patch 8367 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:22:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:22:39 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5763 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:22:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:22:39 +0000 Subject: [Koha-bugs] [Bug 5763] Add users private list management functionality for administrators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12838 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:27:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:27:42 +0000 Subject: [Koha-bugs] [Bug 13194] Tiny typo in POD for SetMessagingPreferencesFromDefaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:27:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:27:59 +0000 Subject: [Koha-bugs] [Bug 13103] No checkouts count on member details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Rafal! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:28:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:28:38 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:28:56 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #50 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:30:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:30:01 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 --- Comment #6 from Fridolin SOMERS --- In my opinion, superlibarian user goal is to have full access in order to fix some problems : permissions, orphan datas ... A normal user should not be superlibrarian. Only the system administrator who knows about patrons privacy and uses his access only when necessary. Think about users that have access to the reports module, the can know what they want about patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:31:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:31:01 +0000 Subject: [Koha-bugs] [Bug 13144] Google transliteration does not work on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Amit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:36:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:36:47 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 33303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33303&action=edit [SIGNED-OFF] Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:36:53 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 33304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33304&action=edit [SIGNED-OFF] Bug 13211: (followup) remove 'masthead' reference Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:41:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:41:51 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33302|0 |1 is obsolete| | CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:57:40 +0000 Subject: [Koha-bugs] [Bug 8822] public calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #1 from Viktor Sarge --- A public calendar would be great and particularly with opening hours. Currently the receipts print a date and timestamp with hh:mm:ss with gives a return by "date 23:59:00" which is just plain silly. But since people have hourly loans we can't remove that timestamp. Hence my interest in a public calendar that includes opening hours since we would then have a timestamp that says to return by closing hours. (I'll file a separate bug for the opening hours part and connect them with a see also) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 14:58:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 13:58:15 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:00:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:00:15 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31863|0 |1 is obsolete| | --- Comment #13 from Paola Rossi --- Created attachment 33305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33305&action=edit 31863: Bug 12993: Add a default tax rate on item types I've applied the patch against master 3.17.00.046 HEAD 11425. On ADMIN the syspref "item-level_itypes" has been set to "biblio record". Everything is OK ordering from a suggestion, suscription, new record, existing record, as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:01:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:01:27 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32018|0 |1 is obsolete| | --- Comment #14 from Paola Rossi --- Created attachment 33306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33306&action=edit 32018: Bug 12993: Add a default tax rate on item types - DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:03:13 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32284|0 |1 is obsolete| | --- Comment #15 from Paola Rossi --- Created attachment 33307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33307&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:05:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:05:20 +0000 Subject: [Koha-bugs] [Bug 8822] public calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8133 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:05:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:05:20 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:06:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:06:57 +0000 Subject: [Koha-bugs] [Bug 8822] public calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 --- Comment #2 from Viktor Sarge --- Found 8133 that gives us opening hours and set a "see also". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:07:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:07:55 +0000 Subject: [Koha-bugs] [Bug 13213] New: choose what fields don't overlay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13213 Bug ID: 13213 Summary: choose what fields don't overlay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When importing marc records it would be nice if there was a way to choose fields that won't overlay - for example local notes stay, but all the rest of the record is overlayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:11:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:11:57 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #31 from Viktor Sarge --- Will receipts adjust their timestamp for "return by" based on opening hours or should that be a separate patch? The current situation with the receipts asking people to return books a minute to midnight is a bit silly. (btw - I set a "see also" from 8822 that asks for a public calendar with opening hours.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:17:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:17:17 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #72 from Katrin Fischer --- Kyle, could you please take a look at comment 66? People seem very interested in testing this :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:19:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:19:41 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32909|0 |1 is obsolete| | --- Comment #66 from Julian Maurice --- Created attachment 33308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33308&action=edit Bug 11708: Add aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:20:05 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32910|0 |1 is obsolete| | --- Comment #67 from Julian Maurice --- Created attachment 33309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33309&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:20:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:20:49 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32911|0 |1 is obsolete| | --- Comment #68 from Julian Maurice --- Created attachment 33310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33310&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:20:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:20:59 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32912|0 |1 is obsolete| | --- Comment #69 from Julian Maurice --- Created attachment 33311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33311&action=edit Bug 11708: explicitly remove pagination Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:21:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:21:10 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32913|0 |1 is obsolete| | --- Comment #70 from Julian Maurice --- Created attachment 33312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33312&action=edit Bug 11708: All basketgroups on one page - several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:21:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:21:24 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32914|0 |1 is obsolete| | --- Comment #71 from Julian Maurice --- Created attachment 33313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33313&action=edit Bug 11708: Remove the amount columns Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:26:32 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #72 from Julian Maurice --- There were a couple of conflicts about [% yuipath %] being removed in favor of [% interface %]. Oddly, I didn't had the same problem as you Katrin about the 5th patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:44:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:44:50 +0000 Subject: [Koha-bugs] [Bug 13214] New: Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Bug ID: 13214 Summary: Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org When you have 167 import batches and you try to pick one by going to acqui/addorderiso2709.pl, it takes ~16s to load the page. This is because all import_records are loaded simply to check if an import_batch has recors with the given status. This patch fixes this and cuts the load time to 1.6s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:45:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:45:01 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7180 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:45:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:45:01 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13214 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:45:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:45:28 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:48:41 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 33314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33314&action=edit Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly TEST PLAN: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 16s for the acqui/addorderiso2709.pl -view to load. AFTER PATCH: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:49:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:49:38 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti --- Tested using Jonathan's excellent tutorial about Perl performace profiling! http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 15:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 14:52:48 +0000 Subject: [Koha-bugs] [Bug 13205] Last/First page options for result list paging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #1 from Katrin Fischer --- Something else that would be helpful is a box where you can enter the page that you want to jump to. This is also an accessibility problem as our current way of paging makes it harder to work with long result lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:37:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:37:04 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #17) > I feel like we made a mistake here. Now it's not possible to add notices > that have a hardcoded notice code like 'HOLD' for multiple branches. > > Maybe I am wrong...? Good catch. This behavior will be problematic quickly and should be fix before the release. I am going to submit a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:40:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:40:43 +0000 Subject: [Koha-bugs] [Bug 13215] New: letter.code is considered as a primary key Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Bug ID: 13215 Summary: letter.code is considered as a primary key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The patches submitted on bug 11742 tried to fix an issue based on a (very) assertion: letter.code should be considered as a primary key and should be uniq. This is completely wrong, we can have a code for the default letter (branchcode=='') and the same code for a specific library. The interface should not block the creation of new letter with the same letter code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:40:53 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11742 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:40:53 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:46:41 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #21 from Martin Renvoize --- Created attachment 33315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33315&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:49:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:49:00 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #22 from Martin Renvoize --- I'm pretty sure I've caught all css and js now.. lots of regex fun... not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:55:03 +0000 Subject: [Koha-bugs] [Bug 13048] Serial Error when NULL date encountered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13048 --- Comment #2 from Joy Nelson --- Katrin- I have seen this in a lot of migrated data. Which is an issue only because previously that date wasn't required for serial functionality. And now the system is throwing errors and is unusable for them. However, I have had newer sites complain of this which makes me think they have someone created a serial without that information. I'll see if I can replicate this. joy (In reply to Katrin Fischer from comment #1) > Hi Joy, > > I haven't seen this happening and haven't managed to create a serial issue > without planned date - do you have some more information on it? On which > page does it happen? Is it migrated data or date added to Koha manually? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:56:43 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 16:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 15:56:46 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #1 from Jonathan Druart --- Created attachment 33316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33316&action=edit Bug 13215: The same letter code can be used for several libraries This patch fixes a major issue introduced by the commit 5c4fdcf Bug 11742: A letter code should be unique. The interface should let the possibility to create a default template letter and some specific ones, with the same letter code (letter.code). The patches submitted on bug 11742 tried to fix an issue based on a (very) assertion: letter.code should be considered as a primary key and should be uniq. This patch reintroduces this behavior. Note that the interface will block a letter code used in different module (this is consistent not to have the same letter code used for different needs). This patch is absolutely not perfect, it just tries to change as less change as possible and to use new tested subroutines. Test plan: 1/ Verify that the problem raised on bug 11742 does not appears anymore. 2/ Verify there are no regression on adding, editing, copying, deleting letters. 3/ Verify you are allowed to create a default letter template with a letter code and to reuse for a specific letter (i.e. for a given library). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:04:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:04:05 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #2) > Tested using Jonathan's excellent tutorial about Perl performace profiling! > > http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf It's not mine :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:04:35 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33288|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 33318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33318&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:04:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:04:32 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33287|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 33317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33317&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:04:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:04:38 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33296|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 33319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33319&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:04:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:04:42 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33297|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 33320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33320&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:04:45 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33315|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 33321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33321&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:08:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:08:30 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:08:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:08:32 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33314|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 33322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33322&action=edit Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly TEST PLAN: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 16s for the acqui/addorderiso2709.pl -view to load. AFTER PATCH: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:22:06 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #2 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > The patches submitted on bug 11742 tried to fix an issue based on a > (very) assertion: letter.code should be considered as a primary key and > should be uniq. ...based on a (very) *bad* assertion... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:44:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:44:44 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33318|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 33324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33324&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:44:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:44:41 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33317|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 33323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33323&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:44:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:44:48 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33319|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 33325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33325&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:44:51 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33320|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 33326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33326&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:44:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:44:54 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33321|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 33327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33327&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:44:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:44:57 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #33 from Martin Renvoize --- Created attachment 33328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33328&action=edit Bug 12904 [Followup] - Add to Intranet for Dev Install I managed to miss the intranet vhost directive first time around.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:45:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:45:45 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:53:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:53:34 +0000 Subject: [Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:53:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:53:50 +0000 Subject: [Koha-bugs] [Bug 13043] Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 17:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 16:54:46 +0000 Subject: [Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 18:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 17:02:26 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 18:02:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 17:02:31 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33127|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 33329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33329&action=edit Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 18:25:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 17:25:02 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 18:40:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 17:40:54 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I'm wondering if this would pass QA. Marcel suggested that things with SQL in them might not pass QA here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753#c64 Just thought I'd note this here to, perhaps, get clarification of whether the added functions should have explicit SQL queries in them like they do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 18:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 17:58:08 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I am not sure how the discussion on bug 8753 relates to this patch - I think the point there was to not have SQL in the .pl files? Joubu moved a lot of the logic into the module and wrote tests. This seems like a major improvement of the code in terms of coding guidelines. Also, there is a difference between new features and trying to improve old code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:06:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:06:34 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #5 from M. Tompsett --- (In reply to Katrin Fischer from comment #4) > I am not sure how the discussion on bug 8753 relates to this patch - I think > the point there was to not have SQL in the .pl files? So, SQL in .pm files is okay? I thought we were trying to move to DBIx as much as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:26:43 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #27 from Katrin Fischer --- C4/Acquisition.pm | 4 +- C4/Bookseller.pm | 53 +-------- Koha/Acquisition/Bookseller.pm | 124 +++++++++++++++++++++ acqui/addorderiso2709.pl | No regression found. acqui/basket.pl | No regression found. acqui/basketgroup.pl | No regression found. acqui/basketheader.pl | No regression found. acqui/booksellers.pl | No regression found. acqui/finishreceive.pl | No regression found. acqui/invoice.pl | No regression found. acqui/invoices.pl | No regression found. acqui/modordernotes.pl | No regression found. acqui/neworderbiblio.pl | No regression found. acqui/neworderempty.pl | No regression found. acqui/newordersubscription.pl | No regression found. acqui/newordersuggestion.pl | No regression found. acqui/orderreceive.pl | No regression found. acqui/parcel.pl | No regression found. acqui/parcels.pl | No regression found. acqui/supplier.pl | No regression found. acqui/transferorder.pl | No regression found. acqui/uncertainprice.pl | No regression found. acqui/z3950_search.pl | No regression found. admin/aqcontract.pl | No regresison found. catalogue/moredetail.pl | No regression found. serials/acqui-search-result.pl | No regression found. serials/subscription-detail.pl | No regression found. t/db_dependent/Acquisition.t | Pass t/db_dependent/Acquisition/Invoices.t | Pass t/db_dependent/Acquisition/OrderFromSubscription.t | Pass t/db_dependent/Bookseller.t | Pass t/db_dependent/Letters.t | Pass Serials - Subscription search - Subscription detail - vendor shows - Subscription edit - vendor can be searched and linked Acquisitons - vendors - searching for vendors - vendor details, editing a vendors Acquisitions - baskets & basket groups - adding a new basket group - printing PDF Acquisitons - uncertain prices - viewing uncertain prices list Acquisitions - contracts - adding, editing, deleting a contract Acquisition - baskets - adding a new basket - changing basket header details - order from z39.50 - order from 'new' - order from existing - order from staged - order from subscription - order from suggestion - transferring an order - adding vendor and internal note Acquisition - receive shipment - receive a new shipment - reveiving orders - undo receipt - canceling an order - giving a reason (new) - finish receiving Acquisitions - invoices - Searching for invoices - Closing an invoice - Viewing an invoice Catalog - detail page - Acquisition tab - Items tab - display of bookseller and acquisition information Also: git grep GetBookSeller - no references found. git grep GetBookSellerFromId - no references found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:29:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:29:19 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #121 from Tom?s Cohen Arazi --- Created attachment 33330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33330&action=edit Bug 8836: (RM followup) fix updatedatabase.pl rebase problem Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:30:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:30:16 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #122 from Tom?s Cohen Arazi --- Created attachment 33331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33331&action=edit Bug 8836: Update DBIx Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:34:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:34:10 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:34:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:34:15 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33164|0 |1 is obsolete| | Attachment #33298|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 33332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33332&action=edit [PASSED QA] Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in it the code from GetBookSeller and GetBookSellerFromId. Test plan: 1/ Create a bookseller, modify it. 2/ Add contacts for this bookseller 3/ Create an order, receive it, transfer it 4/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:34:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:34:30 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #29 from Katrin Fischer --- Created attachment 33333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33333&action=edit [PASSED QA] Bug 12896: Remove 2 occurrences in comments Signed-off-by: Katrin Fischer Passes tests and QA script. Full test report on the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:48:39 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #5) > (In reply to Katrin Fischer from comment #4) > > I am not sure how the discussion on bug 8753 relates to this patch - I think > > the point there was to not have SQL in the .pl files? > > So, SQL in .pm files is okay? I thought we were trying to move to DBIx as > much as possible. Mark, you are right about using DBIx. I'll talk to Jonathan about it. I might push it as-is if the release date approaches, because it is important to have it ASAP integrated for the beta. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:50:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:50:48 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #68 from Owen Leonard --- If you use the same password recover link twice you get an error which is inaccurate: "We could not authenticate you as the account owner Be sure to use the link you received in your email." It might make sense to retain entries in the borrower_password_recovery table for a certain amount of time after they have been "used" so that we can accurately tell the user that they have followed a link which is out of date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:52:21 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:52:24 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33303|0 |1 is obsolete| | Attachment #33304|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 33334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33334&action=edit [PASSED QA] Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:53:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:53:31 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #12 from Katrin Fischer --- Created attachment 33335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33335&action=edit [PASSED QA] Bug 13211: (followup) remove 'masthead' reference Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:54:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:54:25 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33216|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 33336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33336&action=edit Bug 13199 Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:04 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29898|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel --- Created attachment 33337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33337&action=edit Bug 12017 - 1 - Move language description out of database This patch adds identical copies of languages.inc file on include dirs, and modifies include files to process it. To test: 1. No change on current behavior must be observer, any page staff/opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:10 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29899|0 |1 is obsolete| | --- Comment #44 from Bernardo Gonzalez Kriegel --- Created attachment 33338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33338&action=edit Bug 12017 - 2 - Enable languages on web installer This patch modifies installer/step1.tt to use new language descriptions. Only parameter used is rfc4646 code. To test: 1. Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done or make some lang dirs on intranet-tmpl/prog 2. Apply the patch 3. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in with database user, you will be redirected to step1 of web installer. 4. Check names and codes for installed languages. Revert to your old database before proceed, but left dirs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:17 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29900|0 |1 is obsolete| | --- Comment #45 from Bernardo Gonzalez Kriegel --- Created attachment 33339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33339&action=edit Bug 12017 - 3 - Change lang display on sysprefs I18N This patch change the display of languages on sysprefs to set translated languages on I18N Only parameter used is rfc4646 subtag To test: 1. Apply the patch 2. Go to I18N syspref, look language descriptions Following steps are for next patch 3. Set a bunch of languages for staff/opac, save, reload Inlude vi-VN for which there is no current description in databasse 4. Set opaclanguagesdisplay to Allow Current display is preserved, native description for languages outside group, and script/region for language groups Only change is languages ordered by rfc4646 subtag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:23 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29901|0 |1 is obsolete| | --- Comment #46 from Bernardo Gonzalez Kriegel --- Created attachment 33340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33340&action=edit Bug 12017 - 4 - Change language changers This patch modifies language changers on staff/opac Only parameter used is rfc4646 To test: 1. Apply the patch 2. Reload staff and opac (prog/ccsr/bootstrap) 3. Check display of language changers 4. Do a real translation and check language change works Do not change language unless you did a real translation Only change in display is showing only regions for sublanguages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:29 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29902|0 |1 is obsolete| | --- Comment #47 from Bernardo Gonzalez Kriegel --- Created attachment 33341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33341&action=edit Bug 12017 - 5 - Change local use syspref type Language This patch changes local use syspref of type Language Currently this type of syspref is not used, and shows currently translated staff languages. It's values can't be changed. To make something useful, this kind of syspref is changed to show all langs and save iso639_2 codes. And they not use descriptions on database, only rfc4646 codes from templates. It's easy to add new kinds that save rfc4646 codes, or only show translated languages. To test: 1. Apply the patch 2. Go to system preferences, local use 3. Define a new syspref, any name/description, type 'Language', Save 4. New syspref is showed as a multiple selection of iso639_2 codes with current lang and native names. Check that 5. Select some values, save, check they are saved and restored 6. Edit, similar view, change values, save, check 7. Delete test syspref Values are stored as ',' separated values Verify in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:36 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29903|0 |1 is obsolete| | --- Comment #48 from Bernardo Gonzalez Kriegel --- Created attachment 33342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33342&action=edit Bug 12017 - 6 - Change syspref AdvancedSearchLanguages Bug 10986 introduces a way of limiting advanced search languages list. It's a good feature, but to fill the preference you need to list iso639_2 codes. And there is no way to get the list of all codes again as before, and language descriptions are taken from database. This patch changes that preference so it's now a Local syspref, to present an interface to set it's value. Also adds another syspref to control if language chooser is limited at all, recovering previous behavior. As per comments on Bug 10986 language list shows translated and native names and is ordered by iso639_2 code To test: 1. Apply the patch 2. Run updatedatabase.pl 3. Go to system preferences, Searching, new syspref LimitAdvancedSearchLanguages, on by default 4. Go to Local use sysprefs, AdvancedSearchLanguages is now here with interface to set it's values 5. Check language limit on advanced search on staff and opac (any theme) 6. Disable limit and chech language list 7. Enable limit and set different languages on syspref, check language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:43 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29904|0 |1 is obsolete| | --- Comment #49 from Bernardo Gonzalez Kriegel --- Created attachment 33343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33343&action=edit Bug 12017 - 7 - Remove function getFrameworkLanguages [ Note: From now on dependence on language descriptions in database is about to be removed, also some code cleaning.] This must be an old relic, not used anymore. To test: 1. Check use of getFrameworkLanguages egrep -Rl getFrameworkLanguages * No result save for definition file 2. Apply the patch 3. check again, no results Reason for removing this function is that it's not used and tries to send languages descriptions from database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:49 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29905|0 |1 is obsolete| | --- Comment #50 from Bernardo Gonzalez Kriegel --- Created attachment 33344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33344&action=edit Bug 12017 - 8 - Remove use of getAllLanguages from installer getAllLanguages is only used on installer/install.pl, and some tests. Result parameters are passed to C4/Install.pm, but its use is futile, language check on Installer.pm uses parameters that are not present on return value of getAllLanguages, and returned value fwk_code is undefined To test: 1. Apply the patch 2. Do translated install (eg using de-DE or es-ES) a. translate first, b. then create a new database, c. grant permissions, d. change koha-conf to use new db, e. reload staff, f. proceed to web install, g. select translated language, h. use marc21, i. finish, 3. Login and check that marc frameworks are translated The translated install must proceed without problems. Removed only the very first occurence of template parameter fwk_language because of it's null value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:56:55 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29906|0 |1 is obsolete| | --- Comment #51 from Bernardo Gonzalez Kriegel --- Created attachment 33345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33345&action=edit Bug 12017 - 9 - Remove use of language_get_description function This patch removes every use of language_get_description function. This function retrieves lang names from database To test: 1. Functionality removed by this patch do not affect anything, because previous patches are only using rfc4646_subtag value, not values stored in database. 2. Removed import from Templates.pm, not used there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:57:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:57:01 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29907|0 |1 is obsolete| | --- Comment #52 from Bernardo Gonzalez Kriegel --- Created attachment 33346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33346&action=edit Bug 12017 - 10 - Remove description from getLanguage This patch rewrites getLanguage function. This function is of not much use, but is rewrited to takes its data from language_rfc4646_to_iso639 table. To test: 1. Apply the patch 2. Only place that use this function is t/db_dependent/Languages.t so run the test and check that it pass 3. To compare the output pre and post patch you can run perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper $a;' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 19:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 18:57:53 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #53 from Bernardo Gonzalez Kriegel --- Rebased & updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 20:05:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 19:05:47 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 20:05:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 19:05:52 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33299|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 33347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33347&action=edit [PASSED QA] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes tests and QA script. Checked plugin in a UNIMARC installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 20:10:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 19:10:20 +0000 Subject: [Koha-bugs] [Bug 13154] The webinstaller should offer all available languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13154 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- Web installer states: "Please pick your language from the following list. If your language is not listed, please inform your systems administrator." Perhaps the message can be changed, suggesting a way to add more languages before proceed. Bug 12017 adds proper description to "present" (i.e. installed) languages on web installer. But to show a complete list without using database you will need a hardcoded TT list of language codes, it's doable. An then a JS validity check for selected vs. present language. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 20:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 19:10:53 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #69 from Owen Leonard --- opac/opac-password-recovery.pl line 163: warn "INLIBRO username $username"; The script contains a lot of SQL, which is a violation of coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts The template contains a check for the variable "errTooManyEmailFound" but I don't see where that variable is created. In fact there doesn't seems to be any handling of multiple identical email addresses. This is a problem for my library where parents often put their email addresses on their kids' accounts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 20:13:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 19:13:39 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #7 from M. Tompsett --- (In reply to Katrin Fischer from comment #4) > This seems like a major > improvement of the code in terms of coding guidelines. It is. I'm not critiquing that. Frankly, the code is beautiful. > Also, there is a > difference between new features and trying to improve old code. &GetLettersAvailableForALibrary &GetLetterTemplates &DelLetter These are new functions, which is why I was asking about DBIx. Thank you for the reply, Tomas. I'll work on signing these off if needed, just let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 21:49:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 20:49:53 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 21:49:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 20:49:59 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33329|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 33348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33348&action=edit [PASSED QA] Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Tested the SQL, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 21:58:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 20:58:38 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 21:58:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 20:58:41 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33282|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 33349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33349&action=edit [PASSED QA] Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN ----------------- 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:01:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:01:24 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Jonathan, the patch doesn't apply cleanly - can you take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:28:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:28:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #51 from Katrin Fischer --- The patches currently don't apply for me: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 11592 - MARC Visibility settings not respected fatal: sha1 information is lacking or useless (C4/Biblio.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:40:02 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #9 from M. Tompsett --- Bug 11126 is what is causing the conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:46:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:46:16 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:46:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:46:18 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33268|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 33350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33350&action=edit Bug 12792: C4::Reserves breaks my vim syntax color C4/Reserves.pm is unreadable with my vim configuration. It appears I am the only one having this problem. For an incomprehensible reason, a string constructs with qq/my string/; completely breaks the syntax color for all the rest of the file (~2300l). If I replace it with qq{my string}; all is fine! Test plan: launch git show HEAD and verify this patch won't break anything. Additionally, prove t/db_dependent/Reserves.t This will trigger the three functions that were modified. Sorry, but t/db_dependent/Reserves.t fails currently. Checking why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:55:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:55:54 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:55:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:55:57 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33350|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 33351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33351&action=edit [SIGNED OFF] Bug 12792: C4::Reserves breaks my vim syntax color C4/Reserves.pm is unreadable with my vim configuration. It appears I am the only one having this problem. For an incomprehensible reason, a string constructs with qq/my string/; completely breaks the syntax color for all the rest of the file (~2300l). If I replace it with qq{my string}; all is fine! Test plan: launch git show HEAD and verify this patch won't break anything. Additionally, prove t/db_dependent/Reserves.t This will trigger the three functions that were modified. The prove currently fails on test 8, but the other succeeding tests prove that this change is fine. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 6 22:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Nov 2014 21:59:32 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #12 from M. Tompsett --- (In reply to M. Tompsett from comment #11) > The prove currently fails on test 8, but the other succeeding > tests prove that this change is fine. Oops. Test 11. Still, the change is good and worthy of QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:46:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:46:08 +0000 Subject: [Koha-bugs] [Bug 13216] New: fix koha-shell to work with git/dev installs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Bug ID: 13216 Summary: fix koha-shell to work with git/dev installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org koha-shell assumes PERL5LIB is '/usr/share/koha', which if often incorrect in a git/dev install this patch attempts to fix this issue, by using the correct path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:47:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:47:30 +0000 Subject: [Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #1 from Mason James --- (In reply to Mason James from comment #0) > koha-shell assumes PERL5LIB is '/usr/share/koha', which if often incorrect > in a git/dev install > > this patch attempts to fix this issue, by using the correct path oops, which *is* often incorrect in a git/dev install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:49:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:49:34 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #52 from M. Tompsett --- The removal of the prog theme broke this, specifically bug 13170. Bug 11912 and other related bugs which touched t/db_dependent/Biblio.t affected this as well. I'm working on a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:52:21 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33217|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 33352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33352&action=edit [SIGNED-OFF] Bug 13199: Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : /installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. Signed-off-by: Bernardo Gonzalez Kriegel Test works and identify missing notices A few koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:52:33 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33336|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 33353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33353&action=edit [SIGNED-OFF] Bug 13199: Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, test stop failing No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:53:14 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 33354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33354&action=edit Bug 13199: follow up to fix Licence and some koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:53:24 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #53 from M. Tompsett --- (In reply to M. Tompsett from comment #52) > Bug 11912 and other related bugs which touched > t/db_dependent/Biblio.t affected this as well. > I'm working on a rebase. Oops. Bug 12570, because it was t/Biblio.t :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:53:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:53:58 +0000 Subject: [Koha-bugs] [Bug 13217] New: fix koha-upgrade-schema to work with git/dev installs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Bug ID: 13217 Summary: fix koha-upgrade-schema to work with git/dev installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org koha-upgrade-schema seems to currently not work with git/dev koha-gitify installs this patch attempts to fix this issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:54:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:54:03 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 01:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 00:55:34 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 --- Comment #1 from Mason James --- here's an example of a failed attempt... # koha-create --create-db master # koha-gitify master /path/to/my/koha # apachectl restart # koha-upgrade-schema -v master Upgrading database schema for -v unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 373. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 373. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 373. Can't call method "config" on unblessed reference at /usr/share/koha/lib/C4/Context.pm line 796. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 02:06:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 01:06:59 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 --- Comment #2 from Mason James --- > # koha-upgrade-schema -v master > Upgrading database schema for -v oops, typo ^ root at xen1:~# sh -x /usr/sbin/koha-upgrade-schema master + set -e + update=/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl + echo Upgrading database schema for master Upgrading database schema for master + KOHA_CONF=/etc/koha/sites/master/koha-conf.xml PERL5LIB=/usr/share/koha/lib /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl this is a similar issue to 13216, where PERL5LIB is assumed be '/usr/share/koha' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 02:11:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 01:11:17 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32781|0 |1 is obsolete| | --- Comment #45 from Bernardo Gonzalez Kriegel --- Created attachment 33355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33355&action=edit [SIGNED-OFF] Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN --------- 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Image uploaded without problems No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 02:12:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 01:12:48 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com --- Comment #46 from Bernardo Gonzalez Kriegel --- First 4 patches were signed, I tested all and signed the last one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 04:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 03:31:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32382|0 |1 is obsolete| | --- Comment #54 from M. Tompsett --- Created attachment 33356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33356&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 04:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 03:32:07 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33356|0 |1 is obsolete| | --- Comment #55 from M. Tompsett --- Created attachment 33357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33357&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 04:32:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 03:32:15 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32383|0 |1 is obsolete| | --- Comment #56 from M. Tompsett --- Created attachment 33358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33358&action=edit Bug 11592 - MARC Visibility settings not respected The advanced constraints section while editing subfield structure for a particular MARC bibliographic framework allow the user to set visibility settings for OPAC and Intranet. These settings are not fully respected. This was first discovered while comparing the information displayed on the opac-MARCdetail and opac-detail pages. To this end, this patch will provide the ability to correct this problem across the board as desired, but will focus primarily on the OPAC interface. This was accomplished by adding 3 functions to C4/Biblio.pm: - ShouldDisplayOnInterface - ShouldHideMARC - GetFilteredBiblio And also by modifying GetMarcBiblio to filter or not based on parameter style and parameter values passed. ShouldDisplayOnInterface is a wrapper routine which just returns a hash of hashes which let us know if something is visible (1) or not (0 or undef) for a given interface (opac or intranet). This allows us to add/remove to the advance constraints section and then not have to update multiple routines to keep the filtering working properly, though if it is a drastic refactoring that would be necessary. ShouldHideMARC takes a field from marc_subfield_structure, and determines if it should be hidden. It does this for all the fields for a given framework code on a particular interface. If no framework code is given, the framework code used is the default one. If not interface is specified, OPAC is assumed. This routine returns a hash reference to the corresponding hash that was built. GetFilteredBiblio takes a MARC::Record, clones it, and then strips all the fields that should not be visible for a given framework code and interface. If no framework code is specied, it assumes the default one. If no interface is given, OPAC is assumed. The routine then returns the filtered record. GetMarcBiblio was modified to accept a hash style parameter. This allowed for filtering if the new convention was used, and no apparent change if the old convention is used. These functions allowed for filtering, but frequently there were problems with titles, subjects, etc. This required other tweaks. In C4/Biblio.pm, GetMarcSubjects was returning the subject, even it was supposed to be hidden. C4/XSLT.pm tried to replace a field with no field, rather than properly delete it. With the filtering being implemented based on the parameter style, it just required a minor tweak in opac-ISDBdetail to filter. The title needed to be purposefully not set if it was supposed to be hidden in opac-MARCdetail. However, opac-detail was interesting challenge. First, changing the parameter style did filtering, but the output still was leaking things which should be hidden. This is the main reason ShouldHideMARC was written, because there is an insidious little loop that runs through a set of keys and sets template parameters to values. Second, By skipping to the next key based on the hash ref returned by ShouldHideMARC, the template parameter is not set, and thus the value is properly hidden. Third, the subtitle was grabbed by GetRecordValue. This was refactored so filtering worked properly. Then opac-MARCdetail's 'view plain' was still showing details. This required converting the XML record to a MARC::Record, filtering it, and then converting it back. By tweaking opac-export and opac-showmarc to use the new parameter calling convention, records were filtered properly. And of course, with modifications and additions to C4/Biblio.pm, tests were required. t/Biblio.t has been modified to check the new function ShouldDisplayOnInterface. t/db_dependent/Biblio.t has also been modified. It confirms that both old and new calling conventions work. It also tests hiding the title field (200$a UNIMARC, 245$a MARC). It includes tests for ShouldHideMARC, GetFilteredBiblio, and GetMarcBiblio. TEST PLAN --------- 1) Back up your DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be mostly hidden as before until you... 13) Click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) perldoc C4::Biblio -- Look for ShouldHideMARC and confirm that the perldoc entries are okay. 17) prove -v t/Biblio.t -- 'Visibility values confirmed.' test should pass. 18) prove -v t/db_dependent/Biblio.t -- tests 26 through 41 should pass for UNIMARC and MARC21. It would be good to test this patch on both types of systems. 19) Refresh the opac-MARCdetail page. Title should hide now. 20) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 21) Click Normal view 22) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 23) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 24) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields do hide in 'MARC view', but not normal view. This patch does not deal with 952 fields. 25) Attempt to 'Save record' in a variety of types. -- Only unhidden fields should display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 04:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 03:32:35 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:15 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:17 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:19 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:21 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:49 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #13 from Katrin Fischer --- Created attachment 33359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33359&action=edit [PASSED QA] Bug 13199: Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : /installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. Signed-off-by: Bernardo Gonzalez Kriegel Test works and identify missing notices A few koha-qa errors fixed in followup Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:53 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #14 from Katrin Fischer --- Created attachment 33360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33360&action=edit [PASSED QA] Bug 13199: Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, test stop failing No koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:02:56 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #15 from Katrin Fischer --- Created attachment 33361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33361&action=edit [PASSED QA] Bug 13199: follow up to fix Licence and some koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:06:43 +0000 Subject: [Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #16 from Katrin Fischer --- Thx Frederic and Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:14:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:14:26 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:14:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:14:28 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:14:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:14:31 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:14:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:14:33 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:14:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:14:36 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:14:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:14:38 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:15:52 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #47 from Katrin Fischer --- Created attachment 33362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33362&action=edit [PASSED QA] Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:15:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:15:56 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #48 from Katrin Fischer --- Created attachment 33363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33363&action=edit [PASSED QA] Bug 9312: Perltidying picture-upload.pl Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:16:00 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #49 from Katrin Fischer --- Created attachment 33364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33364&action=edit [PASSED QA] Bug 9312: fix a couple more uninitialized variable warnings Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:16:03 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #50 from Katrin Fischer --- Created attachment 33365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33365&action=edit [PASSED QA] Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Sometimes our QA tools are pretty annoying, in cases like this, when its a tab in a comment, .. I don't think we really need to hold up a patch set for it Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 08:16:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 07:16:08 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #51 from Katrin Fischer --- Created attachment 33366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33366&action=edit [PASSED QA] Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN --------- 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Image uploaded without problems No koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 09:21:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 08:21:32 +0000 Subject: [Koha-bugs] [Bug 13218] New: usability enhancement for z39.50 search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Bug ID: 13218 Summary: usability enhancement for z39.50 search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The z39.50/SRU and authority search windows seem to be occasionally confusing for users. It seems that splitting the search fields into two columns suggests to librarians that they can either have a search from one column or the other - something that is simply untrue but that the interface seems to suggest. Additionally, when many z-targets are configured, there is considerable scrolling necessary to get to the search button. One of the goals of this page is to make cataloguing easier and faster, and scrolling takes extra time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 09:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 08:31:18 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #1 from Liz Rea --- Created attachment 33367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33367&action=edit Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 09:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 08:31:39 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |wizzyrea at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:33:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:33:24 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:33:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:33:24 +0000 Subject: [Koha-bugs] [Bug 13219] New: Add graphs to guided reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Bug ID: 13219 Summary: Add graphs to guided reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: chris at bigballofwax.co.nz, fridolyn.somers at biblibre.com, gmcharlt at gmail.com, julien.sicot at gmail.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, tomascohen at gmail.com, veron at veron.ch Depends on: 9915 Everybody likes a pretty graph ;) This patch adds the lightweight Charts.js javascript chart library and implements a couple of example charts on some guided reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:35:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:35:58 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #1 from Martin Renvoize --- Created attachment 33368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33368&action=edit Charts: Added Charts.js javascript charting library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:36:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:36:01 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #2 from Martin Renvoize --- Created attachment 33369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33369&action=edit Added Charts to issues report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:36:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:36:03 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #3 from Martin Renvoize --- Created attachment 33370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33370&action=edit Added color to charts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:36:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:36:06 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #4 from Martin Renvoize --- Created attachment 33371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33371&action=edit Added line/bar switch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 10:36:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 09:36:09 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #5 from Martin Renvoize --- Created attachment 33372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33372&action=edit Added graphs to cataloging report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 11:59:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 10:59:38 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #13 from Jonathan Druart --- (In reply to M. Tompsett from comment #12) > (In reply to M. Tompsett from comment #11) > > The prove currently fails on test 8, but the other succeeding > > tests prove that this change is fine. > > Oops. Test 11. Still, the change is good and worthy of QA. Looks good here: prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/50 Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line 42. C4::Context->userenv not defined! at C4/Branch.pm line 143. C4::Context->userenv not defined! at C4/Items.pm line 2305. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=50, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.60 cusr 0.04 csys = 1.66 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 12:18:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 11:18:24 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #8 from Jonathan Druart --- This is a quite sensitive bug and need to be fixed before the release. Since we don't have a clear and documented way to use DBIC in our Koha namespace, I preferred to use the old-way: C4 and DBI (and avoid discussion as on bug 12892). Moreover the Koha::Letter module does not exist yet and I tried to add as less changes as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 12:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 11:57:15 +0000 Subject: [Koha-bugs] [Bug 13220] New: Shipment date not saved when creating an invoice which has a duplicated number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Bug ID: 13220 Summary: Shipment date not saved when creating an invoice which has a duplicated number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org When creating an invoice which has a duplicated number, if the user chooses to 'Create new invoice anyway', previously entered shipment date (todays date by default) is not being saved, because the date value is passed to the script in the wrong format (acqui/parcels.pl expects shipmentdate parameter to be in the system-configured date format, but what it's getting in such cases is ISO-formatted date instead). As a consequence (when receiving orders from invoice whith empty shipment date) 'datereceived' field in order records are also not being populated. Here and there, Koha is using datereceived field to establish if the order was received or not received, so such not-quite-complete orders: - can be cancelled from the basket (even when they are de facto already received), - it's not possible to cancel receipt of those orders from the invoice (because Koha is considering them as not yet received). To reproduce: 1) Make sure you have some system date format configured in your test environment which is different from ISO format (e.g., DD/MM/YYYY) and the AcqWarnOnDuplicateInvoice syspref is enabled 2) Create some invoice with e.g. '11111' number, 3) Create another invoice with the same number (using 'Create new invoice anyway' button) 4) Try to create yet another invoice with the same number; observe that already existing invoice created in step 3) does have empty shipment date. 5) Optional: create some orders and receive them from the invoice with empty shipment date; observe that such orders are not being treated as received in all places (e.g. it's not possible to cancel receipts of such orders, and the message displayed is not in any way helpfull to determine why not). Note: empty shipment date field in invoice and/or order records may be not readilly apparent in some other places in the acquisitions module, e.g. on the order receive page, there is a date being displayed labeled as 'Received on: ', but this is not the value from the database, it's just today's date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 12:58:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 11:58:56 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 13:16:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 12:16:19 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 --- Comment #1 from Jacek Ablewicz --- Created attachment 33373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33373&action=edit Bug 13220 - Shipment date not saved when creating an invoice which has a duplicated number When creating an invoice which has a duplicated number, if the user chooses to 'Create new invoice anyway', previously entered shipment date (todays date by default) is not being saved, because the date value is passed to the script in the wrong format (acqui/parcels.pl expects shipmentdate parameter to be in the system-configured date format, but what it's getting in such cases is ISO-formatted date instead). As a consequence (when receiving orders from invoice whith empty shipment date) 'datereceived' field in order records are also not being populated. Here and there, Koha is using datereceived field to establish if the order was received or not received, so such not-quite-complete orders: - can be cancelled from the basket (even when they are de facto already received), - it's not possible to cancel receipt of those orders from the invoice (because Koha is considering them as not yet received). To reproduce: 1) Make sure you have some system date format configured in your test environment which is different from ISO format (e.g., DD/MM/YYYY) and the AcqWarnOnDuplicateInvoice syspref is enabled 2) Create some invoice with e.g. '11111' number, 3) Create another invoice with the same number (using 'Create new invoice anyway' button) 4) Try to create yet another invoice with the same number; observe that already existing invoice created in step 3) does have empty shipment date. 5) Optional: create some orders and receive them from the invoice with empty shipment date; observe that such orders are not being treated as received in all places (e.g. it's not possible to cancel receipts of such orders, and the message displayed is not in any way helpfull to determine why not). To test: 1) Apply patch 2) Retest 3) Ensure that the issue is no longer reproductible, and that there are no apparent regressions of any kind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 13:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 12:17:59 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 13:24:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 12:24:31 +0000 Subject: [Koha-bugs] [Bug 13154] The webinstaller should offer all available languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13154 --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Bernardo Gonzalez Kriegel from comment #1) > Web installer states: > > "Please pick your language from the following list. If your language is not > listed, please inform your systems administrator." > > Perhaps the message can be changed, suggesting a way > to add more languages before proceed. > > Bug 12017 adds proper description to "present" (i.e. installed) languages on > web installer. > > But to show a complete list without using database you will need a hardcoded > TT list of language codes, it's doable. > > An then a JS validity check for selected vs. present language. We could calculate everything on the .pl and let the page be a static one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 13:57:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 12:57:34 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Paola Rossi --- Hi, Jonathan, Katrin and Zeno. In my tests, one subscription about a serial ("IJoC") have been opened to the vendor "vendor12851". [My own email was set as the mailing address ("Email") of the vendor12851] Two issues (Vol.2014 No.11 and Suppl.11) of the subscription were in late, as I could see in the CSV file, selecting "Downloading selected claims": -------------------- SUPPLIER,TITLE,ISSUE NUMBER,LATE SINCE vendor12851,"International journal on Communication.","Vol. 2014, No. 11",11/06/2014 vendor12851,"International journal on Communication.","Suppl 11",11/06/2014 -------------------- A notice (of module "claimissues") was cloned to CPL. The cloned notice was: >From <> <> of <> Library: Dear <> The following issues are in late: Issue <> for serial: <> has not been received. -------------------------------------------- -------------------------------------------- I've applied the patch against master 3.17.00.046 HEAD 10582 I claimed the 2 late issues on Serials > Claims, by selecting "Send notification". The results in the received email were: >From of Centerville Library: Dear vendor12851 The following issues are in late: Issue for serial: International journal on Communication has not been received. Issue for serial: International journal on Communication has not been received. - - - - On the contrary, on master 3.17.00.046 HEAD 10582 I received this mail: >From of Centerville Library: Dear vendor12851 The following issues are in late: Issue Vol. 2014, No. 11 for serial: International journal on Communication. has not been received. >From of Centerville Library: Dear vendor12851 The following issues are in late: Issue Suppl 11 for serial: International journal on Communication. has not been received. - - - - ============================================================================== The tag ws not show anymore, as required, but the Serial.serialseq field was not shown anymore against master. I think this is an error. It occurred the same claiming for one issue only. And so I pass the patch to "Failed QA" status. Otherwise, if the noted difference is not a problem [or not related to this bug], I invite you to pass tha patch back to "Needs Sign Off", and I'll sign off the patch, thanks. ------------------------------------------------------------------------------ To test 12851 I saw at the bug 5342's test plan as indicated. I'm available for further tests on ACQ (for example about the ACQCLAIM' notice, which is used by ACQ > Late orders, and has a ""'s tag inside) and further cases of "multi-lines" orders-to-claim (a 2 books' order to claim to a vendor on ACQ). I thought to these 2 cases of "multi-lines" orders-to-claim to a vendor: - 2 late issues (1case already tested), - 2 late books (2case). Please suggest me any possible interesting other ones. Or other cases of <> to test inside the notices, thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 14:41:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 13:41:26 +0000 Subject: [Koha-bugs] [Bug 13221] New: Waiting holds information doesn't disappear from checkout page after hold is checked out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13221 Bug ID: 13221 Summary: Waiting holds information doesn't disappear from checkout page after hold is checked out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Because the checkout page doesn't refresh after checking out a hold, the information about the hold being waiting doesn't disappear from the page. If you combine this with not showing checkouts by default, the librarian has no way to know whether they successfully checked out the item on hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:24:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:24:28 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #9 from M. Tompsett --- Comment on attachment 33316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33316 Bug 13215: The same letter code can be used for several libraries Review of attachment 33316: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13215&attachment=33316) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +123,5 @@ > + FROM letter > + WHERE module = ? > + AND code = ? > + and branchcode = ? > + | http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL9:_SELECT Does SQL9 rule apply? @@ +163,5 @@ > + WHERE 1 > + | > + . q| AND branchcode = ''| > + . ( $module ? q| AND module = ?| : q|| ) > + . q| ORDER BY name|, { Slice => {} } Does SQL9 rule apply? @@ +177,5 @@ > + WHERE 1 > + | > + . q| AND branchcode = ?| > + . ( $module ? q| AND module = ?| : q|| ) > + . q| ORDER BY name|, { Slice => {} } Does SQL9 rule apply? @@ +264,5 @@ > + DELETE FROM letter > + WHERE branchcode = ? > + AND module = ? > + AND code = ? > + | . ( $mtt ? q| AND message_transport_type = ?| : q|| ) Does SQL9 rule apply? ::: t/db_dependent/Letters/GetLetterTemplates.t @@ +95,5 @@ > + }, > +]; > + > +my $sth = $dbh->prepare( > +q|INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) VALUES (?, ?, ?, ?, ?, ?, ?)| See SQL9 rule, I believe. ::: t/db_dependent/Letters/GetLettersAvailableForALibrary.t @@ +95,5 @@ > + }, > +]; > + > +my $sth = $dbh->prepare( > +q|INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) VALUES (?, ?, ?, ?, ?, ?, ?)| SQL9 rule, I believe. ::: tools/letter.pl @@ +115,4 @@ > delete_confirm($branchcode, $module, $code); > } > elsif ( $op eq 'delete_confirmed' ) { > + delete_confirmed($branchcode, $module, $code); mtt was removed, because it is never passed, correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:24:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:24:41 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #123 from Tom?s Cohen Arazi --- Created attachment 33374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33374&action=edit Bug 8836: (RM followup) unit tests should use the new API Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:26:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:26:41 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #124 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:32:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:32:30 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 33375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33375&action=edit Bug 13180 - Errors when acquiring from the new improved staged file, empty indicator warning, is flooding the gosh-darn out of my koha-error.log... Nice to have you back joubu! I get one warning for each mapped Koha items field. This patch fakes the missing indicators to the addorderiso2709.pl/.tt. Those indicators don't really exists for field 952 anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:33:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:33:10 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:34:22 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file, empty indicator warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Summary|Errors when acquiring from |Errors when acquiring from |the new improved staged |the new improved staged |file |file, empty indicator | |warning --- Comment #6 from Olli-Antti Kivilahti --- Fixed the indecent commit message. I am so sorry about that :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:36:33 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file, empty indicator warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 --- Comment #7 from Olli-Antti Kivilahti --- Maybe it would be best to just hard-code the indicator as ' ' in the addorderiso2709.pl instead of dragging it all the way from the templates? Smarter men can decide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:45:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:45:48 +0000 Subject: [Koha-bugs] [Bug 12829] Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:46:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:46:01 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #52 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:46:15 +0000 Subject: [Koha-bugs] [Bug 12760] add restrictions purge to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:46:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:46:47 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #44 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:49:24 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 33376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33376&action=edit Bug 13182 - When placing an order from a staged file, check for duplicates, display availability information. When making acquisitions from one staged file, by many branches as a joint effort, it is important to be able to make orders from the same import_record and to know how many Items have already been ordered. Also introduces misc/maintenance/matchAllStagedRecords.pl to recreate import_record matchings based on the given matcher. This places some extra requirements. 1. An status = 'imported' import_record needs to be shown in the stage_file so other branches can order from it as well. So we can't "hide" a import_record from the staged_file after an order is placed. 2. Having imported one import_record, that import_record must know it is matched to the just imported Biblio, so next acquirers know that it is already in our catalog. 3. We need to know which other branches have already ordered the item so we wont end up ordering too many copies of one Biblio to the consortium. Thus we color each row and show the count of Items in the current user's branch and the total amount of Items in the whole consortium. Additional tooltip listing of Item counts by Branch is displayed so we know are there any such Items near us. TEST PLAN: SETUP: 0a. Define a Matcher from admin/matching-rules.pl. We think good starting values are: Search index, Tag , score ISBN, 020a, 1000 Identifier-standard, 024a, 1000 Identifier-standard, 028a, 1000 Title, 245a, 500 Title-uniform, 240a, 500 Personal-name, 110a, 300 Corporate-name, 100a, 300 Matching threshold 800 You can use an existing matcher as well if you have it configured to other than ISBN. 0b. Stage a MARC file. BASIC USAGE: 1. Start making an order from a staged_file, stop when you see the import_records after you selected the batch to order from at acqui/addorderiso2709.pl?import_batch_id=50... 2. If you have matches, they are colored and the Item counts are visible. If not, order any item and return to the previous view and reload. 3. Observe that you should now have atleast one match. The match displays the amount of items in your branch, in your consortium, and a tooltip from the record title, showing a breakdown of items by branch. 4. When you add more orders, you get more order lines, but all orders are for the same Biblio, thus you don't get many Biblios for many orderlines. UNLEASH THE HOUNDS OF ACQUISITIONS: 1. Order a bunch of biblios and items for homebranch A. Make sure that you get the ordered orderlines in your basket. 2. Order a bunch of biblios and items for homebranch B. 3. Order a bunch of biblios and items for homebranch C. 4. Observe that the biblios already ordered into your catalogue are colored and a number is in front of the title. First number is the count of Items for this Biblio in user's logged-in-branch, second is the total number of Items in the catalogue. Hovering mouse pointer over the title displays a tooltip with a breakdown of all Items by homebranch. TODO: Unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:50:29 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33088|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:51:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:51:04 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:51:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:51:58 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 33377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33377&action=edit Bug 13182 - Overlay an existing Biblio with the acquired import_record If we know we already have a matching biblio in Koha, we can optionally overlay the existing Biblio with the new one. (We don't really need it but looks like Bg_12074 needs it). Also a good hook to attach more advanced automatic overlaying/transformation mechanisms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:57:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:57:21 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33377|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 33378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33378&action=edit Bug 13182 - Overlay an existing Biblio with the acquired import_record If we know we already have a matching biblio in Koha, we can optionally overlay the existing Biblio with the new one. (We don't really need it but looks like Bg_12074 needs it). TEST PLAN 1. Add Items to an order from a staged file. 2. Go and edit the newly added Biblio. Set the field 003 to "TEST ME GENTLY". 3. Add more Items for this same biblio from the same staged_file. 4. While selecting what to add, check the "Overlay?"-checkbox to replace the existing Bibliographic record with the import_record you are ordering. 5. Save the orderline selection. 6. Observe that the existing modified biblio has changed to it's latest revision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 15:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 14:59:30 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 33379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33379&action=edit Bug 13182 - Remove really dead code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:00:32 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Olli-Antti Kivilahti --- This feature is pending proper unit tests but looking forward to some feedback from the community. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:03:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:03:07 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #10 from Jonathan Druart --- (In reply to M. Tompsett from comment #9) > Comment on attachment 33316 [details] [review] > Bug 13215: The same letter code can be used for several libraries > Does SQL9 rule apply? Not sure this is used. Some queries are constructed dynamically, it's not possible to write them using the rules. For the test files, I used perltidy. > ::: tools/letter.pl > @@ +115,4 @@ > > delete_confirm($branchcode, $module, $code); > > } > > elsif ( $op eq 'delete_confirmed' ) { > > + delete_confirmed($branchcode, $module, $code); > > mtt was removed, because it is never passed, correct? Yes, it's not possible to delete only 1 template, all templates should be removed when a letter is removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:04:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:04:18 +0000 Subject: [Koha-bugs] [Bug 13222] New: Accessors for import_record.status have variable names suggesting overlay_status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Bug ID: 13222 Summary: Accessors for import_record.status have variable names suggesting overlay_status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org While trying to figure out what overlay_status is used for, noticed that SetImportRecordStatus() and GetImportRecordStatus() are named all wrong. Obviously sloppily copypasted from SetImportRecordOverlayStatus(); This minor patch adds some make-up to the codebase. While were at it, it would be nice to get some more extensive function documentation about what they are meant to do? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:04:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:04:39 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:08:34 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 33380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33380&action=edit Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status TODO:: Somebody who knows what these are about could write some documentation about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:08:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:08:58 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 16:35:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 15:35:37 +0000 Subject: [Koha-bugs] [Bug 13223] New: Plugin housekeeping: continued Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 Bug ID: 13223 Summary: Plugin housekeeping: continued Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 17:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 16:10:14 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: continued In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 17:10:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 16:10:17 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: continued In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #1 from M. de Rooy --- Created attachment 33381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33381&action=edit Bug 13223: Plugin housekeeping: do not redefine wrapper This report is connected to bug 10480 which will change the general mechanism of loading plugins, but can be tested independently and ahead of that proposed change. Several unimarc plugins use a wrapper sub. The code of this subroutine is not exactly the same for all plugins: in some cases the routine is extended for double character strings (dblspace and dblpipe). It would not hurt to use the extended code for all plugins. By moving the code to a module in the local dir, we prevent redefinition when two or more plugins are loading wrapper in a do-statement. NOTE: You will not see wrapper redefine errors in your log, since the plugins do not use the warnings pragma (yet). Since this patch touches seventeen unimarc plugins, a unimarc signoff is preferred :) Test plan: Use some plugins changed in this patch (if not in use already). Load the MARC editor. Click on some tag editor-buttons to check unchanged behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 17:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 16:10:47 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Summary|Plugin housekeeping: |Plugin housekeeping: do not |continued |redefine wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 17:58:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 16:58:12 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 17:58:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 16:58:12 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12398 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:00:52 +0000 Subject: [Koha-bugs] [Bug 12262] Searching patrons by extended attribute should be a search field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12262 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:01:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:01:39 +0000 Subject: [Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:08:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:08:35 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- Created attachment 33382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33382&action=edit Search dialog box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:08:55 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #3 from Fr?d?ric Demians --- Created attachment 33383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33383&action=edit Search result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:10:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:10:29 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #4 from Fr?d?ric Demians --- I like the new layout. But do you thing you could do something for the unsightly scroll bars that are displayed on search dialog box and search result page? It would be great to have dialog box sized properly to display all its content without scroll-bars. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:41:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:41:18 +0000 Subject: [Koha-bugs] [Bug 13224] New: use TOUT-UF8 base for z3950 BNF server Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Bug ID: 13224 Summary: use TOUT-UF8 base for z3950 BNF server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org For using z3950 BNF server with utf8 encoding, one must use "TOUT-UF8" base. See http://www.bnf.fr/fr/professionnels/recuperation_donnees_bnf_boite_outils/a.profil_z3950_bnf.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:47:21 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:47:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:47:25 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 --- Comment #1 from Fridolin SOMERS --- Created attachment 33384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33384&action=edit Bug 13224 - use TOUT-UF8 base for z3950 BNF server For using z3950 BNF server with utf8 encoding, one must use "TOUT-UF8" base. See http://www.bnf.fr/fr/professionnels/recuperation_donnees_bnf_boite_outils/a.profil_z3950_bnf.html Test plan : - create a fresh koha install : UNIMARC and fr-FR with optional z3950 servers - go to cataloguing - click on "New from Z39.50/SRU" - Perform searches on BNF2 => Check that encoding is correct - Choose a record and import => Check that encoding is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:47:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:47:48 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:53:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:53:52 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 18:53:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 17:53:55 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 33385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33385&action=edit [SIGNED-OFF] Bug 13224: use TOUT-UF8 base for z3950 BNF server For using z3950 BNF server with utf8 encoding, one must use "TOUT-UF8" base. See http://www.bnf.fr/fr/professionnels/recuperation_donnees_bnf_boite_outils/a.profil_z3950_bnf.html Test plan : - create a fresh koha install : UNIMARC and fr-FR with optional z3950 servers - go to cataloguing - click on "New from Z39.50/SRU" - Perform searches on BNF2 => Check that encoding is correct - Choose a record and import => Check that encoding is correct Signed-off-by: Tomas Cohen Arazi Trivial database field change, that reflects BnF recommended settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:04:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:04:57 +0000 Subject: [Koha-bugs] [Bug 13225] New: Z39.50 result Card View doesn't work for UNIMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Bug ID: 13225 Summary: Z39.50 result Card View doesn't work for UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To see the problem: - On an Unimrc Koha, go to Catalaging > New from Z39.50 - Do a search - On result page, click Card link on a biblio record - The Card View display nothing of interest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:06:08 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |12246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:06:08 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13200 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:13:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:13:26 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:13:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:13:28 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 --- Comment #1 from Fr?d?ric Demians --- Created attachment 33386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33386&action=edit Bug 13225 Z39.50 result Card View doesn't work for UNIMARC This patch fix UNIMARC Card View on Z39.50 result page. The valid XSL was there: UNIMARC_compact.xml, but were not selected (a regression). This patch use themelanguage to access XSL file, anticipating a intranet new theme in future. TO TEST: Before applying this patch, do a Z39.50 search, and try to display a biblio record card view: meaningless. Retry after applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:14:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:14:00 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:14:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:14:30 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 --- Comment #2 from Fr?d?ric Demians --- Created attachment 33387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33387&action=edit Card View Before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:14:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:14:50 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 --- Comment #3 from Fr?d?ric Demians --- Created attachment 33388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33388&action=edit Card View After -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:21:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:21:51 +0000 Subject: [Koha-bugs] [Bug 12979] Price formatting should only be defined at one place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:22:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:22:09 +0000 Subject: [Koha-bugs] [Bug 13200] Followup of Bug 12246 - noisy C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:22:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:22:34 +0000 Subject: [Koha-bugs] [Bug 13123] Duplicate label ids for language and opaclanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:23:05 +0000 Subject: [Koha-bugs] [Bug 13089] Tab key triggers JavaScript error in the checkEnter function In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13089 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:23:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:23:24 +0000 Subject: [Koha-bugs] [Bug 12334] Make it easier to hide parts of material type and format information in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12334 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:23:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:23:48 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:24:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:24:20 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Yohann and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 19:32:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 18:32:47 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 20:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 19:01:18 +0000 Subject: [Koha-bugs] [Bug 13226] New: Significant slowdown of checkins with fix for notices ignoring the dateformat preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Bug ID: 13226 Summary: Significant slowdown of checkins with fix for notices ignoring the dateformat preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I noticed that checkins were being processed very slowly and ran some tests. I found that before the patch for Bug 11244 checking in an item which is checked out to a restricted patron took around 2.5 seconds (as measured by Firebug's Net panel). After Bug 11244 the same type of checkin took over 50 seconds. Checking in an item which is checked out to a patron in good standing doesn't seem to be affected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 20:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 19:01:35 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13226 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 7 20:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Nov 2014 19:01:35 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11244 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 02:56:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 01:56:47 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #5 from Liz Rea --- Yep, will have a look at that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 03:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 02:15:47 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #6 from Liz Rea --- Hi Fr?d?ric, I think it's sensible to have a vertical scroll on the search results, you're right there shouldn't be one on the search page itself though. Does that seem sensible to you? Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 03:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 02:26:19 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33367|0 |1 is obsolete| | --- Comment #7 from Liz Rea --- Created attachment 33389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33389&action=edit Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 06:27:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 05:27:03 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33384|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 07:25:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 06:25:41 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 07:25:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 06:25:44 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33351|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 33390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33390&action=edit [PASSED QA] Bug 12792: C4::Reserves breaks my vim syntax color C4/Reserves.pm is unreadable with my vim configuration. It appears I am the only one having this problem. For an incomprehensible reason, a string constructs with qq/my string/; completely breaks the syntax color for all the rest of the file (~2300l). If I replace it with qq{my string}; all is fine! Test plan: launch git show HEAD and verify this patch won't break anything. Additionally, prove t/db_dependent/Reserves.t This will trigger the three functions that were modified. The prove currently fails on test 8, but the other succeeding tests prove that this change is fine. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer All tests pass on my installation. No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 07:28:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 06:28:34 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 07:28:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 06:28:37 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33385|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 33391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33391&action=edit [PASSED QA] Bug 13224: use TOUT-UF8 base for z3950 BNF server For using z3950 BNF server with utf8 encoding, one must use "TOUT-UF8" base. See http://www.bnf.fr/fr/professionnels/recuperation_donnees_bnf_boite_outils/a.profil_z3950_bnf.html Test plan : - create a fresh koha install : UNIMARC and fr-FR with optional z3950 servers - go to cataloguing - click on "New from Z39.50/SRU" - Perform searches on BNF2 => Check that encoding is correct - Choose a record and import => Check that encoding is correct Signed-off-by: Tomas Cohen Arazi Trivial database field change, that reflects BnF recommended settings. Signed-off-by: Katrin Fischer All instances have been changed. No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 11:06:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 10:06:34 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 14:55:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 13:55:07 +0000 Subject: [Koha-bugs] [Bug 12925] sys pref editor displays search terms with diacritics broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problem encoding characters |sys pref editor displays |in link "Back to results" |search terms with | |diacritics broken --- Comment #4 from Katrin Fischer --- The "back to results" problem was solved in bug 11515 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 16:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 15:12:20 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 8 20:36:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Nov 2014 19:36:16 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 02:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 01:56:49 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33386|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 33392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33392&action=edit Bug 13225 Z39.50 result Card View doesn't work for UNIMARC This patch fix UNIMARC Card View on Z39.50 result page. The valid XSL was there: UNIMARC_compact.xml, but were not selected (a regression). This patch use themelanguage to access XSL file, anticipating a intranet new theme in future. TO TEST: Before applying this patch, do a Z39.50 search, and try to display a biblio record card view: meaningless. Retry after applying this patch. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 02:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 01:56:46 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 09:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 08:32:35 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #20 from Fr?d?ric Demians --- It works well. This would be a good thing to have those XSL files in Koha. And at the first place, bug 6536 offers new interesting perspectives. But aren't this functionality (XSL transfo of z3950 search result) and those specific XSL files under-documented? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 09:43:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 08:43:47 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #8 from Fr?d?ric Demians --- (In reply to Liz Rea from comment #6) > I think it's sensible to have a vertical scroll on the search results, > you're right there shouldn't be one on the search page itself though. Yes, of course. My screenshot was pointing to the vertical scrollbar. That was an error. I was meaning that the horizontal scrollbar is superfluous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 09:44:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 08:44:18 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 09:44:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 08:44:20 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33389|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 33393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33393&action=edit Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. Signed-off-by: Frederic Demians Nice evolution of the z3950 search/result pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 11:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 10:58:20 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 11:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 10:58:22 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33392|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 33394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33394&action=edit [PASSED QA] Bug 13225 Z39.50 result Card View doesn't work for UNIMARC This patch fix UNIMARC Card View on Z39.50 result page. The valid XSL was there: UNIMARC_compact.xml, but were not selected (a regression). This patch use themelanguage to access XSL file, anticipating a intranet new theme in future. TO TEST: Before applying this patch, do a Z39.50 search, and try to display a biblio record card view: meaningless. Retry after applying this patch. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Tested in a UNIMARC installation, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 11:59:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 10:59:53 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 12:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 11:07:13 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Is this bug still valid with the reworked serials module? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 18:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 17:57:37 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #8 from Katrin Fischer --- *** Bug 12128 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 18:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 17:57:37 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- I think this patch got lost 'in discussion'. In the current pl file we got: total_gste => sprintf( "%.2f", $total_gste ), total_gsti => sprintf( "%.2f", $total_gsti ), total_gstvalue => sprintf( "%.2f", $total_gstvalue ), So the display problem no longer appears. I agree that the formatting should be in the template - Jonathan has worked on a TT plugin for currencies in acq that I think will do that. *** This bug has been marked as a duplicate of bug 12970 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 19:09:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 18:09:02 +0000 Subject: [Koha-bugs] [Bug 7480] authorisedbyname filled twice in neworderempty.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 19:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 18:08:55 +0000 Subject: [Koha-bugs] [Bug 7480] authorisedbyname filled twice in neworderempty.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Still valid, something for a small clean-up patch: authorisedbyname => $basket->{'authorisedbyname'}, closedate => $basket->{'closedate'}, # order details suggestionid => $suggestion->{suggestionid}, surnamesuggestedby => $suggestion->{surnamesuggestedby}, firstnamesuggestedby => $suggestion->{firstnamesuggestedby}, biblionumber => $biblionumber, uncertainprice => $data->{'uncertainprice'}, authorisedbyname => $borrower->{'firstname'} . " " . $borrower->{'surname'}, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 19:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 18:09:09 +0000 Subject: [Koha-bugs] [Bug 7480] authorisedbyname filled twice in neworderempty.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat at biblibre.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 19:13:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 18:13:07 +0000 Subject: [Koha-bugs] [Bug 7726] AllowItemsOnHoldCheckout has columns in wrong order in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #8 from Katrin Fischer --- This has been pushed to 3.8, we didn't get any complaints and it would only have affected people installing an unstable release for a short amount of tim - I am closing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 19:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 18:31:41 +0000 Subject: [Koha-bugs] [Bug 7865] Command line utility to BATCH load borrower pictures based on Cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Severity|trivial |enhancement --- Comment #2 from Katrin Fischer --- Looks like this got lost - I think it will need a bit of work to fit with our current coding guidelines, but moving it to 'needs signoff' for some testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 19:35:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 18:35:11 +0000 Subject: [Koha-bugs] [Bug 10071] language improvement for holds/transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:24:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:24:28 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:29:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:29:28 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:29:31 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 --- Comment #1 from Katrin Fischer --- Created attachment 33395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33395&action=edit Bug 10878: Correct Display856uAsImage pref description Removes note about Display856uAsImage not working on the OPAC result page. To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - check that the pref description makes sense and is correct - the warning about the pref not working on result pages has been removed - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result page in the bootstrap catalog. Note: The height=100 doesn't work in the Boostrap catalog, so the images display in their original size. Will file a separate bug for this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:29:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:29:58 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:34:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:34:13 +0000 Subject: [Koha-bugs] [Bug 13227] New: Display856uAsImage displays images in OPAC in original size Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Bug ID: 13227 Summary: Display856uAsImage displays images in OPAC in original size Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:36:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:36:39 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:36:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:36:41 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 --- Comment #1 from Katrin Fischer --- Created attachment 33396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33396&action=edit Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 22:39:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 21:39:45 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials desription misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 --- Comment #1 from Katrin Fischer --- Could we make the description... Manage/Don't manage routing lists in the serials module. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:01:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:01:57 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 --- Comment #1 from Katrin Fischer --- Created attachment 33397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33397&action=edit Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:02:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:02:29 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de Assignee|magnus at enger.priv.no |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:05:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:05:40 +0000 Subject: [Koha-bugs] [Bug 12440] Remove references to QueryRemoveStopWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12440 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This appears to be fixed - I can't find any references to QueryRemoveStopWords in the code base. Please reopen if you can :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:09:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:09:37 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master --- Comment #3 from Katrin Fischer --- It appears that there are some references to the borrow permission in the codebase, but I am not sure about the intended functionality either: Some examples: ... basket/basket.pl: flagsrequired => { borrow => 1 }, basket/downloadcart.pl: flagsrequired => { borrow => 1 }, basket/sendbasket.pl: flagsrequired => { borrow => 1 }, basket/sendbasket.pl: flagsrequired => { borrow => 1 }, ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:29:31 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #31 from Robin Sheat --- I bet it's a circular dependency. This might be problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:30:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:30:04 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 --- Comment #1 from Katrin Fischer --- Created attachment 33398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33398&action=edit Bug 12779: Capitalization on add/edit subscription form To test: - Add or edit a new or existing subscription in the serials module Patch changes "biblio" to "record" and fixes capitalization: Search for record | Create record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:30:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:30:28 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:31:35 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Very interesting! I assume that your patrons get "check in" emails? We don't do those kinds of emails so I never even thought about that happening... Amazing that it would go from 2.5 seconds to 50 seconds though :S. That's much much higher than the worst time we recorded for generating overdues. Olli-Antti Kivilahti processed 12 messages in 31 seconds. I processed 35 messages in 31 seconds. Astounding that it would be 1 message in 50 seconds. I suppose that regex would be running over every single replaceable field. Does your check in message have a lot of fields to replace with database data? I'm not sure how to fix this one. The regex idea seemed like the best way of dealing with the dateformat issue in notices :S. I thought about using DBIC to check what type of field we were using, but you can't do that because many table names don't translate to DBIC resultset names. DBIC is pretty slow too though, so I don't know. I'm fresh out of ideas on this one :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:32:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:32:10 +0000 Subject: [Koha-bugs] [Bug 9177] Duplicate patron: Prepopulated fields ar cleared when setting cursor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- It feels like unexpected behaviour to me - might be more irritating than helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:34:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:34:04 +0000 Subject: [Koha-bugs] [Bug 12500] In opac-detail-view, "Browse results" shows indexes from the beginning upon hovering over the last index. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I restested and it's still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:35:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:35:28 +0000 Subject: [Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:37:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:37:45 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #3 from Robin Sheat --- Sent 5 days, 6 hours, and 39 minutes ago: Could you take a look at bug 7904 possibly.. I'd be interested to hear your view on how it may affect packages. There'll be a minor change needed, but that's OK, it's a worthwhile fix. I'll make a patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:39:59 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:40:12 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:40:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:40:14 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29174|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 33399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33399&action=edit [SIGNED OFF] 3.15.00.049 is about Bug 5377, not 11268 Fixes the description and bug reference. http://bugs.koha-community.org/show_bug.cgi?id=12466 Signed-off-by: Katrin Fischer Fixes the description on the old update database entry, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:42:03 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #4 from Robin Sheat --- Created attachment 33400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33400&action=edit Bug 7904 - remove unnecessary path from SIP script With the fixing of the namespace in the SIP code, we don't need to modify the PERL5LIB to have the old one. To test: * do a package install using this and the other patches on bug 7904 * enable SIP * make sure koha-start-sip and koha-stop-sip work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:47:43 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #5 from Robin Sheat --- I haven't actually tested this myself (catching up on everything after a week away), so I'm hoping that it's simple enough that it just works. If I get time later today/this week... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:51:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:51:12 +0000 Subject: [Koha-bugs] [Bug 12486] Appendix G (Resetting the Koha Database) using DELETE instead of TRUNCATE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- reads ok to me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 9 23:52:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 22:52:38 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #32 from Robin Sheat --- (In reply to Jonathan Druart from comment #30) > Created attachment 33183 [details] [review] > Bug 11998: QA follow-up - fix the perlcritic error > > % perlcritic C4/Context.pm > Variable declared in conditional statement at line 544, column 5. > Declare variables outside of the condition. (Severity: 5) So I was wondering what purpose this change solves, turns out it can be important: my $var if condition is a messy construct that doesn't do quite what you expect if condition is true, then $var is created in the current scope and gets cleaned up when the scope ends but if condition is not true, then $var does not get created at runtime and instead, the $var that was inferred at compile time is used instead it ends up being a file-scoped global that persists a value ahh that's a bit of a nasty side-effect :p actually, it's not a file-scoped global it's a lexical and the sub is a closure over that lexical the thing about 'my' is that it has compile-time and run-time effects and in this instance the run-time effects only get to happen if condition is true historical note: this bug/feature was how people used to do state variables before the 'state' keyword existed heh specifically: my $state_variable = 0 if 0; there should be a word for that "fug" perhaps it's certainly fugly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:02:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:02:52 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 --- Comment #1 from Katrin Fischer --- Created attachment 33401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33401&action=edit Bug 13133: Fix mangled titles on pay fines page Titles with diacritics don't show correctly on the 'pay fines' page in the patron account in staff. To test: - Catalog or find a record with non-latin script Something like a word in Hebrew would work. - Create a fine entry for that record Something like a rental fee works. - Verify that the title doesn't display correct on the pay fine page (other tabs are ok) - Apply patch - Check the pages again - display should be correct now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:03:17 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:09:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:09:58 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 --- Comment #1 from Katrin Fischer --- Created attachment 33402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33402&action=edit Bug 13207: "Branch" on basket summary page should be "Library" To test: - Create or find an open basket/order in the acquisition module - Check that "Branch" now reads "library" - Set to "no library" - No branches should be seen there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:10:14 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:12:36 +0000 Subject: [Koha-bugs] [Bug 13076] Spelling error on permissions - paramters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- This appears to be fixed, current installations read: parameters Manage Koha system settings (Administration panel) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:22:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:22:32 +0000 Subject: [Koha-bugs] [Bug 9819] stopwords related code should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #15 from Katrin Fischer --- It looks like we got stuck on this... but would be a nice clean-up? :) Some of the code seems to have been removed since - patches don't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:23:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:23:08 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #21 from David Cook --- (In reply to Fr?d?ric Demians from comment #20) > It works well. This would be a good thing to have those XSL files in Koha. > And at the first place, bug 6536 offers new interesting perspectives. But > aren't this functionality (XSL transfo of z3950 search result) and those > specific XSL files under-documented? I'm definitely in favour of Tomas's patch using bug 6536. I think this makes a lot of sense. I also agree about the XSL files being under-documented. I'll add some suggestions in splinter review. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:30:27 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #22 from David Cook --- Comment on attachment 33177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33177 Bug 6681: introduce XSLT scripts to remove items and links Review of attachment 33177: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6681&attachment=33177) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/xslt/Del952.xsl @@ +1,5 @@ > + + xmlns:xsl="http://www.w3.org/1999/XSL/Transform" > + xmlns:marc="http://www.loc.gov/MARC21/slim" > + version="1.0"> > + @@ +4,5 @@ > + version="1.0"> > + > + > + > + This template matches datafields with the 952 tag. As it provides no specific instructions for how to output this input, the datafield will be deleted from the output. @@ +6,5 @@ > + > + > + > + > + The following template is an "Identity Transform" which will copy all attributes and nodes from the input to the output. Without this template, the output will just be a text document with no XML tags. ::: koha-tmpl/intranet-tmpl/prog/en/xslt/Del995.xsl @@ +1,5 @@ > + + xmlns:xsl="http://www.w3.org/1999/XSL/Transform" > + xmlns:marc="http://www.loc.gov/MARC21/slim" > + version="1.0"> > + @@ +4,5 @@ > + version="1.0"> > + > + > + > + This template matches datafields with the 995 tag. As it provides no specific instructions for how to output this input, the datafield will be deleted from the output. @@ +6,5 @@ > + > + > + > + > + The following template is an "Identity Transform" which will copy all attributes and nodes from the input to the output. Without this template, the output will just be a text document with no XML tags. ::: koha-tmpl/intranet-tmpl/prog/en/xslt/Del9LinksExcept952.xsl @@ +1,4 @@ > + + xmlns:xsl="http://www.w3.org/1999/XSL/Transform" > + xmlns:marc="http://www.loc.gov/MARC21/slim" > + version="1.0"> @@ +4,5 @@ > + version="1.0"> > + > + > + > + The following template is an "Identity Transform" which will copy all attributes and nodes from the input to the output. Without this template, the output will just be a text document with no XML tags. @@ +10,5 @@ > + > + > + > + > + The following template will match every datafield which contains a subfield with a code of 9, except those datafields that have a tag of 952. Since it has no output instructions, this datafield will be deleted from the output. It's important to delete the subfield with a code of 9, since this subfield contains links to authority records, which will most likely not link correctly in Koha when importing from Z39.50. ::: koha-tmpl/intranet-tmpl/prog/en/xslt/Del9LinksExcept995.xsl @@ +1,5 @@ > + + xmlns:xsl="http://www.w3.org/1999/XSL/Transform" > + xmlns:marc="http://www.loc.gov/MARC21/slim" > + version="1.0"> > + @@ +4,5 @@ > + version="1.0"> > + > + > + > + The following template is an "Identity Transform" which will copy all attributes and nodes from the input to the output. Without this template, the output will just be a text document with no XML tags. @@ +10,5 @@ > + > + > + > + > + The following template will match every datafield which contains a subfield with a code of 9, except those datafields that have a tag of 995. Since it has no output instructions, this datafield will be deleted from the output. It's important to delete the subfield with a code of 9, since this subfield contains links to authority records, which will most likely not link correctly in Koha when importing from Z39.50. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:30:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:30:37 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #12 from Katrin Fischer --- Would be nice to see this fixed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:34:39 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:36:40 +0000 Subject: [Koha-bugs] [Bug 10772] IE7 not loading reset-fonts-grids.css in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10772 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from David Cook --- I don't know if this is necessary anymore. If this hasn't come up in a year, it's probably fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:38:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:38:27 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:40:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:40:11 +0000 Subject: [Koha-bugs] [Bug 8618] Z3950 is not processing CCL Queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618 --- Comment #2 from David Cook --- This one is kind of interesting... If you click "Z3950 search" in the staff client search results, and you've done any sort of search other than a basic keyword search, it's never going to work as it will include CCL prefixes. We probably shouldn't show the "Z3950 search" option when doing anything other than a basic keyword search, but that would involve additional detection... So this is a problem... but not a huge one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 00:44:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Nov 2014 23:44:03 +0000 Subject: [Koha-bugs] [Bug 9405] Error in french PO for OPAC (3.10) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- This does seem ok in current versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:08:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:08:19 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #1 from Katrin Fischer --- Still valid on current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:09:36 +0000 Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think if we remove the option to delete it, we would also have to make it mandatory in the web installer. But not sure we should as long as it doesn't seem to cause problems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:11:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:11:01 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:18:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:18:00 +0000 Subject: [Koha-bugs] [Bug 10207] can't renew if holds waiting to be triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11634 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:18:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:18:00 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #40 from Katrin Fischer --- *** Bug 10207 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:20:15 +0000 Subject: [Koha-bugs] [Bug 7171] Use Modern::Perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |MOVED --- Comment #2 from Katrin Fischer --- We are slowly switching to use Modern::Perl and it's mandatory for new scripts, so I think closing this 'unused' omnibus is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:20:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:20:16 +0000 Subject: [Koha-bugs] [Bug 7119] general code-cleaning, tidy/whitespace omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 7171, which changed state. Bug 7171 Summary: Use Modern::Perl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7171 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:23:36 +0000 Subject: [Koha-bugs] [Bug 10882] Link tracking on results pages only works with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- We officially deprecated the non-XSLT views - so I feel this is a WONTFIX now. Feel free to reopen if you want to provide a patch for older versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:25:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:25:02 +0000 Subject: [Koha-bugs] [Bug 11110] remove useless stopword table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9819 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:25:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:25:02 +0000 Subject: [Koha-bugs] [Bug 9819] stopwords related code should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #16 from Katrin Fischer --- *** Bug 11110 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:48:55 +0000 Subject: [Koha-bugs] [Bug 10882] Link tracking on results pages only works with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10882 --- Comment #2 from Liz Rea --- Yep, seems like an ok outcome to me. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 01:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 00:52:33 +0000 Subject: [Koha-bugs] [Bug 7119] general code-cleaning, tidy/whitespace omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 04:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 03:04:40 +0000 Subject: [Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532 --- Comment #2 from Robin Sheat --- This looks useful, my only concern is that if the provided backup dir doesn't exist, it should probably fail hard rather than falling back to the one in the config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:38:07 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33396|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 33403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33403&action=edit Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:38:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:38:04 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:40:09 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:40:12 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33401|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 33404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33404&action=edit Bug 13133: Fix mangled titles on pay fines page Titles with diacritics don't show correctly on the 'pay fines' page in the patron account in staff. To test: - Catalog or find a record with non-latin script Something like a word in Hebrew would work. - Create a fine entry for that record Something like a rental fee works. - Verify that the title doesn't display correct on the pay fine page (other tabs are ok) - Apply patch - Check the pages again - display should be correct now. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:42:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:42:00 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:42:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:42:02 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33397|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 33405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33405&action=edit Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:44:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:44:23 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 06:44:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 05:44:26 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33395|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 33406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33406&action=edit Bug 10878: Correct Display856uAsImage pref description Removes note about Display856uAsImage not working on the OPAC result page. To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - check that the pref description makes sense and is correct - the warning about the pref not working on result pages has been removed - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result page in the bootstrap catalog. Note: The height=100 doesn't work in the Boostrap catalog, so the images display in their original size. Will file a separate bug for this. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 08:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 07:17:47 +0000 Subject: [Koha-bugs] [Bug 7503] OPAC fails WCAG 2.0 AA testing / search input field has no label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC fails WCAG 2.0 AA |OPAC fails WCAG 2.0 AA |testing |testing / search input | |field has no label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 08:19:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 07:19:53 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I have the same problem, haven't been able to tell which plugin it is yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:02:26 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33177|0 |1 is obsolete| | --- Comment #23 from M. de Rooy --- Created attachment 33407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33407&action=edit Bug 6681: introduce XSLT scripts to remove items and links This patch adds the following sample files: - Del952.xsl - Del995.xsl - Del9LinksExcept952.xsl - Del9LinksExcept995.xsl Thay can be used on the new SRU/Z39.50 XSLT processing feature. At the same time they can be used to solve this bug. To test: - Have an SRU/Z39.50 target configured - Have a search that returns at least a record with the following properties: * It contains $9 links * It contains items (952 or 995 fields in MARC21/NORMARC and UNIMARC respectively). MARC21/NORMARC test: - Do a Z39.50/SRU cataloguing search that retrieves the desired record - Verify it includes $9 and 952 field(s) by clicking on the MARC link - Edit your Z39.50 target and add Del952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view of the imported record doesn't contain the 952 field - Edit your Z39.50 target and add Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view contains the 952 field (including the $9 subfield), and all other $9 subfields have been removed - Edit your Z39.50 target and add Del952.xsl, Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field (both, comma separated) - Re-run the search => SUCCESS: the MARC view doesn't contain $9 subfields nor items. - Repeat for UNIMARC, replacing 952 for 995. - Sign off :-D Regards Tomas Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Marcel de Rooy Tested under MARC21. Works fine. (Additionally verified 995 with xsltproc.) As noted on Bugzilla, we could still improve documentation but imo no need to block these example transformations. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:02:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:02:57 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:03:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:03:21 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:24:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:24:24 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:32:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:32:59 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:33:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:33:01 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33405|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 33408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33408&action=edit Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:33:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:33:04 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 --- Comment #4 from M. de Rooy --- Created attachment 33409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33409&action=edit Bug 12264: [QA Follow-up] Fixing biblionumber/biblioitemnumber mixup While testing the string change on 12264, I had this result: DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. # Child (GetItemsInfo tests) exited without calling finalize() not ok 4 - GetItemsInfo tests This was caused by this line in the unit test: my $biblionumber = get_biblio(); This routine returns: return ($bibnum, $bibitemnum); So instead of the bibnum the bibitemnum is saved in biblionumber. In my test database bibnum and bibitemnum somehow got out of sync, revealing this bug :) The fix is just adding parentheses: my ( $biblionumber ) = get_biblio(); Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:33:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:33:16 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 09:53:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 08:53:49 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33407|0 |1 is obsolete| | --- Comment #24 from Fr?d?ric Demians --- Created attachment 33410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33410&action=edit Bug 6681: introduce XSLT scripts to remove items and links This patch adds the following sample files: - Del952.xsl - Del995.xsl - Del9LinksExcept952.xsl - Del9LinksExcept995.xsl Thay can be used on the new SRU/Z39.50 XSLT processing feature. At the same time they can be used to solve this bug. To test: - Have an SRU/Z39.50 target configured - Have a search that returns at least a record with the following properties: * It contains $9 links * It contains items (952 or 995 fields in MARC21/NORMARC and UNIMARC respectively). MARC21/NORMARC test: - Do a Z39.50/SRU cataloguing search that retrieves the desired record - Verify it includes $9 and 952 field(s) by clicking on the MARC link - Edit your Z39.50 target and add Del952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view of the imported record doesn't contain the 952 field - Edit your Z39.50 target and add Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view contains the 952 field (including the $9 subfield), and all other $9 subfields have been removed - Edit your Z39.50 target and add Del952.xsl, Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field (both, comma separated) - Re-run the search => SUCCESS: the MARC view doesn't contain $9 subfields nor items. - Repeat for UNIMARC, replacing 952 for 995. - Sign off :-D Regards Tomas Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Marcel de Rooy Tested under MARC21. Works fine. (Additionally verified 995 with xsltproc.) As noted on Bugzilla, we could still improve documentation but imo no need to block these example transformations. Signed-off-by: Frederic Demians I can't resist to put my own signature on this patch, confirming it works as described with z39.50 Unimarc targets. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:00:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:00:13 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- (In reply to David Cook from comment #1) > I suppose that regex would be running over every single replaceable field. > Does your check in message have a lot of fields to replace with database > data? Yes, could you give a copy of the template letter used? I have the default one (installer/data/mysql/en/mandatory/sample_notices.sql), I manually added a restriction to a patron, checkin, and it took the same time as before (I didn't measured precisely but not 50sec). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:00:44 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 --- Comment #1 from Katrin Fischer --- Created attachment 33411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33411&action=edit Bug 12059: Publisher column on invoice page always empty This patch moves the publisher information out of its own always empty column into the Summary column below the title, as it is on other acq pages. The information was never displaying, as publishercode is in biblioitems and that table was not selected by GetInvoiceDetails. Also modified the code to take into account that UNIMARC uses biblioitems.publicationyear and MARC21/NORMARC use bibio.copyrightdate for the copyright year. To test: - create an invoice for records that - have a publication year - have no publication year - have a publisher... - 'finish receiving' and check the invoice summary page ...acqui/invoice.pl?invoiceid=? - Make sure all the information displays now but didn't witout the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:01:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:01:28 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:02:56 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 --- Comment #2 from Katrin Fischer --- There are tests for GetInvoiceDetails in t/Aquisisions... and t/db_dependent/... - I am not sure if more testing is needed for the new table and how the test should look like. Leaving the patch here as I don't know when I can get back to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:08:20 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:08:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:08:22 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 --- Comment #3 from M. de Rooy --- Created attachment 33412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33412&action=edit 3.15.00.049 is about Bug 5377, not 11268 Fixes the description and bug reference. http://bugs.koha-community.org/show_bug.cgi?id=12466 Signed-off-by: Katrin Fischer Fixes the description on the old update database entry, no problems found. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:11:19 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:53:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:53:34 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 --- Comment #1 from Jonathan Druart --- Created attachment 33413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33413&action=edit Bug 12905: funds with children could not be deleted The interface should prevent to delete funds with children. Otherwise the relationship is broken and problems occur: 1/ You don't see the orphan fund in the fund list 2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent allocation'). This patch: - adds a JS check, template side - adds a check in the perl script (should never be true) - adds an updatedatabase check, in order to alert users with inconsistent data. Test plan: Verify you are not allow to delete a fund with children. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:54:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:54:04 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:54:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:54:51 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Jonathan Druart --- *** Bug 4292 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:54:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:54:51 +0000 Subject: [Koha-bugs] [Bug 4292] deleting a budget leaves funds orphaned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- Patch submitted on bug 12905. *** This bug has been marked as a duplicate of bug 12905 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 10:55:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 09:55:33 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:25:14 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #16 from Jonathan Druart --- I am not confident with the last patch. I have a fix for the issue you raised, but it will certainly introduce regression somewhere else. I would prefer to keep the first patch, even if it is not the best way to do, it is the one which will induce the fewer side-effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:25:18 +0000 Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching for a borrower to add to a routing list don't work correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Katrin Fischer --- This is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:25:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:25:42 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33264|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:25:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:25:45 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31276|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:26:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:26:06 +0000 Subject: [Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:28:39 +0000 Subject: [Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Katrin Fischer --- 3.12 will be out of maintenance very soon, I am closing this bug report. But please reopen if there is still an interest in this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:38:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:38:03 +0000 Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching for a borrower to add to a routing list don't work correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513 --- Comment #9 from Jonathan Druart --- Bug 13021 and bug 12648 use the member search webservice. When they will be pushed, maybe this one will be easy to implement using the same way. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:40:45 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 --- Comment #2 from Katrin Fischer --- Created attachment 33414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33414&action=edit Bug 7988: Make note on authorized values page less confusing Nicole suggested a change of the note, that this patch is implementing: NOTE: If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately. To test: - Go to administration > authorised values - Check the note showing on the page - Select a category from the pull down and edit an existing entry - Check the note on this page is also correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:41:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:41:52 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de Assignee|paul.poulain at biblibre.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:44:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:44:07 +0000 Subject: [Koha-bugs] [Bug 8142] Unhighlight option breaks keywords highlighted in staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8142 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- I tested it on current master and I can also not reproduce the problem. Closing WORKSFORME, please reopen if you still see this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:46:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:46:06 +0000 Subject: [Koha-bugs] [Bug 8096] card number twice on patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Still valid in the new patron search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:49:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:49:27 +0000 Subject: [Koha-bugs] [Bug 11444] Punctuation and space not displaying for Author (Marc 1XX/7XX) headings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- 710 has been fixed by bug 12465. *** This bug has been marked as a duplicate of bug 12877 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:49:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:49:27 +0000 Subject: [Koha-bugs] [Bug 12877] 110 needs spaces in XSLT display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imingchan at yahoo.com.au --- Comment #1 from Katrin Fischer --- *** Bug 11444 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 11:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 10:54:49 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |jonathan.druart at biblibre.co | |m --- Comment #17 from Jonathan Druart --- Bug 11708 rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 12:03:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 11:03:59 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #26 from Magnus Enger --- When I apply the two patches on this bug to master and try to run the tests, I get this: $ sudo koha-shell -c "prove t/db_dependent/Calendar.t" kohadev t/db_dependent/Calendar.t .. Undefined subroutine &main::ModRepeatingEvent called at t/db_dependent/Calendar.t line 22. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Calendar.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/14 subtests Test Summary Report ------------------- t/db_dependent/Calendar.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 0. Files=1, Tests=0, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.13 cusr 0.01 csys = 0.16 CPU) Result: FAIL The calendar page in the intranet seems to work as it should. Other db_dependent tests do pass... I cannot for the life of me understand what is happening here, and it does not seem to happen for others, so I am just leaving this as a note, without changing the status of the bug. Holidays.t also fails: $ sudo koha-shell -c "prove t/db_dependent/Holidays.t" kohadev t/db_dependent/Holidays.t .. 1/6 # Failed test 'Sunday is a closed day' # at t/db_dependent/Holidays.t line 44. # got: '0' # expected: '1' # Failed test 'Christmas is a closed day' # at t/db_dependent/Holidays.t line 46. # got: '0' # expected: '1' # Failed test 'New Years day is a closed day' # at t/db_dependent/Holidays.t line 47. # got: '0' # expected: '1' # Looks like you failed 3 tests of 6. t/db_dependent/Holidays.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/6 subtests Test Summary Report ------------------- t/db_dependent/Holidays.t (Wstat: 768 Tests: 6 Failed: 3) Failed tests: 3, 5-6 Non-zero exit status: 3 Files=1, Tests=6, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.18 cusr 0.02 csys = 0.23 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 12:50:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 11:50:08 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #45 from Jonathan Druart --- The updatedb entry refers to bug 11169. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 13:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 12:46:38 +0000 Subject: [Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 13:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 12:48:12 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #27 from Magnus Enger --- Created attachment 33415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33415&action=edit Dates are not sorted properly I added dates covering several months in a row, and the dates are not sorted properly, when the format is dd/mm/yyyy. See attached screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 13:57:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 12:57:44 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #32 from Magnus Enger --- I get an error when I try to apply the patches: $ git bz apply 8133 Bug 8133 - hourly loans doesn't know when library closed 32985 - Bug 8133 - hourly loans doesn't know when library closed 32986 - Bug 8133 [QA Followup] - Fix koha-qa.pl violations 32991 - Bug 8133 [QA Followup 2] - Fix unit tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8133 - hourly loans doesn't know when library closed /home/vagrant/kohaclone/.git/rebase-apply/patch:62: trailing whitespace. }, { Slice => {} }, $branchcode ); /home/vagrant/kohaclone/.git/rebase-apply/patch:314: trailing whitespace. }, 'weekday', { Slice => {} }, $branch ); /home/vagrant/kohaclone/.git/rebase-apply/patch:399: trailing whitespace. if ( $self->{days_mode} eq 'Calendar' ) { /home/vagrant/kohaclone/.git/rebase-apply/patch:429: trailing whitespace. if ( $self->{days_mode} eq 'Calendar' ) { /home/vagrant/kohaclone/.git/rebase-apply/patch:595: trailing whitespace. warning: squelched 36 whitespace errors warning: 41 lines add whitespace errors. Using index info to reconstruct a base tree... :62: trailing whitespace. }, { Slice => {} }, $branchcode ); :314: trailing whitespace. }, 'weekday', { Slice => {} }, $branch ); :399: trailing whitespace. if ( $self->{days_mode} eq 'Calendar' ) { :429: trailing whitespace. if ( $self->{days_mode} eq 'Calendar' ) { :595: trailing whitespace. warning: squelched 36 whitespace errors warning: 41 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/calendar.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Circulation.pm Applying: Bug 8133 [QA Followup] - Fix koha-qa.pl violations fatal: sha1 information is lacking or useless (C4/Calendar.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8133 [QA Followup] - Fix koha-qa.pl violations When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8133-QA-Followup---Fix-koha-qapl-violations-admQOe.patch But I did get some weirdness when running the tests from bug 11211 (see bug 11211 comment 26), so perhaps there is something about my setup that is borken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:10:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:10:32 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- Good initiative. Shouldn't you put your module in C4 (C4::Utils) directory, rather than in plugin directory itself? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:15:47 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:15:51 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32634|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 33416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33416&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:15:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:15:58 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #48 from Jonathan Druart --- Created attachment 33417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33417&action=edit Bug 13019: (follow-up) Remove smartmatch operator This patch also adds 1 test. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:16:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:16:20 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32068|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 33418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33418&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t Signed-off-by: Jonathan Druart http://bugs.koha-community.org/show_bug.cgi?id=10363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:17:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:17:18 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:17:22 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33418|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 33419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33419&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:17:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:17:27 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #23 from Jonathan Druart --- Created attachment 33420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33420&action=edit Bug 13019: (follow-up) Remove smartmatch operator This patch also adds 1 test. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:18:15 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33417|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:18:20 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33416|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:18:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:18:31 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32634|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:21:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:21:44 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:21:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:21:46 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #1 from M. de Rooy --- Created attachment 33421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33421&action=edit Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:22:06 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32634|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart --- Created attachment 33422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33422&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:22:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:22:24 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #50 from Jonathan Druart --- Created attachment 33423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33423&action=edit Bug 10363: Use Koha::AuthorisedValue[s] in the admin page Now we have packages, we need use them in the pl script. Test plan: Verify there are no regression on addind/editing/deleting authorised values. Done forget to test the branch limitation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:22:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:22:28 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:22:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:22:53 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #51 from Jonathan Druart --- (In reply to Jonathan Druart from comment #50) > Created attachment 33423 [details] [review] > Bug 10363: Use Koha::AuthorisedValue[s] in the admin page Kyle, Can I get you signoff on this patch please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:25:29 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #2 from M. de Rooy --- Forgot deletedborrowers..please wait -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:34:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:34:12 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33421|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 33424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33424&action=edit Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:38:37 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #3 from M. de Rooy --- (In reply to Fr?d?ric Demians from comment #2) > Good initiative. Shouldn't you put your module in C4 (C4::Utils) directory, > rather than in plugin directory itself? Hi Frederic, I thought of that, but its use seems to be so connected to these plugins that I did not move it away from them. Do you prefer to have them there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:45:15 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #33 from Magnus Enger --- (In reply to Magnus Enger from comment #32) > I get an error when I try to apply the patches: Sorry for not being clear about this: it happens when I apply the patches from bug 8133 on top of the patches from bug 11211. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:51:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:51:00 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #3 from Owen Leonard --- (In reply to Jonathan Druart from comment #2) > Yes, could you give a copy of the template letter used? I have the default one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 14:51:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 13:51:20 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #24 from M. de Rooy --- (In reply to Jonathan Druart from comment #23) Jonathan, Any thoughts on comments 18 and 19? Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 15:20:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 14:20:53 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 15:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 14:20:57 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 33425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33425&action=edit Bug 6681: (qa followup) document the existence of the sample files As requestedby people testing the patch, I add references to the new xslt files on the Z39.50/SRU servers help. Example usages are also provided. Test: - Apply the patch - Go to the help page on the 'Z39.50/SRU Servers' page => SUCCESS: Notice there's a section documenting XSLT file(s) usage and provides some examples that cover the introduced files. - Sign off Thanks Tomas Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 15:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 14:32:09 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #4 from Jonathan Druart --- Created attachment 33426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33426&action=edit time checkin Owen, could you execute this script like: time perl time_checkin.pl and give me the result please? Before, fill the $barcode_to_checkin and $branchcode variable with correct values. I would like to be sure the 50sec are spent in this subroutine. Here it spent 1sec. I check an item out to a patron, enable the CHECKIN notice for this patron and add a restriction on it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 15:48:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 14:48:18 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #25 from Jonathan Druart --- (In reply to M. de Rooy from comment #24) > (In reply to Jonathan Druart from comment #23) > Jonathan, > Any thoughts on comments 18 and 19? As Martin said, this is the first step to get modules in Koha using DBIC with a common way. It will allow developers to easily instantiate objects in pl script. We already discussed about the abstraction layer and I agree with it. Moreover Kyle fixed/implemented my concerns (comments 2 and 4). > Is the idea now to allow DBIC methods ONLY in Koha::Object and Objects? This > is currently not achieved if you need to pass in a resultset. > Do we enforce its use in order to prevent chaos? This means creating a lot > of new modules rightaway.. Yes of course. We will only add methods in Koha::Object[s] if needed and make sense. Create 1 module per class in the Koha namespace is the logical consequence of this patch, it's not a problem. > Having new and new_from_dbic was qualified above somewhere as a good idea. > Why? The first implementation of the constructor was uselessly complicated. I believe this will add readability. We already iterated several times with Kyle and other peoples involved, now it's the time to see something pushed and go further. It's always possible to improve this code later if it doesn't match our needs or cause problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:00:16 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #4 from Fr?d?ric Demians --- > I thought of that, but its use seems to be so connected to these plugins > that I did not move it away from them. Do you prefer to have them there? Yes. I understand your reasoning. Except in misc/translator, I don't see any directory other than 'Koha' or 'C4' containing module files. We can imagine scenario in the future where Koha libraries could be searched differently than with PERL5LIB environment variable. Another point: You module need a copyright, I suppose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:01:48 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33399|0 |1 is obsolete| | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:02:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:02:08 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nicolas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:02:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:02:32 +0000 Subject: [Koha-bugs] [Bug 13225] Z39.50 result Card View doesn't work for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13225 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:02:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:02:46 +0000 Subject: [Koha-bugs] [Bug 13224] use TOUT-UF8 base for z3950 BNF server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13224 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:03:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:03:06 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Amit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:03:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:03:36 +0000 Subject: [Koha-bugs] [Bug 12264] Tiny typo in t/db_dependent/Items.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrin and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:09:09 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:09:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:09:13 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33425|0 |1 is obsolete| | --- Comment #26 from Fr?d?ric Demians --- Created attachment 33427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33427&action=edit Bug 6681: (qa followup) document the existence of the sample files As requestedby people testing the patch, I add references to the new xslt files on the Z39.50/SRU servers help. Example usages are also provided. Test: - Apply the patch - Go to the help page on the 'Z39.50/SRU Servers' page => SUCCESS: Notice there's a section documenting XSLT file(s) usage and provides some examples that cover the introduced files. - Sign off Thanks Tomas Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Frederic Demians Help page does shed some light to the XSLT usage. Enough to my taste. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:10:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:10:44 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- Kyle, please provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:13:34 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #27 from Fr?d?ric Demians --- For the future, a better way for storing XSL could be designed. In the disorder: - a z3950severs table new field, - a new db table for XSL, - a centralized repository, - a link to a Koha community page (like for SQL report library). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:23:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:23:27 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31557|0 |1 is obsolete| | Attachment #31558|0 |1 is obsolete| | Attachment #31559|0 |1 is obsolete| | Attachment #31560|0 |1 is obsolete| | Attachment #31561|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart --- Created attachment 33428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33428&action=edit Bug 9043: Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. Signed-off-by: Koha Team Lyon 3 Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:23:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:23:32 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #79 from Jonathan Druart --- Created attachment 33429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33429&action=edit Bug 9043: Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:23:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:23:38 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #80 from Jonathan Druart --- Created attachment 33430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33430&action=edit Bug 9043: Add the multiple select jquery plugin Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:23:43 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #81 from Jonathan Druart --- Created attachment 33431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33431&action=edit Bug 9043: Make strings translatable Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:23:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:23:48 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #82 from Jonathan Druart --- Created attachment 33432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33432&action=edit Bug 9043 [QA Followup] - Don't show "More options" are there aren't any Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:37:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:37:37 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 --- Comment #10 from Koha Team Lyon 3 --- We just need to find time to check ... I'll also take a look at Bug 13181 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:37:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:37:46 +0000 Subject: [Koha-bugs] [Bug 13181] Using Matchers to overlay existing biblios with incoming records. Make MARC transformations on need. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13181 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:54:57 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:54:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:54:59 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33194|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 33433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33433&action=edit Bug 13189 - Patron card creator patron search browse by last name broken by extended attributes The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! Test Plan: 1) Enable extended patron attributes 2) Add a new searchable patron attribute 3) Create a new patron with the last name "Ace" 4) Add the value "D" to the attribute for this patron 5) Browse to the patron card maker, start a new patron batch 6) Click "Add item(s)" to bring up the patron search 7) Click the letter "D" in the patron search box 8) Note that "Ace" shows in the results list 9) Apply this patch 10) Repeat step 7 11) Note that "Ace" no longer shows in the results list 12) Perform a regular search by putting the letter "D" in the "Name:" field, and hit the "Search" button 13) Note this time the results *do* have Ace in them Signed-off-by: Frederic Demians Well described for a tricky bug. Reproducible. Fixed with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:56:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:56:44 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #83 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! Nice addition! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:56:49 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 --- Comment #46 from Tom?s Cohen Arazi --- Created attachment 33434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33434&action=edit Bug 12448: (RM followup) fix bug number in updatedatabase.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:57:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:57:11 +0000 Subject: [Koha-bugs] [Bug 12692] Markup improvements to holds awaiting pickup report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 16:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 15:57:36 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #22 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:26:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:26:24 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33424|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 33435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33435&action=edit Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. updatedatabase.pl did not apply. I edited and then run it. Columns were added as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:26:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:26:54 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:40:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:40:42 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33414|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 33436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33436&action=edit Bug 7988: Make note on authorized values page less confusing Nicole suggested a change of the note, that this patch is implementing: NOTE: If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately. To test: - Go to administration > authorised values - Check the note showing on the page - Select a category from the pull down and edit an existing entry - Check the note on this page is also correct Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:42:04 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:51:59 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33398|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 33437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33437&action=edit Bug 12779: Capitalization on add/edit subscription form To test: - Add or edit a new or existing subscription in the serials module Patch changes "biblio" to "record" and fixes capitalization: Search for record | Create record Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:52:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:52:32 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:52:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:52:49 +0000 Subject: [Koha-bugs] [Bug 12750] koha-create should be able to configure SRU server for the created instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12750 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 18:52:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 17:52:52 +0000 Subject: [Koha-bugs] [Bug 12750] koha-create should be able to configure SRU server for the created instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12750 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30735|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 33438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33438&action=edit Bug 12750: koha-create should be able to configure the Z39.50/SRU server This patch adds two parameters to the koha-create command: --enable-sru: makes the koha-create script enabled the SRU server for the created instance --sru-port: lets the user specify a desired port for the SRU server to listen at. It defaults to 7090 To test: - Apply the patch on top of master - Build your own package and install / can be tested just using the koha-create command on a 3.16+ packages install - Create an instance as usual (i.e. without --enable-sru and --sru-port) => SUCCESS: The instance is created, the publicserver sections are both commented out. The first publicserver section has 7090 set as the listening port. - Create an instance as usual, passing --sru-port 456 => SUCCESS: The instance is created, the port is set but the publicserver sections are commented out - Create an instance with --enable-sru (with and without --sru-port) => SUCCESS: Verify the instance is created as expected, with the SRU server enabled (port 7090 if no --sru-port passed, the one we chose otherwise). - Verify that the docs also talk about this new parameters addition. - Sign off :-D Regards To+ Edit: added references to the Z39.50 as asked by Magnus. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 19:22:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 18:22:49 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #33 from Tom?s Cohen Arazi --- Is it possible that we strip the C4::Log circular dependency out for now? We could even think of a proper Koha::SystemPreferences class to move this functions to in a short term (post-release). But we definitely need the bugfix, and logging syspref changes could wait if needed (it is actually logged by the /svc/config/systempref.... service). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 19:58:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 18:58:02 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #5 from Owen Leonard --- > time perl time_checkin.pl > and give me the result please? real 0m51.725s user 0m50.347s sys 0m0.468s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:25:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:25:31 +0000 Subject: [Koha-bugs] [Bug 12359] hidepatronname doesn't hide on the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I have a patch for this, but I am not sure if we should make the change. The pref description seems to not include the holds report pages: Show/Don't show the names of patrons that have items checked out or on hold on detail pages or the "Place Hold" screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:28:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:28:25 +0000 Subject: [Koha-bugs] [Bug 12359] hidepatronname doesn't hide on the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 --- Comment #2 from Katrin Fischer --- Created attachment 33439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33439&action=edit Bug 12359: Add HidePatronName functionality to the holds queue This changes the Holds Queue page to not show the patron's name and phone number, but only the cardnumber, when HidePatronName is set to 'Don't show' This also changes the link to the patron account to use the borrowernumber instead of the cardnumber, which seems more consistent. Fixes a tiny capitalization error: Only item... To test: - Look at the holds queue page with holds displayed - Toggle HidePatronName system preference and observe the change - Make sure the link works correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:28:55 +0000 Subject: [Koha-bugs] [Bug 12359] hidepatronname doesn't hide on the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Setting in discussion to get some feedback about the suggested change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:32:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:32:14 +0000 Subject: [Koha-bugs] [Bug 5732] Adding permissions on viewlog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5732 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |enhancement --- Comment #2 from Katrin Fischer --- Not sure this is still being worked on, but sounds like an enh, not a bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:38:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:38:25 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 --- Comment #3 from Katrin Fischer --- Created attachment 33440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33440&action=edit Bug 10136: Remove outdated translation tool docs Patch removes outdated translation tool documentation from the misc/translator directory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:39:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:39:00 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Component|I18N/L10N |Documentation Assignee|koha-bugs at lists.koha-commun |nengard at gmail.com |ity.org | QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:50:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:50:46 +0000 Subject: [Koha-bugs] [Bug 13228] New: Documentation of 'restrictions' tab does not show "OVERDUE" restriction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13228 Bug ID: 13228 Summary: Documentation of 'restrictions' tab does not show "OVERDUE" restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The patron information documentation: http://manual.koha-community.org/3.16/en/patroninformation.html at section 9.2.1. Circulation Summary Says "The Restrictions tab will show for all patrons. If the patron has no restrictions you will see that on the tab." ... "If the patron has restrictions on their account the tab will show the number and the description." There is no discussion of 'OVERDUE' restrictions, or the fact that this restriction may be automatically removed if the overdue items are checked back in if the AutoRemoveOverduesRestrictions system preference is set to "[Do] allow OVERDUES restrictions triggered by sent notices to be cleared automatically when all overdue items are returned by a patron." It is also unclear from the documentation what is being restricted: * Are checkouts restricted? [presumably] * Are renewals restricted? * If renewals are restricted, how does this interact with AutoRemoveOverduesRestrictions? Are renewals restricted except when AutoRemoveOverduesRestrictions is set to "Do"? It may be that this would be better documented in http://manual.koha-community.org/3.16/en/administration.html#globalsysprefs 1.5.2.11. AutoRemoveOverduesRestrictions but there should at least be a link from the documentation of the restrictions tab to documentation of that syspref. It would probably also be helpful to point to http://manual.koha-community.org/3.16/en/tools.html#noticetriggers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:56:49 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 --- Comment #4 from Katrin Fischer --- Created attachment 33441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33441&action=edit Bug 10749: Fix typo in budget_add_del permission Updates the en permission file and adds a database update to fix the permisson. The update is done using the description, to not untranslate non-English permission descriptions. To test: - Run the database update on your existing installation and check the typo is gone - Run the web installer and check there are no errors and permissions are loaded correctly (and without typos) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:56:46 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 20:57:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 19:57:30 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:32:50 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:39:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:39:34 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:39:37 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 --- Comment #1 from Katrin Fischer --- Created attachment 33442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33442&action=edit Bug 12567: Make catalog statistics wizard publication year work for MARC21 Publication year was useless for MARC21, as it was using the biblioitems.publicationyear (UNIMARC) instead of biblio.copyrightdate (MARC21). This patch tries to fix the search options to work for both MARC flavours. To test: In Reports > Statistics wizards > Catalog: - Test the publication year search options on a UNIMARC and a MARC21 installation. - Make sure search results make sense for both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:39:51 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Please test well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:46:42 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close and confirm reopen JavaScript alerts do not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 --- Comment #2 from Katrin Fischer --- Ok, I misunderstood - this is about baskets in acquisitions. If you try to reopen a basket, a javascript alert is triggered. But when you close a basket, there is a non-javascript alert. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:50:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:50:52 +0000 Subject: [Koha-bugs] [Bug 8540] Several staff client scripts which do not require authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8540 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:54:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:54:34 +0000 Subject: [Koha-bugs] [Bug 4176] MIME missing from sys prefs interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4176 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- Appears to be fixed - I cannot find references to the old sys pref in the code base and the preferenece has been removed in a database update: $DBversion = "3.02.00.001"; if (C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do(q{DELETE FROM systempreferences WHERE variable IN ( 'holdCancelLength', 'PINESISBN', 'sortbynonfiling', 'TemplateEncoding', 'OPACSubscriptionDisplay', 'OPACDisplayExtendedSubInfo', 'OAI-PMH:Set', 'OAI-PMH:Subset', 'libraryAddress', 'kohaspsuggest', 'OrderPdfTemplate', 'marc', 'acquisitions', 'MIME') } -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 22:59:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 21:59:03 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Jeremie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33402|0 |1 is obsolete| | --- Comment #2 from Jeremie --- Created attachment 33443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33443&action=edit Bug 13207: "Branch" on basket summary page should be "Library" To test: - Create or find an open basket/order in the acquisition module - Check that "Branch" now reads "library" - Set to "no library" - No branches should be seen there. Signed-off-by: jeremie.benarros -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:00:45 +0000 Subject: [Koha-bugs] [Bug 12414] Late orders display showing non-late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- I have tested the late order filters on current master and they seem to be working correctly. I think what you see is that the default is order date "0 days ago" - which will display all open orders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:02:56 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Jeremie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jeremie.benarros at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:11:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:11:06 +0000 Subject: [Koha-bugs] [Bug 5896] Approved comments don't go into pending approval list after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- Works alright on current master and 3.16.2, I am closing the bug report. Please reopen if you want to provide a fix for earlier maintained versions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:13:20 +0000 Subject: [Koha-bugs] [Bug 12449] Routing list tab and Suggestions tab disappear In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- This appears to be fixed now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:18:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:18:44 +0000 Subject: [Koha-bugs] [Bug 13229] New: Suggestion date filters have a style problem Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Bug ID: 13229 Summary: Suggestion date filters have a style problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 33444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33444&action=edit Screenshot The date related filters on the suggestion page don't look quite right/as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:20:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:20:54 +0000 Subject: [Koha-bugs] [Bug 12384] The Suggested by list and Managed by list do not filter the names. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12384 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- This appears to be working correctly now in current master. Please reopen if you still see the problem and maybe provide a screenshot of the problem or a 'step by step' on how to see it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:23:43 +0000 Subject: [Koha-bugs] [Bug 12400] Serial receiving should show claimed issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I just tested this on master and claimed issues now show up on the serial receive page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:32:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:32:08 +0000 Subject: [Koha-bugs] [Bug 7995] upload patron images permission needed to upload offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- I checked this on current master - all offlince-circulation related files have "circulate_remaining_permissions" as required flag. I think this has been fixed: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=5880522ea74e803e41a5efab88dca0efb66f4358 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:32:09 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #28 from David Cook --- (In reply to Fr?d?ric Demians from comment #27) > For the future, a better way for storing XSL could be designed. In the > disorder: - a z3950severs table new field, - a new db table for XSL, - a > centralized repository, - a link to a Koha community page (like for SQL > report library). I've been thinking about this for a little while as well. I've been working again on an OAI harvester which uses XSLTs to filter out the 952, 999, and $9, and I figure "koha-tmpl\intranet-tmpl\prog\en\xslt" isn't always the best place to put these things. I'm intrigued by the idea of using a db field or db table. If we allowed uploads, that would make it easier for libraries to add their own XSLTs (for better or worse) without meddling around on the file system. Actually, a db table could be interesting. We could have the blob, the filename, an id... and then have a db field in z3950servers (or whatever other server config table) that has a foreign key to the primary key id in the XSLT table. I'd kind of like the ability to set defaults as well though... so you could set up XSLT profiles to apply on import (rather than having a string of filenames). Of course, we'd probably need a linking table then for profiles to files. I think that'd be a good way to go about setting up defaults though. You could have a "Default Z3950" profile (and maybe a "Default OAI" table). -- Actually, as I work on this OAI client, I start thinking about ways to integrate code and storage of Z3950 and OAI targets. I'm trying to think if there are other protocols we use for importing records as well... and how instead of making more tables, we could make some tables more generic. I wonder too about using XSLTs when importing records via the batch import, although that would probably slow things down a lot as you'd be going from Iso Marc to Marc Object to MARCXML to XSLT to MARCXML. I suppose I like the idea of making storage and code more generalizable... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:34:08 +0000 Subject: [Koha-bugs] [Bug 13086] Adding a suggestion with the same title as an existing suggestion fails quietly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13086 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Looks like I already reported this in 2013. *** This bug has been marked as a duplicate of bug 10752 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:34:08 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #1 from Katrin Fischer --- *** Bug 13086 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:37:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:37:44 +0000 Subject: [Koha-bugs] [Bug 12179] Serial claims: No alert when vendor has no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Has been fixed as part of 5342. *** This bug has been marked as a duplicate of bug 5342 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:37:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:37:44 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #81 from Katrin Fischer --- *** Bug 12179 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:40:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:40:26 +0000 Subject: [Koha-bugs] [Bug 10738] date does not displayed in fine slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- The date appears correctly on the fine slips I checked. Closing this - please reopen if you still see this problem and include more information on how to reproduce the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:43:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:43:34 +0000 Subject: [Koha-bugs] [Bug 12217] Funds not matching up In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Nicole, on my system it adds all up - can you still see this problem? What does the oder look like? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:44:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:44:36 +0000 Subject: [Koha-bugs] [Bug 11303] Add to Cart doesn't work in pro > MARC biblio view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Works on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:45:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:45:59 +0000 Subject: [Koha-bugs] [Bug 12984] Improvement of the funds list view - acqui home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #16 from Katrin Fischer --- *** Bug 12360 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:45:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:45:59 +0000 Subject: [Koha-bugs] [Bug 12360] funds not showing right on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12984 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:47:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:47:47 +0000 Subject: [Koha-bugs] [Bug 8908] Starman/Plack hangs when faced with zombie Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |12173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:47:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:47:47 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8908 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:49:31 +0000 Subject: [Koha-bugs] [Bug 9225] Subroutines should not be defined in acqui/parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |12173 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:49:31 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9225 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 10 23:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 22:58:22 +0000 Subject: [Koha-bugs] [Bug 5985] Can edit parent fund amount to be below amount allocated to child funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Incorrect date in budgets |Can edit parent fund amount |and failed to edit funds |to be below amount |children |allocated to child funds --- Comment #1 from Katrin Fischer --- Almost completely fixed - the only thing I can reprodocue is 3.1: It's possible to edit a parent fund to be below the amount allocated to the child. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 00:28:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 23:28:51 +0000 Subject: [Koha-bugs] [Bug 9225] Subroutines should not be defined in acqui/parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12173 Depends on|12173 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 00:28:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 23:28:51 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Blocks|8908, 9225 | Depends on| |8908, 9225 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 00:28:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 23:28:51 +0000 Subject: [Koha-bugs] [Bug 8908] Starman/Plack hangs when faced with zombie Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12173 Depends on|12173 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 00:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 23:34:28 +0000 Subject: [Koha-bugs] [Bug 8249] can't add extra issues to prediction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 00:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 23:40:09 +0000 Subject: [Koha-bugs] [Bug 11305] Patrons with hundreds of checkouts cause extreme slowdown In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Kyle, is this fixed with the ajax checkout table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 00:53:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Nov 2014 23:53:37 +0000 Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- I think the situation you describe, that the biblioitems.itypes don't match the itemtypes.itemtype list is a non-standard configuration that is potentially problematic in a lot of places. I think dividing them would need a lot more work and thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 01:09:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 00:09:59 +0000 Subject: [Koha-bugs] [Bug 6962] Fund list not showing encumberance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- The funds page now shows: - allocated - ordered - spent - available So all good. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 01:21:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 00:21:51 +0000 Subject: [Koha-bugs] [Bug 12773] Branch transfer limits show codes instead of descriptions (item types/collections) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 01:30:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 00:30:14 +0000 Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching for a borrower to add to a routing list don't work correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513 --- Comment #10 from Robin Sheat --- Erg, which I'd noticed this earlier, it would have been very easy to slap a 'LIMIT 20' or something onto the SQL. However now it probably doesn't apply. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 01:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 00:31:39 +0000 Subject: [Koha-bugs] [Bug 8866] Plack - remove unneeded dbh->disconnects OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8866 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #2 from Mason James --- (In reply to Robin Sheat from comment #1) > Is there any more detail to this? A very quick search: > > $ ack 'dbh->disconn' > > shows no hits on master. this bug was intended to track bugs described in 8379 it does seem these bugs have been resolved now, so this bug can be closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 01:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 00:40:33 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 02:32:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 01:32:34 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 02:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 01:32:29 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 02:32:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 01:32:37 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:16:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:16:34 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 --- Comment #12 from Robin Sheat --- Created attachment 33445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33445&action=edit Bug 12234 - dependency updates for master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:16:51 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:16:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:16:57 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:17:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:17:04 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:17:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:17:10 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:17:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:17:42 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 --- Comment #13 from Robin Sheat --- I'm just going to reuse this bug until it gets too noisy, unless that's a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:31:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:31:13 +0000 Subject: [Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #17 from Robin Sheat --- (In reply to Katrin Fischer from comment #14) > Created attachment 32696 [details] [review] > [PASSED QA] Bug 12995 - script update_totalissues.pl stops on corrupted > record - UT > > This patch adds an unit test on C4::Biblio::UpdateTotalIssues method > call on non existing record > > Signed-off-by: Owen Leonard > I can't comment on the correctness of the test other than to say it ran > successfully. > > Signed-off-by: Katrin Fischer > Improves CLI script, works as described. > > Note: A small improvement would be to output the problematic biblionumber. This patch causes the package builds to fail, as it requires a database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:44:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:44:40 +0000 Subject: [Koha-bugs] [Bug 13230] New: Bug 12995 causes test case failures Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Bug ID: 13230 Summary: Bug 12995 causes test case failures Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /tmp/buildd/koha-3.17~git+20141111151957.e234e2b0/blib/PERL_MODULE_DIR/C4/Context.pm line 785. # Looks like you planned 44 tests but ran 42. # Looks like your test exited with 255 just after 42. t/Biblio.t .......................... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/44 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 03:45:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 02:45:26 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 04:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 03:07:16 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 04:07:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 03:07:19 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 33446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33446&action=edit Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 04:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 03:26:19 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 04:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 03:26:23 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #34 from Robin Sheat --- Created attachment 33447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33447&action=edit Bug 11998 - fix compile warnings This creates a simplified logging system that can be used by C4::Context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 05:07:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 04:07:55 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 05:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 04:07:58 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33446|0 |1 is obsolete| | --- Comment #2 from Robin Sheat --- Created attachment 33448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33448&action=edit Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat Sponsored-by: Wanting the darn packages to build -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 06:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 05:39:05 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 06:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 05:39:05 +0000 Subject: [Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13230 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 06:54:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 05:54:14 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33448|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 33449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33449&action=edit Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat Sponsored-by: Wanting the darn packages to build Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 07:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 06:16:28 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #7 from Tiburce Euphrasie --- (In reply to Fr?d?ric Demians from comment #6) > (In reply to Tiburce Euphrasie from comment #5) > > Aloha! [...] > Your assumption is not correct. The function can't transform your ISBN-13 > into > ISBN-10, because it begins with '979'. Rather than returning undef to say > that > the conversion is not possible, the function was failing badly, stopping > completely the Perl process. That's what is corrected by the patch. > > Have you tried the patch? Does it solve the bug reported here? Can you import > your record? Is your ISBN field preserved? For both records? [...] Aloha, Yes, it works, I tried it on a Koha 3.16.03 and there's no problem : I can import both records, I can find them and the ISBN are preserved. Thank you again for patching this bug, I can't test it on the master branch for now but it works perfectly for me. Aloha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 07:55:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 06:55:42 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 07:55:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 06:55:44 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33449|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 33450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33450&action=edit [PASSED QA] Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat Sponsored-by: Wanting the darn packages to build Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Sponsored-by: Not wanting to read in my maths book -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 07:57:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 06:57:07 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 08:12:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 07:12:21 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33433|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 33451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33451&action=edit [PASSED QA] Bug 13189 - Patron card creator patron search browse by last name broken by extended attributes The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! Test Plan: 1) Enable extended patron attributes 2) Add a new searchable patron attribute 3) Create a new patron with the last name "Ace" 4) Add the value "D" to the attribute for this patron 5) Browse to the patron card maker, start a new patron batch 6) Click "Add item(s)" to bring up the patron search 7) Click the letter "D" in the patron search box 8) Note that "Ace" shows in the results list 9) Apply this patch 10) Repeat step 7 11) Note that "Ace" no longer shows in the results list 12) Perform a regular search by putting the letter "D" in the "Name:" field, and hit the "Search" button 13) Note this time the results *do* have Ace in them Signed-off-by: Frederic Demians Well described for a tricky bug. Reproducible. Fixed with this patch. Signed-off-by: Katrin Fischer This works as described, no problems or regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 08:14:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 07:14:39 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 --- Comment #4 from Katrin Fischer --- As this changes the search routinges in Member.pm, I'd feel better with a regression test here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 08:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 07:22:05 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #6 from Katrin Fischer --- Please add a test plan to make this easier to test! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 09:43:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 08:43:45 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #21 from Chris Cormack --- Conflict CONFLICT (content): Merge conflict in C4/Circulation.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 09:43:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 08:43:57 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 09:44:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 08:44:00 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33440|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 33452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33452&action=edit Bug 10136: Remove outdated translation tool docs Patch removes outdated translation tool documentation from the misc/translator directory. Signed-off-by: Magnus Enger Removing these lines sounds like a good idea. I tested by applying the patch and checking that the files in question are gone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 10:00:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 09:00:04 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Looks good to me... though your patches are full of tabs cait ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 10:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 09:04:17 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 10:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 09:04:19 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33442|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 33453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33453&action=edit [Signed Off] Bug 12567: Make catalog statistics wizard publication year work for MARC21 Publication year was useless for MARC21, as it was using the biblioitems.publicationyear (UNIMARC) instead of biblio.copyrightdate (MARC21). This patch tries to fix the search options to work for both MARC flavours. To test: In Reports > Statistics wizards > Catalog: - Test the publication year search options on a UNIMARC and a MARC21 installation. - Make sure search results make sense for both. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 10:04:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 09:04:56 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 --- Comment #5 from Martin Renvoize --- Works well for me, fixed tab issues and signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 10:14:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 09:14:46 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #29 from Katrin Fischer --- I think as the initial feature is already pushed, having examples for what you can do with it is a good start - but more documentation is of course always better :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 10:37:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 09:37:58 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #7 from Martin Renvoize --- Lol.. it's a bit of a proof of concept at the minute so I hadn't gotten around to a test plan.. Sorry ;) Test Plan: Pre patches, there won't be any graphs anywhere ;) Post patches, Run through 'Statistics Wizards -> Circulation', you should now get a pretty graph as part of the result. Run through 'Statistics Wizards -> Catalog', you shold now get a pretty graph as part of the result. It's a proof of concept for now really. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 11:14:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 10:14:18 +0000 Subject: [Koha-bugs] [Bug 13231] New: ISBD/AACR2 punctuation causes double facets Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Bug ID: 13231 Summary: ISBD/AACR2 punctuation causes double facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org Created attachment 33454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33454&action=edit Naively remove ISBD punctuation from facets Using MARC21, assume the following in one biblio: 100 1 $aFoo, $ewriter. And this in another biblio: 100 1 $aFoo. This produces double facets, one of "Foo," and another for "Foo." - It should just use one facet, "Foo" Attached is a quick hack to achieve this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 12:47:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 11:47:54 +0000 Subject: [Koha-bugs] [Bug 12486] Appendix G (Resetting the Koha Database) using DELETE instead of TRUNCATE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12486 --- Comment #4 from Pablo AB --- To me too :) JFTR, been strict ?DELETE FROM biblio;? not always do the task straightforward, in some scenarios you should remove first some dependencies (sadly, I don't now exactly whats.. if item is borrowed?). PS: Same with bug #12488. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:38:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:38:04 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #22 from Benjamin Rokseth --- Created attachment 33455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33455&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:39:51 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Benjamin Rokseth --- Resolved conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:56:38 +0000 Subject: [Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:57:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:57:06 +0000 Subject: [Koha-bugs] [Bug 13113] Prevent juvenile/children from reserving ageRestricted material In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13113 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:57:31 +0000 Subject: [Koha-bugs] [Bug 13176] Add links "My account" and "My checkouts" for logged in user to drop down in staff client header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13176 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Nice one, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:57:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:57:44 +0000 Subject: [Koha-bugs] [Bug 13230] Bug 12995 causes test case failures In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:58:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:58:14 +0000 Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Sophie! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:58:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:58:36 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 13:59:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 12:59:47 +0000 Subject: [Koha-bugs] [Bug 12234] Package dependency updates for master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! Note: I'll try to add a followup so this is not needed on future dependency additions. Will coordinate with you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 14:28:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 13:28:10 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #27 from Tom?s Cohen Arazi --- I'm sorry, this one is not an urgent one and needs regression tests. After the release, I can work on them (we need to make the big tests function run on NORMARC and UNIMARC so this is testable on both). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 14:40:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 13:40:03 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 14:40:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 13:40:19 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #5 from M. de Rooy --- Thanks, Marc for signing off. Temporarily switching status to check a possible problem.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 14:49:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 13:49:05 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi at cineca.it --- Comment #2 from Paola Rossi --- I've tried to apply the patch against master 3.17.00.052 HEAD 13113 Applying: Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Auto-merging C4/Suggestions.pm Failed to merge in the changes. Patch failed at 0001 Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl So I pass the patch to "Patch doesn't apply" status. NB. On master, in the template, from patron's "Surname, firstname" there is a "mailto" link in the template. The test plan requires "consulting the record of the user, to know exactly who made the suggestion". Please, does the test plan require the barcode to be a link or not? In case, which link? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 14:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 13:53:01 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 14:53:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 13:53:03 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 --- Comment #1 from Owen Leonard --- Created attachment 33456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33456&action=edit Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 15:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 14:01:08 +0000 Subject: [Koha-bugs] [Bug 13232] New: patron letter browse not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Bug ID: 13232 Summary: patron letter browse not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I just pulled master a few minutes ago, went to the patron module and clicked 'E' it gave me a patron named John Stewart - that was the only result. I do have patrons with last names that start with E - like mine. I think the alphabet filters on the patron search page are not working as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 15:03:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 14:03:19 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 15:04:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 14:04:53 +0000 Subject: [Koha-bugs] [Bug 13233] New: patron birthday tooltip removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 Bug ID: 13233 Summary: patron birthday tooltip removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you chose to search patrons by birthday you were given a tooltip like this: http://manual.koha-community.org/3.16/en/images/patrons/patronsearchbday.png now you are not given a tip on how to search for birthday. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 15:06:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 14:06:24 +0000 Subject: [Koha-bugs] [Bug 7503] OPAC fails WCAG 2.0 AA testing / search input field has no label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7503 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org --- Comment #2 from Owen Leonard --- This bug is fixed in master (including comment 1) in the bootstrap theme. I'll leave this here marked as 3.16 in case someone wants to fix it in stable in the prog theme. I don't plan to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 15:26:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 14:26:58 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 --- Comment #1 from Nicole C. Engard --- Here's a video: http://screencast.com/t/z7UCKT57Olp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 16:29:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 15:29:26 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #7 from Paola Rossi --- I've applied the patch against master 3.17.00.052 head 13113 I cloned the ACQCLAIM to ACQCLAIM-CPL to test the patch: ACQCLAIM-CPL: ($<> -- <> each) as required ACQCLAIM: ($<> each) as by default MASTER: ACQCLAIM-CPL answers: ($USD -- USD each) WRONG ACQCLAIM answers: ($USD each) WRONG APPLIED: ACQCLAIM-CPL answers: ($2000.000000 -- USD each) RIGHT as required ACQCLAIM doesn't send any mail WRONG So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 16:39:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 15:39:58 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jeremie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33413|0 |1 is obsolete| | --- Comment #3 from Jeremie --- Created attachment 33457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33457&action=edit Bug 12905: funds with children could not be deleted The interface should prevent to delete funds with children. Otherwise the relationship is broken and problems occur: 1/ You don't see the orphan fund in the fund list 2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent allocation'). This patch: - adds a JS check, template side - adds a check in the perl script (should never be true) - adds an updatedatabase check, in order to alert users with inconsistent data. Test plan: Verify you are not allow to delete a fund with children. Signed-off-by: jeremie.benarros Javascript verification is working, but i got an error when i'm 'hacking' the JS : Undefined subroutine &main::HasChildren called at /inlibro/git/koha-try4jeremie-dev-inlibro/admin/aqbudgets.pl line 234 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 16:42:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 15:42:28 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33456|0 |1 is obsolete| | --- Comment #2 from Blou --- Created attachment 33458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33458&action=edit Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Signed-off-by: Blou -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 16:43:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 15:43:53 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #3 from Blou --- Looks good on Firefox 28, at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 16:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 15:44:16 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 --- Comment #4 from Blou --- Looks good on Firefox 28, at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 16:44:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 15:44:48 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:08:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:08:17 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #5 from ppp at inlibro.com --- Created attachment 33459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33459&action=edit [SIGNED-OFF] Bug 12133: Guarantor requirements when registering a patron Add two requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor cannot be a guarantee. Signed-off-by: ppp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:10:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:10:23 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 ppp at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ppp at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:24:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:24:08 +0000 Subject: [Koha-bugs] [Bug 9177] Duplicate patron: Prepopulated fields ar cleared when setting cursor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:24:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:24:12 +0000 Subject: [Koha-bugs] [Bug 9177] Duplicate patron: Prepopulated fields ar cleared when setting cursor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 --- Comment #3 from Owen Leonard --- Created attachment 33460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33460&action=edit Bug 9177 - Duplicate patron: Prepopulated fields ar cleared when setting cursor When adding a duplicated patron record some fields are prepopulated from the original patron record. Focusing your cursor on these fields automatically clears them. This works well if you assume that the user only focuses on fields which should be changed. This works badly if you consider that a user might want to tab between all fields. I think the disadvantages outweigh the minor benefit of not having to delete the contents of a field. This patch removes the clearing action. To test, apply the patch and duplicate an existing patron record. Tabbing through the entry fields should not result in the contents of those fields being cleared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:27:56 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi at cineca.it --- Comment #54 from Paola Rossi --- I've tried to apply the patches against master 3.17.00.052 Applying: Bug 12017 - 3 - Change lang display on sysprefs I18N Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt Failed to merge in the changes. Patch failed at 0001 Bug 12017 - 3 - Change lang display on sysprefs I18N So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:37:05 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:37:51 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:40:53 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33373|0 |1 is obsolete| | --- Comment #2 from simith.doliveira at inlibro.com --- Created attachment 33461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33461&action=edit Bug 13220 - Shipment date not saved when creating an invoice which has a duplicated number When creating an invoice which has a duplicated number, if the user chooses to 'Create new invoice anyway', previously entered shipment date (todays date by default) is not being saved, because the date value is passed to the script in the wrong format (acqui/parcels.pl expects shipmentdate parameter to be in the system-configured date format, but what it's getting in such cases is ISO-formatted date instead). As a consequence (when receiving orders from invoice whith empty shipment date) 'datereceived' field in order records are also not being populated. Here and there, Koha is using datereceived field to establish if the order was received or not received, so such not-quite-complete orders: - can be cancelled from the basket (even when they are de facto already received), - it's not possible to cancel receipt of those orders from the invoice (because Koha is considering them as not yet received). To reproduce: 1) Make sure you have some system date format configured in your test environment which is different from ISO format (e.g., DD/MM/YYYY) and the AcqWarnOnDuplicateInvoice syspref is enabled 2) Create some invoice with e.g. '11111' number, 3) Create another invoice with the same number (using 'Create new invoice anyway' button) 4) Try to create yet another invoice with the same number; observe that already existing invoice created in step 3) does have empty shipment date. 5) Optional: create some orders and receive them from the invoice with empty shipment date; observe that such orders are not being treated as received in all places (e.g. it's not possible to cancel receipts of such orders, and the message displayed is not in any way helpfull to determine why not). To test: 1) Apply patch 2) Retest 3) Ensure that the issue is no longer reproductible, and that there are no apparent regressions of any kind. Works as expected. Signed-off-by: simith -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:41:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:41:00 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:41:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:41:03 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:41:05 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 --- Comment #2 from Owen Leonard --- Created attachment 33462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33462&action=edit Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:41:46 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33455|Bug-7981---Transfer-message |Bug 7981 - Remove filename|-when-returning-doesnt-.pat |HomeOrHoldingBranchReturn |ch |syspref Attachment #33455|1 |0 is obsolete| | --- Comment #24 from Benjamin Rokseth --- Comment on attachment 33455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33455 Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref Obsoleted wrong patch. fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 17:42:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 16:42:41 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:05:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:05:03 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Jeremie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremie.benarros at inlibro.co | |m --- Comment #9 from Jeremie --- I'm not able to reproduce the bug. I followed the instructions but the exports just gives me that result : 0 0 0 0 and the XML files give to me correct informations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:12:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:12:18 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:13:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:13:11 +0000 Subject: [Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:13:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:13:27 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #111 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:30:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:30:06 +0000 Subject: [Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Owen Leonard --- I agree with Jonathan -- Bug 11821 seems to have fixed this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:37:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:37:16 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12984 | Depends on| |12984 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:37:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:37:16 +0000 Subject: [Koha-bugs] [Bug 12984] Improvement of the funds list view - acqui home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com Blocks| |12989 Depends on|12989 | --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:37:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:37:41 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:44:06 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com --- Comment #24 from Francois Charbonnier --- I tested this with two CSV profils : Without TT methods 1. Personal name=200|Entry element=210$a|300|009 -> It works With TT methods 2. 245i1=[% fields.245.0.indicator.2 %]|245ac=[% FOREACH field IN fields.245 %] [% field.a.0 %] [% field.c.0 %] [% END %] | Subject=[% FOREACH field IN fields.650 %][% IF field.indicator.2 %][% field.a.0 %] [% END %][% END %] | Language=[% fields.008.0.substr( 28, 3 ) %] | Title=[% IF fields.100.0.indicator.1 %][% fields.245.0.a.0 %][% END %] I used the examples in the help section for the last one. I also works BUT I had to correct one method. The help section says : Display all 245$a and 245$c into the same column: [% FOREACH field IN fields.245 %] [% field.a %] [% field.c %] [% END %] but it doesn't work. I think it should be corrected by : [% FOREACH field IN fields.245 %] [% field.a.0 %] [% field.c.0 %] [% END %] which works. Since I'm not familiar with template toolkit, I let you confirm it's correct. Once the documentation is corrected I'll test it again to sign it off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:52:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:52:46 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32269|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 33463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33463&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 18:52:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 17:52:52 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32270|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 33464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33464&action=edit Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:16:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:16:11 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:18:18 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #11 from Tom?s Cohen Arazi --- As we have deprecated GRS-1, we could just focus on DOM, and implement this using XSLT's for calculating, instead of crafting the search string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:27:47 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:28:39 +0000 Subject: [Koha-bugs] [Bug 12258] Datatable in Patrons Account Fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12258 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Maxime! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:45:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:45:07 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Severity|enhancement |new feature --- Comment #36 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:54:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:54:36 +0000 Subject: [Koha-bugs] [Bug 13234] New: Make on-site checkouts visible in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Bug ID: 13234 Summary: Make on-site checkouts visible in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart at biblibre.com While integrating bug 10860 into current master we removed the change to the prog template it included as the template had just been removed. The changed intended for prog should be reimplemented for the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:54:57 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10860 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 19:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 18:54:57 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13234 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 20:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 19:02:04 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32251|0 |1 is obsolete| | --- Comment #14 from Owen Leonard --- Created attachment 33465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33465&action=edit Bug 10632 [Follow-up] Enable datatables for courses and course details in the OPAC This follow-up adds some style improvements and corrects some errors in the previous patch: - The path to datatables.css has been corrected - Unused CSS has been removed from datatables.css (particularly related to pagination controls, which are currently unused in the OPAC). - Style has been added to datatables.css to make the table search form look better. - The configuration of the course details table has been enhanced to include a title sort which ignores articles and date sorting according to the "title-string" method for date format agnostic sorting. - Unrelated: A message
    has been modified to have the correct style for the Bootstrap theme. To test you should have multiple courses and at least one course with multiple reserves. Clear your browser cache if necessary and view the list of courses in the OPAC. All table sorting should work correctly, as should the table search form. View the details of a course which has multiple reserves. All sorting should work correctly, including title sort excluding articles. Sorting by date due should work correctly for any dateformat system preference setting. View the details of a course which has no reserves. You should see a "No reserves" message box with a style consistent with similar messages in the Bootstrap OPAC. View other sorted tables in the OPAC to confirm that the CSS changes have not negatively affected their appearance: opac-user.pl for instance, or opac-detail.pl. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 20:23:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 19:23:14 +0000 Subject: [Koha-bugs] [Bug 13233] Patron search by birth date tooltip broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Summary|patron birthday tooltip |Patron search by birth date |removed |tooltip broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 20:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 19:27:56 +0000 Subject: [Koha-bugs] [Bug 13233] Patron search by birth date tooltip broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard --- Broken by Bug 9811: Patron search improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 21:00:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 20:00:04 +0000 Subject: [Koha-bugs] [Bug 13235] New: Revise layout of patron search form Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Bug ID: 13235 Summary: Revise layout of patron search form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 10153 changed the layout of the patron search form so that expanded search fields would be stacked (http://www.screencast.com/t/LnVgH2nV) rather than in one line (http://www.screencast.com/t/t0XkqsSX). Bug 9811 returned the layout to a non-stacked layout (http://www.screencast.com/t/9Cn8B0VKm6q), but I think this was not done as an intentional override of Bug 10153. I think the patch was based on the previous version. I propose to bring back the stacked version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 21:02:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 20:02:20 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I liked the non-stacked, especially since German words are often longer than the english ones and the stacked layout gives more flexiblity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 21:30:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 20:30:45 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle and Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 22:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 21:22:58 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 22:43:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 21:43:56 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #35 from Robin Sheat --- (In reply to Robin Sheat from comment #34) > Created attachment 33447 [details] [review] > Bug 11998 - fix compile warnings > > This creates a simplified logging system that can be used by > C4::Context. Ignore that, there's a bug in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 22:44:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 21:44:54 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #36 from Tom?s Cohen Arazi --- (In reply to Robin Sheat from comment #35) > (In reply to Robin Sheat from comment #34) > > Created attachment 33447 [details] [review] [review] > > Bug 11998 - fix compile warnings > > > > This creates a simplified logging system that can be used by > > C4::Context. > > Ignore that, there's a bug in it. Robin, just strip it out. We'll properly implement it as you wanted, later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 22:53:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 21:53:05 +0000 Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045 --- Comment #4 from mathieu saby --- OK Katrin Do you know if it is written somewhere in the documentation that the biblioitems.itypes should match the itemtypes.itemtype list? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 22:56:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 21:56:22 +0000 Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045 --- Comment #5 from mathieu saby --- May I add that this non standard configuration of ours was suggested by our vendor, so at that time, it was not so obvious for them (and of course not for the library) that biblioitems.itypes should match the itemtypes.itemtype list ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 23:06:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 22:06:16 +0000 Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- --- Comment #6 from Katrin Fischer --- Hi Mathieu, I think it's not explicitly documented and it would be good to get more opinions and look at the code some more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 11 23:06:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 22:06:22 +0000 Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 00:46:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Nov 2014 23:46:40 +0000 Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045 --- Comment #7 from mathieu saby --- You understood my mind ;-) Maybe it is a wontfix, but in that case, libraries should be warned somewhere not to use the same configuration pattern as we did (and that's a pity, because it was well fitted for our rules). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 01:49:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 00:49:38 +0000 Subject: [Koha-bugs] [Bug 13236] New: Regression: Table of checkouts no longer preselects overdue items for rewewal Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Bug ID: 13236 Summary: Regression: Table of checkouts no longer preselects overdue items for rewewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: kyle at bywatersolutions.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Before the AJAX checkouts overhaul, any overdue items in the table of checkouts were preselected in the "Renew" column, allowing the librarian to quickly and easily renew only those items which need to be renewed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 01:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 00:51:59 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 01:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 00:51:59 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13236 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 02:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 01:07:09 +0000 Subject: [Koha-bugs] [Bug 13237] New: Regression: List of previous checkouts should be ordered by due date ascending Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Bug ID: 13237 Summary: Regression: List of previous checkouts should be ordered by due date ascending Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: kyle at bywatersolutions.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 11703 Before Bug 11703 the list of previous checkouts on a patrons account were ordered with the oldest checkouts first. Now previous checkouts are shown with the newest checkouts first, breaking a sorting default which has been in place for years. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 02:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 01:07:09 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13237 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:09:49 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:09:52 +0000 Subject: [Koha-bugs] [Bug 13229] Suggestion date filters have a style problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33458|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 33466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33466&action=edit [PASSED QA] Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Signed-off-by: Blou Signed-off-by: Katrin Fischer Works as described, looking better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:14:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:14:36 +0000 Subject: [Koha-bugs] [Bug 13238] New: Improve heading on vendor search when searching for all vendors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Bug ID: 13238 Summary: Improve heading on vendor search when searching for all vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When searching for all vendors by doing an empty search, the page states: You searched on vendor , 3 results found I think we could make this look a bit nicer checking for the empty search term. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:17:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:17:32 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:17:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:17:35 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33461|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 33467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33467&action=edit [PASSED QA] Bug 13220 - Shipment date not saved when creating an invoice which has a duplicated number When creating an invoice which has a duplicated number, if the user chooses to 'Create new invoice anyway', previously entered shipment date (todays date by default) is not being saved, because the date value is passed to the script in the wrong format (acqui/parcels.pl expects shipmentdate parameter to be in the system-configured date format, but what it's getting in such cases is ISO-formatted date instead). As a consequence (when receiving orders from invoice whith empty shipment date) 'datereceived' field in order records are also not being populated. Here and there, Koha is using datereceived field to establish if the order was received or not received, so such not-quite-complete orders: - can be cancelled from the basket (even when they are de facto already received), - it's not possible to cancel receipt of those orders from the invoice (because Koha is considering them as not yet received). To reproduce: 1) Make sure you have some system date format configured in your test environment which is different from ISO format (e.g., DD/MM/YYYY) and the AcqWarnOnDuplicateInvoice syspref is enabled 2) Create some invoice with e.g. '11111' number, 3) Create another invoice with the same number (using 'Create new invoice anyway' button) 4) Try to create yet another invoice with the same number; observe that already existing invoice created in step 3) does have empty shipment date. 5) Optional: create some orders and receive them from the invoice with empty shipment date; observe that such orders are not being treated as received in all places (e.g. it's not possible to cancel receipts of such orders, and the message displayed is not in any way helpfull to determine why not). To test: 1) Apply patch 2) Retest 3) Ensure that the issue is no longer reproductible, and that there are no apparent regressions of any kind. Signed-off-by: simith Signed-off-by: Katrin Fischer Tiny change fixing a bad bug. No problems found, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:17:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:17:57 +0000 Subject: [Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:18:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:18:39 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |katrin.fischer at bsz-bw.de QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:46:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:46:16 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 --- Comment #4 from Martin Renvoize --- Created attachment 33468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33468&action=edit [Passed QA] Bug 7988: Make note on authorized values page less confusing Nicole suggested a change of the note, that this patch is implementing: NOTE: If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately. To test: - Go to administration > authorised values - Check the note showing on the page - Select a category from the pull down and edit an existing entry - Check the note on this page is also correct Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:46:31 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33436|0 |1 is obsolete| | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:46:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:46:47 +0000 Subject: [Koha-bugs] [Bug 7988] warning on authorized values confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Trivial patch, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:50:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:50:01 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33452|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 33469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33469&action=edit [Passed QA] Bug 10136: Remove outdated translation tool docs Patch removes outdated translation tool documentation from the misc/translator directory. Signed-off-by: Magnus Enger Removing these lines sounds like a good idea. I tested by applying the patch and checking that the files in question are gone. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:49:58 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:50:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:50:18 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Sensible and trivial patch, passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:53:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:53:28 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:53:30 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33403|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 33470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33470&action=edit [Passed QA] Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:53:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:53:56 +0000 Subject: [Koha-bugs] [Bug 13227] Display856uAsImage displays images in OPAC in original size In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Passes all my tests and qa script. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:58:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:58:33 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 --- Comment #3 from Martin Renvoize --- Created attachment 33471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33471&action=edit [Passed QA] Bug 12779: Capitalization on add/edit subscription form To test: - Add or edit a new or existing subscription in the serials module Patch changes "biblio" to "record" and fixes capitalization: Search for record | Create record Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:58:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:58:57 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33437|0 |1 is obsolete| | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 08:59:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 07:59:34 +0000 Subject: [Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Agree to change, trivial patch, passes tests... passing qa! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:02:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:02:35 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:02:37 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33406|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 33472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33472&action=edit [Passed QA] Bug 10878: Correct Display856uAsImage pref description Removes note about Display856uAsImage not working on the OPAC result page. To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - check that the pref description makes sense and is correct - the warning about the pref not working on result pages has been removed - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result page in the bootstrap catalog. Note: The height=100 doesn't work in the Boostrap catalog, so the images display in their original size. Will file a separate bug for this. Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:03:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:03:00 +0000 Subject: [Koha-bugs] [Bug 10878] Display856uAsImage works in Results pages, can remove caveat text from system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10878 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Agree, patch is good... passing qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:05:32 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33404|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 33473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33473&action=edit [Passed QA] Bug 13133: Fix mangled titles on pay fines page Titles with diacritics don't show correctly on the 'pay fines' page in the patron account in staff. To test: - Catalog or find a record with non-latin script Something like a word in Hebrew would work. - Create a fine entry for that record Something like a rental fee works. - Verify that the title doesn't display correct on the pay fine page (other tabs are ok) - Apply patch - Check the pages again - display should be correct now. Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:05:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:05:30 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:06:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:06:01 +0000 Subject: [Koha-bugs] [Bug 13133] Mangled UTF8 in pay.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Super trivial, works as expected... passing qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:10:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:10:11 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Regression test++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:41:46 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33457|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 33474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33474&action=edit Bug 12905: funds with children could not be deleted The interface should prevent to delete funds with children. Otherwise the relationship is broken and problems occur: 1/ You don't see the orphan fund in the fund list 2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent allocation'). This patch: - adds a JS check, template side - adds a check in the perl script (should never be true) - adds an updatedatabase check, in order to alert users with inconsistent data. Test plan: Verify you are not allow to delete a fund with children. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:43:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:43:04 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 --- Comment #5 from Jonathan Druart --- (In reply to Jeremie from comment #3) > Javascript verification is working, but i got an error when i'm 'hacking' > the JS : > Undefined subroutine &main::HasChildren called at > /inlibro/git/koha-try4jeremie-dev-inlibro/admin/aqbudgets.pl line 234 Hello Jeremie, Thanks for testing it! Yes, the routine's name is BudgetHasChildren, not HasChildren... Fixed in the last patch, please retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:54:16 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:54:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:54:18 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33443|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 33475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33475&action=edit [Passed QA] Bug 13207: "Branch" on basket summary page should be "Library" To test: - Create or find an open basket/order in the acquisition module - Check that "Branch" now reads "library" - Set to "no library" - No branches should be seen there. Signed-off-by: jeremie.benarros Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 09:54:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 08:54:35 +0000 Subject: [Koha-bugs] [Bug 13207] "Branch:" on basket page should read "Library:" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Simple patch, passes tests.. passing qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13239 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 13239] New: MySQL Character encoding utf8 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 Bug ID: 13239 Summary: MySQL Character encoding utf8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: abl at biblos.pk.edu.pl, benjamin.rokseth at kul.oslo.kommune.no, bgkriegel at gmail.com, boutrosboutrosboutros at gmail.com, dpavlin at rot13.org, hbraum at nekls.org, jonathan.druart at biblibre.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, m.de.rooy at rijksmuseum.nl, magnus at enger.priv.no, martin.renvoize at ptfs-europe.com, paola.rossi at cineca.it, tomascohen at gmail.com, z.tajoli at cineca.it Depends on: 11248, 11906, 11944 Blocks: 7380, 10855, 11844, 12176, 12637, 12832 As discussed in bug 11944 we should use utf8_mb4 as default mysql encoding where the mysql version allows for it. This would allow for the entire utf8 character range rather than an arbitrarily truncated set as chosen by mysql during their first attempt at utf8 compatibility. As promised, I've opened this followup bug to track this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 12637] [DEPENDS ON 11944] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:09 +0000 Subject: [Koha-bugs] [Bug 12832] Basketgroup printing doesn't support no latin chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:00:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:00:53 +0000 Subject: [Koha-bugs] [Bug 13239] MySQL Character encoding utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:08:08 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 10:08:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 09:08:11 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 --- Comment #2 from Jonathan Druart --- Created attachment 33476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33476&action=edit Bug 13232: Search patrons by a first letter should not redirect to a patron detail page Bug 12833 allows to find a patron with his cardnumber. But this won't never append if the firstletter parameter is given. Actually the firstletter param is the only one to take into account if it exists. Test plan: Search patrons by a first letter and verify that the feature is back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 11:16:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 10:16:43 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #25 from Jonathan Druart --- Created attachment 33477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33477&action=edit Bug 12404: FIX documentation to join subfield To display all subfields, the join TT method must be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 11:17:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 10:17:12 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #26 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #24) I updated the documentation in the last patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 11:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 10:19:23 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #6 from Martin Renvoize --- Cheers Robin.. I'll try and promote some interest on list today.. see if we can get someone to signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 11:51:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 10:51:47 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oleonard at myacpl.org Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- I have almost a patch for this one. But at the OPAC, tabs already exist ("show all items" and "showing last 50 items"). I am sure it's not a good idea to add a 2 level tabs here. An ergonomic suggestion? I would replace the existing tab by a link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:04:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:04:02 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #2 from Katrin Fischer --- Hi Jonathan, maybe we could split this up - show the in-house checkouts in the patron account and show it on the OPAC detail tab? Bit confused what we are talking about right now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:21:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:21:42 +0000 Subject: [Koha-bugs] [Bug 13240] New: advanced_notices.pl contains code obfuscation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Bug ID: 13240 Summary: advanced_notices.pl contains code obfuscation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org my $bar; my $foo = $bar->{borrowernumber} ||= {}; $foo->{bar} ||= 'something'; $foo->{two}++; What does $bar contain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:21:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:21:50 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:29:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:29:02 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:29:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:29:08 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #1 from Jonathan Druart --- Created attachment 33478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33478&action=edit Bug 13240: Remove some code obfuscation my $bar; my $foo = $bar->{borrowernumber} ||= {}; $foo->{one} ||= 'something'; $foo->{two}++; What does $bar contain? $VAR1 = { 'borrowernumber' => { 'two' => 1, 'bar' => 'something' } }; Not really obvious. Maybe something I did not see is hidden. Test plan: Verify the digest for DUE and PREDUE work as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:29:12 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #2 from Jonathan Druart --- Created attachment 33479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33479&action=edit Bug 13240: Remove commented warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:49:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:49:40 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 Nabakumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nabakumarbhoi at gmail.com --- Comment #7 from Nabakumar --- First of all thanks a lot for this valuable information.Can i have a video regarding this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 12:59:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 11:59:38 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 13:23:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 12:23:33 +0000 Subject: [Koha-bugs] [Bug 13241] New: Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Bug ID: 13241 Summary: Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The notice ACCTDETAILS will be sent to a new patron on creation if that account has an email address. This notice will always be send in plain text even if the html option is selected in the notice editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 13:23:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 12:23:38 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 13:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 12:26:19 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 13:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 12:26:21 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 --- Comment #1 from Kyle M Hall --- Created attachment 33480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33480&action=edit Bug 13241 - Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected The notice ACCTDETAILS will be sent to a new patron on creation if that account has an email address. This notice will always be send in plain text even if the html option is selected in the notice editor. Test Plan: 1) Create an ACCTDETAILS notice containing html, ensure that the "HTML message" box is checked. 2) Create a new patron with an email address you control 3) Read the email that is sent to you, notice it is in plain text with the html markup clearly visible 4) Apply this patch 5) Delete the patron, and re-create the patron again 6) Note that this time the HTML is parsed correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 13:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 12:30:00 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33480|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 33481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33481&action=edit Bug 13241 - Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected The notice ACCTDETAILS will be sent to a new patron on creation if that account has an email address. This notice will always be send in plain text even if the html option is selected in the notice editor. Test Plan: 1) Create an ACCTDETAILS notice containing html, ensure that the "HTML message" box is checked. 2) Create a new patron with an email address you control 3) Read the email that is sent to you, notice it is in plain text with the html markup clearly visible 4) Apply this patch 5) Delete the patron, and re-create the patron again 6) Note that this time the HTML is parsed correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 13:40:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 12:40:06 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33480|Bug 13241 - Notice for |Bug 13241 [3.16.x] - Notice description|account details ( |for account details ( |ACCTDETAILS ) will only |ACCTDETAILS ) will only |send in plain text even if |send in plain text even if |HTML is selected |HTML is selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:07:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:07:21 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #39 from Jonathan Druart --- (In reply to M. de Rooy from comment #28) > QA Comment: > This looks promising, but currently generates a problem: > stage-marc-import.pl: Can't call method "update" on an undefined value at > /usr/share/koha/testclone/Koha/SimpleMARC.pm line 214, chunk 1. It is fixed by Bug 11395: Fix field_numbers """ This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:16:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:16:43 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #40 from Jonathan Druart --- Created attachment 33482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33482&action=edit Bug 11413: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:16:48 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #41 from Jonathan Druart --- Created attachment 33483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33483&action=edit Bug 11413: Fix field_numbers This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. The following line was completely stupid: if $from_field ne $to_subfield The field_number equals 1 if the user wants to update the first field and 0 for all fields. The field_numbers (note the s) variable contains the field numbers to update. This array is filled if a condition exists (field exists or field equals). Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:17:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:17:11 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33151|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart --- Comment on attachment 33151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33151 Bug 11395: Fix field_numbers This should be on bug 11413. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:17:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:17:35 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33147|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Comment on attachment 33147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33147 Bug 11395: Fix return for ModifyRecordWithTemplate This should be on bug 11413. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:19:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:19:32 +0000 Subject: [Koha-bugs] [Bug 13100] Search results with publication date limit give no results for next page of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13100 --- Comment #2 from Kyle M Hall --- (In reply to Katrin Fischer from comment #1) > I can confirm the bug also exists in 3.16.3. > Kyle, which was the version you found it in? 3.16.4 I believe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:20:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:20:50 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #42 from Jonathan Druart --- Last 2 patches were on but 11395, but need to be on this one. They are not QA yet. The first one removes a warning. The second one fixes the issue raised by Marcel on comment 28. Sorry, I didn't realize it was so easy to do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:24:37 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33381|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 33484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33484&action=edit Bug 13223: Plugin housekeeping: do not redefine wrapper This report is connected to bug 10480 which will change the general mechanism of loading plugins, but can be tested independently and ahead of that proposed change. Several unimarc plugins use a wrapper sub. The code of this subroutine is not exactly the same for all plugins: in some cases the routine is extended for double character strings (dblspace and dblpipe). It would not hurt to use the extended code for all plugins. By moving the code to a module, we prevent redefinition when two or more plugins are loading wrapper in a do-statement. NOTE: You will not see wrapper redefine errors in your log, since the plugins do not use the warnings pragma (yet). Since this patch touches seventeen unimarc plugins, a unimarc signoff is preferred :) Test plan: Use some plugins changed in this patch (if not in use already). Load the MARC editor. Click on some tag editor-buttons to check unchanged behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:29:39 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 --- Comment #3 from Jonathan Druart --- You can only reproduce it if you have a patron with a cardnumber=="" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:31:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:31:58 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- Hi Kyle, Just to let you know: Recently we had a discussion about this notice on another report. A majority wanted to get rid of this notice (for security reasons) instead of extending its use; i abandoned some development therefore. Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:35:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:35:22 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12973 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:35:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:35:22 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:48:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:48:14 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #6 from Jonathan Druart --- Created attachment 33485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33485&action=edit DO NOT PUSH: profiling for _parseletter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 14:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 13:49:24 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #7 from Jonathan Druart --- You can also try to put some warns (see this patch). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:00:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:00:48 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:00:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:00:51 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33380|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 33486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33486&action=edit Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status TODO:: Somebody who knows what these are about could write some documentation about it. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:16:26 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- This patch is not clean (see the updatedatabase.pl changes). Kyle, could you have a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:20:55 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- An eval with a (big) warning message can do the trick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:21:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:21:32 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #112 from Tom?s Cohen Arazi --- Created attachment 33487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33487&action=edit Bug 7673: (RM followup) typo in sysprefs.sql Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:22:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:22:49 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #14 from Katrin Fischer --- I don't want to leave them in a state where the change doesn't get done... but I think we can't change the userids... maybe we could leave instructions somewhere on how to find the doubled userids and the command to run once they are cleaned up? (Wiki?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:23:28 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #26 from M. de Rooy --- (In reply to Jonathan Druart from comment #25) Please be assured that I appreciate your work and eagerness to get things into Koha. I also know that it can be somewhat frustrating to see things develop rather slow. Since this is meant to be a very fundamental object, I would not recommend hurry here btw. > Yes of course. We will only add methods in Koha::Object[s] if needed and > make sense. This sounds like a misunderstanding. If it would be so obvious to not have DBIx code in a perl script (or unit test!), why does Borrower.t contain constructs like: my $borrower = Koha::Database->new()->schema()->resultset('Borrower')->find( $borrowernumber ); Just replace it by something like Koha::Borrower->find( $borrowernumber ) or even extend new with similar functionality, as commented before. This would make new_from_dbic as external method (!! -- could be private though with an underscore) and passing resultsets superfluous. Leave the result set stuff in the objects. Also note that Koha::Borrowers->new()->find is not really elegant. Why not offer both Koha::Borrower->find and Koha::Borrowers->find without going through new? With some minimal changes in that direction, I would be inclined to pass qa.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:43:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:43:53 +0000 Subject: [Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:44:32 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:44:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:44:36 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #3 from Jonathan Druart --- Created attachment 33488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33488&action=edit Bug 13234: On-site checkouts - OPAC This patch introduces the code lost in bug 10860 for the OPAC side. Test plan: Go on opac-readingrecord.pl and verify the tabs work as expected and the "show all items" and "show 50 items" links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:57:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:57:17 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33484|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 33489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33489&action=edit Bug 13223: Plugin housekeeping: do not redefine wrapper This report is connected to bug 10480 which will change the general mechanism of loading plugins, but can be tested independently and ahead of that proposed change. Several unimarc plugins use a wrapper sub. The code of this subroutine is not exactly the same for all plugins: in some cases the routine is extended for double character strings (dblspace and dblpipe). It would not hurt to use the extended code for all plugins. By moving the code to a module, we prevent redefinition when two or more plugins are loading wrapper in a do-statement. NOTE: You will not see wrapper redefine errors in your log, since the plugins do not use the warnings pragma (yet). Since this patch touches seventeen unimarc plugins, a unimarc signoff is preferred :) Test plan: Use some plugins changed in this patch (if not in use already). Load the MARC editor. Click on some tag editor-buttons to check unchanged behavior. Signed-off-by: Frederic Demians Unimarc plugins work as usual. No regression. Simple code factorization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 15:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 14:58:47 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:11:08 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #43 from M. de Rooy --- I will have a look again this week if someone else is not faster :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:11:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:11:48 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #7 from M. de Rooy --- Thx Frederic. Could you upgrade the status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:13:10 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:21:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:21:57 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #6 from M. de Rooy --- Had this error on 3.14.x: Column 'timestamp' in order clause is ambiguous at /usr/share/koha/prodclone/C4/Items.pm line 1209 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:23:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:23:20 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:23:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:23:22 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33435|0 |1 is obsolete| | --- Comment #7 from M. de Rooy --- Created attachment 33490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33490&action=edit Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). NOTE: In order to prevent ambigous column-problems with multiple table queries including more than one timestamps, I name this column bortimestamp instead of just timestamp. This name will be used only in table borrowers and deletedborrowers. Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:24:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:24:21 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33490|0 |1 is obsolete| | --- Comment #8 from M. de Rooy --- Created attachment 33491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33491&action=edit Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). NOTE: In order to prevent ambiguous column-problems with multiple table queries including more than one timestamp, I name this column bortimestamp instead of just timestamp. This name will be used only in table borrowers and deletedborrowers. Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:26:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:26:49 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #9 from M. de Rooy --- Had to reset the status. Sent a mail to the dev list about the ambiguous timestamps in Koha. My patch now proposes bortimestamp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:28:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:28:14 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #41 from Kyle M Hall --- Created attachment 33492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33492&action=edit Bug 11634 [QA Followup] - Make unit tests pass * Allow on shelf holds needed to be enabled * Added some error supression code for undefined string comparison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:31:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:31:33 +0000 Subject: [Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 --- Comment #18 from Fridolin SOMERS --- (In reply to Robin Sheat from comment #17) > This patch causes the package builds to fail, as it requires a database. Oh, carp. How can we fix the UT ? mock the db ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 16:48:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 15:48:06 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #42 from Jonathan Druart --- Comment on attachment 33492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33492 Bug 11634 [QA Followup] - Make unit tests pass Review of attachment 33492: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11634&attachment=33492) ----------------------------------------------------------------- ::: Koha/DateUtils.pm @@ +128,4 @@ > my $pref = > defined $force_pref ? $force_pref : C4::Context->preference('dateformat'); > > + my $time_format = $force_time || C4::Context->preference('TimeFormat') || q{}; Hum, why? I am not sure it is a good idea to consider that TimeFormat can be '', 0 or undef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:04:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:04:41 +0000 Subject: [Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #8 from M. de Rooy --- Created attachment 33493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33493&action=edit Bug 13223: [QA Follow-up] Trivial change to one POD line The line referred to Plugin while it should be FrameworkPlugin. (I renamed the module in the process but forgot this line.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:21:12 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:21:15 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33485|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 33494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33494&action=edit Bug 13226: 9999-12-31 should not considered as a valid date DateTime::Format::DateParse (called in Koha::DateUtils::dt_from_string) does not manage to parse 9999-12-31 if a time zone is given. my $date = DateTime->new(year => 9999, month => 12, day => 31); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31' ); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31', 'America/Los_Angeles' ); => KO (~20sec on my laptop) It should not be considered as a valid date when the letter is parsed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:21:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:21:29 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:26:21 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33494|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 33495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33495&action=edit Bug 13226: 9999-12-31 should not considered as a valid date DateTime::Format::DateParse (called in Koha::DateUtils::dt_from_string) does not manage to parse 9999-12-31 if a time zone is given. my $date = DateTime->new(year => 9999, month => 12, day => 31); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31' ); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31', 'America/Los_Angeles' ); => KO (~20sec on my laptop) It should not be considered as a valid date when the letter is parsed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:39:37 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #10 from Jonathan Druart --- It seems that this patch does not completely fix the problem. I still have a 9999-12-31 somewhere else. But not introduced by bug 11244. Owen could you test it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:52:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:52:10 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi at cineca.it --- Comment #6 from Paola Rossi --- I've tried to apply against master 3.17.00.054 Applying: Bug 11814 - Use constants to describe statuses fatal: sha1 information is lacking or useless (C4/Serials.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11814 - Use constants to describe statuses So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 17:57:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 16:57:39 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #11 from Owen Leonard --- (In reply to Jonathan Druart from comment #10) > It seems that this patch does not completely fix the problem. With this patch I see a significant improvement: Check-ins from the account of a patron who is restricted indefinitely have gone from taking around 50 seconds to between 7 and 10 seconds. It's still slower than the 2-3 seconds for other checkins, but much better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:03:13 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33495|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 33496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33496&action=edit [SIGNED-OFF] Bug 13226: 9999-12-31 should not considered as a valid date DateTime::Format::DateParse (called in Koha::DateUtils::dt_from_string) does not manage to parse 9999-12-31 if a time zone is given. my $date = DateTime->new(year => 9999, month => 12, day => 31); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31' ); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31', 'America/Los_Angeles' ); => KO (~20sec on my laptop) It should not be considered as a valid date when the letter is parsed. Signed-off-by: Owen Leonard Note that to reproduce the problem you much be checking in items from an account which has been restricted indefinitely (either manually or by the overdues process). With this patch such checkins go from taking around 50 seconds (in my test system) to around 7 to 10 seconds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:03:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:03:11 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:19:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:19:57 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33488|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 33497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33497&action=edit [SIGNED-OFF] Bug 13234: On-site checkouts - OPAC This patch introduces the code lost in bug 10860 for the OPAC side. Test plan: Go on opac-readingrecord.pl and verify the tabs work as expected and the "show all items" and "show 50 items" links. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:20:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:20:02 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from simith.doliveira at inlibro.com --- I followed the same test (master 3.17.00.054) as Paola executed: ACQCLAIM-CPL: ($<> -- <> each) as required ACQCLAIM: ($<> each) as by default MASTER: ACQCLAIM-CPL answers: ($USD -- USD each) WRONG ACQCLAIM answers: ($USD each) WRONG APPLIED: ACQCLAIM-CPL answers: ($2000.000000 -- USD each) RIGHT as required But: ACQCLAIM: ($2000.000000 each) So, I pass to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:20:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:20:03 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #5 from Owen Leonard --- Created attachment 33498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33498&action=edit Bug 13234 [Follow-up] Make on-site checkouts visible in OPAC This follow-up makes a few changes to the template: 1. The "show all" / "show 50" links have been modified to show the current state. 2. The tabs are only shown if the OnSiteCheckouts preference is turned on. 3. The DataTables configuration has been modified so that title sorting ignores articles, sorting on the the first column is disabled, and sorting by date works regardless of your dateformat preference. 4. Some indentation has been corrected and markup comments added. To test the opacreadinghistory preference must be enabled. Log in to the OPAC as a patron who has some on-site checkouts as well as regular checkouts. With OnSiteCheckouts enabled, view the reading history page and confirm that the tabs work correctly. Test the table sorting controls. With OnSiteCheckouts disabled, confirm that the tabs do not appear. Test the "Show all items"/"Show last 50 items" links and confirm that the behavior is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:30:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:30:11 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:30:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:30:50 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle at bywatersolutions.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:31:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:31:09 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 --- Comment #1 from Owen Leonard --- Created attachment 33499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33499&action=edit Bug 13236 - Regression: Table of checkouts no longer preselects overdue items for rewewal Before Bug 11703, overdue items in the list of a patrons checkouts had the renewal checkbox preselected so that librarians could quickly renew only those items which required it. This is not longer the case. This patch corrects it. To test, apply the patch and clear your browser cache. Check out to a patron who has overdues and confirm that the overdue items have the "renew" checkbox preselected. Check that items which are not overdue are not preselected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:31:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:31:07 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:36:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:36:25 +0000 Subject: [Koha-bugs] [Bug 13233] Patron search by birth date tooltip broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 --- Comment #2 from Owen Leonard --- Created attachment 33500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33500&action=edit Bug 13233 - Patron search by birth date tooltip broken When the user selects a patron search by birth date a tooltip is supposed to appear showing the date format requirement. Bug 9811 (Patron search improvement) changed the ID on which the tooltip depended to function. This patch corrects it. To test, apply the patch and go to the Patrons home page in the staff client. In the header search form select "Date of birth" from the "search fields" dropdown. This should trigger a tooltip showing the required date format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:36:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:36:22 +0000 Subject: [Koha-bugs] [Bug 13233] Patron search by birth date tooltip broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:58:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:58:38 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #54 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 18:59:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 17:59:05 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #43 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 19:00:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 18:00:19 +0000 Subject: [Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 --- Comment #19 from M. Tompsett --- (In reply to Fridolin SOMERS from comment #18) > (In reply to Robin Sheat from comment #17) > > This patch causes the package builds to fail, as it requires a database. > Oh, carp. > How can we fix the UT ? mock the db ? See bug 13230. There's a patch for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:08:06 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32663|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 33501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33501&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:08:33 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:18:18 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |NEW --- Comment #11 from Nicole C. Engard --- 9740 is no longer failed qa so updating status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:23:00 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:23:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:23:03 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #2 from Owen Leonard --- Created attachment 33502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33502&action=edit Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:25:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:25:03 +0000 Subject: [Koha-bugs] [Bug 8387] Hide labels when no links exist under them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |All Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:56:46 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 --- Comment #3 from Owen Leonard --- Note that in the OPAC the label went from "Other phone" after Bug 5252 back to "Mobile phone" when we added online patron self-registration--a change I assume was made because the new template was based on a version of the template pre-Bug-5252. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 20:56:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 19:56:58 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 12 23:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 22:15:42 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #13 from David Cook --- (In reply to Owen Leonard from comment #12) > Note that to reproduce the problem you much be checking in items from an > account which has been restricted indefinitely (either manually or by > the overdues process). With this patch such checkins go from taking > around 50 seconds (in my test system) to around 7 to 10 seconds. Does that mean that check-ins for non-restricted patrons are processed quickly (e.g. 2-3 seconds)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 00:43:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 23:43:13 +0000 Subject: [Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32635|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 33503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33503&action=edit [SIGNED-OFF] Bug 13075: Silence warnings and improve Charset testing. Calls to C4/Charset.pm's NormalizeString function with an undefined string were triggering warnings when running: prove -v t/db_dependent/Holds.t Sadly, t/Charset.t was also lacking calls to NormalizeString. TEST PLAN --------- 1) prove -v t/db_dependent/Holds.t -- This should generate the uninitialized string warnings. Make sure CPL and MPL are in your branches to save yourself from headaches due to expected data. 2) cat t/Charset.t -- note there are no function calls to NormalizeString. You can see other shortfalls in the tests beyond NormalizeString with: grep ^sub C4/Charset.pm 3) prove -v t/Charset.t 4) Apply patch 5) prove -v t/Charset.t -- Run as before with more tests. 6) cat t/Charset.t -- note there are now function calls to NormalizeString. 7) prove -v t/db_dependent/Holds.t -- Nice and clean run! :) 8) koha-qa.pl -v 2 -c 1 -- all should be Ok. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 00:43:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Nov 2014 23:43:19 +0000 Subject: [Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 33504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33504&action=edit Bug 13075: (followup) remove remaining warnings There's no point creating a MARC record with undef subfields for testing holds. This patch avoids that so no warnings are shown. To test: - Run $ prove t/db_dependent/Holds.t => FAIL: verify several warnings show - Apply the patch - Re-run => SUCCESS: no warnings showed. - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 01:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 00:40:02 +0000 Subject: [Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 01:40:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 00:40:05 +0000 Subject: [Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33504|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 33505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33505&action=edit [SIGNED OFF] Bug 13075: (followup) remove remaining warnings There's no point creating a MARC record with undef subfields for testing holds. This patch avoids that so no warnings are shown. To test: - Run $ prove t/db_dependent/Holds.t => FAIL: verify several warnings show - Apply the patch - Re-run => SUCCESS: no warnings showed. - Sign off :-D Regards NOTE: Not noticable under Ubuntu 12.04 LTS, but verifiable under Debian Wheezy. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 03:38:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 02:38:11 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #28 from Jesse Weaver --- (In reply to Magnus Enger from comment #26) > When I apply the two patches on this bug to master and try to run the tests, > I get this: > > $ sudo koha-shell -c "prove t/db_dependent/Calendar.t" kohadev > t/db_dependent/Calendar.t .. Undefined subroutine &main::ModRepeatingEvent > called at t/db_dependent/Calendar.t line 22. > # Looks like your test exited with 255 before it could output anything. > t/db_dependent/Calendar.t .. Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 14/14 subtests > > Test Summary Report > ------------------- > t/db_dependent/Calendar.t (Wstat: 65280 Tests: 0 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 14 tests but ran 0. > Files=1, Tests=0, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.13 cusr 0.01 > csys = 0.16 CPU) > Result: FAIL > > The calendar page in the intranet seems to work as it should. Other > db_dependent tests do pass... I cannot for the life of me understand what is > happening here, and it does not seem to happen for others, so I am just > leaving this as a note, without changing the status of the bug. Just to verify, do you have the sample branches and holidays installed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 05:28:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 04:28:40 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 05:28:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 04:28:42 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17677|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 33506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33506&action=edit bug 8402 - generate 'install_misc/debian.packages' file from debian/control file to test... - rename ./install_misc/debian.packages file mv ./install_misc/debian.packages ./install_misc/debian.packages.old - apply patch git bz apply 8402 - run script ./koha-debian-deps.pl -r > install_misc/debian.packages - compare improved package file diff ./install_misc/debian.packages ./install_misc/debian.packages.old - install packages sudo apt-get install $( < install_misc/debian.packages) Signed-off-by: Kyle M Hall Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 05:32:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 04:32:17 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33506|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 33507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33507&action=edit bug 8402 - generate 'install_misc/debian.packages' file from debian/control file to test... - rename ./install_misc/debian.packages file mv ./install_misc/debian.packages ./install_misc/debian.packages.old - apply patch git bz apply 8402 - run script ./koha-debian-deps.pl -r > install_misc/debian.packages - compare improved package file diff ./install_misc/debian.packages ./install_misc/debian.packages.old - install packages sudo apt-get install $( < install_misc/debian.packages) Signed-off-by: Kyle M Hall Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 05:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 04:36:19 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #14 from M. Tompsett --- (In reply to Jonathan Druart from comment #9) > QA comment: > > 4 smalls remarks: > 1/ FAIL install_misc/koha-debian-deps.pl > FAIL pod > *** ERROR: Spurious text after =pod in file > install_misc/koha-debian-deps.pl > Need a blank line under "=pod" Added blank line. > 2/ Please use Pod::Usage. Not sure how to do that, but it's likely related to the print_usage() function. > 3/ Maybe should you use > C4::Context->config('intranetdir') . '/debian/control' > instead of using a relative path. > I don't know if it is relevant given that is adds a dependence to > C4::Context. Which is good, because then: ./install_misc/koha-debian-deps.pl -r works nicely without having to be in a fixed location. > 4/ It is useless to return 1 at the end of a perl script. removed. Also, I probably should have cleaned up the licensing. ;) I was also disappointed, because the list generated does not include gcc, which is required for some of the makes. So, I think I'll leave this Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 08:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 07:45:04 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from M. de Rooy --- >From Chris and Galen on the mailing list: > I think we don't need to make columns unique across the whole db just when > selecting do select borrowers.timestamp as something. > DBIx::Class helps us with this also > I agree with Chris. In legacy code, doing a "select *" from a join on > multiple tables is should be discouraged, so using the addition of a > new column to locate cases of these to stamp out is preferable. The > alternative of using a distinct column name has the problem of making > the writing of more general templates and classes more difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 08:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 07:46:35 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33435|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 08:46:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 07:46:45 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 08:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 07:47:14 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33435|Bug 10459: Borrowers should |[SIGNED_OFF] Bug 10459: description|have a timestamp |Borrowers should have a | |timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 08:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 07:48:23 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #11 from M. de Rooy --- Restored the patch signed off by Marc, but I will still add a patch to update some queries to prevent ambiguous column-errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:10:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:10:32 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:10:35 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33476|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 33508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33508&action=edit Bug 13232: Search patrons by a first letter should not redirect to a patron detail page Bug 12833 allows to find a patron with his cardnumber. But this won't never append if the firstletter parameter is given. Actually the firstletter param is the only one to take into account if it exists. Test plan: Search patrons by a first letter and verify that the feature is back. Signed-off-by: Chris Cormack To reproduce the problem you need at least one borrower with a blank cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:10:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:10:44 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #29 from Jonathan Druart --- (In reply to Jesse Weaver from comment #28) > Just to verify, do you have the sample branches and holidays installed? Jesse, I am not sure it's a data problem. The error is: > t/db_dependent/Calendar.t .. Undefined subroutine &main::ModRepeatingEvent > called at t/db_dependent/Calendar.t line 22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:36:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:36:07 +0000 Subject: [Koha-bugs] [Bug 13242] New: Slow checkin for patrons restricted indefinitely Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Bug ID: 13242 Summary: Slow checkin for patrons restricted indefinitely Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:36:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:36:25 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #14 from Jonathan Druart --- (In reply to David Cook from comment #13) > (In reply to Owen Leonard from comment #12) > > Note that to reproduce the problem you much be checking in items from an > > account which has been restricted indefinitely (either manually or by > > the overdues process). With this patch such checkins go from taking > > around 50 seconds (in my test system) to around 7 to 10 seconds. > > Does that mean that check-ins for non-restricted patrons are processed > quickly (e.g. 2-3 seconds)? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:36:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:36:50 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33435|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 33509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33509&action=edit [SIGNED-OFF] Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. updatedatabase.pl did not apply. I edited and then run it. Columns were added as expected. Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:37:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:37:04 +0000 Subject: [Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 --- Comment #15 from Jonathan Druart --- Owen, please have a look at bug 13242 to get rid of some other seconds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:37:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:37:13 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:47:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:47:34 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #1 from Jonathan Druart --- Created attachment 33510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33510&action=edit Bug 13242: DateUtils should manage separately 9999-* dates On bug 13226, we have seen that my $date = DateTime->new(year => 9999, month => 12, day => 31); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31' ); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31', 'America/Los_Angeles' ); => KO (~20sec on my laptop) For instance if you try to check in items for a patron which is restricted indefinitely (and there is no overdue on the item), the code in C4::Circulation::AddReturn l~1948 my $borrower_debar_dt = dt_from_string( $borrower->{debarred} ); will be called. dt_from_string should not called DateTime::Format::DateParse->parse_datetime with the time zone parameter in this case. Test plan: Create an indefinitely restriction for a patron and check an item in. Without this patch, it should take ~20 sec. With, ~2 or 3 sec. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:49:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:49:12 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:49:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:49:12 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |8231 --- Comment #2 from Jonathan Druart --- Original code introduced by bug 8231. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 09:50:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 08:50:00 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33510|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 33511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33511&action=edit Bug 13242: DateUtils should manage separately 9999-* dates On bug 13226, we have seen that my $date = DateTime->new(year => 9999, month => 12, day => 31); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31' ); => OK DateTime::Format::DateParse->parse_datetime( '9999-12-31', 'America/Los_Angeles' ); => KO (~20sec on my laptop) For instance if you try to check in items for a patron which is restricted indefinitely (and there is no overdue on the item), the code in C4::Circulation::AddReturn l~1948 my $borrower_debar_dt = dt_from_string( $borrower->{debarred} ); will be called. dt_from_string should not called DateTime::Format::DateParse->parse_datetime with the time zone parameter in this case. Test plan: Create an indefinitely restriction for a patron and check an item in. Without this patch, it should take ~20 sec. With, ~2 or 3 sec. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:07:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:07:45 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:07:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:07:48 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25541|0 |1 is obsolete| | Attachment #27605|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 33512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33512&action=edit Bug 11814 - Use constants to describe statuses Make the code a bit more understandable by using constants to define the status values and reference those. Adds self-documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:07:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:07:54 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #8 from Jonathan Druart --- Created attachment 33513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33513&action=edit Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:11:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:11:21 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33513|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 33514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33514&action=edit Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:13:08 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:13:12 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33498|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 33515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33515&action=edit Bug 13234 [Follow-up] Make on-site checkouts visible in OPAC This follow-up makes a few changes to the template: 1. The "show all" / "show 50" links have been modified to show the current state. 2. The tabs are only shown if the OnSiteCheckouts preference is turned on. 3. The DataTables configuration has been modified so that title sorting ignores articles, sorting on the the first column is disabled, and sorting by date works regardless of your dateformat preference. 4. Some indentation has been corrected and markup comments added. To test the opacreadinghistory preference must be enabled. Log in to the OPAC as a patron who has some on-site checkouts as well as regular checkouts. With OnSiteCheckouts enabled, view the reading history page and confirm that the tabs work correctly. Test the table sorting controls. With OnSiteCheckouts disabled, confirm that the tabs do not appear. Test the "Show all items"/"Show last 50 items" links and confirm that the behavior is correct. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:16:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:16:30 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #7 from Jonathan Druart --- Owen, Thanks for this follow-up! Now we have the sort available in the table, should the "order by" dropdown list be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:19:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:19:11 +0000 Subject: [Koha-bugs] [Bug 13243] New: Restrict Patron just to the library the Item is from Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13243 Bug ID: 13243 Summary: Restrict Patron just to the library the Item is from Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: joseanjos at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It woud be nice to be able to restrict Patron just to library A and let him borrow on libraries B and C? Our example: We have a public Library and school libraries. We don?t want to duplicate Patrons. If a Patron is restricted in the public library he has to be able to borrow from his school library because they need to read some books so they can do the homework assigned by teachers. If they are restricted they cant do homework. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:20:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:20:30 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:20:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:20:33 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #8 from Jonathan Druart --- Created attachment 33516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33516&action=edit Bug 13234: Remove the order by control Now we have the sort available in the table, the "order by" dropdown list can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 10:21:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 09:21:10 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #9 from Jonathan Druart --- Owen, Could you please sign off this last patch or obsolete it if you disagree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 11:46:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 10:46:57 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Paola Rossi --- Thanks, Simith. Today I've applied again the patch, against master 3.17.00.054 HEAD 11634. My tests agreed with the Simith's ones in comment 8. So: 2 notices: ACQCLAIM-CPL: ($<> -- <> each) as required ACQCLAIM: ($<> each) as by default On ACQ, on lateorders.pl: MASTER: ACQCLAIM-CPL answers: ($USD -- USD each) WRONG ACQCLAIM answers: ($USD each) WRONG APPLIED: ACQCLAIM-CPL answers: ($2000.000000 -- USD each) RIGHT as required ACQCLAIM: ($2000.000000 each) RIGHT When I didn't check any order in late, and select "Claim order", koha answered: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. I think this is an error. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 11:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 10:58:20 +0000 Subject: [Koha-bugs] [Bug 13244] New: GetCancelledOrders and GetOrders can be merged Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Bug ID: 13244 Summary: GetCancelledOrders and GetOrders can be merged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org They do the same job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 11:59:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 10:59:41 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 11:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 10:59:44 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #1 from Jonathan Druart --- Created attachment 33517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33517&action=edit Bug 13244: Merge GetOrders and GetCancelledOrders These two subroutines did the same job (same select, same join, etc.) Test plan: Go on the basket list page and verify you see the pending and the cancelled baskets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 11:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 10:59:59 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 12:04:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 11:04:15 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33517|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 33518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33518&action=edit Bug 13244: Merge GetOrders and GetCancelledOrders These two subroutines did the same job (same select, same join, etc.) Test plan: Go on the basket list page and verify you see the pending and the cancelled baskets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 12:04:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 11:04:36 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #3 from Jonathan Druart --- Not sure it's consistent. The query are not really readable... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 12:04:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 11:04:50 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #4 from Jonathan Druart --- s/are/is! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 12:05:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 11:05:35 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33518|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 33519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33519&action=edit Bug 13244: Merge GetOrders and GetCancelledOrders These two subroutines did the same job (same select, same join, etc.) Test plan: Go on the basket list page and verify you see the pending and the cancelled baskets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 12:25:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 11:25:42 +0000 Subject: [Koha-bugs] [Bug 13245] New: Send Cart via Email corrupts some Unicode characters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13245 Bug ID: 13245 Summary: Send Cart via Email corrupts some Unicode characters Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pongtawat at punsarn.asia QA Contact: testopia at bugs.koha-community.org In OPAC -> Cart -> Send (via Email), if the comment text or the text in item list being send contains some specific Unicode character, the email received will have that character corrupted. Step to reproduce: - Go to OPAC, search for something - Add some item to cart - View your cart - Click "Send" - Enter your email address and enter "??" as the comment. - View your email, you will get something like "?? ?" as comment. This is a known bug from HTML-Format used by html2text TT filter which was used to format email message: https://rt.cpan.org/Public/Bug/Display.html?id=9700 It can be easily fixed there by editing just one line as shown in the bug report above. However, it still not fixed as of HTML-Format v2.11. We may also fix this problem on Koha side as well by not using html2text and turn the template into plain text (or turn the email into HTML). Tested on 3.12, but this part of code is the same in master so it should be affected as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 12:26:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 11:26:50 +0000 Subject: [Koha-bugs] [Bug 13245] Send Cart via Email corrupts some Unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13245 Pongtawat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 13:38:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 12:38:33 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Fr?d?ric Demians --- It seems to come from here: https://metacpan.org/pod/DateTime#Determining-the-Local-Time-Zone-Can-Be-Slow Why is it necessary to use timezone for DateTime conversion process in the first place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 13:48:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 12:48:10 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:01:31 +0000 Subject: [Koha-bugs] [Bug 13246] New: Item edit doesn't respect cn_source if not defined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13246 Bug ID: 13246 Summary: Item edit doesn't respect cn_source if not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Steps to reproduce: - Create an item - Choose no source of classification - Save the item - Re-open the item for edit => FAIL: the $2 is set to the default (DefaultClassificationSource) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:01:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:01:50 +0000 Subject: [Koha-bugs] [Bug 13246] Item edit doesn't respect cn_source if not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13246 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:08:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:08:49 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- You replace: my $digest = $due_digest->{$upcoming->{'borrowernumber'}} ||= {}; $digest->{email} ||= $from_address; $digest->{count}++; With: $due_digest->{$upcoming->{borrowernumber}}{email} = $from_address; $due_digest->{$upcoming->{borrowernumber}}{count}++; But why exactly? The first syntax is Perlish, with ||=, but not to the point to be unreadable. And the second syntax uses autovivification which isn't that readable either. And the second syntax uses $h->{}{} which isn't so good: $h->{}->{} should be preferred, imho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:42:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:42:26 +0000 Subject: [Koha-bugs] [Bug 13247] New: opacuserjs is not compatible with tracking's tools like Piwik Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Bug ID: 13247 Summary: opacuserjs is not compatible with tracking's tools like Piwik Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: stephane.delaune at biblibre.com QA Contact: testopia at bugs.koha-community.org some tools needs to add javascript just before the tag .This is particularly the case of statistical : - Piwik (the page "http://developer.piwik.org/api-reference/tracking-javascript" indicates "copy and paste the JavaScript Tracking code into your pages, just before the tag") - Google Analytics (the page "https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingOverview?hl=fr" indicates "This tracking code snippet should be included in your site's pages so that it appears at the bottom of the page's HTML (or generated-HTML) structure, before the closing tag.") To use these tools with the syspref "opacuserjs", its use should be moved to the end of opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:42:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:42:47 +0000 Subject: [Koha-bugs] [Bug 13247] opacuserjs is not compatible with tracking's tools like Piwik In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |stephane.delaune at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:52:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:52:32 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:52:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:52:34 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 --- Comment #4 from Owen Leonard --- Created attachment 33520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33520&action=edit Bug 13142 - Change "mobile phone" label back to "other phone" Labeling a phone number field "mobile phone" eliminates the usefulness of having the labels "primary" and "secondary." Generic labels let the user populate the fields according to their importance rather than their type. To test I recommend editing a patron record so that the values in the patron record contain a label matching the table column: borrowers.phone : 555-555-1234 (primary - phone) borrowers.phonepro : 555-555-5678 (secondary - phonepro) borrowers.mobile : 555-555-9012 (other - mobile) View this patron's information in the various affected templates and verify that the labels correctly match the data: - OPAC "your personal details" (opac-memberentry.pl) - Submit changes to primary, secondary, and other phone via the OPAC. In the staff client, view the confirmation for those changes. - Patron details in the staff client (moremember.pl) - Patron entry/edit in the staff client (memberentrygen.pl) - Patron duplicate confirmation in the staff client (you can navigate directly to /members/moremember.pl?borrowernumber=XXXX&print=brief) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 14:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 13:55:03 +0000 Subject: [Koha-bugs] [Bug 13247] opacuserjs is not compatible with tracking's tools like Piwik In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 --- Comment #1 from stephane.delaune at biblibre.com --- Created attachment 33521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33521&action=edit proposed patch proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 15:07:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 14:07:28 +0000 Subject: [Koha-bugs] [Bug 10306] acquisitions shows publisher from 260 only (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12756 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 15:07:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 14:07:28 +0000 Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10306 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 15:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 14:08:14 +0000 Subject: [Koha-bugs] [Bug 13247] opacuserjs is not compatible with tracking's tools like Piwik In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 15:08:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 14:08:51 +0000 Subject: [Koha-bugs] [Bug 13247] opacuserjs is not compatible with tracking's tools like Piwik In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 13 15:22:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Nov 2014 14:22:29 +0000 Subject: [Koha-bugs] [Bug 13247] opacuserjs is not compatible with tracking's tools like Piwik In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 --- Comment #2 from M. Tompsett --- Comment on attachment 33521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33521 proposed patch Review of attachment 33521: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13247&attachment=33521) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +238,5 @@ > [% PROCESS jsinclude %] > > +