[Koha-bugs] [Bug 13096] Send account notice with login details in more situations

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 33159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33159&action=edit
Bug 13096: Send account notice at patron modification time

Instead of sending an account notice only at creation time, this patch
makes it possible to generate the same notice when changing account details
of the patron.

In memberentry.pl, the code for selecting an email address and sending the
alert is replaced by calling SendAutoEmail in Members.pm. An additional call
is made for the op=save situation; if in that case param mailacctdetails is
true (checkbox), a mail will be sent. Note that the script refers to
op=duplicate several times. Inspecting the template shows that the duplicate
operation also goes via op=insert however.

If the password is '!' (disabled), the form now shows the password
as blank. If no password is entered, AddMember will insert the ! again.
This makes staff more aware of a missing password than showing *****.

Test plan:
[1] Disable AutoEmailOpacUser. Add, duplicate, modify patron. No mails?
[2] Enable AutoEmailOpacUser. Add, duplicate patron. Check mail.
[3] Modify patron. Check the email checkbox. Did you receive it?
[4] Modify patron. Uncheck the email checkbox. No mail?
[5] Create a new patron without userid and password. No mail.
[6] Edit this patron: a userid has been generated, but the password
    should be blank. Enter a password. Check mail.

-- 
You are receiving this mail because:
You are watching all bug changes.