[Koha-bugs] [Bug 13192] New: Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192

            Bug ID: 13192
           Summary: Hard-coded value (ISBN Prefix '978') in
                    cataloguing::value_builder::unimarc_field_010
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: tiburce.euphrasie at aupaysdescrevettes.org
        QA Contact: testopia at bugs.koha-community.org

Aloha,
Frédéric Demians suggests me to open a new bug report for this case (please
read http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 for more
information):

...I think I've also detected a small problem in
cataloguing::value_builder::unimarc_field_010 :
[...] Line 94 to 96 :
    if (length ($isbn) == 13){
        $isbn = substr($isbn, 3, length($isbn)-3);
    }
[...] Then, line 143 :
        $sth->execute($seg2, "978$seg2");

This "978" on line 143 is hard-coded and there's no relation with the original
data inside $isbn (lost on line 95 via the substr function). I don't know if
this is a real problem but it might be better to keep the original data than
replacing it with "978".

Thanks to Frédéric Demians for resolving bug 13167.
Aloha.

-- 
You are receiving this mail because:
You are watching all bug changes.