[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167

--- Comment #6 from Frédéric Demians <frederic at tamil.fr> ---
(In reply to Tiburce Euphrasie from comment #5)

Aloha!

> Aloha Frédéric Demians,
> Adding 'return unless $isbn;' on line 1683 in Koha.pm means that the sub
> NormalizeISBN will return nothing for the specific ISBN sample I've provided.
> 
> This is not a proper way to fix this bug because that patch implies that all
> those '979.*' ISBN simply don't exist.

Your assumption is not correct. The function can't transform your ISBN-13 into
ISBN-10, because it begins with '979'. Rather than returning undef to say that
the conversion is not possible, the function was failing badly, stopping
completely the Perl process. That's what is corrected by the patch.

Have you tried the patch? Does it solve the bug reported here? Can you import
your record? Is your ISBN field preserved? For both records?

The Koha internal function NormalizeISBN is called from other part of the Koha
code base (see bug 13158). When the action requested to the function could not
be completed, the function is supposed to return undef (nothing). That's
exactly what'is done with the patch.

The import process call NormalizeISBN function for whatever reason. I can't say
why, indeed. And for doing nothing with the result, since ISBN field is not
modified during import. But this is another story, and can't be fixed here.

> Bu the way, the initial summary for this bug was "Stage MARC for Import
> hangs", a mistake was done when changing this summary to "Stage MARC for
> Import hangs for biblio containing invalid ISBN-13", so I'll change it to
> "Stage MARC for Import hangs for biblio containing valid 979* ISBN-13" after
> redacting this comment.

You're correct. That's a valid ISBN-13 which can't be converted into ISBN-10.

-- 
You are receiving this mail because:
You are watching all bug changes.