[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Frédéric Demians from comment #6)
> (In reply to Chris Cormack from comment #5)
> 
> > Why are we doing this? Instead of using C4::Template::themelanguage ?
> > 
> > Now we still have different behaviour for xslt and for normal templates
> > 
> > themelanguage will never fallback to prog for the opac. however
> > _get_best_defautl_xslt_filename will.
> > 
> > So if have a new theme chrisc theme. And I make all the stuff, but no new
> > xslt file. It will now fall back to prog, instead of bootstrap.
> > 
> > This is a problem as prog no longer exists in the OPAC.
> 
> Ok. I see. I forgot to modify _get_best_default_xslt_filename to fall back
> to 'bootstrap' theme rather than 'prog' for OPAC interface. 

It should fall back to whateverr OPACFallback is set to. Currently thats
bootstrap, but we dont want to be in this same position when we change default
theme again sometime in the future of having hardcoded theme names.
> 
> There is a difference between C4::Template::themelanguage &
> C4::XSLT::_get_best_default_xslt_filename. 'themelanguage' search tempalates
> in subdirectories of directory named 'modules'.
> '_get_best_default_xslt_filename' search XSL file in a subdirectory named
> 'xslt'.
> 
> Would you suggest to factorize both functions in one?

Something like that, a single place where we pick the theme and language seems
to be a lot less error prone and easier to maintain.

-- 
You are receiving this mail because:
You are watching all bug changes.