[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Robin Sheat from comment #28)
> Is it really coming from Koha::Cache? I haven't had a chance to look yet,
> but I don't really understand those messages, and without understanding
> they'll be hard to fix.

koha at koha-qa:~/src (BZ11998⚡)% perl -wc C4/Context.pm
Subroutine handle_errors redefined at C4/Context.pm line 28.
Constant subroutine C4::Context::CONFIG_FNAME redefined at
/usr/share/perl/5.20/constant.pm line 156.
Subroutine KOHAVERSION redefined at C4/Context.pm line 214.
Subroutine final_linear_version redefined at C4/Context.pm line 234.
Subroutine read_config_file redefined at C4/Context.pm line 263.
Subroutine ismemcached redefined at C4/Context.pm line 279.
Subroutine memcached redefined at C4/Context.pm line 290.
Subroutine db_scheme2dbi redefined at C4/Context.pm line 309.
Subroutine import redefined at C4/Context.pm line 314.
Subroutine new redefined at C4/Context.pm line 353.
Subroutine set_context redefined at C4/Context.pm line 429.
Subroutine restore_context redefined at C4/Context.pm line 468.
Subroutine _common_config redefined at C4/Context.pm line 499.
Subroutine config redefined at C4/Context.pm line 512.
Subroutine zebraconfig redefined at C4/Context.pm line 515.
Subroutine ModZebrations redefined at C4/Context.pm line 518.
Subroutine preference redefined at C4/Context.pm line 540.
Subroutine boolean_preference redefined at C4/Context.pm line 567.
Subroutine enable_syspref_cache redefined at C4/Context.pm line 583.
Subroutine disable_syspref_cache redefined at C4/Context.pm line 597.
Subroutine clear_syspref_cache redefined at C4/Context.pm line 613.
Subroutine set_preference redefined at C4/Context.pm line 628.
Subroutine delete_preference redefined at C4/Context.pm line 676.
Subroutine AUTOLOAD redefined at C4/Context.pm line 703.
Subroutine Zconn redefined at C4/Context.pm line 725.
Subroutine _new_Zconn redefined at C4/Context.pm line 751.
Subroutine _new_dbh redefined at C4/Context.pm line 813.
Subroutine dbh redefined at C4/Context.pm line 878.
Subroutine new_dbh redefined at C4/Context.pm line 912.
Subroutine set_dbh redefined at C4/Context.pm line 937.
Subroutine restore_dbh redefined at C4/Context.pm line 960.
Subroutine queryparser redefined at C4/Context.pm line 984.
Subroutine _new_queryparser redefined at C4/Context.pm line 1004.
Subroutine marcfromkohafield redefined at C4/Context.pm line 1036.
Subroutine _new_marcfromkohafield redefined at C4/Context.pm line 1052.
Subroutine stopwords redefined at C4/Context.pm line 1077.
Subroutine _new_stopwords redefined at C4/Context.pm line 1093.
Subroutine userenv redefined at C4/Context.pm line 1117.
Subroutine set_userenv redefined at C4/Context.pm line 1139.
Subroutine set_shelves_userenv redefined at C4/Context.pm line 1161.
Subroutine get_shelves_userenv redefined at C4/Context.pm line 1169.
Subroutine _new_userenv redefined at C4/Context.pm line 1196.
Subroutine _unset_userenv redefined at C4/Context.pm line 1213.
Subroutine get_versions redefined at C4/Context.pm line 1230.
Subroutine tz redefined at C4/Context.pm line 1256.
Subroutine IsSuperLibrarian redefined at C4/Context.pm line 1271.
Subroutine interface redefined at C4/Context.pm line 1295.
Name "Tie::Hash::FIELDS" used only once: possible typo at
/usr/share/perl/5.20/fields.pm line 135.
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at
/usr/share/perl/5.20/fields.pm line 135.
Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at
/usr/share/perl/5.20/fields.pm line 135.
C4/Context.pm syntax OK

koha at koha-qa:~/src (BZ11998⚡)% perlcritic C4/Context.pm
Variable declared in conditional statement at line 544, column 5.  Declare
variables outside of the condition.  (Severity: 5)

On master:
koha at koha-qa:~/src (master↓⚡)% perl -wc C4/Context.pm
C4/Context.pm syntax OK

koha at koha-qa:~/src (master↓⚡)% perlcritic C4/Context.pm
C4/Context.pm source OK

The perlcritic error is easy to fix, I can provide a followup, but I don't
understand the warnings neither.

-- 
You are receiving this mail because:
You are watching all bug changes.