[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Frédéric Demians from comment #4)
> - A patch add a new TO_PROCESS notice to en/mandatory/sample_notices.sql. Why
>   no notice for other languages?

"Others will be added when the patch will be signed off."
I will do :)

> - notice_unprocessed_suggestion.pl script has no execution permisions like
>   other scripts in misc/cronjobs

Done.

> - The script help should say that the script uses a notice named TO_PROCESS
>
Done.

> - It would be a plus, if running the script without -c were sending the
> result
>   to STDOUT.

Done.

> - Patron name & surname are in TO_PROCESS notice, but are not displayed. It
>   appears that, calling EnqueueLetter, your script doesn't provide borrowers
>   table info. You should have:
> 
>    tables      => {
>        suggestions => $suggestion->{suggestionid},
>        branches    => $patron->{branchcode},
>        borrowers   => $patron->{borrowernumber},
>    },

Done.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.