[Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from Paola Rossi <paola.rossi at cineca.it> ---
Hi, Jonathan, Katrin and Zeno.

In my tests, one subscription about a serial ("IJoC") have been opened to the
vendor "vendor12851".
[My own email was set as the mailing address ("Email") of the vendor12851]
Two issues (Vol.2014 No.11 and Suppl.11) of the subscription were in late, as I
could see in the CSV file, selecting "Downloading selected claims":
--------------------
SUPPLIER,TITLE,ISSUE NUMBER,LATE SINCE             
vendor12851,"International journal on Communication.","Vol. 2014, No.
11",11/06/2014
vendor12851,"International journal on Communication.","Suppl 11",11/06/2014
--------------------

A notice (of module "claimissues") was cloned to CPL. The cloned notice was:
>From <<borrowers.firstname>> <<borrowers.surname>> of  <<branches.branchname>>
Library:
Dear <<aqbooksellers.name>>
The following issues are in late:
<order>Issue <<serial.serialseq>> for serial: <<biblio.title>> has not been
received.</order>
--------------------------------------------
--------------------------------------------
I've applied the patch against master 3.17.00.046 HEAD 10582

I claimed the 2 late issues on Serials > Claims, by selecting "Send
notification". The results in the received email were: 

>From   of  Centerville Library:
Dear vendor12851
The following issues are in late:
Issue  for serial: International journal on Communication has not been
received.
Issue  for serial: International journal on Communication has not been
received.
- - - -
On the contrary, on master 3.17.00.046 HEAD 10582 I received this mail:

>From   of  Centerville Library:
Dear vendor12851
The following issues are in late:
<order>Issue Vol. 2014, No. 11 for serial: International journal on
Communication. has not been received.</order>
>From   of  Centerville Library:
Dear vendor12851
The following issues are in late:
<order>Issue Suppl 11 for serial: International journal on Communication. has
not been received.</order>
- - - -
==============================================================================
The tag <order> ws not show anymore, as required, but the Serial.serialseq
field was not shown anymore against master.
I think this is an error. 
It occurred the same claiming for one issue only.
And so I pass the patch to "Failed QA" status.

Otherwise, if the noted difference is not a problem [or not related to this
bug], I invite you to pass tha patch back to "Needs Sign Off", and I'll sign
off the patch, thanks.

------------------------------------------------------------------------------
To test 12851 I saw at the bug 5342's test plan as indicated. I'm available for
further tests on ACQ (for example about the ACQCLAIM' notice, which is used by
ACQ > Late orders, and has a "<order>"'s tag inside) and further cases of
"multi-lines" orders-to-claim (a 2 books' order to claim to a vendor on ACQ). 
I thought to these 2 cases of "multi-lines" orders-to-claim to a vendor: 
- 2 late issues (1case already tested), 
- 2 late books (2case). 
Please suggest me any possible interesting other ones. 
Or other cases of <<fields>> to test inside the notices, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.