[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

--- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. de Rooy from comment #24)
> (In reply to Jonathan Druart from comment #23)
> Jonathan,
> Any thoughts on comments 18 and 19?

As Martin said, this is the first step to get modules in Koha using DBIC with a
common way.
It will allow developers to easily instantiate objects in pl script.
We already discussed about the abstraction layer and I agree with it. Moreover
Kyle fixed/implemented my concerns (comments 2 and 4).

> Is the idea now to allow DBIC methods ONLY in Koha::Object and Objects? This
> is currently not achieved if you need to pass in a resultset.
> Do we enforce its use in order to prevent chaos? This means creating a lot
> of new modules rightaway..

Yes of course. We will only add methods in Koha::Object[s] if needed and make
sense.
Create 1 module per class in the Koha namespace is the logical consequence of
this patch, it's not a problem.

> Having new and new_from_dbic was qualified above somewhere as a good idea.
> Why?

The first implementation of the constructor was uselessly complicated.
I believe this will add readability.

We already iterated several times with Kyle and other peoples involved, now
it's the time to see something pushed and go further.
It's always possible to improve this code later if it doesn't match our needs
or cause problems.

-- 
You are receiving this mail because:
You are watching all bug changes.