[Koha-bugs] [Bug 11814] Serial statuses should be stored in constants

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #10)
> I've applied the patch against master 3.17.00.054
> 
> I've created a subscription [length > 1 issues].
> Selecting "Serial collection" of the subscription, I checked the EXPECTED
> issue and selected "Edit serials". 
> I changed the issue from the EXPECTED status to the ARRIVED status.
> A new issue in the EXPECTED status should have been created [the next
> issue], but it was not.


Paola,

Sorry for that, 1 replacement was wrong!
I checked all of them and it should be good now.
The new expected issue is now generated.

Changes are:

@@ -1245,7 +1245,7 @@ sub ModSerialStatus {
             }

             $missinglist .= "; $serialseq"
-                if ( ( grep { $_ == $status } ( MISSING_STATUSES, NOT_ISSUED )
) && ( $missinglist !~/(^|;)\s*$serialseq(?=;|$)/ ) );
+                if ( ( grep { $_ == $status } ( MISSING_STATUSES ) ) && (
$missinglist !~/(^|;)\s*$serialseq(?=;|$)/ ) );
             $missinglist .= "; not issued $serialseq"
                 if ( $status == NOT_ISSUED && $missinglist !~
/(^|;)\s*$serialseq(?=;|$)/ );

@@ -1258,7 +1258,7 @@ sub ModSerialStatus {
     }

     # create new waited entry if needed (ie : was a "waited" and has changed)
-    if ( $oldstatus == ARRIVED && $status != ARRIVED ) {
+    if ( $oldstatus == EXPECTED && $status != EXPECTED ) {
         my $subscription = GetSubscription($subscriptionid);
         my $pattern =
C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subscription->{numberpattern});


The first one is a bad merge conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.