[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #43 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Tomás Cohen Arazi from comment #40)
> I don't understand why we would add a transitional logging facility we don't
> need if we can just remove the logging introduced by this patches, that is
> not needed.
> 
> It seems straightforward to think we should have a Koha::SystemPreferences
> class soon that can do the loggin properly without introducing circular
> dependencies. That is out of the scope of this bug, for sure.
> 
> Also, are we sure we need global variables?
> 
> I was just about to post counter patches (attributed to Robin) that just
> remove the introduction of logaction here, but I thought it would be better
> to just write this lines here.

Well my thinking was:
1) Logging the same thing in multiple places is bad and wrong and should be
removed whenever the chance arises.
2) C4::Context should have the facility to do logging
3) This centralises things which makes it easier to implement an even better
Koha::SystemPreferences module later.

-- 
You are receiving this mail because:
You are watching all bug changes.