[Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
This is a nice feature and it seems to be working well. I have some suggestions
for ways to make the patch conform better to some existing practices:

- <script> blocks should not be added to masthead.inc. In the bootstrap theme
JavaScript is placed at the end of the document: opac-bottom.inc

- jQuery plugins which are included by OPAC pages should be minified. I think
it's helpful to add both the minified and non-minified versions even if we only
link to the minified version. But that's not an agreed-upon rule.

- The "Return to the last advanced search" link should be added to the DOM (or
made visible) using JavaScript since the feature depends on JavaScript. Users
without JS should not see the link.

I'm curious why you use the jQuery.cookie plugin in some code but not in the
changes you made to masthead.inc?

Finally: This patch makes changes to .htaccess and it should not.

-- 
You are receiving this mail because:
You are watching all bug changes.