[Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from simith.doliveira at inlibro.com ---
Concerning some suggestions/error :


- <script> blocks should not be added to masthead.inc. In the bootstrap theme
JavaScript is placed at the end of the document: opac-bottom.inc

Done

- jQuery plugins which are included by OPAC pages should be minified. I think
it's helpful to add both the minified and non-minified versions even if we only
link to the minified version. But that's not an agreed-upon rule.

Done. But I included just the minifieds.

- The "Return to the last advanced search" link should be added to the DOM (or
made visible) using JavaScript since the feature depends on JavaScript. Users
without JS should not see the link.

The link is controlled by a cookie, this cookie est created by js, so, without
js, no link.

I'm curious why you use the jQuery.cookie plugin in some code but not in the
changes you made to masthead.inc?

Both use jQuery.cookie now.

Finally: This patch makes changes to .htaccess and it should not.

Corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.