[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33885|1                           |0
        is obsolete|                            |

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 33885
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33885
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer

Review of attachment 33885:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12123&attachment=33885)
-----------------------------------------------------------------

I definitely prefer Liz's patch over Kyle's. I don't think iframes are needed
at all. It looks like the problem is that we were trying to stuff HTML into a
"p" element which couldn't take them as children.

The only thing stopping my sign off would be the inline CSS. I find the CSS
isn't necessary when I test it, and I suppose if it is necessary for other
browsers, I would just prefer it to be in a stylesheet somewhere else so we can
control our styles better.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
@@ +41,4 @@
>  <h1>Sent notices for [% INCLUDE 'patron-title.inc' %]</h1>
>  
>  [% IF ( QUEUED_MESSAGES ) %]
> +    <table id="noticestable" style="table-layout: fixed">

Using Chrome on Windows, I don't find this CSS does anything. If anything, it
makes the presentation slightly worse.

However, if we do include it, my only request would be to not use inline CSS
and to put this in a separate stylesheet somewhere like staff-global.css or
something like that.

@@ +55,4 @@
>  	    <tr>
>  		<td>
>              <a class="notice-title" href="#">[% QUEUED_MESSAGE.subject %]</a>
> +            <div class="notice">

Switching to a div fixes this problem nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.