[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #32 from Magnus Enger <magnus at enger.priv.no> ---
Looks like the failing tests i reported in comment 26 were due to 
1. How I was running the tests
2. Missing sample data (I had the nb-NO sample data, not the en ones)

$ sudo -u kohadev-koha KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml prove
t/db_dependent/Calendar.t t/db_dependent/Holidays.t t/Calendar.t
t/db_dependent/Calendar.t .. ok     
t/db_dependent/Holidays.t .. ok   
t/Calendar.t ............... ok     
All tests successful.
Files=3, Tests=54,  5 wallclock secs ( 0.03 usr  0.01 sys +  0.84 cusr  0.95
csys =  1.83 CPU)
Result: PASS

But I still see some problems:

1. The sorting of dates from comment 27 and attachment 33415
2. The merge conflicts reported in comment 31

I made a branch before the conflicts were introduced, to do some more testing:

3. If I add a weekly repeating event, like saying the library is closed every
Friday, I click on "Save" and then I get a page that just says "Fridays". No
Koha UI or anything, just that word. If I view source, the source also contains
nothing but the word "Fridays". No HTML or anything like that. If I open the
URL for the intranet main page and navigate to Tools > Calendar the same thing
happens, I get just the word "Fridays". If I go into the database and delete
the relevant entry from repeatable_holidays, the calendar displays as it should
again.
4. With this patch applied you now get to choose if the library is open or
closed when you add an event. As far as I can tell, the
special_holidays.isexception field is used to record open/closed. But the
description for this field is "is this a holiday exception to a repeatable
holiday (1 for yes, 0 for no)". Is open/closed a sensible use/interpretation of
this field? I am not sure of the usage, so I am only raising this as a
question.

-- 
You are receiving this mail because:
You are watching all bug changes.