[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #39 from Magnus Enger <magnus at enger.priv.no> ---
(In reply to Kyle M Hall from comment #38)
> > 3. If I add a weekly repeating event, like saying the library is closed
> > every Friday, I click on "Save" and then I get a page that just says
> > "Fridays". No Koha UI or anything, just that word. If I view source, the
> > source also contains nothing but the word "Fridays". No HTML or anything
> > like that. If I open the URL for the intranet main page and navigate to
> > Tools > Calendar the same thing happens, I get just the word "Fridays". If I
> > go into the database and delete the relevant entry from repeatable_holidays,
> > the calendar displays as it should again.
> 
> I think you may be seeing bug 13097, which I don't believe is directly
> related to this patch. However, if you are not seeing this problem without
> this patch, I am probably wrong ; )

The result looks the same as in the video on bug 13097, but it happens even if
I do not have an ampersand in the title or description. Yearly works. But if I
click on a date, choose "Closed", give it a title like "test" and choose "Event
repeated weekly" I get this weird error, just showing the day of the week. 

There is nothing in the intranet error log when i save the weekly event, but
when I try to view the calendar.pl page later, I get this:

[Tue Nov 25 13:50:05 2014] [error] [client 10.0.2.2] [Tue Nov 25 13:50:05 2014]
calendar.pl: Use of uninitialized value in split at
/home/vagrant/kohaclone/tools/calendar.pl line 105.

Line 104 etc looks like this:

if ( $input->param( 'allBranches' ) || !$input->param( 'branchName' ) ) {
    @branches = split /\|/, $input->param( 'branchcodes' );
} else {
    @branches = ( $input->param( 'branchName' ) );
}

It looks slightly suspicious that it checks for "allBranches" and then splits
"branchcodes", but that is just a hunch, really. 

The intranet access log has:

10.0.2.2 - - [25/Nov/2014:13:58:20 +0000] "GET /cgi-bin/koha/tools/calendar.pl
HTTP/1.1" 200 10319

If i remove the weekly event from the database and reload the page, I get this:

10.0.2.2 - - [25/Nov/2014:14:02:16 +0000] "GET /cgi-bin/koha/tools/calendar.pl
HTTP/1.1" 200 10114

So it looks like the size of those pages is pretty similar, even when the page
and the source is only showing the name of the week...

-- 
You are receiving this mail because:
You are watching all bug changes.