[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
Thinking again... I can see the merit of using an iframe instead of a div. 

After all, the div only works because "p" and "blockquote" can be children of a
"div".

If a person put "html" and "body" tags into the message, those the HTML would
be invalid.

*does a test*

Mmm, instead of busting the notice viewer, Chrome removes the "html" and "body"
tags. (So the viewer continues to work fine, although you'll still notice the
"html" and "body" tags in the message_queue.)

I've noticed libraries put "html" and "body" tags in their notices before,
which is why this comes into my mind.

Chrome is pretty rad at cleaning up tag soup, but I'm not sure about Firefox or
Internet Explorer...

Microsoft Outlook seems capable of handling a HTML email with "html" and "body"
tags inside of a "body" tag. I suppose most email clients are pretty flexible
when it comes to invalid HTML markup.

In any case, I think Liz's solution works. If any problems arise in the future,
I suppose we can address them then. (Or possibly strip "body" and "html" tags
when saving notice templates.)

-- 
You are receiving this mail because:
You are watching all bug changes.