[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |julian.maurice at biblibre.com

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Theses patches work as intended and, as the current behaviour is unchanged by
default, I see no reason to not apply it on master.

But there is some minor issues that should be addressed.
First, koha-qa is reporting an error:

testing 2 commit(s) (applied to b141e6d 'Bug 13332: Fix conflict between 5304
')

 FAIL   C4/Auth_with_ldap.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                "my" variable $sth masks earlier declaration in same scope 
   OK     critic

Also I think the two prepared statements can be replaced by
$dbh->selectrow_array() and $dbh->do()

Finally the die message (Unable to access borrowernumber...) starts on first
column and breaks the indentation style. Maybe you could split the string, or
just leave the string overflow the 80 characters limit, I don't know if there
is any rule for that.

So, failing QA for the first point (koha-qa)

-- 
You are receiving this mail because:
You are watching all bug changes.