From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 02:17:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 00:17:48 +0000
Subject: [Koha-bugs] [Bug 11362] increase zebra AUTH register sizes,
from 4G to 20G
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362
--- Comment #4 from Mason James ---
(In reply to Robin Sheat from comment #3)
> Are there any negative effects to having a large index size? Probably not
> that outweighs the disadvantages to having one that's too small...
afaik, no - everything 'just works' as expected
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 09:42:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 07:42:23 +0000
Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
CC| |jonathan.druart at biblibre.co
| |m
Assignee|yohann.dufour at biblibre.com |chris at bigballofwax.co.nz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 09:58:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 07:58:33 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
libraries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 10:44:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 08:44:08 +0000
Subject: [Koha-bugs] [Bug 12833] Patron search no longer searches extended
attributes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12648
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 10:44:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 08:44:08 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
Depends on| |12833
--- Comment #14 from Jonathan Druart ---
Bug 12833 breaks this enh.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:19:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:19:08 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:19:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:19:23 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
--- Comment #15 from Jonathan Druart ---
Created attachment 31960
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31960&action=edit
Bug 12648: Fix conflict with bug 12833
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:19:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:19:29 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
--- Comment #16 from Jonathan Druart ---
Created attachment 31961
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31961&action=edit
Bug 12648: Hide the result search on load
When no search has been done yet, it's not necessary to display the
result list.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:25:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:25:58 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |z.tajoli at cineca.it
--- Comment #3 from Zeno Tajoli ---
Hi Jonathan,
we have problem to test this patch.
Could you tell us where footerCallback function doesn't work with present
version
and it needs 1.10.2 of DataTables jQuery plugin ?
About the change of 1.10 (reading http://datatables.net/upgrade/1.10):
-- Pagination (two_button), is present only in datatables.css,a css that came
with the plugin. So is not used by us
-- function fnRender: we don't use it.
-- function bScrollInfinite: we don't use it
-- Could be problems with IE6/IE7: from 1.10.2 of DataTables jQuery plugin
cookie based state saving has been replaced with localStorage based state
saving.
This function is not availabe in IE6/IE7 there are same way to live with this
[The stateLoadCallbackDT and stateSaveCallbackDT parameters can be used to
provide a suitable function if you wish to use cookies.]
-- Question: Do we use API plug-ins of ataTables jQuery plugin ?
A real question, I don't know the answer.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:26:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:26:50 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oleonard at myacpl.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:44:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:44:19 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:44:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:44:22 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31605|0 |1
is obsolete| |
Attachment #31607|0 |1
is obsolete| |
Attachment #31672|0 |1
is obsolete| |
--- Comment #24 from Kyle M Hall ---
Created attachment 31962
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31962&action=edit
Bug 12892 - Add Koha::Object, Koha::Objects and unit tests
This patch adds the base classes upon which we can build
new Koha classes to give us smarter, simpler code.
Test Plan:
1) Apply this patch
2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:44:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:44:32 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
--- Comment #25 from Kyle M Hall ---
Created attachment 31963
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31963&action=edit
Bug 12892 - Holds Waiting: not showing from check out screen
When a patron has holds waiting to be pick up, they used to show in the
check out screen. These notifications are no longer showing in 3.16.
Test Plan:
1) Apply this patch
2) Create a hold, set to waiting
3) Browse to circulation.pl for that patron
4) Note you see the list of waiting holds
5) Switch you logged in branch to a different branch
6) Note the "Waiting at" line is no longer emphasized.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:45:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:45:04 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31471|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:45:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:45:12 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31472|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:45:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:45:20 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31670|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:47:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:47:35 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #4 from Jonathan Druart ---
Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without this
one.
The behavior was broken without updating the DT plugin.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:53:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:53:47 +0000
Subject: [Koha-bugs] [Bug 13018] New: Static fine should apply only once for
a given borrower
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018
Bug ID: 13018
Summary: Static fine should apply only once for a given
borrower
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: sophie.meynieux at biblibre.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Once a borrower is charged for overdues, staticfine.pl execution should not add
a new fine each time.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:54:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:54:32 +0000
Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a
given borrower
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=6858
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:54:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 09:54:32 +0000
Subject: [Koha-bugs] [Bug 6858] Adds staticfines.pl for static fines
processing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=13018
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 12:08:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 10:08:49 +0000
Subject: [Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email
address for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530
--- Comment #39 from Martin Renvoize ---
This wiki snippet I did may be useful to anyone documenting this feature.
I'll be happy to explain further upon request
http://wiki.koha-community.org/wiki/MRenvoize/Email
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:32:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:32:28 +0000
Subject: [Koha-bugs] [Bug 13019] New: Add base classes on which to build
Koha objects
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
Bug ID: 13019
Summary: Add base classes on which to build Koha objects
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcharlt at gmail.com
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
The idea behind this is to have a pair of base classes on which to build our
new generation of Koha objects. Koha::Object is a base class, which in it's
most basic form, is to represent a row in a table. For example, Koha::Borrower
inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for
example.
Koha::Objects is to represent a way to fetch and manipulate sets of objects.
For example, Koha::Borrowers has a method to get a Koha::Borrower object by id
and a method to search for an get a list of Koha::Borrower objects. Right now
Koha::Objects has only the essentials but can easily be extended and those
enhancements will be passed down to all the child classes based on it.
By using these classes as a base, we will add consistency to our code, allow us
to keep our code DRY, reduce bugs, and encapsulate our database access among
other benefits.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:33:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:33:12 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:37:24 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:37:26 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
--- Comment #1 from Kyle M Hall ---
Created attachment 31964
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31964&action=edit
Bug 13019 - Add base classes on which to build Koha objects
The idea behind this is to have a pair of base classes on which to build
our new generation of Koha objects. Koha::Object is a base class, which
in it's most basic form, is to represent a row in a table. For example,
Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio
and Koha::Item for example.
Koha::Objects is to represent a way to fetch and manipulate sets of
objects. For example, Koha::Borrowers has a method to get a
Koha::Borrower object by id and a method to search for an get a list
of Koha::Borrower objects. Right now Koha::Objects has only the
essentials but can easily be extended and those enhancements will be
passed down to all the child classes based on it.
By using these classes as a base, we will add consistency to our
code, allow us to keep our code DRY, reduce bugs, and encapsulate our
database access among other benefits.
Test Plan:
1) Apply this patch
2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:37:42 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13019
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:37:42 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12892
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:38:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 11:38:40 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31962|0 |1
is obsolete| |
--- Comment #26 from Kyle M Hall ---
Comment on attachment 31962
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31962
Bug 12892 - Add Koha::Object, Koha::Objects and unit tests
Moving the base class patch to it's own bug. Bug 13019.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:02:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:02:39 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #5 from Owen Leonard ---
Zeno are you finding errors when testing this patch or do you question whether
we should be upgrading DataTables at all?
Is it continued support for IE6/7 which is at issue here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:25:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:25:44 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
--- Comment #14 from Colin Campbell ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Created attachment 31623 [details] [review] [review]
>
> Rolando and Colin, could it be possible to get your point of view on this
> patch please?
(In reply to Rolando Isidoro from comment #13)
> Hey Johnathan, your patch complexity and range greatly exceeds my knowledge
> of Koha's source code. Colin, what's your take on this?
>
> Rolando
This changes behaviour in an undocumented way if I pass a tz other than
C4::Context's it seems in some strings (need more test cases) to be changing to
the system tz but not correctly converting the date ... It also adds processing
to a frequently used routine which is not efficient e.g. the evals are
unnecessary if anything failes the date parse returns undef flagging the error.
I'll try testing some more inputs to this
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:27:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:27:20 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:34:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:34:19 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paola.rossi at cineca.it
--- Comment #6 from Paola Rossi ---
(In reply to Jonathan Druart from comment #4)
Zeno and I thank you, Jonathan.
> Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without
> this one.
1) I think the first bug was 12987, wasn't it?
2) Before trying to apply tha patch, I'm in doubt about 12987.
A) On the graph at kindly prepared
at bug-12825, the two bugs 12988 and 12989 depend on 12987, and 12987 depends
on this current bug 12986.
So the "blocks" set of this bug 12986 should be limited to 12987.
And the bug 12988 would depend on bug 12987, instead of bug 12986 presently
shown.
And the bug 12989 would depend on bug 12987, instead of bug 12986 presently
shown.
B) Otherwise, in the graph the two bugs 12988 and 12989 would point directly to
12986, instead of pointing to 12987.
The "blocks" set of this bug 12986 should remain the same: 7,8 and 9.
And the bug 12988 keeps on depending on the bug 12986 presently shown.
And the bug 12989 keeps on depending on the bug 12986 presently shown.
Thank you in advance.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:35:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:35:49 +0000
Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's
checkouts in circulation and patron details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31160|0 |1
is obsolete| |
--- Comment #12 from Kyle M Hall ---
Created attachment 31965
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31965&action=edit
Bug 12550 - Add ability to delay loading of patron's checkouts in circulation
and patron details
Rebased patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:40:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:40:00 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #2 from Jonathan Druart ---
First thoughts (already sent on #koha):
1/ Type and ObjectClass could be attributes, instead of methods
2/ I really would like to see method name without capital letters (and
underscore '_' to separate words)
3/ "Bad setter returns undef" => not sure about that. Bad setter should croak
4/ What about using Class::Accessor?
5/ t/db_dependent/Objects.t should be t/db_dependent/Borrowers.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:45:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:45:13 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #7 from Zeno Tajoli ---
(In reply to Owen Leonard from comment #5)
> Zeno are you finding errors when testing this patch or do you question
> whether we should be upgrading DataTables at all?
In fact the question is more "Should we upgrade DataTables".
- I don't have a PC with IE6/IE7 so I can't test if we have a problem with
version 10.x of DataTables
> Is it continued support for IE6/7 which is at issue here?
I think yes.
The other problem are any plugin that use API of DataTables plugin.
Do you know our situation about this ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:50:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:50:13 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #8 from Owen Leonard ---
I haven't tested this patch at all so I don't know if the upgrade causes any
problems. However, I think we should always try to keep up to date with the
libraries Koha uses unless there is some specific reason not to.
In my opinion the possibility that it may cause problems for IE6/7 is not
enough of an issue to block an upgrade to the plugin.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:59:55 +0000
Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12989
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:59:55 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|12989 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:59:55 +0000
Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows -
acqui-home
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|12986 |12987
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:59:59 +0000
Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows -
budgets
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|12986 |12987
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:59:59 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|12988 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 12:59:59 +0000
Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12988
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:01:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:01:25 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #9 from Jonathan Druart ---
(In reply to Paola Rossi from comment #6)
> (In reply to Jonathan Druart from comment #4)
>
> Zeno and I thank you, Jonathan.
>
> > Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without
> > this one.
>
> 1) I think the first bug was 12987, wasn't it?
Yes of course, sorry.
> 2) Before trying to apply tha patch, I'm in doubt about 12987.
Yes, the graph is correct!
I updated the dependencies on bugzilla.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:02:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:02:26 +0000
Subject: [Koha-bugs] [Bug 13020] New: Checkouts table default ordering is
incorrect
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
Bug ID: 13020
Summary: Checkouts table default ordering is incorrect
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
The checkouts table is no longer keeping "today's checkouts" in the order they
were scanned.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:04:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:04:47 +0000
Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is
incorrect
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
--- Comment #1 from Kyle M Hall ---
Created attachment 31966
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31966&action=edit
Bug 13020 - Checkouts table default ordering is incorrect
The checkouts table is no longer keeping "today's checkouts" in the
order they were scanned.
Test Plan:
1) Create 3 records "Test 1", "Test 2" and "Test 3" each with one item
2) Check out the items to a patron in the order "Test 2", "Test 1", "Test 3".
3) Note the order is incorrect.
4) Apply this patch
5) Refresh the page
6) Note the order is now correct
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:04:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:04:45 +0000
Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is
incorrect
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:04:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:04:58 +0000
Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is
incorrect
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
Severity|minor |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:05:05 +0000
Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a
given borrower
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018
--- Comment #1 from Sophie MEYNIEUX ---
Created attachment 31967
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31967&action=edit
Bug 13018 : Static fine should be charged only once
Test plan (see Bug 6858 for using staticfine.pl) :
For a user (of a given category and library) with several overdues, launch the
script :
staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY
Then, check that the user has been charged of AMOUNT if the due date of the
most late item plus the delay is *before* today.
One day later, re-execute the script with the same parameters and check that
the fine has not been charged twice.
Without patch, the fine is charged twice, with patch the user already charged
is skipped (see output in debug mode)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:05:13 +0000
Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is
incorrect
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:05:26 +0000
Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is
incorrect
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12550
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:05:26 +0000
Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's
checkouts in circulation and patron details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |13020
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:05:29 +0000
Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a
given borrower
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:14:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 13:14:06 +0000
Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's
checkouts in circulation and patron details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550
--- Comment #13 from Kyle M Hall ---
Created attachment 31968
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31968&action=edit
Bug 12550 [QA Followup] - Make checking the checkbox load the table of
checkouts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:44:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 14:44:06 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Heather Braum changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hbraum at nekls.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:51:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 14:51:51 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |ASSIGNED
CC| |jonathan.druart at biblibre.co
| |m
Assignee|yohann.dufour at biblibre.com |jonathan.druart at biblibre.co
| |m
--- Comment #9 from Jonathan Druart ---
If I am not wrong, there are 3 occurrences of C4::Members::Search:
1/ acqui/aqbasketuser_search.pl
2/ members/guarantor_search.pl
3/ patroncards/members-search.pl
1 is removed by 12648, I have a patch for 2.
3 is todo.
When done, I will completely remove the C4::Members::Search subroutine.
Some code should be move from C4::Utils::DT::Members to C4::Members (or
Koha::Members).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:52:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 14:52:08 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12633
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:52:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 14:52:08 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12648
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 18:24:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 16:24:01 +0000
Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't
have patron images use preceding card's image
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604
lightpurpledye at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lightpurpledye at gmail.com
--- Comment #2 from lightpurpledye at gmail.com ---
This problem goes away if you comment out lines 152 - 159 of
/usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif
($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images') {"
).
However, doing this also breaks the display of any "Other Image"s (non-patron
photo images) on the card layout.
I have tried adding "$image_data = undef" to the beginning of the foreach loop,
and between lines 152 and 153, under the assumption that $image_data still
contains the image data from the previous iteration until it is reassigned, but
this had no effect.
I think that for some reason the elsif condition on line 152 is matching users
which don't have a photo assigned, but I still don't know why that would result
in the behaviour observed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 18:56:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 16:56:50 +0000
Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't
have patron images use preceding card's image
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604
--- Comment #3 from Chris Nighswonger ---
(In reply to lightpurpledye from comment #2)
> This problem goes away if you comment out lines 152 - 159 of
> /usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif
> ($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images')
> {" ).
>
> However, doing this also breaks the display of any "Other Image"s
> (non-patron photo images) on the card layout.
>
The file in question is create-pdf.pl
Your test indicates that at least on your system there may be patron images
stored where "creator_images" should be. This entire block of code
(PROCESS_IMAGES [1]) is prefaced on layout xml like this:
It looks at the data_source key in particular for the "source" of the image.
"creator_images" are stored in a table by the same name in the db. This is a
different source than patron images which are stored in the patronimage table.
The fact that commenting out the condition which allows for retrieval of
creator_images "fixes" the problem would seem to indicate a misunderstanding of
what images should be stored where. An image stored in the creator_images table
and used in a patroncard layout will appear on every card in any batch using
that layout. Images stored in the patronimage table will (should) appear only
on cards which include that patron.
I have not had time to try this bug out, but what you describe seems to be more
related to misunderstanding what images should be stored where. Hopefully that
clarifies things a bit. If I've not understood, feel free to let me know.
[1] http://tinyurl.com/kfh5vbn
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 19:20:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 17:20:22 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
--- Comment #3 from Kyle M Hall ---
> 1/ Type and ObjectClass could be attributes, instead of methods
Could write a followup? I tried to do that but had issues with getting the base
class to know about the package variable. I was properly implementing it wrong.
> 2/ I really would like to see method name without capital letters (and
> underscore '_' to separate words)
I have no strong preference here as long as we stick to one convention. My only
concern would be a convention conflict where a table has the same name as a
field in the table. That would lead to ambiguity, but I'm not sure if we even
have an instance of this. For example, let's say a table has the field borrower
which is actually a borrowernumber. I'd like to have $row->borrower return the
borrowernumber, but $row->Borrower return the Koha::Borrower object. That way
we know when we are getting back a scalar, and when we are getting back an
Object. It would be silly to fetch the Koha::Borrower in a case where we just
need the borrowernumber, which we would already have.
> 3/ "Bad setter returns undef" => not sure about that. Bad setter should croak
Agreed.
> 4/ What about using Class::Accessor?
I don't see the advantage to this. Can you give an example. This implementation
uses a DBIC object as a place to store the data, so there is no need to have
separate properties. Please note the this should not conflict this unit testing
on a database-less system. t/Object.t should demonstrate this.
> 5/ t/db_dependent/Objects.t should be t/db_dependent/Borrowers.t
I can see your point, but the tests are really testing the base classes, and
not the Borrower classes per se. However, I have no strong opinion so that's
fine by me.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 20:07:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 18:07:35 +0000
Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't
have patron images use preceding card's image
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604
--- Comment #4 from lightpurpledye at gmail.com ---
Oops, I did mean create-pdf.pl, well spotted.
I don't think I've misunderstood where images should be stored, however. I only
have one image in the creator_images table in the db, which I wish to be
displayed on every card.
The patron images are all in the patronimage table (uploaded using the bulk
Upload Patron Images tool). It's just that some patrons do not have images set,
but creating a card for them still displays an image, but of a different
patron.
N.B. The self-checkout module does not display any images for these patrons,
and there is no image set for them in the patronimage table, so I am fairly
sure it's a bug in the Patron Card Creator module rather than anything else.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 20:29:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 18:29:33 +0000
Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't
have patron images use preceding card's image
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604
--- Comment #5 from Chris Nighswonger ---
(In reply to lightpurpledye from comment #4)
> Oops, I did mean create-pdf.pl, well spotted.
>
> I don't think I've misunderstood where images should be stored, however. I
> only have one image in the creator_images table in the db, which I wish to
> be displayed on every card.
>
> The patron images are all in the patronimage table (uploaded using the bulk
> Upload Patron Images tool). It's just that some patrons do not have images
> set, but creating a card for them still displays an image, but of a
> different patron.
So it sounds like your images are in the correct location. However, that only
makes it a bit more confusing as to why commenting out code which inserts the
image for every card would "fix" the duplicate patron image issue. So I'll just
have to find time to duplicate the bug and look at what's going on there.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 20:32:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 18:32:56 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Heather Braum changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hbraum at nekls.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 21:18:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 19:18:03 +0000
Subject: [Koha-bugs] [Bug 12656] add a notice that tells patrons when their
hold was cancelled because it wasn't picked up in time
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656
Agnes Rivers-Moore changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arm at hanover.ca
--- Comment #1 from Agnes Rivers-Moore ---
I agree. I am disappointed that Koha leaves no trace for staff or borrower when
a hold is cancelled.
Perhaps there could be a preference choice whether to send a notice for all
cancelled holds, or just for those cancelled after waiting too long for pickup.
Having that notice show up in the borrower messages tab would be really useful!
Agnes
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 21:45:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 19:45:09 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Agnes Rivers-Moore changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arm at hanover.ca
--- Comment #76 from Agnes Rivers-Moore ---
We would like the option to have a shorter pickup period for some item types.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 21:56:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 19:56:09 +0000
Subject: [Koha-bugs] [Bug 1807] search () give odd results
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jesse at bywatersolutions.com
--- Comment #8 from Jesse Maseto ---
//Fix subject search by striping parenthesis from url links
$('#catalogue_detail_biblio a[href*="su:"]').attr('href', function(_,v){
return v.replace(/(\(|\))/g,'')
});
This works for both the staff search and OPAC.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 23:47:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 21:47:54 +0000
Subject: [Koha-bugs] [Bug 12876] Reserve in waiting/transfer status may be
cancelled by user
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12876
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|Koha security |
Component|Koha |Hold requests
Version|unspecified |master
Product|Koha security |Koha
QA Contact| |testopia at bugs.koha-communit
| |y.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 23:48:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 21:48:43 +0000
Subject: [Koha-bugs] [Bug 12873] Reserve can be cancelled by any logged in
user
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12873
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
Group|Koha security |
CC| |gmcharlt at gmail.com
Component|Koha |Hold requests
Version|unspecified |master
Product|Koha security |Koha
QA Contact| |testopia at bugs.koha-communit
| |y.org
--- Comment #12 from Galen Charlton ---
Pushed to 3.16.x for inclusion in 3.16.4.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 00:25:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 22:25:25 +0000
Subject: [Koha-bugs] [Bug 12849] Sending a list has malformed links
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_3_16_5_candidate
CC| |gmcharlt at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 00:26:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Oct 2014 22:26:02 +0000
Subject: [Koha-bugs] [Bug 12849] Sending a list has malformed links
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:29:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 07:29:25 +0000
Subject: [Koha-bugs] [Bug 13021] New: DataTables server-side processing -
guarantor search
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021
Bug ID: 13021
Summary: DataTables server-side processing - guarantor search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart at biblibre.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Bug 12648 refactores some code for the patron search (link patrons to a basket
and an order, in the acquisition module).
This code can be reuse for the guarantor search.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:30:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 07:30:05 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
guarantor search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Blocks| |12633, 12648
Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
|ity.org |m
--- Comment #1 from Jonathan Druart ---
This will remove 1 call to C4::Members::Search (see bug 12633).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:30:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 07:30:05 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13021
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:30:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 07:30:05 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13021
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:03:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:03:15 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #77 from Paul Poulain ---
(In reply to Agnes Rivers-Moore from comment #76)
> We would like the option to have a shorter pickup period for some item types.
Sorry, but this patch does not apply anymore, and should be rewritten almost
from scratch because another patch has been pushed before this one, that make
what Jonathan made invalid.
So, without funding to re-do the work, we (BibLibre) will not work on it
anymore, sorry.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:12:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:12:17 +0000
Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the
patron import tools
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929
Petter Goks?yr ?sen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:12:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:12:19 +0000
Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the
patron import tools
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929
Petter Goks?yr ?sen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31637|0 |1
is obsolete| |
--- Comment #2 from Petter Goks?yr ?sen ---
Created attachment 31969
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31969&action=edit
Bug 12929: Restore behavior before bug 12716
This patch remove borrowernumber from the borrower list fields and
display the field list in the notes.
Test plan:
- verify that the list of fields is displayed on the right (Notes).
- verify the borrowernumber is not displayed anymore in the field list.
Signed-off-by: Petter Goksoyr Asen
Confirmed that this patch removes borrowernumber from list of default
values, and reintroduces missing list of CSV columns in the Notes field.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:27:26 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
guarantor search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:27:28 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
guarantor search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021
--- Comment #2 from Jonathan Druart ---
Created attachment 31970
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31970&action=edit
Bug 13021: guarantor search - prepare existing code to be reused
The add_user_search tt file will be reuse in next commits, this commit
just moves it in a "common" directory.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:27:36 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
guarantor search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021
--- Comment #3 from Jonathan Druart ---
Created attachment 31971
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31971&action=edit
Bug 13021: guarantor search - main patch
This patch is the main patch.
The "common" template is improved to allow different type of picking:
"add" or "select".
The first one appends a patron to a list, the second one selects the
patron and close the result search window.
The members/guarantor_search.pl has completly changed but is quite the
same file as acqui/add_user_search.pl. Both should exist: they don't
belong to the same module (acqui vs members), the picking type is
different (add vs select) and the columns are not the same.
The changes in the common template are very powerful, it's now possible
to list the column we want! This will be very useful for further
reusability.
Before this patch, all patrons mathing the pattern were return. Now only
the first 20 are (depends on the DataTables selected value).
For QA: This patch introduces a new template plugin "To", for now it
permits to convert a perl structure to json. In the idea, it could
permit to convert foo to bar too.
Test plan:
1/ Verify there is no regression in the guarantor search. When the
selection has been done, all data from the guarantor should fill the
form in the "main address" section.
Note that the request is done when the search input in not empty and the
user stop to write for 1 sec.
2/ Verify there is no regression on the 2 other pages where this patron
search is used: link a patron to an order and to a basket (in the
acquisition module).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:27:40 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
guarantor search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021
--- Comment #4 from Jonathan Druart ---
Created attachment 31972
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31972&action=edit
Bug 13021: guarantor search - guarantor_search.tt is useless
The guarantor_search.tt is now useless, no script uses it.
It can be removed safely.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:28:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:28:34 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633
--- Comment #10 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #9)
> 1 is removed by 12648, I have a patch for 2.
The call in guarantor_search is removed by 13021.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:51:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 08:51:07 +0000
Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133
Jesse Weaver changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19326|0 |1
is obsolete| |
Attachment #19740|0 |1
is obsolete| |
--- Comment #14 from Jesse Weaver ---
Created attachment 31973
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31973&action=edit
Bug 8133 - hourly loans doesn't know when library closed
This adds support for storing library hours in the calendar, and using
those hours to compute hourly loan duetimes.
A large amount of cleanup was also performed to expunge duplication of
code between C4::Calendar and Koha::Calendar.
Test plan:
1) Apply patch.
2) Update database.
3) Verify that the calendar administration interface still exists and
works as expected.
4) Run t/Calendar.t and t/db_dependent/Calendar.t.
(This version is truly based on bug 11211, and folds in Liz's followup.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 11:05:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 09:05:06 +0000
Subject: [Koha-bugs] [Bug 1973] Acquisitions : receive items that haven't
been ordered
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1973
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |z.tajoli at cineca.it
Resolution|--- |INVALID
--- Comment #2 from Zeno Tajoli ---
The user needed only a suggestion to do the operation with thea actual
interface
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 12:35:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 10:35:37 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
stylesheets over HTTPS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|XSLT imports containing a |Failure when loading or
|https href in a XSLT |parsing XSLT stylesheets
|stylesheet fail to work |over HTTPS
|with LibXML's load_xml in |
|XSLT_Handler |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 13:46:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 11:46:25 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
stylesheets over HTTPS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758
--- Comment #4 from M. de Rooy ---
I have renamed this report to widen its scope.
Actually, I see here two related problems:
1) LibXML does not like https references when loading xml with the location
parameter. This can be resolved by reading the file into a string and passing
it to load_xml via the string parameter. (A solution within LibXML for https
appears not to be expected for now.)
Note btw bthat reading the file might not be working rightaway. If you
LWP::UserAgent to get the file contents, it will need LWP::Protocol::https.
This dependency was recently added to Koha as optional in the context of
OverDrive integration. Should we mark it as required now?
2) If the stylesheet (via local file, http or https) contains an import with a
https reference, LibXML can load it (possibly with the workaround under point
1), but LibXSLT will now fail parsing it with: "I/O warning : failed to load
external entity". This is harder to resolve; we should not be replacing imports
in xslt code ourselves. The problem seems to go down deeper to the libxml2 C
library.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:00:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:00:18 +0000
Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't
have patron images use preceding card's image
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604
lightpurpledye at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|3.8 |3.14
--- Comment #6 from lightpurpledye at gmail.com ---
Possibly related: If the image file for one patron has a greater
horizontal:vertical ratio than the image file for the patron immediately after
them in the batch, then the first patron's image is shown below the second
patron's image.
e.g. Steps to reproduce
1. In the patron creator, set up a layout with patron images enabled.
2. Create a batch starting with a patron that has a 300x100 image stored.
3. Next choose one with a 200x100 image.
4. Export the batch.
5. Resulting PDF will show:
i) The first one is correct (patron a's picture)
ii) The second one is incorrect (There are 100 pixels of patron a showing
underneath patron b).
This suggests to me that when the PROCESS_IMAGES loop has an iteration it
actually prints the image in every subsequent image position and then relies on
the incorrect images being printed over in the next iteration. This would
explain why, if a patron does not have an image stored, they would get the
previous patron's image.
If this turns out to be unrelated, I can open a separate bug report for it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:04:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:04:58 +0000
Subject: [Koha-bugs] [Bug 12873] Reserve can be cancelled by any logged in
user
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12873
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #13 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:10:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:10:21 +0000
Subject: [Koha-bugs] [Bug 12876] Reserve in waiting/transfer status may be
cancelled by user
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12876
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #19 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:13:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:13:19 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
stylesheets over HTTPS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:13:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:13:21 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
stylesheets over HTTPS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758
--- Comment #5 from M. de Rooy ---
Created attachment 31974
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31974&action=edit
Bug 12758: Workaround for loading stylesheets over https
LibXML does not like https references when loading xml with the location
parameter. This can be resolved by reading the file into a string and
passing it to load_xml via the string parameter.
Note that LWP::UserAgent will only load the file if LWP::Protocol::https
is installed. This is an optional perl dependency in Koha. I mark it as
required now.
Also note that if your stylesheet contains an import with a https
reference, this fix is not enough. The load_xml call will not fail, but
the succeeding call to parse_stylesheet will still fail. As a workaround,
make your import file accessible via http.
NOTE: Some code taken from report 12172. With thanks to Martin Renvoize.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:14:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:14:12 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #10 from Paola Rossi ---
(In reply to Jonathan Druart from comment #4)
> [...] you can try to apply patches from bug 12897, 12988 and 12989 without
> this one.
> The behavior was broken without updating the DT plugin.
1) Looking for a feedback, I've applied 12987, 12955, 12988, 12984 and 12989
without leading 12986. And I saw no number in the last row at the bottom of the
tables in:
ACQ home: /acqui/acqui-home.pl
All Funds di ADMIN: /admin/aqbudgets.pl
2) Then I've applied 12986, 12987, 12955, 12988, 12984 and 12989.
And I saw :
2A) still no numbers in the two tables
2B) The Showing broken.
So I had no feedback for 12986 until this step 2) !
3) So I've tried another test, and I've applied 12986, 12987, 12955, 12988,
12984 without the last 12989.
3.1) ACQ home was perfect: numbers ware present and OK, and Showing was OK too
3.2) Funds was KO: no numbers, broken Showing.
So 3.1 had given me a feedback for 12986, but only about acq-home.
4) So I've tried another test, and I've applied 12986, 12987, 12955, 12988
without the last 12984.
4.1) ACQ home was OK about numbers which were present,
4.2) Funds was KO: no numbers, broken Showing as 3.1
5) So I've tried a further test, and I've applied 12986, 12987, 12955 without
the last 12988.
5.1) ACQ home was OK about numbers which were present,
5.2) finally in Funds I saw numbers (whose sums were not right about hide/show'
filter) [and no Showing].
So I think that 12986 is able to be signed off, but I keep it in the "In
Discussion" status.
The other linked patches are not yet perfect. In particular, if the sequence of
applied patches I've written above is not wrong:
bug 12986, bug 12987, bug 12955, bug 12988, bug 12984, bug 12989,
at least:
12988 ruins the bottom of the funds' table,
12989 ruins the bottom of the ACQ-home' table.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:24:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:24:03 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
stylesheets over HTTPS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31974|0 |1
is obsolete| |
--- Comment #6 from M. de Rooy ---
Created attachment 31975
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31975&action=edit
Bug 12758: Workaround for loading stylesheets over https
LibXML does not like https references when loading xml with the location
parameter. This can be resolved by reading the file into a string and
passing it to load_xml via the string parameter.
Note that LWP::UserAgent will only load the file if LWP::Protocol::https
is installed. This is an optional perl dependency in Koha. I mark it as
required now.
Also note that if your stylesheet contains an import with a https
reference, this fix is not enough. The load_xml call will not fail, but
the succeeding call to parse_stylesheet will still fail. As a workaround,
make your import file accessible via http.
NOTE: Some code taken from report 12172. With thanks to Martin Renvoize.
Test plan:
Take for example OPACXSLTDetailsDisplay and replace it by a https ref.
Check opac detail display.
Note that replacing OPACXSLTResultsDisplay by some https ref would also test
repeating the call.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:25:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 12:25:09 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
--- Comment #4 from Jonathan Druart ---
I tried to make Koha::Borrower extends Koha::Schema::Result::Borrower, but I
get an error.
The idea was to remove the AUTOLOAD and avoid the IsStored, IsChanged, Id, etc.
methods.
[the error was: Unable to perform storage-dependent operations with a detached
result source (source '_unnamed_' is not associated with a schema)]
I suppose I tried to do something very bad :)
So, some additional remarks on the patch:
- "result" and "columns" should be _result and _columns to avoid collisions
later, don't you think?
- Are you sure it is useful to test if the row is stored and has been changed
(Store method)? Not sure about the perf, maybe DBIC does that (?).
- IsStored should be InStorage or completely removed, if useless.
- Delete could call delete in an eval, to avoid a call to in_storage
- what about 2 constructors? new and new_from_rs? The ResultSet should not be
create if not used later
- what about a _result method? It would return ->{_result} if already exists,
otherwise create it. All occurrences to ->{result} will be replaced by
->_result
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:03:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:03:07 +0000
Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319
--- Comment #43 from M. de Rooy ---
(In reply to M. de Rooy from comment #42)
> (In reply to Jonathan Druart from comment #41)
> > (In reply to Jonathan Druart from comment #40)
> > > Marcel, I submitted a patch on bug 11395 comment 39. Could you confirm it's
> > > what you expected?
> >
> > It is bug 11395 comment 36.
>
> Will have a look soon.
Soon was kind of relative. Try to get back at this now..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:04:10 +0000
Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=8015
Depends on|8015 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:04:10 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|11319 |
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=11319
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:04:48 +0000
Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=12541
Blocks|12541 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:04:48 +0000
Subject: [Koha-bugs] [Bug 12541] Marc modification template - multivalued
subfields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|11319 |
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=11319
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:05:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:05:16 +0000
Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the
expected behavior if the condition and source fields are on the same field
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|12541 |
Depends on|8015 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:05:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:05:16 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|11413 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:05:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:05:16 +0000
Subject: [Koha-bugs] [Bug 12541] Marc modification template - multivalued
subfields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|11413 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:06:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:06:35 +0000
Subject: [Koha-bugs] [Bug 12540] Batch modifications for records -
unavailable "Every" option
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Depends on|11395 |
--- Comment #1 from M. de Rooy ---
Removing the dependency for now. There is still no code here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:06:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:06:35 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|12540 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:19:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:19:53 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #37 from M. de Rooy ---
(In reply to Jonathan Druart from comment #36)
> Created attachment 31344 [details] [review]
> Bug 11395: Raise an alert if control field is used
>
> If a control field is used with a copy or move action, the interface
> should block the user in some cases:
> - If a control field is used with a regular field
> - The subfield should be empty
Jonathan, I would rather suggest:
A control field can be used with another control field or a subfield of a
regular field. (Note: For some external records I would like to move for
instance 001 to 029a.)
A regular field can not be used with a control field only with another regular
field.
A regular subfield can be used with another regular subfield or a control
field.
Note that some moves are of course without any use, but this would be the
general rule. What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:24:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:24:10 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395
--- Comment #38 from Jonathan Druart ---
(In reply to M. de Rooy from comment #37)
> Jonathan, I would rather suggest:
>
> A control field can be used with another control field or a subfield of a
> regular field. (Note: For some external records I would like to move for
> instance 001 to 029a.)
> A regular field can not be used with a control field only with another
> regular field.
> A regular subfield can be used with another regular subfield or a control
> field.
>
> Note that some moves are of course without any use, but this would be the
> general rule. What do you think?
I don't remember exactly, but I think I blocked the actions which don't
work/don't be implemented.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:51:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:51:47 +0000
Subject: [Koha-bugs] [Bug 13022] New: Hardcoded limit causes records with
more than 20 items to show inaccurate statuses
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022
Bug ID: 13022
Summary: Hardcoded limit causes records with more than 20 items
to show inaccurate statuses
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching
Assignee: gmcharlt at gmail.com
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
If a record has more than 20 items, all the items over 20 will show as
available on the search results even if they are not!
This is a hard coded limit in the Search module. This number should be
configurable.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:52:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:52:12 +0000
Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more
than 20 items to show inaccurate statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:52:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:52:18 +0000
Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more
than 20 items to show inaccurate statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:52:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:52:34 +0000
Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987
--- Comment #3 from Jonathan Druart ---
Created attachment 31976
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31976&action=edit
Bug 12987: The new format_price include file should be include on using
datatables
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:54:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:54:05 +0000
Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows -
acqui-home
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989
--- Comment #2 from Jonathan Druart ---
Created attachment 31977
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31977&action=edit
Bug 12989: Fix JS error
inactive and active are not defined anymore. They should be removed. The
filter is done with DataTables.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:55:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:55:30 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #11 from Jonathan Druart ---
Hello Paola, I found 2 bugs.
I submitted 2 patches, 1 on bug 12987 (The new format_price include file should
be include on using datatables) and 1 on bug 12989 (Fix JS error).
I hope that will fixed your issues.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:59:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:59:46 +0000
Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more
than 20 items to show inaccurate statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:59:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 13:59:48 +0000
Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more
than 20 items to show inaccurate statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022
--- Comment #1 from Kyle M Hall ---
Created attachment 31978
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31978&action=edit
Bug 13022 - Hardcoded limit causes records with more than 20 items to show
inaccurate statuses
If a record has more than 20 items, all the items over 20 will show as
available on the search results even if they are not!
This is a hard coded limit in the Search module. This number should be
configurable.
Test Plan:
1) Create a record with more than 20 items
2) Set all the items to waiting holds or in transit
3) Search for results that will include that item
4) Note some say they are available even though they are not
5) Apply this patch
6) Run updatedatabase.pl
7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck
to a number larger than the number of items on your record
8) Re-run the search
9) Note that the hold and transit statuses for the items are now correct
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:04:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:04:57 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #12 from Zeno Tajoli ---
I have find the answer to this question:
>>Question: Do we use API plug-ins of DataTables jQuery plugin ?
We have those plugin of DataTables:
In intranet-tmpl/lib/jquery/plugins/
-- jquery.dataTables.grouping.js
No clear if it works or not
-- jquery.dataTables.colvis.js
It is an official estension of DataTables, probably it works or an update to
last version is enough
-- jquery.dataTables.columnFilter.js
In it is site speack about DataTables 1.9
http://jquery-datatables-column-filter.googlecode.com/svn/trunk/index.html
I send emails to authors to undestand compliance situation
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:27:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:27:46 +0000
Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
--- Comment #49 from Kyle M Hall ---
I completely agree. I think the best course of action is to have notes in the
release that they will need to map the non-public note in each framework, then
run misc/maintenance/touch_all_items.pl to pull the note into the db column.
(In reply to David Cook from comment #48)
> What do folks think about trying to resolve this issue in stages?
>
> 1) Add new non-public item note column to items and deleteditems
>
> 2) Add template stuff for the new column (even if the column is empty, which
> would be the default, this wouldn't change any default system behaviour)
>
> That's it. The responsibility of updating frameworks and migrating data can
> be left up to Koha administrators. It's not ideal, but it would be progress.
>
> Perhaps we could update the frameworks for a fresh install to show that's
> how things should go in the future, but I don't see an automatic way of
> fixing this for everyone and I don't think it makes sense to stop working on
> this because it can't be perfect.
>
>
>
>
> P.S. If I understand koha2marclinks.pl correctly, it is a frightening
> script. On a test instance, it will say that "paidfor" is mapped to 952$x,
> but it's not really...or rather...it's mapped to 952$x for the FA framework
> but none of the others. That's incredibly misleading...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:36:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:36:00 +0000
Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation -
basketgroup page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |paola.rossi at cineca.it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:42:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:42:53 +0000
Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN
and ISSN
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377
Jorge de Cardenas changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jdeca at smfpl.org
--- Comment #24 from Jorge de Cardenas ---
I am also getting the same errors as Doug Dearden. Did a package install of
Koha 3.16.03 drop the database, created empty database and imported data from
3.10.
Then updated the schema.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:48:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:48:56 +0000
Subject: [Koha-bugs] [Bug 13023] New: Nonpublic note for items should be
mapped to a database column like itemnotes
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Bug ID: 13023
Summary: Nonpublic note for items should be mapped to a
database column like itemnotes
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Cataloging
Assignee: gmcharlt at gmail.com
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
An item's public notes are mapped to a db column, but the librarian only notes
are not. We need to map these so in the future we may display them in places
other than the editor.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:09 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
--- Comment #1 from Kyle M Hall ---
Created attachment 31979
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31979&action=edit
Bug 13023 - Nonpublic note for items should be mapped to a database column like
itemnotes
An item's public notes are mapped to a db column, but the librarian only
notes are not. We need to map these so in the future we may display them
in places other than the editor.
Test Plan:
1) Create an item with a non-public note
2) Apply this patch
3) Run updatedatabase
4) Run misc/maintenance/touch_all_items.pl
5) Inspect the database, note that your non-public note is now in
items.itemnotes_nonpublic
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:07 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:17 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:55 +0000
Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |RESOLVED
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=13023
Resolution|--- |MOVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:56 +0000
Subject: [Koha-bugs] [Bug 2370] MARC21 non-public note is mapped to
items.paidfor
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2370
Bug 2370 depends on bug 4222, which changed state.
Bug 4222 Summary: Nonpublic note not appearing in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |RESOLVED
Resolution|--- |MOVED
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:56 +0000
Subject: [Koha-bugs] [Bug 6748] Add link to fast add framework while
circulating, if a barcode is not found
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6748
Bug 6748 depends on bug 4222, which changed state.
Bug 4222 Summary: Nonpublic note not appearing in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |RESOLVED
Resolution|--- |MOVED
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:51:56 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=4222
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:52:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:52:52 +0000
Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
--- Comment #50 from Kyle M Hall ---
Moving and splitting bug into db part and UI part. Koha has moved on quite a
but so at least some of the UI code is now outdated.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:53:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:53:15 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:56:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:56:48 +0000
Subject: [Koha-bugs] [Bug 13024] New: Nonpublic note not appearing in the
staff client
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024
Bug ID: 13024
Summary: Nonpublic note not appearing in the staff client
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
The nonpublic note for items is not displayed in the staff client. It should be
displayed in the following areas:
1) Checkouts (circulation.pl)
2) Checkins (returns.pl)
3) Record details ( moredetail.pl )
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:56:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:56:59 +0000
Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:57:15 +0000
Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13023
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:57:15 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |13024
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:57:29 +0000
Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=4222
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:57:29 +0000
Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff
client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=13024
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:58:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 14:58:51 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31979|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 31980
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31980&action=edit
Bug 13023 - Nonpublic note for items should be mapped to a database column like
itemnotes
An item's public notes are mapped to a db column, but the librarian only
notes are not. We need to map these so in the future we may display them
in places other than the editor.
Test Plan:
1) Create an item with a non-public note
2) Apply this patch
3) Run updatedatabase
4) Run misc/maintenance/touch_all_items.pl
5) Inspect the database, note that your non-public note is now in
items.itemnotes_nonpublic
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:07:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 15:07:53 +0000
Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation -
basketgroup page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31830|0 |1
is obsolete| |
--- Comment #4 from Paola Rossi ---
Created attachment 31981
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31981&action=edit
Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl
I've applied the patch against master 3.17.00.025
Firstly I've applied:
5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2).
Everything is OK.
NB. in Conf III 1-0 RRP tax inc. :
162.02 instead of 164.0 (file-doc in 12964)
82.01 instead of 82.0 (file-doc in 12964)
I pass the patch to "Signed Off" status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:13:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 15:13:11 +0000
Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation -
basketgroup page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
--- Comment #5 from Jonathan Druart ---
(In reply to Paola Rossi from comment #4)
> Created attachment 31981 [details] [review]
Paola, you forgot to attach your signoff patch :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:16:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 15:16:00 +0000
Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation -
basketgroup page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
--- Comment #6 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Paola Rossi from comment #4)
> > Created attachment 31981 [details] [review] [review]
>
> Paola, you forgot to attach your signoff patch :)
Sorry, end of the day...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:24:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 15:24:18 +0000
Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772
Viktor Sarge changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |viktor.sarge at regionhalland.
| |se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:24:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 15:24:33 +0000
Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of
overdue notice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771
Viktor Sarge changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |viktor.sarge at regionhalland.
| |se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:24:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 15:24:49 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768
Viktor Sarge changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |viktor.sarge at regionhalland.
| |se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 21:06:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 19:06:31 +0000
Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is
Inconsistent
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cbrannon at cdalibrary.org
--- Comment #12 from Christopher Brannon ---
We would like to see this resolved. We are in 3.14 and still see this problem.
My vote would be to not use a pause or call something twice. Perhaps I am
oversimplifying this, but couldn't it be setup so that submitting the form with
the "confirm and print slip" button just submits the form, and then calls the
next step (printing) when completed? Or is the problem that both the "confirm"
and "confirm and print slip" buttons both call the same submit form function?
Could a switch be added to the function so that if "confirm and print slip"
were clicked, it would pass on an extra switch or value to the submit function
that would trigger the print when the function is complete?
Again, I could be oversimplifying this, not knowing the code at all.
Christopher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 21:28:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 19:28:13 +0000
Subject: [Koha-bugs] [Bug 13025] New: Software error: Undefined subroutine
&C4::Circulation::HasOverdues called at
/home/koha/kohaclone/C4/Circulation.pm line 1925
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025
Bug ID: 13025
Summary: Software error: Undefined subroutine
&C4::Circulation::HasOverdues called at
/home/koha/kohaclone/C4/Circulation.pm line 1925
Change sponsored?: ---
Product: Koha
Version: 3.14
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
One of our partners is seeing the following Software error intermittently on
checkout:
Undefined subroutine &C4::Circulation::HasOverdues called at
/home/koha/kohaclone/C4/Circulation.pm line 1925, line 522.
Here's the offending code:
1924 # Remove any OVERDUES related debarment if the borrower has no
overdues
1925 if ( $borrowernumber
1926 && $borrower->{'debarred'}
1927 && C4::Context->preference('AutoRemoveOverduesRestrictions')
1928 && !HasOverdues( $borrowernumber )
1929 && @{ GetDebarments({ borrowernumber => $borrowernumber, type =>
'OVERDUES' }) }
1930 ) {
1931 DelUniqueDebarment({ borrowernumber => $borrowernumber, type =>
'OVERDUES' });
1932 }
I'm not *entirely* sure why this is happening -- HasOverdues is defined in
C4/Members.pm:
53 push @EXPORT, qw(
54 &Search
55 &GetMemberDetails
56 &GetMemberRelatives
...
108 HasOverdues
109 );
and C4::Members is being included in C4/Circulation.pm:
30 use C4::Members;
... so !HasOverdues( $borrowernumber ) *shouldn't* be interpreted as a call to
&C4::Circulation::HasOverdues ... nonetheless, calling
1928 && !HasOverdues( $borrowernumber )
could be re-written as
1928 && ! C4::Members::HasOverdues( $borrowernumber )
which would be un-ambiguously correct.
For the sake of consistency, the call to HasOverdues at C4/Circulation.pm line
2626 should also be changed.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 21:36:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 19:36:52 +0000
Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine
&C4::Circulation::HasOverdues called at
/home/koha/kohaclone/C4/Circulation.pm line 1925
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025
Barton Chittenden changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 22:05:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 20:05:08 +0000
Subject: [Koha-bugs] [Bug 11271] serials table off the screen on low
resolutions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271
--- Comment #1 from Nicole C. Engard ---
This is still an issue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 22:05:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 20:05:32 +0000
Subject: [Koha-bugs] [Bug 11271] serials table off the screen on low
resolutions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liz at catalyst.net.nz
--- Comment #2 from Nicole C. Engard ---
*** Bug 10873 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 22:05:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 20:05:32 +0000
Subject: [Koha-bugs] [Bug 10873] Lots of wasted space in Serial Search
Result table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10873
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |nengard at gmail.com
Resolution|--- |DUPLICATE
--- Comment #1 from Nicole C. Engard ---
*** This bug has been marked as a duplicate of bug 11271 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 23:01:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Oct 2014 21:01:07 +0000
Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN
and ISSN
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377
--- Comment #25 from Jorge de Cardenas ---
In addition to the issn_idx index I also have isbnidx index. I will be dropping
these and later retest.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 11:59:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 09:59:10 +0000
Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel
page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |paola.rossi at cineca.it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 11:59:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 09:59:50 +0000
Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel
page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31901|0 |1
is obsolete| |
--- Comment #2 from Paola Rossi ---
Created attachment 31982
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31982&action=edit
Bug 13001: Refactor VAT and price calculation - parcel page
I've applied te patch against master 3.17.00.025
Firstly I've applied:
5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2)
I've tested setting pref currencyformat either on FR or US.
The tested steps in file-doc at bug 12964 are about parcel.pl:
STEP 5)
STEP 10)
Either on 1-0 or 1-1 I've seen, as required:
before: 140.57 + 7.03 = 147.60
now: 140.58 + 7.02 = 147.60
So I pass the patch to "Signed Off" status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:11:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:11:32 +0000
Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation -
invoice page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |paola.rossi at cineca.it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:12:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:12:46 +0000
Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation -
invoice page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31880|0 |1
is obsolete| |
--- Comment #4 from Paola Rossi ---
Created attachment 31983
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31983&action=edit
Bug 12976: Use the centralize VAT and prices calculation - invoice.pl
I've applied the patch against master 3.17.00.025
Firstly I've applied:
5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2)
I've tested setting pref currencyformat either on FR or US.
As required, I've seen on invoice.pl:
CONF I 0-0
10B) invoice after receiving (invoice.pl)
gst_rate = 0.05
gstvalue = 7.38
total_tax_exc = 147.60
total_tax_inc = 154.98
------------------
CONF II 1-1
10B) invoice after receiving (invoice.pl)
gst_rate = 0.05
gstvalue = 7.02
total_tax_exc = 140.58
total_tax_inc = 147.60
------------------
CONF III 1-0
10B) invoice after receiving (invoice.pl)
gst_rate = 0.05
gstvalue = 7.02
total_tax_exc = 140.58
total_tax_inc = 147.60
-------------------
CONF IV 0-1
10B) invoice after receiving (invoice.pl)
gst_rate = 0.05
gstvalue = 7.38
total_tax_exc = 147.60
total_tax_inc = 154.98
-------------------
I pass the patch to "Signed Off" status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:40:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:40:12 +0000
Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course
details in the OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #3 from Kyle M Hall ---
Owen, what did I do here differently from bug 10634? Can you describe what I
need to do? Is there an existing example in Koha I can use as a pattern?
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:55:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:55:39 +0000
Subject: [Koha-bugs] [Bug 12980] GetHistory does useless processing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:55:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:55:41 +0000
Subject: [Koha-bugs] [Bug 12980] GetHistory does useless processing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31900|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 31984
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31984&action=edit
[PASSED QA] Bug 12980: GetHistory does useless processing
GetHistory iterated on the orders to calculate the quantity and price.
These values are never used by the called.
It can be removed.
Test plan:
Verify there is no regression on acqui/histsearch.pl and
catalogue/detail.pl
Actually you just have to check that the total quantity and price are
not displayed on these views.
QA: note that 'count' and 'toggle' are never used in the template.
Signed-off-by: Paola Rossi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:58:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:58:19 +0000
Subject: [Koha-bugs] [Bug 12985] All basketgroups are not listed
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:58:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 13:58:22 +0000
Subject: [Koha-bugs] [Bug 12985] All basketgroups are not listed
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31868|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 31985
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31985&action=edit
[PASSED QA] Bug 12985: All basketgroups should be listed
Only 20 first are listed, others are hidden.
Test plan:
- Create at least 21 basketgroups
- verify you can see it on the "open" tab
- close all of them
- verify you can see it on the "close" tab
There is no restriction to hide datables functions here.
Signed-off-by: Paola Rossi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:11:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:11:23 +0000
Subject: [Koha-bugs] [Bug 12992] Fund planning does not display actual values
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12992
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:11:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:11:25 +0000
Subject: [Koha-bugs] [Bug 12992] Fund planning does not display actual values
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12992
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31904|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 31986
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31986&action=edit
[PASSED QA] Bug 12992: Fund planning should display actual values
The 'show_actual' variable is not correctly manage in the template.
This has certainly been introduced by the migration to TT.
Test plan:
1/ Go on a bugdet planning view (admin/aqplan.pl)
2/ Check the "Show actual/estimated values" checkbox on the left
(Filters box)
3/ Go
4/ Verify the actual values are now displayed (i.e. the columns contain
2 values).
Signed-off-by: Chris Cormack
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:15:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:15:17 +0000
Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the
patron import tools
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:27:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:27:43 +0000
Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:27:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:27:46 +0000
Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31824|0 |1
is obsolete| |
Attachment #31825|0 |1
is obsolete| |
--- Comment #5 from Kyle M Hall ---
Created attachment 31987
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31987&action=edit
[PASSED QA] Bug 12944: Refactor the patron autocomplete
The patron list feature uses an autocomplete field to search patron.
This will be reused in the next patch.
This patch should not introduce any behavior change.
Signed-off-by: Paola Rossi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:27:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:27:59 +0000
Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944
--- Comment #6 from Kyle M Hall ---
Created attachment 31988
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31988&action=edit
[PASSED QA] Bug 12944: Search orders by basket creator
This patch adds the ability to search orders using the basket creator.
Test plan:
- go on the order advanced search form (acqui/histsearch.pl)
- use the autocomplete input to search patrons
- launch the search and verify the results are consistent with the
values you have filled.
Signed-off-by: Paola Rossi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:28:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:28:02 +0000
Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944
--- Comment #7 from Kyle M Hall ---
Created attachment 31989
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31989&action=edit
[PASSED QA] Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:40:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:40:37 +0000
Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course
details in the OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #4 from Owen Leonard ---
I can see a couple of things offhand which need to be addressed:
- Apply to the Bootstrap theme
- Use the new DataTables include file
> DataTables won't be styled correctly without changes to the CSS and the
> addition of DataTables-related images. That needs to be taken care of before
> this patch goes in.
This patch doesn't work properly for me anymore in master (missing
datatables-strings.inc file), so I can't say for sure but it sounds like the
existing CSS file in the OPAC doesn't (fully?) handle the pagination menu
controls.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:46:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:46:05 +0000
Subject: [Koha-bugs] [Bug 12956] Users are not linked to a fund
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31779|0 |1
is obsolete| |
--- Comment #4 from Kyle M Hall ---
Created attachment 31990
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31990&action=edit
[PASSED QA] Bug 12956: Users are not linked to a fund
When creating a fund, if you add some users, they are not linked to the
fund.
Note that it works if you link them when editing the fund.
Test plan:
- Try to link users to a fund on creating it.
- On editing, you should see the linked user list.
Signed-off-by: Nick Clemens
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:46:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:46:03 +0000
Subject: [Koha-bugs] [Bug 12956] Users are not linked to a fund
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:47:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:47:27 +0000
Subject: [Koha-bugs] [Bug 12831] local only logins should still work when
ldap authentication is enabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831
--- Comment #7 from Dobrica Pavlinusic ---
Sorry for delay, I wanted to test things before submitting more code.
I can't really get LDAP_NO_SUCH_OBJECT error on bind. My guess is that this
error would appear if I was searching for object which wasn't defined in LDAP
schema as opposed to bind call. Did you manage to get this error from LDAP
server on bind?
I wouldn't like to insert code there just because it seems right, since LDAP
code in Koha is already black magic to almost everyone and accumulating cruft
doesn't seem like a good idea.
Regarding LDAP_INVALID_CREDENTIALS, it's already handled by else part of if
statement and I did test with invalid password and it works as-is.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:54:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:54:24 +0000
Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices
search result
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:54:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 14:54:26 +0000
Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices
search result
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31857|0 |1
is obsolete| |
--- Comment #6 from Kyle M Hall ---
Created attachment 31991
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31991&action=edit
[PASSED QA] Bug 12646: Display all invoices on the same page
Only first 20 invoices were displayed on the page. Without pagination, DT
did not allow to show others.
This page explicitely removes the pagination option in order to display
all invoices on the page.
Test plan:
1/ Create 21+ invoices
2/ Go on acqui/invoices
3/ Verify all invoices are displayed.
Signed-off-by: Paola Rossi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 17:39:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 15:39:40 +0000
Subject: [Koha-bugs] [Bug 12831] local only logins should still work when
ldap authentication is enabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831
Dobrica Pavlinusic changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |In Discussion
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 17:40:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 15:40:15 +0000
Subject: [Koha-bugs] [Bug 12831] local only logins should still work when
ldap authentication is enabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831
Dobrica Pavlinusic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31619|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 17:41:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 15:41:43 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
--- Comment #13 from Paola Rossi ---
(In reply to Jonathan Druart from comment #11)
> Hello Paola, I found 2 bugs.
> I submitted 2 patches, 1 on bug 12987 (The new format_price include file
> should be include on using datatables) and 1 on bug 12989 (Fix JS error).
> I hope that will fixed your issues.
Thanks, Jonathan.
Sorry, it's not yet OK:
I've applied these patches against master 3.17.00.025 :
12986, 12987 (2), 12955, 12988, 12984, 12989 (2)
but no numbers neither in the "Total" row of acqui-home, nor in the "Period
allocated" row of funds in /admin/aqbudgets.pl.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 18:01:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 16:01:02 +0000
Subject: [Koha-bugs] [Bug 12831] local only logins should still work when
ldap authentication is enabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831
--- Comment #8 from Dobrica Pavlinusic ---
Upon further investigation, I decided to obsolete my patch because I suspect
that if fixes problem only for our particular installation instead of providing
general solution to problem. Let me explain...
Problem comes from the fact that in LDAP bind we can't distinguish between
users which doesn't exist in LDAP and invalid passwords. Both of those return
LDAP_INVALID_CREDENTIALS (in our installation we have a bit of LDAP software in
between which creates invalid DN for users which are not in LDAP, but that is
not generally applicable).
This means that we have to know (somehow) weather users should use LDAP
passwords or not. Currently we don't have that information.
One possibility is to do LDAP search (anonymous or via some account) and if
user does exist in LDAP force him to provide proper LDAP password. However,
this might not be practical because it creates additional load on LDAP server
on one hand, and on another anonymous searches might be disabled (that's
probably why we are using auth_by_bind in the first place) or there might not
be special user which can search whole LDAP (or library might not have
permissions to add such user which is our case).
Another possibility is to track locally in Koha if users should use LDAP or
local passwords. This might be implemented simply by invalidating local
password (with word LDAP for example :-) which would prevent local fallback
from working if user is logged in using LDAP.
I'm biased towards second solution but I would love to hear some feedback about
it before producing code.
However, in any case we don't have clear migration path for existing
installations because they do have local LDAP passwords in database (like we
do). After first LDAP login users will have local password invalidated, but
users which never login with correct LDAP password (or who are already
disabled) we still be able to login using cached password.
To be quite honest, I did use that side-effect of old code which allowed our
patrons to login while LDAP wasn't available, so it might even make sense to
have that behavior again (as LDAP configuration option perhaps). But if that is
the case, we again don't have ability to expire users just in LDAP and expect
them to be disabled in Koha also.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 18:55:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 16:55:54 +0000
Subject: [Koha-bugs] [Bug 11271] Serials table off the screen in smaller
viewports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Summary|serials table off the |Serials table off the
|screen on low resolutions |screen in smaller viewports
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:11:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 17:11:00 +0000
Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is
incorrect
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:19:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 17:19:51 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
objects
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
--- Comment #5 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #4)
> I tried to make Koha::Borrower extends Koha::Schema::Result::Borrower, but I
> get an error.
> The idea was to remove the AUTOLOAD and avoid the IsStored, IsChanged, Id,
> etc. methods.
>
> [the error was: Unable to perform storage-dependent operations with a
> detached result source (source '_unnamed_' is not associated with a schema)]
> I suppose I tried to do something very bad :)
>
> So, some additional remarks on the patch:
> - "result" and "columns" should be _result and _columns to avoid collisions
> later, don't you think?
Good idea
> - Are you sure it is useful to test if the row is stored and has been
> changed (Store method)? Not sure about the perf, maybe DBIC does that (?).
Yeah, I'd have to check the DBIC code, but that seems entirely likely.
> - IsStored should be InStorage or completely removed, if useless.
Again, your probably right. I can't see a use for this right now and we can
always add an InStorage method at a later date if it *is* needed for something.
> - Delete could call delete in an eval, to avoid a call to in_storage
Do you think that will improve efficiency? in_storage has already been
calculated and is just a dbic property. It seems like using eval would take
more time.
> - what about 2 constructors? new and new_from_rs? The ResultSet should not
> be create if not used later
For Koha::Object? That's a good idea.
> - what about a _result method? It would return ->{_result} if already
> exists, otherwise create it. All occurrences to ->{result} will be replaced
> by ->_result
Also a good idea.
I'll see if I can't make some time next week to implement these changes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:38:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 17:38:50 +0000
Subject: [Koha-bugs] [Bug 12775] Only suggestion manager can order from
accepted suggestion
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:38:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 17:38:53 +0000
Subject: [Koha-bugs] [Bug 12775] Only suggestion manager can order from
accepted suggestion
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31891|0 |1
is obsolete| |
--- Comment #7 from Kyle M Hall ---
Created attachment 31992
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31992&action=edit
[PASSED QA] Bug 12775: Suggestions should be ordered by anyone
Currently only the suggestion manager can order from accepted
suggestion.
This patch set to default the ability to show all suggestions when
ordering from a suggestion.
2 links "show only mine" and "show all" permits to filter/show all
permissions.
Test plan:
Create an order from a suggestion and verify you are able to see all
suggestions by default.
Verify the "show only mine" link works as expected.
Signed-off-by: Paola Rossi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:05:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 18:05:55 +0000
Subject: [Koha-bugs] [Bug 12538] Solr removal
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:05:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 18:05:58 +0000
Subject: [Koha-bugs] [Bug 12538] Solr removal
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31817|0 |1
is obsolete| |
Attachment #31819|0 |1
is obsolete| |
--- Comment #12 from Kyle M Hall ---
Created attachment 31993
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31993&action=edit
[PASSED QA] Bug 12538: Remove Solr without breaking anything else
Since nobody is currently working on the zebra layer introduced by bug
8233, Solr won't never work.
Some code has been introduced in 3.10 to prove several search engines
can cohabit into Koha but no help/fund has been found to go ahead.
It is useless to keep this code and to maintain an ambiguous situation.
I think the indexes configuration page could be restore later if someone
else introduces a new search engine into Koha.
Test plan:
Look at the code introduced by bug 8233 and verify all is removed.
Signed-off-by: Chris Cormack
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:06:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 18:06:09 +0000
Subject: [Koha-bugs] [Bug 12538] Solr removal
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538
--- Comment #13 from Kyle M Hall ---
Created attachment 31994
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31994&action=edit
[PASSED QA] Bug 12538 : FOLLOW UP Remove Moose from the list of dependencies
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:27:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 18:27:11 +0000
Subject: [Koha-bugs] [Bug 11271] Serials table off the screen in smaller
viewports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271
--- Comment #3 from Owen Leonard ---
Created attachment 31995
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31995&action=edit
Bug 11271 - Serials table off the screen in smaller viewports
When you search for serials in the Serials module the results table is
often too wide for the screen (depending on your browser window size).
This is partly due to the fixed width of the search fields in the table
footer.
This patch applies a flexible width to those s and reduces the
font size of their text.
This patch also moves the "action" links for each table row into an
"action" menu (similar to the change made by Bug 10615 in Reports) to
further conserve screen space.
This patch also revises the page's DataTables configuration to use table
header classes for sorting configuration.
To test you should be able to perform a search which returns multiple
open and closed subscriptions.
- Test that table sorting works correctly, including for titles with
articles and for dates.
- Test that the Action menu items work correctly and that they correctly
reflect the permissions of the logged-in user with regard to
receive_serials and routing.
- Perform these tests on both the "Open" and "Closed" tabs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:27:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 18:27:08 +0000
Subject: [Koha-bugs] [Bug 11271] Serials table off the screen in smaller
viewports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 21:50:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 19:50:45 +0000
Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the
latest version
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Patch doesn't apply
Patch complexity|--- |Medium patch
--- Comment #14 from Zeno Tajoli ---
Hi to all,
I think to have finish the basic check asked comment #2.
There are two points that emerge as important:
-- Support of IE6/IE7
-- Interaction with plugins of this plugin.
a)Support of IE6/IE7
Discussions on chat and mailing list give as answer: we can drop support
of IE6/IE7;
http://lists.katipo.co.nz/pipermail/koha/2014-October/040960.html,
http://lists.koha-community.org/pipermail/koha-devel/2014-October/040836.html,
http://irc.koha-community.org/koha/2014-10-01#i_1575703,
http://irc.koha-community.org/koha/2014-10-02#i_1575984
b)Interaction with plugins of this plugin.
There three plugin of DataTables in Koha, they are in
intranet-tmpl/lib/jquery/plugins/
1) jquery.dataTables.colvis.js
Written from the same firm that write DataTables, update to new version of
DataTables.
2) jquery.dataTables.rowGrouping.js
We use the last version, there are same minir problems,the best option is to
use old 1.9 API when you is plugin, see
https://code.google.com/p/jquery-datatables-row-grouping/issues/detail?id=75&sort=-id
3) jquery.dataTables.columnFilter.js
We don't use the last version, there is a patch to improve compatibility with
v.1.10,
https://code.google.com/p/jquery-datatables-column-filter/issues/detail?id=158&sort=-id
So my idea is that:
-- We can update
-- We need to update also plugins.
So, now for me 'Patch doesn't apply' because you don't update plugin.
I think that a patch to test needs:
1) update DataTables to v 1.10
2) update query.dataTables.colvis.js
3) evalute if update or not query.dataTables.columnFilter.js and insert or not
the patch linked.
Bye
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Oct 4 01:18:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Oct 2014 23:18:43 +0000
Subject: [Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for
staff and OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495
bondiurbano changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |costalc at gmail.com
--- Comment #1 from bondiurbano ---
It would be very nice...3.16.4
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Oct 4 22:51:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Oct 2014 20:51:12 +0000
Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped
to a database column like itemnotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at quecheelibrary.org
--- Comment #3 from Nick Clemens ---
I tried testing
created items with non-public notes
apply patch
upgrade database
map itemnotes_nonpublic to 952x
run touch_all_items.pl
all non-public notes still seemed to be in more_sbfields_xml
new notes worked as expected but I couldn't get old notes to transfer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Oct 4 23:03:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Oct 2014 21:03:15 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |nick at quecheelibrary.org
--- Comment #27 from Nick Clemens ---
Applying: Bug 12892 - Holds Waiting: not showing from check out screen
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Reserves.t
CONFLICT (content): Merge conflict in t/db_dependent/Reserves.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging circ/circulation.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 12892 - Holds Waiting: not showing from check out
screen
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-12892---Holds-Waiting-not-showing-from-check-o-xSl9aQ.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 02:19:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 00:19:43 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #28 from Owen Leonard ---
Did you apply the dependencies first?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 02:54:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 00:54:13 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892
--- Comment #29 from Nick Clemens ---
SMH, no
I got caught up reading through the discussion and forgot to go back up and
note them.
I can't apply 11518 so can't apply 11703 and so can't apply this, will retreat
for simpler bugs
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:11:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 01:11:11 +0000
Subject: [Koha-bugs] [Bug 12981] Patron attribute type limit by patron
category not working on patron entry form
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12981
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at quecheelibrary.org
--- Comment #2 from Nick Clemens ---
I confirmed the behavior
The patch works as described.
Does it matter that I can change the category in order to make the attribute
show, fill it in, change it again and hide the field, but still have the
information save?
It reuires a pretty deliberate staff action but you end up with an attribute
showing that you can't edit
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:27:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 01:27:23 +0000
Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration
hold date in staff not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:27:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 01:27:30 +0000
Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration
hold date in staff not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31685|0 |1
is obsolete| |
--- Comment #3 from Nick Clemens ---
Created attachment 31996
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31996&action=edit
[SIGNED OFF] Bug 12893 - 'Clear date' links on start and expiration hold date
in staff not working
I introduced this bug with my patch for Bug 8181. In changing the way
the date picker widgets worked I changed the ID the "clear date"
javascript was looking for, so it stopped working.
This patch corrects it and improves the JavaScript by moving it out of
the HTML markup.
This patch also makes some minor HTML validity corrections: escaping
ampersands and removing a "size" attribute from a hidden form field.
To test, you should have the AllowHoldDateInFuture system preference
enabled. Place a hold in the staff client for a patron and confirm that
you can choose a "hold starts on" date and a "hold expires on" date and
that the respective "clear date" links work correctly for each one.
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:28:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 01:28:39 +0000
Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration
hold date in staff not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at quecheelibrary.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:46:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 01:46:56 +0000
Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:47:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Oct 2014 01:47:00 +0000
Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30726|0 |1
is obsolete| |
--- Comment #17 from Nick Clemens