From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 02:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 00:17:48 +0000 Subject: [Koha-bugs] [Bug 11362] increase zebra AUTH register sizes, from 4G to 20G In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362 --- Comment #4 from Mason James --- (In reply to Robin Sheat from comment #3) > Are there any negative effects to having a large index size? Probably not > that outweighs the disadvantages to having one that's too small... afaik, no - everything 'just works' as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 09:42:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 07:42:23 +0000 Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |jonathan.druart at biblibre.co | |m Assignee|yohann.dufour at biblibre.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 09:58:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 07:58:33 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 10:44:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 08:44:08 +0000 Subject: [Koha-bugs] [Bug 12833] Patron search no longer searches extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12648 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 10:44:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 08:44:08 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Depends on| |12833 --- Comment #14 from Jonathan Druart --- Bug 12833 breaks this enh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:19:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:19:08 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:19:23 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #15 from Jonathan Druart --- Created attachment 31960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31960&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:19:29 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #16 from Jonathan Druart --- Created attachment 31961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31961&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:25:58 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |z.tajoli at cineca.it --- Comment #3 from Zeno Tajoli --- Hi Jonathan, we have problem to test this patch. Could you tell us where footerCallback function doesn't work with present version and it needs 1.10.2 of DataTables jQuery plugin ? About the change of 1.10 (reading http://datatables.net/upgrade/1.10): -- Pagination (two_button), is present only in datatables.css,a css that came with the plugin. So is not used by us -- function fnRender: we don't use it. -- function bScrollInfinite: we don't use it -- Could be problems with IE6/IE7: from 1.10.2 of DataTables jQuery plugin cookie based state saving has been replaced with localStorage based state saving. This function is not availabe in IE6/IE7 there are same way to live with this [The stateLoadCallbackDT and stateSaveCallbackDT parameters can be used to provide a suitable function if you wish to use cookies.] -- Question: Do we use API plug-ins of ataTables jQuery plugin ? A real question, I don't know the answer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:26:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:26:50 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:44:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:44:19 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:44:22 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31605|0 |1 is obsolete| | Attachment #31607|0 |1 is obsolete| | Attachment #31672|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 31962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31962&action=edit Bug 12892 - Add Koha::Object, Koha::Objects and unit tests This patch adds the base classes upon which we can build new Koha classes to give us smarter, simpler code. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:44:32 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #25 from Kyle M Hall --- Created attachment 31963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31963&action=edit Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:45:04 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:45:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:45:12 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:45:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:45:20 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:47:35 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #4 from Jonathan Druart --- Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without this one. The behavior was broken without updating the DT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:53:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:53:47 +0000 Subject: [Koha-bugs] [Bug 13018] New: Static fine should apply only once for a given borrower Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Bug ID: 13018 Summary: Static fine should apply only once for a given borrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Once a borrower is charged for overdues, staticfine.pl execution should not add a new fine each time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:54:32 +0000 Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6858 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 11:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 09:54:32 +0000 Subject: [Koha-bugs] [Bug 6858] Adds staticfines.pl for static fines processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13018 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 12:08:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 10:08:49 +0000 Subject: [Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email address for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #39 from Martin Renvoize --- This wiki snippet I did may be useful to anyone documenting this feature. I'll be happy to explain further upon request http://wiki.koha-community.org/wiki/MRenvoize/Email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:32:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:32:28 +0000 Subject: [Koha-bugs] [Bug 13019] New: Add base classes on which to build Koha objects Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Bug ID: 13019 Summary: Add base classes on which to build Koha objects Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:33:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:33:12 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:37:24 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:37:26 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #1 from Kyle M Hall --- Created attachment 31964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31964&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:37:42 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:37:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:37:42 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 13:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 11:38:40 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31962|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Comment on attachment 31962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31962 Bug 12892 - Add Koha::Object, Koha::Objects and unit tests Moving the base class patch to it's own bug. Bug 13019. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:02:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:02:39 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #5 from Owen Leonard --- Zeno are you finding errors when testing this patch or do you question whether we should be upgrading DataTables at all? Is it continued support for IE6/7 which is at issue here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:25:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:25:44 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 --- Comment #14 from Colin Campbell --- (In reply to Jonathan Druart from comment #12) > (In reply to Jonathan Druart from comment #11) > > Created attachment 31623 [details] [review] [review] > > Rolando and Colin, could it be possible to get your point of view on this > patch please? (In reply to Rolando Isidoro from comment #13) > Hey Johnathan, your patch complexity and range greatly exceeds my knowledge > of Koha's source code. Colin, what's your take on this? > > Rolando This changes behaviour in an undocumented way if I pass a tz other than C4::Context's it seems in some strings (need more test cases) to be changing to the system tz but not correctly converting the date ... It also adds processing to a frequently used routine which is not efficient e.g. the evals are unnecessary if anything failes the date parse returns undef flagging the error. I'll try testing some more inputs to this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:27:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:27:20 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:34:19 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #6 from Paola Rossi --- (In reply to Jonathan Druart from comment #4) Zeno and I thank you, Jonathan. > Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without > this one. 1) I think the first bug was 12987, wasn't it? 2) Before trying to apply tha patch, I'm in doubt about 12987. A) On the graph at kindly prepared at bug-12825, the two bugs 12988 and 12989 depend on 12987, and 12987 depends on this current bug 12986. So the "blocks" set of this bug 12986 should be limited to 12987. And the bug 12988 would depend on bug 12987, instead of bug 12986 presently shown. And the bug 12989 would depend on bug 12987, instead of bug 12986 presently shown. B) Otherwise, in the graph the two bugs 12988 and 12989 would point directly to 12986, instead of pointing to 12987. The "blocks" set of this bug 12986 should remain the same: 7,8 and 9. And the bug 12988 keeps on depending on the bug 12986 presently shown. And the bug 12989 keeps on depending on the bug 12986 presently shown. Thank you in advance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:35:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:35:49 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31160|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 31965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31965&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:40:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:40:00 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- First thoughts (already sent on #koha): 1/ Type and ObjectClass could be attributes, instead of methods 2/ I really would like to see method name without capital letters (and underscore '_' to separate words) 3/ "Bad setter returns undef" => not sure about that. Bad setter should croak 4/ What about using Class::Accessor? 5/ t/db_dependent/Objects.t should be t/db_dependent/Borrowers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:45:13 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #7 from Zeno Tajoli --- (In reply to Owen Leonard from comment #5) > Zeno are you finding errors when testing this patch or do you question > whether we should be upgrading DataTables at all? In fact the question is more "Should we upgrade DataTables". - I don't have a PC with IE6/IE7 so I can't test if we have a problem with version 10.x of DataTables > Is it continued support for IE6/7 which is at issue here? I think yes. The other problem are any plugin that use API of DataTables plugin. Do you know our situation about this ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:50:13 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #8 from Owen Leonard --- I haven't tested this patch at all so I don't know if the upgrade causes any problems. However, I think we should always try to keep up to date with the libraries Koha uses unless there is some specific reason not to. In my opinion the possibility that it may cause problems for IE6/7 is not enough of an issue to block an upgrade to the plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:59:55 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12989 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:59:55 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12989 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:59:55 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12986 |12987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:59:59 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12986 |12987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:59:59 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12988 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 14:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 12:59:59 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:01:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:01:25 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #9 from Jonathan Druart --- (In reply to Paola Rossi from comment #6) > (In reply to Jonathan Druart from comment #4) > > Zeno and I thank you, Jonathan. > > > Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without > > this one. > > 1) I think the first bug was 12987, wasn't it? Yes of course, sorry. > 2) Before trying to apply tha patch, I'm in doubt about 12987. Yes, the graph is correct! I updated the dependencies on bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:02:26 +0000 Subject: [Koha-bugs] [Bug 13020] New: Checkouts table default ordering is incorrect Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Bug ID: 13020 Summary: Checkouts table default ordering is incorrect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The checkouts table is no longer keeping "today's checkouts" in the order they were scanned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:04:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:04:47 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 --- Comment #1 from Kyle M Hall --- Created attachment 31966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31966&action=edit Bug 13020 - Checkouts table default ordering is incorrect The checkouts table is no longer keeping "today's checkouts" in the order they were scanned. Test Plan: 1) Create 3 records "Test 1", "Test 2" and "Test 3" each with one item 2) Check out the items to a patron in the order "Test 2", "Test 1", "Test 3". 3) Note the order is incorrect. 4) Apply this patch 5) Refresh the page 6) Note the order is now correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:04:45 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:04:58 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:05:05 +0000 Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 31967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31967&action=edit Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:05:13 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:05:26 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:05:26 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13020 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:05:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:05:29 +0000 Subject: [Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 15:14:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 13:14:06 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #13 from Kyle M Hall --- Created attachment 31968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31968&action=edit Bug 12550 [QA Followup] - Make checking the checkbox load the table of checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 14:44:06 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:51:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 14:51:51 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Assignee|yohann.dufour at biblibre.com |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- If I am not wrong, there are 3 occurrences of C4::Members::Search: 1/ acqui/aqbasketuser_search.pl 2/ members/guarantor_search.pl 3/ patroncards/members-search.pl 1 is removed by 12648, I have a patch for 2. 3 is todo. When done, I will completely remove the C4::Members::Search subroutine. Some code should be move from C4::Utils::DT::Members to C4::Members (or Koha::Members). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:52:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 14:52:08 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 16:52:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 14:52:08 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12648 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 18:24:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 16:24:01 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 lightpurpledye at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lightpurpledye at gmail.com --- Comment #2 from lightpurpledye at gmail.com --- This problem goes away if you comment out lines 152 - 159 of /usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif ($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images') {" ). However, doing this also breaks the display of any "Other Image"s (non-patron photo images) on the card layout. I have tried adding "$image_data = undef" to the beginning of the foreach loop, and between lines 152 and 153, under the assumption that $image_data still contains the image data from the previous iteration until it is reassigned, but this had no effect. I think that for some reason the elsif condition on line 152 is matching users which don't have a photo assigned, but I still don't know why that would result in the behaviour observed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 18:56:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 16:56:50 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #3 from Chris Nighswonger --- (In reply to lightpurpledye from comment #2) > This problem goes away if you comment out lines 152 - 159 of > /usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif > ($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images') > {" ). > > However, doing this also breaks the display of any "Other Image"s > (non-patron photo images) on the card layout. > The file in question is create-pdf.pl Your test indicates that at least on your system there may be patron images stored where "creator_images" should be. This entire block of code (PROCESS_IMAGES [1]) is prefaced on layout xml like this: It looks at the data_source key in particular for the "source" of the image. "creator_images" are stored in a table by the same name in the db. This is a different source than patron images which are stored in the patronimage table. The fact that commenting out the condition which allows for retrieval of creator_images "fixes" the problem would seem to indicate a misunderstanding of what images should be stored where. An image stored in the creator_images table and used in a patroncard layout will appear on every card in any batch using that layout. Images stored in the patronimage table will (should) appear only on cards which include that patron. I have not had time to try this bug out, but what you describe seems to be more related to misunderstanding what images should be stored where. Hopefully that clarifies things a bit. If I've not understood, feel free to let me know. [1] http://tinyurl.com/kfh5vbn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 19:20:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 17:20:22 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #3 from Kyle M Hall --- > 1/ Type and ObjectClass could be attributes, instead of methods Could write a followup? I tried to do that but had issues with getting the base class to know about the package variable. I was properly implementing it wrong. > 2/ I really would like to see method name without capital letters (and > underscore '_' to separate words) I have no strong preference here as long as we stick to one convention. My only concern would be a convention conflict where a table has the same name as a field in the table. That would lead to ambiguity, but I'm not sure if we even have an instance of this. For example, let's say a table has the field borrower which is actually a borrowernumber. I'd like to have $row->borrower return the borrowernumber, but $row->Borrower return the Koha::Borrower object. That way we know when we are getting back a scalar, and when we are getting back an Object. It would be silly to fetch the Koha::Borrower in a case where we just need the borrowernumber, which we would already have. > 3/ "Bad setter returns undef" => not sure about that. Bad setter should croak Agreed. > 4/ What about using Class::Accessor? I don't see the advantage to this. Can you give an example. This implementation uses a DBIC object as a place to store the data, so there is no need to have separate properties. Please note the this should not conflict this unit testing on a database-less system. t/Object.t should demonstrate this. > 5/ t/db_dependent/Objects.t should be t/db_dependent/Borrowers.t I can see your point, but the tests are really testing the base classes, and not the Borrower classes per se. However, I have no strong opinion so that's fine by me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 20:07:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 18:07:35 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #4 from lightpurpledye at gmail.com --- Oops, I did mean create-pdf.pl, well spotted. I don't think I've misunderstood where images should be stored, however. I only have one image in the creator_images table in the db, which I wish to be displayed on every card. The patron images are all in the patronimage table (uploaded using the bulk Upload Patron Images tool). It's just that some patrons do not have images set, but creating a card for them still displays an image, but of a different patron. N.B. The self-checkout module does not display any images for these patrons, and there is no image set for them in the patronimage table, so I am fairly sure it's a bug in the Patron Card Creator module rather than anything else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 20:29:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 18:29:33 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #5 from Chris Nighswonger --- (In reply to lightpurpledye from comment #4) > Oops, I did mean create-pdf.pl, well spotted. > > I don't think I've misunderstood where images should be stored, however. I > only have one image in the creator_images table in the db, which I wish to > be displayed on every card. > > The patron images are all in the patronimage table (uploaded using the bulk > Upload Patron Images tool). It's just that some patrons do not have images > set, but creating a card for them still displays an image, but of a > different patron. So it sounds like your images are in the correct location. However, that only makes it a bit more confusing as to why commenting out code which inserts the image for every card would "fix" the duplicate patron image issue. So I'll just have to find time to duplicate the bug and look at what's going on there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 20:32:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 18:32:56 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 21:18:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 19:18:03 +0000 Subject: [Koha-bugs] [Bug 12656] add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #1 from Agnes Rivers-Moore --- I agree. I am disappointed that Koha leaves no trace for staff or borrower when a hold is cancelled. Perhaps there could be a preference choice whether to send a notice for all cancelled holds, or just for those cancelled after waiting too long for pickup. Having that notice show up in the borrower messages tab would be really useful! Agnes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 21:45:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 19:45:09 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #76 from Agnes Rivers-Moore --- We would like the option to have a shorter pickup period for some item types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 21:56:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 19:56:09 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #8 from Jesse Maseto --- //Fix subject search by striping parenthesis from url links $('#catalogue_detail_biblio a[href*="su:"]').attr('href', function(_,v){ return v.replace(/(\(|\))/g,'') }); This works for both the staff search and OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 23:47:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 21:47:54 +0000 Subject: [Koha-bugs] [Bug 12876] Reserve in waiting/transfer status may be cancelled by user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12876 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Hold requests Version|unspecified |master Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 1 23:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 21:48:43 +0000 Subject: [Koha-bugs] [Bug 12873] Reserve can be cancelled by any logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12873 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Group|Koha security | CC| |gmcharlt at gmail.com Component|Koha |Hold requests Version|unspecified |master Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org --- Comment #12 from Galen Charlton --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 00:25:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 22:25:25 +0000 Subject: [Koha-bugs] [Bug 12849] Sending a list has malformed links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_5_candidate CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 00:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Oct 2014 22:26:02 +0000 Subject: [Koha-bugs] [Bug 12849] Sending a list has malformed links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:29:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 07:29:25 +0000 Subject: [Koha-bugs] [Bug 13021] New: DataTables server-side processing - guarantor search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Bug ID: 13021 Summary: DataTables server-side processing - guarantor search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 12648 refactores some code for the patron search (link patrons to a basket and an order, in the acquisition module). This code can be reuse for the guarantor search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:30:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 07:30:05 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |12633, 12648 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #1 from Jonathan Druart --- This will remove 1 call to C4::Members::Search (see bug 12633). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:30:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 07:30:05 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13021 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 09:30:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 07:30:05 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13021 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:03:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:03:15 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #77 from Paul Poulain --- (In reply to Agnes Rivers-Moore from comment #76) > We would like the option to have a shorter pickup period for some item types. Sorry, but this patch does not apply anymore, and should be rewritten almost from scratch because another patch has been pushed before this one, that make what Jonathan made invalid. So, without funding to re-do the work, we (BibLibre) will not work on it anymore, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:12:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:12:17 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:12:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:12:19 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31637|0 |1 is obsolete| | --- Comment #2 from Petter Goks?yr ?sen --- Created attachment 31969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31969&action=edit Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list. Signed-off-by: Petter Goksoyr Asen Confirmed that this patch removes borrowernumber from list of default values, and reintroduces missing list of CSV columns in the Notes field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:27:26 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:27:28 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #2 from Jonathan Druart --- Created attachment 31970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31970&action=edit Bug 13021: guarantor search - prepare existing code to be reused The add_user_search tt file will be reuse in next commits, this commit just moves it in a "common" directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:27:36 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #3 from Jonathan Druart --- Created attachment 31971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31971&action=edit Bug 13021: guarantor search - main patch This patch is the main patch. The "common" template is improved to allow different type of picking: "add" or "select". The first one appends a patron to a list, the second one selects the patron and close the result search window. The members/guarantor_search.pl has completly changed but is quite the same file as acqui/add_user_search.pl. Both should exist: they don't belong to the same module (acqui vs members), the picking type is different (add vs select) and the columns are not the same. The changes in the common template are very powerful, it's now possible to list the column we want! This will be very useful for further reusability. Before this patch, all patrons mathing the pattern were return. Now only the first 20 are (depends on the DataTables selected value). For QA: This patch introduces a new template plugin "To", for now it permits to convert a perl structure to json. In the idea, it could permit to convert foo to bar too. Test plan: 1/ Verify there is no regression in the guarantor search. When the selection has been done, all data from the guarantor should fill the form in the "main address" section. Note that the request is done when the search input in not empty and the user stop to write for 1 sec. 2/ Verify there is no regression on the 2 other pages where this patron search is used: link a patron to an order and to a basket (in the acquisition module). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:27:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:27:40 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #4 from Jonathan Druart --- Created attachment 31972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31972&action=edit Bug 13021: guarantor search - guarantor_search.tt is useless The guarantor_search.tt is now useless, no script uses it. It can be removed safely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:28:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:28:34 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > 1 is removed by 12648, I have a patch for 2. The call in guarantor_search is removed by 13021. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 10:51:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 08:51:07 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19326|0 |1 is obsolete| | Attachment #19740|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver --- Created attachment 31973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31973&action=edit Bug 8133 - hourly loans doesn't know when library closed This adds support for storing library hours in the calendar, and using those hours to compute hourly loan duetimes. A large amount of cleanup was also performed to expunge duplication of code between C4::Calendar and Koha::Calendar. Test plan: 1) Apply patch. 2) Update database. 3) Verify that the calendar administration interface still exists and works as expected. 4) Run t/Calendar.t and t/db_dependent/Calendar.t. (This version is truly based on bug 11211, and folds in Liz's followup.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 11:05:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 09:05:06 +0000 Subject: [Koha-bugs] [Bug 1973] Acquisitions : receive items that haven't been ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1973 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |z.tajoli at cineca.it Resolution|--- |INVALID --- Comment #2 from Zeno Tajoli --- The user needed only a suggestion to do the operation with thea actual interface -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 12:35:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 10:35:37 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|XSLT imports containing a |Failure when loading or |https href in a XSLT |parsing XSLT stylesheets |stylesheet fail to work |over HTTPS |with LibXML's load_xml in | |XSLT_Handler | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 13:46:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 11:46:25 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #4 from M. de Rooy --- I have renamed this report to widen its scope. Actually, I see here two related problems: 1) LibXML does not like https references when loading xml with the location parameter. This can be resolved by reading the file into a string and passing it to load_xml via the string parameter. (A solution within LibXML for https appears not to be expected for now.) Note btw bthat reading the file might not be working rightaway. If you LWP::UserAgent to get the file contents, it will need LWP::Protocol::https. This dependency was recently added to Koha as optional in the context of OverDrive integration. Should we mark it as required now? 2) If the stylesheet (via local file, http or https) contains an import with a https reference, LibXML can load it (possibly with the workaround under point 1), but LibXSLT will now fail parsing it with: "I/O warning : failed to load external entity". This is harder to resolve; we should not be replacing imports in xslt code ourselves. The problem seems to go down deeper to the libxml2 C library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:00:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:00:18 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 lightpurpledye at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |3.14 --- Comment #6 from lightpurpledye at gmail.com --- Possibly related: If the image file for one patron has a greater horizontal:vertical ratio than the image file for the patron immediately after them in the batch, then the first patron's image is shown below the second patron's image. e.g. Steps to reproduce 1. In the patron creator, set up a layout with patron images enabled. 2. Create a batch starting with a patron that has a 300x100 image stored. 3. Next choose one with a 200x100 image. 4. Export the batch. 5. Resulting PDF will show: i) The first one is correct (patron a's picture) ii) The second one is incorrect (There are 100 pixels of patron a showing underneath patron b). This suggests to me that when the PROCESS_IMAGES loop has an iteration it actually prints the image in every subsequent image position and then relies on the incorrect images being printed over in the next iteration. This would explain why, if a patron does not have an image stored, they would get the previous patron's image. If this turns out to be unrelated, I can open a separate bug report for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:04:58 +0000 Subject: [Koha-bugs] [Bug 12873] Reserve can be cancelled by any logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12873 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:10:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:10:21 +0000 Subject: [Koha-bugs] [Bug 12876] Reserve in waiting/transfer status may be cancelled by user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12876 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #19 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:13:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:13:19 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:13:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:13:21 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #5 from M. de Rooy --- Created attachment 31974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31974&action=edit Bug 12758: Workaround for loading stylesheets over https LibXML does not like https references when loading xml with the location parameter. This can be resolved by reading the file into a string and passing it to load_xml via the string parameter. Note that LWP::UserAgent will only load the file if LWP::Protocol::https is installed. This is an optional perl dependency in Koha. I mark it as required now. Also note that if your stylesheet contains an import with a https reference, this fix is not enough. The load_xml call will not fail, but the succeeding call to parse_stylesheet will still fail. As a workaround, make your import file accessible via http. NOTE: Some code taken from report 12172. With thanks to Martin Renvoize. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:14:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:14:12 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #10 from Paola Rossi --- (In reply to Jonathan Druart from comment #4) > [...] you can try to apply patches from bug 12897, 12988 and 12989 without > this one. > The behavior was broken without updating the DT plugin. 1) Looking for a feedback, I've applied 12987, 12955, 12988, 12984 and 12989 without leading 12986. And I saw no number in the last row at the bottom of the tables in: ACQ home: /acqui/acqui-home.pl All Funds di ADMIN: /admin/aqbudgets.pl 2) Then I've applied 12986, 12987, 12955, 12988, 12984 and 12989. And I saw : 2A) still no numbers in the two tables 2B) The Showing broken. So I had no feedback for 12986 until this step 2) ! 3) So I've tried another test, and I've applied 12986, 12987, 12955, 12988, 12984 without the last 12989. 3.1) ACQ home was perfect: numbers ware present and OK, and Showing was OK too 3.2) Funds was KO: no numbers, broken Showing. So 3.1 had given me a feedback for 12986, but only about acq-home. 4) So I've tried another test, and I've applied 12986, 12987, 12955, 12988 without the last 12984. 4.1) ACQ home was OK about numbers which were present, 4.2) Funds was KO: no numbers, broken Showing as 3.1 5) So I've tried a further test, and I've applied 12986, 12987, 12955 without the last 12988. 5.1) ACQ home was OK about numbers which were present, 5.2) finally in Funds I saw numbers (whose sums were not right about hide/show' filter) [and no Showing]. So I think that 12986 is able to be signed off, but I keep it in the "In Discussion" status. The other linked patches are not yet perfect. In particular, if the sequence of applied patches I've written above is not wrong: bug 12986, bug 12987, bug 12955, bug 12988, bug 12984, bug 12989, at least: 12988 ruins the bottom of the funds' table, 12989 ruins the bottom of the ACQ-home' table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:24:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:24:03 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31974|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 31975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31975&action=edit Bug 12758: Workaround for loading stylesheets over https LibXML does not like https references when loading xml with the location parameter. This can be resolved by reading the file into a string and passing it to load_xml via the string parameter. Note that LWP::UserAgent will only load the file if LWP::Protocol::https is installed. This is an optional perl dependency in Koha. I mark it as required now. Also note that if your stylesheet contains an import with a https reference, this fix is not enough. The load_xml call will not fail, but the succeeding call to parse_stylesheet will still fail. As a workaround, make your import file accessible via http. NOTE: Some code taken from report 12172. With thanks to Martin Renvoize. Test plan: Take for example OPACXSLTDetailsDisplay and replace it by a https ref. Check opac detail display. Note that replacing OPACXSLTResultsDisplay by some https ref would also test repeating the call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 14:25:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 12:25:09 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #4 from Jonathan Druart --- I tried to make Koha::Borrower extends Koha::Schema::Result::Borrower, but I get an error. The idea was to remove the AUTOLOAD and avoid the IsStored, IsChanged, Id, etc. methods. [the error was: Unable to perform storage-dependent operations with a detached result source (source '_unnamed_' is not associated with a schema)] I suppose I tried to do something very bad :) So, some additional remarks on the patch: - "result" and "columns" should be _result and _columns to avoid collisions later, don't you think? - Are you sure it is useful to test if the row is stored and has been changed (Store method)? Not sure about the perf, maybe DBIC does that (?). - IsStored should be InStorage or completely removed, if useless. - Delete could call delete in an eval, to avoid a call to in_storage - what about 2 constructors? new and new_from_rs? The ResultSet should not be create if not used later - what about a _result method? It would return ->{_result} if already exists, otherwise create it. All occurrences to ->{result} will be replaced by ->_result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:03:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:03:07 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #43 from M. de Rooy --- (In reply to M. de Rooy from comment #42) > (In reply to Jonathan Druart from comment #41) > > (In reply to Jonathan Druart from comment #40) > > > Marcel, I submitted a patch on bug 11395 comment 39. Could you confirm it's > > > what you expected? > > > > It is bug 11395 comment 36. > > Will have a look soon. Soon was kind of relative. Try to get back at this now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:04:10 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8015 Depends on|8015 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:04:10 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11319 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:04:48 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12541 Blocks|12541 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:04:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:04:48 +0000 Subject: [Koha-bugs] [Bug 12541] Marc modification template - multivalued subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11319 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:05:16 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12541 | Depends on|8015 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:05:16 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11413 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:05:16 +0000 Subject: [Koha-bugs] [Bug 12541] Marc modification template - multivalued subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11413 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:06:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:06:35 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Depends on|11395 | --- Comment #1 from M. de Rooy --- Removing the dependency for now. There is still no code here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:06:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:06:35 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12540 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:19:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:19:53 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #37 from M. de Rooy --- (In reply to Jonathan Druart from comment #36) > Created attachment 31344 [details] [review] > Bug 11395: Raise an alert if control field is used > > If a control field is used with a copy or move action, the interface > should block the user in some cases: > - If a control field is used with a regular field > - The subfield should be empty Jonathan, I would rather suggest: A control field can be used with another control field or a subfield of a regular field. (Note: For some external records I would like to move for instance 001 to 029a.) A regular field can not be used with a control field only with another regular field. A regular subfield can be used with another regular subfield or a control field. Note that some moves are of course without any use, but this would be the general rule. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:24:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:24:10 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #38 from Jonathan Druart --- (In reply to M. de Rooy from comment #37) > Jonathan, I would rather suggest: > > A control field can be used with another control field or a subfield of a > regular field. (Note: For some external records I would like to move for > instance 001 to 029a.) > A regular field can not be used with a control field only with another > regular field. > A regular subfield can be used with another regular subfield or a control > field. > > Note that some moves are of course without any use, but this would be the > general rule. What do you think? I don't remember exactly, but I think I blocked the actions which don't work/don't be implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:51:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:51:47 +0000 Subject: [Koha-bugs] [Bug 13022] New: Hardcoded limit causes records with more than 20 items to show inaccurate statuses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Bug ID: 13022 Summary: Hardcoded limit causes records with more than 20 items to show inaccurate statuses Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:52:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:52:12 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:52:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:52:18 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:52:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:52:34 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #3 from Jonathan Druart --- Created attachment 31976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31976&action=edit Bug 12987: The new format_price include file should be include on using datatables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:54:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:54:05 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #2 from Jonathan Druart --- Created attachment 31977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31977&action=edit Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:55:30 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #11 from Jonathan Druart --- Hello Paola, I found 2 bugs. I submitted 2 patches, 1 on bug 12987 (The new format_price include file should be include on using datatables) and 1 on bug 12989 (Fix JS error). I hope that will fixed your issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:59:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:59:46 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 15:59:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 13:59:48 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #1 from Kyle M Hall --- Created attachment 31978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31978&action=edit Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. Test Plan: 1) Create a record with more than 20 items 2) Set all the items to waiting holds or in transit 3) Search for results that will include that item 4) Note some say they are available even though they are not 5) Apply this patch 6) Run updatedatabase.pl 7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck to a number larger than the number of items on your record 8) Re-run the search 9) Note that the hold and transit statuses for the items are now correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:04:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:04:57 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #12 from Zeno Tajoli --- I have find the answer to this question: >>Question: Do we use API plug-ins of DataTables jQuery plugin ? We have those plugin of DataTables: In intranet-tmpl/lib/jquery/plugins/ -- jquery.dataTables.grouping.js No clear if it works or not -- jquery.dataTables.colvis.js It is an official estension of DataTables, probably it works or an update to last version is enough -- jquery.dataTables.columnFilter.js In it is site speack about DataTables 1.9 http://jquery-datatables-column-filter.googlecode.com/svn/trunk/index.html I send emails to authors to undestand compliance situation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:27:46 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #49 from Kyle M Hall --- I completely agree. I think the best course of action is to have notes in the release that they will need to map the non-public note in each framework, then run misc/maintenance/touch_all_items.pl to pull the note into the db column. (In reply to David Cook from comment #48) > What do folks think about trying to resolve this issue in stages? > > 1) Add new non-public item note column to items and deleteditems > > 2) Add template stuff for the new column (even if the column is empty, which > would be the default, this wouldn't change any default system behaviour) > > That's it. The responsibility of updating frameworks and migrating data can > be left up to Koha administrators. It's not ideal, but it would be progress. > > Perhaps we could update the frameworks for a fresh install to show that's > how things should go in the future, but I don't see an automatic way of > fixing this for everyone and I don't think it makes sense to stop working on > this because it can't be perfect. > > > > > P.S. If I understand koha2marclinks.pl correctly, it is a frightening > script. On a test instance, it will say that "paidfor" is mapped to 952$x, > but it's not really...or rather...it's mapped to 952$x for the FA framework > but none of the others. That's incredibly misleading... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:36:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:36:00 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:42:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:42:53 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Jorge de Cardenas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdeca at smfpl.org --- Comment #24 from Jorge de Cardenas --- I am also getting the same errors as Doug Dearden. Did a package install of Koha 3.16.03 drop the database, created empty database and imported data from 3.10. Then updated the schema. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:48:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:48:56 +0000 Subject: [Koha-bugs] [Bug 13023] New: Nonpublic note for items should be mapped to a database column like itemnotes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Bug ID: 13023 Summary: Nonpublic note for items should be mapped to a database column like itemnotes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:09 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #1 from Kyle M Hall --- Created attachment 31979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31979&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Run misc/maintenance/touch_all_items.pl 5) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:07 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:17 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:55 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13023 Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:56 +0000 Subject: [Koha-bugs] [Bug 2370] MARC21 non-public note is mapped to items.paidfor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2370 Bug 2370 depends on bug 4222, which changed state. Bug 4222 Summary: Nonpublic note not appearing in the staff client http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:56 +0000 Subject: [Koha-bugs] [Bug 6748] Add link to fast add framework while circulating, if a barcode is not found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6748 Bug 6748 depends on bug 4222, which changed state. Bug 4222 Summary: Nonpublic note not appearing in the staff client http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:51:56 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4222 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:52:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:52:52 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #50 from Kyle M Hall --- Moving and splitting bug into db part and UI part. Koha has moved on quite a but so at least some of the UI code is now outdated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:53:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:53:15 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:56:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:56:48 +0000 Subject: [Koha-bugs] [Bug 13024] New: Nonpublic note not appearing in the staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Bug ID: 13024 Summary: Nonpublic note not appearing in the staff client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:56:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:56:59 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:57:15 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13023 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:57:15 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13024 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:57:29 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4222 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:57:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:57:29 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13024 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 16:58:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 14:58:51 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31979|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 31980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31980&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Run misc/maintenance/touch_all_items.pl 5) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:07:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 15:07:53 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31830|0 |1 is obsolete| | --- Comment #4 from Paola Rossi --- Created attachment 31981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31981&action=edit Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl I've applied the patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2). Everything is OK. NB. in Conf III 1-0 RRP tax inc. : 162.02 instead of 164.0 (file-doc in 12964) 82.01 instead of 82.0 (file-doc in 12964) I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:13:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 15:13:11 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #5 from Jonathan Druart --- (In reply to Paola Rossi from comment #4) > Created attachment 31981 [details] [review] Paola, you forgot to attach your signoff patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 15:16:00 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > (In reply to Paola Rossi from comment #4) > > Created attachment 31981 [details] [review] [review] > > Paola, you forgot to attach your signoff patch :) Sorry, end of the day... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:24:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 15:24:18 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:24:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 15:24:33 +0000 Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 17:24:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 15:24:49 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 21:06:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 19:06:31 +0000 Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #12 from Christopher Brannon --- We would like to see this resolved. We are in 3.14 and still see this problem. My vote would be to not use a pause or call something twice. Perhaps I am oversimplifying this, but couldn't it be setup so that submitting the form with the "confirm and print slip" button just submits the form, and then calls the next step (printing) when completed? Or is the problem that both the "confirm" and "confirm and print slip" buttons both call the same submit form function? Could a switch be added to the function so that if "confirm and print slip" were clicked, it would pass on an extra switch or value to the submit function that would trigger the print when the function is complete? Again, I could be oversimplifying this, not knowing the code at all. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 21:28:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 19:28:13 +0000 Subject: [Koha-bugs] [Bug 13025] New: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Bug ID: 13025 Summary: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com One of our partners is seeing the following Software error intermittently on checkout: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925, line 522. Here's the offending code: 1924 # Remove any OVERDUES related debarment if the borrower has no overdues 1925 if ( $borrowernumber 1926 && $borrower->{'debarred'} 1927 && C4::Context->preference('AutoRemoveOverduesRestrictions') 1928 && !HasOverdues( $borrowernumber ) 1929 && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) } 1930 ) { 1931 DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); 1932 } I'm not *entirely* sure why this is happening -- HasOverdues is defined in C4/Members.pm: 53 push @EXPORT, qw( 54 &Search 55 &GetMemberDetails 56 &GetMemberRelatives ... 108 HasOverdues 109 ); and C4::Members is being included in C4/Circulation.pm: 30 use C4::Members; ... so !HasOverdues( $borrowernumber ) *shouldn't* be interpreted as a call to &C4::Circulation::HasOverdues ... nonetheless, calling 1928 && !HasOverdues( $borrowernumber ) could be re-written as 1928 && ! C4::Members::HasOverdues( $borrowernumber ) which would be un-ambiguously correct. For the sake of consistency, the call to HasOverdues at C4/Circulation.pm line 2626 should also be changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 21:36:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 19:36:52 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 22:05:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 20:05:08 +0000 Subject: [Koha-bugs] [Bug 11271] serials table off the screen on low resolutions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 --- Comment #1 from Nicole C. Engard --- This is still an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 22:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 20:05:32 +0000 Subject: [Koha-bugs] [Bug 11271] serials table off the screen on low resolutions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Nicole C. Engard --- *** Bug 10873 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 22:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 20:05:32 +0000 Subject: [Koha-bugs] [Bug 10873] Lots of wasted space in Serial Search Result table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10873 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nengard at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 11271 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 2 23:01:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Oct 2014 21:01:07 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #25 from Jorge de Cardenas --- In addition to the issn_idx index I also have isbnidx index. I will be dropping these and later retest. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 11:59:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 09:59:10 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 11:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 09:59:50 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31901|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 31982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31982&action=edit Bug 13001: Refactor VAT and price calculation - parcel page I've applied te patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) I've tested setting pref currencyformat either on FR or US. The tested steps in file-doc at bug 12964 are about parcel.pl: STEP 5) STEP 10) Either on 1-0 or 1-1 I've seen, as required: before: 140.57 + 7.03 = 147.60 now: 140.58 + 7.02 = 147.60 So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:11:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:11:32 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:12:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:12:46 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31880|0 |1 is obsolete| | --- Comment #4 from Paola Rossi --- Created attachment 31983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31983&action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl I've applied the patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) I've tested setting pref currencyformat either on FR or US. As required, I've seen on invoice.pl: CONF I 0-0 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.38 total_tax_exc = 147.60 total_tax_inc = 154.98 ------------------ CONF II 1-1 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.02 total_tax_exc = 140.58 total_tax_inc = 147.60 ------------------ CONF III 1-0 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.02 total_tax_exc = 140.58 total_tax_inc = 147.60 ------------------- CONF IV 0-1 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.38 total_tax_exc = 147.60 total_tax_inc = 154.98 ------------------- I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:40:12 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Kyle M Hall --- Owen, what did I do here differently from bug 10634? Can you describe what I need to do? Is there an existing example in Koha I can use as a pattern? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:55:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:55:39 +0000 Subject: [Koha-bugs] [Bug 12980] GetHistory does useless processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:55:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:55:41 +0000 Subject: [Koha-bugs] [Bug 12980] GetHistory does useless processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31900|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 31984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31984&action=edit [PASSED QA] Bug 12980: GetHistory does useless processing GetHistory iterated on the orders to calculate the quantity and price. These values are never used by the called. It can be removed. Test plan: Verify there is no regression on acqui/histsearch.pl and catalogue/detail.pl Actually you just have to check that the total quantity and price are not displayed on these views. QA: note that 'count' and 'toggle' are never used in the template. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:58:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:58:19 +0000 Subject: [Koha-bugs] [Bug 12985] All basketgroups are not listed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 15:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 13:58:22 +0000 Subject: [Koha-bugs] [Bug 12985] All basketgroups are not listed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31868|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 31985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31985&action=edit [PASSED QA] Bug 12985: All basketgroups should be listed Only 20 first are listed, others are hidden. Test plan: - Create at least 21 basketgroups - verify you can see it on the "open" tab - close all of them - verify you can see it on the "close" tab There is no restriction to hide datables functions here. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:11:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:11:23 +0000 Subject: [Koha-bugs] [Bug 12992] Fund planning does not display actual values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12992 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:11:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:11:25 +0000 Subject: [Koha-bugs] [Bug 12992] Fund planning does not display actual values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12992 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31904|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 31986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31986&action=edit [PASSED QA] Bug 12992: Fund planning should display actual values The 'show_actual' variable is not correctly manage in the template. This has certainly been introduced by the migration to TT. Test plan: 1/ Go on a bugdet planning view (admin/aqplan.pl) 2/ Check the "Show actual/estimated values" checkbox on the left (Filters box) 3/ Go 4/ Verify the actual values are now displayed (i.e. the columns contain 2 values). Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:15:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:15:17 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:27:43 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:27:46 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31824|0 |1 is obsolete| | Attachment #31825|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 31987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31987&action=edit [PASSED QA] Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:27:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:27:59 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #6 from Kyle M Hall --- Created attachment 31988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31988&action=edit [PASSED QA] Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:28:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:28:02 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #7 from Kyle M Hall --- Created attachment 31989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31989&action=edit [PASSED QA] Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:40:37 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- I can see a couple of things offhand which need to be addressed: - Apply to the Bootstrap theme - Use the new DataTables include file > DataTables won't be styled correctly without changes to the CSS and the > addition of DataTables-related images. That needs to be taken care of before > this patch goes in. This patch doesn't work properly for me anymore in master (missing datatables-strings.inc file), so I can't say for sure but it sounds like the existing CSS file in the OPAC doesn't (fully?) handle the pagination menu controls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:46:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:46:05 +0000 Subject: [Koha-bugs] [Bug 12956] Users are not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31779|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 31990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31990&action=edit [PASSED QA] Bug 12956: Users are not linked to a fund When creating a fund, if you add some users, they are not linked to the fund. Note that it works if you link them when editing the fund. Test plan: - Try to link users to a fund on creating it. - On editing, you should see the linked user list. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:46:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:46:03 +0000 Subject: [Koha-bugs] [Bug 12956] Users are not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:47:27 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #7 from Dobrica Pavlinusic --- Sorry for delay, I wanted to test things before submitting more code. I can't really get LDAP_NO_SUCH_OBJECT error on bind. My guess is that this error would appear if I was searching for object which wasn't defined in LDAP schema as opposed to bind call. Did you manage to get this error from LDAP server on bind? I wouldn't like to insert code there just because it seems right, since LDAP code in Koha is already black magic to almost everyone and accumulating cruft doesn't seem like a good idea. Regarding LDAP_INVALID_CREDENTIALS, it's already handled by else part of if statement and I did test with invalid password and it works as-is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:54:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:54:24 +0000 Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 16:54:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 14:54:26 +0000 Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31857|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 31991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31991&action=edit [PASSED QA] Bug 12646: Display all invoices on the same page Only first 20 invoices were displayed on the page. Without pagination, DT did not allow to show others. This page explicitely removes the pagination option in order to display all invoices on the page. Test plan: 1/ Create 21+ invoices 2/ Go on acqui/invoices 3/ Verify all invoices are displayed. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 17:39:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 15:39:40 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 17:40:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 15:40:15 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 17:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 15:41:43 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #13 from Paola Rossi --- (In reply to Jonathan Druart from comment #11) > Hello Paola, I found 2 bugs. > I submitted 2 patches, 1 on bug 12987 (The new format_price include file > should be include on using datatables) and 1 on bug 12989 (Fix JS error). > I hope that will fixed your issues. Thanks, Jonathan. Sorry, it's not yet OK: I've applied these patches against master 3.17.00.025 : 12986, 12987 (2), 12955, 12988, 12984, 12989 (2) but no numbers neither in the "Total" row of acqui-home, nor in the "Period allocated" row of funds in /admin/aqbudgets.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 18:01:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 16:01:02 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #8 from Dobrica Pavlinusic --- Upon further investigation, I decided to obsolete my patch because I suspect that if fixes problem only for our particular installation instead of providing general solution to problem. Let me explain... Problem comes from the fact that in LDAP bind we can't distinguish between users which doesn't exist in LDAP and invalid passwords. Both of those return LDAP_INVALID_CREDENTIALS (in our installation we have a bit of LDAP software in between which creates invalid DN for users which are not in LDAP, but that is not generally applicable). This means that we have to know (somehow) weather users should use LDAP passwords or not. Currently we don't have that information. One possibility is to do LDAP search (anonymous or via some account) and if user does exist in LDAP force him to provide proper LDAP password. However, this might not be practical because it creates additional load on LDAP server on one hand, and on another anonymous searches might be disabled (that's probably why we are using auth_by_bind in the first place) or there might not be special user which can search whole LDAP (or library might not have permissions to add such user which is our case). Another possibility is to track locally in Koha if users should use LDAP or local passwords. This might be implemented simply by invalidating local password (with word LDAP for example :-) which would prevent local fallback from working if user is logged in using LDAP. I'm biased towards second solution but I would love to hear some feedback about it before producing code. However, in any case we don't have clear migration path for existing installations because they do have local LDAP passwords in database (like we do). After first LDAP login users will have local password invalidated, but users which never login with correct LDAP password (or who are already disabled) we still be able to login using cached password. To be quite honest, I did use that side-effect of old code which allowed our patrons to login while LDAP wasn't available, so it might even make sense to have that behavior again (as LDAP configuration option perhaps). But if that is the case, we again don't have ability to expire users just in LDAP and expect them to be disabled in Koha also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 18:55:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 16:55:54 +0000 Subject: [Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|serials table off the |Serials table off the |screen on low resolutions |screen in smaller viewports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 17:11:00 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 17:19:51 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > I tried to make Koha::Borrower extends Koha::Schema::Result::Borrower, but I > get an error. > The idea was to remove the AUTOLOAD and avoid the IsStored, IsChanged, Id, > etc. methods. > > [the error was: Unable to perform storage-dependent operations with a > detached result source (source '_unnamed_' is not associated with a schema)] > I suppose I tried to do something very bad :) > > So, some additional remarks on the patch: > - "result" and "columns" should be _result and _columns to avoid collisions > later, don't you think? Good idea > - Are you sure it is useful to test if the row is stored and has been > changed (Store method)? Not sure about the perf, maybe DBIC does that (?). Yeah, I'd have to check the DBIC code, but that seems entirely likely. > - IsStored should be InStorage or completely removed, if useless. Again, your probably right. I can't see a use for this right now and we can always add an InStorage method at a later date if it *is* needed for something. > - Delete could call delete in an eval, to avoid a call to in_storage Do you think that will improve efficiency? in_storage has already been calculated and is just a dbic property. It seems like using eval would take more time. > - what about 2 constructors? new and new_from_rs? The ResultSet should not > be create if not used later For Koha::Object? That's a good idea. > - what about a _result method? It would return ->{_result} if already > exists, otherwise create it. All occurrences to ->{result} will be replaced > by ->_result Also a good idea. I'll see if I can't make some time next week to implement these changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 17:38:50 +0000 Subject: [Koha-bugs] [Bug 12775] Only suggestion manager can order from accepted suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 19:38:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 17:38:53 +0000 Subject: [Koha-bugs] [Bug 12775] Only suggestion manager can order from accepted suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31891|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 31992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31992&action=edit [PASSED QA] Bug 12775: Suggestions should be ordered by anyone Currently only the suggestion manager can order from accepted suggestion. This patch set to default the ability to show all suggestions when ordering from a suggestion. 2 links "show only mine" and "show all" permits to filter/show all permissions. Test plan: Create an order from a suggestion and verify you are able to see all suggestions by default. Verify the "show only mine" link works as expected. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:05:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 18:05:55 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:05:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 18:05:58 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31817|0 |1 is obsolete| | Attachment #31819|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 31993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31993&action=edit [PASSED QA] Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:06:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 18:06:09 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #13 from Kyle M Hall --- Created attachment 31994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31994&action=edit [PASSED QA] Bug 12538 : FOLLOW UP Remove Moose from the list of dependencies Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:27:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 18:27:11 +0000 Subject: [Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 --- Comment #3 from Owen Leonard --- Created attachment 31995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31995&action=edit Bug 11271 - Serials table off the screen in smaller viewports When you search for serials in the Serials module the results table is often too wide for the screen (depending on your browser window size). This is partly due to the fixed width of the search fields in the table footer. This patch applies a flexible width to those s and reduces the font size of their text. This patch also moves the "action" links for each table row into an "action" menu (similar to the change made by Bug 10615 in Reports) to further conserve screen space. This patch also revises the page's DataTables configuration to use table header classes for sorting configuration. To test you should be able to perform a search which returns multiple open and closed subscriptions. - Test that table sorting works correctly, including for titles with articles and for dates. - Test that the Action menu items work correctly and that they correctly reflect the permissions of the logged-in user with regard to receive_serials and routing. - Perform these tests on both the "Open" and "Closed" tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 20:27:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 18:27:08 +0000 Subject: [Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 3 21:50:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 19:50:45 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply Patch complexity|--- |Medium patch --- Comment #14 from Zeno Tajoli --- Hi to all, I think to have finish the basic check asked comment #2. There are two points that emerge as important: -- Support of IE6/IE7 -- Interaction with plugins of this plugin. a)Support of IE6/IE7 Discussions on chat and mailing list give as answer: we can drop support of IE6/IE7; http://lists.katipo.co.nz/pipermail/koha/2014-October/040960.html, http://lists.koha-community.org/pipermail/koha-devel/2014-October/040836.html, http://irc.koha-community.org/koha/2014-10-01#i_1575703, http://irc.koha-community.org/koha/2014-10-02#i_1575984 b)Interaction with plugins of this plugin. There three plugin of DataTables in Koha, they are in intranet-tmpl/lib/jquery/plugins/ 1) jquery.dataTables.colvis.js Written from the same firm that write DataTables, update to new version of DataTables. 2) jquery.dataTables.rowGrouping.js We use the last version, there are same minir problems,the best option is to use old 1.9 API when you is plugin, see https://code.google.com/p/jquery-datatables-row-grouping/issues/detail?id=75&sort=-id 3) jquery.dataTables.columnFilter.js We don't use the last version, there is a patch to improve compatibility with v.1.10, https://code.google.com/p/jquery-datatables-column-filter/issues/detail?id=158&sort=-id So my idea is that: -- We can update -- We need to update also plugins. So, now for me 'Patch doesn't apply' because you don't update plugin. I think that a patch to test needs: 1) update DataTables to v 1.10 2) update query.dataTables.colvis.js 3) evalute if update or not query.dataTables.columnFilter.js and insert or not the patch linked. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 4 01:18:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Oct 2014 23:18:43 +0000 Subject: [Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #1 from bondiurbano --- It would be very nice...3.16.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 4 22:51:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Oct 2014 20:51:12 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #3 from Nick Clemens --- I tried testing created items with non-public notes apply patch upgrade database map itemnotes_nonpublic to 952x run touch_all_items.pl all non-public notes still seemed to be in more_sbfields_xml new notes worked as expected but I couldn't get old notes to transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 4 23:03:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Oct 2014 21:03:15 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick at quecheelibrary.org --- Comment #27 from Nick Clemens --- Applying: Bug 12892 - Holds Waiting: not showing from check out screen Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t CONFLICT (content): Merge conflict in t/db_dependent/Reserves.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/circulation.pl Failed to merge in the changes. Patch failed at 0001 Bug 12892 - Holds Waiting: not showing from check out screen When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12892---Holds-Waiting-not-showing-from-check-o-xSl9aQ.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 02:19:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 00:19:43 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #28 from Owen Leonard --- Did you apply the dependencies first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 02:54:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 00:54:13 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #29 from Nick Clemens --- SMH, no I got caught up reading through the discussion and forgot to go back up and note them. I can't apply 11518 so can't apply 11703 and so can't apply this, will retreat for simpler bugs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:11:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:11:11 +0000 Subject: [Koha-bugs] [Bug 12981] Patron attribute type limit by patron category not working on patron entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #2 from Nick Clemens --- I confirmed the behavior The patch works as described. Does it matter that I can change the category in order to make the attribute show, fill it in, change it again and hide the field, but still have the information save? It reuires a pretty deliberate staff action but you end up with an attribute showing that you can't edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:27:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:27:23 +0000 Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration hold date in staff not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:27:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:27:30 +0000 Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration hold date in staff not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31685|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 31996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31996&action=edit [SIGNED OFF] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:28:39 +0000 Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration hold date in staff not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:46:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:46:56 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:47:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:47:00 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30726|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 31997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31997&action=edit [SIGNED OFF] Bug 643: Allow override of 'debarred' status Add a button to temporarily override patron debarment. To test: 1) Go to patron check out page 2) If patron has been debarred (eg. due to having fees), there is no way to check out to that patron. 3) Apply patch 4) A debarred patron check out page now has a button for "Override debarment temporarily" - clicking on it should allow checking out to that patron. Signed-off-by: Aleisha Rebased because patch did not apply Signed-off-by: Aleisha Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:47:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:47:16 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30727|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 31998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31998&action=edit [SIGNED OFF] Bug 643: Followup: Display override button only if issuing staff member has force_checkout permission To test: Apply first patch Apply this patch Log in as superlibrarian Go to Home > Patrons > Set permissions for issuing staff member Disable circulate - force_checkout Log in as issuing staff member Try to checkout to a debarred patron => should not be possible Log in again as superlibrarian Enable circulate - force_checkout for issuing staff member Log in as issuing staff_member Try to checkout to a debarred person => You should get the button 'Override debarment temporarily' Signed-off-by: Aleisha Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 03:47:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 01:47:31 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31837|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 31999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31999&action=edit [SIGNED OFF] Bug 643: QA Followup - server-side verification of permissions Only allow $force_allow=1 if the logged in user has permissions. TEST PLAN --------- Attempt to intentionally override the checkout by passing an appropriately handcrafted URL. -- Regardless of the force_allow value, it should be not allowed for those lacking the force_checkout permission. NOTE: I didn't test this. I figured Marc Veron could do that. :) (Sorry, couldn't easily get git bz to work with the accent) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 05:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 03:36:42 +0000 Subject: [Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31574|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 32000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32000&action=edit [SIGNED OFF] Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 05:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 03:36:37 +0000 Subject: [Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 23:54:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 21:54:04 +0000 Subject: [Koha-bugs] [Bug 7878] When duplicating a patron too many fields carrying over In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 5 23:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 21:54:07 +0000 Subject: [Koha-bugs] [Bug 7878] When duplicating a patron too many fields carrying over In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31903|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 32001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32001&action=edit [SIGNED OFF] Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 00:38:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 22:38:54 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 00:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 22:48:23 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #3 from Jonathan Druart --- Kyle, the patch applies correctly here. Switch the status back to SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 00:55:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Oct 2014 22:55:26 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Jonathan Druart --- Hello Zeno, thanks for your tests. This bug report only updates the DataTables plugin. We could update others too if needed, but it is not the goal of this one, except if regressions are found. Back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 09:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 07:23:43 +0000 Subject: [Koha-bugs] [Bug 13026] New: permanent location becomes CART. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026 Bug ID: 13026 Summary: permanent location becomes CART. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Just noticed we have ~1500 items with items.location == CART and items.permanent_location == CART. No idea how to replicate this issue. Probably related to Bug 7817. This leads to loss of location data for Items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 10:16:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 08:16:43 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #91 from Colin Campbell --- Branch edi_master on git at github.com:colinsc/koha.git is the version I've deployed on our customers. I'll be creating a patch to submit against this bug but its available there for interested parties that may want to take a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 11:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 09:49:42 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Paola Rossi --- After having applied these patches : 12986, 12987 (2), 12955, 12988, 12984, 12989 (2) I've tested what is required by 12987, 12988, 12989. Using both the browsers Mozilla FF version 32.0.3 and IExplorer version 11.0. everything is OK excluding this case: currencyformat pref set to FR, fund's (=aqbudgets.pl) totals are all zeros (ERROR). So I pass the patch to "Failed QA" status. NB. To test the patches it might be that the browser should be closed and reopened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:08:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:08:44 +0000 Subject: [Koha-bugs] [Bug 13027] New: Typo RoutlingListNote Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 Bug ID: 13027 Summary: Typo RoutlingListNote Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:09:49 +0000 Subject: [Koha-bugs] [Bug 13027] Typo RoutlingListNote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:09:51 +0000 Subject: [Koha-bugs] [Bug 13027] Typo RoutlingListNote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 --- Comment #1 from M. de Rooy --- Created attachment 32002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32002&action=edit Bug 13027: Typo RoutlingListNote Trivial patch adjusts two occurrences of this typo in two installer sql files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:10:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:10:10 +0000 Subject: [Koha-bugs] [Bug 13027] Typo RoutlingListNote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:12:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:12:02 +0000 Subject: [Koha-bugs] [Bug 13027] Typo RoutlingListNote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 --- Comment #2 from M. de Rooy --- Created attachment 32003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32003&action=edit Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:12:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:12:43 +0000 Subject: [Koha-bugs] [Bug 13027] Typo RoutlingListNote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 --- Comment #3 from M. de Rooy --- Oops wrong command ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 13:12:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 11:12:56 +0000 Subject: [Koha-bugs] [Bug 13027] Typo RoutlingListNote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:04:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:04:39 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31964|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 32004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32004&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:08:59 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > - "result" and "columns" should be _result and _columns to avoid collisions > later, don't you think? Done! > - Are you sure it is useful to test if the row is stored and has been > changed (Store method)? Not sure about the perf, maybe DBIC does that (?). DBIC does indeed do that already. In fact, DBIC will only update changed columns and skipped those that are unchanged. > - IsStored should be InStorage or completely removed, if useless. Changed to InStorage > - Delete could call delete in an eval, to avoid a call to in_storage This one I did not implement, in_storage is really just a property to I believe it is quicker than using eval. We can always run some tests to see which is really faster. > - what about 2 constructors? new and new_from_rs? The ResultSet should not > be create if not used later Done! > - what about a _result method? It would return ->{_result} if already > exists, otherwise create it. All occurrences to ->{result} will be replaced > by ->_result Done! Also done for _columns as well since it depends on _result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:09:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:09:42 +0000 Subject: [Koha-bugs] [Bug 13028] New: Use of uninitialized value in string eq at misc/maintenance/cmp_sysprefs.pl line 194 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Bug ID: 13028 Summary: Use of uninitialized value in string eq at misc/maintenance/cmp_sysprefs.pl line 194 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. This is corrected by a better test of the hash value in the CheckVersionPref subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:14:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:14:32 +0000 Subject: [Koha-bugs] [Bug 13028] Use of uninitialized value in string eq at misc/maintenance/cmp_sysprefs.pl line 194 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:14:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:14:35 +0000 Subject: [Koha-bugs] [Bug 13028] Use of uninitialized value in string eq at misc/maintenance/cmp_sysprefs.pl line 194 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #1 from M. de Rooy --- Created attachment 32005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32005&action=edit Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194 If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. This is corrected by a better test of the hash value in the CheckVersionPref subroutine. Test plan: [1] Create a small pref file and remove the version pref (if present). You could for instance do a pref backup and remove most lines. [2] Use the restore option with and without this patch. So, something like: maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f 9999crucial.pref [3] Check on the error message and the pref count. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:17:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:17:25 +0000 Subject: [Koha-bugs] [Bug 13028] Use of uninitialized value in string eq at misc/maintenance/cmp_sysprefs.pl line 194 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:34:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:34:46 +0000 Subject: [Koha-bugs] [Bug 12982] Patron category dropdown empty in header search form on patron entry page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:34:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:34:48 +0000 Subject: [Koha-bugs] [Bug 12982] Patron category dropdown empty in header search form on patron entry page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31850|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 32006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32006&action=edit [SIGNED-OFF] Bug 12982 - Patron category dropdown empty in header search form on patron entry page The include file which contains the patron search form assumes that the page in which it is included will have access to a set of patron categories passed from the script. This is often not the case. This patch adds a new template plugin for getting patron categories and adds usage of it to patron-search.inc. The follow templates include patron-search.inc: members\boraccount.tt members\deletemem.tt members\files.tt members\mancredit.tt members\maninvoice.tt members\member-flags.tt members\member-password.tt members\member.tt members\memberentrygen.tt members\members-update.tt members\moremember.tt members\notices.tt members\pay.tt members\paycollect.tt members\purchase-suggestions.tt members\readingrec.tt members\routing-lists.tt members\statistics.tt tools\import_borrowers.tt tools\picture-upload.tt To test, view those pages and confirm that the patron category dropdown is present in the patron header search at the top of the page (shown by clicking the [+] link). Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:38:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:38:51 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32004|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 32007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32007&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 14:43:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 12:43:31 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32007|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 32008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32008&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:06:25 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32008|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 32009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32009&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:06:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:06:56 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31963|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 32010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32010&action=edit Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:31:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:31:01 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy --- - else { # Assume any if no index was specified - $attr = " \@attr 1=Any "; - } >From glancing thru this code: The place of this else in the old code and in the new code is different. In the new code you are not reaching this point anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:35:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:35:49 +0000 Subject: [Koha-bugs] [Bug 13029] New: Allow to pass additional parameters to SMS::Send drivers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Bug ID: 13029 Summary: Allow to pass additional parameters to SMS::Send drivers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:36:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:36:05 +0000 Subject: [Koha-bugs] [Bug 12974] Argument "" isn't numeric in numeric gt (>) in opac-results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12974 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy --- ( SEARCH_RESULT.rating_total && SEARCH_RESULT.rating_total ) > 0 This is probably not what you intended to do. Do you mean: A && A>0 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:36:55 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #1 from Julian Maurice --- Created attachment 32011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32011&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers C4::SMS::send_sms now reads a YAML file and pass all parameters in the file to SMS::Send::new. The config file is read in /etc/sms/driver/.yaml. For instance, if the driver used is SMS::Send::UK::Kapow, the config file has to be in /etc/sms/driver/UK/Kapow.yaml A underscore character is prepended to all parameter names so they are treated as driver-specific options (leading underscore must not appear in config file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:37:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:37:08 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:38:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:38:58 +0000 Subject: [Koha-bugs] [Bug 10784] SMS-related code needs improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- (In reply to Jonathan Druart from comment #2) > See http://git.biblibre.com/biblibre/kohac/commits/sanop/ft/MT10141 too. This has been submitted in bug 13029 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:43:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:43:28 +0000 Subject: [Koha-bugs] [Bug 13030] New: Show waiting hold expiration date for waiting holds on circulation.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Bug ID: 13030 Summary: Show waiting hold expiration date for waiting holds on circulation.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:43:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:43:43 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13030 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:43:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:43:43 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12892 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:45:25 +0000 Subject: [Koha-bugs] [Bug 13031] New: create_koc_db.pl shows error Can't locate C4/Context.pm in @INC on execution Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13031 Bug ID: 13031 Summary: create_koc_db.pl shows error Can't locate C4/Context.pm in @INC on execution Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mydsls at yahoo.in QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While executing following command /usr/share/koha/bin/cronjobs/create_koc_db.pl -sqlite3 It's showing following error : Can't locate C4/Context.pm in @INC ( @INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at /usr/share/koha/bin/cronjobs/create_koc_db.pl line 97. Please anyone can look in the matter so we can prepare borrower database to make offline circulation Regards Abhijit Nikam -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:49:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:49:48 +0000 Subject: [Koha-bugs] [Bug 13032] New: Feature Request -- command line switch to add page breaks to overdue_notices.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13032 Bug ID: 13032 Summary: Feature Request -- command line switch to add page breaks to overdue_notices.pl Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When overdue_notices.pl is run using the '-n' option, form feed characters are inserted between notices. This is currently the only way of inserting page breaks between notices. I've had several partners request that page breaks be added for the email sent to the library containing all notices for patrons who do not have email. This could be added via a command line switch -- perhaps '--page-break'. The behavior of this switch should be aware of whether the notices are html formatted or not -- if they are, page breaks must be added via CSS/html, if they are not, they should be inserted as form-feeds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:50:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:50:24 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:57:51 +0000 Subject: [Koha-bugs] [Bug 13032] Feature Request -- command line switch to add page breaks to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13032 --- Comment #1 from Barton Chittenden --- HTML page breaks can be added as follows: CSS: @media all { .page-break { display: none; } } @media print { .page-break { display: block; page-break-before: always; } } HTML:
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 15:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 13:58:03 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Owen Leonard --- (In reply to Paola Rossi from comment #16) > After having applied these patches : > > 12986, 12987 (2), 12955, 12988, 12984, 12989 (2) I don't think this patch should be failed based on testing those bugs since this report isn't designated as being dependent on them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:00:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:00:49 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:00:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:00:51 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #1 from Kyle M Hall --- Created attachment 32012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32012&action=edit Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:01:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:01:06 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #2 from Julian Maurice --- Created attachment 32013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32013&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers Fixed a variable name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:01:35 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:04:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:04:20 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #18 from Jonathan Druart --- (In reply to Owen Leonard from comment #17) > (In reply to Paola Rossi from comment #16) > > After having applied these patches : > > > > 12986, 12987 (2), 12955, 12988, 12984, 12989 (2) > > I don't think this patch should be failed based on testing those bugs since > this report isn't designated as being dependent on them. Yes, please mark as failed qa bug 12988 if the problem only exists on the aqbudgets.pl page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:08:34 +0000 Subject: [Koha-bugs] [Bug 9321] holds queue printable version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9321 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:18:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:18:50 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #3 from Nicole C. Engard --- Just an update that this is still an issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:23:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:23:01 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #22 from Nicole C. Engard --- My opinion is that it is in fact a bug - because it bugs a lot of people :) No, seriously, it's confusing many users and should be consistent. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:30:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:30:16 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #3 from Paola Rossi --- I've applied these patches against master 3.17.00.025: 12986, 12987 (2), 12955, 12988, 12984, 12989 (2) Using both the browsers Mozilla FF version 32.0.3 and IExplorer version 11.0. everything is OK excluding this case: currencyformat pref set to FR, fund's (=aqbudgets.pl) totals are all zeros (ERROR). So I pass the patch to "Failed QA" status. NB. To test the patches it might be that the browser should be closed and reopened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:34:39 +0000 Subject: [Koha-bugs] [Bug 12974] Argument "" isn't numeric in numeric gt (>) in opac-results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12974 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31794|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 32014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32014&action=edit Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 16:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 14:40:33 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 --- Comment #4 from Jonathan Druart --- Paola, the issue only appears on the aqbudgets page (not the aqui-home page)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 17:05:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 15:05:34 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 --- Comment #5 from Jonathan Druart --- I don't have this error. All looks good. Could you please attach a screenshot please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 17:33:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 15:33:06 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #2 from Paola Rossi --- I've applied the patch against master 3.17.00.025 I've set some values in the gist system pref. Then, editing an itemtype, I could select a tax rate value in the drop down list of "Tax rate" field, but, after saving changes, the tax rate value was not recorded to the itemtype in the DB. The patch is lacking in adding the "gstrate" field to the itemtypes DB-table. [The patch gives no updatedatabase.pl' diffs (at least).] So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 17:54:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 15:54:53 +0000 Subject: [Koha-bugs] [Bug 12974] Argument "" isn't numeric in numeric gt (>) in opac-results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12974 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32014|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 32015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32015&action=edit Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) Signed-off-by: Magnus Enger Works as advertized. Looks like you have to be logged in to trigger the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 17:54:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 15:54:50 +0000 Subject: [Koha-bugs] [Bug 12974] Argument "" isn't numeric in numeric gt (>) in opac-results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12974 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 18:20:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 16:20:49 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 --- Comment #6 from Paola Rossi --- Created attachment 32016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32016&action=edit screen about the error case here is the image of the screen for the error case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 19:07:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 17:07:30 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 19:07:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 17:07:33 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32010|0 |1 is obsolete| | --- Comment #31 from Nick Clemens --- Created attachment 32017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32017&action=edit [SIGNED OFF] Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 19:57:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 17:57:54 +0000 Subject: [Koha-bugs] [Bug 13033] New: Waiting holds do not alert on check-in. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033 Bug ID: 13033 Summary: Waiting holds do not alert on check-in. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Items with waiting holds which are checked in do not trigger a "Waiting Holds" alert when the patron checking in the item has waiting holds. Nick Clemins found this while signing off on ticket 12892 "Holds Waiting: not showing from check out screen". Steps to reproduce. 1) Patron A checks out item 1 2) Patron B checks out item 2 3) Patron B places a hold for item 1 4) Patron A checks in item 1 => Item 1 is waiting for patron B. 5) Patron B returns item 2 This should trigger an alert that Patron B has waiting holds, but the alert does not trigger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 19:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 17:59:32 +0000 Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12892 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 19:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 17:59:32 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13033 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:02:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:02:11 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #32 from Barton Chittenden --- There is an analogous problem on check-in. See bug 13033. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:04:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:04:57 +0000 Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:08:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:08:51 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:08:55 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #3 from Jonathan Druart --- Created attachment 32018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32018&action=edit Bug 12993: Add a default tax rate on item types - DB changes This patch adds a new DB field: itemtypes.gstrate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:09:23 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #4 from Jonathan Druart --- Sorry Paola, I forgot to attach the DB changes patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:15:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:15:07 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #2 from Nick Clemens --- I am not seeing a difference after applying the patches, in both instances I see the list from top to bottom as 3,1,2 What are the orders for the incorrect function and the desired function? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:19:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:19:52 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #4 from Jonathan Druart --- Created attachment 32019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32019&action=edit Bug 12987: Fix remove all what is not number The regex was wrong, to calculate a total, we should keep number (0-9) and minus sign (-). All others characters should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:20:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:20:07 +0000 Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:20:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:20:26 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart --- Thanks for the screenshot, very useful! I added a patch on bug 12987, it should fix your issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:50:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:50:36 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 20:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 18:50:41 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31852|0 |1 is obsolete| | --- Comment #19 from Owen Leonard --- Created attachment 32020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32020&action=edit [SIGNED-OFF] Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) DataTables 1.10.2 is now available. The footerCallback function does not seem to work correctly with our current version. Test plan: Go on the maximum of pages where DataTables is used and try to catch a bug/regression :) Signed-off-by: Owen Leonard I tested many many pages with DataTables, taking special care to find pages with different DataTables configurations. I found no errors in the OPAC or staff client. Tested thoroughly in Firefox (latest) on Windows 7. Tested less thoroughly in Chrome (latest) on Windows 7. Tested briefly in Internet Explorer 7 in Vista and Internet Explorer 8 and found no bugs which were related to the DataTables upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 22:01:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 20:01:33 +0000 Subject: [Koha-bugs] [Bug 12974] Argument "" isn't numeric in numeric gt (>) in opac-results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 22:01:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 20:01:40 +0000 Subject: [Koha-bugs] [Bug 12974] Argument "" isn't numeric in numeric gt (>) in opac-results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32015|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 32021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32021&action=edit Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) Signed-off-by: Magnus Enger Works as advertized. Looks like you have to be logged in to trigger the error. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 22:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 20:43:29 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 --- Comment #3 from Mason James --- > i'll add some more info... this was run on a debian 7.6 box :) $ uname -a Linux xen1 3.2.0-4-amd64 #1 SMP Debian 3.2.60-1+deb7u3 x86_64 GNU/Linux -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 22:48:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 20:48:11 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 --- Comment #4 from Mason James --- (In reply to Mason James from comment #3) > > i'll add some more info... > > this was run on a debian 7.6 box :) > > $ uname -a > Linux xen1 3.2.0-4-amd64 #1 SMP Debian 3.2.60-1+deb7u3 x86_64 GNU/Linux ...and some apache info too # dpkg -l|grep apache ii apache2 2.2.22-13+deb7u3 amd64 Apache HTTP Server metapackage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:05:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:05:15 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 --- Comment #5 from Liz Rea --- Created attachment 32022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32022&action=edit Bug 12856 - koha-disable fails without disabling site To test: Package up a branch with this patch install that package create a site - sudo koha-create --create-db testdisable enable a site - sudo koha-enable testdisable check it's enabled - sudo koha-list --enabled * it should show up disable a site - sudo koha-disable testdisable Do this for both debian squeeze/wheezy and ubuntu 12.04 and 14.04, if you can. I'd like to see a sign off from a debian (sq/wh)eez(e/y) or ubuntu 12 user, because I could only test reliably on ubuntu 14.04. * make sure apache restarts and no errors are produced check it's disabled - sudo koha-list --enabled * it should not show up check the site is still there - sudo koha-list * it should still be there check that the config file has the Include for disabling uncommented * the line Include /etc/koha/apache-shared-disable.conf should not have a # in front. Re-enable the site - sudo koha-enable testdisable * the line Include /etc/koha/apache-shared-disable.conf should have a # in front. And the final question - does the site work? All other functions unchanged? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:05:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:05:53 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:10:14 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32022|0 |1 is obsolete| | --- Comment #6 from Liz Rea --- Created attachment 32023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32023&action=edit Bug 12856 - koha-disable fails without disabling site To test: Package up a branch with this patch install that package create a site - sudo koha-create --create-db testdisable enable a site - sudo koha-enable testdisable check it's enabled - sudo koha-list --enabled * it should show up disable a site - sudo koha-disable testdisable Do this for both debian squeeze/wheezy and ubuntu 12.04 and 14.04, if you can. I'd like to see a sign off from a debian (sq/wh)eez(e/y) or ubuntu 12 user, because I could only test reliably on ubuntu 14.04. * make sure apache restarts and no errors are produced check it's disabled - sudo koha-list --enabled * it should not show up check the site is still there - sudo koha-list * it should still be there check that the config file has the Include for disabling uncommented * the line Include /etc/koha/apache-shared-disable.conf should not have a # in front. Re-enable the site - sudo koha-enable testdisable * the line Include /etc/koha/apache-shared-disable.conf should have a # in front. And the final question - does the site work? All other functions unchanged? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:17:22 +0000 Subject: [Koha-bugs] [Bug 7878] When duplicating a patron too many fields carrying over In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Is there a reason not to use UNLESS instead of "IF do nothing ELSE do something"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:20:58 +0000 Subject: [Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |643 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:20:58 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12914 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:44:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:44:26 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26203|0 |1 is obsolete| | Attachment #26346|0 |1 is obsolete| | Attachment #26352|0 |1 is obsolete| | Attachment #31369|0 |1 is obsolete| | Attachment #31370|0 |1 is obsolete| | Attachment #31373|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 32024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32024&action=edit Bug 11926: Render community koha statistic usages Goals: - Collecting Koha usage statistics - Rendering stats on a community website - Having a big bicture of how koha is used 3 parts in the project: - this patch in koha - hea-ws which collects data - hea-app which renders data Installation: 1/ Fill systempreferences: UsageStatsLastUpdateTime UsageStatsID UsageStatsShare UsageStatsLibraryName 2/ Setup a cron in your crontab (ex: at 3:00 every first of the month): 0 3 1 * * export KOHA_CONF=/home/koha/etc/koha-conf.xml; export PERL5LIB=/home/koha/src; perl /home/koha/src/C4/UsageStats.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:44:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:44:34 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #9 from Jonathan Druart --- Created attachment 32025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32025&action=edit Bug 11926: Package updates * POD doc * hardcoding hea.koha-community.org as the URL where the stats must be sent * fixing some typos * adding all sysprefs we want to upload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:44:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:44:39 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #10 from Jonathan Druart --- Created attachment 32026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32026&action=edit Bug 11926: URI-encode data sent to statistics server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:44:45 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #11 from Jonathan Druart --- Created attachment 32027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32027&action=edit Bug 11926: Add a cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:44:51 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #12 from Jonathan Druart --- Created attachment 32028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32028&action=edit Bug 11926: Add new sysprefs and fix encoding issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:44:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:44:56 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #13 from Jonathan Druart --- Created attachment 32029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32029&action=edit Bug 11926: Add the items table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:45:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:45:01 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #14 from Jonathan Druart --- Created attachment 32030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32030&action=edit Bug 11926: DB changes This patch adds the syspref in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 6 23:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 21:48:00 +0000 Subject: [Koha-bugs] [Bug 11926] Render community koha statistic usages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 --- Comment #15 from Jonathan Druart --- I added the changes to updatedb.pl and syspref.sql into a specific patch to make easier the installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 01:52:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Oct 2014 23:52:16 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 07:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 05:08:08 +0000 Subject: [Koha-bugs] [Bug 13034] New: Print summary does not print items checked out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13034 Bug ID: 13034 Summary: Print summary does not print items checked out Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: eugenegf at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 32031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32031&action=edit Koha 3.12.5 In newer version of Koha ILS 3.16.3, 3.16.4 and when 'Print Summary' button is clicked, the checked out items does not show in the Account Summary. First attachment is Koha 3.12.5. While second attachment is 3.16.4. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 07:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 05:10:53 +0000 Subject: [Koha-bugs] [Bug 13034] Print summary does not print items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13034 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #1 from Eugene Espinoza --- Created attachment 32032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32032&action=edit 3.16.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 14:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 12:08:14 +0000 Subject: [Koha-bugs] [Bug 7878] When duplicating a patron too many fields carrying over In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #4) > Is there a reason not to use UNLESS instead of "IF do nothing ELSE do > something"? Probably not, just following the pattern already established in the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 14:43:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 12:43:12 +0000 Subject: [Koha-bugs] [Bug 13035] New: Overdue notices send notices for due date in future. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035 Bug ID: 13035 Summary: Overdue notices send notices for due date in future. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: rkopaczka at afm.edu.pl Reporter: rkopaczka at afm.edu.pl QA Contact: testopia at bugs.koha-community.org Overdue notices, script uses method days_between which returns always positive value of days, no mater if due_date is higher or lower from date_to_run. This causes overdue notices to be send for real overdue and for checkouts with due date in future, which have same days_between as in notice triggers. To reproduce: 1. Set up overdue notice triggers for eg. 2 day. 2. Checkout items for 2 borrowers first gets item with due date 2 days in past and second gets 2 days in future. 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. watch that notices was generated for both of them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 14:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 12:47:43 +0000 Subject: [Koha-bugs] [Bug 13035] Overdue notices send notices for due date in future. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035 --- Comment #1 from Rafal Kopaczka --- Created attachment 32033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32033&action=edit Bug 13035: Overdue notices send notices for due date in future. Overdue notices, script uses method days_between which returns always positive value of days, no mater if due_date is higher or lower from date_to_run. This causes overdue notices to be send for real overdue and for checkouts with due date in future, which have same days_between as in notice triggers. To reproduce: 1. Set up overdue notice triggers for eg. 2 day. 2. Checkout items for 2 borrowers first gets item with due date 2 days in past and second gets 2 days in future. 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. watch that notices was generated for both of them. To test: 1. Repeat steps 1,2 2. Apply patch 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. should be 1 notice for borrower with overdue item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 14:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 12:48:54 +0000 Subject: [Koha-bugs] [Bug 13035] Overdue notices send notices for due date in future. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:00:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:00:05 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:00:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:00:08 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31706|0 |1 is obsolete| | Attachment #31707|0 |1 is obsolete| | Attachment #31708|0 |1 is obsolete| | Attachment #31709|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 32034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32034&action=edit Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds The current holds behavior in Koha allows a situation like this: - Patron A has an item currently checked out. - Patron B places a hold on the next available copy of that title. - Then Patron A will not be able to renew his item, even if there are other available copies of that title that could potentially fill Patron B's hold. Since this seems unfair to Patron A, we should allow renewal of items even if there are unfilled holds, but those holds could all be filled with currently available items. Test Plan: 1) Apply this patch 2) Create a record with two items 3) Check out the item to a patron 4) Place a hold on the record 5) Note you cannot renew the item for the patron 6) Enable the new system preference AllowRenewalIfOtherItemsAvailable 7) Note you can now renew the item, as all the holds can be satisfied by available items. 8) Place a second hold on the record 9) Note you can no longer renew the item, as all the holds *cannot* be filled by currently available items Signed-off-by: Holger Meissner Signed-off-by: Chris Rohde -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:00:22 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #32 from Kyle M Hall --- Created attachment 32035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32035&action=edit Bug 11634 [QA Followup] - Unit Tests These new unit tests will fail due to the fact that Koha::Database uses a separate dbh handle than C4::Context->dbh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:00:25 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #33 from Kyle M Hall --- Created attachment 32036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32036&action=edit Bug 11634 [QA Followup 2] - Implement check for IsAvailableForItemLevelRequest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:00:27 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #34 from Kyle M Hall --- Created attachment 32037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32037&action=edit Bug 11634 [QA Followup 3] - Found holds should be considered unavailable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:36:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:36:51 +0000 Subject: [Koha-bugs] [Bug 13036] New: Exclude control columns from sorting on catalog detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Bug ID: 13036 Summary: Exclude control columns from sorting on catalog detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org On the catalog detail page the first column (of checkboxes) and the last column ("Edit") are sortable. They should be excluded from sorting because sorting them is useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:37:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:37:03 +0000 Subject: [Koha-bugs] [Bug 13036] Exclude control columns from sorting on catalog detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:39:28 +0000 Subject: [Koha-bugs] [Bug 13036] Exclude control columns from sorting on staff client catalog detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exclude control columns |Exclude control columns |from sorting on catalog |from sorting on staff |detail page |client catalog detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:49:09 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Paola Rossi --- (In reply to Jonathan Druart from comment #7) > Thanks for the screenshot, very useful! > I added a patch on bug 12987, it should fix your issue. Thanks, Jonathan. I've applied the added patch, and now the error of comment 3 is fixed. I've two further questions for you, and for now I pass the patch (this one) to "Failed QA" status (see A) point below). [In case I've passed the erroneous patch, by your kind suggestion I'll soon rectify and make the right changes). In case of no problem, you can easily back 12988 to NSO, please, [and I'll sign off the patch; perhaps all the 12986, 12987, 12988, 12989]. --------------------------------------------------------------------------- On MASTER: on Funds the "Library" filter on the left lists only two values: - none [for ALL the libraries] - the library which has been set as the current one (f.i. Centerville). As you certainly know, the second option doesn't work: all the funds are shown the same (MASTER-ERROR-1), even if none of them is linked to the selected current library. I've selected exactly such a current library, to which none funds have been linked. So all the funds have been shown. Moreover, their values have been formatted so (MASTER-ERROR-2 in showing): 2000 147.6 147.609 Totals are made of zeros here, as we know. We're on master here, so nothing is worth until now. ---------------------------------------------------- After having applied the patches: Now I've applied: 12986, 12987 (3), 12955, 12988, 12984, 12989 (2) The Library's filter on the left of Funds page has listed all the libraries instead of only the current one. A) Is this enhancement in "Library" filter desired on funds' page? Or is it an ERROR-0? Perhaps it is desired. After applying the patches those MASTER-ERROR-1 and MASTER-ERROR-2 have been kept, as you can easily imagine. But moreover now the applied patches have shown the totals on funds' page, and I've seen this kind of ERROR-3 in summing (no matter US or FR): in "Total ordered" column: 5 + 147.6 = 14.81 instead of 152.6 in "Base-level allocated" column: 100000.000000+100000.000000=2,000,000,000.00 instead of 200,000.00 just as no point, and then 2 decimal everywhere. B) Should those summing errors have been prevented by the patches? Are those badly formatted values usual? are they possible, created by filtering or by some other way, and so must the patches take them into accout? --------------------------------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:49:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:49:56 +0000 Subject: [Koha-bugs] [Bug 13036] Exclude control columns from sorting on staff client catalog detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:49:58 +0000 Subject: [Koha-bugs] [Bug 13036] Exclude control columns from sorting on staff client catalog detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13036 --- Comment #1 from Owen Leonard --- Created attachment 32038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32038&action=edit Bug 13036 - Exclude control columns from sorting on staff client catalog detail page The checkbox and "edit" column in the table of holdings on the staff client detail page should be excluded from sorting since there is no useful data to sort. This patch does so. To test, view the detail page for a title which has multiple items. Confirm that sorting works correctly. Test under the following conditions: - with the StaffDetailItemSelection system preference enabled and disabled. - as users who do and do not have cataloging item edit privileges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:58:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:58:54 +0000 Subject: [Koha-bugs] [Bug 13037] New: Staff client cart should exclude articles when sorting by title Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13037 Bug ID: 13037 Summary: Staff client cart should exclude articles when sorting by title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The staff client cart's table sorter is not configured to exclude articles when sorting by title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 15:59:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 13:59:01 +0000 Subject: [Koha-bugs] [Bug 13037] Staff client cart should exclude articles when sorting by title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13037 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 16:10:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 14:10:51 +0000 Subject: [Koha-bugs] [Bug 13037] Staff client cart should exclude articles when sorting by title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13037 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 16:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 14:10:53 +0000 Subject: [Koha-bugs] [Bug 13037] Staff client cart should exclude articles when sorting by title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13037 --- Comment #1 from Owen Leonard --- Created attachment 32039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32039&action=edit Bug 13037 - Staff client cart should exclude articles when sorting by title This patch modifies the configuration of the staff client cart table sorting to enable title sorting to ignore articles. Other column sorting configuration settings are revised to use table header classes instead of indexes. To test, add multiple titles to the staff client cart, choosing several titles which begin with articles ("a," "an," or "the" in English). View the cart and test sorting of all columns. Sorting by title should sort correctly while ignoring articles. Other columns should sort correctly too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 16:42:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 14:42:23 +0000 Subject: [Koha-bugs] [Bug 13038] New: checkboxes disappearing on author searches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13038 Bug ID: 13038 Summary: checkboxes disappearing on author searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32040&action=edit author search from advanced search When doing a search in the staff module, if you click on the author?s name, whether on the results or in a record, you get results on that author, but there are no check boxes! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 16:42:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 14:42:40 +0000 Subject: [Koha-bugs] [Bug 13038] checkboxes disappearing on author searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13038 --- Comment #1 from Nicole C. Engard --- Created attachment 32041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32041&action=edit author search from clicking author's name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 16:43:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 14:43:43 +0000 Subject: [Koha-bugs] [Bug 13038] checkboxes disappearing on author searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13038 --- Comment #2 from Nicole C. Engard --- The checkboxes which don't display have the following html: Whereas the ones that do look like this: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 17:09:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 15:09:28 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32009|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 32042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32042&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 17:11:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 15:11:18 +0000 Subject: [Koha-bugs] [Bug 13038] checkboxes disappearing on author searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13038 --- Comment #3 from Owen Leonard --- I think this is a duplicate of Bug 12071 which is fixed in master. Can you please check the version of the system you're seeing it in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 17:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 15:27:06 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32042|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 32043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32043&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 17:32:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 15:32:00 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 --- Comment #33 from Kyle M Hall --- Created attachment 32044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32044&action=edit [SIGNED OFF] Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:02:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:02:52 +0000 Subject: [Koha-bugs] [Bug 9214] OPAC Status Display hierarchy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Amber Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amber at marlboro.edu --- Comment #1 from Amber Hunt --- I'd love to see some work on this. For any library with damaged reference books or periodical titles that are non-circulating, this causes some serious confusion for patrons. Thanks! Amber Hunt Marlboro College Marlboro, VT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:09:09 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32043|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 32045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32045&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:09:12 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Paola Rossi --- Thanks, Jonathan. I've tested adding orders from existing record and from subscription, and it's OK. But from suggestion it is not OK: the document type of a suggestion has recently become mandatory, and so this is an error. So I pass the patch to "Failed QA" status. [Some problems could be from staged file, too. But perhaps the tool "Stage MARC records for import" might have an error in recognizing the document type of the input record biblio (942$c subfield). The tool should do it (see the "Match type" column in the table at the bottom of "Manage staged MARC records", on tols/manage-marc-import.pl?import_batch_id, after having "uploaded" and "Staged for import". If the tool has this error, no test here for 12933.] Ordering "From an external source" doesn't assign the document type of the source to the order: the user has to use cataloguing to assign the 942$c subfield, so he should exit from ordering' path. So no test here. And ordering "From a new (empty) record" is the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:30:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:30:13 +0000 Subject: [Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:30:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:30:25 +0000 Subject: [Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:31:45 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12801 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:31:45 +0000 Subject: [Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12803 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:32:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:32:26 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #10 from Kyle M Hall --- Created attachment 32046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32046&action=edit Bug 12803 [QA Followup] - Use Koha::Calendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:33:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:33:29 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Kyle M Hall --- Good catch Jonathan! Note this bug now depends on bug 12801 since it makes use of Koha::Calendar which has a caching bug that would cause this feature to work incorrectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:40:45 +0000 Subject: [Koha-bugs] [Bug 13026] permanent location becomes CART. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7817 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 18:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 16:40:45 +0000 Subject: [Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 19:42:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 17:42:49 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 19:43:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 17:43:57 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.8 |master Summary|OPAC Status Display |Show damaged status in the |hierarchy |OPAC for items which are | |not for loan Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 19:47:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 17:47:40 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #6 from Jonathan Druart --- (In reply to Paola Rossi from comment #5) This works only on the neworderempty.pl script. So if you order from a suggestion, suscription, new record, existing record. It looks to work for all of these cases. I tried for a suggestion and if I change the value of the itemtype dropdown-list, the vat value is updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 19:47:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 17:47:54 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:01:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:01:44 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Jonathan Druart --- Last patch is stupid, it does not take into account decimal prices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:02:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:02:24 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 --- Comment #9 from Jonathan Druart --- Arg, yes the last patch on bug 12987 does not fix correctly the problem. I will try to provide a patch soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:37:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:37:17 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:37:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:37:19 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 --- Comment #2 from Owen Leonard --- Created attachment 32047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32047&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:38:00 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 --- Comment #3 from Owen Leonard --- Created attachment 32048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32048&action=edit Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:53:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:53:36 +0000 Subject: [Koha-bugs] [Bug 13039] New: Vendor search: sorting of "item count" and "biblio count" columns can be incorrect Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 Bug ID: 13039 Summary: Vendor search: sorting of "item count" and "biblio count" columns can be incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The vendor search results page shows tables of baskets for each of those vendors. In those tables the "item count" and "biblio count" columns will be sorted incorrectly if some of the cells contain textual data (ex: "(2 cancelled)"). These columns should be configured to have a numeric sort. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 20:53:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 18:53:44 +0000 Subject: [Koha-bugs] [Bug 13039] Vendor search: sorting of "item count" and "biblio count" columns can be incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:04:10 +0000 Subject: [Koha-bugs] [Bug 12378] addbiblio.pl error when deleting record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:30:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:30:13 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by amber at marlboro.edu <1> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:30:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:30:26 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:30:31 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:30:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:30:59 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 32049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32049&action=edit Bug 12937: Deleting suggestions should ask for a confirmation On the suggestion management page, the librarian can choose to delete suggestions but no confirmation is needed. This could produce unexpected lost of data. Test plan: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: amber at marlboro.edu <1> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:31:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:31:02 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 32050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32050&action=edit Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: amber at marlboro.edu <1> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 7 21:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Oct 2014 19:35:20 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Amber Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Amber Hunt --- Well, I tried to be helpful and test the patch, but have apparently done something wrong resulting in the last three posts. Sorry about that. I'll bow out on this one, but THANKS OWEN for starting work on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 03:45:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 01:45:10 +0000 Subject: [Koha-bugs] [Bug 6891] LDIF interoperability - a proposal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6891 --- Comment #25 from Xan Charbonnet --- Hello Koha Community, I'd like to resurrect this discussion, if possible. Since we last spoke, LDIF has gone through a number of revisions (you can see the latest .xsd, including the changelog, here: https://www.biblionix.com/ldif/ldif.xsd (We haven't yet come up with a better name than LDIF, to resolve the conflict with the LDAP standard. Certainly open for ideas on that.) And we now have a script that reads directly from a Koha database and outputs LDIF. That script is available here: https://www.biblionix.com/ldif/koha_to_ldif.pl.txt It would be really exciting if you would consider integrating an LDIF extraction feature into Koha, perhaps based on this script. I don't know whether such a feature would ultimately be better as part of the UI or as a command-line script, but figured that this script would be a good starting point. I'm sure there are many things that Koha experts would do differently, and there's probably a place or two where things are US-centric (processing states in addresses, most prominently), but if you have any interest in adapting this for inclusion in Koha, then we'd be glad to make any changes that would be appropriate, including of course relicensing it under GPL3. Let me know if there's anything I can clarify or do to make this a more worthwhile feature. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 05:27:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 03:27:41 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 05:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 03:27:44 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32023|0 |1 is obsolete| | --- Comment #7 from Mason James --- Created attachment 32051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32051&action=edit Bug 12856 - koha-disable fails without disabling site To test: Package up a branch with this patch install that package create a site - sudo koha-create --create-db testdisable enable a site - sudo koha-enable testdisable check it's enabled - sudo koha-list --enabled * it should show up disable a site - sudo koha-disable testdisable Do this for both debian squeeze/wheezy and ubuntu 12.04 and 14.04, if you can. I'd like to see a sign off from a debian (sq/wh)eez(e/y) or ubuntu 12 user, because I could only test reliably on ubuntu 14.04. * make sure apache restarts and no errors are produced check it's disabled - sudo koha-list --enabled * it should not show up check the site is still there - sudo koha-list * it should still be there check that the config file has the Include for disabling uncommented * the line Include /etc/koha/apache-shared-disable.conf should not have a # in front. Re-enable the site - sudo koha-enable testdisable * the line Include /etc/koha/apache-shared-disable.conf should have a # in front. And the final question - does the site work? All other functions unchanged? Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 05:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 03:34:55 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 05:36:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 03:36:23 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 --- Comment #8 from Mason James --- > Do this for both debian squeeze/wheezy and ubuntu 12.04 and 14.04, if you > can. I'd like to see a sign off from a debian (sq/wh)eez(e/y) or ubuntu 12 > user, because I could only test reliably on ubuntu 14.04. tested ok on debian wheezy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 05:37:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 03:37:42 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 08:12:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 06:12:05 +0000 Subject: [Koha-bugs] [Bug 13040] New: Improve exporter to allow multiple branch selections Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Bug ID: 13040 Summary: Improve exporter to allow multiple branch selections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org At the moment you can only select all branches or one branch for export. This will add the ability to select a set of branches for export. By default all branches will be selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 08:16:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 06:16:59 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 08:17:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 06:17:02 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #1 from Robin Sheat --- Created attachment 32052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32052&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 08:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 06:19:33 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 10:35:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 08:35:34 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:06:46 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:06:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:06:50 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30298|0 |1 is obsolete| | Attachment #30299|0 |1 is obsolete| | Attachment #30300|0 |1 is obsolete| | --- Comment #149 from Kyle M Hall --- Created attachment 32053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32053&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:07:09 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #150 from Kyle M Hall --- Created attachment 32054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32054&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:07:13 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #151 from Kyle M Hall --- Created attachment 32055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32055&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:09:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:09:35 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #152 from Kyle M Hall --- Those are not a problem. Unfortunately there is no IF EXISTS for adding and dropping indexes. You should have had those indexes, but since you didn't, it's not an issue. The situation is similar to if a db update were to attempt to insert a system preference that already exists, or create a table column that already exists. It will fail, but cause absolutely no harm. (In reply to Jonathan Druart from comment #148) > Kyle, > I got these 2 errors on launching the updatedb script: > > DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists > at installer/data/mysql/updatedatabase.pl line 8788. > DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key > exists at installer/data/mysql/updatedatabase.pl line 8794. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:34:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:34:33 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32045|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 32056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32056&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 12:44:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 10:44:33 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 13:40:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 11:40:58 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32044|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 32057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32057&action=edit Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:05:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:05:45 +0000 Subject: [Koha-bugs] [Bug 13039] Vendor search: sorting of "item count" and "biblio count" columns can be incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 --- Comment #1 from Owen Leonard --- Created attachment 32058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32058&action=edit Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:05:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:05:43 +0000 Subject: [Koha-bugs] [Bug 13039] Vendor search: sorting of "item count" and "biblio count" columns can be incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13039 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:08:18 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32056|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 32059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32059&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:20:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:20:25 +0000 Subject: [Koha-bugs] [Bug 11756] Hold ratios report sorting incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11756 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11990 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:20:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:20:25 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report sorts wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11756 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:20:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:20:49 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report sorts wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:23:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:23:03 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds ratio report sorts |Holds ratio report sorts |wrong |numeric values as text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:28:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:28:18 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds ratio report sorts |Holds ratio report |numeric values as text |(circ/reserveratios.pl) | |sorts numeric values as | |text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:29:09 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 32060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32060&action=edit Bug 11990 - Holds ratio report (circ/reserveratios.pl) sorts numeric values as text This patch makes columns Holds, Items and "Hold ratio" to sort numerically instead of lexicographically. Also cleans up an excess aoColumn -definition, because aoColumns == aoColumnDefs without target operator. No point in defining columns twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:31:05 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32060|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 32061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32061&action=edit Bug 11990 - Holds ratio report (circ/reserveratios.pl) sorts numeric values as text This patch makes columns Holds, Items and "Hold ratio" to sort numerically instead of lexicographically. Also changes default sorting column from "Holds" to "Hold ratio" because this is a hold ratios -report, not hold count report. Also cleans up an excess aoColumn -definition, because aoColumns == aoColumnDefs without target operator. No point in defining columns twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:31:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:31:26 +0000 Subject: [Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use of uninitialized value |Remove uninitialized value |in string eq at |warning and add partial |misc/maintenance/cmp_syspre |flag to cmp_sysprefs script |fs.pl line 194 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:31:32 +0000 Subject: [Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:31:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:31:42 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:37:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:37:54 +0000 Subject: [Koha-bugs] [Bug 13041] New: Can't add user as manager of basket if name includes a single quote Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Bug ID: 13041 Summary: Can't add user as manager of basket if name includes a single quote Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If you try to add a user as a manager of a basket and the user's name contains a single quote it will trigger a JavaScript error and the operation will fail without any visible error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:39:28 +0000 Subject: [Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #2 from M. de Rooy --- Created attachment 32062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32062&action=edit Bug 13028: Followup adding a -partial flag for partial compares If you compare the database with a partial pref file, you may not be interested in lots of lines saying that a pref is not in the file. You were already aware of that ;) If you add the -partial flag, these lines will be skipped. Test plan: Do as described above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:40:53 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32047|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:40:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:40:57 +0000 Subject: [Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:40:59 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32048|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:41:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:41:03 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:41:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:41:08 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:44:45 +0000 Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #9 from Nicole C. Engard --- *** Bug 13038 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 14:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 12:44:45 +0000 Subject: [Koha-bugs] [Bug 13038] checkboxes disappearing on author searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13038 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Nicole C. Engard --- You're right it's version 3.14.5. *** This bug has been marked as a duplicate of bug 12071 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 15:01:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 13:01:21 +0000 Subject: [Koha-bugs] [Bug 12757] Integers in saved SQL report ODT export prepended with single quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|single quote in odt export |Integers in saved SQL | |report ODT export prepended | |with single quote --- Comment #1 from Owen Leonard --- I can't reproduce this problem in master. Could you post the SQL which triggers the error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 15:05:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 13:05:30 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26023|0 |1 is obsolete| | --- Comment #15 from Fridolin SOMERS --- Created attachment 32063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32063&action=edit Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'd?j?' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 15:13:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 13:13:18 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #16 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #14) > Fridolin, could you check this is still valid on current master? Still exists withe actual test plan. > Also... patch doesn't apply. Patch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 15:15:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 13:15:06 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #522 from Olli-Antti Kivilahti --- Good work on this one Kyle! I hope we get this to master some day! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 15:57:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 13:57:07 +0000 Subject: [Koha-bugs] [Bug 13042] New: Move budget action links into menu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13042 Bug ID: 13042 Summary: Move budget action links into menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/aqbudgetperiods.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 32064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32064&action=edit Screenshot of the proposed change There are so many links in the "action" column of budgets administration that it might be more usable to move them into a menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:09:41 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32059|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 32065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32065&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:09:52 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32057|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 32066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32066&action=edit Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:10:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:10:36 +0000 Subject: [Koha-bugs] [Bug 12757] Integers in saved SQL report ODT export prepended with single quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12757 --- Comment #2 from Nicole C. Engard --- Here's one: select i.location, s.type, count(s.datetime) as count from statistics s left join items i using (itemnumber) where i.location IN ('BOARDBK','EASYRDR','JAUDIOBK','JBIO','JDVD','JDVDNF','JDVDS7','JDVDSER','JFIC','JGRAPHIC','JLANG','JMUSIC','JMYS','JNF','JOS','JPER','JSPN','JVDV','KIWANIS','PICBOOK','SUMMER') AND s.datetime between <> and <> and s.type in ('issue','renew','return') group by i.location, s.type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:18:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:18:34 +0000 Subject: [Koha-bugs] [Bug 12314] "Pay an amount toward all fines" does not save the note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12314 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |olli-antti.kivilahti at jns.fi Resolution|--- |DUPLICATE --- Comment #2 from Olli-Antti Kivilahti --- *** This bug has been marked as a duplicate of bug 12865 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:18:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:18:34 +0000 Subject: [Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #7 from Olli-Antti Kivilahti --- *** Bug 12314 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:26:11 +0000 Subject: [Koha-bugs] [Bug 13042] Move budget action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13042 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:26:14 +0000 Subject: [Koha-bugs] [Bug 13042] Move budget action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13042 --- Comment #1 from Owen Leonard --- Created attachment 32067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32067&action=edit Bug 13042 - Move budget action links into menu The series of links in the "actions" column of the budgets administration summary table are not very readable as they are, all strung together: Edit Delete Duplicate Close Add fund. This patch moves the links into an "Actions" menu, similar to the change made by Bug 10615 in Reports. To test you should have multiple active and inactive budgets. Apply the patch and go to Administration -> Budgets. Confirm that each menu item links to the correct action. Test the menu for both active and inactive budgets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 16:44:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 14:44:20 +0000 Subject: [Koha-bugs] [Bug 12757] Integers in saved SQL report ODT export prepended with single quote In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12757 --- Comment #3 from Owen Leonard --- Okay you're right and I can reproduce it with my reports as well. I just didn't realize that the single quote wasn't visible in the spreadsheet until you click in a cell to edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 18:42:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 16:42:32 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32065|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 32068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32068&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 18:42:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 16:42:54 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32066|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 32069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32069&action=edit Bug 12892 - Holds Waiting: not showing from check out screen When a patron has holds waiting to be pick up, they used to show in the check out screen. These notifications are no longer showing in 3.16. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch you logged in branch to a different branch 6) Note the "Waiting at" line is no longer emphasized. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 18:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 16:43:15 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32012|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 32070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32070&action=edit Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 19:00:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 17:00:58 +0000 Subject: [Koha-bugs] [Bug 13043] New: Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Bug ID: 13043 Summary: Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The staff client search history page template links to jquery.dataTables.columnFilter.js, but the link is incorrect. The plugin is not used, so the link can be removed altogether. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 19:14:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 17:14:02 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 19:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 17:51:06 +0000 Subject: [Koha-bugs] [Bug 13043] Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 19:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 17:51:08 +0000 Subject: [Koha-bugs] [Bug 13043] Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 --- Comment #1 from Owen Leonard --- Created attachment 32071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32071&action=edit Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page The staff client search history page does not required the DataTables columnFilter plugin, so the link (which pointed to the wrong location anyway) can be removed. To test, apply the patch and view your search history in the staff client. Table sorter functions (sorting, paging, and searching) should work correctly for current and previous sessions of catalog and authority searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:24:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:24:05 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:35:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:35:16 +0000 Subject: [Koha-bugs] [Bug 7712] a single holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7712 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:35:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:35:40 +0000 Subject: [Koha-bugs] [Bug 7711] clear holds statuses and workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|koha.sekjal at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:37:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:37:23 +0000 Subject: [Koha-bugs] [Bug 7712] a single holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7712 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:41:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:41:57 +0000 Subject: [Koha-bugs] [Bug 13044] New: Deprecate old dropbox mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Bug ID: 13044 Summary: Deprecate old dropbox mode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We now have two ways to backdate returns, the older "Book drop" mode, and the newer arbitrary backdating of returns feature. We should deprecate the older mode by having the "Book drop" checkbox insert the date the library was last open into the date field. We would also need to remove the system preference to have the returns backdating feature always on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:42:04 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 20:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 18:47:28 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deprecate old dropbox mode |Deprecate old book drop | |mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 21:34:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 19:34:17 +0000 Subject: [Koha-bugs] [Bug 13045] New: not for loan items show hold option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13045 Bug ID: 13045 Summary: not for loan items show hold option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32072&action=edit no hold link See attached. An item that is marked as not for loan is showing the hold link on the search results, but not on the detail page. The detail page is right, the results page is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 21:34:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 19:34:36 +0000 Subject: [Koha-bugs] [Bug 13045] not for loan items show hold option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13045 --- Comment #1 from Nicole C. Engard --- Created attachment 32073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32073&action=edit hold link showing on the results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 21:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 19:39:48 +0000 Subject: [Koha-bugs] [Bug 13046] New: self-registration error with same firstname and lastname! Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13046 Bug ID: 13046 Summary: self-registration error with same firstname and lastname! Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nguyenquocuy_1102 at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When 2 people self register account on Koha, if they have same firstname and lastname, then they will have same username with different password. Then the second username can not login. I think we should change the second username to something like firstname.lastname2 if there is an exist username like firstname.lastname. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:44:32 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:48:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:48:31 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Jonathan Druart --- To test this patch (actually bug 12988 and bug 12989), you need to apply bug 12844 (and bug 12979). I forgot this dependency, that's why it does not work. Bug 12844 removes the currency symbol on the aqbudgets page. The problem arises if the currency symbol is displayed. It could (and will) be fixed later. I cannot fix everything without to be sure these patches will be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:49:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:49:12 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:49:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:49:12 +0000 Subject: [Koha-bugs] [Bug 12844] Introduce a centralized way to display prices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:49:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:49:48 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart --- Solution proposed on bug 12987, I added a dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:49:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:49:49 +0000 Subject: [Koha-bugs] [Bug 13047] New: SQL Last Run Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13047 Bug ID: 13047 Summary: SQL Last Run Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be helpful if we could see the last run dates on the saved sql reports so we can easily see what isn't being used. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:52:33 +0000 Subject: [Koha-bugs] [Bug 13047] SQL Last Run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13047 --- Comment #1 from Christopher Brannon --- Actually, it would be nice if that field worked at all. It appears that the timestamp is not working. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:53:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:53:25 +0000 Subject: [Koha-bugs] [Bug 12844] Introduce a centralized way to display prices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 --- Comment #27 from Jonathan Druart --- Note for QA: Please don't consider that removing the currency symbol on the aqbudgets page if CurrencyFormat == 'FR' could be blocker. All patches above this patch won't apply and will break the display if added. I will fix this minor issue and homogenize prices formatting later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 22:57:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 20:57:41 +0000 Subject: [Koha-bugs] [Bug 13047] SQL Last Run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think the field might be related to the use of the scheduler feature - not sure about running the report in the web interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 8 23:05:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 21:05:20 +0000 Subject: [Koha-bugs] [Bug 13047] SQL Last Run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13047 --- Comment #3 from Christopher Brannon --- Well, that's a bummer. So, I guess the enhancement that is needed is a last used field that is timestamped when a report is used. :) Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 01:30:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Oct 2014 23:30:49 +0000 Subject: [Koha-bugs] [Bug 13048] New: Serial Error when NULL date encountered Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13048 Bug ID: 13048 Summary: Serial Error when NULL date encountered Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com We have a number of libraries experiencing the following error: Date::Calc::Add_Delta_YM(): not a valid date at /home/koha/kohaclone/C4/Serials.pm line 2626, line 522. When we investigate it appears that there is no serial.planneddate value. It is either NULL or there is no entry in the serial table for the subscriptionid. It appears that Koha is not handling 'bad data' well in the serials module in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 08:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 06:25:04 +0000 Subject: [Koha-bugs] [Bug 13046] self-registration error with same firstname and lastname! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13046 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 09:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 07:36:42 +0000 Subject: [Koha-bugs] [Bug 13049] New: Improve self-registration cronjobs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Bug ID: 13049 Summary: Improve self-registration cronjobs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org There are two small cronjobs for self-registration: delete_expired_opac_registrations.pl and delete_unverified_opac_registrations.pl The expired job is meant to delete from borrowers when the patron category is equal to PatronSelfRegistrationDefaultCategory and date enrolled past PatronSelfRegistrationExpireTemporaryAccountsDelay. (See also bug 11945.) It seems to me that this behavior is unexpected since the pref descriptions do not suggest that the default category is temporary. Perhaps, it was meant to add some verification step into the process when you do not use the email verification triggered by pref PatronSelfRegistrationVerifyByEmail. The unverified job is meant to delete from borrower_modifications and uses a time parameter (defaulting to 24 hours) to find unverified entries. It seems to me that it should use the PatronSelfRegistrationExpireTemporaryAccountsDelay preference. (Read its description.) I propose the following changes: [1] Move these actions to cleanupdatabase. Do they really need two separate scripts? [2] Rename the Delay preference. Name and description conflict now. We could make name and description cover both cases: (a) verify is on and still unverified and (b) verify is off and still in the initial category. [3] Trigger the borrowers/category delete only if Verify is off and the renamed delay has been past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 10:16:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 08:16:37 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30926|0 |1 is obsolete| | --- Comment #41 from Julian Maurice --- Created attachment 32074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32074&action=edit Bug 7290: More granular permissions for order receiving Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 10:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 08:16:52 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30927|0 |1 is obsolete| | --- Comment #42 from Julian Maurice --- Created attachment 32075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32075&action=edit Bug 7290: QA fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 10:17:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 08:17:03 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30928|0 |1 is obsolete| | --- Comment #43 from Julian Maurice --- Created attachment 32076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32076&action=edit Bug 7290: Fix CanUserReceiveBasket tests Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 10:17:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 08:17:10 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #44 from Julian Maurice --- Created attachment 32077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32077&action=edit Bug 7290: Add new permission to users that have 'order_receive' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 10:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 08:17:22 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 10:19:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 08:19:44 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #45 from Julian Maurice --- (In reply to Katrin Fischer from comment #40) > 2) Wondeirng, should I still be able to delete or move an order, that I am > not allowed to receive? I guess it's intentional, but it feels a bit like > taking away the nice one and leaving the dangerous actions :) Yes, you should still be able to delete or move an order you can't receive, but that's not a different behaviour than without the patch, right ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:38:46 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #46 from Julian Maurice --- Patron should also not have the permission order_manage_all and should not be in the basket's users list. Maybe we should not check for order_manage_all here. What do you think ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:41:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:41:20 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 --- Comment #1 from M. de Rooy --- Created attachment 32078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32078&action=edit Bug 11945: SQL syntax error in delete_expired_opac_registrations.pl This patch corrects a syntax error, adds some comments to the usage instructions and adds a count of the removed borrowers (with verbose flag on). Note that this is a dangerous script. It will delete your patrons in patron category PatronSelfRegistrationDefaultCategory. If you do not use this as a temporary category, you should NOT run this script. Test plan: Check PatronSelfRegistrationDefaultCategory. Check PatronSelfRegistrationExpireTemporaryAccountsDelay. Based on these two settings, check the number of patrons to be deleted (date enrolled should be before NOW minus the delay). Backup your data and run the script. Check the number of deleted borrowers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:42:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:42:01 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch Version|3.14 |master Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:42:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:42:22 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:42:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:42:35 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:44:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:44:10 +0000 Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11945 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:44:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:44:10 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13049 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:49:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:49:06 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 --- Comment #12 from Julian Maurice --- Created attachment 32079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32079&action=edit Bug 11847: Add span with class around order date so libraries can hide it if they want -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 11:55:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 09:55:00 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Julian Maurice --- (In reply to Katrin Fischer from comment #10) > I am sorry, bit this seems to explode in a perl error if you choose to not > attach your closed basket to a basket group (not checking the checkbox when > closing the basket): > > basketgroup id is required to edit a basketgroup at > /home/katrin/kohaclone/C4/Acquisition.pm line 1001. I am not able to reproduce this. Could you test it again on recent master ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:04:03 +0000 Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- I have no objections to moving these behaviors to cleanupdatabase. My only concern would be to make sure upgraders have clear notification that the old cron scripts have gone away and the functionality has been moved. delete_expired_opac_registrations.pl is indeed meant to delete patron accounts that are still set to the default category after a set time. I agree there is some confusion here. There are two use cases: 1) This PatronSelfRegistrationDefaultCategory is a provisional category which is meant to allow a patron to immediately access online resources but not to check out items. In the scenario, the patron is supposed to come into the library within a given amount of time to verify his or her identity, and have a librarian change the patron category to a permanent category. That way the patron is now a full-fledged member who can check out items. This is the scenario where delete_expired_opac_registrations.pl is meant to be used. 2) The PatronSelfRegistrationDefaultCategory *is* full fledged membership category. In this scenario no verification is required by the library and delete_expired_opac_registrations.pl should *not* be used, ever. delete_unverified_opac_registrations.pl is more of a garbage cleanup. If PatronSelfRegistrationVerifyByEmail is enabled, patrons try to create an account, but never confirm the account creation via the emailed link. We don't want these to just pile up, so this script removes them. Note this is only for new patron account submissions, and not for patron modification requests to existing accounts ( hence where borrowernumber = 0 ). > I propose the following changes: > [1] Move these actions to cleanupdatabase. Do they really need two separate > scripts? I think delete_unverified_opac_registrations.pl is a prime candidate for folding into cleanupdatabase. I suppose delete_expired_opac_registrations.pl could be moved into it as well. I would not object to that, but it's not quite the same as removing crufty old data. This script deletes what may be active patron accounts. It isn't really cleanup. I do like the idea of one unified script though. > [2] Rename the Delay preference. Name and description conflict now. We could > make name and description cover both cases: (a) verify is on and still > unverified and (b) verify is off and still in the initial category. I'm questioning whether we should have the preference at all. Is PatronSelfRegistrationExpireTemporaryAccountsDelay something we really need libraries to be able to change without the help of an administrator? Maybe this should be a days parameter like it is for delete_unverified_opac_registrations.pl? > [3] Trigger the borrowers/category delete only if Verify is off and the > renamed delay has been past. This part I'm not understanding. When you say Verify do you mean PatronSelfRegistrationVerifyByEmail, or being verified by having the patron category changed? I don't think we should automate the triggering of these deletions. This behavior may be very custom depending on the needs of the librarians. So in summary, my suggested course of action would be to: 1) Fold both scripts into cleanupdatabase with separate switches and time parameters for each ( maybe --delete-expired-self-registration= and --delete-unverified-self-registrations= so we don't need two parameters for each. 2) Remove PatronSelfRegistrationExpireTemporaryAccountsDelay completely 3) Update PatronSelfRegistrationDefaultCategory to indicate that if they use --delete-expired-self-registration= that this category should *only* be for provisional self-registered patrons What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:19:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:19:59 +0000 Subject: [Koha-bugs] [Bug 13050] New: Follow-up for bug 12371 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Bug ID: 13050 Summary: Follow-up for bug 12371 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:20:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:20:12 +0000 Subject: [Koha-bugs] [Bug 13050] Follow-up for bug 12371 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:23:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:23:24 +0000 Subject: [Koha-bugs] [Bug 13050] Follow-up for bug 12371 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:23:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:23:26 +0000 Subject: [Koha-bugs] [Bug 13050] Follow-up for bug 12371 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 --- Comment #1 from M. de Rooy --- Created attachment 32080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32080&action=edit Bug 13050: Follow-up for bug 12371 This patch simplifies the SQL query in Letters.pm for table borrower_modifications. It also addresses the only case this query is used in opac-memberentry. An unused variable in Letters.pm is removed. Test plan: Enable selfregistration on opac. Set verification by email to required in prefs too. Self-register two new users. Check the email notices generated. Verify the new users with the tokens in their notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:23:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:23:47 +0000 Subject: [Koha-bugs] [Bug 13050] Follow-up for bug 12371 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:27:51 +0000 Subject: [Koha-bugs] [Bug 13050] Follow-up for bug 12371 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12371 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:27:51 +0000 Subject: [Koha-bugs] [Bug 12371] Links in every patron self-registration email points to a single borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13050 --- Comment #12 from M. de Rooy --- I agree with Chris and Nick that this query is not very clear and easy to maintain. Actually we do only need the unique token here (at this time we are creating a new self-registered borrower without number). Sending a follow-up on report 13050. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 13:48:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 11:48:09 +0000 Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #2 from M. de Rooy --- (In reply to Kyle M Hall from comment #1) > What do you think? Thanks. This is quite clear. I will send a proposed patch. Still thinking a little bit on the provisional category-case.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:02:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:02:22 +0000 Subject: [Koha-bugs] [Bug 12971] Printing member information lacks data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #1 from Rafal Kopaczka --- *** Bug 13034 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:02:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:02:22 +0000 Subject: [Koha-bugs] [Bug 13034] Print summary does not print items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13034 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |rkopaczka at afm.edu.pl Resolution|--- |DUPLICATE --- Comment #2 from Rafal Kopaczka --- Seems like duplicate of Bug 12971. *** This bug has been marked as a duplicate of bug 12971 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:09:24 +0000 Subject: [Koha-bugs] [Bug 13046] self-registration error with same firstname and lastname! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13046 --- Comment #1 from M. de Rooy --- (In reply to Nguyen Quoc Uy from comment #0) > When 2 people self register account on Koha, if they have same firstname and > lastname, then they will have same username with different password. Then > the second username can not login. > I think we should change the second username to something like > firstname.lastname2 if there is an exist username like firstname.lastname. Hi, Do not know what your firstname and lastname is btw :) The code in Members.pm contains two routines for generating the userid. Generate_Userid generates the suggested userid and Check_Userid does actually check if that userid is not in the database. I tried to reproduce your problem, but in my case with the same firstname and lastname a userid was generated that was followed by a digit 1. So: firstname.lastname1 I am curious if your problem somehow has to do with special characters or so. Could you give me the exact firstname and lastname to reproduce this error please? Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:32:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:32:41 +0000 Subject: [Koha-bugs] [Bug 13051] New: And remember, usernames are not case sensitive Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 Bug ID: 13051 Summary: And remember, usernames are not case sensitive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org opac-auth contains the following statement: You entered an incorrect username or password. Please try again! And remember, usernames and passwords are case sensitive. Obviously, this is not completely true. The username can be entered in lowercase, uppercase, any mixed case Trivial string patch forthcoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:37:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:37:16 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:37:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:37:21 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 --- Comment #1 from M. de Rooy --- Created attachment 32081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32081&action=edit Bug 13051: And remember, usernames are not case sensitive opac-auth contains the following statement: You entered an incorrect username or password. Please try again! And remember, usernames and passwords are case sensitive. Obviously, this is not completely true. The username can be entered in lowercase, uppercase, any mixed case. This patch simply adjusts this string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:38:07 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:50:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:50:26 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 14:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 12:50:29 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32081|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 32082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32082&action=edit [SIGNED-OFF] Bug 13051: And remember, usernames are not case sensitive opac-auth contains the following statement: You entered an incorrect username or password. Please try again! And remember, usernames and passwords are case sensitive. Obviously, this is not completely true. The username can be entered in lowercase, uppercase, any mixed case. This patch simply adjusts this string. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:10:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:10:00 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29336|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Comment on attachment 29336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29336 Bug 8133 - New fix: hourly loans doesn't know when library closed Obsoleting for now. Jesse has posted an updated patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:11:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:11:33 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:11:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:11:54 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 --- Comment #13 from Jonathan Druart --- Created attachment 32083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32083&action=edit Bug 7372: (follow-up) remove debug message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:12:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:12:42 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 --- Comment #14 from Jonathan Druart --- Tomas, Paul have found a debug message (in French...) in the last patch. Could you push it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:15:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:15:18 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:15:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:15:38 +0000 Subject: [Koha-bugs] [Bug 13051] And remember, usernames are not case sensitive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32082|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 32084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32084&action=edit Bug 13051: And remember, usernames are not case sensitive opac-auth contains the following statement: You entered an incorrect username or password. Please try again! And remember, usernames and passwords are case sensitive. Obviously, this is not completely true. The username can be entered in lowercase, uppercase, any mixed case. This patch simply adjusts this string. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:24:36 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #51 from Jared Camins-Esakov --- (In reply to M. de Rooy from comment #50) > When I am testing dedup-records.pl with Match/100abc on PERSO_NAME, the > script finds two duplicates Surname, C.-J. and Surname, C-J. > It does not find: Surname, Fred and Surname, F. (Note: Could be a match, but > maybe not.) > > Without diving deep into C4/Matcher.pm myself, could you give some hints how > to get the script to report such ones? You would need to write your own matcher that identified Surname, Fred and Surname, F. as duplicates. If you have a 4xx field for Surname, F. in the new record you could use Previous-heading-see-from/100abcd. > On the two patch sets in this report: I would suggest to move the two > patches of Julian to another report. This is confusing. Also note that I > would not recommend to refactor rebuild_zebra on a report about authorities; > you'd better split them up. I agree. The two deduplicators are not mutually exclusive in my opinion, so perhaps it would make sense for me to create a separate bug for Julian's patches with a subject something like "Authority deduplicator for UNIMARC"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:40:22 +0000 Subject: [Koha-bugs] [Bug 13052] New: OPAC Cart JavaScript is included twice in the footer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Bug ID: 13052 Summary: OPAC Cart JavaScript is included twice in the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The template logic for including the Cart's JavaScript file is doubled up in the OPAC footer include. One instance should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:45:40 +0000 Subject: [Koha-bugs] [Bug 13052] OPAC Cart JavaScript is included twice in the footer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:45:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:45:44 +0000 Subject: [Koha-bugs] [Bug 13052] OPAC Cart JavaScript is included twice in the footer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 --- Comment #1 from Owen Leonard --- Created attachment 32085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32085&action=edit Bug 13052 - OPAC Cart JavaScript is included twice in the footer The external JavaScript file which powers the OPAC Cart should not be included twice. The correct instance is the one which comes after the definition of MSG strings. To test you must have the opacbookbag system preference turned on. In Bootstrap OPAC, test adding some items to the Cart and confirm that Cart operations work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:48:42 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #23 from Jonathan Druart --- Created attachment 32086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32086&action=edit Bug 9967 - Cache authorised value requests properly Authorised values are now cached using the proper Koha::Cache mechanism, rather than a simple internal cache. Memoize has been removed because it didn't really work like we needed it to. Test plan: * running a persistent environment: * load the edit item screen * refresh several times to ensure any process-based caches are filled * add a new LOC authorised value as fast as possible (prepare it on another tab.) * refresh the edit item page * note that the new LOC value may or may not be showing in the "shelving location" * if more than 5 seconds have passed since saving it, it must now show up. * refresh a few times to ensure that it's showing on all processes. Note: * This patch depends on the caching changes of 9967. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:48:49 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28625|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 32087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32087&action=edit Bug 9967 - include $branch_limit in the cache key Make the caching more correct. Also removes a warn that got left behind. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:49:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:49:52 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Jonathan Druart --- Brendan signed the patches off. I confirm the bug and that the patches fix it. No regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:50:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:50:09 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 15:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 13:50:21 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:09:46 +0000 Subject: [Koha-bugs] [Bug 13053] New: Do not use template cache when from commandline Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 Bug ID: 13053 Summary: Do not use template cache when from commandline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org You may define in config a folder (usually /tmp) for TT cache : template_cache_dir in etc/koha-conf.xml. Some perl pages may be launched from commandline, like tools/export.pl. Also, the script gather_print_notices.pl uses C4::Templates. The problem is that when script is launched from Apache, the Unix owner of cache files will be www-data. When script is launched from commandline, like in a cronjob, the Unix owner will be different (like a user named "koha"), causing a crash because cache files can only be read by its owner. I propose not to use the template cache if perl script is called from commandline. This cache is certainly only useful for web access. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:09:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:09:54 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:27:18 +0000 Subject: [Koha-bugs] [Bug 13054] New: Allow server-side sorting by title to ignore custom sets of articles to ignore Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 Bug ID: 13054 Summary: Allow server-side sorting by title to ignore custom sets of articles to ignore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When sorting clent-side DataTables-enhanced tables by title, it's possible to use a custom sorting algorithm to ignore articles, based on this configuration in datatables-strings.inc: var CONFIG_EXCLUDE_ARTICLES_FROM_SORT = _("a an the"); ...and the "anti-the" sorting code in js/datatables.js. This doesn't work with server-side DataTables implementations, which means that sorting by title on the circulation and patron detail pages no longer works as well as it did before those pages were redone with AJAX datatables. I would like to see some kind of implementation which continued to enable the user to define articles to exclude from sorting and would work at the database level so that AJAX datatables could be correctly sorted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:28:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:28:15 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow server-side sorting |Allow server-side sorting |by title to ignore custom |by title to ignore custom |sets of articles to ignore |sets of articles -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:29:14 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Applying: Bug 8133 - hourly loans doesn't know when library closed fatal: sha1 information is lacking or useless (C4/Calendar.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8133 - hourly loans doesn't know when library closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:36:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:36:32 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- I can do a patch for this, which makes us use a new zebra connection each time. Or I can do a patch which would build a dependency on yaz-proxy so that we use that instead. The first is obviously a lot faster, and is what zebra is designed for, it is not built for persistent connections, the second would allow us to pool connections, but would add a new software dependency Opinions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:40:55 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:40:59 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32079|0 |1 is obsolete| | --- Comment #14 from Chris Cormack --- Created attachment 32088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32088&action=edit Bug 11847: Add span with class around order date so libraries can hide it if they want Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:47:23 +0000 Subject: [Koha-bugs] [Bug 13055] New: Show budget name when editing it Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055 Bug ID: 13055 Summary: Show budget name when editing it Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&bud get_period_id=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When you are editing a budget the page heading should show the name of that budget. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:54:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:54:42 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 --- Comment #1 from Fridolin SOMERS --- Created attachment 32089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32089&action=edit Bug 13053 - Do not use template cache when from commandline You may define in config a folder (usually /tmp) for TT cache : template_cache_dir in etc/koha-conf.xml. Some perl pages may be launched from commandline, like tools/export.pl. Also, the script gather_print_notices.pl uses C4::Templates. The problem is that when script is launched from Apache, the Unix owner of cache files will be www-data. When script is launched from commandline, like in a cronjob, the Unix owner will be different (like a user named "koha"), causing a crash because cache files can only be read by its owner. This script disables the template cache if perl script is called from commandline. This cache is certainly only useful for web access. Using GATEWAY_INTERFACE env var comes from tools/export.pl Test plan : - Use a dev install of koha installed in a user home, ie "/home/kohadev" - Define a folder for template_cache_dir in etc/koha-conf.xml. For example : /tmp - Check there is no cached templates already in this forder - Create a file "bib.list" containing a few existing biblionumbers - As user kohadev, launch : tools/export.pl --record-type=bibs --id_list_file=bib.list - Look at cache folder => Without patch you see cache files owned by user kohadev => With patch there are no cache files - Use the Koha interfaces OPAC and Intranet => Without patch you get an error : Template process failed: file error - cache failed to write ... => With patch you have no error and cache files are generated with Apache user as owner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:55:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:55:45 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:55:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:55:58 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:59:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:59:10 +0000 Subject: [Koha-bugs] [Bug 13055] Show budget name when editing it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055 --- Comment #1 from Owen Leonard --- Created attachment 32090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32090&action=edit Bug 13055 - Show budget name when editing it This patch adds the budget name to the page heading when editing a budget. The patch also similarly corrects the page title during edit operations and fixes some inconsistency in the breadcrumbs. To test, edit an existing budget (Adminitration -> Budgets) and confirm that page title, breadcrumbs, and heading look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 16:59:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 14:59:07 +0000 Subject: [Koha-bugs] [Bug 13055] Show budget name when editing it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:05:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:05:01 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:05:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:05:14 +0000 Subject: [Koha-bugs] [Bug 11945] Cronjob delete_expired_opac_registrations.pl fails with error in SQL syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32078|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 32091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32091&action=edit Bug 11945: SQL syntax error in delete_expired_opac_registrations.pl This patch corrects a syntax error, adds some comments to the usage instructions and adds a count of the removed borrowers (with verbose flag on). Note that this is a dangerous script. It will delete your patrons in patron category PatronSelfRegistrationDefaultCategory. If you do not use this as a temporary category, you should NOT run this script. Test plan: Check PatronSelfRegistrationDefaultCategory. Check PatronSelfRegistrationExpireTemporaryAccountsDelay. Based on these two settings, check the number of patrons to be deleted (date enrolled should be before NOW minus the delay). Backup your data and run the script. Check the number of deleted borrowers. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:13:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:13:17 +0000 Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages when running under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #3 from Brendan Gallagher --- Hmm... I was not able to repeat this. I've got starman and memcached running. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:19:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:19:24 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Chris Cormack from comment #4) > I can do a patch for this, which makes us use a new zebra connection each > time. > Or I can do a patch which would build a dependency on yaz-proxy so that we > use that instead. > > The first is obviously a lot faster, and is what zebra is designed for, it > is not built for persistent connections, the second would allow us to pool > connections, but would add a new software dependency > > Opinions? I'd go for the approach that creates a new connection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:20:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:20:24 +0000 Subject: [Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:20:28 +0000 Subject: [Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126 --- Comment #1 from Jonathan Druart --- Created attachment 32092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32092&action=edit Bug 10126: Remove my variables at module level In C4::Reports::Guided, a lot of variables was defined at module level and reused in subroutine. I didn't find any problem with Plack, so I'm not sure this patch is useful. Test plan: Verify there is no more ^my in the module and you don't find any regression with the guided reports tools (with and without Plack) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:20:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:20:59 +0000 Subject: [Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- This patch is quite ugly, feel free to provide your own version ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:23:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:23:35 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 --- Comment #1 from Martin Renvoize --- Created attachment 32093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32093&action=edit Bug 13054: Added sort 'anti-the' to title -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:24:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:24:43 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- A tad confused... I just added the 'anti-the' to checkouts.js and found it appeared to be working for me.. See patch for the super tiny change.. Maybe i'm not looking in the right place though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:29:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:29:36 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- In the future we might need to extend the IF to handle other ones, but for now that is no reason not to sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:30:27 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31854|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 32094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32094&action=edit Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:30:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:30:45 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:30:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:30:49 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31976|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 32095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32095&action=edit Bug 12987: The new format_price include file should be include on using datatables Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:39:59 +0000 Subject: [Koha-bugs] [Bug 13056] New: ISSUEQSLIP & ISSUESLIP don't print data of items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13056 Bug ID: 13056 Summary: ISSUEQSLIP & ISSUESLIP don't print data of items Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hectorejch at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When I want to print the list of "check-outs" does not generate information from books or items. The information of the borrowers and branches is generated correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:44:06 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 32096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32096&action=edit Bug 11677 - (KD-157) Limit to Only items currently available for loan or reference not working! This row: $availability_limit .= "( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and (lost,st-numeric=0) )"; #or ( allrecords,AlwaysMatches='' not lost,AlwaysMatches='')) )"; Causes all records in Zebra to be selected and removes records with even one item onloan (even if items would be available)! This is obviously wrong, but because Zebra (and not many other text indexers) cannot deal with (If undef)-search terms, a fix might be to set 952$q (onloan) datetime to 0000-00-00 instead of NULL in the DB. Then we could find Records with items where onloan is 0000-00-00. Comments out that Zebra availability search and deals with availability on Koha-side. Gets the branch or holdingbranch limit from opac-search.pl or search.pl and uses that to skip Zebra results which are onloan or notforloan. Updates the result set size when results are removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:46:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:46:30 +0000 Subject: [Koha-bugs] [Bug 13057] New: Empty library dropdown in funds header search on some budgets and funds pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13057 Bug ID: 13057 Summary: Empty library dropdown in funds header search on some budgets and funds pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The funds header search include is used by the Budgets, Funds, and Planning (admin/aqplan.pl) pages. It has an option for limiting by library, but the library data it requires seems to only be provided by the Funds (aqbudgets.pl) summary page. In addition, if the dropdown is populated by any library data it appears to only show the branch the current user is logged in as, even if you submit a search with "show my funds only" unchecked. I don't see how that limitation is useful. Should the full list of libraries be shown at all times, or perhaps just libraries for which funds are defined? If the latter, should this data be added to all pages which include this filter? Or should the library selection dropdown be hidden when there is no library data to populate it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:47:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:47:48 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:47:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:47:54 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31385|0 |1 is obsolete| | Attachment #31386|0 |1 is obsolete| | Attachment #31387|0 |1 is obsolete| | --- Comment #57 from Paul Poulain --- Created attachment 32097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32097&action=edit Bug 9352 : More specific indexing of UNIMARC 7XX fields (GRS1) 1st patch : for GRS1 indexing Problem : Zebra indexes all subfields of UNIMARC 7XX fields in author index, including $9, $3, $4 (function code), $f (dates of authors), $c (additions other than dates), $p (address). It causes Koha to give too much results. For example, if an author is born in 1984 and is a teacher, searching "1984" or "teacher" in simple search will return all work by this author if these pieces of informations are in 7XX field. This is not how most ILS work, and it should be corrected. Solution : This patch makes indexing of unimarc 7XX fields more specific. For each field, useless subfields are not indexed. 70X : Do not index $f (dates),$c (additions other than dates),$p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. 710-712 : Do not index $p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. (I kept all other subfields : even if some may be useless I am not sure of it) 716 : Do not index $f (dates),$c (additions other than dates),$3,$4. Index $9 only in Koha-Auth-Number. 72X : Do not index $f (dates),$3,$4. Index $9 only in Koha-Auth-Number. 730 : Do not index $4. Index $9 only in Koha-Auth-Number. Additionnaly, this patch indexes 205$f/$g in Author index (author of the edition of the work) Testing : a/ Create a record with : 700$a Doe $b John $f1950 $cteacher $4070 710$a Corporate $b Meeting $p Address 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys b/ Before applying patch, make several searches : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results with simple search (because 205 is indexed in title) => you will not see the record among the results with author search c/ Apply patch d/ Rebuild Zebra with ./misc/migration_tools/rebuild_zebra.pl -b -x -v -reset e/ Try the same searches as before : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will not see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results in both simple search and author search Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described with GRS1. No koha-qa errors. Signed-off-by: Martin Renvoize Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:49:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:49:14 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #58 from Paul Poulain --- Created attachment 32098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32098&action=edit Bug 9352 : More specific indexing of UNIMARC 7XX fields and 511 (DOM) 2d patch, for DOM indexing Rebased on 20 Aug 2014, Fixed on 25 Aug 2014 (716 field and 205$g) Same changes as in GRS-1 patch, with 2 small additions : - I take the occasion for indexing the 511 field (I don't know why it was omitted) - index 710$a and 720$a in Author:s as well as 700$a (seems logical) (biblio-zebra-indexdefs.xsl is made from biblio-koha-indexdefs.xml with xsltproc) Same test as first patch : Testing : a/ Create a record with some values. for example: 700$a Doe $b John $f1950 $cteacher $4070 710$a Corporate $b Meeting $q Address 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys 511$a falsetitle b/ Before applying patch, make several searches : Search in simple search and author search : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will see the record among the results Search in simple search and author search : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in simple search and author search : "guy", "guys" => you will see the record among the results with simple search (because 205 is indexed in title) => you will not see the record among the results with author search Search ti:falsetitle => no results c/ Apply the patch d/ copy the 2 modified files into your zebra configuration directory e/ Rebuild Zebra with ./misc/migration_tools/rebuild_zebra.pl -b -x -v -reset f/ Try the same searches as before : Search in simple search and author search : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will not see the record among the results Search in simple search and author search : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in simple search and author search : "guy", "guys" => you will see the record among the results in both simple search and author search Search ti:falsetitle => 1 result Signed-off-by: Martin Renvoize Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:49:44 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #59 from Paul Poulain --- Created attachment 32099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32099&action=edit Bug 9352: Add a new XSLT template for indexing goup of subfields as a whole This patch adds a new template in koha-indexdefs-to-zebra.xsl in order to index a specific goup of subfields as a whole. It can be used for indexing as a "phrase" a string resulting from the concatenation of some indexes (with a space between them) To use this new template, use the new "index_group_of_subfields" element in biblio-koha-indexdefs.xml, in the same way you used index_subfields Ex : to index the concatenation of "$a $b $d $g" subfields of 700 UNIMARC field in Author:p Author:p This patch also change the biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl for UNIMARC, in order to use this new template for 700-712 fields For 700 and 710, it also indexes in "Author:s" (used for sorting) the concatenation of subfields instead of only the $a subfield To test : in a DOM UNIMARC Koha, apply all the patches, copy the modified files in your Zebra configuration directory, rebuild zebra, and make some tests Everything should be the same as when only the first 2 patches were applied, EXCEPT this behavior: - create a record with 700$aDoe$bJohn (and nothing in 200$f or $g) - Go in Advanced Search, and select the "Author as phrase" index - with only the first 2 patches, you will have 0 result if you enter "Doe John" or "Doe John" - with the 3 patches, you will have 1 result if you enter "Doe John" or "Doe John" - same kind of test for 710 field - the logic is the same for 701, 702,711, 712. So, no need to test - make some searches and test the sorting of your results by author name ("Author A-Z" and "Author Z-A"). The complete name of main author (700 and 710) sould be used for sorting the results, instead of only $& Note that this it better to test it in advanced search, because the behavior of "au:" CCL index in simple search is maybe bugged (it searches the phrase index, while it should probably searches the word index) Signed-off-by: Martin Renvoize Signed-off-by: Paul Poulain Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:52:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:52:01 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:52:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:52:10 +0000 Subject: [Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:52:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:52:22 +0000 Subject: [Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32092|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 32100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32100&action=edit Bug 10126: Remove my variables at module level In C4::Reports::Guided, a lot of variables was defined at module level and reused in subroutine. I didn't find any problem with Plack, so I'm not sure this patch is useful. Test plan: Verify there is no more ^my in the module and you don't find any regression with the guided reports tools (with and without Plack) Signed-off-by: Chris Cormack I'm unsure if this is needed, but I have verified it causes no regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:53:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:53:39 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 32101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32101&action=edit Bug 11677 - Limit to Only items currently available for loan or reference not working! This row: $availability_limit .= "( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and (lost,st-numeric=0) )"; #or ( allrecords,AlwaysMatches='' not lost,AlwaysMatches='')) )"; Causes all records in Zebra to be selected and removes records with even one item onloan (even if items would be available)! This is obviously wrong, but because Zebra (and not many other text indexers) cannot deal with (If undef)-search terms, a fix might be to set 952$q (onloan) datetime to 0000-00-00 instead of NULL in the DB. Then we could find Records with items where onloan is 0000-00-00. Comments out that Zebra availability search and deals with availability on Koha-side. Gets the branch or holdingbranch limit from opac-search.pl or search.pl and uses that to skip Zebra results which are onloan or notforloan. Updates the result set size when results are removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:53:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:53:49 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 17:56:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 15:56:40 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit to Only items |Limit to Only items |currently available for |currently available for |loan or reference not |loan or reference not |working! |working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:05:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:05:48 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:06:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:06:01 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 --- Comment #6 from Chris Cormack --- Created attachment 32102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32102&action=edit Bug 12005 : Creating a new zebra connection for each time we need one Zebra is not designed to have persistent connections, under cgi this didn't matter the scripts would get a new connection each time, but under plack we try to use dead connections This patch changes it so plack works the same way that cgi did. To test: Apply this patch Do some searches Check everything still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:29:10 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:41:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:41:10 +0000 Subject: [Koha-bugs] [Bug 13058] New: Deleting reports should be a permission setting, not a default Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13058 Bug ID: 13058 Summary: Deleting reports should be a permission setting, not a default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: jendayi30 at gmail.com QA Contact: testopia at bugs.koha-community.org One of our librarians just reported to me that she accidentally deleted one of our saved reports off the system. Her permissions were only set to "Execute reports" so this scenario should not be possible. It seems to be an unintended effect of incorporating the ability to delete multiple reports (bug #3134). It would be nice to have a permissions setting for deleting reports. Either a syspref for enabling the multiple reports feature or a permissions setting for deleting reports would work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:47:29 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19876|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 32103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32103&action=edit Bug 10632 - Enable datatables for courses and course details in the OPAC We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. Test Plan: 1) Apply this patch 2) View the courses in the OPAC, try sorting and searching 3) View the course details for a course, try sorting and searching the items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:47:27 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:48:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:48:30 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 --- Comment #3 from Owen Leonard --- (In reply to Martin Renvoize from comment #2) > I just added the 'anti-the' to checkouts.js and found it > appeared to be working for me.. Yes, that works for me too. However, if I try to add something similar to manage-marc-imports.tt it doesn't work (Line 38): - { "mDataProp": "citation" }, + { "mDataProp": "citation", "sType": "anti-the" }, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:49:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:49:37 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Paola Rossi --- Hi, Jonathan. My results didn't match your observations in comment 6, so I've made some further tests. I've applied the patches. On ADMIN in "Item Types" I set "Tax rate" of Book to 5% On ADMIN I set the system pref gist to: 0.10|0|0.05|0.23 [As ADMIN says: "First is the default."] The vendor was configured 0-0, and his tax rate was set to 23%. [I kept the system pref "AcqCreateItem" to default value "placing an order".] The patches worked perfectly well in these 4 cases: A) ordering from an existing record: On a BK biblio record I _immediately_ saw 5% in the tax rate of the "Accounting details" in the "New order" page (RIGHT just as required, I think). And, on a biblio record with none itemtype, I _immediately_ saw 23% there (RIGHT, I also think) B) ordering from a subscription C) ordering from a staged file: the neworderempty.pl script is used by way of the link "Add order", at the right of the uploaded-and-staged-file's titles, in the tag "Select to import" under "Add orders from (name of my file)" D) ordering from titles with highest hold ratios. Ordering from a BK suggestion [or from an empty record] I've seen 23% in the tax rate of the order: it's the vendor' tax rate, instead of the expected tax rate 5% of the BK' itemtype (ERROR). Where have I been wrong, please? Did I forget anything? I beg your pardon, but I should pass the patch to "Failed QA" status for now. [Perhaps is there anything missing in the patches? there is nothing about neworderempty.pl, I see] I've a lot of doubts. Note that a suggestion has no corresponding biblio record in the DB until it has been ordered. So I ask myself how the neworderempty.pl script can find an "itemtype at the biblio level" ordering from a suggestion. [Anyway, I didn't find a way in koha to create a suggestion together with a biblio record: neither from ACQ nor from OPAC]. I'm in doubt: are we into the test for 12993 or not? Moreover, the order had shown the suggestion' price very well in "Accounting details"! If we're into the 12993 test, couldn't the suggestion's itemtype have been read by the same way? It's not a biblio level' itemtype, as you required, but it seems to me being no other way to have an itemtype for a BK suggestion. In case, I invite you to let me know the steps of your test on suggestion, please. ------------------------------------------------------------ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 18:59:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 16:59:58 +0000 Subject: [Koha-bugs] [Bug 12655] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 19:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 17:00:16 +0000 Subject: [Koha-bugs] [Bug 12655] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #11 from Chris Cormack --- Pushed to MM-OPAC/theme_dep -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 19:14:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 17:14:52 +0000 Subject: [Koha-bugs] [Bug 13059] New: tab order on add/edit item isn't right Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13059 Bug ID: 13059 Summary: tab order on add/edit item isn't right Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The tab order on the edit item screen skips the add item button and goes up to the catalog search box, then the search submit button and then to the add item button after tabbing out of public note. It should go public note, add item, add and duplicate, add multiple, and then back to the search box at the top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 19:33:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 17:33:39 +0000 Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages when running under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 --- Comment #4 from Magnus Enger --- I'm about to add Plack as an option to https://github.com/digibib/kohadevbox I'll see if I can reproduce the problem when I get a little bit further with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 19:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 17:41:11 +0000 Subject: [Koha-bugs] [Bug 13060] New: number of holds on acq multiplying by copies ordered Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13060 Bug ID: 13060 Summary: number of holds on acq multiplying by copies ordered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32104&action=edit 4 holds In the summary of already received items the number of holds is being multiplied by the number of items ordered. It's not adding holds, it's just showing the number that's wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 19:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 17:41:28 +0000 Subject: [Koha-bugs] [Bug 13060] number of holds on acq multiplying by copies ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13060 --- Comment #1 from Nicole C. Engard --- Created attachment 32105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32105&action=edit showing the holds*ordered -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:00:32 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:00:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:00:35 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31966|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 32106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32106&action=edit [SIGNED-OFF] Bug 13020 - Checkouts table default ordering is incorrect The checkouts table is no longer keeping "today's checkouts" in the order they were scanned. Test Plan: 1) Create 3 records "Test 1", "Test 2" and "Test 3" each with one item 2) Check out the items to a patron in the order "Test 2", "Test 1", "Test 3". 3) Note the order is incorrect. 4) Apply this patch 5) Refresh the page 6) Note the order is now correct Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:05:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:05:40 +0000 Subject: [Koha-bugs] [Bug 13061] New: filters on invoices not clearing after results found Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Bug ID: 13061 Summary: filters on invoices not clearing after results found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32107&action=edit filter text staying On this page: /cgi-bin/koha/acqui/parcel.pl you see the filter on the left. If you enter a value it stays there even after you're on the results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:11:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:11:54 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:12:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:12:57 +0000 Subject: [Koha-bugs] [Bug 13062] New: Cataloging search no longer passes search terms to z39.50 search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 Bug ID: 13062 Summary: Cataloging search no longer passes search terms to z39.50 search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you search the catalog and click new from z39.50, your term is put in the search popup. Doing the same thing from the cataloging search no longer works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:13:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:13:03 +0000 Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search terms to z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:15:41 +0000 Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search terms to z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:15:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:15:43 +0000 Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search terms to z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 --- Comment #1 from Kyle M Hall --- Created attachment 32108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32108&action=edit Bug 13062 - Cataloging search no longer passes search terms to z39.50 search If you search the catalog and click new from z39.50, your term is put in the search popup. Doing the same thing from the cataloging search no longer works. Test Plan: 1) Do a cataloging search 2) Click "New from Z39.50/SRU" 3) Note you get a blank search form 4) Apply this patch 5) Repeat steps 1-2 6) Note the search time is now pre-populated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:21:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:21:41 +0000 Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:26:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:26:17 +0000 Subject: [Koha-bugs] [Bug 10655] Include list of holds on circ slip or offer separate printing option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10655 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 20:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 18:59:15 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #99 from Katrin Fischer --- Setting this to failed for now - Martin is working on a follow-up for the tests as I ran into some problems running them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:02:44 +0000 Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search terms to z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at ptfs-europe.com --- Comment #2 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Veronica Lencinas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:02:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:02:55 +0000 Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search terms to z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:03:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:03:03 +0000 Subject: [Koha-bugs] [Bug 13062] Cataloging search no longer passes search terms to z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13062 --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 32109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32109&action=edit Bug 13062 - Cataloging search no longer passes search terms to z39.50 search If you search the catalog and click new from z39.50, your term is put in the search popup. Doing the same thing from the cataloging search no longer works. Test Plan: 1) Do a cataloging search 2) Click "New from Z39.50/SRU" 3) Note you get a blank search form 4) Apply this patch 5) Repeat steps 1-2 6) Note the search time is now pre-populated Signed-off-by: Veronica Lencinas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:10:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:10:04 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 --- Comment #15 from Tom?s Cohen Arazi --- Followup pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:17:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:17:10 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher --- (In reply to Chris Cormack from comment #16) > Applying: Bug 8133 - hourly loans doesn't know when library closed > fatal: sha1 information is lacking or useless (C4/Calendar.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 8133 - hourly loans doesn't know when library closed Chris - I think you need to make sure you apply 11211 first - because it applied cleanly for me after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:30:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:30:33 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #30 from Paul Poulain --- QA comments: * NOT UNIMARC-specific things: - this patch fixes 2 obvious mistakes in bib1.att. It means it also fixes a bug in MARC21 that no-one ever saw : -att 1075 Subject-genre/form -att 1076 Subject-name-gerographical +att 1075 Subject-genre-form +att 1076 Subject-name-geographical - this patch adds the following attributes: +su-corp Subject-name-corporate +su-ti Subject-title => those 2 additions are harmless, i've checked that there is no reference to that in marc21/normarc directories no other comment, test plan works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:31:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:31:11 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:31:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:31:27 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30959|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 32110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32110&action=edit Bug 11211 - Move calculation code out of C4::Calendar This patch moves the calculation code out of C4::Calendar, replacing any references to it with Koha::Calendar. Additionally, it moves the administration interface to a single script, tools/calendar.pl. NOTE: This is intended as a bridge to bug 8133, so the UI is a bit awkward, and C4::Calendar has an API designed for adding hours to the calendar. All features should still work, and 8133 will make things better. Test plan: 1) Install the new dependency, Template::Plugin::JavaScript. 2) prove t/db_dependent/Calendar.t t/db_dependent/Holidays.t to verify that the new C4::Calendar API works correctly. 3) prove t/Calendar.t 4) Add, remove and modify events of each type using the administrative interface. In this version, changing a repeating event to "Open" deletes it. 5) Check out items to verify that the calculation code is using the events you just created. 6) If possible, verify that the two affected cronjobs still function correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:31:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:31:42 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30961|0 |1 is obsolete| | Attachment #30962|0 |1 is obsolete| | Attachment #31113|0 |1 is obsolete| | --- Comment #31 from Paul Poulain --- Created attachment 32111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32111&action=edit Bug 9828: More specific indexing of UNIMARC 6XX fields [New commit on 18 Aug 2014 : rebased, and DOM indexing only] Issues to fix : Most of 6XX may contain a $2 that identifies the system used for indexing. It should not be indexed. In French libraries, $2 contains "rameau". So searching books about the music composer "Rameau" retreive thousands of records! For some 6XX fiels, other subfields should not be indexed, for example dates of persons and family, or adresses. In Unimarc guide, 600$t,601$t,602$t are said to exist but to be "not used". I keep them indexed. Additionnally, subject indexing could be improved by using specific indexes for each 6XX if possible : In ccl.properties : - su-to, su-geo and su-ut are defined as aliases of Subject. - a specific index is defined, but not used in record.abs : Subject-name-personal, alias su-na We can use these indexes and create new specific indexes by using existing bib1 attributes. We could also index $j,$x,$y,$z subdivision in specific indexes. This patch does the following changes : 1) For all 6XX : Not indexing $2 (LSCH, Rameau...), $3 and $5 2) Suppressing the indexing of some specific subfields, depending on the field: 600 : Personal name used as a subject // see Marc21 600 not indexing c (additional elements),f (dates),p (address/affiliation) 602 : Family name used as a subject // see Marc21 600 3X not indexing f (dates) 616 : Trademark not indexing c,f 3) For all 6XX : index $j,$x,$y,$z in several indexes in addition to the specfific index for their 6XX field: 4) Define in ccl.properties some specific indexes : Subject-name-conference 1=1073 => alias su-conf Subject-name-corporate 1=1074 => alias su-corp Subject-genre-form 1=1075 => alias su-genre and su-form Subject-geographical 1=1076 => alias su-geo Subject-chronological 1=1077 => alias su-chrono Subject-title 1=1078 => alias su-ut and su-ti Subject-topical 1=1079 => alias su-to 5) Adding new aliases in Search.pm : su-chrono, su-form, su-genre, su-corp, su-conf, su-ti 6) Using these new indexes in for 600 : Subject and Subject-Personal-Name ; all subfields except subdivisions in Personal-name 601 : Subject, Subject-name-conference and Subject-name-corporate and Subject-name-conf ; all subfields except subdivisions in Corporate-name and Conference-name 602 : same as 600 but could be improved later 604 : Subject and Subject-title ; $a in Subject-Personal-Name ; all subfields except subdivisions in Name-and-Title 605 : Subject and Subject-title 606 : Subject and Subject-topical 607 : Subject and Subject-geographical ; all subfields except subdivisions in Name-geographic 608 : Subject and Subject-genre-form To test : A. In a UNIMARC-DOM indexing environment 1) Apply the patch 2) Rebuild zebra 3) Create a record A with some values in critical fields, for example: - the string "test9828" in 600$c 600$f 600$p, 602$f, 616$c, 616$f, 606$2,600$2 - the string "subform" in 600$j 4) Create a record B with the string "subgeo" in 606$y 5) Create a record C with the string "subdate" in 606$z 6) try to search "su:test9828". You should have no results 7) try to search "su-genre:subform". You should have 1 result : record A 8) try to search "su-geo:subgeo". You should have 1 result : record B 9) try to search "su-chrono:subdate". You should have 1 result : record C 10) on existing records, try su-ut, su-to, su-na, su-form, su-corp, su-geo indexes, and see it results are relevant Indexing of subjects could maybe be improved later Signed-off-by: Nick Clemens All seems to work as expected, I am not super-familiar with UNIMARC but I wonder if in su-corp and su-conf the subdivisions might be useful (e.g. France-Gendarmie / Staatsbibliothek-Berlin) Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:31:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:31:50 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 --- Comment #32 from Paul Poulain --- Created attachment 32112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32112&action=edit Bug 9828 : Add and fix comments in UNIMARC biblio-koha-indexdefs.xml Only cosmetic : - the references to lines record.abs are now useless and outdated - some comments added in record.abs could be usefull in biblio-koha-indexdefs.xml No change expected, only comments Signed-off-by: Nick Clemens Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:32:07 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 --- Comment #33 from Paul Poulain --- Created attachment 32113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32113&action=edit Bug 9828 : Followup for Queryparser and deletion of useless 6XX$9 This followup - changes some indexes in Queryparser configuration file - supresses some clearly useless 6XX$9 in biblio-koha-indexdefs.xml and adds 2 new ones, probably useless (not sure of that) - change the name of index Subject-geographical to Subject-name-geographical in ccl.properties (to match bib1.att) the xsl file zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl was generated with the following command: xsltproc zebradb/xsl/koha-indexdefs-to-zebra.xsl zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml > zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl To test : 1) Apply the 3 patches 2) copy the modified files from the source directory to the directory where you store the config files for Zebra and Queryparser The files modified by the 3 patches and that need to be copied are: etc/zebradb/biblios/etc/bib1.att etc/zebradb/ccl.properties etc/searchengine/queryparser.yaml etc/zebradb/ccl.properties .../unimarc/biblios/biblio-koha-indexdefs.xml .../unimarc/biblios/biblio-zebra-indexdefs.xsl 3) Rebuild Zebra 4) Create a record A with some values in critical fields, for example: - the string "test9828" in 600$c 600$f 600$p, 602$f, 616$c, 616$f, 606$2,600$2 - the string "subform" in 600$j 4) Create a record B with the string "subgeo" in 606$y 5) Create a record C with the string "subdate" in 606$z WITHOUT QP activated in sysprefs ("Don't try to use QP"): 6) try to search "su:test9828". You should have no results 7) try to search "su-genre:subform". You should have 1 result : record A 8) try to search "su-geo:subgeo". You should have 1 result : record B 9) try to search "su-chrono:subdate". You should have 1 result : record C 10) on existing records, try su-ut, su-to, su-na, su-form, su-corp, su-geo indexes, and see it results are relevant WITH QP activated in sysprefs: Same tests Signed-off-by: Nick Clemens Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:42:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:42:09 +0000 Subject: [Koha-bugs] [Bug 12901] BiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12901 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- Test plan: BEFORE the patch * switch to default the xstl results * set BiblioDefaultView to any value * check that when you're on a list, you always get the normal view AFTER the patch * set BiblioDefaultView to any value * check that when you're on a list, you you get the defined view Following this test plan for a UNIMARC database, I confirm it fixes the bug. Cannot say for NORMARC, but the code is similar, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:43:25 +0000 Subject: [Koha-bugs] [Bug 12901] BiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12901 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31610|0 |1 is obsolete| | --- Comment #4 from Paul Poulain --- Created attachment 32114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32114&action=edit Bug 12901: BiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT Signed-off-by: Paul Poulain http://bugs.koha-community.org/show_bug.cgi?id=9828 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:43:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:43:34 +0000 Subject: [Koha-bugs] [Bug 12901] BiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12901 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31611|0 |1 is obsolete| | --- Comment #5 from Paul Poulain --- Created attachment 32115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32115&action=edit Bug 12901: (consistency followup) add buildBiblioDefaultViewURL to MARC21 XSLT Signed-off-by: Paul Poulain http://bugs.koha-community.org/show_bug.cgi?id=9828 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:48:03 +0000 Subject: [Koha-bugs] [Bug 12900] IntranetBiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12900 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- Test plan : BEFORE the patch * switch to default the xstl results * set IntranetBiblioDefaultView to any value * check that when you're on a list, you always get the normal view AFTER the patch * set IntranetBiblioDefaultView to any value * check that when you're on a list or results, you you get the defined view Following this test plan for a UNIMARC database, I confirm it fixes the bug. Cannot say for NORMARC, but the code is similar, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:48:49 +0000 Subject: [Koha-bugs] [Bug 12900] IntranetBiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12900 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31612|0 |1 is obsolete| | --- Comment #4 from Paul Poulain --- Created attachment 32116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32116&action=edit Bug 12900: IntranetBiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:48:55 +0000 Subject: [Koha-bugs] [Bug 12900] IntranetBiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12900 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31613|0 |1 is obsolete| | --- Comment #5 from Paul Poulain --- Created attachment 32117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32117&action=edit Bug 12900: (consistency followup) add buildBiblioDefaultViewURL to MARC21 XSLT Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:58:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:58:44 +0000 Subject: [Koha-bugs] [Bug 13063] New: 111n display wrong in opac Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13063 Bug ID: 13063 Summary: 111n display wrong in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32118&action=edit opac Attached are screenshots from the staff and the OPAC. The staff client is showing things right, but the OPAC isn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 21:58:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 19:58:56 +0000 Subject: [Koha-bugs] [Bug 13063] 111n display wrong in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13063 --- Comment #1 from Nicole C. Engard --- Created attachment 32119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32119&action=edit staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 22:27:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 20:27:10 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 22:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 20:52:04 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 22:52:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 20:52:14 +0000 Subject: [Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 23:21:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 21:21:38 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #9 from Katrin Fischer --- I am not sure I understood completely what Dobrica wrote, but I feel like ideally we shouldn't store passwords for LDAP users, but still have the option to have 'local password only' users - think of external library users that are not in LDAP. And as this worked before, we really need to make sure it does again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 23:23:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 21:23:50 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #23 from Katrin Fischer --- Thx for the comment Nicole! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 9 23:29:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 21:29:04 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 --- Comment #11 from Heather Braum --- I know this is an old bug, but I just discovered the original bug that David reported on the Holds Waiting Pickup report on our system, running 3.14.8. We're moving to 3.16.4 this weekend, and I bet it will still be there; we continue to have the holds cancel buttons on this report hidden using JQuery. The bug that Christopher Brannon reported later is a separate issue -- but I think that's what the patch was written for that Failed QA more than a year ago. What's the best way to get the Holds Waiting Pickup bug moving along again? A separate bug? Or something else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:00:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:00:30 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #77 from Katrin Fischer --- Hi Jonathan, sorry, I found some small issues: 1) the ISSN and Issue number column descriptions are switched 2) there are 2 tabs hiding in claims.tt according to the qa script 3) the tags are not removed when generating the email, I used the suggested claim notice template: The following issues are in late: <>, <> (<>) The result email for the 2 claimed issues looks like this: The following issues are in late: Some serial title... Some serial title... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:12:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:12:16 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hi Kyle, I know this is quite an old patch, but as it is in a sensitive area, could we add a hint on the circulation rules page to make it more clear and have some regression tests please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:30:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:30:19 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Katrin Fischer --- I've applied the patches, ran the database update and then tried to run the unit tests specific for serials, sadly, they are failing with these patches, but are ok on master: Test Summary Report ------------------- t/db_dependent/Serials.t (Wstat: 1024 Tests: 44 Failed: 4) Failed tests: 39-40, 42-43 Non-zero exit status: 4 The QA script was ok, no problems there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:51:56 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:52:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:52:00 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31997|0 |1 is obsolete| | Attachment #31998|0 |1 is obsolete| | Attachment #31999|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 32120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32120&action=edit [PASSED QA] Bug 643: Allow override of 'debarred' status Add a button to temporarily override patron debarment. To test: 1) Go to patron check out page 2) If patron has been debarred (eg. due to having fees), there is no way to check out to that patron. 3) Apply patch 4) A debarred patron check out page now has a button for "Override debarment temporarily" - clicking on it should allow checking out to that patron. Signed-off-by: Aleisha Rebased because patch did not apply Signed-off-by: Aleisha Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Tested with/without force_checkout and superlibrarian permission. Also checked crafting a URL is no longer working. No regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:52:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:52:14 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 --- Comment #21 from Katrin Fischer --- Created attachment 32121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32121&action=edit [PASSED QA] Bug 643: Followup: Display override button only if issuing staff member has force_checkout permission To test: Apply first patch Apply this patch Log in as superlibrarian Go to Home > Patrons > Set permissions for issuing staff member Disable circulate - force_checkout Log in as issuing staff member Try to checkout to a debarred patron => should not be possible Log in again as superlibrarian Enable circulate - force_checkout for issuing staff member Log in as issuing staff_member Try to checkout to a debarred person => You should get the button 'Override debarment temporarily' Signed-off-by: Aleisha Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 00:52:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 22:52:27 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 --- Comment #22 from Katrin Fischer --- Created attachment 32122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32122&action=edit [PASSED QA] Bug 643: QA Followup - server-side verification of permissions Only allow $force_allow=1 if the logged in user has permissions. TEST PLAN --------- Attempt to intentionally override the checkout by passing an appropriately handcrafted URL. -- Regardless of the force_allow value, it should be not allowed for those lacking the force_checkout permission. NOTE: I didn't test this. I figured Marc Veron could do that. :) (Sorry, couldn't easily get git bz to work with the accent) Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 01:14:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 23:14:25 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer --- The QA script is pointing out a problem: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK forbidden patterns OK tt_valid FAIL valid_template greybox.inc: not found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 01:24:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Oct 2014 23:24:28 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #51 from Katrin Fischer --- Hi Kyle, there have been lots of follow-ups on this, would you be ok with asking for another sign-off? This is a bigger one and I'd feel better with some additional testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 02:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 00:05:32 +0000 Subject: [Koha-bugs] [Bug 12985] All basketgroups are not listed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thansk Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 02:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 00:06:04 +0000 Subject: [Koha-bugs] [Bug 12755] MARC Preview doesn't always display in managed MARC record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 02:24:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 00:24:00 +0000 Subject: [Koha-bugs] [Bug 13063] 111n display wrong in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13063 --- Comment #2 from Owen Leonard --- This works for me in master. Can you please verify the version number? If you can reproduce the problem in master please attach the MARC record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 02:26:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 00:26:29 +0000 Subject: [Koha-bugs] [Bug 13059] tab order on add/edit item isn't right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13059 --- Comment #1 from Owen Leonard --- Sounds like Bug 12380, "can't tab to save buttons on add item." Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 02:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 00:36:28 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha h1 tag on staff login |Login page image | |replacement technique fails | |when browser width exceeds | |2000 pixels --- Comment #1 from Owen Leonard --- ?Doctor, doctor, it hurts when I do this.? ?Then don?t do that!? Sorry, I couldn't resist. Yes it's true. If your browser window goes much wider than 2000 pixels the image replacement technique which displays the Koha logo will fail, having this style: text-indent: -1000px; ...which at the time of implementation was expected to be PLENTY of space to exclude the possibility that someone's browser would be wide enough that the text would be visible. It may be that we need to increase that number, or it may be that there is a more modern image replacement technique which we should switch to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 04:12:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 02:12:44 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 04:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 02:12:50 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #46 from Jonathan Druart --- Created attachment 32123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32123&action=edit Bug 8992: Add the greybox include file for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 04:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 02:24:53 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #52 from Katrin Fischer --- There are also a couple of problems pointed out by the QA script at this point: FAIL circ/returns.pl OK critic OK forbidden patterns OK pod FAIL valid "my" variable $itemnumber masks earlier declaration in same scope FAIL rotating_collections/addItems.pl OK critic FAIL forbidden patterns forbidden pattern: You should not use a .tmpl extension for the template name (see bug 11349) (line 33) OK pod OK valid FAIL rotating_collections/editCollections.pl OK critic FAIL forbidden patterns forbidden pattern: You should not use a .tmpl extension for the template name (see bug 11349) (line 33) OK pod OK valid FAIL rotating_collections/rotatingCollections.pl OK critic FAIL forbidden patterns forbidden pattern: You should not use a .tmpl extension for the template name (see bug 11349) (line 32) OK pod OK valid FAIL rotating_collections/transferCollection.pl OK critic FAIL forbidden patterns forbidden pattern: You should not use a .tmpl extension for the template name (see bug 11349) (line 36) OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 04:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 02:32:19 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #74 from Katrin Fischer --- Hi Kyle, I am having problems applying these patches - I fixed the conflicts in the second, but then can't get QA follow-up 2 to apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 09:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 07:08:59 +0000 Subject: [Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #10 from Martin Renvoize --- Unfortunately I don't think there's going to be a 'quick fix' here. As Dobrica says, I believe his fix doesn't really catch the general case and as such we could be chasing our tails for a while. That said, it's probably better than nothing to start with. Our LDAP implementation relies heavily on 'quirks' all over the place and isn't really a very thorough implementation at all. The more I look at it, the more questions I ask about it. I'd love to get a some feedback from the community as to how people are configuring the module and expecting it to behave. Then we'de have a better idea of what features are 'broken', what features are in fact bugs, and where people are using bugs as features to get around our bad implementation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 09:16:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 07:16:08 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #100 from Martin Renvoize --- :( It seems that mocking the database with DBD::Mock when using DBIx::Class is simply incompatible (DBIx::Class just complains about an unrecognised DBI driver, then proceeds to drop back to some default SQL and fails badly) I've been looking into alternatives, like Test::DBIx::Class (which is a module to create an in memory sql database to test against, but this route requires lots of work manually creating dummy data to test against). I then tried DBIx::Class::Sims (which is a module to automatically fill tables with randomly generated dummy data, but this approach also fails because our database schema has a large number of cyclic relationships and the Sims module doesn't cope with this well) Interesting enough, the problem I'm facing (Not wanting to have to populate the whole structure of a Borrowers Row and satisfy all constraints manually) is basically solved by the TestBuilder module we recently decided not to adopt! I'll keep battling with it, but I have a feeling the Test size will have to jump substantially as I add all the releated data in a transaction. It shouldn't be this Hard! Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 09:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 07:24:27 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #73 from Julian Maurice --- Created attachment 32124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32124&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 09:24:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 07:24:46 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 09:34:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 07:34:54 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 10:07:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 08:07:23 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 --- Comment #7 from Jacek Ablewicz --- (In reply to Chris Cormack from comment #6) > This patch changes it so plack works the same way that cgi did. At the moment I don't have a persistent install properly set up & suitable for any meaningfull testing, but - at least at the 1st glance, this proposed patch doesn't look quite right to me: 1) Completely abandoninig Zconn caching would have some measurable impact (performance-wise and memory-footprint-wise) in non-persistent installations. How significant such an impact may be in the practical circumstances is another question - while Koha does not seem to use cached Zconn very often, in those rare (?) cases when it does, cached Zconn is being used rather extensivelly (eg. when performing authority searches). 2) Removing a code part which used to destroy() previously made zebra connection may be not such a good idea IMO. AFAIRC (it's been several months since I had a look at that code), previously estabilished Zconn is not being atomatically destroyed when the variable which holds it gets udefined, goes out of scope, etc. Unless I'm very much mistaken - with this patch applied, when running in persistent environment - yes, Koha will indeed make brand new zebra connection each time it does perform a search, but the problem is that previously made connection[s] would never get destroyed (and they will accumulate pretty quicky, eventually leading to the crash when the system goes out of available RAM for new zebra processes, free filehandles for subsequent connections and so on). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 10:29:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 08:29:29 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31907|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize --- Created attachment 32125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32125&action=edit BUG8446, QA Followup: Use DBIx::Class - Convert Auth_with_shibboleth to use dbic stanzas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 10:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 08:31:00 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 --- Comment #3 from Julian Maurice --- Hi Nick, are you sure there is nothing linked to the subfield $3 ? In any framework ? Does master have the same behaviour ? Does it also happen with another subfield ? Could you also check the "Koha to MARC mappings" page (cgi-bin/koha/admin/koha2marclinks.pl) ? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 10:35:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 08:35:00 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 10:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 08:38:39 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #102 from Martin Renvoize --- Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 11:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 09:38:41 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 --- Comment #34 from mathieu saby --- Note: France -- Gendarmerie is encoded as $aFrance $bGendarmerie http://multimedia.bnf.fr/unimarcb_trad/B601-6-2013.pdf M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 11:57:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 09:57:03 +0000 Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26262|0 |1 is obsolete| | Attachment #28574|0 |1 is obsolete| | --- Comment #12 from Rafal Kopaczka --- Created attachment 32126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32126&action=edit Bug 11651: Add possibility to print holds from holds queue This patch adds possibility to print holds slip, directly from holds queue page. Added preference to enable or disable. When enabled in holds queue are 2 new buttons and checkboxes to select holds to print. First button prints selected holds on RESERVESLIP form. Second is to switch between display printed or not printed holds. In this mode isn't possible to display printed and non printed together. Test plan: 1) Apply patch 2) Update database 3) Make 2 new holds, 1 on specific copy, another on next available 4) Update holds queue by running $KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl 5) Check holds queue there should be 2 new holds from step 3 6) Enable printSlipFromHoldsQueue in preferences-> circulation-> interface 7) Go to holds after submit branch there should be 2 new buttons and checkboxes in table. 8) Print both holds and check if on slip are all biblio and item info. 9) click show printed to display printed holds 10) click hide printed, now holds queue shuld be empty 11) disable printSlipFromHoldsQueue go to holds queue and check if holds are again visible. Signed-off-by: Aurelie Fichot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 11:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 09:57:40 +0000 Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 --- Comment #13 from Rafal Kopaczka --- Created attachment 32127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32127&action=edit Bug 11651: (QA Follow-up) Add possibility to print holds from holds queue. Added unit tests, for new and modified subroutines. Fixed minor qa suggestions. Koha-qa.pl - pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 11:58:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 09:58:44 +0000 Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 --- Comment #14 from Rafal Kopaczka --- Rebased, against master. Also few minor changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 12:00:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 10:00:19 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Paola Rossi --- I've tried to apply the patches against master 3.17.00.025 I've applied: 12844 (4), 12986, 12987 (2), 12955 Applying: Bug 12988: Update table footer with the visible rows - budgets Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt Failed to merge in the changes. Patch failed at 0001 Bug 12988: Update table footer with the visible rows - budgets So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 12:59:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 10:59:51 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 13:27:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 11:27:29 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Nick Clemens --- I cannot now recreate, still had some oddness going on but I think it was me so reverting to sign off and will test again when I have a chnace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:04:07 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:04:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:04:11 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #20 from Kyle M Hall --- Created attachment 32128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32128&action=edit [PASSED QA] Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) DataTables 1.10.2 is now available. The footerCallback function does not seem to work correctly with our current version. Test plan: Go on the maximum of pages where DataTables is used and try to catch a bug/regression :) Signed-off-by: Owen Leonard I tested many many pages with DataTables, taking special care to find pages with different DataTables configurations. I found no errors in the OPAC or staff client. Tested thoroughly in Firefox (latest) on Windows 7. Tested less thoroughly in Chrome (latest) on Windows 7. Tested briefly in Internet Explorer 7 in Vista and Internet Explorer 8 and found no bugs which were related to the DataTables upgrade. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:20:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:20:44 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 --- Comment #4 from Kyle M Hall --- Created attachment 32129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32129&action=edit Bug 12929 [QA Followup] - Hide borrownumber from sample csv file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:21:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:21:39 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31969|Bug 12929: Restore behavior |[SIGNED-OFF] Bug 12929: description|before bug 12716 |Restore behavior before bug | |12716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:21:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:21:47 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:40:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:40:05 +0000 Subject: [Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- I cannot reproduce this bug on master with bug 643 applied. I think perhaps the wording of the message has changed to correct this already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:44:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:44:25 +0000 Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration hold date in staff not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:44:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:44:28 +0000 Subject: [Koha-bugs] [Bug 12893] 'Clear date' links on start and expiration hold date in staff not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31996|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 32130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32130&action=edit [PASSED QA] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:48:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:48:33 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32103|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 32131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32131&action=edit [SIGNED-OFF] Bug 10632 - Enable datatables for courses and course details in the OPAC We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. Test Plan: 1) Apply this patch 2) View the courses in the OPAC, try sorting and searching 3) View the course details for a course, try sorting and searching the items. Signed-off-by: Owen Leonard Signing off, but have a follow-up to address some missing stuff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:48:42 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 --- Comment #7 from Owen Leonard --- Created attachment 32132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32132&action=edit Bug 10632 [Follow-up] Enable datatables for courses and course details in the OPAC This follow-up adds some style improvements and corrects some errors in the previous patch: - The path to datatables.css has been corrected - Unused CSS has been removed from datatables.css (particularly related to pagination controls, which are currently unused in the OPAC). - Style has been added to datatables.css to make the table search form look better. - The configuration of the course details table has been enhanced to include a title sort which ignores articles and date sorting according to the "title-string" method for date format agnostic sorting. - Unrelated: A message
has been modified to have the correct style for the Bootstrap theme. To test you should have multiple courses and at least one course with multiple reserves. Clear your browser cache if necessary and view the list of courses in the OPAC. All table sorting should work correctly, as should the table search form. View the details of a course which has multiple reserves. All sorting should work correctly, including title sort excluding articles. Sorting by date due should work correctly for any dateformat system preference setting. View the details of a course which has no reserves. You should see a "No reserves" message box with a style consistent with similar messages in the Bootstrap OPAC. View other sorted tables in the OPAC to confirm that the CSS changes have not negatively affected their appearance: opac-user.pl for instance, or opac-detail.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:50:10 +0000 Subject: [Koha-bugs] [Bug 12281] RTL display for records using 880 broken in Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12281 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 14:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 12:50:13 +0000 Subject: [Koha-bugs] [Bug 12281] RTL display for records using 880 broken in Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12281 --- Comment #9 from Kyle M Hall --- Created attachment 32133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32133&action=edit [PASSED QA] Bug 12281: Display for records with RTL script in 880 in Boostrap This patch adds a missing CSS declaration to the Boostrap CSS file in order to fix the display for RTL script catalogued in tag 880. To test: - Catalog or import records using the 880 tag into your catalog - Compare the prog OPAC detail and rsult view with bootstrap - Apply patch - Verfiy now the display in bootstrap is the same as before in prog (and also in staff) Note: Some notes on how to catalog with 880 were added to the bug report. Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:01:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:01:09 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:01:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:01:12 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32132|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 32134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32134&action=edit [SIGNED-OFF] Bug 10632 [Follow-up] Enable datatables for courses and course details in the OPAC This follow-up adds some style improvements and corrects some errors in the previous patch: - The path to datatables.css has been corrected - Unused CSS has been removed from datatables.css (particularly related to pagination controls, which are currently unused in the OPAC). - Style has been added to datatables.css to make the table search form look better. - The configuration of the course details table has been enhanced to include a title sort which ignores articles and date sorting according to the "title-string" method for date format agnostic sorting. - Unrelated: A message
has been modified to have the correct style for the Bootstrap theme. To test you should have multiple courses and at least one course with multiple reserves. Clear your browser cache if necessary and view the list of courses in the OPAC. All table sorting should work correctly, as should the table search form. View the details of a course which has multiple reserves. All sorting should work correctly, including title sort excluding articles. Sorting by date due should work correctly for any dateformat system preference setting. View the details of a course which has no reserves. You should see a "No reserves" message box with a style consistent with similar messages in the Bootstrap OPAC. View other sorted tables in the OPAC to confirm that the CSS changes have not negatively affected their appearance: opac-user.pl for instance, or opac-detail.pl. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:02:53 +0000 Subject: [Koha-bugs] [Bug 13064] New: Indexing problem with ICU on control characters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13064 Bug ID: 13064 Summary: Indexing problem with ICU on control characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org The ICU configuration files contains a rule to remove control characters : This rule is before tokenization. The problem is that "[:Control:]" regex contains linefeed, carriage return and tab. See http://www.regular-expressions.info/posixbrackets.html. So when several lines are indexed, last word of line is joined with first line of next line. Thoses words are then not searchable. For example : First line Second line This will become "First lineSecond line", tokenized as "First", "lineSecond" and "line". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:03:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:03:25 +0000 Subject: [Koha-bugs] [Bug 13065] New: Receive shipment error message incorrectly styled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13065 Bug ID: 13065 Summary: Receive shipment error message incorrectly styled Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcels.pl OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If there is an error when receiving a shipment an error message is displayed, "An error has occurred. Invoice cannot be created." That message box is incorrectly styled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:06:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:06:05 +0000 Subject: [Koha-bugs] [Bug 13064] Indexing problem with ICU on control characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13064 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:06:54 +0000 Subject: [Koha-bugs] [Bug 13065] Receive shipment error message incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13065 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:06:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:06:56 +0000 Subject: [Koha-bugs] [Bug 13065] Receive shipment error message incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13065 --- Comment #1 from Owen Leonard --- Created attachment 32135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32135&action=edit Bug 13065 - Receive shipment error message incorrectly styled If there is an error during the receive shipment process the error message is incorrectly styled. This patch fixes it. To test you can trigger the error by accessing the page with incorrect or missing parameters: /cgi-bin/koha/acqui/parcels.pl?op=confirm This should trigger the message. Apply the patch and confirm that the error is now styled consistently with others in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:13:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:13:31 +0000 Subject: [Koha-bugs] [Bug 13064] Indexing problem with ICU on control characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13064 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:13:34 +0000 Subject: [Koha-bugs] [Bug 13064] Indexing problem with ICU on control characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13064 --- Comment #1 from Fridolin SOMERS --- Created attachment 32136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32136&action=edit Bug 13064 - Indexing problem with ICU on control characters The ICU configuration files contains a rule to remove control characters : This rule is before tokenization. The problem is that "[:Control:]" regex contains line feed, carriage return and tab. See http://www.regular-expressions.info/posixbrackets.html. So when several lines are indexed, last word of line is joined with first line of next line. Thoses words are then not searchable. For example : First line Second line This will become "First lineSecond line", tokenized as "First", "lineSecond" and "line". Test plan : - Use ICU in Zebra configuration - Choose an indexed field, like 300$a - Create a new record - Enter several lines in choosen field, like : First line Second line - Index this record => Without patch the search on "Second" does not return the record => With patch the search on "Second" returns the record - Same tests with tab and carriage return instead of line feed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:24:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:24:06 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Paola Rossi --- I've applied the patches against 3.17.00.025 Firstly I've applied the signed-off patches: 11319 (5) 11413 (3) At step 0/ Create a new marc modification template with some actions, I've created a template with some actions. Then I've selected the "Edit" link, at the right of one of the created actions, but I could not edit this action. Instead of seeing the values of the action I wanted to edit, under the "Actions for this template" table, the default page "Add a new action" with the default values: "Delete ", "All" and none, has been shown. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:46:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:46:50 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #40 from Jonathan Druart --- It should work. Please try refreshing completely (ctrl+r / ctrl+f5) your cache. Did you get a JS error (using Firebug)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:48:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:48:09 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:48:28 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31910|0 |1 is obsolete| | --- Comment #10 from Paul Poulain --- Created attachment 32137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32137&action=edit Bug 11586: Better default framework for UNIMARC - framework This patch updates the framework_DEFAULT.sql for unimarc_complet. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:48:41 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31911|0 |1 is obsolete| | --- Comment #11 from Paul Poulain --- Created attachment 32138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32138&action=edit Bug 11586: Better default framework for UNIMARC - authority This patch updates the framework for authorities (unimarc_complet only). Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:48:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:48:59 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31912|0 |1 is obsolete| | --- Comment #12 from Paul Poulain --- Created attachment 32139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32139&action=edit Bug 11586: Better default framework for UNIMARC - AV This patch updates the authorised_values.sql file. New WITHDRAWN and RESTRICTED. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:49:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:49:06 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31913|0 |1 is obsolete| | --- Comment #13 from Paul Poulain --- Created attachment 32140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32140&action=edit Bug 11586: Better default framework for UNIMARC - zebra conf This patch updates the Zebra configuration for unimarc. 995$d and 995$j should not be indexed. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:49:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:49:17 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 --- Comment #8 from Chris Cormack --- (In reply to Jacek Ablewicz from comment #7) > (In reply to Chris Cormack from comment #6) > > > This patch changes it so plack works the same way that cgi did. > > At the moment I don't have a persistent install properly set up & suitable > for any meaningfull testing, but - at least at the 1st glance, this proposed > patch doesn't look quite right to me: > > 1) Completely abandoninig Zconn caching would have some measurable impact > (performance-wise and memory-footprint-wise) in non-persistent > installations. How significant such an impact may be in the practical > circumstances is another question - while Koha does not seem to use cached > Zconn very often, in those rare (?) cases when it does, cached Zconn is > being used rather extensivelly (eg. when performing authority searches). > It would if it was working, but the caching has never worked. It has never been doing caching, you make a connection, and use it and then cgi dies and the connection disappears. In plack you make a connection, you use it, you stop using it, you asking for a new connection, it tries to give you back the old one that is dead. Searches break. So while I agree caching would probably be good, the fact is there is no performance hit from removing it, because we never had it. > 2) Removing a code part which used to destroy() previously made zebra > connection may be not such a good idea IMO. AFAIRC (it's been several months > since I had a look at that code), previously estabilished Zconn is not being > atomatically destroyed when the variable which holds it gets udefined, goes > out of scope, etc. Unless I'm very much mistaken - with this patch applied, > when running in persistent environment - yes, Koha will indeed make brand > new zebra connection each time it does perform a search, but the problem is > that previously made connection[s] would never get destroyed (and they will > accumulate pretty quicky, eventually leading to the crash when the system > goes out of available RAM for new zebra processes, free filehandles for > subsequent connections and so on). THis is not our experience we have been running it live in production for 6 months, zebra kills the connections without the destroy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:51:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:51:25 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 --- Comment #14 from Paul Poulain --- Created attachment 32141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32141&action=edit Bug 11586 follow-up * itemtype = a mix was made between 099$t (biblioitems level) and 995$r (items level). I've chosen 099$t (manual change still possible for librarians that want it) * the 616$z is mistakenly displayed in tab 0. Switched to 6 * field "abim?" (995$1) activated, it's better Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:51:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:51:39 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 --- Comment #15 from Paul Poulain --- Created attachment 32142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32142&action=edit Bug 11586 follow-up, FA framework update This follow-up also improves the FA framework, removing some fields that should not be in FA Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:52:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:52:17 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 15:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 13:52:21 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32129|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 32143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32143&action=edit Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:09:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:09:00 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32020|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:15:09 +0000 Subject: [Koha-bugs] [Bug 12999] Untranslatable string on enhanced_content.pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:15:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:15:12 +0000 Subject: [Koha-bugs] [Bug 12999] Untranslatable string on enhanced_content.pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31886|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 32144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32144&action=edit [SIGNED-OFF] Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## NOTE: you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:16:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:16:01 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:16:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:16:06 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31855|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 32145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32145&action=edit Bug 12988: Update table footer with the visible rows - budgets On the budget list view, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: To test with both CurrencyFormat pref values. 1/ Go on the budget list view 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown 4/ Hide/Show inactive budgets and verify the totals are still corrects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:17:48 +0000 Subject: [Koha-bugs] [Bug 13066] New: search the catalog tab not selected on results in staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13066 Bug ID: 13066 Summary: search the catalog tab not selected on results in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32146&action=edit tab selected on search results Are you search the catalog in the staff client you're presented with results, the results page used to keep the 'search the catalog' tab selected, but now it reverts back to 'check out' (now being in 3.16.4). I can't recreate in master, but don't see a bug that fixed this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:20:15 +0000 Subject: [Koha-bugs] [Bug 12984] Improvement of the funds list view - acqui home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31870|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 32147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32147&action=edit Bug 12984: Improvement of the funds list view - acqui home Bug 11578 improved the funds list view in the administration module. It would be great to have the same improvement on the acquisition home page. This improvement groups funds by budget and displays them with a hierarchy. Test plan: 0/ Create a budget and fund hierarchy, with active and inactive budgets. 1/ Go on the acquisition home page and verify the values are the same as before 2/ Verify the funds are correctly listed 3/ Verify the links on top of table work (expand/collapse all, show/hide inactive budgets). Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:21:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:21:30 +0000 Subject: [Koha-bugs] [Bug 13067] New: due date sorting doesn't work on patron checkouts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13067 Bug ID: 13067 Summary: due date sorting doesn't work on patron checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 32148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32148&action=edit due date sorting When looking at the list of items out on a patron's record, the little sort arrow on the due date column doesn't work. I can make the list be arranged by title a-z or z-a by clicking on the arrow in the title box, but the one in the date due box doesn't do anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:26:11 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31856|0 |1 is obsolete| | Attachment #31977|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 32149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32149&action=edit Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:26:21 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #4 from Jonathan Druart --- Created attachment 32150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32150&action=edit Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:27:18 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #247 from Paul Poulain --- abandoning this one, will try something else, more simpler, that fixes the sandbox cannot apply most patches with DB update problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:27:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:27:23 +0000 Subject: [Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Bug 9326 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:27:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:27:25 +0000 Subject: [Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327 Bug 9327 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:27:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:27:25 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Bug 9328 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:27:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:27:26 +0000 Subject: [Koha-bugs] [Bug 6190] Custom field removal from patron entry screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Bug 6190 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:27:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:27:28 +0000 Subject: [Koha-bugs] [Bug 6328] Fine in days does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328 Bug 6328 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:29:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:29:04 +0000 Subject: [Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED CC| |paul.poulain at biblibre.com Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:29:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:29:36 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED CC| |paul.poulain at biblibre.com Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:31:43 +0000 Subject: [Koha-bugs] [Bug 12957] Get rid of warning in aqbudgets.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12957 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:31:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:31:46 +0000 Subject: [Koha-bugs] [Bug 12957] Get rid of warning in aqbudgets.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12957 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31700|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 32151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32151&action=edit [SIGNED-OFF] Bug 12957: Get rid of warnings in aqbudgets.pl There are a lot of warnings on navigating into the fund views (list, editing, etc.) "Use of uninitialized value in string eq..." "Use of uninitialized value in hash element" "Use of uninitialized value in concatenation..." Test plan: Verify the warnings don't appear anymore in logs on going on the fund list view, editing a fund, saving a fund. QA note: the budget_owner_name, budget_borrowernumber and branchname are never used on the fund list view. A call to GetMember has been removed. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:34:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:34:09 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:34:16 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31795|0 |1 is obsolete| | Attachment #31796|0 |1 is obsolete| | Attachment #31797|0 |1 is obsolete| | Attachment #31798|0 |1 is obsolete| | Attachment #31799|0 |1 is obsolete| | Attachment #31800|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 32152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32152&action=edit Bug 11232: Add new syntax for facets definition on koha-indexdefs-to-zebra.xsl This patch changes koha-indexdefs-to-zebra.xsl to correctly process a new syntax for defining facet indexes on the XML files. It also changes the retrieval file to allow access to Zebra's internal data from Zoom (i.e. access to zebra::facet:*). Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:34:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:34:34 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #76 from Jonathan Druart --- Created attachment 32153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32153&action=edit Bug 11232: MARC21 facet definition and updated XSL file for DOM This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based on what is hardcoded on C4::Koha::getFacets(). The biblio-zebra-indexdefs.xsl file for MARC21 is generated using the usual: xsltproc ...koha-indexdefs-to-zebra.xsl ...marc21/biblios/biblio-koha-indexdefs.xml > \ ...marc21/biblios/biblio-zebra-indexdefs.xsl Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:34:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:34:44 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #77 from Jonathan Druart --- Created attachment 32154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32154&action=edit Bug 11232: UNIMARC facet definition and updated XSL file for DOM This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based on what is hardcoded on C4::Koha::getFacets(). The biblio-zebra-indexdefs.xsl file for UNIMARC is generated using the usual: xsltproc ...koha-indexdefs-to-zebra.xsl ...unimarc/biblios/biblio-koha-indexdefs.xml > \ ...unimarc/biblios/biblio-zebra-indexdefs.xsl Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:34:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:34:51 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #78 from Jonathan Druart --- Created attachment 32155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32155&action=edit Bug 11232: NORMARC facet definition and updated XSL file for DOM This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based on what is hardcoded on C4::Koha::getFacets(). The biblio-zebra-indexdefs.xsl file for NORMARC is generated using the usual: xsltproc ...koha-indexdefs-to-zebra.xsl ...normarc/biblios/biblio-koha-indexdefs.xml > \ ...normarc/biblios/biblio-zebra-indexdefs.xsl Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:34:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:34:59 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #79 from Jonathan Druart --- Created attachment 32156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32156&action=edit Bug 11232: retrieve facets from Zebra's indexes in DOM This patch adds the following routines to C4::Search - GetFacets This is a wrapper routine, that given a ZOOM::ResultSet, extracts the relevant facets. To do the job, it uses the internal functions: _get_facets_from_records and _get_facets_from_zebra. The choice is done on querying the indexing mode: grs1 will use records, and dom zebra's facets. - _get_facets_from_records Just refactoring the already existent main loop from getRecords into a function. - _get_facets_from_zebra Given a result set, loop through all defined facets in C4::Koha::getFacets and call _get_facet_from_result_set for each, to build the facets information. It retrieves the facets from Zebra's facets. - _get_facet_from_result_set Given a result set and a facet index name, retrieve the facets for the given index, and build the result for rendering. To test this preliminay work: - Apply the patches, install on DOM, using MARC21, NORMARC and UNIMARC. - Reindex some DB with lots of records. - Check facets work. Note: UNIMARC is the only dialect that has more than one subfield (concatenated) for facets values, so it is better to test on uNIMARC. The approach leaves room for re-thinking facets in MARC21/NORMARC, but it is outside of the scope of the bug (e.g. we could have more author facets) Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:35:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:35:09 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #80 from Jonathan Druart --- Created attachment 32157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32157&action=edit Bug 11232: (followup) remove unnecesary namespace definition from all XML elements The previous patches for facet extraction from Zebra indexes set a default namespace on the following files: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/normarc/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and hence the XML file index_subfields can be cleaned by removing the namespace. To test: - Apply this patch - Run $ for i in marc21 normarc unimarc do xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/$i/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/$i/biblios/biblio-zebra-indexdefs.xsl done => SUCCESS: no errors reported - Run $ git diff => SUCCESS: no differences on the xsl files - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:35:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:35:56 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #81 from Jonathan Druart --- Tested with Tomas yesterday on a UNIMARC installation. All works fine :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:36:55 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #4 from Owen Leonard --- *** Bug 13067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:36:55 +0000 Subject: [Koha-bugs] [Bug 13067] due date sorting doesn't work on patron checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13067 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- I'm pretty sure this is fixed by Bug 13020. Please reopen if I'm wrong. *** This bug has been marked as a duplicate of bug 13020 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:37:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:37:07 +0000 Subject: [Koha-bugs] [Bug 13068] New: New feature for DB update and sandbox Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Bug ID: 13068 Summary: New feature for DB update and sandbox Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: paul.poulain at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Most patches with a DB update cannot be applied automatically on sandboxes, because they have a conflict in updatedatabase.pl I propose to have a new directory (say dev_update), that will be used during the development process. * when you submit a patch with a db update, you developer must put the DB update part into the dev_update/ directory, NOT in updatedatabase.pl * the updatedatabase.pl, at the end of the update process, checks if there is something in the dev_update. If there is, what's here is applied. * when the patch is pushed by the Release Manager, the DB update is moved out from the dev_update directory, and included into updatedatabase.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:37:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:37:07 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:39:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:39:14 +0000 Subject: [Koha-bugs] [Bug 13066] search the catalog tab not selected on results in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13066 --- Comment #1 from Owen Leonard --- I can't reproduce this problem in master or 3.16.4. Please make sure there aren't any local customizations which might be causing the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:42:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:42:56 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #103 from Martin Renvoize --- Created attachment 32158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32158&action=edit BUG8446, QA Followup: Add Test::DBIx::Class to dependancies - To correct tests after converting module to dbic, we need to add the Test::DBIx::Class module as a dependancy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:47:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:47:41 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:52:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:52:08 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32061|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 32159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32159&action=edit [SIGNED-OFF] Bug 11990 - Holds ratio report (circ/reserveratios.pl) sorts numeric values as text This patch makes columns Holds, Items and "Hold ratio" to sort numerically instead of lexicographically. Also changes default sorting column from "Holds" to "Hold ratio" because this is a hold ratios -report, not hold count report. Also cleans up an excess aoColumn -definition, because aoColumns == aoColumnDefs without target operator. No point in defining columns twice. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:52:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:52:06 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:52:13 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32047|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 32160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32160&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:53:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:53:05 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:53:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:53:15 +0000 Subject: [Koha-bugs] [Bug 9214] Show damaged status in the OPAC for items which are not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32048|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 32161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32161&action=edit Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:56:38 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:57:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:57:25 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:59:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:59:20 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:59:28 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 16:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 14:59:57 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31408|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:00:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:00:24 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:00:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:00:30 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30617|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:01:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:01:01 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30618|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:01:08 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:01:14 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:01:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:01:43 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Paola Rossi --- Thanks, Jonathan. I've tried to apply against master 3.17.00.025 Now I've applied: 12844 (4), 12986, 12987 (2), 12955, 12988. The patches 12984 and 12989 remain yet to be applied. Applying: Bug 12984: Improvement of the funds list view - acqui home Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt Failed to merge in the changes. Patch failed at 0001 Bug 12984: Improvement of the funds list view - acqui home So I pass again the patch to "Patch doesn't apply" status. [I beg your pardon if this is not the right bug to be passed] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:01:53 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:05:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:05:49 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #104 from Katrin Fischer --- Created attachment 32162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32162&action=edit [PASSED QA] BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 BUG8446, Follow up: Remove unused imports from scripts - Remove import of deprecated C4::Utils module from shibboleth authentication module: Auth_with_shibboleth.pm Signed-off-by: Jesse Weaver Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer Tested with the feide idp. - LDAP login and logout are working - local login/logout are still working - CAS login/logout are still working Instructions for setup can be found on the wiki: http://wiki.koha-community.org/wiki/Shibboleth_Configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:06:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:06:32 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #105 from Katrin Fischer --- Created attachment 32163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32163&action=edit [PASSED QA] BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:06:40 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #106 from Katrin Fischer --- Created attachment 32164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32164&action=edit [PASSED QA] BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:07:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:07:22 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #107 from Katrin Fischer --- Created attachment 32165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32165&action=edit [PASSED QA] BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context->new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:08:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:08:00 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #108 from Katrin Fischer --- Created attachment 32166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32166&action=edit [PASSED QA] BUG8446, followup: Add Unit Tests Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:08:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:08:48 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #109 from Katrin Fischer --- Created attachment 32167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32167&action=edit [PASSED QA] BUG8446, QA Followup: Cleanup tabs and license Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:09:39 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #110 from Katrin Fischer --- Created attachment 32168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32168&action=edit [PASSED QA] BUG8446, QA Followup: Minor Code Tidies Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:09:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:09:47 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #111 from Katrin Fischer --- Created attachment 32169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32169&action=edit [PASSED QA] BUG8446, QA Followup: Use DBIx::Class - Convert Auth_with_shibboleth to use dbic stanzas. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:09:55 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #112 from Katrin Fischer --- Created attachment 32170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32170&action=edit [PASSED QA] BUG8446, QA Followup: Add Test::DBIx::Class to dependancies - To correct tests after converting module to dbic, we need to add the Test::DBIx::Class module as a dependancy. Signed-off-by: Katrin Fischer The dependency will probably need to be packaged by us until it can get into Debian proper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:10:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:10:11 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 --- Comment #14 from Jonathan Druart --- Looks good here: Bug 12989: Fix JS error Bug 12989: Update table footer with the visible rows - acqui-home Bug 12984: Improvement of the funds list view - acqui home Bug 12988: Update table footer with the visible rows - budgets Bug 12987: The new format_price include file should be include on using datatables Bug 12987: Update table footer with the visible rows Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) Bug 12955: The "show my funds only" should be take into account Bug 12844: FIX import package missing Bug 12844: Use Koha::Number::Price where it can be useful Bug 12844: Remove the C4::Output::FormatNumber subroutine Bug 12844: New module to manage prices into Koha Bug 12979: Fix error on layout3pagesfr Bug 12979: Price formatting should only be defined at one place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:10:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:10:30 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:10:31 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:12:14 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #40 from Jonathan Druart --- Just another try: https://git.biblibre.com/biblibre/kohac/commits/ft/bug_10363 wip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:12:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:12:53 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #54 from Katrin Fischer --- Hi Jesse, is this ready for testing? I was under the impression that you were still working out things - also I reported 2 issues in my last comment :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:18:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:18:48 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:19:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:19:20 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31694|0 |1 is obsolete| | Attachment #31902|0 |1 is obsolete| | --- Comment #78 from Katrin Fischer --- Created attachment 32171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32171&action=edit [PASSED QA] Bug 5342: Serial claiming improvements: add a counter This patch adds a new DB field serial.claims_count This field already exists for late orders. It makes sense to introduce it for serial. Test plan: 0/ a) Does not apply the patch. b) Remove all your claimissues notices and be sure you have some serial issues in late. c) remove email address for the vendor you will use. d) remove email address for the logged in user. e) Export claims using the csv export => The selected issues will be marked as claimed. f) logout/login (to update the email address). 1/ Apply the patch and execute the updatedb entry. 2/ Go on the Serials > Claims page 3/ Verify that you get a warning message 'No claimissue notice defined' 4/ Verify the vendor list is correct (with the number of serial in late. You should not get any changes here. 5/ Select one vendor and verify that the issue which was claimed before has a claim count set to 1. 6/ Verify that you are not able to send notification to the vendor. 7/ Create a claimissue notice. Something like: <> <> The following issues are in late: <>, <> (<>) 8/ Go on the Serials > Claims page, the warning message does not appear anymore. 9/ Select issues. Select a notice. And "Send notification". You should get an error (no email defined for this vendor). 10/ Add an email for the vendor. 11/ Select issues. Select a notice. And "Send notification". You should get an error (no email defined for your user). 12/ Add an email address to your user logout/login 13/ Select issues. Select a notice. And "Send notification". You should get a happy message: the email has been sent! 14/ The email will contain the order tags if bug 12851 is not pushed/applied. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Works as described, some small issues fixed in a follow-up. Note: If you change the email address of your staff user, you will have to log out and back in to make the change take effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:19:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:19:58 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 --- Comment #4 from Olli-Antti Kivilahti --- Thanks for signing this off Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:21:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:21:49 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #79 from Katrin Fischer --- Created attachment 32172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32172&action=edit [PASSED QA] Bug 5342: (qa-followup) FIX some issues this patch: - reintroduces the ISSN column - fix a wording (already there before the main patch) - fix the tests if a serial was already in late Signed-off-by: Katrin Fischer Small change: Removed 2 tabs in claims.tt and fixed order of ISSN/Issue number column descriptions as they were switched. Note: The tags are currently not stripped out of the notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:31:41 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #1 from Paul Poulain --- Created attachment 32173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32173&action=edit Bug 13068, updatedatabase improvement for developer process with this patch, the updatedatabase now checks info the db_update directory. If there is something here, it's executed. Note that there is no version update, so if you run the updatedatabase script twice, you'll get an sql error probably. This patch will be very useful for sandbox testing process. When the RM pushes a patch with something in db_update, he will have to copy it into updatedatabase.pl, give it a number, and remove the file in db_update Test plan: * apply the patch * create a files with a .sql extension in the db_update directory * run updatedatabase.pl * look at your database, what was in the .sql file must have been run -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:31:45 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #2 from Paul Poulain --- Created attachment 32174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32174&action=edit Bug 13068 sample This file is an example to test the patch. it must NOT BE PUSHED ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:32:19 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:34:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:34:43 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:37:25 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #3 from Paul Poulain --- Created attachment 32175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32175&action=edit Bug 13068 follow-up Removing 2 lines of dead code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:44:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:44:11 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31973|0 |1 is obsolete| | --- Comment #18 from Chris Cormack --- Created attachment 32176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32176&action=edit Bug 8133 - hourly loans doesn't know when library closed This adds support for storing library hours in the calendar, and using those hours to compute hourly loan duetimes. A large amount of cleanup was also performed to expunge duplication of code between C4::Calendar and Koha::Calendar. Test plan: 1) Apply patch. 2) Update database. 3) Verify that the calendar administration interface still exists and works as expected. 4) Run t/Calendar.t and t/db_dependent/Calendar.t. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:47:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:47:40 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32173|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher --- Created attachment 32177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32177&action=edit Bug 13068, updatedatabase improvement for developer process with this patch, the updatedatabase now checks info the db_update directory. If there is something here, it's executed. Note that there is no version update, so if you run the updatedatabase script twice, you'll get an sql error probably. This patch will be very useful for sandbox testing process. When the RM pushes a patch with something in db_update, he will have to copy it into updatedatabase.pl, give it a number, and remove the file in db_update Test plan: * apply the patch * create a files with a .sql extension in the db_update directory * run updatedatabase.pl * look at your database, what was in the .sql file must have been run Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:48:05 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #5 from Paul Poulain --- Side comment : the atomicupdate directory already exist, and could have been used. However, there is some code, that seems dead, but I don't want to introduce any regression. cleaning atomicupdate should be made in another patch if it's relevant. 2nd side comment : this patch does not address the case where the update must be made in a .pl file, because it's too complex. However, this case is very very rare, so this patch will fix 90% of the cases. The 10% remaining will not apply on sandboxes, but that's already a big improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:49:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:49:15 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32177|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher --- Created attachment 32178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32178&action=edit Bug 13068, updatedatabase improvement for developer process with this patch, the updatedatabase now checks info the db_update directory. If there is something here, it's executed. Note that there is no version update, so if you run the updatedatabase script twice, you'll get an sql error probably. This patch will be very useful for sandbox testing process. When the RM pushes a patch with something in db_update, he will have to copy it into updatedatabase.pl, give it a number, and remove the file in db_update Test plan: * apply the patch * create a files with a .sql extension in the db_update directory * run updatedatabase.pl * look at your database, what was in the .sql file must have been run Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:53:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:53:03 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32174|0 |1 is obsolete| | --- Comment #7 from Brendan Gallagher --- Created attachment 32179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32179&action=edit Bug 13068 sample This file is an example to test the patch. it must NOT BE PUSHED ! Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:54:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:54:45 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32175|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher --- Created attachment 32180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32180&action=edit Bug 13068 follow-up Removing 2 lines of dead code Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 17:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 15:55:03 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:00:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:00:26 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:23:05 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from Paola Rossi --- (In reply to Jonathan Druart from comment #40) > It should work. Please try refreshing completely (ctrl+r / ctrl+f5) your > cache. It has worked! Then I could change the actions. Thanks, Jonathan. I'm sorry, indeed there was another error. It occurred before adding templates [more generally, it occurred when no template exists]. It is not resolved by (ctrl+r / ctrl+f5). Firstly on Tools I've selected "Batch record modifications". Koha answered by writing [as expected, it's OK]: "No MARC modification template is defined. You have to create at least one template for using this tool." But the whole shown page was not OK: Koha has shown a sort a double page (in screen 1 there is the top of the shown page, in screen 2 there is the middle part of the whole "double" shown page). Under the "Quote editor" of "Additional tools" I saw the message (see screen 2): Status: 200 OK Set-Cookie: CGISESSID=023a87ce0c543bc9822811b2fe51b209; path=/; HttpOnly Date: Fri, 10 Oct 2014 15:24:25 GMT Pragma: no-cache Cache-control: no-cache Content-script-type: text/javascript Content-style-type: text/css Content-Type: text/html; charset=UTF-8 More below, beyond the message, another "Batch record modifications" page was shown; in front of the second part of the there are three search fields [instead of 1]. Then the whole double page ends with the [second] "Quote editor". I didn't get any JS error using Firebug on this "double" page. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:24:37 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #42 from Paola Rossi --- Created attachment 32181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32181&action=edit screen-1 screen-1: top of the "double" page shown by koha after having selected "Batch record modification" on Tools menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:25:29 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #43 from Paola Rossi --- Created attachment 32182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32182&action=edit screen-2 screen-2: middle part of the same "double" page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:27:47 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #2 from Owen Leonard --- This is an interesting bug... I had no idea this arbitrary limitation was in the code. Note the associated FIXME: # A couple heuristics to limit how many times # we query the database for item transfer information, sacrificing # accuracy in some cases for speed; # # 1. don't query if item has one of the other statuses # 2. don't check transit status if the bib has # more than 20 items # # FIXME: to avoid having the query the database like this, and to make # the in transit status count as unavailable for search limiting, # should map transit status to record indexed in Zebra. The problem with both the old way and the patched version of things is that something is happening which the user doesn't know anything about. You can pick an arbitrarily high number for MaxSearchResultsItemsPerRecordStatusCheck (that's a mouthful!) and rest assured that no inaccurate information will be displayed or you can set it to something else and take your chances. How does the librarian administrator know what value of MaxSearchResultsItemsPerRecordStatusCheck is reasonable? I'm interested in hearing why the solution proposed in the FIXME isn't the one which has been implemented. If the Zebra solution is not a good one, I think a better solution to this might just be to add a note which tells the user to click through to the detail page for accurate status information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:41:09 +0000 Subject: [Koha-bugs] [Bug 13069] New: Enable sort by title to ignore articles on circulation and patron detail pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Bug ID: 13069 Summary: Enable sort by title to ignore articles on circulation and patron detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: martin.renvoize at ptfs-europe.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:55:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:55:29 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:55:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:55:45 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:55:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:55:47 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 --- Comment #1 from Owen Leonard --- Created attachment 32183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32183&action=edit Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 18:59:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 16:59:49 +0000 Subject: [Koha-bugs] [Bug 13070] New: Managing staged MARC records, sorting by title should ignore articles Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Bug ID: 13070 Summary: Managing staged MARC records, sorting by title should ignore articles Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/manage-marc-import.pl?import_batch _id=X OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: martin.renvoize at ptfs-europe.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The new DataTables-enhanced display of staged MARC records should be modified so that sorting by title ignores articles. I thought the solution would be as simple as the one for Bug 13069, but when I try to add something similar to manage-marc-imports.tt it doesn't work (Line 38): - { "mDataProp": "citation" }, + { "mDataProp": "citation", "sType": "anti-the" }, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 20:21:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 18:21:30 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #44 from Jonathan Druart --- Created attachment 32184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32184&action=edit Bug 11395: exit should be done after displaying the output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 20:21:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 18:21:23 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 20:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 18:22:07 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #45 from Jonathan Druart --- (In reply to Paola Rossi from comment #41) Good catch! Should be fixed now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 20:34:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 18:34:48 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #9 from Paul Poulain --- Created attachment 32185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32185&action=edit Bug 13068 QA follow-up using the proper file handle to pass koha-qa.pl ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 20:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 18:47:08 +0000 Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31325|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 32186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32186&action=edit [SIGNED-OFF] Bug 12862: Staff client tweaks related to obsolete language="javascript" As a result, this patch removed the deprecated tag from the intranet templates. And since there was just 1 other tiny error in the same template file, the checked="checked" was removed from a text box. TEST PLAN --------- 1) Install the HTML Validator 0.9.5.8 for FireFox. 2) Open Intranet to Home -> Tools -> News 3) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 4) Click Edit beside one of the news items. 5) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 6) Apply patch 7) Repeat steps 2 to 5 without "language="javascript" related error messages. 8) Run koha QA test tools. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 10 20:47:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Oct 2014 18:47:15 +0000 Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31326|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 32187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32187&action=edit [SIGNED-OFF] Bug 12862: OPAC bootstrap - clean up language="javascript" There was a > [% END %] > +[% IF CoceProviders %] > + > +[% END %] This is OPAC prog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:17:47 +0000 Subject: [Koha-bugs] [Bug 3977] MARC21 Tag 321b In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3977 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:18:07 +0000 Subject: [Koha-bugs] [Bug 3977] MARC21 Tag 321b In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3977 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:19:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:19:06 +0000 Subject: [Koha-bugs] [Bug 12844] Introduce a centralized way to display prices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |enhancement --- Comment #38 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:19:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:19:21 +0000 Subject: [Koha-bugs] [Bug 12844] Introduce a centralized way to display prices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Tom?s Cohen Arazi --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:19:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:19:47 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:20:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:20:33 +0000 Subject: [Koha-bugs] [Bug 13080] Addition of noEnterSubmit class should not apply to textarea, only to input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:20:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:20:47 +0000 Subject: [Koha-bugs] [Bug 12651] DOM indexing should be the default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:21:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:21:05 +0000 Subject: [Koha-bugs] [Bug 13139] Move treeview jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13139 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:25:00 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31716|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 32797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32797&action=edit Bug-11068-Update-MARC21-es-ES-default-frameworks Rebased on top of 3977 This patch is too big for bugzilla/git-bz It's in compressed form, mostly for changes on sample frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:25:30 +0000 Subject: [Koha-bugs] [Bug 3977] MARC21 Tag 321b In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3977 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11068 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:25:30 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3977 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:37:51 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32797|0 |1 is obsolete| | CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 32798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32798&action=edit Bug-11068-Update-MARC21-es-ES-default-frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:37:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:37:59 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:46:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:46:13 +0000 Subject: [Koha-bugs] [Bug 13150] C4::Search::searchResults triggers software error by passing incorrect values to GetAuthorisedValueDesc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13150 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:49:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:49:16 +0000 Subject: [Koha-bugs] [Bug 13150] C4::Search::searchResults triggers software error by passing incorrect values to GetAuthorisedValueDesc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13150 --- Comment #1 from Kyle M Hall --- This was caused by memcached needing a restart on this particular server. However, this could be solved in the code with a bit more testing: diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 61e4c3b..17afeaf 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -1616,7 +1616,7 @@ sub GetAuthorisedValueDesc { if ( !$category ) { - return $value unless defined $tagslib->{$tag}->{$subfield}->{'authorised_value'}; + return $value unless $tagslib && defined $tagslib->{$tag}->{$subfield}->{'authorised_value'}; #---- branch if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches" ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 18:58:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 17:58:28 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I feel like the patch is not complete - all UsageStats* have the wrong field order. Testing a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 19:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 18:10:37 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 19:15:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 18:15:45 +0000 Subject: [Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email address for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #41 from Katrin Fischer --- Created attachment 32799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32799&action=edit Bug 9530: Follow-up - Fix t/db_dependent/Branch.t Tests need to learn about the new fields in the branches table. To test: prove t/db_dependent/Branch.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 19:22:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 18:22:45 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 19:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 18:32:09 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 --- Comment #5 from Katrin Fischer --- Created attachment 32800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32800&action=edit Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 19:33:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 18:33:06 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Katrin Fischer --- My new patch applies on top of Kivilahti's, fixing the other UsageStats* prefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 19:57:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 18:57:35 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:10:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:10:32 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32795|0 |1 is obsolete| | --- Comment #24 from Fr?d?ric Demians --- Created attachment 32801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32801&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:14:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:14:28 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32798|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:15:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:15:37 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 --- Comment #11 from Katrin Fischer --- Created attachment 32802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32802&action=edit [PASSED QA] Bug 11068 - big patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:27:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:27:14 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32792|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 32803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32803&action=edit [SIGNED-OFF] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:27:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:27:21 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32800|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 32804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32804&action=edit [SIGNED-OFF] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above Signed-off-by: Bernardo Gonzalez Kriegel Tested creating new database, then loading kohastructure and sysprefs.sql Without patch sysprefs fails to load, with patch loads Ok! No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:27:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:27:39 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:28:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:28:08 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:44:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:44:09 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 20:44:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 19:44:12 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32787|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 32805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32805&action=edit [PASSED QA] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton Signed-off-by: Frederic Demians Galen patch works as described. The way it's implemented seems sensible. Whatever the reason why a patron has guarantes, it make sense to display them. So it's better to check the count of guarantes rather than the current patron type to decide to display guarantes. Signed-off-by: Katrin Fischer Works as described, small change, no regressions found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:08:33 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #40 from Liz Rea --- no, thank YOU. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:09:52 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:10:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:10:02 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32783|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 32806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32806&action=edit [PASSED QA] Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, tested with de-DE. Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:10:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:10:32 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #4 from Katrin Fischer --- Created attachment 32807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32807&action=edit Bug 11593: Remove subtag_registry.txt This file is no longer needed by the web installer and can be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:11:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:11:25 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Bernardo, what do you think about removing the text file (see second patch)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:35:57 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32801|0 |1 is obsolete| | --- Comment #25 from Fr?d?ric Demians --- Created attachment 32808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32808&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:39:05 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #26 from Fr?d?ric Demians --- (In reply to M. Tompsett from comment #23) > Rather than add more parameters, why not modify the template to have: [%- > USE Koha -%] > And then use the plugin function to grab it directly. > Less modifications are good. :) I agree. Thanks for the tip. I wasn't aware if this Koha TT extension. I refactored the patch to use it. > ::: koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc > This is OPAC prog. Cleaned now. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:42:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:42:05 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #27 from M. Tompsett --- Comment on attachment 32808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32808 Bug 9580 Cover images from Coce, a remote image URL cache Review of attachment 32808: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=32808) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ +257,5 @@ > [% END %] > [% END %] > > + [% IF Koha.Preference('CoceProviders') %] > + [% IF ( SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn ) %] Split this into an IF/ELSIF/ELSE (http://template-toolkit.org/docs/manual/Directives.html#section_IF_UNLESS_ELSIF_ELSE) So that you can more plainly meet http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML @@ +258,5 @@ > [% END %] > > + [% IF Koha.Preference('CoceProviders') %] > + [% IF ( SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn ) %] > + Because this is hard to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:43:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:43:27 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #28 from M. Tompsett --- Comment on attachment 32808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32808 Bug 9580 Cover images from Coce, a remote image URL cache Review of attachment 32808: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=32808) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref @@ +344,5 @@ > + class: url > + - > + - Providers > + - pref: CoceProviders > + - 'separated by comma, for example: aws,gb. Leave empty not to activate this service.' If this saves in the systempreferences table, shouldn't there be updatedatabase.pl, systemprefs.sql update too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:48:47 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #29 from M. Tompsett --- Comment on attachment 32808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32808 Bug 9580 Cover images from Coce, a remote image URL cache Review of attachment 32808: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=32808) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +166,4 @@ > //]]> > > [% END %] > +[% IF CoceProviders %] CoceProviders isn't defined here, is it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:53:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:53:51 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Barton Chittenden --- I don't think that setting default permissions goes far enough -- this works when a new patron is added, but it doesn't help when permissions need to be added or changed across a group of existing patrons. Perhaps we need to introduce the concept of "role" that encompasses a group of permissions, which could be changed en-masse: borrower has a role patron category has a default role a role has many permissions a role may be based off a parent role (when the parent changes, all permissions not specified by the child will also change). This would allow some independence between patron categories and groups of permissions, while still allowing mass-insert and/or update of permissions as necessary. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 21:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 20:55:11 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32808|0 |1 is obsolete| | --- Comment #30 from Fr?d?ric Demians --- Created attachment 32809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32809&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:01:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:01:20 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #31 from Fr?d?ric Demians --- (In reply to M. Tompsett from comment #28) > If this saves in the systempreferences table, shouldn't there be > updatedatabase.pl, systemprefs.sql update too? I don't think so. No value are required at all. By default, nothing is stored in systempreferences table, and the functionality is just disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:17:56 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #32 from M. Tompsett --- (In reply to Fr?d?ric Demians from comment #31) > (In reply to M. Tompsett from comment #28) > > > If this saves in the systempreferences table, shouldn't there be > > updatedatabase.pl, systemprefs.sql update too? > > I don't think so. No value are required at all. By default, nothing is > stored in systempreferences table, and the functionality is just disabled. http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference I think you do. You are correct that it functions without it, but we should be explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:27:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:27:54 +0000 Subject: [Koha-bugs] [Bug 12830] Move the order-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:27:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:27:59 +0000 Subject: [Koha-bugs] [Bug 12830] Move the order-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31827|0 |1 is obsolete| | Attachment #31828|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 32810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32810&action=edit [PASSED QA] Bug 12830: Move the order-related code into Koha::Acquisition::Order The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Order module and put in it the code from NewOrder and NewOrderItem. Test plan: 1/ Create an order, modify it, receive it, cancel the receipt. 2/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:28:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:28:18 +0000 Subject: [Koha-bugs] [Bug 12830] Move the order-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:28:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:28:22 +0000 Subject: [Koha-bugs] [Bug 12830] Move the order-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830 --- Comment #25 from Katrin Fischer --- Created attachment 32811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32811&action=edit [PASSED QA] Bug 12830: use find instead of search Since ordernumber is the pk, it is stupid to use search. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer All acquisition related tests and the QA script pass. I can't find any regressions with these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:33:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:33:34 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #33 from M. Tompsett --- Oh, and Amazon preferences also seem to affect this. I get an Amazon cover image with the other system preferences, but not the Coce ones. Though, it isn't the "No cover image" like the others. :) Green Book of Language Revitalization in Practice (The) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 22:55:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 21:55:43 +0000 Subject: [Koha-bugs] [Bug 12829] 020z not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #6 from bondiurbano --- Please see "my" Bug 11653 - For tag "020" only subfields "a" is displayed in MARC XSLT OPAC's detail template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:08:55 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Hi Paola, I have tried working my way through the dependencies here, but I must be missing something. Can you still get this to apply? Or maybe you still have your testing branch and could take a look at the sequence you applied the patches in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:35:21 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #52 from Robin Sheat --- (In reply to Katrin Fischer from comment #51) > Adding Robin, because of comment #42: > > It looks like there is no package for Template::Plugin::JSON::Escape in > > Ubuntu <= 12.04. It's in wheezy and above: https://packages.debian.org/search?keywords=libtemplate-plugin-json-escape-perl&searchon=names&suite=all§ion=all That'll make it easy to backport... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:37:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:37:24 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- Leaving bread crumbs... from here, go to bug 12987. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:39:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:39:30 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- More bread crumbs - This can only be tested with another bug, so apply first bug 12984 and then bug 12989. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:43:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:43:00 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:43:10 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32094|0 |1 is obsolete| | Attachment #32095|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 32812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32812&action=edit [PASSED QA] Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) DataTables 1.10.2 is now available. The footerCallback function does not seem to work correctly with our current version. Test plan: Go on the maximum of pages where DataTables is used and try to catch a bug/regression :) Signed-off-by: Owen Leonard I tested many many pages with DataTables, taking special care to find pages with different DataTables configurations. I found no errors in the OPAC or staff client. Tested thoroughly in Firefox (latest) on Windows 7. Tested less thoroughly in Chrome (latest) on Windows 7. Tested briefly in Internet Explorer 7 in Vista and Internet Explorer 8 and found no bugs which were related to the DataTables upgrade. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:43:25 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #12 from Katrin Fischer --- Created attachment 32813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32813&action=edit [PASSED QA] Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:44:16 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32812|0 |1 is obsolete| | Attachment #32813|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 32814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32814&action=edit [PASSED QA] Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:44:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:44:43 +0000 Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #14 from Katrin Fischer --- Created attachment 32815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32815&action=edit [PASSED QA] Bug 12987: The new format_price include file should be include on using datatables Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:46:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:46:48 +0000 Subject: [Koha-bugs] [Bug 12984] Improvement of the funds list view - acqui home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 --- Comment #14 from Katrin Fischer --- I retested, it was the dependencies. Ready to pass QA on this now. My branch on master as of today looks like this: Bug 12989: Update table footer with the visible rows - acqui-home Bug 12984: Improvement of the funds list view - acqui home Bug 12987: The new format_price include file should be include o~ Bug 12987: Update table footer with the visible rows Bug 12986: Upgrade the DataTables jQuery plugin to the latest ve~ Bug 12844: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:47:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:47:25 +0000 Subject: [Koha-bugs] [Bug 12984] Improvement of the funds list view - acqui home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:47:28 +0000 Subject: [Koha-bugs] [Bug 12984] Improvement of the funds list view - acqui home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32147|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 32816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32816&action=edit [PASSED QA] Bug 12984: Improvement of the funds list view - acqui home Bug 11578 improved the funds list view in the administration module. It would be great to have the same improvement on the acquisition home page. This improvement groups funds by budget and displays them with a hierarchy. Test plan: 0/ Create a budget and fund hierarchy, with active and inactive budgets. 1/ Go on the acquisition home page and verify the values are the same as before 2/ Verify the funds are correctly listed 3/ Verify the links on top of table work (expand/collapse all, show/hide inactive budgets). Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:49:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:49:17 +0000 Subject: [Koha-bugs] [Bug 12849] Sending a list has malformed links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton --- Pushed to 3.16.x for inclusion in 3.16.5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:50:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:50:36 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:50:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:50:44 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32348|0 |1 is obsolete| | Attachment #32349|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 32817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32817&action=edit [PASSED QA] Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 27 23:52:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 22:52:14 +0000 Subject: [Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #8 from Katrin Fischer --- Created attachment 32818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32818&action=edit [PASSED QA] Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:04:10 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:04:13 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32346|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 32819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32819&action=edit [PASSED QA] Bug 12988: Update table footer with the visible rows - budgets On the budget list view, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: To test with both CurrencyFormat pref values. 1/ Go on the budget list view 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown 4/ Hide/Show inactive budgets and verify the totals are still corrects. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:08:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:08:16 +0000 Subject: [Koha-bugs] [Bug 12955] The budget list always shows my funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- My testing branch looked like this: Bug 12988: Update table footer with the~ Bug 12955: The "show my funds only" should be take into account Bug 12989: Fix JS error Bug 12989: Update table footer with the visible rows - acqui-home Bug 12984: Improvement of the funds list view - acqui home Bug 12987: The new format_price include file should be include on using... Bug 12987: Update table footer with the visible rows Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) Bug 12844: Force the symbol place in the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:21:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:21:46 +0000 Subject: [Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- My testing branch looked like this: Bug 12988: Update table footer with the... Bug 12955: The "show my funds only" should be take into account Bug 12989: Fix JS error Bug 12989: Update table footer with the visible rows - acqui-home Bug 12984: Improvement of the funds list view - acqui home Bug 12987: The new format_price include file should be include on using... Bug 12987: Update table footer with the visible rows Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) Bug 12844: Force the symbol place in the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:29:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:29:20 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #96 from David Cook --- Quick question. Is there a reason why we needed to add "facetNumRecs"? The speed already seemed pretty good. Even if it were a bit slower, I think I'd rather use all retrieved records than an arbitrary number of them :/. I suppose 1000 is pretty good, but if I click a facet, I want to know that I'm getting all the relevant records from a result set and not just the records that are from the first 1000 records. Of course, perhaps I'm being a bit ridiculous. If a person is getting over 1000 results, their search isn't very exact. But... sometimes you want to do a broad search then narrow it down using multiple facets :/. I suppose this is the kind of configuration that individual libraries could change on their own though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:36:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:36:21 +0000 Subject: [Koha-bugs] [Bug 12788] Refine search displays 4xx fields from authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12788 --- Comment #25 from Tom?s Cohen Arazi --- (In reply to mathieu saby from comment #24) > Do you know if the issue was also occuring for UNIMARC Koha? > > M. Saby It was also occuring to UNIMARC. Because the original code foreach my $field (@fields) { # If $field->indicator(1) eq 'z', it means it is a 'see from' # field introduced because of IncludeSeeFromInSearches, so skip it next if $field->indicator(1) eq 'z'; Applied to all fields no matter the flavour. The bug was introduced by me and happened in 3.16.0, with the patches for bug 11096. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:41:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:41:39 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #97 from M. Tompsett --- Actually, I haven't looked at the code, but David's comment does resonate with me. If I can retrieve all the facets, why would I limit them? Is there a significant speed difference at a particular number of facets? If I have to wait 20 seconds for all the facets, is that really so bad for a large search result? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 00:59:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Oct 2014 23:59:46 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #98 from Tom?s Cohen Arazi --- (In reply to David Cook from comment #96) > Quick question. Is there a reason why we needed to add "facetNumRecs"? Zebra defaults to 10 [1] (which is way too low) and I found no way to define a wildcard. Any ideas for improving this are welcome. [1] Line 902 of http://www.indexdata.com/zebra/dox/html/retrieve_8c_source.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 03:42:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 02:42:28 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #53 from Robin Sheat --- (In reply to Robin Sheat from comment #52) > It's in wheezy and above: > > https://packages.debian.org/search?keywords=libtemplate-plugin-json-escape- > perl&searchon=names&suite=all§ion=all > > That'll make it easy to backport... Famous last words, but it's in there now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 04:38:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 03:38:36 +0000 Subject: [Koha-bugs] [Bug 13112] Add name of template file in html comment for each '.tt' file. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13112 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- Tested on sandbox, works fine, signing off. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 04:48:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 03:48:20 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- Sent this error message when trying to test: fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt). Setting to 'patch does not apply' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 05:25:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 04:25:12 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- Sent this error message when trying to test: fatal: sha1 information is lacking or useless (C4/Search/History.pm). Setting to 'patch does not apply' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:04:46 +0000 Subject: [Koha-bugs] [Bug 13112] Add name of template file in html comment for each '.tt' file. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:04:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:04:49 +0000 Subject: [Koha-bugs] [Bug 13112] Add name of template file in html comment for each '.tt' file. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32545|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 32820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32820&action=edit [PASSED QA] Bug 13112 - Add name of template file in html comment for each '.tt' file. This patch adds the name of the .tt file as a HTML comment to OPAC and Staff client pages. To test: Apply patch Open pages in OPAC and Staff client. Make sure that a comment similar to the following appears in the source code: Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:07:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:07:08 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- There is a dependency on bug 1861 for this - Kyle, could you take a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:45:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:45:59 +0000 Subject: [Koha-bugs] [Bug 12958] Set a fund owner to its children In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #6 from Katrin Fischer --- Owen, could you take a look at the first = second GUI follow-up? I wonder if we should add a warning, that if the child funds already have an owner, this one will be overwritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:47:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:47:53 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #61 from Katrin Fischer --- Still working on this, will post comments tonight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:52:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:52:40 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #34 from Fr?d?ric Demians --- > http://wiki.koha-community.org/wiki/ > System_Preferences#Adding_a_new_system_preference > I think you do. You are correct that it functions without it, but we should > be explicit. I updated the wiki, accordingly with my thought on the subject. Feel free to disagree, and to revert my wiki update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 08:54:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 07:54:24 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #35 from Fr?d?ric Demians --- (In reply to M. Tompsett from comment #33) > Oh, and Amazon preferences also seem to affect this. > I get an Amazon cover image with the other system preferences, but not the > Coce ones. Though, it isn't the "No cover image" like the others. :) > Green Book of Language Revitalization in Practice (The) I don't understand. Do you mean, you have enabled simultaneously Koha OPACAmazonCoverImages syspref, and Coce sysprefs? You shouldn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 10:59:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 09:59:23 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 --- Comment #3 from Colin Campbell --- Should we not be using C4::Circulation::GetIssuingCharges to get the amount? This returns the rental fee but also calculates the discount if one is applicable, that step is omitted in this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 11:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 10:08:54 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Colin, thank you for taking a look. I think you are correct, it won't apply the correct rental charge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 12:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 11:31:43 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #16 from Paola Rossi --- (In reply to Katrin Fischer from comment #15) > Hi Paola, I have tried working my way through the dependencies here, but I > must be missing something. Can you still get this to apply? Or maybe you > still have your testing branch and could take a look at the sequence you > applied the patches in? Kind Katrin, I'm sorry, I'm not able to help you. I signed off on Sep the 19-th, against master 3.17.00.025, attaching to bugzilla an 0004* file. So I suppose I followed exactly the Jonathan's note of comment 10: >> Now bug 12830 depends on bug 12953. >>This one should apply correctly on top. Today [3.17.00.033] the patch 12953 (1) is already pushed to master, whilst the patch 12830 (2) not. So, applying against master, the two 12830 are OK, but this patch 12896 is not OK [as it should be expected after Sep 23-th]. This is the conflict: Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Acquisition/OrderFromSubscription.t CONFLICT (content): Merge conflict in t/db_dependent/Acquisition/OrderFromSubscription.t Auto-merging acqui/addorderiso2709.pl Failed to merge in the changes. Patch failed at 0001 Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller -------------------------------------------------------------------- The 5342's dependency was required later, on the 23-th. But I see conflict: 1) either applying 5342 soon after 12830, 2) or applying 12852/29-th [as Jonathan asked in comment 14] after 12830, 3) or applying 12852/PassedQA Oct 11 (after 12830 or without 12830) So I'm sorry, I can't help you. ---------------------------------------------- 5342's conflict after applying 12830: Applying: Bug 5342: Serial claiming improvements: add a counter Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: t/db_dependent/Serials/Claims.t Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 5342: Serial claiming improvements: add a counter ----------------------------- The conflict of the patch 12852, version of Sep, the 29-th, after applying 12830: Applying: Bug 12852: The "preview" param can be removed serials/claims.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging serials/claims.pl CONFLICT (content): Merge conflict in serials/claims.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt Failed to merge in the changes. Patch failed at 0001 Bug 12852: The "preview" param can be removed serials/claims.pl ====================================================================== -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:00:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:00:20 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard --- (In reply to Aleisha Amohia from comment #2) > fatal: sha1 information is lacking or useless That usually means you were missing a dependent patch: Did you apply the patch for Bug 13083 first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:01:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:01:05 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Owen Leonard --- (In reply to Aleisha Amohia from comment #3) > Sent this error message when trying to test: > fatal: sha1 information is lacking or useless (C4/Search/History.pm). Did you apply the patch for Bug 11430 first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:08:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:08:02 +0000 Subject: [Koha-bugs] [Bug 12958] Set a fund owner to its children In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12956, 12955 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:08:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:08:02 +0000 Subject: [Koha-bugs] [Bug 12956] Users are not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:08:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:08:02 +0000 Subject: [Koha-bugs] [Bug 12955] The budget list always shows my funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12955 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:26:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:26:27 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #17 from Katrin Fischer --- Hi Paola, thx for trying. I think we will have to wait for Jonathan then to help. I have QA'd some of the other patches and will if I can do more without this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:57:09 +0000 Subject: [Koha-bugs] [Bug 13152] New: Duplicate phone hold notices when using Talking Tech Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Bug ID: 13152 Summary: Duplicate phone hold notices when using Talking Tech Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 13:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 12:57:15 +0000 Subject: [Koha-bugs] [Bug 13152] Duplicate phone hold notices when using Talking Tech In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:00:38 +0000 Subject: [Koha-bugs] [Bug 13152] Duplicate phone hold notices when using Talking Tech In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:00:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:00:40 +0000 Subject: [Koha-bugs] [Bug 13152] Duplicate phone hold notices when using Talking Tech In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 --- Comment #1 from Kyle M Hall --- Created attachment 32821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32821&action=edit Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:04:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:04:16 +0000 Subject: [Koha-bugs] [Bug 12958] Set a fund owner to its children In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 --- Comment #7 from Owen Leonard --- Created attachment 32822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32822&action=edit Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy This alternate follow-up modifies the text of the label to (hopefully) make it more clear. The markup has been revised someone to make it more standard, and a warning has been added about overwriting existing data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:08:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:08:05 +0000 Subject: [Koha-bugs] [Bug 13152] Duplicate phone hold notices when using Talking Tech In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:09:36 +0000 Subject: [Koha-bugs] [Bug 13152] Duplicate phone hold notices when using Talking Tech In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32821|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 32823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32823&action=edit Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:18:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:18:01 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32803|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 32824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32824&action=edit [PASSED QA] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:18:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:18:14 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32804|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 32825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32825&action=edit [PASSED QA] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above Signed-off-by: Bernardo Gonzalez Kriegel Tested creating new database, then loading kohastructure and sysprefs.sql Without patch sysprefs fails to load, with patch loads Ok! No koha-qa errors Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:18:46 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:22:20 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Olli and Katrina -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:23:10 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #80 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! Note: a small fix added on rebasing so it applies, please review, just in case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:23:36 +0000 Subject: [Koha-bugs] [Bug 11990] Holds ratio report (circ/reserveratios.pl) sorts numeric values as text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:24:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:24:03 +0000 Subject: [Koha-bugs] [Bug 13083] Hard-coded " by " in opac-tags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13083 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:24:27 +0000 Subject: [Koha-bugs] [Bug 8837] Dewey cn_sort inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8837 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Simith and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:24:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:24:42 +0000 Subject: [Koha-bugs] [Bug 8837] Dewey cn_sort inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8837 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:24:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:24:57 +0000 Subject: [Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:25:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:25:15 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:25:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:25:16 +0000 Subject: [Koha-bugs] [Bug 13153] New: Waiting hold checked in at different library doesn't re-route item to correct library Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Bug ID: 13153 Summary: Waiting hold checked in at different library doesn't re-route item to correct library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It seems that if an item is triggered at a location as waiting for pickup, if that item falls into the hands of another library by mistake, Koha doesn?t know what to do with it. It just records a local use. It doesn?t try to transfer home or to the library it should be waiting at. Correct behavior should be that if it is scanned at another location other than where the system thinks it is, it should trigger a transfer to where it should be. Right now, the only way to get the item back on course is to go to the holds for that item and change the waiting to priority 1 again, and change any other priorities back one level, if any, and then check the item in again. To reproduce: 1) Place a hold on an item for a patron at LibraryA 2) Check the item in at LibraryA 3) Confirm the hold at LibraryA, the item is now a waiting hold 4) Set your logged in branch to LibraryB 5) Check the item in at LibraryB 6) Notice there is no request to transfer the item to LibraryA I think what should probably happen is the hold status should go from Waiting (W) to In Transit (T), and a transfer should be created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:25:30 +0000 Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:25:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:25:54 +0000 Subject: [Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email address for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #42 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:28:33 +0000 Subject: [Koha-bugs] [Bug 13154] New: The webinstaller should offer all available languages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13154 Bug ID: 13154 Summary: The webinstaller should offer all available languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The webinstaller should offer the end-user with all languages, and show some warning if the chosen one is not installed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:28:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:28:41 +0000 Subject: [Koha-bugs] [Bug 13154] The webinstaller should offer all available languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:41:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:41:08 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate Status|Passed QA |Patch doesn't apply --- Comment #91 from Katrin Fischer --- Julian, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:54:07 +0000 Subject: [Koha-bugs] [Bug 13129] HTML and JS escapes missing in unimarc_field_4XX.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13129 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:54:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:54:22 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:54:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:54:54 +0000 Subject: [Koha-bugs] [Bug 13112] Add name of template file in html comment for each '.tt' file. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13112 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Nice and simple enhancement Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:55:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:55:14 +0000 Subject: [Koha-bugs] [Bug 12573] blinddetail-biblio-search uses wrong comparidon operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12573 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 14:55:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 13:55:32 +0000 Subject: [Koha-bugs] [Bug 13095] An email will be sent shortly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:04:10 +0000 Subject: [Koha-bugs] [Bug 12281] RTL display for records using 880 broken in Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12281 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31741|0 |1 is obsolete| | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:13:34 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32786|0 |1 is obsolete| | --- Comment #82 from Olli-Antti Kivilahti --- Created attachment 32826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32826&action=edit Bug 8367 - How long is a hold waiting for pickup at a more granular level You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. The lastpickupdate-column is set based on the given instruction and lands only on an open library day. Also cancel_expired_reserves.pl now cancels only on open library days after the last pickup date has expired. And waitingreserves.pl respects the new DB column. This patch adds: - a new column in the issuing rules, including help topics. - a new column reserves.lastpickupdate (+old_reserves) It contains the waitingdate + the corresponding "holds pickup wait". Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupwait - a new function C4::Reserves::MoveWaitingdate() to help in testing this feature. - a new function C4::Reserves::GetLastPickupDate() to calculate the proper date from Calendar. This patch removes: - the ReservesMaxPickUpDelay syspref. - the ExpireReservesOnHolidays syspref, because it became obsolete due to the changes in handling the last pickup date with Koha Calendar. - Also removes a code section from C4::Letters::_parseLetter() which worked blatantly disrespectfully towards Koha Calendar. - TODO put the <> as a placeholder in C4::Letters. - TODO figure out how to rename existing letter placeholders <> with <> TODO Refactoring unit tests is in progress. $$$$$$$$$$$$$ $ TEST PLAN $ $$$$$$$$$$$$$ ****** ****** *** *** *** TEST: BASIC WORKFLOW * ****** ****** 1. Check there is no regression with a normal reserve workflow. 2. Add one or more issuingrules. 3. Update the new column 'Holds pickup wait' in your issuing rules. 4. In 4 templates, you can see the 'Last pickup date' for an hold (circ/circulation.tt, circ/waitingreserves.tt, members/moremember.tt, opac-user.tt). 5. According to a library and an item type, the lastpickupdate value will be equal to the waiting date + the "holds pickup wait" defined. ** ** ** ** ** ** *** *** *** TEST: RESPECTING CALENDAR HOLIDAYS * ** ** ** ** ** ** 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a single, unrepeated, holiday. Then make the next day a weekly repeating holiday. Then make the next two days an annual holiday repeatable every year. 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be increased by four days. ** ** ** ** ** ** *** *** *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION * ** ** ** ** ** ** 1. Modify the HOLD-letter, add <> and <> somewhere. 2. Catch a hold for a borrower. 3. See the members/notices.pl for the message queued and verify that the lastpickupdate-placeholder is set in your desired datetime format and that it is not on a holiday. Verify that the waitingdate is today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:14:05 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:14:21 +0000 Subject: [Koha-bugs] [Bug 12281] RTL display for records using 880 broken in Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12281 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:14:45 +0000 Subject: [Koha-bugs] [Bug 12830] Move the order-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Keep the good work Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:17:19 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #22 from Katrin Fischer --- Thx Bernardo! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:45:04 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #7 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #5) > Bernardo, what do you think about removing the text file (see second patch)? It's only a description, could be removed... and it's already done :) I will rework Bug 12250 and complete missing language descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:45:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:45:16 +0000 Subject: [Koha-bugs] [Bug 12250] Add Kurdish language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:47:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32591|0 |1 is obsolete| | Attachment #32592|0 |1 is obsolete| | Attachment #32593|0 |1 is obsolete| | Attachment #32594|0 |1 is obsolete| | Attachment #32595|0 |1 is obsolete| | Attachment #32596|0 |1 is obsolete| | Attachment #32597|0 |1 is obsolete| | Attachment #32598|0 |1 is obsolete| | Attachment #32599|0 |1 is obsolete| | Attachment #32600|0 |1 is obsolete| | Attachment #32601|0 |1 is obsolete| | Attachment #32602|0 |1 is obsolete| | --- Comment #547 from Kyle M Hall --- Created attachment 32827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32827&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:47:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:47:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #548 from Kyle M Hall --- Created attachment 32828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32828&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:47:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #549 from Kyle M Hall --- Created attachment 32829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32829&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:47:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #550 from Kyle M Hall --- Created attachment 32830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32830&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:47:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:47:46 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #551 from Kyle M Hall --- Created attachment 32831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32831&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:47:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:47:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #552 from Kyle M Hall --- Created attachment 32832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32832&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:06 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #553 from Kyle M Hall --- Created attachment 32833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32833&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:15 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #554 from Kyle M Hall --- Created attachment 32834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32834&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #555 from Kyle M Hall --- Created attachment 32835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32835&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #556 from Kyle M Hall --- Created attachment 32836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32836&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:38 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #557 from Kyle M Hall --- Created attachment 32837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32837&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:46 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #558 from Kyle M Hall --- Created attachment 32838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32838&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:48:55 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32784|0 |1 is obsolete| | --- Comment #27 from M. de Rooy --- Created attachment 32839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32839&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:49:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:49:01 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32785|0 |1 is obsolete| | --- Comment #28 from M. de Rooy --- Created attachment 32840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32840&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with pref DevUpdateControl: [1] DevUpdateControl= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] DevUpdateControl= RESET: Reinstall dev updates after an official db rev. [3] DevUpdateControl= ALWAYS: Run the dev updates at each upgrade. [4] DevUpdateControl=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: If the pref does not exist or is empty, we fall back to PROD (safest). If the pref differs from PROD, ALWAYS or TRACK, it falls back to RESET. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of DevUpdateControl (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:49:58 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- We believe this is a major cause for stalled items, and why items end up missing or on the shelves at other libraries. This would be a very good bug to fix. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:52:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:52:29 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #29 from M. de Rooy --- Rebased again. Made trivial change to make it less 'rebase prone'. Moved some comments for the RM from updatedatabase to the commit message. Removed one print message. Added test plans to the last two counterpatches. Paul: Would you agree to reset the status of this report and obsolete some patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:56:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:56:08 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32294|0 |1 is obsolete| | --- Comment #30 from M. de Rooy --- Created attachment 32841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32841&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:56:12 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32839|0 |1 is obsolete| | --- Comment #31 from M. de Rooy --- Created attachment 32842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32842&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 15:56:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 14:56:16 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32840|0 |1 is obsolete| | --- Comment #32 from M. de Rooy --- Created attachment 32843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32843&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with pref DevUpdateControl: [1] DevUpdateControl= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] DevUpdateControl= RESET: Reinstall dev updates after an official db rev. [3] DevUpdateControl= ALWAYS: Run the dev updates at each upgrade. [4] DevUpdateControl=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: If the pref does not exist or is empty, we fall back to PROD (safest). If the pref differs from PROD, ALWAYS or TRACK, it falls back to RESET. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of DevUpdateControl (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 16:07:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 15:07:25 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #8 from Katrin Fischer --- Tomas was fast :) Hope you don't mind! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 16:09:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 15:09:01 +0000 Subject: [Koha-bugs] [Bug 13088] Allow the user to specify a max amount of facets to show. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 32844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32844&action=edit Bug 13088: (RM followup) add missing pref mock Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 16:14:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 15:14:15 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #44 from Tom?s Cohen Arazi --- Mathieu, I tried to email you but it bounced. Your patches seem to affect MARC21 (and probably NORMARC) search behaviour. I think it is because you removed: Subject 1=21 su Subject -su-to Subject and probably because you only patched the UNIMARC biblio-koha-indexdefs.xml file. I'm reverting it, but I want it pushed again soon. So, please take a look at the output of this with your patches applied: prove t/db_dependent/QueryParser.t t/db_dependent/Search.t to find out. I think this kind of problem is one of the reasons we need better regression tests, lacking a lot in UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 16:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 15:14:22 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 16:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 15:15:21 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 28 16:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Oct 2014 15:15:24 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #24 from Owen Leonard --- Created attachment 32845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32845&action=edit Bug 12403 [Follow-up] Batch record deletion This follow-up makes several changes to language and markup with one change in behavior: - Updated permission description to avoid the use of the term "biblio" - Updated batch delete template to avoid the use of the term "biblio" and to improve clarity. - Replaced instances of terms "issue" and "reserve" with "checkout" and "hold" respectively. - On bibliographic record batch delete, wrap biblionumber in