[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #14 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Created attachment 31623 [details] [review] [review]
> 
> Rolando and Colin, could it be possible to get your point of view on this
> patch please?

(In reply to Rolando Isidoro from comment #13)
> Hey Johnathan, your patch complexity and range greatly exceeds my knowledge
> of Koha's source code. Colin, what's your take on this?
> 
> Rolando

This changes behaviour in an undocumented way if I pass a tz other than
C4::Context's it seems in some strings (need more test cases) to be changing to
the system tz but not correctly converting the date ... It also adds processing
to a frequently used routine which is not efficient e.g. the evals are
unnecessary if anything failes the date parse returns undef flagging the error.

I'll try testing some more inputs to this

-- 
You are receiving this mail because:
You are watching all bug changes.