[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

--- Comment #3 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to lightpurpledye from comment #2)
> This problem goes away if you comment out lines 152 - 159 of
> /usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif
> ($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images')
> {" ).
> 
> However, doing this also breaks the display of any "Other Image"s
> (non-patron photo images) on the card layout.
> 

The file in question is create-pdf.pl

Your test indicates that at least on your system there may be patron images
stored where "creator_images" should be. This entire block of code
(PROCESS_IMAGES [1]) is prefaced on layout xml like this:

  <images name="image_1" Dx="139.4" Ox="0" Oy="0" Sx="0" Sy="0" Tx="0" Ty="0">
    <data_source image_name="Temp Card Front PNG" image_source="creator_images"
/>
  </images>

It looks at the data_source key in particular for the "source" of the image.
"creator_images" are stored in a table by the same name in the db. This is a
different source than patron images which are stored in the patronimage table.

The fact that commenting out the condition which allows for retrieval of
creator_images "fixes" the problem would seem to indicate a misunderstanding of
what images should be stored where. An image stored in the creator_images table
and used in a patroncard layout will appear on every card in any batch using
that layout. Images stored in the patronimage table will (should) appear only
on cards which include that patron.

I have not had time to try this bug out, but what you describe seems to be more
related to misunderstanding what images should be stored where. Hopefully that
clarifies things a bit. If I've not understood, feel free to let me know.

[1] http://tinyurl.com/kfh5vbn

-- 
You are receiving this mail because:
You are watching all bug changes.