[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #4)
> - "result" and "columns" should be _result and _columns to avoid collisions
> later, don't you think?

Done!

> - Are you sure it is useful to test if the row is stored and has been
> changed (Store method)? Not sure about the perf, maybe DBIC does that (?).

DBIC does indeed do that already. In fact, DBIC will only update changed
columns and skipped those that are unchanged.

> - IsStored should be InStorage or completely removed, if useless.

Changed to InStorage

> - Delete could call delete in an eval, to avoid a call to in_storage

This one I did not implement, in_storage is really just a property to I believe
it is quicker than using eval. We can always run some tests to see which is
really faster.

> - what about 2 constructors? new and new_from_rs? The ResultSet should not
> be create if not used later

Done!

> - what about a _result method? It would return ->{_result} if already
> exists, otherwise create it. All occurrences to ->{result} will be replaced
> by ->_result

Done! Also done for _columns as well since it depends on _result

-- 
You are receiving this mail because:
You are watching all bug changes.