[Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Paola Rossi <paola.rossi at cineca.it> ---
(In reply to Jonathan Druart from comment #7)
> Thanks for the screenshot, very useful!
> I added a patch on bug 12987, it should fix your issue.

Thanks, Jonathan. I've applied the added patch, and now the error of comment 3
is fixed.

I've two further questions for you, and for now I pass the patch (this one) to
"Failed QA" status (see A) point below).
[In case I've passed the erroneous patch, by your kind suggestion I'll soon
rectify and make the right changes). 
In case of no problem, you can easily back 12988 to NSO, please, [and I'll sign
off the patch; perhaps all the 12986, 12987, 12988, 12989].

---------------------------------------------------------------------------
On MASTER:

on Funds the "Library" filter on the left lists only two values:
- none [for ALL the libraries]
- the library which has been set as the current one (f.i. Centerville).

As you certainly know, the second option doesn't work: all the funds are shown
the same (MASTER-ERROR-1), even if none of them is linked to the selected
current library. 

I've selected exactly such a current library, to which none funds have been
linked.
So all the funds have been shown. Moreover, their values have been formatted so
(MASTER-ERROR-2 in showing):
2000
147.6
147.609
Totals are made of zeros here, as we know.
We're on master here, so nothing is worth until now.
----------------------------------------------------
After having applied the patches:

Now I've applied:
12986, 12987 (3), 12955, 12988, 12984, 12989 (2)

The Library's filter on the left of Funds page has listed all the libraries
instead of only the current one.

A) Is this enhancement in "Library" filter desired on funds' page? Or is it an 
ERROR-0?

Perhaps it is desired.
After applying the patches those MASTER-ERROR-1 and MASTER-ERROR-2 have been
kept, as you can easily imagine. 
But moreover now the applied patches have shown the totals on funds' page, and
I've seen this kind of ERROR-3 in summing (no matter US or FR):
in "Total ordered" column:
5 + 147.6 = 14.81 instead of 152.6
in "Base-level allocated" column:
100000.000000+100000.000000=2,000,000,000.00 instead of 200,000.00

just as no point, and then 2 decimal everywhere.

B) Should those summing errors have been prevented by the patches? 
Are those badly formatted values usual? are they possible, created by filtering
or by some other way, and so must the patches take them into accout?
---------------------------------------------------------------------------

-- 
You are receiving this mail because:
You are watching all bug changes.