[Koha-bugs] [Bug 13049] New: Improve self-registration cronjobs

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

            Bug ID: 13049
           Summary: Improve self-registration cronjobs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

There are two small cronjobs for self-registration:
delete_expired_opac_registrations.pl and
delete_unverified_opac_registrations.pl

The expired job is meant to delete from borrowers when the patron category is
equal to PatronSelfRegistrationDefaultCategory and date enrolled past
PatronSelfRegistrationExpireTemporaryAccountsDelay. (See also bug 11945.) It
seems to me that this behavior is unexpected since the pref descriptions do not
suggest that the default category is temporary.
Perhaps, it was meant to add some verification step into the process when you
do not use the email verification triggered by pref
PatronSelfRegistrationVerifyByEmail.

The unverified job is meant to delete from borrower_modifications and uses a
time parameter (defaulting to 24 hours) to find unverified entries. It seems to
me that it should use the PatronSelfRegistrationExpireTemporaryAccountsDelay
preference. (Read its description.)

I propose the following changes:
[1] Move these actions to cleanupdatabase. Do they really need two separate
scripts?
[2] Rename the Delay preference. Name and description conflict now. We could
make name and description cover both cases: (a) verify is on and still
unverified and (b) verify is off and still in the initial category.
[3] Trigger the borrowers/category delete only if Verify is off and the renamed
delay has been past.

-- 
You are receiving this mail because:
You are watching all bug changes.