[Koha-bugs] [Bug 12993] Add a default tax rate on item types

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Paola Rossi <paola.rossi at cineca.it> ---
Hi, Jonathan. My results didn't match your observations in comment 6, so I've
made some further tests.

I've applied the patches.

On ADMIN in "Item Types" I set "Tax rate" of Book to 5%

On ADMIN I set the system pref gist to: 
0.10|0|0.05|0.23  [As ADMIN says: "First is the default."]

The vendor was configured 0-0, and his tax rate was set to 23%.

[I kept the system pref "AcqCreateItem" to default value "placing an order".]

The patches worked perfectly well in these 4 cases:
A) ordering from an existing record:
On a BK biblio record I _immediately_ saw 5% in the tax rate of the "Accounting
details" in the "New order" page (RIGHT just as required, I think). 
And, on a biblio record with none itemtype, I _immediately_ saw 23% there
(RIGHT, I also think)
B) ordering from a subscription
C) ordering from a staged file:
the neworderempty.pl script is used by way of the link "Add order", at the
right of the uploaded-and-staged-file's titles, in the tag "Select to import"
under "Add orders from (name of my file)"
D) ordering from titles with highest hold ratios.

Ordering from a BK suggestion [or from an empty record] I've seen 23% in the
tax rate of the order: it's the vendor' tax rate, instead of the expected tax
rate 5% of the BK' itemtype (ERROR).

Where have I been wrong, please? Did I forget anything?

I beg your pardon, but I should pass the patch to "Failed QA" status for now.

[Perhaps is there anything missing in the patches? there is nothing about
neworderempty.pl, I see]

I've a lot of doubts.

Note that a suggestion has no corresponding biblio record in the DB until it
has been ordered. So I ask myself how the neworderempty.pl script can find an
"itemtype at the biblio level" ordering from a suggestion. [Anyway, I didn't
find a way in koha to create a suggestion together with a biblio record:
neither from ACQ nor from OPAC]. I'm in doubt: are we into the test for 12993
or not?

Moreover, the order had shown the suggestion' price very well in "Accounting
details"! If we're into the 12993 test, couldn't the suggestion's itemtype have
been read by the same way? It's not a biblio level' itemtype, as you required, 
but it seems to me being no other way to have an itemtype for a BK suggestion.

In case, I invite you to let me know the steps of your test on suggestion,
please.

------------------------------------------------------------

-- 
You are receiving this mail because:
You are watching all bug changes.