[Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 10 21:44:51 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32100|0                           |1
        is obsolete|                            |

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 32199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32199&action=edit
Bug 10126: Remove my variables at module level

In C4::Reports::Guided, a lot of variables was defined at module level
and reused in subroutine.

I didn't find any problem with Plack, so I'm not sure this patch is
useful.

Test plan:
Verify there is no more ^my in the module and you don't find any
regression with the guided reports tools (with and without Plack)

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

I'm unsure if this is needed, but I have verified it causes no
regressions

Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list