[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to M. de Rooy from comment #12)
> Paul,
> I favor your approach to this problem. But I see some problems:
> [1] You read sql files line by line. I would use the installer.
+1000 ! I was uncomfortable with the line by line reading, using the installer
is much better !

> [2] I would like to run perl files too. (Or print from a text file.)
there are only a few updates that requires perl, so I thought it could be a
later enhancement. But i've nothing against an immediate one ;-)


> [3] Running it several times may/will cause problems or at least generate
> lots of warnings.
yep, but does not seemed a problem to me as it was for developer only.

> [4] You use a new folder; but we already have atomicupdates. See my cleanup
> patch.
+1 for the cleanup patch. Can you tell me what you made to be sure those files
can be removed safely ? I tried, but was not sure of avoiging a side effect.
Thus my use of another directory.

> [5] There is slightly more hand work for the RM that pushes a db rev.
Yep, but so much improvement for sandboxes and daily developer life... (and
Tomas told me it was fine)

> With these points in mind, I am attaching a counter patch based on your idea.
> Appreciate any feedback.
My main comment with your patch is the workflow.
ON A DEV INSTALL :
 * dev submit a patch with a db update. On 1st run, the update is applied. On
the next ones, it is not, because it's in the syspref
 * the patch is signed-off / qa-ed, puched (and get a number)
 * on the next run, the patch will be applied and an error thrown (but not a
problem according to me, because it's a dev install) The syspref is cleaned
(which is OK. A potential side-effect can happen, in case the developer has
applied 2 patches, one that has been pushed, one that hasn't. But that would
just throw a sql error, which is fine, because it's a dev setup)

ON A PROD SERVER :
 * sysop update Koha
 * on 1st run, the update is applied, the version is update, syspref untouched
=> no change in the behaviour.

If I'm right, then I'm fine with this behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.