[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Oct 14 20:25:59 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075
M. Tompsett <mtompset at hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #32282|0 |1
is obsolete| |
--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 32326
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32326&action=edit
Bug 13075 - Silence warnings and improve Charset testing.
Calls to C4/Charset.pm's NormalizeString function with an
undefined string were triggering warnings when running:
prove -v t/db_dependent/Holds.t
Sadly, t/Charset.t was also lacking calls to NormalizeString.
TEST PLAN
---------
1) prove -v t/db_dependent/Holds.t
-- This should generate the uninitialized string warnings.
Make sure CPL and MPL are in your branches to save
yourself from headaches due to expected data.
2) cat t/Charset.t
-- note there are no function calls to NormalizeString.
You can see other shortfalls in the tests beyond
NormalizeString with: grep ^sub C4/Charset.pm
3) prove -v t/Charset.t
4) Apply patch
5) prove -v t/Charset.t
-- Run as before with more tests.
6) cat t/Charset.t
-- note there are now function calls to NormalizeString.
7) prove -v t/db_dependent/Holds.t
-- Nice and clean run! :)
8) koha-qa.pl -v 2 -c 1
-- all should be Ok.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list