[Koha-bugs] [Bug 11401] Add support for Norwegian national library card

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Magnus Enger from comment #13)
> (In reply to Chris Cormack from comment #8)
> > The only suggestion I have is that we could perhaps use
> > Module::Load::Conditional
> > in C4/Members.pm, so that we don't have to load the module unless we need it.
> 
> Something like 
> 
>   use Module::Load::Conditional qw( can_load );
>   can_load( modules => { 'Koha::NorwegianPatronDB qw( NLUpdateHashedPIN
> NLEncryptPIN NLSync )' => undef } );
> 
> instead of plain old 
> 
>   use Koha::NorwegianPatronDB qw( NLUpdateHashedPIN NLEncryptPIN NLSync );
> 
> ?

Yep except wrap it in an if

if (syspref is set) {
  can_load ....
}

eg in Koha::QueryParser::Driver::PQF we do
if ( $format eq 'json' && can_load( modules => { 'JSON' => undef } ) ) {

Hope this helps

-- 
You are receiving this mail because:
You are watching all bug changes.