[Koha-bugs] [Bug 8446] Shibboleth authentication patch

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #117 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 32369
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32369&action=edit
BUG8446, Follow up: Refactor to clean up bad practice

- A number of issues were highlighted whilst writing sensible unit tests
  for this module.
  - Removed unnessesary call to context->new();
  - Global variables are BAD!
  - Croaking is a wimps way out, we should handle errors early and
    properly.

Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.